[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added a comment. In D66324#2395230 , @haowei wrote: > In D66324#2394687 , @lebedev.ri > wrote: > >> In D66324#2336555 , @lebedev.ri >> wrote: >> >>> In D66324#23

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis added a comment. In D91037#2391915 , @aaron.ballman wrote: > LGTM! Thanks! I'll see what can be done to deal with it in a separate commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rG4364539b3a4c: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on… (authored by zinovy.nis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037

[clang-tools-extra] 4364539 - [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

Author: Zinovy Nis Date: 2020-11-14T08:35:21+03:00 New Revision: 4364539b3a4c5e73561e5ff29e6952a75e89dc43 URL: https://github.com/llvm/llvm-project/commit/4364539b3a4c5e73561e5ff29e6952a75e89dc43 DIFF: https://github.com/llvm/llvm-project/commit/4364539b3a4c5e73561e5ff29e6952a75e89dc43.diff LO

[PATCH] D84293: Add an assertion in SmallVector::push_back()

mehdi_amini added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10811-10813 +Ops.reserve(Ops.size() + 1); Ops.push_back(Ops[0]); Ops.erase(Ops.begin()); njames93 wrote: > Probably a little off topic, but shouldn't this be refactored a

[PATCH] D84293: Add an assertion in SmallVector::push_back()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c196bbc6bd8: Add an assertion in SmallVector::push_back() (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D84293?vs=

[clang] 42e88bd - Replace sequences of v.push_back(v[i]); v.erase(&v[i]); with std::rotate (NFC)

Author: Mehdi Amini Date: 2020-11-14T00:55:33Z New Revision: 42e88bd6b18597fe0a46ee9663d4e2cf2f7a4e57 URL: https://github.com/llvm/llvm-project/commit/42e88bd6b18597fe0a46ee9663d4e2cf2f7a4e57 DIFF: https://github.com/llvm/llvm-project/commit/42e88bd6b18597fe0a46ee9663d4e2cf2f7a4e57.diff LOG: R

[PATCH] D84293: Add an assertion in SmallVector::push_back()

njames93 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10811-10813 +Ops.reserve(Ops.size() + 1); Ops.push_back(Ops[0]); Ops.erase(Ops.begin()); Probably a little off topic, but shouldn't this be refactored as a rotate. Has the

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

pcc added a comment. How does Zircon handle tagged addresses in syscalls? Are they handled equivalently to Linux's tagged address ABI? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91466/new/ https://reviews.llvm.org/D91466 __

[PATCH] D84293: Add an assertion in SmallVector::push_back()

mehdi_amini updated this revision to Diff 305279. mehdi_amini added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix one clang instance failing this assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84293/n

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

thegameg accepted this revision. thegameg added a comment. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91417/new/ https://reviews.llvm.org/D91417 ___ cfe-commits mailing list cfe-co

[PATCH] D91389: [MemProf][NewPM] Make memprof passes required

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52f05fb2c2c3: [MemProf][NewPM] Make memprof passes required (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D91389?vs=30

[clang] 52f05fb - [MemProf][NewPM] Make memprof passes required

Author: Arthur Eubanks Date: 2020-11-13T15:15:27-08:00 New Revision: 52f05fb2c2c30d12238f7e4ce3f3a4f849c40972 URL: https://github.com/llvm/llvm-project/commit/52f05fb2c2c30d12238f7e4ce3f3a4f849c40972 DIFF: https://github.com/llvm/llvm-project/commit/52f05fb2c2c30d12238f7e4ce3f3a4f849c40972.diff

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

haowei added a comment. In D66324#2394687 , @lebedev.ri wrote: > In D66324#2336555 , @lebedev.ri > wrote: > >> In D66324#2336186 , @phosek wrote: >> >>> I apologize for the

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added projects: Sanitizers, clang. Herald added subscribers: Sanitizers, mgorny. leonardchan requested review of this revision. This tracks all the compiler/llvm changes needed for building Fuchsia with t

[PATCH] D91389: [MemProf][NewPM] Make memprof passes required

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91389/new/ https://reviews.llvm.org/D91389 ___

[PATCH] D91295: Frontend: Remove unused parameter from ASTUnit::LoadFromCompilerInvocationAction, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfde3edeae47: Frontend: Remove unused parameter from ASTUnit… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] cfde3ed - Frontend: Remove unused parameter from ASTUnit::LoadFromCompilerInvocationAction, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-13T17:47:17-05:00 New Revision: cfde3edeae4730aa44642c4835bcfa5a857ea8d4 URL: https://github.com/llvm/llvm-project/commit/cfde3edeae4730aa44642c4835bcfa5a857ea8d4 DIFF: https://github.com/llvm/llvm-project/commit/cfde3edeae4730aa44642c4835bcfa5a857e

[clang] b09154e - [CMake] Explicity set up RPATH for the runtime libs on Win to ARM Linux cross builds.

Author: Vladimir Vereschaka Date: 2020-11-13T14:32:35-08:00 New Revision: b09154ebf95f3120414487ff7388e77393eb58c2 URL: https://github.com/llvm/llvm-project/commit/b09154ebf95f3120414487ff7388e77393eb58c2 DIFF: https://github.com/llvm/llvm-project/commit/b09154ebf95f3120414487ff7388e77393eb58c2

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1267 assert(!isa(constant)); - emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant); + emitStoresForConstant(CGM, D, Loc, isVolatile, Builder, constant, true); } Nit: `/*

[PATCH] D91417: [IRGen] Add !annotation metadata for auto-init stores.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. I think this looks reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91417/new/ https://reviews.llvm.org/D91417 ___

[PATCH] D91385: [DFSan][NewPM] Handle dfsan under NPM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e098189db7d: [DFSan][NewPM] Handle dfsan under NPM (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 6e09818 - [DFSan][NewPM] Handle dfsan under NPM

Author: Arthur Eubanks Date: 2020-11-13T13:41:38-08:00 New Revision: 6e098189db7da11bc9c32dd483cd81765804c241 URL: https://github.com/llvm/llvm-project/commit/6e098189db7da11bc9c32dd483cd81765804c241 DIFF: https://github.com/llvm/llvm-project/commit/6e098189db7da11bc9c32dd483cd81765804c241.diff

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao marked 3 inline comments as done. hliao added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:227 + Optional getAssumedAddrSpace(const Value *V) const { +return getTLI()->getTargetMachine().getAssumedAddrSpace(V); arsenm wrote:

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao updated this revision to Diff 305250. hliao marked an inline comment as done. hliao added a comment. Revise the interface of that target hook. Add a dedicated test case for value reading from parameter even though most cases are already covered in the clang test. Repository: rG LLVM Git

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2f2c2f3a463: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] a2f2c2f - Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-13T16:23:04-05:00 New Revision: a2f2c2f3a46351bc5478acd290258d318af2cd88 URL: https://github.com/llvm/llvm-project/commit/a2f2c2f3a46351bc5478acd290258d318af2cd88 DIFF: https://github.com/llvm/llvm-project/commit/a2f2c2f3a46351bc5478acd290258d318af2

[PATCH] D87928: Provide -fsource-dir flag in Clang

dexonsmith added reviewers: Bigcheese, jansvoboda11, arphaman. dexonsmith added a comment. I missed this before, and it's an interesting problem. I have a few questions: - I'm not clear on the expected interaction between the current working directory of the compiler and `-fsource-dir`. What ha

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu created this revision. jasonliu added reviewers: xingxue, hubert.reinterpretcast, cebowleratibm, DiggerLin, daltenty. Herald added subscribers: llvm-commits, kbarton, hiraditya, mgorny, nemanjai. Herald added a project: LLVM. jasonliu requested review of this revision. Herald added a subs

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

arsenm added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:227 + Optional getAssumedAddrSpace(const Value *V) const { +return getTLI()->getTargetMachine().getAssumedAddrSpace(V); hliao wrote: > hliao wrote: > > arsenm wrote: > > > W

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

wchilders added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1762 }; +using FDK = FunctionDefinitionKind; wchilders wrote: > aaron.ballman wrote: > > rsmith wrote: > > > I don't think it's OK to have an initialism like this in the `clang`

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

wchilders added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1762 }; +using FDK = FunctionDefinitionKind; aaron.ballman wrote: > rsmith wrote: > > I don't think it's OK to have an initialism like this in the `clang` > > namespace scope --

[PATCH] D91421: Fix temporary file name on Windows

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4645 + // therefore replace it with '%'. + std::replace(BoundArch.begin(), BoundArch.end(), ':', '%'); +#endif tra wrote: > Windows `cmd` shell uses `%` to reference environment variables. Th

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

wchilders added a comment. Replying to inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91035/new/ https://reviews.llvm.org/D91035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D91428: Add support for multiple program address spaces

tlively added a comment. I think this is a good direction overall, and I'm glad the code doesn't become any messier with this change. I do think it would be good to also email llvm-dev about this change to get general feedback and make sure it doesn't require a full RFC. Com

[PATCH] D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG902ea588eab8: [WebAssembly] Rename atomic.notify and *.atomic.wait (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nikic updated this revision to Diff 305232. nikic added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87188/new/ https://reviews.llvm.org/D87188 Files: clang/test/CodeGen/builtins-wasm.c llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp llvm/test/Transforms

[clang] 902ea58 - [WebAssembly] Rename atomic.notify and *.atomic.wait

Author: Heejin Ahn Date: 2020-11-13T12:04:48-08:00 New Revision: 902ea588eab849e7254d3bc76abf32d833ac0dd6 URL: https://github.com/llvm/llvm-project/commit/902ea588eab849e7254d3bc76abf32d833ac0dd6 DIFF: https://github.com/llvm/llvm-project/commit/902ea588eab849e7254d3bc76abf32d833ac0dd6.diff LO

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01d871536940: [WebAssembly] Remove a temporarily added RUN line (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 01d8715 - [WebAssembly] Remove a temporarily added RUN line

Author: Heejin Ahn Date: 2020-11-13T11:57:09-08:00 New Revision: 01d87153694052d1712e9d539b7cc1425c3aff30 URL: https://github.com/llvm/llvm-project/commit/01d87153694052d1712e9d539b7cc1425c3aff30 DIFF: https://github.com/llvm/llvm-project/commit/01d87153694052d1712e9d539b7cc1425c3aff30.diff LO

[PATCH] D91387: [Driver] Support UBSan multilib

mcgrathr added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:214-215 + set(RUNTIMES_${target}-unknown-fuchsia+ubsan+noexcept_LLVM_BUILD_COMPILER_RT OFF CACHE BOOL "") +set(RUNTIMES_${target}-unknown-fuchsia+ubsan+noexcept_LLVM_USE_SANITIZER "Und

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. Ping? Is it OK to land this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith marked 2 inline comments as done. rsmith added inline comments. Comment at: libcxx/include/iosfwd:188 +#ifdef _LIBCPP_PREFERRED_NAME +template aaron.ballman wrote: > We always define `_LIBCPP_PREFERRED_NAME` so is this actually needed? Thanks, I was try

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith updated this revision to Diff 305222. rsmith added a comment. - Properly disable redundant redeclarations if preferred_name attribute is Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91311/new/ https://reviews.llvm.org/D91311 Files: clang

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Wow, that bug is wild! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91448/new/ https://reviews.llvm.org/D91448 _

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added a comment. In D66324#2336555 , @lebedev.ri wrote: > In D66324#2336186 , @phosek wrote: > >> I apologize for the late response, I somehow missed the earlier responses. >> We have successfully used t

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. aheejin requested review of this revision. This RUN line was added as a temporary measure to undo t

[PATCH] D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, jfb, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. aheejin requested review of this revision. - atomic.notify -> me

[clang] b764a62 - Serialization: Rename three AST diagnostics, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-13T14:09:00-05:00 New Revision: b764a62f02e146bed96cf2231bd1db2d9d4fb72c URL: https://github.com/llvm/llvm-project/commit/b764a62f02e146bed96cf2231bd1db2d9d4fb72c DIFF: https://github.com/llvm/llvm-project/commit/b764a62f02e146bed96cf2231bd1db2d9d4f

[PATCH] D91436: Serialization: Rename three AST diagnostics, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGb764a62f02e1: Serialization: Rename three AST diagnostics, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D91385: [DFSan][NewPM] Handle dfsan under NPM

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91385/new/ https://reviews.llvm.org/D91385 ___

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

c-rhodes added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2217-2218 - // Allow reinterpret_casts between vectors of the same size and - // between vectors and integers of the same size. bool destIsVector = DestType->isVectorType(); nit: not s

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f78605a8cb1: [PowerPC] Add paired vector load and store builtins and intrinsics (authored by bsaleil). Repository: rG LLVM Github Monorepo CHANG

[clang] 3f78605 - [PowerPC] Add paired vector load and store builtins and intrinsics

Author: Baptiste Saleil Date: 2020-11-13T12:35:10-06:00 New Revision: 3f78605a8cb121d005c0ad11cce83cf58be983f2 URL: https://github.com/llvm/llvm-project/commit/3f78605a8cb121d005c0ad11cce83cf58be983f2 DIFF: https://github.com/llvm/llvm-project/commit/3f78605a8cb121d005c0ad11cce83cf58be983f2.dif

[PATCH] D91421: Fix temporary file name on Windows

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM overall, nit about the character choice. Comment at: clang/lib/Driver/Driver.cpp:4645 + // therefore replace it with '%'. + std::replace(BoundArch.begin(), BoundArch.end(),

[clang] 66b876c - Pass the source range when diagnosing an unknown attribute

Author: Aaron Ballman Date: 2020-11-13T10:29:44-08:00 New Revision: 66b876c014ad57e7d750a2063a4abac6babd8ef1 URL: https://github.com/llvm/llvm-project/commit/66b876c014ad57e7d750a2063a4abac6babd8ef1 DIFF: https://github.com/llvm/llvm-project/commit/66b876c014ad57e7d750a2063a4abac6babd8ef1.diff

[clang] d87fd09 - Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-13T13:26:37-05:00 New Revision: d87fd096ac3eb27f376c0182ed5e3034ce240861 URL: https://github.com/llvm/llvm-project/commit/d87fd096ac3eb27f376c0182ed5e3034ce240861 DIFF: https://github.com/llvm/llvm-project/commit/d87fd096ac3eb27f376c0182ed5e3034ce24

[PATCH] D91366: Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGd87fd096ac3e: Serialization: Hoist the check for in-flight diagnostics in ASTReader… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh added a comment. In D91442#2394513 , @jrtc27 wrote: > We use pure LLVM toolchains so improving support for that out of the box is > good in my books. However, I do worry this is going to cause friction for a > lot of people using LLVM for RISC-V; m

[PATCH] D90972: [clang-tidy] Install run-clang-tidy.py in bin/ as run-clang-tidy

JonasToth accepted this revision. JonasToth added a comment. LGTM! thanks for fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90972/new/ https://reviews.llvm.org/D90972 ___ cfe-commits mailing list

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jrtc27 added a comment. We use pure LLVM toolchains so improving support for that out of the box is good in my books. However, I do worry this is going to cause friction for a lot of people using LLVM for RISC-V; my understanding is that most use LLVM with a GNU sysroot and binutils, and so thi

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Seems reasonable. I could see someone wanting to use `--gcc-toolchain` to point at the baremetal toolchain for their target, but that's unlikely to work out of the box anyway. I'd love to

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao marked an inline comment as done. hliao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp:533 + auto *Ty = V->getType(); + if (!Ty->isPointerTy() || + Ty->getPointerAddressSpace() != AMDGPUAS::FLAT_ADDRESS) arsenm wrot

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao updated this revision to Diff 305203. hliao added a comment. Revise the condition check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91121/new/ https://reviews.llvm.org/D91121 Files: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20 "malformed block record in PCH file: '%0'">, DefaultFatal; def err_fe_pch_file

[PATCH] D91436: Serialization: Rename three AST diagnostics, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91436/new/ https://reviews.llvm.org/D91436 ___ cfe-commits mailing list cfe

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh created this revision. abidh added reviewers: asb, jroelofs, manojgupta, clang. Herald added subscribers: cfe-commits, frasercrmck, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, n

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91438/new/ https://reviews.llvm.org/D91438 __

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

dmajor added a comment. In D91330#2394415 , @kadircet wrote: > Looks like it is already green at > http://lab.llvm.org:8011/#/builders/109/builds/2693 Yep, I'm seeing the same, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. Looks like it is already green at http://lab.llvm.org:8011/#/builders/109/builds/2693 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.llvm.org/D91330 _

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

NeHuang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp:417 + + // should prefer D-form if LXVX / STXVX uses a ZERO or ZERO8 + if (MI.getOpcode() == PPC::LXVX || MI.getOpcode() == PPC::STXVX) { amyk wrote: > Ple

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

kadircet added a comment. should be fixed with  https://github.com/llvm/llvm-project/commit/8dc2aa0e412171dad5cdc1aa60a92ddcd3800202. please let me know if it doesn't work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91330/new/ https://reviews.l

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

dmajor added a comment. This broke the bots: http://lab.llvm.org:8011/#/builders/109/builds/2682 File "/b/1/clang-x86_64-debian-fast/llvm.obj/tools/clang/tools/extra/clangd/test/lit.site.cfg.py", line 35 config.have_zlib = ^ SyntaxError: invalid syntax Repo

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

NeHuang added a comment. Please clang-format the patch to pass pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 ___ cfe-commits mailing list cfe-

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington added a reviewer: efriedma. erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90871/new/ https://reviews.llvm.org/D90871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D90188: Add support for attribute 'using_if_exists'

erik.pilkington updated this revision to Diff 305193. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Herald added a subscriber: jdoerfert. Add support for C++11-style attributes on using-declarations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90188

[clang-tools-extra] 8dc2aa0 - [clangd] Canonicalize LLVM_ENABLE_ZLIB

Author: Kadir Cetinkaya Date: 2020-11-13T18:20:37+01:00 New Revision: 8dc2aa0e412171dad5cdc1aa60a92ddcd3800202 URL: https://github.com/llvm/llvm-project/commit/8dc2aa0e412171dad5cdc1aa60a92ddcd3800202 DIFF: https://github.com/llvm/llvm-project/commit/8dc2aa0e412171dad5cdc1aa60a92ddcd3800202.dif

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

avieira created this revision. Herald added subscribers: cfe-commits, danielkiss, jfb, kristof.beyls. Herald added a project: clang. avieira requested review of this revision. Hi all, This patch implements the definition of __ARM_FEATURE_ATOMICS and fixes the missing definition of __ARM_FEATURE_

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

dexonsmith updated this revision to Diff 305184. dexonsmith added a comment. Rename to use `ast_` to match https://reviews.llvm.org/D91436. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91367/new/ https://reviews.llvm.org/D91367 Files: clang/include/clang/Basic/DiagnosticSerializatio

[PATCH] D91436: Serialization: Rename three AST diagnostics, NFC

dexonsmith created this revision. dexonsmith added a reviewer: jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. All three diagnostics have a select between "PCH", "module", and "AST" in the text. The most generic of these is "AST", so rename them fro

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91361/new/ https://reviews.llvm.org/D91361 ___ cfe-commits mailing list cf

[PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. More context: https://www.openwall.com/lists/musl/2013/03/29/13 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13673/new/ https://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17141 + Visit(ACO->getTrueExpr()->IgnoreParenImpCasts()) || + Visit(ACO->getFalseExpr()->IgnoreParenImpCasts()); + } It looks like this short-circuits and the fa

[PATCH] D90622: clang: Don't assert on no_unique_address fields in @encode()

This revision was automatically updated to reflect the committed changes. Closed by commit rG46ca880fcae2: clang: Don't assert on no_unique_address fields in @encode() (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 46ca880 - clang: Don't assert on no_unique_address fields in @encode()

Author: Nico Weber Date: 2020-11-13T11:39:10-05:00 New Revision: 46ca880fcae24693d381ca05c16c704675545433 URL: https://github.com/llvm/llvm-project/commit/46ca880fcae24693d381ca05c16c704675545433 DIFF: https://github.com/llvm/llvm-project/commit/46ca880fcae24693d381ca05c16c704675545433.diff LO

[PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. In D13673#2394064 , @ldionne wrote: > @vkalintiris @jroelofs Is it possible to detect Musl through some macro? I'd > like to get rid of the CMake option -- this isn't the sort of property that > we want to set explicitly at conf

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 305167. bader added a comment. Upload full patch after removing `sycl_constant` address space attribute support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files:

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 305165. bader added a comment. Remove support for `sycl_constant` address space attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files: clang/include/clang/Ba

[PATCH] D91361: [AIX][driver] Include crti[_64].o and -bcdtors also for C language link invocations by default

Xiangling_L updated this revision to Diff 305160. Xiangling_L added a comment. Remove the `if` condition and tweak the comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91361/new/ https://reviews.llvm.org/D91361 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix

[PATCH] D91367: Serialization: Merge three diagnostics to simplify ASTReader::getInputFile, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20 "malformed block record in PCH file: '%0'">, DefaultFatal; def err_fe_pch_file_modified : Error< +"file '%0' has been modified since the " jansvob

[PATCH] D90507: Adding DWARF64 clang flag

wenlei added a comment. This change covers non-LTO cases. For LTO, I think we would need to pass it from driver to LTO. Something like this: tools::addLTOOptions -> lld -> lto::Config (Config->TargetOptions->MCTargetOptions) ->LTO Backend. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:227 + Optional getAssumedAddrSpace(const Value *V) const { +return getTLI()->getTargetMachine().getAssumedAddrSpace(V); hliao wrote: > arsenm wrote: > > We already have a -1

[PATCH] D91121: [InferAddrSpace] Teach to handle assumed address space.

hliao updated this revision to Diff 305154. hliao added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add a note in the AMDGPU usage document on the assumption made here. - Revise the test in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D91429: [OpenCL] Stop opencl-c-base.h leaking extension enabling

mantognini added a comment. LGMT as it reduces the divergence in compilation flows. I let @Anastasia, or someone else more familiar with the codebase, give the final approval though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91429/new/ https:/

[PATCH] D91330: [clangd] Ensure we test for compatibility of serialized index format

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8741a76f5dd1: [clangd] Ensure we test for compatibility of serialized index format (authored by kadircet). Repository: rG LLVM Github Monorepo CH

[clang-tools-extra] 8741a76 - [clangd] Ensure we test for compatibility of serialized index format

Author: Kadir Cetinkaya Date: 2020-11-13T17:06:23+01:00 New Revision: 8741a76f5dd11ba65fadfd3182da4d365ac15352 URL: https://github.com/llvm/llvm-project/commit/8741a76f5dd11ba65fadfd3182da4d365ac15352 DIFF: https://github.com/llvm/llvm-project/commit/8741a76f5dd11ba65fadfd3182da4d365ac15352.dif

[PATCH] D13673: Add initial support for the MUSL C library.

ldionne added a comment. Herald added subscribers: krytarowski, mgorny. @vkalintiris @jroelofs Is it possible to detect Musl through some macro? I'd like to get rid of the CMake option -- this isn't the sort of property that we want to set explicitly at configure time, it's the sort of property

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:184 if (TM.isPPC64()) { -if (Subtarget.hasAltivec()) +if (Subtarget.hasAltivec()) { + if (Subtarget.isAIXABI() && !TM.getAIXExtendedAlt

[PATCH] D91405: [clangd] Assert on varint encoding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e7dd1e3e117: [clangd] Assert on varint encoding (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 305150. ZarkoCA added a comment. Rebased and addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Files: llvm/lib/Target/PowerPC/PPCCallingConv.td ll

  1   2   >