[clang-tools-extra] 8e9bde3 - [clangd] NFC: Add more logging to remote index test

Author: Kirill Bobyrev Date: 2020-11-11T08:24:09+01:00 New Revision: 8e9bde34e7185780e6470150c8bf6d902703bf9e URL: https://github.com/llvm/llvm-project/commit/8e9bde34e7185780e6470150c8bf6d902703bf9e DIFF: https://github.com/llvm/llvm-project/commit/8e9bde34e7185780e6470150c8bf6d902703bf9e.diff

[PATCH] D91237: [OpenCL] Make Clang recognize -cl-std=1.0 as a value argument

Elvina created this revision. Elvina added reviewers: Anastasia, yaxunl, rsmith. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. Elvina requested review of this revision. This patch makes Clang recognize -cl-std=1.0 as a value argument, before only -std=cl1.0 has to be

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis marked an inline comment as done. zinovy.nis added a comment. In D91037#2387377 , @njames93 wrote: > Taking a step back, rather than worrying about if its an `ExprWithCleanups`. > Shouldn't we just get the condition removing all implicit nodes.

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis marked 2 inline comments as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:145 + const auto *LeftDRE = dyn_cast(CondOp->getLHS()->IgnoreParenImpCasts()); aaron.

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis updated this revision to Diff 304400. zinovy.nis added a comment. Simplified to use `IgnoreImplicit()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new/ https://reviews.llvm.org/D91037 Files: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp

[PATCH] D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy

faisalv closed this revision. faisalv added a comment. Committed: https://github.com/llvm/llvm-project/commit/e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91011/new/ https://reviews.llvm.org/D91011 __

[clang] e4d2793 - [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to remove duplication

Author: Faisal Vali Date: 2020-11-10T23:40:12-06:00 New Revision: e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9 URL: https://github.com/llvm/llvm-project/commit/e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9 DIFF: https://github.com/llvm/llvm-project/commit/e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9.diff L

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

sbc100 added a comment. Nope I was wrong, emscripten does use these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91222/new/ https://reviews.llvm.org/D91222 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D91226: [clang] Add missing header guard in

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf36142d342a: [clang] Add missing header guard in (authored by mcgrathr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cf36142 - [clang] Add missing header guard in

Author: Roland McGrath Date: 2020-11-10T19:34:25-08:00 New Revision: cf36142d342a46689007df3b508b2ef059d76e46 URL: https://github.com/llvm/llvm-project/commit/cf36142d342a46689007df3b508b2ef059d76e46 DIFF: https://github.com/llvm/llvm-project/commit/cf36142d342a46689007df3b508b2ef059d76e46.diff

[PATCH] D91226: [clang] Add missing header guard in

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91226/new/ https://reviews.llvm.org/D91226 ___ c

[PATCH] D91226: [clang] Add missing header guard in

mcgrathr created this revision. mcgrathr added reviewers: phosek, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. mcgrathr requested review of this revision. This header has long lacked a standard multiple inclusion guard like other headers have, for no apparent

[clang] d9258a2 - Fix the data layout mangling specification for 'arm64-pc-win32-macho'

Author: Akira Hatanaka Date: 2020-11-10T18:52:12-08:00 New Revision: d9258a21f03811a9e231c2ec338822de84d55eef URL: https://github.com/llvm/llvm-project/commit/d9258a21f03811a9e231c2ec338822de84d55eef DIFF: https://github.com/llvm/llvm-project/commit/d9258a21f03811a9e231c2ec338822de84d55eef.diff

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

sbc100 added a comment. I don't think so but I will double check. I'm in the middle of some TLS rethinking so I'll leave this open for now pending any changes to our TLS ABI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91222/new/ https://review

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Excellent, thanks. I hope I'm not forgetting any good reason we added these. Emscripten doesn't use them in its pthreads runtime, right? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

scanon added a comment. Strictly speaking, fp-contract=fast probably should have been a separate flag entirely (since there's no _expression_ being contracted in fast). Unfortunately, that ship has sailed, and it does constrain our ability to choose an accurate name somewhat. What if we just s

[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

shivanshu3 added a reviewer: tiagoma. shivanshu3 added a comment. Note that this regression seems to be there ever since Clang 3.4.1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91129/new/ https://reviews.llvm.org/D91129 _

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

dblaikie added a comment. In D90719#2387379 , @akhuang wrote: > + @ldionne for libc++ input? > > To summarize, this constructor homing debug info optimization makes the > assumption that if a class is being used then its constructor must have been > call

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

rjmccall added a comment. `fast-strict`? Sounds sort of oxymoronic, but it's `fast` while also being strict about honoring pragmas. I don't have any great ideas here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___

[PATCH] D91222: [WebAssembly] Remove wasm-specific TLS builtins

sbc100 created this revision. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. sbc100 requested review of this revision. Herald added a subscriber: aheejin. These builtins don't have any actua

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote: > gulfem wrote: > > aaron.ballman wrote: > >

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a subscriber: ldionne. akhuang added a comment. + @ldionne for libc++ input? To summarize, this constructor homing debug info optimization makes the assumption that if a class is being used then its constructor must have been called at some point. We noticed that some libc++ types

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

njames93 added a comment. Taking a step back, rather than worrying about if its an `ExprWithCleanups`. Shouldn't we just get the condition removing all implicit nodes. const Expr* Cond = InnerIf->getCond()->ignoreImplicit(); This has to be simpler and will likely future proof this against any

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

nridge added inline comments. Comment at: clang-tools-extra/clangd/README.md:30 + We suggest building in RELEASE mode as building DEBUG binaries requires + considerably more resources. You can check [Building LLVM with CMake + documentation](https://llvm.org/docs/CMake.html) f

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

nridge added a comment. Thanks for the reviews! Comment at: clang-tools-extra/clangd/test/call-hierarchy.test:39 +--- +{"jsonrpc":"2.0","id":2,"method":"callHierarchy/incomingCalls","params":{"item":{"data":"F0E64FE3F8FEA480","kind":12,"name":"callee","range":{"end":{"character

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. I agree with your analysis and I'd also prefer **Solution (1)**, I've rebased the change and included a simple test. Right now, there's nothing specific to libc++, we're simply relying on the linker. Alternative would be to have a more explicit logic in DarwinClang::Add

[clang] c6d86b6 - Properly collect template arguments from a class-scope function template

Author: Richard Smith Date: 2020-11-10T15:55:19-08:00 New Revision: c6d86b6b45a8e40457286c78321a4680b459e800 URL: https://github.com/llvm/llvm-project/commit/c6d86b6b45a8e40457286c78321a4680b459e800 DIFF: https://github.com/llvm/llvm-project/commit/c6d86b6b45a8e40457286c78321a4680b459e800.diff

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek updated this revision to Diff 304342. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45639/new/ https://reviews.llvm.org/D45639 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-ld.c Index: clang/test/Driver/darwin-ld.c ===

[clang] 872633b - Add utility for testing if we're matching nodes AsIs

Author: Stephen Kelly Date: 2020-11-10T23:32:30Z New Revision: 872633b28538f87a2b7f61bcb91259cf7e09dfa1 URL: https://github.com/llvm/llvm-project/commit/872633b28538f87a2b7f61bcb91259cf7e09dfa1 DIFF: https://github.com/llvm/llvm-project/commit/872633b28538f87a2b7f61bcb91259cf7e09dfa1.diff LOG:

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

rjmccall added inline comments. Comment at: clang/lib/AST/Decl.cpp:2491 +bool VarDecl::isCapturedByOwnInit() const { + return hasAttr() && NonParmVarDeclBits.CapturedByOwnInit; +} ille wrote: > rjmccall wrote: > > You should check `isEscapingByref()` here rather

[PATCH] D90188: Add support for attribute 'using_if_exists'

rsmith added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5273 + namespace empty_namespace {}; + using empty_namespace::does_not_exist __attribute__((using_if_exists)); // no error! + aaron.ballman wrote: > Mordante wrote: > > erik.pilkin

[clang] c43f8c7 - Add PrintingPolicy overload to APValue::printPretty. NFC.

Author: Richard Smith Date: 2020-11-10T14:48:56-08:00 New Revision: c43f8c772886ff081aaaf94ddb70da58d545a4c0 URL: https://github.com/llvm/llvm-project/commit/c43f8c772886ff081aaaf94ddb70da58d545a4c0 DIFF: https://github.com/llvm/llvm-project/commit/c43f8c772886ff081aaaf94ddb70da58d545a4c0.diff

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

mnauw added a comment. Thanks. However, I do not have commit access, so someone may have to arrange for that ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90534/new/ https://reviews.llvm.org/D90534 __

[clang] ed2baaa - Revert "Add utility for testing if we're matching nodes AsIs"

Author: Stephen Kelly Date: 2020-11-10T22:29:58Z New Revision: ed2baaac56c45cef4742cab79434a2e6c95e8fda URL: https://github.com/llvm/llvm-project/commit/ed2baaac56c45cef4742cab79434a2e6c95e8fda DIFF: https://github.com/llvm/llvm-project/commit/ed2baaac56c45cef4742cab79434a2e6c95e8fda.diff LOG:

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

jyknight added inline comments. Comment at: llvm/docs/Atomics.rst:625 + +Libcalls: out-of-line atomics += I think this section needs to be put on the end of the section on `__sync_*`. These functions are effectively an aarch64-specifi

[PATCH] D91204: [[clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi updated this revision to Diff 304327. saudi added a comment. Updated the patch. Followed suggestion from @dexonsmith. Indeed it simplifies the code. Also, improved the test, to also test with -j 2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91204/new/ https://reviews.llvm.org/D

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1228 +Callback>> Reply) { + Server->outgoingCalls(Params.Item, std::move(Reply)); +} as mentioned in the previous review, let's just reply with none/empty here, with a

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

kadircet added a comment. can you also add some tests to ClangdTests.cpp ? Comment at: clang-tools-extra/clangd/ClangdServer.cpp:695 +Callback>> CB) { + CB(clangd::incomingCalls(Item, Index)); +} why do we run this on the mainthread ? I suppose we should j

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

fghanim added a comment. Thanks for doing this. Please add proper lit test. you can find that under `clang/test/OpenMP/sections_codegen.cpp`. add a case for using the OMPBuilder. As an example look in the same directory for `parallel_codegen.cpp` , `master_codegen.cpp` , `critical_codegen.cpp`

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1317 -static Optional -symbolToTypeHierarchyItem(const Symbol &S, const SymbolIndex *Index, - PathRef TUPath) { that's a great change to have, but maybe leave

[PATCH] D91111: [CodeGen] Mark calls to objc_autorelease as tail

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG874b0a0b9db9: [CodeGen] Mark calls to objc_autorelease as tail (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 874b0a0 - [CodeGen] Mark calls to objc_autorelease as tail

Author: Akira Hatanaka Date: 2020-11-10T13:48:25-08:00 New Revision: 874b0a0b9db93f5d3350ffe6b5efda2d908415d0 URL: https://github.com/llvm/llvm-project/commit/874b0a0b9db93f5d3350ffe6b5efda2d908415d0 DIFF: https://github.com/llvm/llvm-project/commit/874b0a0b9db93f5d3350ffe6b5efda2d908415d0.diff

[PATCH] D91204: [[clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

dexonsmith added a comment. Can we use `getPhysicalFileSystem()` instead of `getRealFileSystem()` here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91204/new/ https://reviews.llvm.org/D91204 ___ cfe-co

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19f077092343: [Coroutine][Sema] Cleanup temporaries as early as possible (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 19f0770 - [Coroutine][Sema] Cleanup temporaries as early as possible

Author: Xun Li Date: 2020-11-10T13:27:42-08:00 New Revision: 19f07709234304b0214f5352750e85cacfda4b36 URL: https://github.com/llvm/llvm-project/commit/19f07709234304b0214f5352750e85cacfda4b36 DIFF: https://github.com/llvm/llvm-project/commit/19f07709234304b0214f5352750e85cacfda4b36.diff LOG: [

[PATCH] D91204: [[clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi created this revision. saudi added reviewers: arphaman, dexonsmith. saudi added a project: clang. Herald added subscribers: cfe-commits, tschuett. saudi requested review of this revision. The bug appeared when clang-scan-deps was run from a different directory than the one provided in the "

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this generally seems reasonable, but I'm far from an AIX expert so you should wait a few days in case other reviewers have feedback. Comment at: clang/

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:145 + const auto *LeftDRE = dyn_cast(CondOp->getLHS()->IgnoreParenImpCasts()); The old code used to assert that `CondOp` was a

[clang] 438a27f - Move code to determine the type of an LValueBase out of ExprConstant and

Author: Richard Smith Date: 2020-11-10T13:03:57-08:00 New Revision: 438a27f2e56a9753d4cc8477a1f1c306edc4c885 URL: https://github.com/llvm/llvm-project/commit/438a27f2e56a9753d4cc8477a1f1c306edc4c885 DIFF: https://github.com/llvm/llvm-project/commit/438a27f2e56a9753d4cc8477a1f1c306edc4c885.diff

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalInMultithreadedProgramCheck.cpp:41 + hasDeclaration(functionDecl(hasAnyListedName(ThreadList, +hasDescendant(varDecl(hasType(recordDecl(hasName("std::

[PATCH] D90984: Update matchers to be traverse-aware

steveire added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2368 NonTrivial m_nt; - HasCtorInits() : NoSpecialMethods(), m_i(42) {} }; aaron.ballman wrote: > Was this originally testing behavior with explicitly initia

[PATCH] D90984: Update matchers to be traverse-aware

steveire updated this revision to Diff 304298. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90984/new/ https://reviews.llvm.org/D90984 Files: clang/include/clang/ASTMatchers/ASTMatchers.h clang/include/clang/A

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG703038b35a86: [Sema] Fix volatile check when testing if a return object can be implicitly… (authored by nullptr.cpp, committed by arthur.j.odwyer).

[clang] 703038b - [Sema] Fix volatile check when testing if a return object can be implicitly moved

Author: Yang Fan Date: 2020-11-10T15:11:07-05:00 New Revision: 703038b35a864d06e1926237c1568a430417b0b4 URL: https://github.com/llvm/llvm-project/commit/703038b35a864d06e1926237c1568a430417b0b4 DIFF: https://github.com/llvm/llvm-project/commit/703038b35a864d06e1926237c1568a430417b0b4.diff LOG:

[PATCH] D91200: [PowerPC] Prevent the use of MMA with P9 and earlier

bsaleil created this revision. bsaleil added reviewers: nemanjai, saghir, lei, amyk, PowerPC. bsaleil added projects: clang, PowerPC. Herald added subscribers: cfe-commits, shchenz, kbarton. bsaleil requested review of this revision. We want to allow using MMA on `P10` CPU only. This patch prevent

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:85 // remove the inner `if`. - const auto *BinOpCond = dyn_cast(InnerIf->getCond()); + const auto *BinOpCond =

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis updated this revision to Diff 304280. zinovy.nis added a comment. dyn_cast_or_null -> dyn_cast CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new/ https://reviews.llvm.org/D91037 Files: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp clang-t

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:85 // remove the inner `if`. - const auto *BinOpCond = dyn_cast(InnerIf->getCond()); + const auto *BinOpCond = dyn_cast_or_null(InnerIf->getCond()); + i

[PATCH] D91194: Fixes an issue where adding a relative path to the C include Directories via the C_INCLUDE_DIRS compile time option, there is a "/" ommitted to join the sysroot and the supplied relati

lancethepants created this revision. Herald added subscribers: cfe-commits, jgravelle-google, sbc100, dschuff. Herald added a project: clang. lancethepants requested review of this revision. Herald added a subscriber: aheejin. ...the relative path of course does not start with "/", so the "/" is n

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis marked 2 inline comments as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:85 // remove the inner `if`. - const auto *BinOpCond = dyn_cast(InnerIf->getCond()); + const auto *BinOpCond =

[PATCH] D91144: Add utility for testing if we're matching nodes AsIs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe73296d3b92f: Add utility for testing if we're matching nodes AsIs (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] e73296d - Add utility for testing if we're matching nodes AsIs

Author: Stephen Kelly Date: 2020-11-10T19:28:11Z New Revision: e73296d3b92fc231f3f913815e477d55b66595bd URL: https://github.com/llvm/llvm-project/commit/e73296d3b92fc231f3f913815e477d55b66595bd DIFF: https://github.com/llvm/llvm-project/commit/e73296d3b92fc231f3f913815e477d55b66595bd.diff LOG:

[PATCH] D91144: Add utility for testing if we're matching nodes AsIs

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:195 +bool ASTMatchFinder::isTraversalAsIs() const { + return getASTContext().getParentMapContext().getTraversalKind() == TK_AsIs; +} steveire wrote: > aaron.ballman wr

[PATCH] D91144: Add utility for testing if we're matching nodes AsIs

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:195 +bool ASTMatchFinder::isTraversalAsIs() const { + return getASTContext().getParentMapContext().getTraversalKind() == TK_AsIs; +} aaron.ballman wrote: > I don't insist,

[PATCH] D91158: Fix the DeclContextLookupResult::iterator non-copyable.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d85f732b13a: Fix the DeclContextLookupResult::iterator non-copyable. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 7d85f73 - Fix the DeclContextLookupResult::iterator non-copyable.

Author: Haojian Wu Date: 2020-11-10T20:22:45+01:00 New Revision: 7d85f732b13a3434bbb6a9054b8ede0e903961da URL: https://github.com/llvm/llvm-project/commit/7d85f732b13a3434bbb6a9054b8ede0e903961da DIFF: https://github.com/llvm/llvm-project/commit/7d85f732b13a3434bbb6a9054b8ede0e903961da.diff LO

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304256. Xiangling_L added a comment. Address comments; Move testcases to CodeGen folder instead of CodeGenCXX since ctor/dtor attribute should work in both C&C++ mode; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); aaron.ballm

[PATCH] D91051: [clangd] Improve clangd-indexer performance

ArcsinX updated this revision to Diff 304262. ArcsinX added a comment. Don't check that `AbsPath` is not in `Files` twice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91051/new/ https://reviews.llvm.org/D91051 Files: clang-tools-extra/clangd/i

[PATCH] D91134: [clangd] Abort rename when given the same name

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218 +case ReasonToReject::SameName: + return "new name should differ from the old name"; } sammccall wrote: > hokein wrote: > > returning an error seems to be an

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); Xiangling_L wrote: > aaron.ballman wrote: > > Xiangling

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90990/new/ https://reviews.llvm.org/D90990 ___ cfe

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 5 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); aaron.ballm

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:85 // remove the inner `if`. - const auto *BinOpCond = dyn_cast(InnerIf->getCond()); + const auto *BinOpCond = dyn_cast_or_null(InnerIf->getCond()); + i

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Adds minimal cmake configuration required t

[clang] 58c586e - Allow searching for prebuilt implicit modules.

Author: Alexandre Rames Date: 2020-11-10T10:14:13-08:00 New Revision: 58c586e701889250c08285193dc75d94a7ed302d URL: https://github.com/llvm/llvm-project/commit/58c586e701889250c08285193dc75d94a7ed302d DIFF: https://github.com/llvm/llvm-project/commit/58c586e701889250c08285193dc75d94a7ed302d.dif

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis marked an inline comment as done and 2 inline comments as not done. zinovy.nis added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp:85 // remove the inner `if`. - const auto *BinOpCond = dyn_cast(InnerIf->getCo

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis updated this revision to Diff 304242. zinovy.nis marked 2 inline comments as done. zinovy.nis added a comment. *iterator -> getSubExpr() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new/ https://reviews.llvm.org/D91037 Files: clang-tools-extra/clang-tidy/bugprone/Re

[PATCH] D91134: [clangd] Abort rename when given the same name

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:218 +case ReasonToReject::SameName: + return "new name should differ from the old name"; } hokein wrote: > returning an error seems to be an interesting idea,

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

ille added inline comments. Comment at: clang/lib/AST/Decl.cpp:2491 +bool VarDecl::isCapturedByOwnInit() const { + return hasAttr() && NonParmVarDeclBits.CapturedByOwnInit; +} rjmccall wrote: > You should check `isEscapingByref()` here rather than just `hasAttr`

[PATCH] D91184: [clang-tidy] Merge options inplace instead of copying

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Changed `ClangTidyOptions::mergeWith` to operate on the instance instead of ret

[PATCH] D90928: [OpenCL] Add assertions to extension lookup

Anastasia added a comment. In D90928#2382111 , @erik2020 wrote: > In D90928#2379322 , @Anastasia wrote: > >> Ok, it would still segfault but perhaps it is acceptable as this is an >> internal frontend only option f

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

lxfind updated this revision to Diff 304233. lxfind added a comment. Add AST test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90990/new/ https://reviews.llvm.org/D90990 Files: clang/lib/Sema/SemaCoroutine.cpp clang/test/AST/Inputs/std-corout

[PATCH] D91158: Fix the DeclContextLookupResult::iterator non-copyable.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DeclBase.h:1249 llvm::iterator_adaptor_base; + std::random_access_iterator_tag, NamedDec

[PATCH] D82860: Port ObjCMTAction to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 ___ cfe-commits mailing list cfe-comm

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

zahiraam added a comment. In D91089#2385821 , @hans wrote: >> clang.exe -c test.cpp >> Assertion failed: !hasUninstantiatedDefaultArg() && "Default argument is not >> yet instantiated!", file >> D:\IUSERS\zahiraam\llorg_ws\ws1\llvm\clang\lib\AST\Decl.cpp

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); Xiangling_L wrote: > aaron.ballman wrote: > > There's a

[PATCH] D90890: Frontend: Change ComputePreambleBounds to take MemoryBufferRef, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90890/new/ https://reviews.llvm.org/D90890 ___ cfe-commits mailing list cfe

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.h:25 public: + enum class AsyncSafeFunctionSetType { Minimal, POSIX }; + balazske wrote: > aaron.ballman wrote: > > I don't think this needs to be public?

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

lxfind added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:475 + if (!AwaitSuspend) +return Calls; if (!AwaitSuspend->getType()->isDependentType()) { lxfind wrote: > bruno wrote: > > In case `AwaitSuspend` is null, is there any need to set

[PATCH] D91067: [AArch64][SVE] Support implicit lax vector conversions for SVE types

fpetrogalli added a comment. Hi @joechrisellis - thank you for this patch! I have left a couple of comments. Francesco Comment at: clang/lib/AST/ASTContext.cpp:8563-8566 +if (const auto *BT = FirstType->getAs()) { + if (const auto *VT = SecondType->getAs()) { +

[PATCH] D90990: [Coroutine][Sema] Cleanup temporaries as early as possible

lxfind added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:475 + if (!AwaitSuspend) +return Calls; if (!AwaitSuspend->getType()->isDependentType()) { bruno wrote: > In case `AwaitSuspend` is null, is there any need to set `Calls.IsInvalid`

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L marked 6 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1482 + void AddGlobalDtor(llvm::Function *Dtor, int Priority = 65535, + bool IsDtorAttrFunc = false); aaron.ballm

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added a comment. In D90851#2385744 , @aaron.ballman wrote: > One thing that's not clear to me in the patch is what the behavior should be > when the user specifies that they want the POSIX set but they're compiling > for a non-POSIX system like

[PATCH] D88987: [FPEnv][Clang][Driver] Use MarshallingInfoFlag for -fexperimental-strict-floating-point

jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. Hi Kevin, sorry for the late response. I don't think adding new tests is necessary as long as the flag is used in existing ones. Comment at: clang/inc

[PATCH] D89684: [AIX] Add mvecnvol and mnovecnvol options to enable the AIX extended and default vector ABIs.

DiggerLin added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2870 + +.. option:: -mvecnvol, -mnovecnvol + I think it should be ```.. option:: -mvecnvol, -mnovecnvol Only supported On AIX. Specify usage of volatile and nonvolatile vect

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304198. njames93 added a comment. Herald added subscribers: usaxena95, kadircet, arphaman. Teach clangd to ignore these fix-its. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.or

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

aaron.ballman added a comment. In D77493#1962465 , @njames93 wrote: > In my mind this check is definitely in the realm of the static analyser, > clang-tidy just isn't designed for this. +1, I think this probably should be handled in the static analyzer i

[PATCH] D90890: Frontend: Change ComputePreambleBounds to take MemoryBufferRef, NFC

dexonsmith updated this revision to Diff 304195. dexonsmith added a comment. Missed a couple of calls from clang-tools-extra. Fixed those. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90890/new/ https://reviews.llvm.org/D90890 Files: clang-tools-extra/clangd/CodeComplete.cpp clang

[PATCH] D90944: [clang-tidy] implement misc-mt-unsafe

segoon updated this revision to Diff 304189. segoon edited the summary of this revision. segoon added a comment. - add `Libc` option - improve docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/misc/CMakeL

  1   2   >