[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90009/new/ https://reviews.llvm.org/D90009 _

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling support for non-type template parameters of class type and template parameter objects.

rsmith updated this revision to Diff 300524. rsmith added a comment. - Fix incorrect mangling for zero-but-not-null template arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89998/new/ https://reviews.llvm.org/D89998 Files: clang/include

[clang] 7b35158 - For P0732R2, P1907R1: ensure that template parameter objects don't refer

Author: Richard Smith Date: 2020-10-24T22:11:43-07:00 New Revision: 7b3515880c22c887cd5ca4825dfb060ad82d3ebc URL: https://github.com/llvm/llvm-project/commit/7b3515880c22c887cd5ca4825dfb060ad82d3ebc DIFF: https://github.com/llvm/llvm-project/commit/7b3515880c22c887cd5ca4825dfb060ad82d3ebc.diff

[PATCH] D89670: [clangd] Store the containing symbol for refs

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:349 +SymbolRef{SM.getFileLoc(Loc), Roles, + dyn_cast_or_null(ASTNode.Parent)}); // Don't continue indexing if this is

[PATCH] D89670: [clangd] Store the containing symbol for refs

nridge updated this revision to Diff 300518. nridge added a comment. Use Decl rather than NamedDecl, and add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89670/new/ https://reviews.llvm.org/D89670 Files: clang-tools-extra/clangd/index/Re

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 updated this revision to Diff 300517. tianshilei1992 added a comment. Fixed some test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp cl

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. Would it be possible to split this review further, into "checking" and "fixing" portions? I understand that fix-it portion is more difficult, and sometimes results in multiple 'const' keywords being added, but for the past year we have used the check as part of regu

[PATCH] D90110: Use --use-color in run-clang-tidy.py

dsanders11 created this revision. dsanders11 added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. dsanders11 requested review of this revision. Now that D79477 landed, it's a better user experience to use '--use-color'

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 added a comment. Added a few inline comments for clarification. **Note**: I was not able to get a debug build and unit tests working on my Windows set up, so this has only been tested manually. I'm not sure if the unit test added in D79477 runs on Wi

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 created this revision. dsanders11 added reviewers: aaron.ballman, njames93. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, xazax.hun. Herald added projects: clang, LLVM. dsanders11 requested review of this revision. On Windows the --use-color option cannot be used for i

[clang-tools-extra] aaa8b44 - [clangd] Add a TestWorkspace utility

Author: Nathan Ridge Date: 2020-10-24T20:15:17-04:00 New Revision: aaa8b44d19918ea1764339224cec68c27445aa8e URL: https://github.com/llvm/llvm-project/commit/aaa8b44d19918ea1764339224cec68c27445aa8e DIFF: https://github.com/llvm/llvm-project/commit/aaa8b44d19918ea1764339224cec68c27445aa8e.diff

[PATCH] D89297: [clangd] Add a TestWorkspace utility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaa8b44d1991: [clangd] Add a TestWorkspace utility (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D89297: [clangd] Add a TestWorkspace utility

nridge updated this revision to Diff 300513. nridge marked 4 inline comments as done. nridge added a comment. address final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89297/new/ https://reviews.llvm.org/D89297 Files: clang-too

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

nridge added a comment. Note, I've cargo-culted this comment into `declToTypeHierarchyItem()` as well, so whatever change we make here should be made there too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89935/new/ https://reviews.llvm.org/D899

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 updated this revision to Diff 300509. tianshilei1992 added a comment. Fixed an issue that caused compiler crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files: clang/lib/CodeGen/CGOp

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. I replied on llvm-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83088/new/ https://reviews.llvm.org/D83088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert updated this revision to Diff 300507. aaronpuchert added a comment. `LiteralPtr`s aren't always globals, local variables are also translated that way. So we ask the stored `ValueDecl` if it `isDefinedOutsideFunctionOrMethod`. That seems like the right thing. Repository: rG LLVM

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert reopened this revision. aaronpuchert added a comment. This revision is now accepted and ready to land. Almost forgot about that. I think I've figured it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84604/new/ https://reviews.llvm

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

mibintc updated this revision to Diff 300494. mibintc retitled this revision from "Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress" to "Enable '#pragma STDC FENV_ACCESS' in frontend". mibintc added a comment. I updated the test cases, added documentation about constan

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

tianshilei1992 created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. In current implementation, if it requires an oute

[clang] 39a0d68 - [X86] Add a stub for Intel's alderlake.

Author: Benjamin Kramer Date: 2020-10-24T19:01:22+02:00 New Revision: 39a0d6889dee636af3b7fbb69e1ac5c8af777ad0 URL: https://github.com/llvm/llvm-project/commit/39a0d6889dee636af3b7fbb69e1ac5c8af777ad0 DIFF: https://github.com/llvm/llvm-project/commit/39a0d6889dee636af3b7fbb69e1ac5c8af777ad0.dif

[clang] bd2cf96 - [X86] Add a stub for znver3 based on the little public information there is in AMD's manuals

Author: Benjamin Kramer Date: 2020-10-24T19:01:22+02:00 New Revision: bd2cf96c098ed0020f5178eda12cf30d3980d9bd URL: https://github.com/llvm/llvm-project/commit/bd2cf96c098ed0020f5178eda12cf30d3980d9bd DIFF: https://github.com/llvm/llvm-project/commit/bd2cf96c098ed0020f5178eda12cf30d3980d9bd.dif

[clang] b8d2b6f - Unbreak the clang-interpreter example after 0aec49c8531bc5282b095730d34681455826bc2c

Author: Benjamin Kramer Date: 2020-10-24T19:01:21+02:00 New Revision: b8d2b6f6cf6015751fc950c3e8149404e8b37fe8 URL: https://github.com/llvm/llvm-project/commit/b8d2b6f6cf6015751fc950c3e8149404e8b37fe8 DIFF: https://github.com/llvm/llvm-project/commit/b8d2b6f6cf6015751fc950c3e8149404e8b37fe8.dif

[PATCH] D90099: [Clang][OpenMP] Added the support for target data nowait

tianshilei1992 created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Previously we added support for target nowait, bu

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 300489. MyDeveloperDay added a comment. Rebase the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

tianshilei1992 added a comment. I don't think the failed case has anything to do with this patch. It must be a random issue in the bolt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:60 + *RBrace = cast_or_null( + Stmt->findChild(syntax::NodeRole::CloseParen)); +if (!LBrace || !RBrace) sammccall wrote: > strictly this

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

awarzynski added a comment. Thank you all for your input! Before merging I took the liberty to rename `NoClangOption` as `FlangOnlyOption`. The new name reflects better what the flag is introduced for. Also, based on responses to [1], it is unlikely that it will be used beyond flang-only option

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c5906cffd04: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O (authored by CarolineConcatto, committed by awarzynski). C

[clang] 4c5906c - [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

Author: Caroline Concatto Date: 2020-10-24T14:58:32+01:00 New Revision: 4c5906cffd04202387d2f6b50a47d39c0e4f2c0e URL: https://github.com/llvm/llvm-project/commit/4c5906cffd04202387d2f6b50a47d39c0e4f2c0e DIFF: https://github.com/llvm/llvm-project/commit/4c5906cffd04202387d2f6b50a47d39c0e4f2c0e.d

[PATCH] D90073: [Clang][CodeGen] fix failed assertion

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4640 /*D=*/nullptr); -LT = getLLVMLinkageVarDefinition(cast(GD.getDecl()), - D->getType().isConstQualified()); +if

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

kbobyrev updated this revision to Diff 300479. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Decompose locations and add checks for FileID == MainFileID. Also, rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm