[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added a comment. @NoQ > The new code should obviously be restricted into evalCastFromLoc() because if > it's a region it's a Loc. The first I tryed was `evalCastFromLoc()`, but it turned out that `SVal` which binds to a pointer can be `NonLoc` as well through violation of pointin

[PATCH] D74130: [clang] fix consteval call in default arguments

rsmith added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1026 + HandleImmediateInvocations(ExprEvalContexts.back()); + Tyker wrote: > rsmith wrote: > > What do we need this for? If I'm understanding the patch correctly, I think > > the only way we sh

[PATCH] D89636: [AMDGPU] Extend hip-toolchin-features.hip test

t-tye created this revision. t-tye added reviewers: kzhuravl, scott.linder, rampitec. Herald added subscribers: cfe-commits, tpr, dstuttard, yaxunl. Herald added a project: clang. t-tye requested review of this revision. Herald added a subscriber: wdng. - Extend hip-toolchin-features.hip to also c

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

tejohnson updated this revision to Diff 298849. tejohnson added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. As discussed in review for D89086 , move test changes to this patch since they are only required here. Repositor

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

Thanks everyone for keeping your annotated builders in the staging area! Much appreciated. Please feel free to move all the green builders back to the production. It has a new AnnotatedCommand now. Thanks Galina On Thu, Oct 15, 2020 at 12:46 AM Vitaly Buka wrote: > Ok, I can switch them back

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

eugenis updated this revision to Diff 298692. eugenis added a comment. fix type size check for vscale types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/CodeGenOptions.

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9e789447f14: Revert "[clang-format] Fix AlignConsecutive on PP blocks" (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/ne

[clang] b9e7894 - Revert "[clang-format] Fix AlignConsecutive on PP blocks"

Author: Sylvestre Ledru Date: 2020-10-17T19:52:51+02:00 New Revision: b9e789447f14c0330edd22c82746af29e7c3b259 URL: https://github.com/llvm/llvm-project/commit/b9e789447f14c0330edd22c82746af29e7c3b259 DIFF: https://github.com/llvm/llvm-project/commit/b9e789447f14c0330edd22c82746af29e7c3b259.dif

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

sameeranjoshi added a comment. Thank you, this patch looks easy to understand as it's clearly separated from(`D87989`) the infrastructure changes needed for frontend actions. A few comments inline. Comment at: flang/include/flang/Frontend/CompilerInstance.h:85 + /// Return pa

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante updated this revision to Diff 298838. Mordante marked an inline comment as done. Mordante added a comment. Removes the support for the pointer types. I adjusted the unit test for `void f()`, but I think it would be better remove this test now pointers are no longer allowed. Do you agree

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added a comment. @jfb (and others), friendly ping. Are there any other changes (especially to the logic) that you'd like me to make? Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1647 +QualType Ty) { + auto *I8Ptr = CGF.Builder.

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:1817-1819 + NeedToMaterializeTemporary = + SrcType->isRecordType() || SrcType->isArrayType() || + SrcType->isFunctionPointerType() || SrcType-

[PATCH] D24688: Introduce "hosted" module flag.

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Herald added subscribers: kerbowa, steven_wu, atanasyan, zzheng, MaskRay, fedor.sergeev, hiraditya, jvesely, sdardis, emaste. Herald added a reviewer: espindola. Herald added a

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

dexonsmith resigned from this revision. dexonsmith added a reviewer: Bigcheese. dexonsmith added a subscriber: Bigcheese. dexonsmith added a comment. Herald added a subscriber: dexonsmith. If this is still relevant, I’m happy for @ldionne and @Bigcheese to make the call. Repository: rC Clang

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

NoQ added a comment. Aha, great, sounds like all casting can be made more correct, not just casting on store retrieve! Maybe it's worth celebrating through extra unittests on `evalCast()`. Thank you for looking into this. The new code should obviously be restricted into `evalCastFromLoc()` beca

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 298819. jonpa added a comment. Sorry, here's the test case included as well... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/aarch64-inline-asm.c

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker updated this revision to Diff 298818. Tyker marked 9 inline comments as done. Tyker added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74130/new/ https://reviews.llvm.org/D74130 Files: clang/include/clang/AS

[PATCH] D74130: [clang] fix consteval call in default arguments

Tyker added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1026 + HandleImmediateInvocations(ExprEvalContexts.back()); + rsmith wrote: > What do we need this for? If I'm understanding the patch correctly, I think > the only way we should propagate immed

[clang] 5564ee4 - Revert "Register TargetCXXABI.def as a textual header"

Author: Dave Lee Date: 2020-10-17T00:15:34-07:00 New Revision: 5564ee495bddeb12d3a9a617631cfa478cf67959 URL: https://github.com/llvm/llvm-project/commit/5564ee495bddeb12d3a9a617631cfa478cf67959 DIFF: https://github.com/llvm/llvm-project/commit/5564ee495bddeb12d3a9a617631cfa478cf67959.diff LOG:

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:409 + +namespace std { + gribozavr2 wrote: > flx wrote: > > gribozavr2 wrote: > > > Could you add a nested inline namespace to

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Any chance of adding a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89608/new/ https://reviews.llvm.org/D89608 _