[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322900 , @mati865 wrote: > With `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_C_COMPILER=clang > -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_RANLIB_COMPILER=llvm-ranlib > -DCMAKE_AR_COMPILER=llvm-ar -DCMAKE_LINKER=ld.lld -DLLVM_ENABL

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rjmccall added a comment. The GCC docs seem pretty clear that `-frounding-math` is meant to allow dynamic access to the FP environment. There might be optimizations that are perfectly legal with a constant but non-default rounding mode, and there might be some flag that only implies that weake

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88712/new/ https://reviews.llvm.org/D88712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

LLVM buildbot will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek, tstellar. Herald added subscribers: llvm-commits, cfe-commits, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_ami

Re: [clang] 9dcd96f - Canonicalize declaration pointers when forming APValues.

I think this is the cause of https://crbug.com/1134762. Can we speculatively revert while coming up with a repro? Or would you like a repro first? On Sun, Sep 27, 2020 at 7:06 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-09-27T19:05:

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-static-member.cpp:144-147 +// For some reason, const_va is not emitted when the target is MS. +// NOT-MS: !DIDerivedType(tag: DW_TAG_member, name: "const_va", +// NOT-MS-SAME: line: [[@LINE-3]]

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 297355. bogser01 added a comment. Rebase diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tools-extr

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. With `-DLLVM_ENABLE_ASSERTIONS=ON -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_RANLIB_COMPILER=llvm-ranlib -DCMAKE_AR_COMPILER=llvm-ar -DCMAKE_LINKER=ld.lld -DLLVM_ENABLE_LLD=ON` libclang-cpp.dll has 65535 exports, seems it got truncated? Repository:

[PATCH] D88314: Added llvm-string-referencing check

bogser01 added a comment. @aaron.ballman Thank you for picking up this review! Running the check over the entire LLVM causes ~74K warnings across 430 files. As to the false positive rate it's tricky to measure. Based on previous analysis on //flang// codebase, I would say roughly 50% of the fix

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. Reproduced by adding `-DLLVM_ENABLE_ASSERTIONS=ON`. With `-DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON` libLLVM.dll also fails to link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8754

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

joaomoreira added a comment. I noticed that this commit breaks MUSL 1.2.0. Here is an isolated test-case that illustrates the issue: https://godbolt.org/z/6bdnEh Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87822/new/ https://reviews.llvm.org/D8

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jyu2 accepted this revision. jyu2 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

keryell added a comment. Great feature for all the weird pieces of hardware all around the world! :-) Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2229-2233 + SmallVector Args = { + AnnotatedVal, + Builder.CreateBitCast(CGM.EmitAnnotationString(AnnotationStr),

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

hubert.reinterpretcast added a comment. In D89064#2322717 , @Xiangling_L wrote: > In D89064#2320133 , > @hubert.reinterpretcast wrote: > >> Can we use a regex to make this also work in AIX? > > Sure we can also do

[PATCH] D88968: [WebAssembly] Prototype i16x8.q15mulr_sat_s

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8f58bf53a98: [WebAssembly] Prototype i16x8.q15mulr_sat_s (authored by tlively). Changed prior to commit: https://reviews.llvm.org/D88968?vs=29667

[clang] d8f58bf - [WebAssembly] Prototype i16x8.q15mulr_sat_s

Author: Thomas Lively Date: 2020-10-09T21:17:53Z New Revision: d8f58bf53a98574ef14568fd830edac5d1fb37f3 URL: https://github.com/llvm/llvm-project/commit/d8f58bf53a98574ef14568fd830edac5d1fb37f3 DIFF: https://github.com/llvm/llvm-project/commit/d8f58bf53a98574ef14568fd830edac5d1fb37f3.diff LOG:

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

scott.linder added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1579 if (EmitDebugInfo && HaveInsertPoint()) { -Address DebugAddr = address; +Address DebugAddr = AllocaAddr.isValid() ? AllocaAddr : address; bool UsePointerValue = NRVO && ReturnValuePo

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322643 , @mati865 wrote: >> How many exports does your DLL end up with - is it close to the 64k limit, >> or far from it? Is there maybe some other library that is linked in, that >> increases the number of exported s

[clang] 5d74c43 - DirectoryWatcher: add an implementation for Windows

Author: Saleem Abdulrasool Date: 2020-10-09T20:55:57Z New Revision: 5d74c435117526616d2c2665f030263b8f60da1b URL: https://github.com/llvm/llvm-project/commit/5d74c435117526616d2c2665f030263b8f60da1b DIFF: https://github.com/llvm/llvm-project/commit/5d74c435117526616d2c2665f030263b8f60da1b.diff

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d74c4351175: DirectoryWatcher: add an implementation for Windows (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89064: [AIX] Disable two itanium alignment LIT testcases

Xiangling_L added a comment. In D89064#2320133 , @hubert.reinterpretcast wrote: > Can we use a regex to make this also work in AIX? Sure we can also do that. May I ask is that because we prefer letting AIX support as many LIT testcases as possible? Re

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd updated this revision to Diff 297324. compnerd marked an inline comment as done. compnerd added a comment. Herald added a subscriber: jfb. Remove unnecessary include, fix an incorrect wait (verified that unit tests now pass!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:15 +#include "llvm/Support/Windows/WindowsSupport.h" #include #include amccarth wrote: > I don't see a reaso

[PATCH] D88968: [WebAssembly] Prototype i16x8.q15mulr_sat_s

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_q15mulr_saturate_s_i8x16, "V8UsV8UsV8Us", "nc", "simd128") + aheejin wrote: > - Is it implemented in the VM? If not shouldn't we use

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. > How many exports does your DLL end up with - is it close to the 64k limit, or > far from it? Is there maybe some other library that is linked in, that > increases the number of exported symbols (=all), or does this DLL only export > explicitly intended symbols with dl

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

aaron.ballman added a comment. In D88645#2321980 , @jdoerfert wrote: > (Drive By: This is cool) I didn't say this before, but yeah, I agree -- this is really quite neat, thank you for working on it! Comment at: clang/include/clang/Sem

[PATCH] D88314: Added llvm-string-referencing check

aaron.ballman added a comment. It looks like you generated a diff from a previous diff instead of trunk -- can you regenerate the diff against trunk so that reviewers can see the full content of the changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:46 + +void ConstCorrectnessCheck::registerMatchers(MatchFinder *Finder) { + const auto ConstType = hasType(isConstQualified()); JonasToth w

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

DiggerLin added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ https://reviews.llvm.org/D88737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88976: [clang] Use correct address space for global variable debug info

scott.linder added inline comments. Comment at: clang/test/CodeGenHIP/debug-info-address-class.hip:8 + +// CHECK-DAG: ![[FILEVAR0:[0-9]+]] = distinct !DIGlobalVariable(name: "FileVar0", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: {{[0-9]+}}, type: !{{[0-9]+}}, isLocal: false,

[PATCH] D88976: [clang] Use correct address space for global variable debug info

scott.linder updated this revision to Diff 297309. scott.linder added a comment. Replace uses of CHECK-DAG, use more meaningful names in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88976/new/ https://reviews.llvm.org/D88976 Files: clang/l

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

ASDenysPetrov added a comment. In D87547#2322325 , @mati865 wrote: > @ASDenysPetrov what CMake options do you use? > I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. Sorry for not mentioning that. This is my cmd: cmake -GN

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. aeubanks requested review of this revision. Some targets may add required passes via TargetMachine::registerPassBuilderCallbacks(). We need to run those even under -O

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 297297. jhuber6 added a comment. Fixing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/captur

[PATCH] D89130: [WIP][Sparc] Fix long double on 32-bit Solaris/SPARC

efriedma added a comment. SparcTargetLowering::LowerCall_32 is Sparc-specific code. Maybe you can take a look at where it's crashing, and ask some more specific question? The compiler-rt requirement for __uint128_t is a bit inconvenient, I guess; maybe it could be changed, but that's probably

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG40cef5a00eb8: [clang] Add a test for CGDebugInfo treatment of blocks (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88754/new/ ht

[clang] 40cef5a - [clang] Add a test for CGDebugInfo treatment of blocks

Author: Scott Linder Date: 2020-10-09T19:03:21Z New Revision: 40cef5a00eb83f44e946912b74be83e8dc02effb URL: https://github.com/llvm/llvm-project/commit/40cef5a00eb83f44e946912b74be83e8dc02effb DIFF: https://github.com/llvm/llvm-project/commit/40cef5a00eb83f44e946912b74be83e8dc02effb.diff LOG:

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1579 if (EmitDebugInfo && HaveInsertPoint()) { -Address DebugAddr = address; +Address DebugAddr = AllocaAddr.isValid() ? AllocaAddr : address; bool UsePointerValue = NRVO && ReturnValuePointer

[PATCH] D88976: [clang] Use correct address space for global variable debug info

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That looks much nicer. Comment at: clang/test/CodeGenHIP/debug-info-address-class.hip:8 + +// CHECK-DAG: ![[FILEVAR0:[0-9]+]] = distinct !DIGlobalVariable(name: "FileVar0"

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88754/new/ https://reviews.llvm.org/D88754

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mstorsjo added a comment. In D87547#2322325 , @mati865 wrote: > @ASDenysPetrov what CMake options do you use? > I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. How many exports does your DLL end up with - is it close to the

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[&CalledFunctions](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +CalledFunctions.push_back(CE); +}}; --

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

mati865 added a comment. @ASDenysPetrov what CMake options do you use? I'm unable to reproduce this error with Clang+LLD and GCC+Binutils from MSYS2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87547/new/ https://reviews.llvm.org/D87547

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

jasonliu added a comment. In D88737#2321921 , @MaskRay wrote: > A less intrusive approach is to not touch the existing > InitTargetOptionsFromCodeGenFlags without parameters. You can add an > `initTargetOptionsFromCodeGenFlags` with `const Tripe &` as it

[PATCH] D89148: [SyntaxTree] Artificial use of the Mutations API.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Not intended for submission. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89148 Files: clang/include/clang/Tooling/Syntax/

[PATCH] D89147: [SyntaxTree] Improve the signature of `replaceChildRangeLowLevel`.

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Previously `replaceChildRangeLowLevel` took the new child range as a `Node* New`. `New` was expected to have siblings attached already, and thus i

[PATCH] D89146: [SyntaxTree] Fix rtti for `Expression`.

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89146 Files: clang/include/clang/Tooli

[PATCH] D89143: [OpenCL][Docs] Improved description of the supported language functionality.

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:2718 +Clang only supports the full OpenCL profile, and not `the embedded profile +`_. + I am surprised t

[PATCH] D89143: [OpenCL][Docs] Improved description of the supported language functionality.

Anastasia created this revision. Anastasia added reviewers: azabaznov, svenvh. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. As suggested on RFC: http://lists.llvm.org/pipermail/cfe-dev/2020-October/066932.html https://reviews.llvm.org/D89143 Files:

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. In D88498 @rsmith wrote, s far from clear to me that this is correct in C++. In principle, for a dynamic initializer, the rounding mode could have been set by an earlier initializer. Perhaps we can make an argument that, due to the permi

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 297260. mibintc added a comment. I rebased the patch I added documentation to UserManual showing that -ffp-model=strict enables FENV_ACCESS I removed ActOnAfterCompoundStatementLeadingPragmas since it was redundant with work being done in ActOnCompoundStmt

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a24316087d: [clang] Don't look into for C++ headers if they are found alongside… (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] a3a2431 - [clang] Don't look into for C++ headers if they are found alongside the toolchain

Author: Louis Dionne Date: 2020-10-09T12:41:41-04:00 New Revision: a3a24316087d0e1b4db0b8fee19cdee8b7968032 URL: https://github.com/llvm/llvm-project/commit/a3a24316087d0e1b4db0b8fee19cdee8b7968032 DIFF: https://github.com/llvm/llvm-project/commit/a3a24316087d0e1b4db0b8fee19cdee8b7968032.diff

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

jdoerfert added a comment. (Drive By: This is cool) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D88645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Thanks for extending this functionality to Windows! Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:15 +#include "llvm/Support/Windows/

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

dexonsmith updated this revision to Diff 297245. dexonsmith added a comment. Rebased (on top of https://reviews.llvm.org/D89136). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66782/new/ https://reviews.llvm.org/D66782 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.c

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 297246. bogser01 added a comment. Added documentation & Nit fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/llvm/StringRefe

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This is a prep patch for https://reviews.llvm.org/D66782, changing SourceManager to return `Optional` instead of `MemoryBuffer`. With that c

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[&CalledFunctions](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +CalledFunctions.push_back(CE); +}}; ---

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

MaskRay added a comment. A less intrusive approach is to not touch the existing InitTargetOptionsFromCodeGenFlags without parameters. You can add an `initTargetOptionsFromCodeGenFlags` with `const Tripe &` as its parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ http

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added a comment. @NoQ BTW, what you think we should do with D77062 and D88477 then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89055/new/ https://reviews.llvm.or

[PATCH] D89135: [clangd] Stop capturing trace args if the tracer doesn't need them.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The tracer is now expected to allocate+fr

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added a comment. @NoQ > Can we collapse this function further towards this goal? Say, why not pump > every region //unconditionally// through `castRegion()`? Does > `dispatchCast()` use `castRegion()` internally - and if it does, why are > there so many branches in this function?

Re: [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hello Andrzej, Please do not update your bots yet. I will explicitly ask later. Feel free to move other reliably green bots of yours to the production buildbot. Thanks Galina On Fri, Oct 9, 2020 at 3:51 AM Andrzej Warzynski wrote: > I switched one of our workers to the main Buildbot and ever

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1633 + +if (BTy) { + BuiltinType::Kind BTyKind = BTy->getKind(); When can BTy be null? Should this instead be an assert? Instead can we implement this without looking at t

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

teemperor added a comment. I think we could at least have a unittest that just calls these functions with an invalid SourceLocation. `unittests/Basic/SourceManagerTest.cpp` already takes care of creating a valid SourceManager object, so the unit test would just be a single call to each method.

[PATCH] D89102: [X86] Add HRESET instruction.

pengfei updated this revision to Diff 297234. pengfei added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89102/new/ https://reviews.llvm.org/D89102 Files: clang/docs/ClangCommandLineReference.rst clang/incl

[PATCH] D89102: [X86] Add HRESET instruction.

pengfei marked an inline comment as done. pengfei added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89102/new/ https://reviews.llvm.org/D89102 ___ cfe-commits mailing

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

This revision was automatically updated to reflect the committed changes. Closed by commit rG71d3b7ec7b62: [OpenCL] Add new compilation mode for OpenCL 3.0. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 71d3b7e - [OpenCL] Add new compilation mode for OpenCL 3.0.

Author: Anastasia Stulova Date: 2020-10-09T15:28:38+01:00 New Revision: 71d3b7ec7b62d37dd3c8eb1a921f0b3e1ffdaa7f URL: https://github.com/llvm/llvm-project/commit/71d3b7ec7b62d37dd3c8eb1a921f0b3e1ffdaa7f DIFF: https://github.com/llvm/llvm-project/commit/71d3b7ec7b62d37dd3c8eb1a921f0b3e1ffdaa7f.d

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 297231. JonasToth added a comment. - missed one place of decltype Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clang-tools-extra/clang-tidy/cppcoreguideli

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson added a comment. After chatting with bkramer , I'm working on rebasing this diff so that it can be landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 _

[clang-tools-extra] 41d2987 - [clangd] Stop logging in fromJSON, report instead.

Author: Sam McCall Date: 2020-10-09T16:15:45+02:00 New Revision: 41d2987c7558734cef74151e743645f47d9df501 URL: https://github.com/llvm/llvm-project/commit/41d2987c7558734cef74151e743645f47d9df501 DIFF: https://github.com/llvm/llvm-project/commit/41d2987c7558734cef74151e743645f47d9df501.diff LO

[clang] d91234b - [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test

Author: Fanbo Meng Date: 2020-10-09T10:14:44-04:00 New Revision: d91234b21c1a1a34d98157089a8769d8f9a32f06 URL: https://github.com/llvm/llvm-project/commit/d91234b21c1a1a34d98157089a8769d8f9a32f06 DIFF: https://github.com/llvm/llvm-project/commit/d91234b21c1a1a34d98157089a8769d8f9a32f06.diff LO

[PATCH] D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd91234b21c1a: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test (authored by fanbo-meng). Repository: rG LLVM Github

[PATCH] D89131: [clangd] Validate optional fields more strictly.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Mono

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson added inline comments. Comment at: include/clang/Driver/Options.td:1157 +def fno_delete_null_pointer_checks : Flag<["-"], "fno-delete-null-pointer-checks">, + Group, Flags<[CC1Option]>; rjmccall wrote: > Please include HelpText, and it's probably w

[PATCH] D89130: [WIP][Sparc] Fix long double on 32-bit Solaris/SPARC

ro created this revision. ro added reviewers: efriedma, brad. Herald added subscribers: Sanitizers, s.egerton, dexonsmith, jrtc27, simoncook, fedor.sergeev, hiraditya, mgorny, jyknight. Herald added projects: clang, Sanitizers, LLVM. ro requested review of this revision. The SysVr4 SPARC psABI pr

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

ASDenysPetrov reopened this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. Hi, @mati865 Currently I got an error while building with GCC10 on Win10. [2325/2656] Linking CXX shared library bin\libclang-cpp.dll FAILED: bin/libclang-cpp.dll lib/libclang

[clang] 0741a2c - [Clang][unittests][NFC] Break up test in Callbacks.cpp

Author: Stefan Pintilie Date: 2020-10-09T08:53:50-05:00 New Revision: 0741a2c9caca864fc30af2104712d02accdc12e6 URL: https://github.com/llvm/llvm-project/commit/0741a2c9caca864fc30af2104712d02accdc12e6 DIFF: https://github.com/llvm/llvm-project/commit/0741a2c9caca864fc30af2104712d02accdc12e6.dif

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0741a2c9caca: [Clang][unittests][NFC] Break up test in Callbacks.cpp (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 297224. JonasToth added a comment. - fix platform dependent warning message for decltype to just match the beginning and not the 'a.k.a' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://revie

[PATCH] D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89127/new/ https://reviews.llvm.org/D89127 ___

[PATCH] D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test

fanbo-meng created this revision. fanbo-meng added reviewers: abhina.sreeskantharajan, uweigand, Kai, hubert.reinterpretcast. Herald added subscribers: cfe-commits, krytarowski. Herald added a project: clang. fanbo-meng requested review of this revision. z/OS defaults to 16 bytes for __attribute

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3683 + auto *Attr = + AnnotateAttr::Create(Context, Str, Args.empty() ? nullptr : Args.data(), + Args.size(), CI.getRange(), CI.getSyntax()); aaron.ballman wr

[clang-tools-extra] fe4715c - Remove old create(MainFile)?IncludeInsertion overloads

Author: Alexander Kornienko Date: 2020-10-09T15:24:57+02:00 New Revision: fe4715c47f9c02a83b339c12067f1d27a3115fe4 URL: https://github.com/llvm/llvm-project/commit/fe4715c47f9c02a83b339c12067f1d27a3115fe4 DIFF: https://github.com/llvm/llvm-project/commit/fe4715c47f9c02a83b339c12067f1d27a3115fe4

[PATCH] D89117: Remove old create(MainFile)?IncludeInsertion overloads

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe4715c47f9c: Remove old create(MainFile)?IncludeInsertion overloads (authored by alexfh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89117/new/ https://

[PATCH] D89126: [clangd] Support CodeActionParams.only

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Mo

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

lebedev.ri updated this revision to Diff 297217. lebedev.ri added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88979/new/ https://reviews.llvm.org/D889

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 297215. JonasToth marked an inline comment as done. JonasToth added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clan

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt:37 + clangLex + clangSerialization clangTidy aaron.ballman wrote: > Why do serialization and lex need to be

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

Abpostelnicu added a comment. In D79388#2321231 , @MyDeveloperDay wrote: > Not to my knowledge, if we are not going to fix it we should probably revert > it for now, we can bring it back later I'm a strong supporter of reverting it for the moment. Rep

[PATCH] D89091: Regenerate ClangCommandLineReference.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rGb581c5a42f05: Regenerate ClangCommandLineReference.rst (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] b581c5a - Regenerate ClangCommandLineReference.rst

Author: Konstantin Zhuravlyov Date: 2020-10-09T08:29:53-04:00 New Revision: b581c5a42f052d4d02f1152d0e1ff2d54668e6a0 URL: https://github.com/llvm/llvm-project/commit/b581c5a42f052d4d02f1152d0e1ff2d54668e6a0 DIFF: https://github.com/llvm/llvm-project/commit/b581c5a42f052d4d02f1152d0e1ff2d54668e6

[PATCH] D86828: [windows-itanium] make dllimport/export handling closer to MS behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb148ad426f8: [windows-itanium] make dllimport/export handling closer to MS behavior (authored by Ben Dunbobbin ). Herald added a project: clang. Herald added a subscriber: cfe-com

[clang] bb148ad - [windows-itanium] make dllimport/export handling closer to MS behavior

Author: Ben Dunbobbin Date: 2020-10-09T13:24:07+01:00 New Revision: bb148ad426f8c7e6a6f968d54796f872685a00b2 URL: https://github.com/llvm/llvm-project/commit/bb148ad426f8c7e6a6f968d54796f872685a00b2 DIFF: https://github.com/llvm/llvm-project/commit/bb148ad426f8c7e6a6f968d54796f872685a00b2.diff

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[&CalledFunctions](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +CalledFunctions.push_back(CE); +}}; --

Re: [clang] 4eb627e - first upstream review

On Fri, Oct 9, 2020 at 3:21 PM Ben Dunbobbin via cfe-commits wrote: > > > Author: Ben Dunbobbin > Date: 2020-10-09T13:21:03+01:00 > New Revision: 4eb627ed96e3f2f9f24aec8a0654ce5204874bb8 > > URL: > https://github.com/llvm/llvm-project/commit/4eb627ed96e3f2f9f24aec8a0654ce5204874bb8 > DIFF: > htt

[clang] a9f1bb9 - Revert "first upstream review"

Author: Ben Dunbobbin Date: 2020-10-09T13:22:46+01:00 New Revision: a9f1bb92bfb1efc005b53bf9ea18ad5e902386fc URL: https://github.com/llvm/llvm-project/commit/a9f1bb92bfb1efc005b53bf9ea18ad5e902386fc DIFF: https://github.com/llvm/llvm-project/commit/a9f1bb92bfb1efc005b53bf9ea18ad5e902386fc.diff

  1   2   >