[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70d9dc867417: [AST][RecoveryExpr] Support dependent binary operator in C for error recovery. (authored by hokein). Repository: rG LLVM Github Mono

[clang] 70d9dc8 - [AST][RecoveryExpr] Support dependent binary operator in C for error recovery.

Author: Haojian Wu Date: 2020-10-06T08:53:31+02:00 New Revision: 70d9dc867417ac63fe280ab145776f75a9487f0f URL: https://github.com/llvm/llvm-project/commit/70d9dc867417ac63fe280ab145776f75a9487f0f DIFF: https://github.com/llvm/llvm-project/commit/70d9dc867417ac63fe280ab145776f75a9487f0f.diff LO

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 296367. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226 Files: clang/include/clang/A

[PATCH] D88491: [ASTContext] Use AllowCXX in all merge*Type methods, strip references

jdoerfert added a comment. In D88491#2306099 , @aaron.ballman wrote: > Do you have test cases for this change? I didn't see any relevant ones in > D88384 . In the revert (rG4fc69ab002382675d84f611f22599cb3cb4a0787

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

asbirlea added a comment. Thank you, Ankit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88138/new/ https://reviews.llvm.org/D88138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D88477: [analyzer] Overwrite cast type in getBinding only if that was null originally

NoQ added a comment. > i'm pretty worried about our ability to actually achieve that in the near > future This whole cast problem that you're looking into in D85528 is definitely a part of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

NoQ added a comment. With Z3 //constraint// manager you absolutely want your constraints to be as precise as possible. The only reason we don't add these casts is because it confuses the constraint manager a lot. With a better constraint manager we would have spared ourselves a lot of suffering

Buildbot numbers for the week of 09/20/2020 - 09/26/2020

Hello everyone, Below are some buildbot numbers for the week of 09/20/2020 - 09/26/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

Buildbot numbers for the week of 09/13/2020 - 09/19/2020

Hello everyone, Below are some buildbot numbers for the week of 09/13/2020 - 09/19/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

Buildbot numbers for the week of 09/27/2020 - 10/03/2020

Hello everyone, Below are some buildbot numbers for the last week of 09/27/2020 - 10/03/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

nomanous added a comment. In D87962#2312617 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes I need! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___

[PATCH] D88275: [ASTMatchers] Add matcher `hasParentIgnoringImplicit`.

ymandel added a comment. In D88275#2305989 , @aaron.ballman wrote: > In D88275#2303283 , @ymandel wrote: > >>> I'm not concerned about the basic idea behind the proposed matcher, I'm >>> only worried we're making

[clang] ded79be - [c++17] Implement P0145R3 during constant evaluation.

Author: Richard Smith Date: 2020-10-05T19:04:14-07:00 New Revision: ded79be63555f4e5bfdb0db27ef22b71fe568474 URL: https://github.com/llvm/llvm-project/commit/ded79be63555f4e5bfdb0db27ef22b71fe568474 DIFF: https://github.com/llvm/llvm-project/commit/ded79be63555f4e5bfdb0db27ef22b71fe568474.diff

[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

shivanshu3 updated this revision to Diff 296340. shivanshu3 added a comment. Address Reid's comments: - Use hasFlag instead of hasArg - Add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88680/new/ https://reviews.llvm.org/D88680 Files:

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

jrtc27 added a comment. In D88759#2313236 , @thakis wrote: > This seems to break tests: http://45.33.8.238/linux/29545/step_7.txt > > Can you take a look and revert for now if it takes a while to fix? I see it should already have been fixed in a48d480e1f

[PATCH] D88863: [docs] Fix vector literal examples that don't compile

ahatanak planned changes to this revision. ahatanak added a comment. The parenthesis initialization does not work as documented for GCC or OpenCL vectors, so that has to be fixed too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88863/new/ https:

[clang] a48d480 - [RISCV] Fix broken test

Author: Evandro Menezes Date: 2020-10-05T19:28:31-05:00 New Revision: a48d480e1f7ebc5d5f93507fe1f519496621e259 URL: https://github.com/llvm/llvm-project/commit/a48d480e1f7ebc5d5f93507fe1f519496621e259 DIFF: https://github.com/llvm/llvm-project/commit/a48d480e1f7ebc5d5f93507fe1f519496621e259.dif

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/29545/step_7.txt Can you take a look and revert for now if it takes a while to fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88759/new/ https://reviews.llvm.org/D8875

[PATCH] D88863: [docs] Fix vector literal examples that don't compile

ahatanak created this revision. ahatanak added reviewers: nemanjai, ayartsev. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. ahatanak requested review of this revision. Guard the AltiVec vector variables with `#ifdef __VEC__` and remove the last line, wh

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd created this revision. compnerd added reviewers: gribozavr2, MForster. Herald added subscribers: jfb, mgorny. Herald added a project: clang. compnerd requested review of this revision. This adds the skeleton of the YAML Compiler for APINotes. This change only adds the YAML IO model for t

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

bsaleil accepted this revision. bsaleil added a comment. LGTM, please fix the unrelated change when committing. Comment at: clang/test/CodeGen/builtins-ppc-vsx.c:1 -// REQUIRES: powerpc-registered-target +// requires: powerpc-registered-target // RUN: %clang_cc1 -target-featur

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

nikic added a comment. This ended up having a rather large impact... Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=567462b48eba1c2d286ce97117994463f4535d2e&to=e00f189d392dd9bf95f6a98f05f2d341d06cd65c&stat=instructions Code size: https://llvm-compile-time-tracker.com/compa

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

yaxunl added a comment. This patch may break some existing HIP applications. For rdc mode, device vars are merged. Host shadow vars should also be in comdat and merged. HIP runtime just ignores the same shadow var registered with the same device var, everything should work. For nordc mode, dev

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

aaron.ballman added a comment. One request though: can you add a release note about the removal with a brief explanation of why it was removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://reviews.llvm.org/D88831 _

[clang] e00f189 - [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

Author: Roman Lebedev Date: 2020-10-06T00:00:30+03:00 New Revision: e00f189d392dd9bf95f6a98f05f2d341d06cd65c URL: https://github.com/llvm/llvm-project/commit/e00f189d392dd9bf95f6a98f05f2d341d06cd65c DIFF: https://github.com/llvm/llvm-project/commit/e00f189d392dd9bf95f6a98f05f2d341d06cd65c.diff

[clang] 5d6d8a2 - [RISCV] Add SiFive cores to the CPU option

Author: Evandro Menezes Date: 2020-10-05T15:50:57-05:00 New Revision: 5d6d8a2769b3a91fd65b125c2cda64ea27a894bf URL: https://github.com/llvm/llvm-project/commit/5d6d8a2769b3a91fd65b125c2cda64ea27a894bf DIFF: https://github.com/llvm/llvm-project/commit/5d6d8a2769b3a91fd65b125c2cda64ea27a894bf.dif

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe00f189d392d: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D88759: [RISCV] Add SiFive cores to the CPU option

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d6d8a2769b3: [RISCV] Add SiFive cores to the CPU option (authored by evandro). Herald added subscribers: cfe-commits, jrtc27. Herald added a project: clang. Changed prior to commit: https://reviews.llv

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16447 + +bool AIXBitfieldViolation = false; +if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs()) { sfertile wrote: > Can this change can be split out into its own patch? I

[PATCH] D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination

ddcc added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88349/new/ https://reviews.llvm.org/D88349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

DiggerLin added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:46 ///< aliases to base ctors when possible. -CODEGENOPT(DataSections , 1, 0) ///< Set when -fdata-sections is enabled. +CODEGENOPT(DataSections

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2cc8833683d: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Do you need someone to commit on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87962/new/ https://reviews.llvm.org/D87962 ___ cfe-commits mailing list cfe

[clang] a2cc883 - [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

Author: Fangrui Song Date: 2020-10-05T12:53:59-07:00 New Revision: a2cc8833683dd124cf2ee96f6d17f7f835da1fc8 URL: https://github.com/llvm/llvm-project/commit/a2cc8833683dd124cf2ee96f6d17f7f835da1fc8 DIFF: https://github.com/llvm/llvm-project/commit/a2cc8833683dd124cf2ee96f6d17f7f835da1fc8.diff

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM to remove rather than move into `readability` unless someone has a good argument as to why it belongs there. I don't think this pattern makes code more readable in general as it recommends using a more verbose syntax (poin

[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

fanbo-meng updated this revision to Diff 296269. fanbo-meng added a comment. fix no newline at end of file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88845/new/ https://reviews.llvm.org/D88845 Files: clang/lib/Basic/Targets/OSTargets.h clang/test/CodeGen/zos-alignment.c Index:

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin updated this revision to Diff 296267. DiggerLin marked 3 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451 Files: clang/docs/Cla

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin marked 7 inline comments as done. DiggerLin added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file(XCOFF only) + -

[PATCH] D88845: [SystemZ][z/OS] Set default alignment rules for z/OS target

fanbo-meng created this revision. fanbo-meng added reviewers: abhina.sreeskantharajan, hubert.reinterpretcast, Kai, uweigand. Herald added a project: clang. Herald added a subscriber: cfe-commits. fanbo-meng requested review of this revision. Set the default alignment control variables for z/OS t

[PATCH] D88844: [clangd] Add `score` extension to workspace/symbol response.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The protocol doesn't really incorporate r

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/test/Layout/aix-bitfield-alignment.cpp:118 + +typedef __attribute__((aligned(32))) short mySHORT; +struct D { We should have a similar test for an overaligned long or long long. CHANGES SINCE LAST ACTION https

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri added a comment. In D88789#2312510 , @lebedev.ri wrote: > So, we can't really teach SCEV about this: D88788 > (not without the > https://bugs.llvm.org/show_bug.cgi?id=47592 at least) > And we can't recover the

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri added a comment. So, we can't really teach SCEV about this: D88788 (not without the https://bugs.llvm.org/show_bug.cgi?id=47592 at lease) And we can't recover the situation post-inlining in instcombine: D88842 . It r

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

efriedma added a comment. > Keeping loads and stores of pointers as pointers to the extent possible > doesn't seem like a bad idea, but I'm worried people will feel like this > gives a *semantic* guarantee that isn't really there. Fundamentally, LLVM > still doesn't currently have typed memory.

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

tra added a comment. In D88786#2312365 , @MaskRay wrote: >> Could you provide an example where this is causing an issue? > > If the C++17 inline variable appears in two TUs. They have the same comdat > group. The first comdat group is prevailing and the s

[clang-tools-extra] 95262ee - [clangd] Describe non-handling of most IWYU pragmas. NFC

Author: Sam McCall Date: 2020-10-05T20:50:26+02:00 New Revision: 95262ee2be75daffd05e9a8a985ca2c8e34c9af7 URL: https://github.com/llvm/llvm-project/commit/95262ee2be75daffd05e9a8a985ca2c8e34c9af7 DIFF: https://github.com/llvm/llvm-project/commit/95262ee2be75daffd05e9a8a985ca2c8e34c9af7.diff LO

[PATCH] D88822: [clangd] Describe non-handling of most IWYU pragmas. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG95262ee2be75: [clangd] Describe non-handling of most IWYU pragmas. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88822/new/ htt

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14381 + OpLoc, CurFPFeatureOverrides()); +switch (Opc) { +case BO_Assign: now the only thing that differs between the cases is the type. Yo

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1643 + } else { +// Handle AIX oversized Long Long bitfield under 32 bit compile mode. +if (StorageUnitSize > 32 && I get different results for using a long lon

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

MaskRay added a comment. In D88786#2312329 , @tra wrote: >> If such a variable (which has a comdat group) is discarded (a copy from >> another >> translation unit is prevailing and selected), accessing the variable from >> outside the section group (__cud

[PATCH] D88446: docs: add documentation describing API Notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85d506400081: docs: add documentation describing API Notes (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D88446?vs=295

[clang] 85d5064 - docs: add documentation describing API Notes

Author: Saleem Abdulrasool Date: 2020-10-05T18:29:13Z New Revision: 85d506400081e121ef876a4c66fb337b050dcae6 URL: https://github.com/llvm/llvm-project/commit/85d506400081e121ef876a4c66fb337b050dcae6 DIFF: https://github.com/llvm/llvm-project/commit/85d506400081e121ef876a4c66fb337b050dcae6.diff

[PATCH] D88786: [CUDA] Don't call __cudaRegisterVariable on C++17 inline variables

tra added a comment. > If such a variable (which has a comdat group) is discarded (a copy from > another > translation unit is prevailing and selected), accessing the variable from > outside the section group (__cuda_register_globals) is a violation of the ELF > specification and will be rejected

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

nemanjai added a comment. Hi @gribozavr do you think we can do something about this test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 ___ cfe-commits mailing

[PATCH] D88013: [AArch64] Correct parameter type for unsigned Neon scalar shift intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88013/new/ https://reviews.llvm.org/D88013 _

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. In D88659#2306403 , @jyknight wrote: > Hm, to start with, the current state of this confuses me. > > In GCC, the preprocessor macro `__BIGGEST_ALIGNMENT__` was supposed to expose > the alignment used by `__attribute__((aligned

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. For the LIT test clang/test/AST/const-fpfeatures.cpp, currently failing in this patch, the variables V1 and others are initialized via call to "global var init" which performs the rounding at execution time, I think that's correct not certain. Repository: rG LLVM Gi

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 296221. mibintc added a comment. In the previous version of this patch, I enabled FENV_ACCESS if frounding-math, but @sepavloff commented that this deduction is not correct. I changed the logic to check for the "ffp-model=strict" settings, and if those sett

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14365 + "Should only occur in error-recovery path."); +if (BinaryOperator::isCompoundAssignmentOp(Opc)) + return CompoundAssignOperator::Create( sammccall wrote: > isAssignme

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

hokein updated this revision to Diff 296218. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84226/new/ https://reviews.llvm.org/D84226 Files: clang/include/clang/A

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

jmorse added a comment. Hi -- We (Sony) are running into a bit of difficulty with the test for this change, as it relies on the configuration of the -O1 optimisation pipeline. Would it be possible to reduce down to a frontend test, and then tests for whatever passes are to interpret the IR prod

[clang] 8d51d37 - [flang] Introduce DiagnosticConsumer classes in libflangFrontend

Author: Andrzej Warzynski Date: 2020-10-05T17:46:44+01:00 New Revision: 8d51d37e0628bde3eb5a3200507ba7135dfc2751 URL: https://github.com/llvm/llvm-project/commit/8d51d37e0628bde3eb5a3200507ba7135dfc2751 DIFF: https://github.com/llvm/llvm-project/commit/8d51d37e0628bde3eb5a3200507ba7135dfc2751.d

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d51d37e0628: [flang] Introduce DiagnosticConsumer classes in libflangFrontend (authored by awarzynski). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jhuber6 updated this revision to Diff 296204. jhuber6 added a comment. Changing method of determining architecture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 Files: clang/include/clang/Basic/Diagnos

[PATCH] D88754: [clang] Add a test for CGDebugInfo treatment of blocks

aprantl added a comment. I think that this should either hardcode a 64-bit architecture or it shouldn't test for explicit offsets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88754/new/ https://reviews.llvm.org/D88754 __

[clang] 1dce692 - Revert "[OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload"

Author: Joseph Huber Date: 2020-10-05T12:35:39-04:00 New Revision: 1dce692de1896412693f25a3afb4818883a611e7 URL: https://github.com/llvm/llvm-project/commit/1dce692de1896412693f25a3afb4818883a611e7 DIFF: https://github.com/llvm/llvm-project/commit/1dce692de1896412693f25a3afb4818883a611e7.diff

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Google C++ style guide does not have this rule anymore. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:410-411 setRoundingMode(LO.getFPRoundingMode()); +// FENV access is true if rounding math is enabled. +setAllowFEnvAccess((getRoundingMode() == llvm::RoundingMode::Dynamic)); setF

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. I neglected to hit the "submit" button last week, these are the inline questions I have. Also in addition to the comments above, check-clang is showing 1 LIT test failing AST/const-fpfeatures.cpp I believe the clang constant folder is returning False for the expression,

Re: [PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

Nice! I'm glad to see the patch being revived. Thanks for that :) Em seg, 5 de out de 2020 10:48, fiesh via Phabricator < revi...@reviews.llvm.org> escreveu: > fiesh added a comment. > > Continued in https://reviews.llvm.org/D88833 > > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D311

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf73293cb6b: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload (authored by jhuber6). Repository: rG LLVM Github Monor

[clang] eaf7329 - [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

Author: Joseph Huber Date: 2020-10-05T11:02:13-04:00 New Revision: eaf73293cb6b8d45dd85ffced57aea7ad4177754 URL: https://github.com/llvm/llvm-project/commit/eaf73293cb6b8d45dd85ffced57aea7ad4177754 DIFF: https://github.com/llvm/llvm-project/commit/eaf73293cb6b8d45dd85ffced57aea7ad4177754.diff

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

DiggerLin added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:46 ///< aliases to base ctors when possible. -CODEGENOPT(DataSections , 1, 0) ///< Set when -fdata-sections is enabled. +CODEGENOPT(DataSections

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16447 + +bool AIXBitfieldViolation = false; +if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs()) { Can this change can be split out into its own patch? If it can i would sugg

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:74 auto Names = splitQualifiedName(Query); Add a comment here (or elsewhere, I guess) about how qualified names are handled. - exact namespace: boosted on the index sid

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added a subscriber: jyknight. jdoerfert added a comment. One minor nit from me. @jyknight @aaron.ballman @rjmccall any more thoughts? Comment at: clang/lib/CodeGen/CGStmt.cpp:801 + getLangOpts().CPlusPlus11 || getLangOpts().CPlusPlus14 || + ge

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

sameeranjoshi accepted this revision. sameeranjoshi added a comment. Thanks for patch. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/D87774 ___ cfe-commits

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

baloghadamsoftware added a comment. In D88831#2311802 , @lebedev.ri wrote: > In D88831#2311800 , @Eugene.Zelenko > wrote: > >> Does this check make sense in content of other style guides? > > I'd +1 to moving it to

[PATCH] D88594: [OpenMP] Add Error Handling for Conflicting Pointer Sizes for Target Offload

jdoerfert accepted this revision. jdoerfert added a comment. LGTM, a new triple makes sense here, we don't support arbitrary combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88594/new/ https://reviews.llvm.org/D88594 ___

[PATCH] D88829: [OpenMP][RTL] Remove dead code

JonChesterfield accepted this revision. JonChesterfield added a comment. Thanks guys, will remember that as the local convention on rolling whitespace changes into other stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88829/new/ https://revie

[PATCH] D88829: [OpenMP][RTL] Remove dead code

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, thanks for removing dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88829/new/ https://reviews.llvm.org/D88829 ___

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

lebedev.ri added a comment. In D88831#2311800 , @Eugene.Zelenko wrote: > Does this check make sense in content of other style guides? I'd +1 to moving it to `readability`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

Eugene.Zelenko added a comment. Does this check make sense in content of other style guides? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88831/new/ https://reviews.llvm.org/D88831 ___ cfe-commits maili

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

lebedev.ri updated this revision to Diff 296173. lebedev.ri added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88789/new/ https://reviews.llvm.org/D88789 Files: clang/test/CodeGen/attr-arm-sve-vector-bits-bitcast.c clang/test/C

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. Continued in https://reviews.llvm.org/D88833 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31130/new/ https://reviews.llvm.org/D31130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D88833: Do not warn on pointer decays in system macros

fiesh created this revision. fiesh added a reviewer: aaron.ballman. fiesh added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. fiesh requested review of this revision. As system headers are in general out of reach, it makes no

[PATCH] D88829: [OpenMP][RTL] Remove dead code

grokos added a comment. In D88829#2311768 , @JonChesterfield wrote: > Rolling the reduction in leading whitespace in > nvptx_target_parallel_reduction_codegen.cpp in with the patch might be > contentious, added a couple more reviewers to see if other pe

[PATCH] D88829: [OpenMP][RTL] Remove dead code

JonChesterfield added a comment. Change looks great to me. Rolling the reduction in leading whitespace in nvptx_target_parallel_reduction_codegen.cpp in with the patch might be contentious, added a couple more reviewers to see if other people would prefer that part split out. I'll accept in a

[PATCH] D88831: [clang-tidy] Remove obsolete checker google-runtime-references

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, gribozavr2, aaron.ballman. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: martong, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun, whisperity, mgorny. Herald added a

[clang] 7a932f4 - [Parser] ParseMicrosoftAsmStatement - Replace bit '|' operator with logical '||' operator. (PR47071)

Author: Simon Pilgrim Date: 2020-10-05T14:23:28+01:00 New Revision: 7a932f4f4ccbc0c4294c6911d404f74529f3259b URL: https://github.com/llvm/llvm-project/commit/7a932f4f4ccbc0c4294c6911d404f74529f3259b DIFF: https://github.com/llvm/llvm-project/commit/7a932f4f4ccbc0c4294c6911d404f74529f3259b.diff

[PATCH] D88810: [clangd] Add isKeyword function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1425c7223676: [clangd] Add isKeyword function. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang-tools-extra] 1425c72 - [clangd] Add isKeyword function.

Author: Haojian Wu Date: 2020-10-05T15:11:24+02:00 New Revision: 1425c72236766ad9107d86cb645ee8c6a3ee0eb1 URL: https://github.com/llvm/llvm-project/commit/1425c72236766ad9107d86cb645ee8c6a3ee0eb1 DIFF: https://github.com/llvm/llvm-project/commit/1425c72236766ad9107d86cb645ee8c6a3ee0eb1.diff LO

[PATCH] D88810: [clangd] Add isKeyword function.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:638 + // Keywords are initialized in constructor. + clang::IdentifierTable KeywordsTable(LangOpts); + return KeywordsTable.find(NewName) != KeywordsTable.end(); sammccall wrote:

[PATCH] D88810: [clangd] Add isKeyword function.

hokein updated this revision to Diff 296168. hokein marked an inline comment as done. hokein added a comment. address code comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88810/new/ https://reviews.llvm.org/D88810 Files: clang-tools-extr

[PATCH] D84226: [AST][RecoveryExpr] Part1: Support dependent binary operator in C for error recovery.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/ASTContext.h:668 + // clang's C-only codepath doesn't support dependent types yet, it is used to + // perform early typo cor

[PATCH] D88828: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, but can you add some description about why you've decided to do it now :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88828/new/ htt

[PATCH] D88828: [clangd] Verify the diagnostic code in include-fixer diagnostic tests, NFC.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: clang. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[clang] 007dd12 - [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

Author: Gabor Marton Date: 2020-10-05T14:06:09+02:00 New Revision: 007dd12d546814977519b33ca38b1cc8b31fee26 URL: https://github.com/llvm/llvm-project/commit/007dd12d546814977519b33ca38b1cc8b31fee26 DIFF: https://github.com/llvm/llvm-project/commit/007dd12d546814977519b33ca38b1cc8b31fee26.diff

[PATCH] D88745: [clangd][WIP] Add new code completion signals to improve MRR by 3%.

usaxena95 updated this revision to Diff 296159. usaxena95 edited the summary of this revision. usaxena95 added a comment. Updated the references to old signals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88745/new/ https://reviews.llvm.org/D8874

[PATCH] D88665: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG007dd12d5468: [ASTImporter][AST] Fix structural equivalency crash on dependent FieldDecl (authored by martong). Repository: rG LLVM Github Monorep

  1   2   >