nomanous added a comment.
Ping @rsmith
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87962/new/
https://reviews.llvm.org/D87962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
thanks.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1147
+getDeclAtPosition(AST, *CurLoc, Relations);
+std::vector AdditionalDecls;
+// If the results incl
baloghadamsoftware added a comment.
Now I completely know what the source of our misunderstanding is. You thought
that this patch will **fix** an issue, namely that we store iterator positions
for both the iterator values and the locations of the iterator variables. While
this is definitely a w
zoecarver marked 3 inline comments as done.
zoecarver added inline comments.
Comment at: clang/test/CodeGenCXX/builtin-zero-non-value-bits-codegen.cpp:16
+ Bar f;
+};
+
jfb wrote:
> It would be helpful to have a comment with the final layout of the struct,
> in
zoecarver updated this revision to Diff 294603.
zoecarver marked 3 inline comments as done.
zoecarver added a comment.
- Add UnsizedTail codegen test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87974/new/
https://reviews.llvm.org/D87974
Files:
myhsu created this revision.
Herald added subscribers: cfe-commits, dang, mgorny.
Herald added a project: clang.
myhsu requested review of this revision.
Herald added a subscriber: ormris.
Add new toolchain and driver options for the M680x0 target
Repository:
rG LLVM Github Monorepo
https://r
myhsu created this revision.
Herald added subscribers: cfe-commits, mgorny.
Herald added a reviewer: aaron.ballman.
Herald added a project: clang.
myhsu requested review of this revision.
1. Add M68K as new Clang target
2. Add new attribute to support M68K's ISR (Interrupt Service Routine)
Repos
jdoerfert updated this revision to Diff 294596.
jdoerfert added a comment.
Add instantiation check and expand test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88384/new/
https://reviews.llvm.org/D88384
Files:
clang/lib/Sema/SemaOpenMP.cpp
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
I think the assertion is correct: if we reach this point, then we have a
`DeclRefExpr` that is not value-dependent and refers to a declaration whose
initializer is value-dependent. T
craig.topper updated this revision to Diff 294593.
craig.topper added a comment.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Rebase and add a backend test file
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87888/new/
http
Author: Richard Smith
Date: 2020-09-27T20:05:39-07:00
New Revision: df2a1f2aabf6692daa83e849f0fdc37f9e402fca
URL:
https://github.com/llvm/llvm-project/commit/df2a1f2aabf6692daa83e849f0fdc37f9e402fca
DIFF:
https://github.com/llvm/llvm-project/commit/df2a1f2aabf6692daa83e849f0fdc37f9e402fca.diff
BRevzin added inline comments.
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h:167-171
-
-inline bool operator!=(const DWARFExpression::iterator &LHS,
- const DWARFExpression::iterator &RHS) {
- return !(LHS == RHS);
-}
dbla
On Tue, 22 Sep 2020 at 17:42, Leonard Chan via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: Leonard Chan
> Date: 2020-09-22T17:40:53-07:00
> New Revision: 15d94a7d0f8f0d6b3b5308fff51b286957e45650
>
> URL:
> https://github.com/llvm/llvm-project/commit/15d94a7d0f8f0d6b3b5308fff51b28695
Author: Richard Smith
Date: 2020-09-27T19:05:26-07:00
New Revision: 9dcd96f728863d40d6f5922ed52732fdd728fb5f
URL:
https://github.com/llvm/llvm-project/commit/9dcd96f728863d40d6f5922ed52732fdd728fb5f
DIFF:
https://github.com/llvm/llvm-project/commit/9dcd96f728863d40d6f5922ed52732fdd728fb5f.diff
rsmith added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:875-876
"C++ standards before C++20">, InGroup, DefaultIgnore;
+def err_anon_bitfield_member_init : Error<
+ "anonymous bit-field cannot have an in-class initializer">;
def err_incomp
nridge marked 3 inline comments as done.
nridge added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1150
+ if (llvm::isa(D) || llvm::isa(D)) {
+Decls = getDeclAtPosition(AST, *CurLoc,
+ Relations | DeclRelation::Unde
nridge updated this revision to Diff 294580.
nridge added a comment.
Address review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87225/new/
https://reviews.llvm.org/D87225
Files:
clang-tools-extra/clangd/XRefs.cpp
clang-tools-extra/cl
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, only nits here. Please feel free to submit after addressing them, or
request another round of review if you prefer.
Comment at: clang/lib/Sema/SemaInit.cpp:3115-3118
nridge updated this revision to Diff 294577.
nridge marked 5 inline comments as done.
nridge added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87256/new/
https://reviews.llvm.org/D87256
Files:
clang-tools-ext
atmnpatel updated this revision to Diff 294575.
atmnpatel added a comment.
rebase to hopefully fix buildbot
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86841/new/
https://reviews.llvm.org/D86841
Files:
clang/lib/CodeGen/CGLoopInfo.cpp
clang/
atmnpatel updated this revision to Diff 294570.
atmnpatel added a comment.
All language standards (minus gnu extensions) are now tested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86841/new/
https://reviews.llvm.org/D86841
Files:
clang/lib/Co
atmnpatel added inline comments.
Comment at: clang/test/CodeGen/attr-mustprogress-0.cpp:2
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --check-attributes
+// RUN: %clang_cc1 -S -emit-llvm %s -o - | FileCheck %s
+
chang
atmnpatel updated this revision to Diff 294569.
atmnpatel added a comment.
Split them into pre and post forward progress requirement tests, now the
difference is much easier to catch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86841/new/
https:
jdoerfert updated this revision to Diff 294567.
jdoerfert added a comment.
Remove lefotver dump
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88384/new/
https://reviews.llvm.org/D88384
Files:
clang/lib/Sema/SemaOpenMP.cpp
clang/test/AST/ast-du
jdoerfert created this revision.
jdoerfert added reviewers: JonChesterfield, jhuber6, ABataev, aaron.ballman,
ye-luo.
Herald added subscribers: guansong, bollu, yaxunl.
Herald added a project: clang.
jdoerfert requested review of this revision.
Herald added a subscriber: sstefan1.
Especially for
NoQ added a comment.
So, `ArrayBoundCheckerV3` then?
We already have a similar simplification facility in `SValBuilder` created to
solve the similar problem with iterator checkers. It fires up when it knows
that the values it works with are limited to roughly 1/4 of their type's range
and ther
tdeo created this revision.
tdeo added a reviewer: sammccall.
tdeo added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny.
Herald added a project: clang.
tdeo requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryuko
Mordante added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6454
+static bool validateLikelihoodAttr(Sema &S, Decl *D, const ParsedAttr &A) {
+ if (!isa(D)) {
aaron.ballman wrote:
> This is entering into somewhat novel territory for attributes,
CarolineConcatto updated this revision to Diff 294558.
CarolineConcatto added a comment.
Fix typos
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88381/new/
https://reviews.llvm.org/D88381
Files:
clang/include/clang/Driver/Options.td
flang/incl
CarolineConcatto created this revision.
Herald added subscribers: cfe-commits, dang, mgorny.
Herald added a reviewer: DavidTruby.
Herald added a reviewer: sscalpone.
Herald added a project: clang.
CarolineConcatto requested review of this revision.
This patch runs Preprocess and PrintProcess actio
Mordante updated this revision to Diff 294556.
Mordante added a comment.
Addresses the review comments.
Adds an extra test case to test whether the proper overload is called. The
proper overload is a bit of a surprise so when the expected behaviour changes
the overload test can be adjusted.
CH
jdoerfert added a comment.
In what situation do we generate `mustprogress` function attributes now? I was
expecting them in `clang/test/CodeGen/attr-mustprogress.cpp` but did not see
any.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86841/new/
h
Mordante marked 2 inline comments as done.
Mordante added inline comments.
Comment at: clang/test/CXX/drs/dr14xx.cpp:411-414
+ void f(const char[4]);
+ void f(const wchar_t[4]);
+ void f(const char16_t[4]);
+ void f(const char32_t[4]);
rsmith wrote:
> rsmith
aaron.ballman updated this revision to Diff 294554.
aaron.ballman retitled this revision from "Correctly parse attributes on the
declaration of an anonymous bit-field" to "Better diagnostics for anonymous
bit-fields with attributes or an initializer".
aaron.ballman added a comment.
Herald added a
yaxunl created this revision.
yaxunl added reviewers: tra, ashi1, arsenm.
Herald added subscribers: kerbowa, t-tye, Anastasia, tpr, dstuttard, nhaehnle,
jvesely, kzhuravl.
yaxunl requested review of this revision.
Herald added a subscriber: wdng.
AMDGPU toolchain currently only diagnose invalid t
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6454
+static bool validateLikelihoodAttr(Sema &S, Decl *D, const ParsedAttr &A) {
+ if (!isa(D)) {
This is entering into somewhat novel territory for attributes, so some of this
Author: Aaron Ballman
Date: 2020-09-27T08:30:41-04:00
New Revision: de55ebe3bbc77882901ae2b9654503b7611b28f3
URL:
https://github.com/llvm/llvm-project/commit/de55ebe3bbc77882901ae2b9654503b7611b28f3
DIFF:
https://github.com/llvm/llvm-project/commit/de55ebe3bbc77882901ae2b9654503b7611b28f3.diff
37 matches
Mail list logo
