[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl updated this revision to Diff 294534. yaxunl added a comment. fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88370/new/ https://reviews.llvm.org/D88370 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Basic/Targets/AMDGPU.h clang/test/Driver/amdgpu-macros.cl I

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl created this revision. yaxunl added reviewers: arsenm, b-sumner. Herald added subscribers: kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D88370 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Basic/Ta

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1964 for (StringRef Candidate : CandidateBiarchTripleAliases) ScanLibDirForGCCTriple(TargetTriple, Args, LibDir, Candidate, /*NeedsBiarchSuffix=*/ true);

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

MaskRay added a comment. Without the patch % strace -fc -e file /tmp/RelA/bin/clang '-###' a.cc ... % time seconds usecs/call callserrors syscall -- --- --- - - 74.570.002809 8 331 312 opena

[clang] 4855018 - Fix sphinx warnings in AttributeReference, NFC

Author: Aaron Puchert Date: 2020-09-27T00:52:36+02:00 New Revision: 485501899d6c752ff05f4e045f7f89ace39ec413 URL: https://github.com/llvm/llvm-project/commit/485501899d6c752ff05f4e045f7f89ace39ec413 DIFF: https://github.com/llvm/llvm-project/commit/485501899d6c752ff05f4e045f7f89ace39ec413.diff

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

This revision was automatically updated to reflect the committed changes. Closed by commit rGf702a6fa7c9e: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY (authored by ryanofsky, committed by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] f702a6f - Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

Author: Russell Yanofsky Date: 2020-09-26T22:16:50+02:00 New Revision: f702a6fa7c9e4c0e2871b3d6657ce4dfa525ce52 URL: https://github.com/llvm/llvm-project/commit/f702a6fa7c9e4c0e2871b3d6657ce4dfa525ce52 DIFF: https://github.com/llvm/llvm-project/commit/f702a6fa7c9e4c0e2871b3d6657ce4dfa525ce52.di

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

aaronpuchert accepted this revision. aaronpuchert added a comment. Maybe we'll have to clarify this further in the future, but for now this is an improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87629/new/ https://reviews.llvm.org/D87629

[PATCH] D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling

mstorsjo added a comment. In D88005#2296254 , @dmajor wrote: > This change broke the configure step of Firefox mingw builds. > > The build bot won't give me the full details, so I'll need to set up a local > repro next week if needed, but my hunch is that

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

mati865 added subscribers: hans, mati865. mati865 added a comment. @hans sorry for not spotting it earlier but is it possible to still backport it to LLVM 11? It's totally OK if it's too late. I can easily keep it as a patch in MSYS2 repository. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

manojgupta added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1949 + // Maybe filter out /gcc and /gcc-cross. + GCCDirExists = D.getVFS().exists(LibDir + "/gcc"); + GCCCrossDirExists = D.getVFS().exists(LibDir + "/gcc-cross"); S

[clang] 915310b - Revert "[DSE] Switch to MemorySSA-backed DSE by default."

Author: Florian Hahn Date: 2020-09-26T18:35:27+01:00 New Revision: 915310bf14cbac58a81fd60e0fa9dc8d341108e2 URL: https://github.com/llvm/llvm-project/commit/915310bf14cbac58a81fd60e0fa9dc8d341108e2 DIFF: https://github.com/llvm/llvm-project/commit/915310bf14cbac58a81fd60e0fa9dc8d341108e2.diff

[PATCH] D88363: [CodeGen] Improve likelihood attribute branch weights

Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman. Mordante added a project: clang. Mordante requested review of this revision. Bruno De Fraine discovered some issues with D85091 . The branch weights generated for `logical not` and `

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#2295894 , @AlexanderLanin wrote: > Off-Topic: I was just attempting to apply this to my codebase at work. > Seems this will be more challenging than anticipated 😉 > My best guess is this is related to D72730

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis added a comment. Thanks for accepting @rjmccall. Could you land this? I don't have commit access yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 ___ c

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 294503. ellis added a comment. Update call sites Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/ItaniumMangle.c

[PATCH] D88359: [analyzer][RFC] Complete rewrite of ArrayBoundCheckerV2

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, xazax.hun, Szelethus, martong, balazske, baloghadamsoftware. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Herald added a proj

[clang] f91b9c0 - Run test on particular target only

Author: Serge Pavlov Date: 2020-09-26T20:26:34+07:00 New Revision: f91b9c0f9858bb3d6ff4dd1fb494e83633eefed8 URL: https://github.com/llvm/llvm-project/commit/f91b9c0f9858bb3d6ff4dd1fb494e83633eefed8 DIFF: https://github.com/llvm/llvm-project/commit/f91b9c0f9858bb3d6ff4dd1fb494e83633eefed8.diff

[PATCH] D88333: Correctly parse attributes on the declaration of an anonymous bit-field

aaron.ballman added a comment. In D88333#2296252 , @rsmith wrote: > I think we established rough consensus in CWG (at least, no one objected) > that this is a grammar bug -- there's nothing for these attributes to > appertain to, so they shouldn't be per

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

aganea added a comment. Thanks for the patch! I'll let others review it, but I was just being curious: what tool do you use for intercepting & printing `stat(` and `openat(`? How can I repro locally? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6314f412a83d: [FPEnv] Evaluate constant expressions under non-default rounding modes (authored by sepavloff). Repository: rG LLVM Github Monorepo

[clang] 6314f41 - [FPEnv] Evaluate constant expressions under non-default rounding modes

Author: Serge Pavlov Date: 2020-09-26T17:59:39+07:00 New Revision: 6314f412a83d61e293e3696d4afe1797a4001ac4 URL: https://github.com/llvm/llvm-project/commit/6314f412a83d61e293e3696d4afe1797a4001ac4 DIFF: https://github.com/llvm/llvm-project/commit/6314f412a83d61e293e3696d4afe1797a4001ac4.diff

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86559/new/ https://reviews.llvm.org/D86559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/static-device-var-no-rdc.cu:84 + const static __constant__ int local_static_constant = 42; + const static __device__ int local_static_device = 43; a[0] = x; what happens to a const static devic

[PATCH] D88019: [analyzer][solver] Fix issue with symbol non-equality tracking

steakhal added a comment. In D88019#2291953 , @steakhal wrote: > What are our options mitigating anything similar happening in the future? > > This way any change touching the `SymbolicRangeInferrer` and any related > parts of the analyzer seems to be way

[PATCH] D88352: [clang][AVR] Add more devices

benshi001 updated this revision to Diff 294486. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88352/new/ https://reviews.llvm.org/D88352 Files: clang/lib/Basic/Targets/AVR.cpp clang/test/Misc/target-invalid-cpu-note.c Index: clang/test/Misc/target-invalid-cpu-note.c

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. - C++11: > [class.copy]p32: > When **the criteria for elision of a copy operation **are met or would be met > save for the fact that the source object is a function parameter, and the > object to be copied is designated by an lvalue, overload resolution to select >

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp updated this revision to Diff 294485. nullptr.cpp added a comment. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 Files: clang/lib/Sema/SemaStmt.cpp clang/test/SemaCXX/implicitly-