[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

craig.topper added a comment. In D87888#2281360 , @RKSimon wrote: > Do we have sufficient backend test coverage for this? Taking a closer look, I don't think our coverage is very good. We just have one test for each the 28 condition code strings we suppo

[PATCH] D85810: [clang] Pass-through remarks options to linker

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:95 +if (F.empty()) + F = llvm::sys::path::stem(Input.getBaseInput()); + } Is the `F.empty()` case unreachable? Please delete the code or add an assert ==

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

rsmith added inline comments. Comment at: clang/include/clang/AST/Type.h:4478 - DecltypeType(Expr *E, QualType underlyingType, QualType can = QualType()); + const ASTContext &Context; + DecltypeType(Expr *E, QualType underlyingType, const ASTContext &Context, ---

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Not ready for review yet, posting a WIP fix for https://bugs.llvm.org/show_bug.cgi?id=47479. TODO next week: - tests, tests, and more tests. - interaction with `__attribute__((always_inline))`. - fix TODOs in cod

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. nickdesaulniers requested review of this revision. It's currently ambiguous in IR whether the sourc

[PATCH] D87949: [ThinLTO] Option to bypass function importing.

tejohnson added a comment. Minor comments. Comment at: clang/test/CodeGen/thinlto_embed_bitcode.ll:17 +; RUN: rm %t1.bc %t2.bc +; RUN: %clang -target x86_64-unknown-linux-gnu -O2 -o %t-redo.o -x ir %t-embedded.bc -c -fthinlto-index=%t.o.thinlto.bc -mllvm -lto-embed-bitcode=po

[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37e7673c21af: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D8

[clang] 37e7673 - [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

Author: Amy Kwan Date: 2020-09-18T18:16:14-05:00 New Revision: 37e7673c21af1531b601ca975cb6118d04b6e1cc URL: https://github.com/llvm/llvm-project/commit/37e7673c21af1531b601ca975cb6118d04b6e1cc DIFF: https://github.com/llvm/llvm-project/commit/37e7673c21af1531b601ca975cb6118d04b6e1cc.diff LOG:

[PATCH] D87953: [xray] Function coverage groups

ianlevesque created this revision. ianlevesque added reviewers: dberris, MaskRay, kyulee. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. ianlevesque requested review of this revision. Add the ability to selectively instrument a subset of functions by dividing the func

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu added a comment. In D84988#2282849 , @vsk wrote: > @zequanwu FTR, I don't have any outstanding concerns (I understand you might > be asking for a second reviewer to chime in though). Thanks for reviewing. Then, I think it might be ready to land.

[PATCH] D87943: [clang] Remove profile available check for fsplit-machine-functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb86f1af42395: [clang] Remove profile available check for fsplit-machine-functions. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D879

[clang] b86f1af - [clang] Remove profile available check for fsplit-machine-functions.

Author: Snehasish Kumar Date: 2020-09-18T15:08:00-07:00 New Revision: b86f1af423952d9f1dbe105b651b948ce0e1e8d0 URL: https://github.com/llvm/llvm-project/commit/b86f1af423952d9f1dbe105b651b948ce0e1e8d0 DIFF: https://github.com/llvm/llvm-project/commit/b86f1af423952d9f1dbe105b651b948ce0e1e8d0.dif

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. In D87946#2283049 , @jdoerfert wrote: > I guess you can try to use `sed` to update the tests. That's what I did for all the clang tests, they all pass as far as I know and I can use the built clang to correctly build offloaded ap

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra added a comment. In D84362#2283065 , @yaxunl wrote: > I think this is probably a different issue. The issue reported in D84364 > was introduced by change in D84364 > . It's possible.

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed79827aea44: [clang][module] Improve incomplete-umbrella warning (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] ed79827 - [clang][module] Improve incomplete-umbrella warning

Author: Zixu Wang Date: 2020-09-18T14:56:47-07:00 New Revision: ed79827aea444e6995fb3d36abc2bfd36331773c URL: https://github.com/llvm/llvm-project/commit/ed79827aea444e6995fb3d36abc2bfd36331773c DIFF: https://github.com/llvm/llvm-project/commit/ed79827aea444e6995fb3d36abc2bfd36331773c.diff LOG

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl added a comment. In D84362#2283045 , @tra wrote: > In D84362#2282992 , @yaxunl wrote: > >> The fix is for the change in D84364 . It >> has no effect on the change in this rev

[PATCH] D87949: [ThinLTO] Option to bypass function importing.

mtrofin created this revision. mtrofin added a reviewer: tejohnson. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a reviewer: alexshap. Herald added projects: clang, LLVM. mtrofin requested review of this revision. This completes th

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jdoerfert added a comment. I guess you can try to use `sed` to update the tests. Comment at: openmp/libomptarget/include/omptarget.h:4 -// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. -// See https://llvm.org/LICENSE.txt for license information

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra added a comment. In D84362#2282992 , @yaxunl wrote: > The fix is for the change in D84364 . It has > no effect on the change in this review. Are you sure the issue you saw is due > to change in this review instead of

[clang-tools-extra] 549e55b - Temporarily Revert "[clangd] Add Random Forest runtime for code completion."

Author: Eric Christopher Date: 2020-09-18T14:47:43-07:00 New Revision: 549e55b3d5634870aa9d42135f51ad46a6a0e347 URL: https://github.com/llvm/llvm-project/commit/549e55b3d5634870aa9d42135f51ad46a6a0e347 DIFF: https://github.com/llvm/llvm-project/commit/549e55b3d5634870aa9d42135f51ad46a6a0e347.di

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 added a comment. WIP for adding ident_t support to libomptarget. Still breaks some tests, just wanted to get a start. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 ___

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added a project: OpenMP. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, jfb, guansong, yaxunl. Herald added projects: clang, LLVM. jhuber6 requested review of this revision. Herald added a subscriber:

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon planned changes to this revision. RKSimon added a comment. WIP until reductions are no longer experimental Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87604/new/ https://reviews.llvm.org/D87604 ___

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl added a comment. In D84362#2282965 , @tra wrote: > In D84362#2282890 , @yaxunl wrote: > >> I have a fix for the issue reported in D84364 >> . Would you like to try? Thanks. >

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

gribozavr2 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3592 + let Content = [{ +Objective-C declarations marked with the ``swift_private`` attribute are hidden +from the framework client but are still made available for use within the ---

[PATCH] D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins

Conanap updated this revision to Diff 292901. Conanap added a comment. Open coded VMODS/UQ instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87394/new/ https://reviews.llvm.org/D87394 Files: clang/include/clang/Basic/BuiltinsPPC.def clang

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

aaronpuchert added a comment. In D87629#2280475 , @ajtowns wrote: > Sure, it makes perfect sense that it's too hard. It's not really too hard, there is an existing parameter somewhere in the CFG generation that controls these exception handling edges, an

[PATCH] D87943: [clang] Remove profile availabile check for fsplit-machine-functions.

snehasish marked 2 inline comments as done. snehasish added a comment. Thanks for the quick review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87943/new/ https://reviews.llvm.org/D87943 ___ cfe-commit

[PATCH] D87943: [clang] Remove profile availabile check for fsplit-machine-functions.

snehasish updated this revision to Diff 292899. snehasish added a comment. Drop braces, add a test. - Remove braces from single line if. - Add a test to make sure that option is passed through even if no profiles provided. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra reopened this revision. tra added a comment. This revision is now accepted and ready to land. In D84362#2282890 , @yaxunl wrote: > I have a fix for the issue reported in D84364 > . Would you like to try? Thanks. I can

[PATCH] D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:9 +// +// This file tests the Syntax Tree base API. +// Please elaborate what "base API" covers -- specifically, what classes and such. However, I'm not sure it is necessa

[PATCH] D87648: [Coverage][NFC] Remove skipped region after added into MappingRegions

vsk added a comment. (Depending on what the potential performance gains look like, it might be advisable to keep things simple with the current O(n^2) approach. Optimizing things can carry some risk -- not sure if we've already ruled this out, but e.g. perhaps there's some edge case with nested

[PATCH] D87904: [AIX][Clang][Driver] Add handling of nostartfiles option

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87904/new/ https://reviews.llvm.org/D87904

[PATCH] D87943: [clang] Remove profile availabile check for fsplit-machine-functions.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm with a couple of minor suggestions Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4919 if (Triple.isX86() && Triple.isOSBinFormatELF()) { if (A->get

[PATCH] D87648: [Coverage][NFC] Remove skipped region after added into MappingRegions

vsk added a comment. Unfortunately it does look like the work done in gatherSkippedRegions is O(n^2) in the number of functions, at the moment. If the goal is to speed it up, it'd be good to grab some performance numbers for some representative compile unit (the sqlite3 amalgamation is my go-to

[PATCH] D87943: [clang] Remove profile availabile check for fsplit-machine-functions.

snehasish created this revision. snehasish added reviewers: tejohnson, davidxl. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. snehasish requested review of this revision. Enforcing a profile available check in the driver does not work with incremental LTO builds

[PATCH] D87942: [Analyzer] GNU named variadic macros in Plister

chrish_ericsson_atx created this revision. chrish_ericsson_atx added reviewers: NoQ, Szelethus, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang.

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

gribozavr2 accepted this revision. gribozavr2 added a comment. > This introduces the new swift_name attribute that allows annotating > interfaces with an alternate spelling for Swift. This is used as part > of the importing mechanism to allow interfaces to be imported with a new s/interfaces/APIs

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl added a comment. In D84362#2279845 , @tra wrote: > In D84362#2279688 , @tra wrote: > >> Apparently this patch triggers compiler crashes on some of our code. I'll >> try to create a reproducer, but it would b

[PATCH] D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:846 + +let Predicates = [MMA] in { + def : Pat<(v512i1 (PPCAccBuild v4i32:$vs1, v4i32:$vs0, v4i32:$vs3, v4i32:$vs2)), Just my opinion but maybe we can put this block under the ano

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

yaxunl added a comment. In D84364#2282458 , @hctim wrote: > Not a known issue - no, but MSan doesn't play nice with uninistrumented > libraries (including things like libcxx) - and so it can be tricky to ensure > your build is properly sanitized, which i

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

jasonliu added inline comments. Comment at: clang/include/clang/Sema/Sema.h:66 #include "llvm/Frontend/OpenMP/OMPConstants.h" +#include #include Do we need cmath? Comment at: clang/include/clang/Sema/Sema.h:488 +AlignPackInfo(AlignPackI

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

vsk added a comment. @zequanwu FTR, I don't have any outstanding concerns (I understand you might be asking for a second reviewer to chime in though). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://reviews.llvm.org/D84988 __

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne added a subscriber: jwakely. ldionne added inline comments. Comment at: libcxx/include/new:243 # ifdef _LIBCPP_HAS_NO_BUILTIN_OVERLOADED_OPERATOR_NEW_DELETE return ::operator new(__size, __align_val); # else This breaks GCC (as of GCC 9). I don't k

[clang-tools-extra] 8077779 - CompletionModelCodegen: Remove unused import

Author: Nico Weber Date: 2020-09-18T16:24:58-04:00 New Revision: 80913e82bece68a2f929ae17bd0e9ba38ab0 URL: https://github.com/llvm/llvm-project/commit/80913e82bece68a2f929ae17bd0e9ba38ab0 DIFF: https://github.com/llvm/llvm-project/commit/80913e82bece68a2f929ae17bd0e9ba38ab0.diff LO

[PATCH] D87931: [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py

vmiklos added a comment. Thanks for the quick feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87931/new/ https://reviews.llvm.org/D87931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2282502 , @nikic wrote: > Based on an initial look, the changes in comparison predicates here are > probably a red herring. If I understand right, those predicates are switching > from signed to unsigned comparison (e.

[PATCH] D87931: [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb168bbfae42e: [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py (authored by vmiklos). Repository: rG LLVM Github Monorepo C

[clang] b168bbf - [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py

Author: Miklos Vajna Date: 2020-09-18T21:43:18+02:00 New Revision: b168bbfae42e792542b4ced8729599524b9759c5 URL: https://github.com/llvm/llvm-project/commit/b168bbfae42e792542b4ced8729599524b9759c5 DIFF: https://github.com/llvm/llvm-project/commit/b168bbfae42e792542b4ced8729599524b9759c5.diff

[PATCH] D87931: [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87931/new/ https://reviews.llvm.org/D87931 _

[PATCH] D87931: [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py

vmiklos added a comment. Mydeveloperday, Sam: could you please take a look? Hopefully a trivial one. Thanks :-) There are some larger codebases like LibreOffice that use .hxx as their header file extension, it's a bit inconsistent that .cxx is recognized but .hxx is not. This is meant to fix t

[PATCH] D87931: [clang-format] Recognize "hxx" as a C++ header in clang-format-diff.py

vmiklos created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. vmiklos requested review of this revision. And shift "proto" to the next line to avoid a too long line. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87931 Files: clang/too

[clang-tools-extra] 0ea2a57 - clangd: Make ompletionModelCodegen.py tpy2.7 compatible

Author: Nico Weber Date: 2020-09-18T15:26:58-04:00 New Revision: 0ea2a57274225066ad81e971659222cf9ee1d12d URL: https://github.com/llvm/llvm-project/commit/0ea2a57274225066ad81e971659222cf9ee1d12d DIFF: https://github.com/llvm/llvm-project/commit/0ea2a57274225066ad81e971659222cf9ee1d12d.diff LO

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. This change is trying to address the issues raised in D83154 . There are still some open questions: - Is `-fsource-dir` the best name for this flag? - I'm not sure if `make_relative` should be applied to all source paths, or only paths th

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. In D83154#2277712 , @phosek wrote: > In D83154#2277539 , @rnk wrote: > >> Yeah, my goal is for the build system to be able to avoid having to embed >> PWD into the compiler flags. For exampl

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya. Herald added projects: clang, LLVM. phosek requested review of this revision. Herald added a subscriber: ormris. This flag can be used to relativize source paths againts a given directory. Compared

[PATCH] D86137: Add -Wno-error=unknown flag to clang-format.

MyDeveloperDay added a comment. it certainly LGTM, like I said I've had met this issue before and I think this does get around that situation where perhaps your not even using the option it's complaining about (especially if its a C++ option and you are using clang-format for C#) So yes I thin

[PATCH] D87927: [AIX][clang][driver] Make sure ctri.o is linked in C++ mode

daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. since crti is required for functional static initialization. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87927 Files: clang/l

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nikic added a comment. In D87188#2281093 , @mstorsjo wrote: > This broke a few tests for me (generating code that now gives the fail result > at runtime). > > I'm not entirely sure which bit is the culprit, but the difference in output > (that breaks tes

[PATCH] D87925: [Synthesis] Fix: `createTree` only from children that are not backed by source code

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87925 Files: clang/include/clang/Tooling/Syntax/BuildTree.h clang/lib/Tooling

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

hctim added a comment. Not a known issue - no, but MSan doesn't play nice with uninistrumented libraries (including things like libcxx) - and so it can be tricky to ensure your build is properly sanitized, which is why I'd recommend the build script :). Repository: rG LLVM Github Monorepo

[PATCH] D87923: [MS] On x86_32, pass overaligned, non-copyable arguments indirectly

rnk created this revision. rnk added reviewers: aeubanks, craig.topper. Herald added a project: clang. rnk requested review of this revision. This updates the C++ ABI argument classification code to use the logic from D72114 , fixing an ABI incompatibility with MS

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

rjmccall added a comment. Oh, I didn't notice that this only did work conditionally based on the builtin ID. Yes, please make a function like `lookupNecessaryTypesForBuiltin` that takes the builtin ID. Maybe we can generalize this to solve the problem with that other builtin, too. Repositor

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

rjmccall added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2462 + return true; +} + Thanks, these look good. Comment at: clang/lib/AST/ExprConstant.cpp:2427 +FPOptions FPFeatures = Cast->getFPFeaturesInEffect(Info.Ctx.getLa

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://reviews.llvm.org/D84988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

tambre added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9674 ASTContext::GetBuiltinTypeError Error; +LookupPredefedObjCSuperType(*this, S, NewFD->getIdentifier()); QualType BuiltinType = Context.GetBuiltinType(BuiltinID, Error);

[PATCH] D84364: [CUDA][HIP] Defer overloading resolution diagnostics for host device functions

yaxunl added a comment. In D84364#2279684 , @hctim wrote: > Looks like this patch broke the MSan buildbots, PTAL (repro instructions > https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild): > > http://lab.llvm.org:8011/builders/sanitizer-x

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

dmajor added a comment. Thanks, this fixes the specific translation unit I was looking at today. It's going to take some time before I have full build results but I don't expect any problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87917/new

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9674 ASTContext::GetBuiltinTypeError Error; +LookupPredefedObjCSuperType(*this, S, NewFD->getIdentifier()); QualType BuiltinType = Context.GetBuiltinType(BuiltinID, Error

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2427 +FPOptions FPFeatures = Cast->getFPFeaturesInEffect(Info.Ctx.getLangOpts()); +RM = FPFeatures.getRoundingMode(); + } rjmccall wro

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa1aa330b202f: [Sema] Handle objc_super special lookup when checking builtin compatibility (authored by tambre). Repositor

[clang] a1aa330 - [Sema] Handle objc_super special lookup when checking builtin compatibility

Author: Raul Tambre Date: 2020-09-18T20:51:55+03:00 New Revision: a1aa330b202f97ecd243ea9ef0c7ac00a80ea653 URL: https://github.com/llvm/llvm-project/commit/a1aa330b202f97ecd243ea9ef0c7ac00a80ea653 DIFF: https://github.com/llvm/llvm-project/commit/a1aa330b202f97ecd243ea9ef0c7ac00a80ea653.diff L

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

sepavloff updated this revision to Diff 292841. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87822/new/ https://reviews.llvm.org/D87822 Files: clang/include/clang/AST/Expr.h clang/lib/AST/Expr.cpp cl

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b6765e784b3: [clangd] Add Random Forest runtime for code completion. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 9b6765e - [clangd] Add Random Forest runtime for code completion.

Author: Utkarsh Saxena Date: 2020-09-18T19:25:56+02:00 New Revision: 9b6765e784b39c88cb8cdb85ab083e6c95a997ed URL: https://github.com/llvm/llvm-project/commit/9b6765e784b39c88cb8cdb85ab083e6c95a997ed DIFF: https://github.com/llvm/llvm-project/commit/9b6765e784b39c88cb8cdb85ab083e6c95a997ed.diff

[clang] a16e4a6 - [clang-format] NFC ensure the clang-format tests remain clang-formatted

Author: mydeveloperday Date: 2020-09-18T18:16:02+01:00 New Revision: a16e4a63ae7c1933291577723324e412e087dc8e URL: https://github.com/llvm/llvm-project/commit/a16e4a63ae7c1933291577723324e412e087dc8e DIFF: https://github.com/llvm/llvm-project/commit/a16e4a63ae7c1933291577723324e412e087dc8e.diff

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

tambre added a comment. I'll go ahead and commit this, as it's affecting an user and the fix is simple and obvious. Hopefully post-commit review is acceptable per my understanding of the rules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87917/n

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7add812eb7: [clang-format] Add a option for the position of Java static import (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 2e7add8 - [clang-format] Add a option for the position of Java static import

Author: mydeveloperday Date: 2020-09-18T18:12:21+01:00 New Revision: 2e7add812eb7bdd90bd0f0fc3b633515edd55f27 URL: https://github.com/llvm/llvm-project/commit/2e7add812eb7bdd90bd0f0fc3b633515edd55f27 DIFF: https://github.com/llvm/llvm-project/commit/2e7add812eb7bdd90bd0f0fc3b633515edd55f27.diff

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2282219 , @tambre wrote: > In D77491#2282166 , @dmajor wrote: > >> This commit broke Firefox builds on Mac with an error in the SDK headers. >> Could you please revert if a fix is

[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

tambre created this revision. tambre added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. tambre requested review of this revision. objc_super is special and needs LookupPredefedObjCSuperType() called before performing builtin type comparisons. This fix

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292835. tianshilei1992 added a comment. Fixed the test case `target_parallel_codegen.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/Code

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

rnk added a comment. In D87808#2280197 , @dblaikie wrote: > @rsmith What's the deal with these anonymous structs/unions? Why do they have > copy/move constructors (are those technically called from the enclosing > class's copy/move constructors?) but no

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2282166 , @dmajor wrote: > This commit broke Firefox builds on Mac with an error in the SDK headers. > Could you please revert if a fix is not readily available? > > Reproducer: > > struct objc_super {}; > extern "C"

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jyknight added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:256 - /// A cache from types to size and alignment information. using TypeInfoMap = llvm::DenseMap; + /// A cache from types to size and ABI-specified alignment information. P

[PATCH] D87858: [hip] Add HIP scope atomic ops.

jfb added a comment. In D87858#2282150 , @yaxunl wrote: > In D87858#2280429 , @jfb wrote: > >> Please provide documentation in this patch. > > opencl atomic builtins are documented as notes to `__c11_atomic builtins

[PATCH] D87895: [SyntaxTree] Test for '\' inside token.

eduucaldas updated this revision to Diff 292832. eduucaldas added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87895/new/ https://reviews.llvm.org/D87895 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index: clang

[PATCH] D87896: [SyntaxTree][Synthesis] Improve testing `createLeaf`

eduucaldas updated this revision to Diff 292831. eduucaldas added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87896/new/ https://reviews.llvm.org/D87896 Files: clang/unittests/Tooling/Syntax/SynthesisTest.cpp Index: clang/u

[PATCH] D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. Forgot to approve this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87804/new/ https://reviews.llvm.org/D87804

[PATCH] D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM

amyk updated this revision to Diff 292830. amyk added a comment. Address clang-format concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87671/new/ https://reviews.llvm.org/D87671 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

dmajor added a comment. This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available? Reproducer: struct objc_super {}; extern "C" id objc_msgSendSuper(struct objc_super *super, SEL op, ...); extern "C" void objc_msgSe

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292828. usaxena95 added a comment. Fixed output_dir cmake variable. Clean build succeeds now. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files:

[PATCH] D87858: [hip] Add HIP scope atomic ops.

yaxunl added a comment. In D87858#2280429 , @jfb wrote: > Please provide documentation in this patch. opencl atomic builtins are documented as notes to `__c11_atomic builtins` part of https://clang.llvm.org/docs/LanguageExtensions.html#builtin-functions.

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

This revision was automatically updated to reflect the committed changes. Closed by commit rG51c5add8547a: Extending Baremetal toolchain's support for the rtlib option. (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/

[clang] 51c5add - Extending Baremetal toolchain's support for the rtlib option.

Author: Jon Roelofs Date: 2020-09-18T09:19:37-07:00 New Revision: 51c5add8547a66caa5fbc9a19a91cd7976944229 URL: https://github.com/llvm/llvm-project/commit/51c5add8547a66caa5fbc9a19a91cd7976944229 DIFF: https://github.com/llvm/llvm-project/commit/51c5add8547a66caa5fbc9a19a91cd7976944229.diff L

[PATCH] D87914: [AIX][Clang][Driver] Add handling of shared option

daltenty created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. daltenty requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87914 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c Ind

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

spatel added a comment. In D87188#2281957 , @sanwou01 wrote: > I know this has already been reverted but just FYI that I've bisected a ~2% > regression in SPEC2017 x264_r on AArch64 to this commit. Presumably this is > due to the extra unrolling / cost m

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292818. usaxena95 added a comment. Removed generated (for review) files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you may want to get a second set of eyes on the swift name validation bits for a more thorough review of that part. Comment at: clang/include/clan

  1   2   >