[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

MaskRay accepted this revision. MaskRay added a comment. > This patch avoid the issue by defaulting to -mstackrealign, just like gcc. This sentence from the description should be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87615/new/ ht

[PATCH] D87812: [FPEnv] Use typed accessors in FPOptions

sepavloff created this revision. sepavloff added reviewers: rjmccall, kpn, mibintc. Herald added subscribers: llvm-commits, dexonsmith. Herald added projects: clang, LLVM. sepavloff requested review of this revision. Previously methods `FPOptions::get*` returned unsigned value even if the correspo

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

yaxunl marked an inline comment as done. yaxunl added a comment. In D87791#2277887 , @tra wrote: > Does this naming scheme the same as used for `.o` files? We may want to keep > them in sync. > > Other than that, LGTM. .o file is different story. For -f

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ajtowns added a comment. In D87629#2272676 , @aaronpuchert wrote: > (The existing `LockAssertion` class that the change removed looks like it > should use `ASSERT_CAPABILITY` instead—please don't use `ACQUIRE` when the > capability is assumed to be held

[libunwind] fb1abe0 - [libunwind][DWARF] Fix end of .eh_frame calculation

Author: Ryan Prichard Date: 2020-09-16T19:00:57-07:00 New Revision: fb1abe00635c1ec28e55921709904d5ca2e86a74 URL: https://github.com/llvm/llvm-project/commit/fb1abe00635c1ec28e55921709904d5ca2e86a74 DIFF: https://github.com/llvm/llvm-project/commit/fb1abe00635c1ec28e55921709904d5ca2e86a74.diff

[clang] 7337f29 - PR47555: Inheriting constructors are implicitly definable.

Author: Richard Smith Date: 2020-09-16T18:11:18-07:00 New Revision: 7337f296194483e0959ff980049e2835e226f396 URL: https://github.com/llvm/llvm-project/commit/7337f296194483e0959ff980049e2835e226f396 DIFF: https://github.com/llvm/llvm-project/commit/7337f296194483e0959ff980049e2835e226f396.diff

[clang] 905b9ca - Canonicalize declaration pointers when forming APValues.

Author: Richard Smith Date: 2020-09-16T18:11:18-07:00 New Revision: 905b9ca26c94fa86339451a528cedde5004fc1bb URL: https://github.com/llvm/llvm-project/commit/905b9ca26c94fa86339451a528cedde5004fc1bb DIFF: https://github.com/llvm/llvm-project/commit/905b9ca26c94fa86339451a528cedde5004fc1bb.diff

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. I would wait a few days before committing in case other reviewers have comments but not too long as you can address extra comments post-commit. Repository: rG LLVM Gith

[PATCH] D87808: [DebugInfo] Fix bug in constructor homing where it would use ctor homing when a class only has copy/move constructors

akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. akhuang requested review of this revision. Basically, the code was checking if there were no constructors at all, but didn't check that there were any non copy/

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2683 } + if (const BinaryOperator *BE = dyn_cast(E)) { +if (BE->getFPFeaturesInEffect(Info.Ctx.getLangOpts()).isFPConstrained()) { `E` here is only intended for use in determining di

[PATCH] D87561: [Sema] List conversion validate character array

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:4989 +if (ToType->isArrayType() && ToType->isCharType() && +isa(From->getInit(0))) { InitializedEntity Entity = Mordante wrote: > rsmith wrote: > > This is too narrow a c

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng updated this revision to Diff 292378. zzheng marked 2 inline comments as done. zzheng added a comment. Fixed comment and lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/ https://reviews.llvm.org/D84414 Files: clang/lib/Driver

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

rsmith added inline comments. Comment at: clang/test/CodeGenCXX/mangle.cpp:805 - // CHECK-LABEL: define weak_odr void @_ZN6test341fIiEEvDTstDTplcvT__EcvS1__EEE + // CHECK-LABEL: define weak_odr void @_ZN6test341fIiEEvm template void f(decltype(sizeof(1))); ---

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

rsmith added inline comments. Comment at: clang/test/CodeGenCXX/mangle-exprs.cpp:218 template void a(decltype(noexcept(int(; - // CHECK: void @_ZN5test51aIiEEvDTnxcvT__EE( + // CHECK: void @_ZN5test51aIiEEvb } As with the other case, the expression here

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87607/new/ https://reviews.llvm.org/D87607 ___ cfe-commits mailing list cfe-commits

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:38 + // Do not save RA to the SCS if it's not saved to the regular stack, + // i.e. RA is not at risk of being to overwritten. + std::vector &CSI = MF.getFrameInfo().getCalleeSavedInfo(); --

[PATCH] D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

Conanap created this revision. Conanap added reviewers: PowerPC, saghir, nemanjai, hfinkel. Conanap added projects: LLVM, PowerPC, clang. Herald added a subscriber: kbarton. Conanap requested review of this revision. This patch implements Vector signed/unsigned __int128 overloads for the comparis

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng marked 2 inline comments as done. zzheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:60 + // sw ra, 0(s2) + // addi s2, s2, 4 + BuildMI(MBB, MI, DL, TII->get(IsRV64 ? RISCV::SD : RISCV::SW)) jrtc27 wrote: > Is it in

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng updated this revision to Diff 292372. zzheng marked 9 inline comments as done. zzheng added a comment. Addressed comments by @jrtc27 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/ https://reviews.llvm.org/D84414 Files: clang/lib

[clang] f70baaf - [AArch64] Add -mmark-bti-property flag.

Author: Daniel Kiss Date: 2020-09-17T01:18:36+02:00 New Revision: f70baaf71f62ba8623b3522345527271add74f6b URL: https://github.com/llvm/llvm-project/commit/f70baaf71f62ba8623b3522345527271add74f6b DIFF: https://github.com/llvm/llvm-project/commit/f70baaf71f62ba8623b3522345527271add74f6b.diff L

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292369. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/Di

[clang] 60e244f - Revert "[AArch64] Add -mmark-bti-property flag."

Author: Daniel Kiss Date: 2020-09-17T01:17:23+02:00 New Revision: 60e244f82c1f97c1b7d65c06d2b0b4f634f8d696 URL: https://github.com/llvm/llvm-project/commit/60e244f82c1f97c1b7d65c06d2b0b4f634f8d696 DIFF: https://github.com/llvm/llvm-project/commit/60e244f82c1f97c1b7d65c06d2b0b4f634f8d696.diff L

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292368. compnerd added a comment. Change diagnostics for conflicting `swift_name`, add a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files: clang/inclu

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

aaronpuchert added a comment. In D87629#2275639 , @ryanofsky wrote: > The mistakes about exceptions came from me taking "(no return)" in the > previous documentation too literally thinking it was referring to > https://en.cppreference.com/w/cpp/language/

[PATCH] D85685: Support dwarf fission for wasm object files

sbc100 accepted this revision. sbc100 added a comment. I don't really grok the `TargetFrameLowering::DwarfFrameBase` part but everything else LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 __

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rG95e43f84b7b9: [AArch64] Add -mmark-bti-property flag. (authored by danielkiss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llv

[clang] 95e43f8 - [AArch64] Add -mmark-bti-property flag.

Author: Daniel Kiss Date: 2020-09-17T00:24:14+02:00 New Revision: 95e43f84b7b9c61011aece7583c0367297dd67d8 URL: https://github.com/llvm/llvm-project/commit/95e43f84b7b9c61011aece7583c0367297dd67d8 DIFF: https://github.com/llvm/llvm-project/commit/95e43f84b7b9c61011aece7583c0367297dd67d8.diff L

[PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl

shafik added a comment. Herald added a reviewer: JDevlieghere. We are going to move forward with this approach (after dealing with the multi-dimensional array case) temporarily. We are seeing crash bugs from this from users and we want to fix it while we explore the solution space more. This PR

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

joerg accepted this revision. joerg added a comment. This revision is now accepted and ready to land. I'm still curious about the source of the vptr diff, but that's a minor question, otherwise. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87

[PATCH] D85685: Support dwarf fission for wasm object files

dschuff added a comment. In D85685#2277998 , @dschuff wrote: > > Yeah, ELF splits ELFWriter out from ELFObjectWriter, and then instantiates it > twice. It's all because ELFObjectWriter has to derive from MCObjectWriter > which was clearly not designe

[PATCH] D85685: Support dwarf fission for wasm object files

dschuff added a comment. In D85685#2275585 , @sbc100 wrote: > Seems reasonable. Do you think this way is cleaner than the way elf does > it? Looks like ELF creates two different ELFWriter inside the > ELFDwoObjectWriter subclass right? Yeah, ELF spl

[PATCH] D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks

ronlieb added a comment. The latest patch applied cleanly to our downstream port. builds fine, tests very nicely as well. All the failing SOLLVE task wait depend tests now pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84470/new/ https://revi

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

ldionne added a comment. In D31413#2277630 , @smeenai wrote: > What was the conclusion for the comments about the priority level (100 vs. > 101)? My understanding is that values below `101` are literally not allowed: <...>/llvm/libcxx/src/iostream.cpp

[libunwind] 23bef7e - [libunwind] Support for leaf function unwinding.

Author: Daniel Kiss Date: 2020-09-16T23:53:36+02:00 New Revision: 23bef7ee9923b1262326981960397e8cd95d6923 URL: https://github.com/llvm/llvm-project/commit/23bef7ee9923b1262326981960397e8cd95d6923 DIFF: https://github.com/llvm/llvm-project/commit/23bef7ee9923b1262326981960397e8cd95d6923.diff L

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd added subscribers: dexonsmith, doug.gregor. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2179 +def SwiftNewType : InheritableAttr { + let Spellings = [GNU<"swift_newtype">, GNU<"swift_wrapper">]; + let Args = [EnumArgument<"NewtypeKind"

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rGee5519d32357: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] ee5519d - [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

Author: Yaxun (Sam) Liu Date: 2020-09-16T17:35:28-04:00 New Revision: ee5519d323571c4a9a7d92cb817023c9b95334cd URL: https://github.com/llvm/llvm-project/commit/ee5519d323571c4a9a7d92cb817023c9b95334cd DIFF: https://github.com/llvm/llvm-project/commit/ee5519d323571c4a9a7d92cb817023c9b95334cd.dif

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13197-13198 assert(E->isRValue() && E->getType()->isRealFloatingType()); + if (Info.isStrictFP) +return false; return FloatExprEvaluator(Info, Result).Visit(E); rsmith wrote: > I

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 292343. mibintc added a comment. I pulled out the isStrictFP boolean from EvalInfo and used the FPOptions when visiting floating point BinaryOperator, CastExpr and builtin CallExpr. I created the diagnostic note explaining why constant evaluation failed. No

[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Does this naming scheme the same as used for `.o` files? We may want to keep them in sync. Other than that, LGTM. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:909 + au

[PATCH] D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults

modimo added a comment. Thanks @asbirlea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] bebfc3b - Revert "Do not apply calling conventions to MSVC entry points"

Author: Amy Huang Date: 2020-09-16T13:52:29-07:00 New Revision: bebfc3b92d5e8dd1b1d75d40d5d03975957eec14 URL: https://github.com/llvm/llvm-project/commit/bebfc3b92d5e8dd1b1d75d40d5d03975957eec14 DIFF: https://github.com/llvm/llvm-project/commit/bebfc3b92d5e8dd1b1d75d40d5d03975957eec14.diff LOG

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. whoops, sorry for weird formatting in the previous comment. I'll revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___ cfe

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

akhuang added a comment. This is causing a link error in the windows chromium build: lld-link: error: undefined symbol: _WinMain@16 >>> referenced by >>> D:\agent\_work\4\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:102 >>> >>> msvcrtd.lib(exe_winmain.obj):(int __cdecl invoke_main(v

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4289 +if (Inline->getName() != Name && !Inline->isImplicit()) { + Diag(Inline->getLocation(), diag::warn_attribute_ignored) << Inline; + Diag(CI.getLoc(), diag::note_conflicting_attribute);

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added a comment. In D83154#2277539 , @rnk wrote: > Yeah, my goal is for the build system to be able to avoid having to embed PWD > into the compiler flags. For example, I believe it is a goal of the LLVM gn > build system for the build tree to be

[PATCH] D86020: [MemCpyOptimizer] Optimize passing byref function arguments down the stack

arsenm added a comment. In D86020#103 , @atrosinenko wrote: > @rjmccall > > Maybe I overestimated similarity of `byval` and recently introduced > `byref`... Looks like some aliasing restrictions are not mentioned in LLVM > Language Reference

[PATCH] D84470: [OpenMP 5.0] Fix user-defined mapper privatization in tasks

ABataev updated this revision to Diff 292330. ABataev added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updated + added clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84470/new/ https://reviews.llvm.

[PATCH] D87791: [CUDA][HIP] Fix -gsplit option

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. yaxunl requested review of this revision. when -gsplit option is used with clang driver, clang driver will create a filename with .dwo option based on the input file name and pass it to clang -cc1. This file is used for storing th

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. This is a very nice cleanup. Thank you, Sam. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84362/new/ https://reviews.llvm.org/D84362 ___ cfe-co

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. > Hmm, I thought we actually just generated a bogus definition for the protocol > when it was forward-declared; really, this is better behavior that I > expected. Regardless, I don't think it's worthwhile to diagnose this more > strongly than a warning because of the hist

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

yaxunl updated this revision to Diff 292319. yaxunl retitled this revision from "[NFC] Add missing functions to PartialDiagnostic" to "[NFC] Refactor DiagnosticBuilder and PartialDiagnostic". yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comments. Extracte

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

smeenai added a comment. What was the conclusion for the comments about the priority level (100 vs. 101)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31413/new/ https://reviews.llvm.org/D31413 ___ cfe-

[PATCH] D87785: [analyzer][StdLibraryFunctionsChecker] Fix a BufferSize constraint crash

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:219-226 if (V.isUndef()) -return State; +return {State, State}; DefinedOrUnknownSVal L = V.castAs(); if (!L.getAs()) -retur

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

aganea added a comment. In D86694#2277456 , @cryptoad wrote: > I didn't try to make the Exclusive version work, mostly because I was using > the Windows TLS API and the Shared fit right in with those, but it would get > rid of a lot of the contention. T

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2274687 , @jdoerfert wrote: > >> Do you mean a test for recognizing the option in `common.py`? I'm not sure >> what you're asking for here. > > The function is recognized in common.py, right? Can't you run the > up

[PATCH] D83154: clang: Add -fcoverage-prefix-map

rnk added a comment. Yeah, my goal is for the build system to be able to avoid having to embed PWD into the compiler flags. For example, I believe it is a goal of the LLVM gn build system for the build tree to be relocatable. If the compiler command lines need to contain absolute paths to make

[PATCH] D87785: [analyzer][StdLibraryFunctionsChecker] Fix a BufferSize constraint crash

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:694 // execution continues on a code whose behaviour is undefined. assert(SuccessSt); NewState = SuccessSt; This is where we crashed b

[PATCH] D87785: [analyzer][StdLibraryFunctionsChecker] Fix a BufferSize constraint crash

martong created this revision. martong added reviewers: steakhal, balazske, Szelethus, NoQ. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a projec

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292299. compnerd marked 2 inline comments as done. compnerd added a comment. Address everything but warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files: cl

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd marked 3 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:104 +def ObjCClassMethod +: SubsetSubjectisInstanceMethod()}], aaron.ballman wrote: > This change is no longer needed. Ah, right, I'll m

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2277371 , @aganea wrote: > @cryptoad What happens if the primary was much smaller? Or if pages were > //reserved// in much smaller ranges? The Primary can be made smaller, but this works better with the Standalone ver

[clang] 2240ca0 - [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

Author: Fanbo Meng Date: 2020-09-16T14:49:03-04:00 New Revision: 2240ca0bd1502d7baa098da7cb4aca64a6f979d4 URL: https://github.com/llvm/llvm-project/commit/2240ca0bd1502d7baa098da7cb4aca64a6f979d4 DIFF: https://github.com/llvm/llvm-project/commit/2240ca0bd1502d7baa098da7cb4aca64a6f979d4.diff LO

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rG2240ca0bd150: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS (authored by fanbo-meng, committed by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 5c1084e - [OpenMP] Context selector extensions for template functions

Author: Johannes Doerfert Date: 2020-09-16T13:37:10-05:00 New Revision: 5c1084e8840b02d410ba125cbba466465242d820 URL: https://github.com/llvm/llvm-project/commit/5c1084e8840b02d410ba125cbba466465242d820 DIFF: https://github.com/llvm/llvm-project/commit/5c1084e8840b02d410ba125cbba466465242d820.d

[PATCH] D85878: [OpenMP] Context selector extensions for return value overloading

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4b7a1da9d87: [OpenMP] Context selector extensions for return value overloading (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D85878?vs=285262&id=292291#toc Repository: r

[PATCH] D85879: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97652202d1e6: [OpenMP] Overload `std::isnan` and friends multiple times for the GPU (authored by jdoerfert). Changed prior to commit: https://revi

[PATCH] D85877: [OpenMP] Support nested OpenMP context selectors (declare variant)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c63ae156e96: [OpenMP] Support nested OpenMP context selectors (declare variant) (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHA

[clang] 9765220 - [OpenMP] Overload `std::isnan` and friends multiple times for the GPU

Author: Johannes Doerfert Date: 2020-09-16T13:37:09-05:00 New Revision: 97652202d1e6964d5d7a1c03a257452c7ad95233 URL: https://github.com/llvm/llvm-project/commit/97652202d1e6964d5d7a1c03a257452c7ad95233 DIFF: https://github.com/llvm/llvm-project/commit/97652202d1e6964d5d7a1c03a257452c7ad95233.d

[clang] 56069b5 - [OpenMP] Support `std::complex` math functions in target regions

Author: Johannes Doerfert Date: 2020-09-16T13:37:10-05:00 New Revision: 56069b5c71ca78749aa983c1e9de6f1e4c049f4b URL: https://github.com/llvm/llvm-project/commit/56069b5c71ca78749aa983c1e9de6f1e4c049f4b DIFF: https://github.com/llvm/llvm-project/commit/56069b5c71ca78749aa983c1e9de6f1e4c049f4b.d

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jdoerfert marked 2 inline comments as done. Closed by commit rG5c1084e8840b: [OpenMP] Context selector extensions for template functions (authored by jdoerfert). Repos

[clang] c4b7a1d - [OpenMP] Context selector extensions for return value overloading

Author: Johannes Doerfert Date: 2020-09-16T13:37:09-05:00 New Revision: c4b7a1da9d872ed075ce99c80a90b11a135577a0 URL: https://github.com/llvm/llvm-project/commit/c4b7a1da9d872ed075ce99c80a90b11a135577a0 DIFF: https://github.com/llvm/llvm-project/commit/c4b7a1da9d872ed075ce99c80a90b11a135577a0.d

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56069b5c71ca: [OpenMP] Support `std::complex` math functions in target regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D85876: [OpenMP][FIX] Do not drop a '$' while demangling declare variant names

This revision was automatically updated to reflect the committed changes. Closed by commit rG05fd04eda4b2: [OpenMP][FIX] Do not drop a '$' while demangling declare variant names (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D85875: [OpenMP][FIX] Do not crash trying to print a missing (demangled) user condition

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a02932becae: [OpenMP][FIX] Do not crash trying to print a missing (demangled) user condition (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 05fd04e - [OpenMP][FIX] Do not drop a '$' while demangling declare variant names

Author: Johannes Doerfert Date: 2020-09-16T13:37:09-05:00 New Revision: 05fd04eda4b22b09e33753132cbf037a1265c7e2 URL: https://github.com/llvm/llvm-project/commit/05fd04eda4b22b09e33753132cbf037a1265c7e2 DIFF: https://github.com/llvm/llvm-project/commit/05fd04eda4b22b09e33753132cbf037a1265c7e2.d

[clang] 6a02932 - [OpenMP][FIX] Do not crash trying to print a missing (demangled) user condition

Author: Johannes Doerfert Date: 2020-09-16T13:37:08-05:00 New Revision: 6a02932becaeaeb02eddfaed567f3dad3719dd1c URL: https://github.com/llvm/llvm-project/commit/6a02932becaeaeb02eddfaed567f3dad3719dd1c DIFF: https://github.com/llvm/llvm-project/commit/6a02932becaeaeb02eddfaed567f3dad3719dd1c.d

[clang] 5c63ae1 - [OpenMP] Support nested OpenMP context selectors (declare variant)

Author: Johannes Doerfert Date: 2020-09-16T13:37:09-05:00 New Revision: 5c63ae156e96a20ce96570d4bd2c48a9c8170a9d URL: https://github.com/llvm/llvm-project/commit/5c63ae156e96a20ce96570d4bd2c48a9c8170a9d DIFF: https://github.com/llvm/llvm-project/commit/5c63ae156e96a20ce96570d4bd2c48a9c8170a9d.d

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

RKSimon added a comment. @joerg Are you alright with this now? If so please can you accept it to unblock it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87615/new/ https://reviews.llvm.org/D87615 ___

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

aganea added a subscriber: maniccoder. aganea added a comment. In D86694#2274682 , @cryptoad wrote: > In D86694#2274548 , @russell.gallop > wrote: > >> I guess using scudo as a general purpose allocator that could

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:86 + + // Get shadow call stack pointer register. + Register SCSPReg = RISCVABI::getSCSPReg(); Pointless comment; remove Comment at: llvm/lib/Target/RISCV/

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292280. tianshilei1992 added a comment. Fixed an issue that one wildcard is missing in the CHECK line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: cl

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. This is currently incompatible with the save/restore libcalls, and I don't think there's any way to avoid that (the restore libcall both loads ra and jumps to it). We should ensure c

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

efriedma accepted this revision. efriedma added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87615/new/ https://reviews.llvm.org/D87615 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] 4d4f092 - [clang][codegen] Skip adding default function attributes on intrinsics.

Author: Michael Liao Date: 2020-09-16T14:10:05-04:00 New Revision: 4d4f0922837de3f1aa9862ae8a8d941b3b6e5f78 URL: https://github.com/llvm/llvm-project/commit/4d4f0922837de3f1aa9862ae8a8d941b3b6e5f78 DIFF: https://github.com/llvm/llvm-project/commit/4d4f0922837de3f1aa9862ae8a8d941b3b6e5f78.diff

[PATCH] D87761: [clang][codegen] Skip adding default function attributes on intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d4f0922837d: [clang][codegen] Skip adding default function attributes on intrinsics. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8776

[PATCH] D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`

eduucaldas created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. eduucaldas requested review of this revision. - Introduce `TreeTest.cpp` to unit test `Tree.h` - Add `generateAllTreesWithShape` to generating test cases - Add tests for `findFirstLeaf`

[clang] 4d43734 - fix test no-rtti.cpp

Author: Zequan Wu Date: 2020-09-16T11:03:15-07:00 New Revision: 4d437348d24d6342bdeb3ad84a64e57a889a0ea2 URL: https://github.com/llvm/llvm-project/commit/4d437348d24d6342bdeb3ad84a64e57a889a0ea2 DIFF: https://github.com/llvm/llvm-project/commit/4d437348d24d6342bdeb3ad84a64e57a889a0ea2.diff LOG

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2276899 , @dmajor wrote: > In D87163#2275896 , @asbirlea wrote: > >> I checked in a fix in https://reviews.llvm.org/rGfc8200633122, but I haven't >> yet verified it addresses all

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm updated this revision to Diff 292275. arsenm added a comment. Herald added subscribers: wenlei, dang. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78979/new/ https://reviews.llvm.org/D78979 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clan

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng updated this revision to Diff 292274. zzheng added a comment. rebase & ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/ https://reviews.llvm.org/D84414 Files: clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolChain.

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG77a01d9498a7: Sema: add support for `__attribute__((__swift_bridge__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87532?vs=292018&id=292273#toc Repository: rG LLVM Gi

[clang] 77a01d9 - Sema: add support for `__attribute__((__swift_bridge__))`

Author: Saleem Abdulrasool Date: 2020-09-16T17:54:57Z New Revision: 77a01d9498a79d2e6e3f366fdb363928f188ec11 URL: https://github.com/llvm/llvm-project/commit/77a01d9498a79d2e6e3f366fdb363928f188ec11 DIFF: https://github.com/llvm/llvm-project/commit/77a01d9498a79d2e6e3f366fdb363928f188ec11.diff

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:104 +def ObjCClassMethod +: SubsetSubjectisInstanceMethod()}], This change is no longer needed. Comment at: clang/include/clang/Basic/AttrDocs.td:3584 +The

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 added a comment. > If I remember correctly, you may yield the thread inside a target region > after enqueuing kernels and transfers. So even with 1 thread, there is chance > to run other tasks without finishing this target. Isn't that possible? I assume you were referring to `tas

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 292271. tianshilei1992 added a comment. Fixed `declare_mapper_codegen.cpp` with `CK0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files: clang/lib/CodeGen/

[PATCH] D87775: [clangd] Add option for disabling AddUsing tweak on some namespaces.

sammccall added a comment. Nice! Comment at: clang-tools-extra/clangd/Config.h:66 + + /// Style of the codebase. + struct { describe elements more precisely? They are namespaces with/without leading/trailing ::, and sub-namespaces are implicitly included.

[clang] ebf267b - [Sema][MSVC] warn at dynamic_cast/typeid when /GR- is given

Author: Zequan Wu Date: 2020-09-16T10:38:52-07:00 New Revision: ebf267b87d4b557dff488f87f66df3628e3da957 URL: https://github.com/llvm/llvm-project/commit/ebf267b87d4b557dff488f87f66df3628e3da957 DIFF: https://github.com/llvm/llvm-project/commit/ebf267b87d4b557dff488f87f66df3628e3da957.diff LOG

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebf267b87d4b: [Sema][MSVC] warn at dynamic_cast/typeid when /GR- is given (authored by zequanwu). Changed prior to commit: https://reviews.llvm.or

[PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

ldionne added a comment. In D12689#2277225 , @eastig wrote: > Abandoned in favour of https://reviews.llvm.org/D31413 Sorry, we had a race condition :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12689/new/ https://reviews.llvm.org/D12689 __

  1   2   3   >