[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:2000 +defm split_machine_functions: OptInFFlag<"split-machine-functions", + "Enable", "Disable", " late function spli

[PATCH] D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:925 + "vstribr", "$vT, $vB", IIC_VecGeneral, +[(set v16i8:$vT, + (int_ppc_altivec_vstribr v16i8:

[PATCH] D87671: [PowerPC] Implement Vector String Isolate Builtins in Clang/LLVM

amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, nemanjai, saghir. amyk added projects: PowerPC, LLVM. Herald added subscribers: shchenz, hiraditya. Herald added a project: clang. amyk requested review of this revision. This patch implements the vector string isolate (pr

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. @balazske may have some closing words. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1262 Getline(LongLongTy

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. If there are no further comments I'll commit this in a few days. Comment at: clang/lib/Sema/SemaDecl.cpp:2088 + + if (Error || R.isNull()) +return nullptr; aaron.ballman wrote: > Should we do this check *before* we create the C link

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 291778. tambre marked 2 inline comments as done. tambre added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files: clang/include/clang/B

[PATCH] D87669: Rainbow Semantic Highlighting

alexzielenski created this revision. alexzielenski added reviewers: MaskRay, ilya-biryukov, sammccall. alexzielenski created this object with visibility "All Users". Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. alexzielenski requested

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. Some comments but I haven't gone through all of it. The tests are still missing. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6334 + + for (auto i = Clauses.rbegin(); i < Clauses.rend(); i++) { +OMPWhenClause *WhenClause = dyn_cast(*i);

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291775. snehasish added a comment. Remove unnecessary includes, update doc text. - Update doctext. - Remove no longer necessary includes to frontend driver diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2000 +defm split_machine_functions: OptInFFlag<"split-machine-functions", + "Enable", "Disable", " late function splitting using profile information (x86-elf only)">; + If this can

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish marked 3 inline comments as done. snehasish added a comment. That makes sense. I moved the check to lib/Driver/ToolChains/Clang.cpp and updated the test. Seems cleaner to have all the checks in one place. PTAL, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291771. snehasish marked an inline comment as done. snehasish added a comment. Check profile flag in Driver, update test. - Move the profile missing warning check to the Driver. - Update the test to use -### for CHECK-WARN. Repository: rG LLVM Github Mo

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

MaskRay added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:518 + if (CodeGenOpts.SplitMachineFunctions) { +if (CodeGenOpts.getProfileUse() != CodeGenOptions::ProfileNone) I did not pay attention. Such compatibility checks should be added

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/fsplit-machine-functions.c:3 +// RUN: %clang -### -target x86_64 -fprofile-use=default.profdata -fsplit-machine-functions -fno-

[PATCH] D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class

njames93 added a comment. Please fix the clang-format fail too. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-noexcept-opt.cpp:23 +// Shouldn't crash due to llvm_unreachable in canThrow() on EST_Uninstantiated +template class c { void *operator new(size

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

ahatanak added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7216 "aligned %select{allocation|deallocation}0 function of type '%1' is only " "available on %2 %3 or newer">; +def err_aligned_allocation_unavailable_on_os : Error< --

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish marked an inline comment as done. snehasish added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions.c:3 +// RUN: %clang -### -target x86_64 -fprofile-use=default.profdata -fsplit-machine-functions -fno-split-machine-functions %s -c 2>&1 | FileChec

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291758. snehasish added a comment. Remove extra -c from test command line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87047/new/ https://reviews.llvm.org/D87047 Files: clang/include/clang/Basic/CodeGenO

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

vsapsai added a comment. Noticed that the warning and the fix-it might not work well with pragmas suppressing diagnostic and with header guards. But it's not a regression and I don't think it is worth improving these use cases preemptively. Comment at: clang/lib/Lex/PPLexerCh

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

ye-luo added a comment. In D78075#2272474 , @tianshilei1992 wrote: > In D78075#2272398 , @ye-luo wrote: > >>> However, OpenMP task has a problem that it must be within >>> to a parallel region; otherwise the task w

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

asbirlea added a comment. I'd suggest reverting if the failures are blocking, but we do need a reproducer so it can be recommitted after a fix is in place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87163/new/ https://reviews.llvm.org/D87163 _

Buildbot numbers for the week of 09/06/2020 - 09/12/2020

Hello everyone, Below are some buildbot numbers for the last week of 09/06/2020 - 09/12/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 08/30/2020 - 09/5/2020

Hello everyone, Below are some buildbot numbers for the week of 08/30/2020 - 09/5/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

aaronpuchert added a comment. You can view it this way: there is a dynamic set and a static set of capabilities. The static set is always the same at any particular point in a function, regardless of the circumstances we're called from. It's what we determine in the analysis. The dynamic set de

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/AST/ExprConstant.cpp:775-778 +/// Strict floating point is enabled, this inhibits +/// floating ponit constant folding. +bool

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 291736. mibintc added a comment. This update uses context information from Expr->getFPFeaturesInEffect() to disable fp constant folding in ExprConstant.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87528/ne

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/fsplit-machine-functions.c:3 +// RUN: %clang -### -target x86_64 -fprofile-use=default.profdata -fsplit-machine-functions -fno-split-mach

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish added a comment. @MaskRay ping, let me know if you have any further comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87047/new/ https://reviews.llvm.org/D87047 ___ cfe-commits ma

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291728. snehasish added a comment. Rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87047/new/ https://reviews.llvm.org/D87047 Files: clang/include/clang/Basic/CodeGenOptions.def clang/includ

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

aaronpuchert added reviewers: aaron.ballman, aaronpuchert. aaronpuchert added a comment. We don't really have a good understanding of `ASSERT_CAPABILITY` ourselves. For example, there is this loophole: void h() { mu.AssertHeld(); mu.Unlock(); } One would expect to get a warning forc

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a reviewer: jdoerfert. Herald added a project: clang. compnerd requested review of this revision. Add the `swift_newtype` attribute which allows a type definition to be imported into Swift as a new type. The im

[clang] da55e9b - [Sema] Address-space sensitive index check for unbounded arrays

Author: Chris Hamilton Date: 2020-09-14T18:13:19-05:00 New Revision: da55e9ba1273284f1af61bceeaeb25e487838034 URL: https://github.com/llvm/llvm-project/commit/da55e9ba1273284f1af61bceeaeb25e487838034 DIFF: https://github.com/llvm/llvm-project/commit/da55e9ba1273284f1af61bceeaeb25e487838034.diff

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rGda55e9ba1273: [Sema] Address-space sensitive index check for unbounded arrays (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rjmccall added a subscriber: scanon. rjmccall added a comment. That's a really useful concept, and given that it exists, I agree that we shouldn't invent something else. The fact that it covers local variables with constant initializers that happen to be `const` seems really unfortunate, thoug

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 added a comment. In D78075#2272398 , @ye-luo wrote: >> However, OpenMP task has a problem that it must be within >> to a parallel region; otherwise the task will be executed immediately. As a >> result, if we directly wrap to a regular task,

[PATCH] D87648: [Coverage][NFC] Remove skipped region after added into MappingRegions

zequanwu created this revision. zequanwu added a reviewer: vsk. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. There is no need to scan through all SkippedRegions when some of them are already added into MappingRegions. Reposit

[PATCH] D78075: [WIP][Clang][OpenMP] Added support for nowait target in CodeGen

ye-luo added a comment. > However, OpenMP task has a problem that it must be within > to a parallel region; otherwise the task will be executed immediately. As a > result, if we directly wrap to a regular task, the nowait target outside of a > parallel region is still a synchronous version. The s

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

zixuw added a comment. @arphaman @vsapsai @bruno This diff has been sitting here for too long. I've separated out the fix-it hint part (working on implementing a //'FullSourceRange'// to be used by FixItHint now) and this is just a concise change for the warning message now. Does it look good?

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

rsmith accepted this revision. rsmith added a comment. Thanks! This looks good to me (subject to Aaron's comment being addressed). Please wait a couple of days for any more comments from the other reviewers. Comment at: clang/lib/Sema/SemaDecl.cpp:9689 + Cont

[PATCH] D87636: [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode

mtrofin added inline comments. Comment at: clang/test/CodeGen/Inputs/start-lib2.ll:4 -declare void @bar() - -define void @foo() { +define void @bar() { ret void The message that this was copied from llvm/test/LTO/X86/Inputs/start-lib1.ll is incorrect - this

[PATCH] D87604: [X86] Convert integer _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

craig.topper added a comment. Longer term should we have a variadic version of this like __builtin_shufflevector or __builtin_convertvector that can handle any reduction? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87604/new/ https://reviews.ll

[PATCH] D87636: [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode

mtrofin created this revision. mtrofin added reviewers: tejohnson, zapster. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a reviewer: alexshap. Herald added projects: clang, LLVM. mtrofin requested review of this revision. This will

[PATCH] D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`

compnerd updated this revision to Diff 291687. compnerd added a comment. - make the attribute inheritable - add a test case for inheritance - add a test case for C++ type alias Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://review

[PATCH] D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`

compnerd marked 3 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftBridgedTypedef : Attr { + let Spellings = [GNU<"swift_bridged_typedef">]; compnerd wrote: > aaron.ballman wrote: > > Should

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

dmajor added a comment. In D87163#2272105 , @fhahn wrote: > I also pushed a fix for a MemorySSA issue that was exposed through DSE + > MemorySSA in c4f1b3144184 > . This > might also f

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2271998 , @dmajor wrote: > In D87163#2270871 , @fhahn wrote: > >> In D87163#2270444 , @thakis wrote: >> >>> Heads-up: We're seeing fairly wid

[PATCH] D87164: Extending Baremetal toolchain's support for the rtlib option.

jroelofs added a comment. In D87164#2268366 , @mcarrasco wrote: > @jroelofs no worries, thanks a lot for your time. > > Please tell me if I understood you correctly. > > It is acceptable just to append the -lgcc if -rtlib=libgcc is used, although > the us

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

dmajor added a comment. In D87163#2270871 , @fhahn wrote: > In D87163#2270444 , @thakis wrote: > >> Heads-up: We're seeing fairly widespread test failures with this in Chromium >> that go away when we force this fl

[clang] 226d80e - [MemProf] Rename HeapProfiler to MemProfiler for consistency

Author: Teresa Johnson Date: 2020-09-14T13:14:57-07:00 New Revision: 226d80ebe20e2d796af6c1bc43d9fbdfbb9d4a07 URL: https://github.com/llvm/llvm-project/commit/226d80ebe20e2d796af6c1bc43d9fbdfbb9d4a07 DIFF: https://github.com/llvm/llvm-project/commit/226d80ebe20e2d796af6c1bc43d9fbdfbb9d4a07.diff

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG226d80ebe20e: [MemProf] Rename HeapProfiler to MemProfiler for consistency (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency

tejohnson added a comment. In D87622#2271931 , @davidxl wrote: > LGTM (if the option is documented, the documentation part also needs to be > updated). It isn't documented yet, since the generated code won't work until the runtime is in. I will be send

[PATCH] D63697: clang-format: Fix error return when using inplace with stdin

thakis requested changes to this revision. thakis added a comment. This revision now requires changes to proceed. (marking this "request changes" to get it off my dashboard. please ping if you do add a test :) ) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63697

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. LGTM (if the option is documented, the documentation part also needs to be updated). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87622/new/

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ryanofsky requested review of this revision. Previous description didn't actually state the effect the attribute has on thread safety analysis (causing analysis to assume the capability is held)

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency (NFC)

tejohnson added a comment. In D87622#2271861 , @MaskRay wrote: > LG. (Nit: technically this is not NFC: it affects command line options and > runtime function names (ABI changes).) Fair enough, will remove that. Repository: rG LLVM Github Monorepo C

[PATCH] D87603: [X86] Update SSE/AVX integer MINMAX intrinsics to emit llvm.smax.* etc. (PR46851)

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM. I think we have enough to start using them for vector intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87603/new/ https://reviews.l

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency (NFC)

MaskRay added a comment. LG. (Nit: technically this is not NFC: it affects command line options and runtime function names (ABI changes).) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87622/new/ https://reviews.llvm.org/D87622 __

[PATCH] D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class

zinovy.nis created this revision. zinovy.nis added reviewers: alexfh, rsmith. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. zinovy.nis requested review of this revision. Bug: https://bugs.llvm.org/show_bug.cgi?id=474

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. In D86694#2270433 , @aganea wrote: > Thanks for working on this @russell.gallop! > > I've reproduced your tests, please see below. The only difference is that > I've used a ThinLTO build for stage2: Thanks. It's good to kn

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng updated this revision to Diff 291638. fanbo-meng marked an inline comment as done. fanbo-meng added a comment. change vendor name from ibm to none for tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D87611 Files: clang/include/clang

[PATCH] D87624: [SystemZ][z/OS] Set default wchar_t type for zOS

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan added reviewers: abdulras, uweigand, hubert.reinterpretcast, fanbo-meng, Kai, ro, zibi, SeanP. Herald added a project: clang. Herald added a subscriber: cfe-commits. abhina.sreeskantharajan requested review of this revision. S

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

zequanwu updated this revision to Diff 291630. zequanwu added a comment. Rename option EmptyLineCoverage to EmptyLineCommentCoverage and mark it cl::Hidden. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://reviews.llvm.org/D84988

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

efriedma added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8522 + return VT->getElementType().getCanonicalType() == + getBuiltinVectorTypeInfo(BT).ElementType; } We allow casting SVE fixed-width vectors only if the el

[PATCH] D87615: [clang][Driver] Force stack realignment on 32-bit Solaris/x86

joerg requested changes to this revision. joerg added a comment. This revision now requires changes to proceed. I don't think this is the right place for this at all. Look at `X86Subtarget::initSubtargetFeatures` please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

vsk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:38 + "disable it on test)"), +llvm::cl::init(true)); + We might consider marking this as cl::Hidden. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time

zequanwu added a comment. In D87425#2265523 , @hans wrote: > I'm not sure that changing isPotentiallyEvaluated() is the right thing to do. > The meaning of that corresponds to text in the standard: > https://eel.is/c++draft/expr.typeid#3 so changing it t

[PATCH] D87615: [clang][Driver] Force stack realignment on 32-bit Solaris/x86

efriedma added a comment. In D87615#2271297 , @ro wrote: > In D87615#2271268 , @RKSimon wrote: > >> Would it be possible to add some tests? > > Probably not reliably: the tests that usually fail bye the hundreds hap

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd updated this revision to Diff 291621. compnerd added a comment. - Add additional test case that was requested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDoc

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

mibintc added a comment. In D69272#2271338 , @sepavloff wrote: > In D69272#2268337 , @mibintc wrote: > >> I am working on a task to ensure that clang is doing floating point constant >> folding correctly. > > Could

[PATCH] D87622: [MemProf] Rename HeapProfiler to MemProfiler for consistency (NFC)

tejohnson created this revision. tejohnson added a reviewer: davidxl. Herald added subscribers: jfb, hiraditya, mgorny. Herald added projects: clang, LLVM. tejohnson requested review of this revision. This is consistent with the clang option added in 7ed8124d46f94601d5f1364becee9cee8538265e

[PATCH] D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time

zequanwu updated this revision to Diff 291619. zequanwu added a comment. If the operand of CXXTypeidExpr is already most derived object, no need to look up vtable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87425/new/ https://reviews.llvm.org/D

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng updated this revision to Diff 291616. fanbo-meng added a comment. be consistent with namespace qualification CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D87611 Files: clang/include/clang/Basic/AlignedAllocation.h clang/include/clang/

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:216 +{"long","l"}, +{"long long", "ll"}, +{"unsigned long", "ul"}, `unsigned long long` -> `ull` ===

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

tra added subscribers: aaron.ballman, rtrieu. tra added a comment. So, the idea here is to do some sort of duck-typing and allow DiagBuilder to work with both `DiagnosticBuilder` and `PartialDiagnostic`. What bothers me is that unlike `Diagnostic` `PartialDiagnostic` seems to be commingling fun

[PATCH] D87455: [clang-tidy] performance-unnecessary-copy-initialization: Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments

flx added a comment. Thank you for the review, Aaron! I don't have have commit access. Would you mind submitting it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87455/new/ https://reviews.llvm.org/D87455 ___ cfe-commits mailing list cfe-co

[PATCH] D87561: [Sema] List conversion validate character array

Mordante marked 3 inline comments as done. Mordante added a comment. Thanks for the feedback! Comment at: clang/lib/Sema/SemaOverload.cpp:4988 + +if (ToType->isArrayType() && ToType->isCharType() && +isa(From->getInit(0))) { rsmith wrote: > `isCharT

[PATCH] D87455: [clang-tidy] performance-unnecessary-copy-initialization: Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments

flx updated this revision to Diff 291610. flx marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87455/new/ https://reviews.llvm.org/D87455 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tools-extra/test/clang-tid

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1841 -<< IsDelete << FD.getType().getAsString() << OSName -<< alignedAllocMinVersion(T.getOS()).getAsString(); Diag(Loc, diag::note_silence_aligned_allocation_unavailable); -

[PATCH] D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry added a comment. Hey @MyDeveloperDay, thanks for the review. On the one hand, you're right, it's a breaking change and I dislike it too. But please, reconsider because on the other hand: a) adding a new option means increasing our maintenance cost by possibly adding a rarely-used switch (

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7841e21c9849: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map… (authored by rahmanl). Repository: rG LLVM Github M

[clang] 7841e21 - Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

Author: Rahman Lavaee Date: 2020-09-14T10:16:44-07:00 New Revision: 7841e21c98495ba5e33e0d2507d985bd5b938445 URL: https://github.com/llvm/llvm-project/commit/7841e21c98495ba5e33e0d2507d985bd5b938445 DIFF: https://github.com/llvm/llvm-project/commit/7841e21c98495ba5e33e0d2507d985bd5b938445.diff

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 291607. rahmanl added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files: clang/docs/UsersManual.rst clang/test/CodeGen/basic-block-sections.

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

martong updated this revision to Diff 291606. martong added a comment. - Add tests to verify compatibility of the two checkers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87081/new/ https://reviews.llvm.org/D87081 Files: clang/lib/StaticAnalyz

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd updated this revision to Diff 291601. compnerd marked an inline comment as done. compnerd added a comment. Address some feedback from @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87532/new/ https://reviews.llvm.org/D87532

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd marked 4 inline comments as done. compnerd added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5535 + // Don't duplicate annotations that are already set. + if (D->hasAttr()) { +S.Diag(AL.getLoc(), diag::warn_duplicate_attribute) << AL.getAttrName();

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/ZOS.cpp:25-27 +void ZOS::addClangTargetOptions(const llvm::opt::ArgList &DriverArgs, +llvm::opt::ArgStringList &CC1Args, +Action::

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 291595. rahmanl added a comment. - Merge branch 'master' into arcpatch-D85408 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files: clang/docs/UsersManual.rst clan

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

doug.gregor added a comment. Thank you for doing this! Comment at: clang/include/clang/Basic/Attr.td:2173 + SubjectList<[Enum, EnumConstant, Field, Function, GlobalVar, Struct, TypedefName, + ObjCInterface, ObjCClassMethod, ObjCInstanceMethod, ObjCPrope

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng updated this revision to Diff 291593. fanbo-meng added a comment. Previous diff is incorrect and didn't include the entire change set, making a new one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D87611 Files: clang/include/clang/Bas

[PATCH] D87588: [ASTMatchers] extract public matchers from const-analysis into own patch

JonasToth updated this revision to Diff 291592. JonasToth added a comment. - fix compilation error from removed brace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87588/new/ https://reviews.llvm.org/D87588 Files: clang/docs/LibASTMatchersRefere

[PATCH] D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS

fanbo-meng updated this revision to Diff 291590. fanbo-meng added a comment. emit the correct diagnostics for z/OS. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87611/new/ https://reviews.llvm.org/D87611 Files: clang/include/clang/Basic/AlignedAllocation.h clang/include/clang/Basi

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 291589. rahmanl added a comment. - Remove the "labels" part of the clang test as the functionality is tested on LLVM tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85

[PATCH] D87455: [clang-tidy] performance-unnecessary-copy-initialization: Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some minor nits. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:122 // the first. - for (unsigned int i =

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd updated this revision to Diff 291587. compnerd added a comment. Add additional test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 Files: clang/include/clang/Basic/Attr.td clang/include/c

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

sepavloff added a comment. In D69272#2268337 , @mibintc wrote: > I am working on a task to ensure that clang is doing floating point constant > folding correctly. Could you please share your plans on it? I recently also started implementing constant fol

[PATCH] D86796: [Sema] Address-space sensitive index check for unbounded arrays

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8841-8844 +def warn_array_index_exceeds_max_addressable_bounds : Warning< + "array index %0

[PATCH] D87455: [clang-tidy] performance-unnecessary-copy-initialization: Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:126 if (OldVar == nullptr) { +// Only allow initialization of a const reference from a free function if it +// has no arguments or only default arguments

[PATCH] D87455: [clang-tidy] performance-unnecessary-copy-initialization: Restrict UnnecessaryCopyInitialization check to variables initialized from free functions without arguments

flx updated this revision to Diff 291584. flx edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87455/new/ https://reviews.llvm.org/D87455 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tools-extra/test/clang-

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7543 + case ParsedAttr::AT_SwiftBridgedTypedef: +handleSimpleAttribute(S, D, AL); +break; compnerd wrote: > aaron.ballman wrote: > > compnerd wrote: > > > aaron.ballman wrot

[PATCH] D87587: [clang-format][PR47290] Make one-line namespaces resistant to FixNamespaceComments, update documentation

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. I have a hard time when people change tests! just because one person wants them this way doesn't mean everyone will. I am not sure about others but I'd be ok about seeing this as an option to override the value b

  1   2   >