[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:1070 +Builder.markChildToken( +std::next(Builder.findToken(S->getCallee()->getEndLoc())), +syntax::NodeRole::OpenParen); gribozavr2 wrote: > Could you add an

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas updated this revision to Diff 287842. eduucaldas marked 8 inline comments as done. eduucaldas added a comment. Answer code review, squash commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86544/new/ https://reviews.llvm.org/D86544 F

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu updated this revision to Diff 287835. zequanwu added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/incl

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson updated this revision to Diff 287832. tejohnson marked 2 inline comments as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85948/new/ https://reviews.llvm.org/D85948 Files: clang/include

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

tejohnson marked 18 inline comments as done. tejohnson added a comment. I think I've addressed all the comments. Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:48 +// Size of memory mapped to a single shadow location. +static const uint64_t DefaultShadowGranul

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG72bdb41a06a2: [Docs] Document --lto-whole-program-visibility (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://revie

[clang] 72bdb41 - [Docs] Document --lto-whole-program-visibility

Author: Teresa Johnson Date: 2020-08-25T19:44:54-07:00 New Revision: 72bdb41a06a27b5453bf966a0ffecfa6f5fae1a6 URL: https://github.com/llvm/llvm-project/commit/72bdb41a06a27b5453bf966a0ffecfa6f5fae1a6 DIFF: https://github.com/llvm/llvm-project/commit/72bdb41a06a27b5453bf966a0ffecfa6f5fae1a6.diff

[PATCH] D86427: Fix some spelling errors

YangZhihui added a comment. In D86427#2237668 , @plotfi wrote: > In D86427#2235630 , @YangZhihui > wrote: > >> how can I add the Author property in the patch >> Thanks > > Is your email `yangzh.f...@cn.fujitsu.com

[PATCH] D86427: Fix some spelling errors

plotfi added a comment. In D86427#2235630 , @YangZhihui wrote: > how can I add the Author property in the patch > Thanks Is your email `yangzh.f...@cn.fujitsu.com` associated with a github account? If it is, this is all I need. Repository: rG LLVM G

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

emaste added inline comments. Comment at: clang/lib/Basic/Targets.cpp:361-362 return new LinuxTargetInfo(Triple, Opts); +case llvm::Triple::FreeBSD: + return new FreeBSDTargetInfo(Triple, Opts); case llvm::Triple::NetBSD: List was previously

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Thanks and sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 __

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 updated this revision to Diff 287811. Bdragon28 added a comment. Use correct target for FreeBSD driver test. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ https://reviews.llvm.org/D73425 Files: clan

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson updated this revision to Diff 287808. tejohnson marked an inline comment as done. tejohnson added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75655/new/ https://reviews.llvm.org/D75655 Files: clang/docs/LT

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson marked an inline comment as done. tejohnson added a comment. In D75655#2237474 , @pcc wrote: > I think that the part of the description beginning "This can be used when..." > is somewhat misleading since you could pretty much say the same thing

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 added inline comments. Comment at: clang/test/Driver/freebsd.c:32 +// CHECK-PPC64LE: "--eh-frame-hdr" "-dynamic-linker" "{{.*}}ld-elf{{.*}}" "-o" "a.out" "{{.*}}crt1.o" "{{.*}}crti.o" "{{.*}}crtbegin.o" "-L[[SYSROOT]]/usr/lib" "{{.*}}.o" "-lgcc" "--as-needed" "-lgcc_s

[PATCH] D86581: [clang-format] Handle shifts within conditions

Saldivarcher created this revision. Saldivarcher added a reviewer: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Saldivarcher requested review of this revision. In some situation shifts can be treated as a template, and is thus formatted as one. So, by doing

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

MaskRay added inline comments. Comment at: clang/test/Driver/freebsd.c:32 +// CHECK-PPC64LE: "--eh-frame-hdr" "-dynamic-linker" "{{.*}}ld-elf{{.*}}" "-o" "a.out" "{{.*}}crt1.o" "{{.*}}crti.o" "{{.*}}crtbegin.o" "-L[[SYSROOT]]/usr/lib" "{{.*}}.o" "-lgcc" "--as-needed" "-lgcc_s"

[PATCH] D82777: Clang Driver: Use Apple ld64's new @response-file support.

jyknight added a comment. BTW, to the apple folks here, it'd sure be awesome if this could be backported into XCode 12's clang. :) (c.f. FB7037642). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82777/new/ https://reviews.llvm.org/D82777

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

jdoerfert marked 5 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10042 void ActOnFinishedFunctionDefinitionInOpenMPDeclareVariantScope( - FunctionDecl *FD, FunctionDecl *BaseFD); + Decl *D, SmallVectorImpl &Base

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10042 void ActOnFinishedFunctionDefinitionInOpenMPDeclareVariantScope( - FunctionDecl *FD, FunctionDecl *BaseFD); + Decl *D, SmallVectorImpl &Bases); JonChesterfield wrote:

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev added a comment. In D86562#2237399 , @kkwli0 wrote: > `default(firstprivate)` was added in > https://reviews.llvm.org/rG78443666bc18a6957d279a0f58319c8a3e57771a Yest, it was before clang 11 was branched, so need to add to the list of the changes

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

jdoerfert added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/complex_cmath.h:58 + +template __DEVICE__ _Tp norm(const std::complex<_Tp> &__c) { + if (std::isinf(__c.real())) JonChesterfield wrote: > Doesn't matter hugely given inlining, but I'

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai marked an inline comment as done. vsapsai added a comment. Thanks for the review. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:700 + "no module named '%0' %select{found|in '%2'}1, " + "expected parent module to be defined before the submodule">; def er

[clang] 8839e27 - [Modules] Improve error message when cannot find parent module for submodule definition.

Author: Volodymyr Sapsai Date: 2020-08-25T16:31:27-07:00 New Revision: 8839e278ffcadc62b333423de07756488cae980f URL: https://github.com/llvm/llvm-project/commit/8839e278ffcadc62b333423de07756488cae980f DIFF: https://github.com/llvm/llvm-project/commit/8839e278ffcadc62b333423de07756488cae980f.di

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8839e278ffca: [Modules] Improve error message when cannot find parent module for submodule… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Bdragon28 updated this revision to Diff 287795. Bdragon28 added reviewers: MaskRay, dim. Bdragon28 added a comment. Herald added a subscriber: kbarton. Add some tests for the new target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73425/new/ http

[PATCH] D85777: [OpenMP] Support std::complex math functions in target regions

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. The duplication from libc++ doesn't feel good but I can see how it happened. Dependency breaking etc. Comment at: clang/lib/Headers/openmp_wrappers/complex

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

pcc added a comment. I think that the part of the description beginning "This can be used when..." is somewhat misleading since you could pretty much say the same thing about specifying `-fvisibility=hidden -fwhole-program-vtables` at compile time. I think it would be better to focus on the spe

[PATCH] D85735: [OpenMP] Context selector extensions for template functions

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. This looks good to me. I can't claim to have read the test case in detail. Some style suggestions inline around the vector, but they're not blocking. Comme

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

kkwli0 added a comment. `default(firstprivate)` was added in https://reviews.llvm.org/rG78443666bc18a6957d279a0f58319c8a3e57771a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev added a comment. In D86562#2237388 , @kkwli0 wrote: > `present` map type and motion modifier > `default(firstprivate)` Present was added after 11.0 branching. Not aure about default(firstprivate) Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 9500a72 - Revert "[Coverage] Enable emitting gap area between macros"

Author: Zequan Wu Date: 2020-08-25T15:28:42-07:00 New Revision: 9500a7209163d6bfce7d554cb71a7c189ca5de58 URL: https://github.com/llvm/llvm-project/commit/9500a7209163d6bfce7d554cb71a7c189ca5de58 DIFF: https://github.com/llvm/llvm-project/commit/9500a7209163d6bfce7d554cb71a7c189ca5de58.diff LOG

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

kkwli0 added a comment. `present` map type and motion modifier `default(firstprivate)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562 ___ cfe-commits mailing lis

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

dblaikie accepted this revision. dblaikie added a comment. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 ___ cfe-commits mailing list cfe-co

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

MaskRay added inline comments. Comment at: clang/docs/LTOVisibility.rst:39 +During the LTO link, all classes with public LTO visibility will be refined +to hidden LTO visibility when the ``-lto-whole-program-visibility`` lld linker +option is applied (``-plugin-opt=whole-program-

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev updated this revision to Diff 28. ABataev added a comment. Misprint fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev added a comment. In D86562#2237215 , @jdoerfert wrote: > Nit: Maybe we should mention `complex` support on nvptx devices. Ok, will add. > The rest looks good to me. Others might want to add stuff That was the intention. > but we can merge this

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev updated this revision to Diff 287776. ABataev added a comment. + complex types for NVPTX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86562/new/ https://reviews.llvm.org/D86562 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/Rele

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

rsmith added a comment. Have you considered using the `ext_vector_type` attribute instead of `vector_size` for this? That would have a couple of advantages: - It's not a GCC attribute, so there's no risk that GCC would give different meaning to the same syntax (such as using one byte per vector

[PATCH] D86544: [SyntaxTree] Add support for call expressions

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:333 +/// call-arguments: +/// delimited_list(expression, ',', ) +/// Note: This construct is a simpli

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

NoQ added a comment. No-no, recursive locks are much more complicated than that, please do them separately. You'll have to discriminate between a real double lock / double unlock bug and an actual valid use of the recursive mutex in order to emit any warnings at all. That's completely different

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille added a comment. I'll need a contact email to preserve authorship information, can you send me one at `sguel...@redhat.com`? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 __

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

MaskRay added inline comments. Comment at: clang/tools/driver/driver.cpp:537 + // When running in integrated-cc1 mode, the CrashRecoveryContext returns + // the same code as if the program crashed. On Unix, that is codes >128. + IsCrash |= CommandRes > 128; ---

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Nit: Maybe we should mention `complex` support on nvptx devices. The rest looks good to me. Others might want to add stuff but we can merge this right away (IMHO) Repository: rG LLVM

[PATCH] D85485: Fix quiet mode in git-clang-format

serge-sans-paille accepted this revision. serge-sans-paille added a comment. Sure, thanks for your patience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85485/new/ https://reviews.llvm.org/D85485 ___ c

[PATCH] D86293: [analyzer] Add modeling of Eq operator in smart ptr

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks amazing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86293/new/ https://reviews.llvm.org/D86293 _

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:483 +llvm::raw_ostream &OS) { + BR.markInteresting(ThisRegion); + OS << "Smart

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG97ccf93b3615: [SystemZ][z/OS] Add z/OS Target and define macros (authored by abhina.sreeskantharajan, committed by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 97ccf93 - [SystemZ][z/OS] Add z/OS Target and define macros

Author: Abhina Sreeskantharajan Date: 2020-08-25T15:51:59-04:00 New Revision: 97ccf93b3615ff4c0d5fe116e6a7c7b616d8ec0c URL: https://github.com/llvm/llvm-project/commit/97ccf93b3615ff4c0d5fe116e6a7c7b616d8ec0c DIFF: https://github.com/llvm/llvm-project/commit/97ccf93b3615ff4c0d5fe116e6a7c7b616d8

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau updated this revision to Diff 287755. ctetreau marked 4 inline comments as done. ctetreau added a comment. address code review issues, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582 Files:

[clang] b1009ee - Reland "[DebugInfo] Move constructor homing case in shouldOmitDefinition."

Author: Amy Huang Date: 2020-08-25T12:36:11-07:00 New Revision: b1009ee84fc0242bcebd07889306bf39d9b7170f URL: https://github.com/llvm/llvm-project/commit/b1009ee84fc0242bcebd07889306bf39d9b7170f DIFF: https://github.com/llvm/llvm-project/commit/b1009ee84fc0242bcebd07889306bf39d9b7170f.diff LOG

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang updated this revision to Diff 287748. akhuang added a comment. Fix errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-in

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai updated this revision to Diff 287749. vsapsai added a comment. Tweak the error text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84458/new/ https://reviews.llvm.org/D84458 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

aganea updated this revision to Diff 287747. aganea marked an inline comment as done. aganea added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase. Address @MaskRay's suggestions. Made `safeLldLink` a public API and made it possible to provide user-defined

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added a comment. In D86559#2236931 , @Quuxplusone wrote: > It seems like this patch would basically "copy" the `[[likely]]` attribute > from line C up to lines A and B, where it would reinforce the likelihood of > path A and (maybe?) "cancel out

[PATCH] D86065: [SVE] Make ElementCount members private

ctetreau added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:56 + friend bool operator>(const ElementCount &LHS, const ElementCount &RHS) { +assert(LHS.Scalable == RHS.Scalable && fpetrogalli wrote: > paulwalker-arm wrote: > > david-arm

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. just reopening to update the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86491/new/ https://reviews.llvm.org/D86491 _

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

steakhal added a comment. In D85728#2237006 , @NoQ wrote: > Hans is pinging us on Bugzilla because this patch is marked as a release > blocker (and i believe that it indeed is). I think we should land these > patches. I believe @baloghadamsoftware is on

[PATCH] D85728: [Analyzer] Support for the new variadic isa<> and isa_and_not_null<> in CastValueChecker

NoQ added a comment. Hans is pinging us on Bugzilla because this patch is marked as a release blocker (and i believe that it indeed is). I think we should land these patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85728/new/ https://reviews.llvm.org/D85728 _

[clang] 01eb123 - [X86] Mention -march=sapphirerapids in the release notes.

Author: Craig Topper Date: 2020-08-25T11:57:34-07:00 New Revision: 01eb1233db54454b146cb1e70d6f810ffbc354e5 URL: https://github.com/llvm/llvm-project/commit/01eb1233db54454b146cb1e70d6f810ffbc354e5 DIFF: https://github.com/llvm/llvm-project/commit/01eb1233db54454b146cb1e70d6f810ffbc354e5.diff

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Quuxplusone added a comment. This feels like the wrong approach to me... but I admit that I don't know what the "right" approach might be. (I doubt any right approach exists.) if (ch == ' ') [[likely]] { goto whitespace; // A } else if (ch == '\n' || ch == '\t') [[unlikely]] { g

[PATCH] D83845: [LTO/WPD] Remove special type test handling for -flto-visibility-public-std

tejohnson added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83845/new/ https://reviews.llvm.org/D83845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D75655: [Docs] Document -lto-whole-program-visibility

tejohnson added a comment. @pcc ping. I'd like to get something in for LLVM 11 if at all possible. How about for now I make the last sentence something like "This is useful in situations where it is not safe to specify``-fvisibility=hidden`` at compile time, for example when bitcode objects wil

[PATCH] D86562: [OPENMP][NFC]Release notes for OpenMP in clang (11.x).

ABataev created this revision. ABataev added reviewers: jdoerfert, kkwli0, RaviNarayanaswamy, hfinkel. Herald added subscribers: jfb, guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monore

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau marked 8 inline comments as done. ctetreau added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1765 } auto *VectorTy = dyn_cast( cast(Addr.getPointer()->getType())->getElementType()); c-rhodes wrote: > cast here that would be a b

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

tejohnson added inline comments. Comment at: llvm/lib/Analysis/OptimizationRemarkEmitter.cpp:103 BFI = &getAnalysis().getBFI(); - else +// Get hotness threshold from PSI. This should only happen once. +if (Context.isDiagnosticsHotnessThresholdSetFromPSI()) { ---

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante created this revision. Mordante added reviewers: rsmith, rjmccall, aaron.ballman. Mordante added a project: clang. Herald added a subscriber: cfe-commits. Mordante requested review of this revision. Allows the likelihood attributes on label, which are not part of a case statement. When a

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

hans added a comment. I'll land tomorrow unless Alexandre beats me to it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85998/new/ https://reviews.llvm.org/D85998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D86491: [DebugInfo] Move constructor homing case in shouldOmitDefinition.

akhuang added a comment. In D86491#2235206 , @MaskRay wrote: > Note that Harbormaster actually reported the check-clang-codegencxx issues > B69369 .. Definitely my bad; I thought I had run check-clang locally before commi

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen added a comment. Thanks @hans! I'll need you (or someone else with permission) to land the change on my behalf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85998/new/ https://reviews.llvm.org/D85998 ___ cfe-commits mailing list cfe-

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng added a comment. In D84414#2234267 , @lenary wrote: > Ok, so any compilation units without `-fsanitize=shadow-call-stack` should be > compiled with `-ffixed-x18` if you want to link those together. That is > reasonable. My question was whether we

[PATCH] D86558: [OPENMP]Add support for allocate vars in untied tasks.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Local vars, marked with pragma allocate, mustbe allocate by the call of the

[PATCH] D85810: [clang] Pass-through remarks options to linker

tejohnson added a comment. Looks pretty good but I think it can be simplified in one place as I note below. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:596 + // Handle remark diagnostics on screen options: '-Rpass-*'. + if (usesRpassOptions(Args)) +renderRpassO

[PATCH] D86376: [HIP] Improve kernel launching latency

tra added a comment. In D86376#2236501 , @yaxunl wrote: > My previous measurements did not warming up, which caused some one time > overhead due to device initialization and loading of device binary. With warm > up, the call of `__hipPushCallConfigure/__

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:506 | `-'~' -|-'decltype' +|-'decltype' OpenParen |-'(' This is wrong but it's just because decltype is all wrong =

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas updated this revision to Diff 287694. eduucaldas added a comment. - Nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86544/new/ https://reviews.llvm.org/D86544 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Sy

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 287692. simoll added a comment. NFC. Make clang-tidy happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81083/new/ https://reviews.llvm.org/D81083 Files: clang/docs/LanguageExtensions.rst clang/include/cl

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

tejohnson added a comment. In D77925#2229484 , @mehdi_amini wrote: > Overall that would likely work for XLA. Something I'd like to mention though > in response to: > >> The veclib type is also tied to the accepted values for -fveclib, which is a >> list

[PATCH] D86376: [HIP] Improve kernel launching latency

yaxunl added a comment. In D86376#2234824 , @tra wrote: > In D86376#2234719 , @yaxunl wrote: > >>> This patch appears to be somewhere in the gray area to me. My prior >>> experience with CUDA suggests that it will

[PATCH] D86221: [compiler-rt][builtins] Do not assume int to be at least 32 bit wide

atrosinenko abandoned this revision. atrosinenko added a comment. Replaced this by D86546: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls and D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z

[PATCH] D86547: [compiler-rt][builtins] Use c[tl]zsi macro instead of __builtin_c[tl]z

atrosinenko created this revision. atrosinenko added reviewers: efriedma, MaskRay, aykevl, uabelho. Herald added subscribers: Sanitizers, dberris. Herald added a project: Sanitizers. atrosinenko requested review of this revision. `__builtin_c[tl]z` accepts `unsigned int` argument that is not alway

[PATCH] D86546: [compiler-rt][builtins] Use explicitly-sized integer types for LibCalls

atrosinenko created this revision. atrosinenko added reviewers: efriedma, MaskRay, aykevl, uabelho. Herald added subscribers: Sanitizers, dberris. Herald added a project: Sanitizers. atrosinenko requested review of this revision. Use s[iu]_int instead of `(unsigned) int` and d[ui]_int instead of `

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen added a comment. The real reason we don't see it internally is because we use -c for all compilation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85998/new/ https://reviews.llvm.org/D85998 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. I also seem to have broken a bunch of tests, although I'm not sure why. If you see an obvious cause, I'm happy to get some pointers, otherwise, I'll just dig in an debug as I extend the test suite once the patch stabilizes. Repository: rG LLVM Github Monor

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

jonathan.protzenko added a comment. Thanks for the review! Regarding Declarator: I briefly mentioned something related in the details section... actually maybe you can tell me what's the best approach here. I was thinking of just passing in a void* and expecting plugins to do if (const Decla

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen marked an inline comment as done. zahen added a comment. In D85998#2236401 , @hans wrote: > I'm still curious why it seems it's not looking for link.exe in the /fake dir > though. clang\lib\Driver\ToolChains\MSVC.cpp:311 FindVisualStudioExecutable

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

Szelethus marked an inline comment as done and an inline comment as not done. Szelethus added a comment. I'll get the nits I didn't object to fixed, thats the status you're looking for :) Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1338-1339 void TokenPrint

[PATCH] D86544: [SyntaxTree] Add support for call expressions

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Add support for all C++ call expressions, including those coming from `operator()`. A call expression's arguments are inside their own node - `Cal

[PATCH] D86531: [analyzer][StdLibraryFunctionsChecker][NFC] Use Optionals throughout the summary API

martong updated this revision to Diff 287680. martong added a comment. - Use FileCheck in the lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86531/new/ https://reviews.llvm.org/D86531 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFu

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas added a comment. Hi @hans , I'll have a look at it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

hans added a comment. Seems reasonable to me. I'm still curious why it seems it's not looking for link.exe in the /fake dir though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85998/new/ https://reviews.llvm.org/D85998 ___ cfe-commits mai

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

hans added inline comments. Comment at: clang/test/SemaCXX/ms_dynamic_cast.cpp:16 +B *b = new D1(); +auto d = dynamic_cast(b); // expected-warning{{should not use dynamic_cast with /GR-}} +} zequanwu wrote: > lebedev.ri wrote: > > I'm not sure it makes s

[PATCH] D86065: [SVE] Make ElementCount members private

david-arm updated this revision to Diff 287672. david-arm added a comment. Herald added a subscriber: rogfer01. - Changed comparison function from gt to ogt and added a olt (less than) comparison function too. - Instead of adding the ">>=" operator I've added "/=" instead as I think this is more

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen marked 3 inline comments as done. zahen added inline comments. Comment at: clang/test/Driver/cl-options.c:686 +// vctoolsdir is handled by the driver; just check that we don't error. Pass -c because fakedir isn't a real toolchain path +// RUN: %clang_cl -c -vctoolsdir fake

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen updated this revision to Diff 287671. zahen added a comment. Herald added a subscriber: ormris. It felt too invasive to swap the precedence of using vctoolsdir vs %INCLUDE% for all clang-cl users so I compromised by skipping the %INCLUDE% check when vctoolsdir was passed on the command lin

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan added a comment. In D85324#2234712 , @hubert.reinterpretcast wrote: > In D85324#2233290 , > @abhina.sreeskantharajan wrote: > >> Thanks Hubert, I fixed the comment. > > Got it; I'll look in

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov updated this revision to Diff 287669. ASDenysPetrov added a comment. Added recursive_mutex support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85984/new/ https://reviews.llvm.org/D85984 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/Static

[PATCH] D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__

steakhal added a comment. I'm not sure about the //status// of this patch. If you say that further improvements will be done later and this functionality is enough, I'm fine with that. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:901 + + void next(Token &Res

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

hans added a comment. Lucas, this seems to have casued https://bugs.llvm.org/show_bug.cgi?id=47001. Can you take a look? (I would cc you on the bug, but I couldn't find your email in bugzilla.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/n

  1   2   >