[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

NoQ added a comment. Ok, here's the crashing example with `ObjCForCollectionStmt`. It should be saved as an `.mm` file and it crashes under pure `--analyze`. @interface Item // ... @end @interface Collection // ... @end typedef void (^Blk)(); struct RAII { Blk blk;

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert updated this revision to Diff 280327. jdoerfert added a comment. minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/B

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea updated this revision to Diff 280326. asbirlea added a comment. The increase in number of instructions and cycles was caused by reversing the order in which the updates are applied by GraphDiff. I'll look into re-adding some of the original cleanups in a follow-up patch. Repository:

[clang] 70e7aa4 - [AST][FPEnv] Keep FP options in trailing storage of CallExpr

Author: Serge Pavlov Date: 2020-07-24T12:04:19+07:00 New Revision: 70e7aa4a4ed36a034c43b249d0842f4f273b44e1 URL: https://github.com/llvm/llvm-project/commit/70e7aa4a4ed36a034c43b249d0842f4f273b44e1 DIFF: https://github.com/llvm/llvm-project/commit/70e7aa4a4ed36a034c43b249d0842f4f273b44e1.diff

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG70e7aa4a4ed3: [AST][FPEnv] Keep FP options in trailing storage of CallExpr (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84343/new/

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

NoQ added a comment. In D84316#2168730 , @steakhal wrote: > In D84316#2168462 , @NoQ wrote: > > > Such separation also looks amazing because ultimately the first part can be > > made checker-inspecific (i.e., a reu

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

NoQ added a comment. In D84316#2168730 , @steakhal wrote: > I wanted to have a separate class for bookkeeping while minimalizing the > necessary changes. > What do you think would be the best way to organize this separation? > > Few notes: > > - Checkers

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2170821 , @tra wrote: > In D80858#2170781 , @hliao wrote: > > > The problem is not whether we have solution to tell them but when we need > > to add that. Not all `static` device va

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

vitalybuka added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; isn't better just create new set of callbacks? e.

[PATCH] D84482: [Fuchsia] Use -z dead-reloc-in-nonalloc=*=0 for Fuchsia targets

mcgrathr created this revision. mcgrathr added reviewers: phosek, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84482 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp Index: clang/lib/Driver/T

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

kcc added a comment. Yep, cool. LGTM from me, but please get another pair if eyes (Vitaly?) Comment at: clang/docs/DataFlowSanitizer.rst:182 +less CPU and code size overhead. To use fast16labels instrumentation, you'll +need to specify `-fsanitize=dataflow -mllvm -fast-16-labe

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 280305. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/CMakeLists.txt

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

morehouse updated this revision to Diff 280304. morehouse added a comment. - Fix libfuzzer dataflow tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84371/new/ https://reviews.llvm.org/D84371 Files: clang/docs/DataFlowSanitizer.rst compile

[PATCH] D83972: Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

shafik updated this revision to Diff 280291. shafik added a comment. Updating diff since the parent landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83972/new/ https://reviews.llvm.org/D83972 Files: clang/lib/AST/ASTImporter.cpp lldb/test/API/lang/objc/bitfield_ivars/TestBitfi

[PATCH] D84476: Make hip math headers easier to use from C

JonChesterfield created this revision. JonChesterfield added a reviewer: yaxunl. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Make hip math headers easier to use from C Motivation is a step towards using the hip math headers t

[PATCH] D84473: Dump Accumulator

mtrofin added inline comments. Comment at: llvm/include/llvm/Analysis/DumpAccumulator.h:43 +// +// Note that ThinLTO is not supported yet. +// I'd clarify that transferring the data from pre-link thinlto to post-link isn't supported, but one could use this in po

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

morehouse added a subscriber: Dor1s. morehouse added a comment. In D84371#2168367 , @kcc wrote: > In what cases do we still call __dfsan_union? We still call `__dfsan_union_load` when we load sizes greater than 2 bytes but not divisible by 4. I actuall

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

morehouse updated this revision to Diff 280286. morehouse marked 6 inline comments as done. morehouse added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add documentation. - Remove fast16labels runtime flag. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D84473: Dump Accumulator

kazu created this revision. kazu added reviewers: davidxl, mtrofin, wmi. kazu added a project: LLVM. Herald added subscribers: cfe-commits, rupprecht, MaskRay, hiraditya, mgorny. Herald added a reviewer: jhenderson. Herald added a project: clang. This patch adds a utility called DumpAccumulator.

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:973 + if ((LexLevel == 0 || PreprocessToken) && + !Result.getFlag(Token::IsReinjected)) { +if (LexLevel == 0) @hans , can you take a lo

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu updated this revision to Diff 280283. zequanwu edited the summary of this revision. zequanwu added a comment. In `Preprocessor.cpp`, don't increment `TokenCount` if `LexLevel == 0`. I tests this with chromium crypto_unittests. It doesn't track comments regions. I don't why when using th

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs added a comment. In D83494#2170838 , @dmajor wrote: > After this commit, several of our builds are failing with > `FuzzerInterceptors.cpp:30:10: fatal error: > 'sanitizer/common_interface_defs.h' file not found`. This is odd because the > file

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. Can you check if https://reviews.llvm.org/D84470 fixes the problem as this test doesn't work on my machine? If yes, please accept and upstream it since I don't have the permission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:152 + Align, Name, + /*ArraySize=*/nullptr, Alloca); c-rhodes wrote: > efriedma wrote: > > Do we need to bitcast the result of CreateTempAlloca to a pointer to the > > array typ

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dmajor added a comment. After this commit, several of our builds are failing with `FuzzerInterceptors.cpp:30:10: fatal error: 'sanitizer/common_interface_defs.h' file not found`. This is odd because the file certainly seems like it exists. Is there a missing include path somewhere, perhaps? R

[clang] 38c71b7 - Revert "[CMake] Simplify CMake handling for zlib"

Author: Petr Hosek Date: 2020-07-23T15:12:42-07:00 New Revision: 38c71b7c85cac4c8de39329ff3ed682e63f61525 URL: https://github.com/llvm/llvm-project/commit/38c71b7c85cac4c8de39329ff3ed682e63f61525 DIFF: https://github.com/llvm/llvm-project/commit/38c71b7c85cac4c8de39329ff3ed682e63f61525.diff LO

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

tra added a comment. In D80858#2170781 , @hliao wrote: > The problem is not whether we have solution to tell them but when we need to > add that. Not all `static` device variables need to be visible to the host > side. `Externalizing` them adds the overh

[PATCH] D82999: [CodeGen] Check the cleanup flag before destructing lifetime-extended temporaries created in conditional expressions

rjmccall added a comment. I agree, that can be done separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82999/new/ https://reviews.llvm.org/D82999 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D83325: [Sema] Be more thorough when unpacking the AS-qualified pointee for a pointer conversion.

rjmccall added a comment. `removeAddrSpaceQualType` should guarantee that it removes the address space qualifier; you shouldn't need to do something special here. That means it needs to iteratively desugar and collect qualifiers as long as the type is still address-space-qualified. Repositor

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d09ecf36175: [CMake] Simplify CMake handling for zlib (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.o

[clang] 1d09ecf - [CMake] Simplify CMake handling for zlib

Author: Petr Hosek Date: 2020-07-23T14:47:25-07:00 New Revision: 1d09ecf36175f7910ffedd6d497c07b5c74c22fb URL: https://github.com/llvm/llvm-project/commit/1d09ecf36175f7910ffedd6d497c07b5c74c22fb DIFF: https://github.com/llvm/llvm-project/commit/1d09ecf36175f7910ffedd6d497c07b5c74c22fb.diff LO

[PATCH] D84343: [AST] Keep FP options in trailing storage of CallExpr

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84343/new/ https://reviews.llvm.org/D84343 __

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2170668 , @tra wrote: > In D80858#2170604 , @hliao wrote: > > > In D80858#2170547 , @tra wrote: > > > > > Would it work if we generate a glob

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 280261. aelitashen added a comment. Fix run_test to cover every system case and attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

tra added a comment. In D84364#2170244 , @tra wrote: > I'm going to try the patch on our CUDA code and see how it fares. Stay tuned. The patch works well enough to build TensorFlow which is a good sign that existing working code should be OK -- we're ma

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGa41af6e41e6f: [clang] Fix libdl linking for libclang in standalone mode (authored by thieta, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] a41af6e - [clang] Fix libdl linking for libclang in standalone mode

Author: Tobias Hieta Date: 2020-07-24T00:10:22+03:00 New Revision: a41af6e41e6fcf3e7030feaf24057cbe8291b748 URL: https://github.com/llvm/llvm-project/commit/a41af6e41e6fcf3e7030feaf24057cbe8291b748 DIFF: https://github.com/llvm/llvm-project/commit/a41af6e41e6fcf3e7030feaf24057cbe8291b748.diff

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau updated this revision to Diff 280254. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGe

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

RaviNarayanaswamy added a comment. In D84422#2170667 , @grokos wrote: > So is the test case that motivated this patch illegal OpenMP code? > > #pragma omp target enter data map(alloc:i) > #pragma omp target data map(present, alloc: i) > { > #prag

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

tra added a comment. In D80858#2170604 , @hliao wrote: > In D80858#2170547 , @tra wrote: > > > Would it work if we generate a globally unique visible aliases for the > > static vars and use the alias' name to regis

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

grokos added a comment. So is the test case that motivated this patch illegal OpenMP code? #pragma omp target enter data map(alloc:i) #pragma omp target data map(present, alloc: i) { #pragma omp target exit data map(delete:i) } // fails presence check here Repository: rG LLVM Gith

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

RaviNarayanaswamy added a comment. In D84422#2170285 , @grokos wrote: > What confuses me about this interpretation of the standard is the > inconsistency at `data exit`. So if we have an explicit `omp target exit data > map(present...)` then we should re

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rsmith added a comment. These new builtins should ideally support constant evaluation if possible. Comment at: clang/docs/LanguageExtensions.rst:2439-2440 +Clang provides versions of the following functions which are overloaded based on +the pointer parameter types: + --

[PATCH] D84461: [Concepts] Fix ast dump for immediately declared constraint.

hokein created this revision. hokein added a reviewer: rsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84461 Files: clang/lib/AST/TextNodeDumper.cpp clang/test/AST/ast-dump-concepts.cpp Index: clang/test/AST/ast-dump-concepts.cpp =

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2170547 , @tra wrote: > Would it work if we generate a globally unique visible aliases for the static > vars and use the alias' name to register device-side entities without > changing their visibility? We still need to

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2170533 , @yaxunl wrote: > In D80858#2170328 , @hliao wrote: > > > In D80858#2169534 , @yaxunl wrote: > > > > > Another reason is that we nee

[PATCH] D84409: [libTooling] Add an `EditGenerator` that applies a rule throughout a bound node.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:337 +// refer to nodes bound by the calling rule. `Rule` is not applied to the node +// itself.

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

tra added a comment. Would it work if we generate a globally unique visible aliases for the static vars and use the alias' name to register device-side entities without changing their visibility? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80858/new/ https://reviews.llvm.org/D80858

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny added a comment. I don't know if the OpenMP committee has any documented rationale for this behavior. I can say that the OpenACC committee is considering the same semantics. However, the issues to consider are not identical. For example, OpenACC has a separate structured reference cou

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

yaxunl added a comment. In D80858#2170328 , @hliao wrote: > In D80858#2169534 , @yaxunl wrote: > > > Another reason is that we need to support it in rdc mode, where different > > TU can have static var with the sam

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai marked 3 inline comments as done. vsapsai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:700 + "no module named '%0' %select{found|in '%2'}1, " + "expected parent module to be defined before the submodule">; def err_mmap_top_level_in

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

xazax.hun added a comment. In D82598#2164363 , @Szelethus wrote: > Actually, what I said initially is true: > > > [...] the only non-expression statements it **queried** are > > ObjCForCollectionStmts [...] Btw, sorry. I somehow misunderstood the snippe

[PATCH] D84458: [Modules] Improve error message when cannot find parent module for submodule definition.

vsapsai created this revision. vsapsai added reviewers: rsmith, bruno, Bigcheese. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. Before the change the diagnostic for module unknown.submodule {} was "error: expected module name" which is incorrect and mi

[PATCH] D83909: [OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop counters.

ABataev updated this revision to Diff 280231. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83909/new/ https://reviews.llvm.org/D83909 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/taskloop_codegen.cpp

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/shadowcallstack.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv32-unknown-elf -mattr=+reserve-x18 -verify-machineinstrs < %s \ +; RUN: | FileCheck %s

[PATCH] D84341: Implement __builtin_eh_return_data_regno for SystemZ

slavek-kucera added a comment. I addressed the code formatting. As I don't have commit access, could you commit the change for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84341/new/ https://reviews.llvm.org/D84341 ___ cfe-commits mai

[PATCH] D84414: [RISCV] Support Shadow Call Stack

pcc added a comment. > Any callee-saved register can be used. In fact, any register may be used, as long as it cannot be used to pass arguments or return values. It may be better to select a temporary register, as `x18` is on aarch64 when not being used as a platform register, so that problems

[PATCH] D84414: [RISCV] Support Shadow Call Stack

pcc added inline comments. Comment at: llvm/test/CodeGen/RISCV/shadowcallstack.ll:12 +; RV32-NEXT:ret +; RV32-NOT: x18 +; Shouldn't it be looking for `s2` since that's how `x18` is spelled in assembly? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D84455: [Concepts] Fix a deserialization crash.

hokein added a comment. btw, `getTypeConstraint` and `hasTypeConstraint` APIs are quite easy to be misused (there is another similar bug in getAssociatedConstraints ), I think we need to refine

[PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +active_modules = self.vscode.get_active_modules() +program_module = active_modules[program_basename] +self.assertEqual(program_basena

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. In untied tasks, need to allocate the space for local variales, declared in task region, when the memory for task data is allocated. THe function

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

yaxunl added a comment. In D80858#2170311 , @hliao wrote: > > The problem is that even though the static variable is registered through > > `__hipRigisterVariable`, the runtime still relies on looking up symbol name > > to get the address of the device v

[PATCH] D84414: [RISCV] Support Shadow Call Stack

MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:33-37 + std::vector &CSI = MF.getFrameInfo().getCalleeSavedInfo(); + if (std::none_of(CSI.begin(), CSI.end(), [](CalleeSavedInfo &CSR) { +return CSR.getReg() == RISCV::X1; + }))

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen marked an inline comment as done. aelitashen added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +active_modules = self.vscode.get_active_modules() +program_module = active_modules[program_basenam

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. 1. Please use local variables with meaningful names for `RISCV::Xn` rather than inlining them everywhere and making it harder at a glance to work out what's going on without knowing

[PATCH] D84455: [Concepts] Fix a deserialization crash.

hokein created this revision. hokein added a reviewer: rsmith. Herald added a subscriber: kristof.beyls. Herald added a project: clang. `TemplateTypeParmDecl::hasTypeConstraint` is not a safe guard for checking `TemplateTypeParmDecl::getTypeConstraint()` result is null. in somecases (e.g. implici

[PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP support

hfinkel added a comment. Thanks for working on this. Please, however, take another pass of the test cases (especially those that are not in the PowerPC directory). Many of those should not be deleted, please change triple instead. They're testing general functionality. Comm

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280216. eduucaldas added a comment. Update API to new nested-name-specifier grammar rule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.org/D84348 Files: clang/include/clang

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. LGTM, thanks for taking care of this! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84453/new/ https://reviews.llvm.org/D84453 ___

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:95 + .addReg(RISCV::X18) + .addImm(0); +} apazos wrote: > There are thee things to observe here and other reviewers might have some > additional comments: > > - RIS

[PATCH] D84414: [RISCV] Support Shadow Call Stack

zzheng updated this revision to Diff 280210. zzheng marked 3 inline comments as done. zzheng edited the summary of this revision. zzheng added a comment. Using 'BLOCKED' now. clang-formated RISCVFrameLowering.cpp updated style of test/CodeGen/RISCV/shadowcallstack.ll Repository: rG LLVM Gith

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2169534 , @yaxunl wrote: > Another reason is that we need to support it in rdc mode, where different TU > can have static var with the same name. That's an issue of our current RDC support through LLVM IR instead of nati

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

NoQ created this revision. NoQ added reviewers: alexfh, gribozavr, dcoughlin, delcypher, yln, kubamracek, vsavchenko. Herald added subscribers: martong, mgehre, Charusso, xazax.hun. It's failing on macOS under AddressSanitizer for no obvious reason - i.e., no report is produced, just the code is

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

hliao added a comment. In D80858#2169399 , @yaxunl wrote: > In D80858#2169295 , @hliao wrote: > > > I don't that's proper way to support file-scope static device variables. As > > we discuss APIs like cudaMemcpyToS

[PATCH] D84356: [AIX] remove -u from the clang when invoke aix as assembler

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84356/new/ https://reviews.llvm.org/D84356 __

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

grokos added a comment. What confuses me about this interpretation of the standard is the inconsistency at `data exit`. So if we have an explicit `omp target exit data map(present...)` then we should respect the "present" semantics, whereas when we have a scoped data exit: #pragma omp target

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. >>> Do you think it'd be useful to have different guarantees for different >>> operands? I guess it could come up, but it'd be a whole lot of extra >>> complexity that I can't imagine we'd ever support. >> >> You mean, if `element_size` is passed then you get different gua

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. In D79279#2170187 , @jfb wrote: > In D79279#2170157 , @rjmccall wrote: > > > I think the argument is treated as if it were 1 if not given. That's all > > that ordinary memcpy formally gua

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

tra added a comment. I'm going to try the patch on our CUDA code and see how it fares. Stay tuned. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84364/new/ https://reviews.llvm.org/D84364 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

Szelethus added a comment. You could do it in the code, but if the modeling wouldn't be present from CStringModeling, CStringChecker wouldn't work properly. So you should make it a strong dependency, just as you did in this patch. My comment was mainly a response to @NoQ :)

LLVM buildmaster is back to normal work

Hello everyone, LLVM buildmaster is back to normal work, sorry for inconvenience. Last night updates caused some distortions unfortunately. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. In D79279#2170157 , @rjmccall wrote: > I think the argument is treated as if it were 1 if not given. That's all > that ordinary memcpy formally guarantees, which seems to work fine > (semantically, if not performance-wise) for prett

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar added a comment. In D84405#2170110 , @vsk wrote: > How were you able to show that the specialized IRGen is equivalent to the > generic kind? I tried doing this with direct inspection > (https://godbolt.org/z/o5WEn3), but wasn't able to convince

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal marked 4 inline comments as done. steakhal added a comment. In D84316#2169195 , @Szelethus wrote: > [...] you really cant make CStringChecker work without CStringModeling How should I fuse the `CStringModeling` and the `CStringChecker` together

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. I think the argument is treated as if it were 1 if not given. That's all that ordinary memcpy formally guarantees, which seems to work fine (semantically, if not performance-wise) for pretty much everything today. I don't think you need any restrictions on element si

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. In D79279#2170095 , @rjmccall wrote: > I don't think any of these should allow _Atomic unless we're going to give it > some sort of consistent atomic semantics (which is hard to imagine being > useful), and I think you should just ta

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

vsk added a comment. How were you able to show that the specialized IRGen is equivalent to the generic kind? I tried doing this with direct inspection (https://godbolt.org/z/o5WEn3), but wasn't able to convince myself. In the past I used a test driver to compare the before/after compiler output

[PATCH] D84029: [clang][Driver] Default to /usr/bin/ld on Solaris

MaskRay added a comment. Can you add a test to `test/Driver/solaris-ld.c`? > However, if someone forgets this, it depends on the user's PATH whether or > not clang finds the correct linker, which doesn't make for a good user > experience. Not very sure about this. The last resort of GetProgram

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. I don't think any of these should allow _Atomic unless we're going to give it some sort of consistent atomic semantics (which is hard to imagine being useful), and I think you should just take an extra argument of the minimum access width on all of them uniformly if yo

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

chill accepted this revision. chill added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 ___ cfe-commits mailing list cfe-co

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. > My point is that this has nothing to do with the ordinary semantics of > `_Atomic`. You're basically just looking at the word "atomic" and saying > that, hey, a minimum access size is sortof related to atomicity. > > If you want this to be able to control the minimum acc

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

c-rhodes marked an inline comment as done. c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:152 + Align, Name, + /*ArraySize=*/nullptr, Alloca); efriedma wrote: > Do we need to bitcast the result of CreateTempAlloca to a pointe

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. In D79279#2169522 , @jfb wrote: > In D79279#2168649 , @rjmccall wrote: > > > In D79279#2168533 , @jfb wrote: > > > > > In D79279#2168479

[PATCH] D84310: [libTooling] Add assorted `EditGenerator` combinators.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:125 +/// not bound, then no edits are produced. +inline EditGenerator ifBound(std::string ID, ASTEdit TrueEdit) { + return ifBound(std::move

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

arsenm added a comment. In D79744#2165929 , @rjmccall wrote: > Arguably we should add this attribute to all indirect arguments. I can > understand not wanting to update all the test cases, but you could probably > avoid adding a new IndirectByRef kind o

[PATCH] D84310: [libTooling] Add assorted `EditGenerator` combinators.

asoffer accepted this revision. asoffer added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:125 +/// not bound, then no edits are produced. +inline EditGenerator ifBound(std::string ID, ASTEdit

[PATCH] D83997: [os_log] Improve the way we extend the lifetime of objects passed to __builtin_os_log_format

ahatanak added a comment. The use case for this is a macro in which the call to `__builtin_os_log_format` that writes to the buffer and the call that uses the buffer appear in two different statements. For example: __builtin_os_log_format(buf, "%@", getObj()); ... use_buffer(buf); The ob

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny created this revision. jdenny added reviewers: grokos, ABataev, jdoerfert. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1, guansong, yaxunl. Herald added projects: clang, OpenMP, LLVM. Without this patch, the following example fails but shouldn't according to

[PATCH] D84414: [RISCV] Support Shadow Call Stack

apazos added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:95 + .addReg(RISCV::X18) + .addImm(0); +} There are thee things to observe here and other reviewers might have some additional comments: - RISC-V does not have a re

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

This revision was automatically updated to reflect the committed changes. dokyungs marked an inline comment as done. Closed by commit rG831ae45e3dc6: Recommit "[libFuzzer] Link libFuzzer's own interceptors when other compiler… (authored by dokyungs). Repository: rG LLVM Github Monorepo CHANGES

  1   2   >