[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 267124. michele.scandale added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fixup more tests with now redundant `-ffp-contract=fast` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 267125. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

pdhaliwal updated this revision to Diff 267123. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79400/new/ https://reviews.llvm.org/D79400 Files: llvm/cmake/modules/AddLLVM.cmake llvm/include/llvm/Support/CMakeLists.txt Index: llvm/include/llvm/

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 267122. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 267121. michele.scandale added a comment. Rebase + `-ffast-math` change the default contraction mode to fast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 F

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale added a comment. In D80315#2061164 , @rjmccall wrote: > In D80315#2059160 , > @michele.scandale wrote: > > > In D80315#2058914 , @rjmccall > > wrote: > > >

[PATCH] D80770: [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, Volodymyr! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80770/new/ https://reviews.llvm.org/D80770 _

[PATCH] D80723: [PowerPC] Convert vec_splats functions to macros

steven.zhang added inline comments. Comment at: clang/lib/Headers/altivec.h:13670 + ) +#elif defined(__VSX__) +#define vec_splats(N) \ vddvss wrote: > steven.zhang wrote: > > I am not sure if this is by intention. It is not se

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5369 if (ES->hasExternalDefinitions(D) == ExternalASTSource::EK_Never) - DebugInfo->completeUnusedClass(cast(*D)); + DebugInfo->completeUnusedClass(*CRD); } ---

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

MaskRay added a comment. @theraven Are you ok with this change? You seem to have a use case not using ld.bfd, ld.gold or ld.lld . This change will require you to adapt. In D80225#2049466 , @jyknight wrote: > It's worrying to me that there number of place

[PATCH] D80771: [MTE] Convert StackSafety into analysisThis lets us to remove !stack-safe metadata andbetter controll when to perform StackSafetyanalysis.

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80771 Files: clang/lib/CodeGen/Bac

[PATCH] D80770: [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON.

vsapsai created this revision. vsapsai added reviewers: JDevlieghere, steven_wu. Herald added subscribers: ributzka, dexonsmith, jkorous, mgorny. Herald added a project: clang. Not sure about other platforms but `install-xcode-toolchain` was already including diagtool in the toolchain. This change

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

nagart added a comment. @leonardchan Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80412/new/ https://reviews.llvm.org/D80412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 added a comment. In D80222#2061810 , @jdoerfert wrote: > LGTM. Thanks for taking this one, it was more complex than I thought but it > is a really nice step in the right direction. I'll commit it for you soon if > you don't have access yet. Feel

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG1285e8bcac2c: Run Coverage pass before other *San passes under new pass manager, round 2 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 1285e8b - Run Coverage pass before other *San passes under new pass manager, round 2

Author: Arthur Eubanks Date: 2020-05-28T17:04:47-07:00 New Revision: 1285e8bcac2c54ddd924ffb813b2b187467ac2a6 URL: https://github.com/llvm/llvm-project/commit/1285e8bcac2c54ddd924ffb813b2b187467ac2a6 DIFF: https://github.com/llvm/llvm-project/commit/1285e8bcac2c54ddd924ffb813b2b187467ac2a6.diff

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks updated this revision to Diff 267087. aeubanks added a comment. Update some CHECKs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80692/new/ https://reviews.llvm.org/D80692 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/sa

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith added a comment. The new test failure appears unrelated to my changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 ___ cfe-commits mailing list cfe-com

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for taking this one, it was more complex than I thought but it is a really nice step in the right direction. I'll commit it for you soon if you don't have access yet. Feel f

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

leonardchan accepted this revision. leonardchan added a comment. In D80692#2061739 , @aeubanks wrote: > I foolishly submitted without running check-all, and it turns out this broke > a test under check-clang. > Looks like https://reviews.llvm.org/D62888

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks updated this revision to Diff 267073. aeubanks added a comment. I foolishly submitted without running check-all, and it turns out this broke a test under check-clang. Looks like https://reviews.llvm.org/D62888 added tests in sancov-new-pm.c to make sure that sancov + LTO work together,

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith added a comment. Thanks I moved them to the bottom and I believe I fixed them on windows! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 ___ cfe-commits

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith updated this revision to Diff 267069. keith added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/fuse-ld.c Index:

[clang] 0dfb43d - Fix handling of default arguments in __attribute__((enable_if)).

Author: Richard Smith Date: 2020-05-28T15:35:22-07:00 New Revision: 0dfb43deb6d5511a8ea69eeb7373a212ebd6c9c1 URL: https://github.com/llvm/llvm-project/commit/0dfb43deb6d5511a8ea69eeb7373a212ebd6c9c1 DIFF: https://github.com/llvm/llvm-project/commit/0dfb43deb6d5511a8ea69eeb7373a212ebd6c9c1.diff

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn updated this revision to Diff 267061. fhahn marked 7 inline comments as done. fhahn added a comment. Updated tests to use more targeted checks, fix typo and rebased on top of master (so this change can be applied before D76791 . Repository: rG LLVM Gith

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:12112 +return InvalidOperands(Loc, OriginalLHS, OriginalRHS); + } + rjmccall wrote: > You need to not actually apply this conversion to the LHS if this is a > compound assignment. You can

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267058. Daniel599 marked an inline comment as not done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/Cl

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked 4 inline comments as done. Daniel599 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/duplicate-fixes-of-alias-checkers.cpp:3 + +#include +namespace std { Eugene.Zelenko wrote: > cstdio. Please also separate w

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 267057. zequanwu added a comment. Don't mangle `ParmVarDecl`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/CodeGenCXX/mangle-ms-cxx17.cpp Index:

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 updated this revision to Diff 267056. Daniel599 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tools-extra/clang-tidy/ClangT

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80757/new/ https://reviews.llvm.org/D80757 ___ cfe-commits mailing list cfe-commi

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 added a comment. No worries. Mateusz Mikuła CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

njames93 added a comment. It may be worth verifying that the fix-its are identical too, multiple versions of a check could be running with differing options resulting in different fix-its generated, in that case we should let clang-tidy disable any conflicting fixes for us. Side note would it n

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. First of all, very nice idea. :) Second, could you please make sure that the script is compatible with Python 3? Also, in order to clean up a bit the generation of the RST (to avoi

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG922fa2fce38b: Run Coverage pass before other *San passes under new pass manager, round 2 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM now - thanks! What's your preferred git author line for this project? I can probably push it tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://revie

[clang] e3fb844 - Revert "Run Coverage pass before other *San passes under new pass manager, round 2"

Author: Arthur Eubanks Date: 2020-05-28T14:38:05-07:00 New Revision: e3fb8446f2ec3953348f3c773004cf2aa28a8c04 URL: https://github.com/llvm/llvm-project/commit/e3fb8446f2ec3953348f3c773004cf2aa28a8c04 DIFF: https://github.com/llvm/llvm-project/commit/e3fb8446f2ec3953348f3c773004cf2aa28a8c04.diff

[clang] 922fa2f - Run Coverage pass before other *San passes under new pass manager, round 2

Author: Arthur Eubanks Date: 2020-05-28T14:25:23-07:00 New Revision: 922fa2fce38b0bd97921b91ff1cdc57f18d3569c URL: https://github.com/llvm/llvm-project/commit/922fa2fce38b0bd97921b91ff1cdc57f18d3569c DIFF: https://github.com/llvm/llvm-project/commit/922fa2fce38b0bd97921b91ff1cdc57f18d3569c.diff

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

saghir accepted this revision. saghir added a comment. This revision is now accepted and ready to land. Other than the nit, this looks good to me. Comment at: clang/test/Driver/ppc-pcrel.cpp:1 +// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel -o %

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 updated this revision to Diff 267036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/compiler-rt-unwind.c Index: clang/test/Driver/compiler-rt-unwind.c

[PATCH] D79995: [clang] [MinGW] Fix libunwind extension

mati865 updated this revision to Diff 267034. mati865 added a comment. Added test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79995/new/ https://reviews.llvm.org/D79995 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/compiler-rt-unwind.c Index: clang/test/D

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

This revision was automatically updated to reflect the committed changes. nemanjai marked an inline comment as done. Closed by commit rG9021ce9576e4: [Clang] Enable KF and KC mode for [_Complex] __float128 (authored by nemanjai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/support/Threading.h:134 +// Memoize is a cache to store and reuse computation results based on a key. +// nit:

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu updated this revision to Diff 267027. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80574/new/ https://reviews.llvm.org/D80574 Files: clang/docs/LanguageExtensions.rst clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Sema/ext_vector_comparisons.c I

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:750 + for (auto &Error : Errors) { +auto Inserted = UniqueErrors.insert(&Error); + Please don't use auto when type is not spelled in same statement

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

saghir created this revision. saghir added reviewers: hfinkel, nemanjai, lei, power-llvm-team, amyk. saghir added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, shchenz, hiraditya. jsji added a reviewer: PowerPC. jsji added a project: PowerPC. This patch adds command l

[clang] 9021ce9 - [Clang] Enable KF and KC mode for [_Complex] __float128

Author: Nemanja Ivanovic Date: 2020-05-28T15:48:15-05:00 New Revision: 9021ce9576e438ae5a6fdb574327d30ea6b67fa8 URL: https://github.com/llvm/llvm-project/commit/9021ce9576e438ae5a6fdb574327d30ea6b67fa8 DIFF: https://github.com/llvm/llvm-project/commit/9021ce9576e438ae5a6fdb574327d30ea6b67fa8.di

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

lei created this revision. lei added reviewers: stefanp, nemanjai, hfinkel, power-llvm-team. Herald added subscribers: shchenz, wuzish. Herald added a project: clang. Add user-facing front end option to turn off pc-relative memops. This will be compatible with gcc. Repository: rG LLVM Github M

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu marked 2 inline comments as done. myhsu added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7484 + // Only ext vector is allowed + if (const auto *VecCondTy = Cond->getType()->getAs()) { +QualType EleTy = VecCondTy->getElementType(); Anasta

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu updated this revision to Diff 267024. myhsu added a comment. Fix document section CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80574/new/ https://reviews.llvm.org/D80574 Files: clang/docs/LanguageExtensions.rst clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems ok to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79117/new/ https://reviews.llvm.org/D79117 ___

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk updated this revision to Diff 267021. kwk marked 9 inline comments as done. kwk added a comment. - Don't store SourceManager but get it from Preprocessor - Use getName instead of getNameStart - Remove FIXME - change warning message - doxygen: \a -> \p - Make MacroName private and add getter

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

ABataev added a comment. Investigated the bug. Seems to me, the bug is not related to OpenMP. The following code crashes the compiler too: struct FOO { static const int vec_align_bytes = 32; void foo() { alignas(vec_align_bytes) double a; ; } }; Seems to

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added a comment. @njames93 I've addressed all your comments and hope the patch is good to land now :) Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.cpp:25 + const SourceManager &SM) + : Check(Check), PP(PP), SM(SM) {}

[PATCH] D80712: [SVE] Add checks for no warnings in SVE tests

efriedma added a comment. I guess we could do this as a temporary measure, if you think it's useful; eventually, of course, the codepath to print the warning will go away. Since you checked this, how many tests do still print warnings? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks added a comment. In D80692#2061219 , @leonardchan wrote: > Would be worthwhile to write a small test that asserts Sancov runs before the > other sanitizers under the new PM? > > Aside from this, LGTM. Asserting that sancov runs before other san

[PATCH] D77942: [Preamble] Invalidate preamble when missing headers become present.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Let's build more preambles ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77942/new/ https://reviews.llvm.org/D77942 _

[clang] 2f430f7 - [StackSafety] Remove SetMetadata parameter

Author: Vitaly Buka Date: 2020-05-28T13:32:57-07:00 New Revision: 2f430f7a51693c9d5c648179f2341b541be44000 URL: https://github.com/llvm/llvm-project/commit/2f430f7a51693c9d5c648179f2341b541be44000 DIFF: https://github.com/llvm/llvm-project/commit/2f430f7a51693c9d5c648179f2341b541be44000.diff L

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

echristo added a comment. First question: Since split dwarf has to do some similar things can we not use the same support? This seems to be a lot of changes for this. Second question: and if we can't use the same support can we make split dwarf use this? Having two separate methods for passin

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

aganea updated this revision to Diff 266989. aganea added a comment. Herald added subscribers: cfe-commits, steven_wu, aheejin, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a project: clang. I'm taking over this patch, as discussed offline with Zachary. I've re-i

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo closed this revision. oontvoo added a comment. Thanks, all! Committed https://github.com/llvm/llvm-project/commit/51401a676c036f2bd4e6b4b38f3538615799de40 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D8

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 267008. oontvoo added a comment. Move matcher to near forEachArgumentWithParam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: clang/docs/LibASTMatchersReferen

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau updated this revision to Diff 267002. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80323/new/ https://reviews.llvm.org/D80323 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGExpr.cpp clan

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Would be worthwhile to write a small test that asserts Sancov runs before the other sanitizers under the new PM? Aside from this, LGTM. Comment at: llvm/include/l

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo added a comment. In D80603#2061131 , @aaron.ballman wrote: > In D80603#2059122 , @gribozavr2 > wrote: > > > In D80603#2058019 , @aaron.ballman > > wrote: > > > > >

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

oontvoo updated this revision to Diff 266999. oontvoo added a comment. Updated Registry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 Files: clang/docs/LibASTMatchersReference.html clang/include/clang

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

gribozavr2 added a comment. > Also, you need to update Registry.cpp to add this to the list of dynamic > matchers. Good point. @oontvoo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 __

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall added a comment. In D80315#2059160 , @michele.scandale wrote: > In D80315#2058914 , @rjmccall wrote: > > > In D80315#2058735 , > > @michele.scandale wrote: > > > >

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

gribozavr2 added a comment. > Is there a reason we want to support blocks but not lambdas? Lambdas are supported (see tests). Lambdas generate classes with regular function decls, so there's no surprise there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 51401a6 - add isAtPosition narrowing matcher for parmVarDecl

Author: Vy Nguyen Date: 2020-05-28T16:04:41-04:00 New Revision: 51401a676c036f2bd4e6b4b38f3538615799de40 URL: https://github.com/llvm/llvm-project/commit/51401a676c036f2bd4e6b4b38f3538615799de40 DIFF: https://github.com/llvm/llvm-project/commit/51401a676c036f2bd4e6b4b38f3538615799de40.diff LOG

[PATCH] D80731: Improve test infrastructure in SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rGeca41919d28b: Improve test infrastructure in SyntaxTree (authored by eduucaldas, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D80731?vs=266898&id=266993#toc Repository:

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

aaron.ballman added a comment. In D80603#2059122 , @gribozavr2 wrote: > In D80603#2058019 , @aaron.ballman > wrote: > > > I'm sorry if I'm being dense, but `hasParameter` traverses to the > > `ParmVarDecl`, so I'

[clang] eca4191 - Improve test infrastructure in SyntaxTree

Author: Eduardo Caldas Date: 2020-05-28T21:35:12+02:00 New Revision: eca41919d28b0616140a63c6a97483098ec1ffee URL: https://github.com/llvm/llvm-project/commit/eca41919d28b0616140a63c6a97483098ec1ffee DIFF: https://github.com/llvm/llvm-project/commit/eca41919d28b0616140a63c6a97483098ec1ffee.diff

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77836/new/ https://reviews.llvm.org/D77836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks marked 2 inline comments as done. aeubanks added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:597-598 /// /// This extension point allows adding optimizations at the very end of the /// function optimization pipeline. A key difference betw

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

dblaikie added inline comments. Comment at: clang/test/Modules/ModuleDebugInfo.m:46-47 -// The forward declaration should not be in the module scope. -// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "OpaqueData", file - Did this type go missing wit

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 created this revision. Daniel599 added reviewers: alexfh, hokein. Daniel599 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, Charusso, xazax.hun. Herald added a project: clang. when both a check and its alias are enabled, we should only take the fixes of one of

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

aaron.ballman added a comment. In D69764#2058590 , @rsmith wrote: > In D69764#2058334 , @MyDeveloperDay > wrote: > > > @rsmith, Thank you for your comments, I don't agree, but thank you anyway. > > > > I will conti

cfe-commits@lists.llvm.org

LukeGeeson created this revision. LukeGeeson added reviewers: SjoerdMeijer, t.p.northover, sdesmalen, labrinea. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D80716: [AArch64]: BFlo

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

ymandel added a comment. Thanks for the suggestioned change. However, I think we can do somewhat simpler. What do you think of just providing a setter on the super class void setRule(Optional Rule) { this->Rule = std::move(Rule); } Subclasses will call `setRule` in their constructor body . O

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zixuw added reviewers: ributzka, steven_wu, cishida, bruno, arphaman. Herald added a subscriber: dexonsmith. zixuw edited the summary of this revision. - Add an `-Wundef-prefix=,...` option, which i

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 266976. yaxunl added a comment. Emit target id module flag metadata. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic/Off

[PATCH] D80492: Avoid linking libdl unless needed

This revision was automatically updated to reflect the committed changes. Closed by commit rG0073c293a401: [clang] Avoid linking libdl unless needed (authored by thieta, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/

[PATCH] D80748: [clang] Add '-Wundef-prefix' warning option

zixuw created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zixuw abandoned this revision. Add an `-Wundef-prefix=,...` option, which is similar to `-Wundef`, but only give warnings for undefined macros with the given prefixes. Make `-Wundef` an alias of `-W

[PATCH] D80727: AMDGPU: Add intrinsic for s_setreg

arsenm closed this revision. arsenm added a comment. 97f3f0bab0982f84745c7ac5ce8fb6b0918ff718 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80727/new/ https://reviews.llvm.org/D80727 __

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

leonardchan added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:597-598 /// /// This extension point allows adding optimizations at the very end of the /// function optimization pipeline. A key difference between this and the /// legacy PassManag

[PATCH] D80697: [clang-tidy] Reworked TransformerClangTidyCheck to simplify usage of Options

njames93 updated this revision to Diff 266957. njames93 added a comment. - Renamed makeRule to buildRule to avoid ambiguity with tooling::makeRule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80697/new/ https://reviews.llvm.org/D80697 Files: cl

[clang] 97f3f0b - AMDGPU: Add intrinsic for s_setreg

Author: Matt Arsenault Date: 2020-05-28T14:26:38-04:00 New Revision: 97f3f0bab0982f84745c7ac5ce8fb6b0918ff718 URL: https://github.com/llvm/llvm-project/commit/97f3f0bab0982f84745c7ac5ce8fb6b0918ff718 DIFF: https://github.com/llvm/llvm-project/commit/97f3f0bab0982f84745c7ac5ce8fb6b0918ff718.diff

[clang] 0073c29 - [clang] Avoid linking libdl unless needed

Author: Tobias Hieta Date: 2020-05-28T21:08:00+03:00 New Revision: 0073c293a401774ac96b4b3d27f05e13f379f98e URL: https://github.com/llvm/llvm-project/commit/0073c293a401774ac96b4b3d27f05e13f379f98e DIFF: https://github.com/llvm/llvm-project/commit/0073c293a401774ac96b4b3d27f05e13f379f98e.diff

[PATCH] D80626: [analyzer] SATestBuild.py: Make verbosity level a cmd option

This revision was automatically updated to reflect the committed changes. Closed by commit rG5395389475bc: [analyzer] SATestBuild.py: Make verbosity level a cmd option (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80626/new/

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a comment. I figured out what the problem is and we can relatively easily fix it *once* we always have an OpenMPIRBuilder available in Clangs CG. As noted in D80735 , we should remove `IdentQTy` as it is used to create a new ident_t in some situa

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

rjmccall added a comment. Thanks, functionality is looking good for the non-assignment operators. Comment at: clang/lib/Sema/SemaExpr.cpp:12112 +return InvalidOperands(Loc, OriginalLHS, OriginalRHS); + } + You need to not actually apply this conversion to

[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80374/new/ https://reviews.llvm.org/D80374 _

[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

ymandel added a comment. Fixed with commit a1b88afe46d7a0f72d2acd8792951bd959b27545 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80023/new/ https://reviews.llvm.org/D80023

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

njames93 added a comment. Few changes and nits then LGTM Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.cpp:25 + const SourceManager &SM) + : Check(Check), PP(PP), SM(SM) {} + nit: You don't need to store a

[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage

Fznamznon updated this revision to Diff 266942. Fznamznon marked an inline comment as done and an inline comment as not done. Fznamznon added a comment. Included test cases from Johannes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ htt

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/EastWestConstFixer.cpp:195 +FormatToken *Tok) { + // We only need to think about streams that begin with const. + if (!Tok->is(tok

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

erichkeane created this revision. erichkeane added reviewers: rsmith, rjmccall. erichkeane added a comment. I hope that @rsmith pays particular attention here for me, I'm unable to come up with any cases where this isn't sufficient/breaks other things, but I also don't feel like I know deduction

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

erichkeane added a comment. I hope that @rsmith pays particular attention here for me, I'm unable to come up with any cases where this isn't sufficient/breaks other things, but I also don't feel like I know deduction guides well enough to claim that I don't break anything :) All the lit tests

[clang] 5395389 - [analyzer] SATestBuild.py: Make verbosity level a cmd option

Author: Valeriy Savchenko Date: 2020-05-28T20:47:06+03:00 New Revision: 5395389475bcaba16966ab62125f2f54ea81c915 URL: https://github.com/llvm/llvm-project/commit/5395389475bcaba16966ab62125f2f54ea81c915 DIFF: https://github.com/llvm/llvm-project/commit/5395389475bcaba16966ab62125f2f54ea81c915.d

  1   2   3   >