[PATCH] D79290: Update suffix check and cast non-suffix types

reikdas updated this revision to Diff 261682. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79290/new/ https://reviews.llvm.org/D79290 Files: clang/lib/AST/TemplateBase.cpp clang/test/Misc/integer-literal-printing.cpp Index: clang/test/Misc/integer-literal-printing.cpp

[PATCH] D79290: Update suffix check and cast non-suffix types

reikdas updated this revision to Diff 261683. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79290/new/ https://reviews.llvm.org/D79290 Files: clang/lib/AST/TemplateBase.cpp clang/test/Misc/integer-literal-printing.cpp Index: clang/test/Misc/integer-literal-printing.cpp

[PATCH] D79290: Update suffix check and cast non-suffix types

v.g.vassilev added a comment. @hubert.reinterpretcast, this patch is part of our internal forks which we would like to put upstream. The author of the previous patch does not have bandwidth to work on it and @reikdas kindly volunteered to take over. I can close the previous one if that's prefer

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

jfb added a comment. In D79279#2016573 , @rjmccall wrote: > In D79279#2016570 , @rjmccall wrote: > > > I do think this is a somewhat debatable change in the behavior of these > > builtins, though. > > > Let me put

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

rjmccall added a comment. In D79279#2016570 , @rjmccall wrote: > I do think this is a somewhat debatable change in the behavior of these > builtins, though. Let me put more weight on this. You need to propose this on cfe-dev. Repository: rG LLVM Gi

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

rjmccall added a comment. In D79279#2016496 , @jfb wrote: > In D79279#2015983 , @rjmccall wrote: > > > Most of the complexity of this patch is introduced by the decision to > > type-check these calls with a volatil

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

rmansfield added a comment. They're overly reduced examples ;) but embedded programmers tend to make heavy use of shift operators, including within for loops and if stmts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 ___

[PATCH] D79279: Allow volatile parameters to __builtin_mem{cpy,move,set}

jfb added a comment. In D79279#2015983 , @rjmccall wrote: > Most of the complexity of this patch is introduced by the decision to > type-check these calls with a volatile-typed parameter, which seems like it > does nothing but cause problems. If your go

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

ASDenysPetrov added a comment. In D79232#2016065 , @NoQ wrote: > @baloghadamsoftware @steakhal @ASDenysPetrov will you be able to plug D49074 > /D50256 > /D77792 >

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay added a comment. In D79293#2016410 , @rmansfield wrote: > Couple examples: > > void foo(int x) { > > for (unsigned int i = 0; i < x >> 1; i++) { } > > } > > and > > int i = 0; > > if (i < x >> 1) {} > > > } I don't deny there

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

abhinavgaba added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5974 + SmallVectorImpl &Result) override {} +}; + Overloading `CompleteType(TagDecl*)` is causing a warning: virtual void `clang::ExternalASTSource::

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG4597e3bd475b: [libclang]: visit BindingDecl in DecompositionDecl (authored by milianw, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D78214: [libclang]: visit C++17 if init statements

This revision was automatically updated to reflect the committed changes. Closed by commit rG08e181264318: [libclang]: visit C++17 if init statements (authored by milianw, committed by bkramer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new

[PATCH] D78214: [libclang]: visit C++17 if init statements

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78214/new/ https://reviews.llvm.org/D78214 ___

[PATCH] D78213: [libclang]: visit BindingDecl in DecompositionDecl

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78213/new/ https://reviews.llvm.org/D78213 ___

[clang] 4597e3b - [libclang]: visit BindingDecl in DecompositionDecl

Author: Milian Wolff Date: 2020-05-02T22:18:31+02:00 New Revision: 4597e3bd475badff9f81e5d738913cd841bc3c1d URL: https://github.com/llvm/llvm-project/commit/4597e3bd475badff9f81e5d738913cd841bc3c1d DIFF: https://github.com/llvm/llvm-project/commit/4597e3bd475badff9f81e5d738913cd841bc3c1d.diff

[clang] 08e1812 - [libclang]: visit C++17 if init statements

Author: Milian Wolff Date: 2020-05-02T22:18:36+02:00 New Revision: 08e18126431878373abfa33136768d0ec7c13def URL: https://github.com/llvm/llvm-project/commit/08e18126431878373abfa33136768d0ec7c13def DIFF: https://github.com/llvm/llvm-project/commit/08e18126431878373abfa33136768d0ec7c13def.diff

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

rmansfield added a comment. Couple examples: void foo(int x) { for (unsigned int i = 0; i < x >> 1; i++) { } } and int i = 0; if (i < x >> 1) {} } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 _

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay updated this revision to Diff 261656. MyDeveloperDay added a comment. Update for pre-merge checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79293/new/ https://reviews.llvm.org/D79293 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D79292: [sema] NFC Unable to build Sema library with MSVC Debug target due to missing /bigobj

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e194a3b9356: [sema] NFC Unable to build Sema library with MSVC Debug target due to missing… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 9e194a3 - [sema] NFC Unable to build Sema library with MSVC Debug target due to missing /bigobj

Author: mydeveloperday Date: 2020-05-02T19:34:58+01:00 New Revision: 9e194a3b9356c6ef0498609c1779043d1b6bb9e1 URL: https://github.com/llvm/llvm-project/commit/9e194a3b9356c6ef0498609c1779043d1b6bb9e1 DIFF: https://github.com/llvm/llvm-project/commit/9e194a3b9356c6ef0498609c1779043d1b6bb9e1.diff

[clang] c0f210d - Don't stash types that aren't copyable or moveable into a SmallVector

Author: Benjamin Kramer Date: 2020-05-02T19:13:06+02:00 New Revision: c0f210d636300abe891cf7e5f07d13f5f4c0102e URL: https://github.com/llvm/llvm-project/commit/c0f210d636300abe891cf7e5f07d13f5f4c0102e DIFF: https://github.com/llvm/llvm-project/commit/c0f210d636300abe891cf7e5f07d13f5f4c0102e.dif

[PATCH] D79293: [clang-format] [PR45218] Fix an issue where < and > and >> in a for loop gets incorrectly interpreted at a TemplateOpener/Closer

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: owenpan, hans, krasimir, mitchell-stellar, sammccall, pawels. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay edited the summary of this revision. Fix to address https://bugs.llvm.org/show_bug.cgi?id=45218 T

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

b-sumner added a comment. In D77910#2015225 , @arsenm wrote: > In D77910#1989163 , @b-sumner wrote: > > > In D77910#1988807 , @arsenm wrote: > > > > > In D77910#1981828

[PATCH] D79290: Update suffix check and cast non-suffix types

hubert.reinterpretcast added a comment. In D79290#2016278 , @reikdas wrote: > In D79290#2016273 , > @hubert.reinterpretcast wrote: > > > @reikdas, please upload the full copy of your combined changes to D77598 > >

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sbc100 added a comment. In D70500#134 , @bernhard wrote: > > Would it work to increase the memory size, and then put your data in the > > new space this creates at the end of memory? > > > > > `__data_end` and `__heap_base` aren't things you can move

[PATCH] D79292: [sema] NFC Unable to build Sema library with MSVC Debug target due to missing /bigobj

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79292/new/ https://reviews.llvm.org/D79292

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

tejohnson added a comment. In D77925#2016299 , @wenlei wrote: > @mehdi_amini @tejohnson When can we re-land this (with tweaks)? I'm under the > impression that a test case demonstrating the 3rd party usage will be added > very soon after this revert, the

[PATCH] D79292: [sema] NFC Unable to build Sema library with MSVC Debug target due to missing /bigobj

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: ABataev, jdoerfert, aaron.ballman, rnk. MyDeveloperDay added a project: clang. Herald added a subscriber: mgorny. Unable to build sema library on MSVC with Debug target C:\clang\llvm-project\clang\lib\Sema\SemaOpenMP.cpp : fa

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

wenlei added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. @mehdi_amini @tejohnson When can we re-land this (with tweaks)? I'm under the impression that a test case demonstrating the 3rd party usage will be added very soon after this revert, then we can tweak

[PATCH] D79094: [SemaObjC] Warn on visibility attributes on an @implementation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This seems reasonable to me. I agree that this feels like it's something that should be written on the declaration in the header, not just magically appear on the definition, but

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

aaron.ballman added a comment. I only see a comment on the issue, but not that the issue was resolved in favor of that comment (unless I've missed something). If the issue gets resolved in the direction that comment is going, then the revert makes sense (though we should add an explicit test ca

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6898 case ParsedAttr::AT_Constructor: -handleConstructorAttr(S, D, AL); +if (S.Context.getTargetInfo().getTriple().isOSAIX()) + S.Diag(AL.getLoc(), diag::warn_attribute_type_not_suppo

[clang] cc1c516 - Use realloc for NestedNameSpecifierLocBuilder

Author: Benjamin Kramer Date: 2020-05-02T17:12:44+02:00 New Revision: cc1c51655854627c126daf9ead4c701616564bde URL: https://github.com/llvm/llvm-project/commit/cc1c51655854627c126daf9ead4c701616564bde DIFF: https://github.com/llvm/llvm-project/commit/cc1c51655854627c126daf9ead4c701616564bde.dif

[PATCH] D79121: Add nomerge function attribute to clang

aaron.ballman added a comment. This is missing Sema tests ensuring that the attribute only appertains to the correct subject, does not accept arguments, etc. Comment at: clang/include/clang/Basic/AttrDocs.td:356 + let Content = [{ +Calls to functions marked `nomerge` will not

[PATCH] D79204: [clang-format] NFC - clang-format the FormatTests

This revision was automatically updated to reflect the committed changes. Closed by commit rGece7e95f02cd: [clang-format] NFC - clang-format the FormatTests (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79204/new/ https

[PATCH] D79290: Update suffix check and cast non-suffix types

reikdas added a comment. In D79290#2016273 , @hubert.reinterpretcast wrote: > @reikdas, please upload the full copy of your combined changes to D77598 > where the review is still active and close > this. This still does

[clang] ece7e95 - [clang-format] NFC - clang-format the FormatTests

Author: mydeveloperday Date: 2020-05-02T15:42:20+01:00 New Revision: ece7e95f02cdcdf9fa7c6fdfbf6db92e4cc0c87e URL: https://github.com/llvm/llvm-project/commit/ece7e95f02cdcdf9fa7c6fdfbf6db92e4cc0c87e DIFF: https://github.com/llvm/llvm-project/commit/ece7e95f02cdcdf9fa7c6fdfbf6db92e4cc0c87e.diff

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. In D74051#2016101 , @mgorny wrote: > In D74051#2016085 , @lebedev.ri > wrote: > > > In D74051#2016078 , @mgorny wrote: > > > > > This broke runn

[clang-tools-extra] d10c995 - std::isspace -> llvm::isSpace (where locale should be ignored)

Author: Sam McCall Date: 2020-05-02T15:36:04+02:00 New Revision: d10c995b4ddf6be8f3a9c5ad61dd0becb5355cbe URL: https://github.com/llvm/llvm-project/commit/d10c995b4ddf6be8f3a9c5ad61dd0becb5355cbe DIFF: https://github.com/llvm/llvm-project/commit/d10c995b4ddf6be8f3a9c5ad61dd0becb5355cbe.diff LO

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff marked an inline comment as done. sepavloff added inline comments. Comment at: clang/docs/UsersManual.rst:770 + $ cat abc + clang-11,"/tmp/foo-123456.o",92000,84000,87536 + ld,"a.out",900,8000,53568 aganea wrote: > sepavloff wrote: > > aganea wrot

[clang-tools-extra] b283ae7 - [ADT] Add locale-independent isSpace() to StringExtras. NFC

Author: Sam McCall Date: 2020-05-02T15:20:05+02:00 New Revision: b283ae7af8261c994a62b17b0eaf90cf649228fe URL: https://github.com/llvm/llvm-project/commit/b283ae7af8261c994a62b17b0eaf90cf649228fe DIFF: https://github.com/llvm/llvm-project/commit/b283ae7af8261c994a62b17b0eaf90cf649228fe.diff LO

[PATCH] D79139: [clangd] Fix whitespace between chunks in markdown paragraphs.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGec170b7ccd5b: [clangd] Fix whitespace between chunks in markdown paragraphs. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77598: Integral template argument suffix printing

reikdas added a comment. I updated the diff here - https://reviews.llvm.org/D79290. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

bernhard added a comment. I had an application crash with optimizations enabled, so I wanted to keep the debug info but the automatic wasm-opt kept removing it and I lost another 30 minutes to this, so I'm back :-) Can we get clang not to automatically call wasm-opt if it is called without `-X

[clang-tools-extra] fa1f4cf - [clangd] Rename FormattedString -> Markup, move to support. NFC

Author: Sam McCall Date: 2020-05-02T14:53:47+02:00 New Revision: fa1f4cf84326b59f917bccde784875c742e71740 URL: https://github.com/llvm/llvm-project/commit/fa1f4cf84326b59f917bccde784875c742e71740 DIFF: https://github.com/llvm/llvm-project/commit/fa1f4cf84326b59f917bccde784875c742e71740.diff LO

[clang-tools-extra] ec170b7 - [clangd] Fix whitespace between chunks in markdown paragraphs.

Author: Sam McCall Date: 2020-05-02T14:39:54+02:00 New Revision: ec170b7ccd5bf7aa05dea80e6f246964fd081e98 URL: https://github.com/llvm/llvm-project/commit/ec170b7ccd5bf7aa05dea80e6f246964fd081e98 DIFF: https://github.com/llvm/llvm-project/commit/ec170b7ccd5bf7aa05dea80e6f246964fd081e98.diff LO

[PATCH] D78904: [clang-tidy] extend bugprone-signed-char-misuse check with array subscript case.

ztamas updated this revision to Diff 261634. ztamas added a comment. Spelling / grammar fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78904/new/ https://reviews.llvm.org/D78904 Files: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuse

[PATCH] D78429: [clangd] Metric tracking through Tracer

sammccall accepted this revision. sammccall added a comment. Still LG Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:1047 Server, FooHPath, RenamePos, NewName, {/*CrossFile=*/true})); + EXPECT_THAT(Tracer.takeMetric("rename_files"), SizeIs(1));

[PATCH] D78904: [clang-tidy] extend bugprone-signed-char-misuse check with array subscript case.

This revision was automatically updated to reflect the committed changes. Closed by commit rG030ff901f432: [clang-tidy] extend bugprone-signed-char-misuse check with array subscript case. (authored by ztamas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang-tools-extra] 030ff90 - [clang-tidy] extend bugprone-signed-char-misuse check with array subscript case.

Author: Tamás Zolnai Date: 2020-05-02T14:05:05+02:00 New Revision: 030ff901f43258d18b68a77b0085d0fae2a0fbc6 URL: https://github.com/llvm/llvm-project/commit/030ff901f43258d18b68a77b0085d0fae2a0fbc6 DIFF: https://github.com/llvm/llvm-project/commit/030ff901f43258d18b68a77b0085d0fae2a0fbc6.diff

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: alexfh, gribozavr2. DmitryPolukhin added projects: clang-tools-extra, clang. Herald added a subscriber: xazax.hun. Also added BuildDirectory for completness and removed unused `Fix`. Test Plan: check-all Repository: rG LLVM

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko marked 3 inline comments as done. vsavchenko added a comment. > Very nice, i like this architecture. Aww, thanks 😊 > @baloghadamsoftware @steakhal @ASDenysPetrov will you be able to plug D49074 > /D50256 > /D77792 >

[PATCH] D78903: [Driver] Add option -fproc-stat-report

tschuett added inline comments. Comment at: clang/lib/Driver/Driver.cpp:83 #include "llvm/Support/raw_ostream.h" +#include #include https://llvm.org/docs/CodingStandards.html#include-iostream-is-forbidden Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff updated this revision to Diff 261621. sepavloff added a comment. Updated patch - added variant of the option without file, it is used to print statistics on stdout. - Updated file locking mechanism. - Updated test and documentation accordingly. Repository: rG LLVM Github Monorepo

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

mgorny added a comment. In D74051#2016085 , @lebedev.ri wrote: > In D74051#2016078 , @mgorny wrote: > > > This broke running clang tests stand-alone: > > > > Traceback (most recent call last): > > File > > "/