[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

2020-02-09 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Bump @rsmith thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/ https://reviews.llvm.org/D73020 ___ cfe-commits mai

[PATCH] D73996: [Sema] Demote call-site-based 'alignment is a power of two' check for AllocAlignAttr into a warning

2020-02-09 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Bump @rsmith / @erichkeane thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73996/new/ https://reviews.llvm.org/D73996 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] a067891 - [clang][codegen] Fix another lifetime emission on alloca on non-default address space.

2020-02-09 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2020-02-10T00:15:56-05:00 New Revision: a06789138987d1f64bb2f97d3a5c0f39eaf94715 URL: https://github.com/llvm/llvm-project/commit/a06789138987d1f64bb2f97d3a5c0f39eaf94715 DIFF: https://github.com/llvm/llvm-project/commit/a06789138987d1f64bb2f97d3a5c0f39eaf94715.diff

[PATCH] D74298: Honor -finline-functions and -finline-hint-functions at -O0

2020-02-09 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. Hi @MaskRay – I was just looking at the source history. I didn't test the old way. As it turns out there isn't a regression, but just some unexplained code in the current clang option parsing. And the `-disable-O0-optnone` is a useful hint. Thanks! I've been hackin

[libclc] 85e2fa4 - libclc/r600: Use target specific builtins to implement rsqrt and native_rsqrt

2020-02-09 Thread Jan Vesely via cfe-commits
Author: Jan Vesely Date: 2020-02-09T14:42:15-05:00 New Revision: 85e2fa44c64e1edd2f675c990ecc60f5fadb4686 URL: https://github.com/llvm/llvm-project/commit/85e2fa44c64e1edd2f675c990ecc60f5fadb4686 DIFF: https://github.com/llvm/llvm-project/commit/85e2fa44c64e1edd2f675c990ecc60f5fadb4686.diff LO

[libclc] 4b23a2e - libclc: Move rsqrt implementation to a .cl file

2020-02-09 Thread Jan Vesely via cfe-commits
Author: Jan Vesely Date: 2020-02-09T14:42:09-05:00 New Revision: 4b23a2e8e971876d075d3ae322754dbc0495413d URL: https://github.com/llvm/llvm-project/commit/4b23a2e8e971876d075d3ae322754dbc0495413d DIFF: https://github.com/llvm/llvm-project/commit/4b23a2e8e971876d075d3ae322754dbc0495413d.diff LO

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

2020-02-09 Thread Richard Smith via cfe-commits
On Sun, 9 Feb 2020, 01:09 Nico Weber via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Our code fails to build with "destructor cannot be declared using a type > alias" after this, without us changing language mode or anything. > > Is that intended? > Can you provide a sketch of what you we

[PATCH] D74298: Honor -finline-functions and -finline-hint-functions at -O0

2020-02-09 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Why you say regression, do you have a case where fcd33149b48885ab8e4ca4ffb6977bce5be2e623 actually regressed things? -O0 implies optnone. For `-Xclang -disable-O0-optnone -O0 -finline-functions`, the patch can indeed make a difference. `-disable-O0-optnone` is currently

[PATCH] D74298: Honor -finline-functions and -finline-hint-functions at -O0

2020-02-09 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki added a comment. Hi @lebedev.ri – Before I add a small new test file, is there an existing one that you know of that would be good to extend? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74298/new/ https://reviews.llvm.org/D74298

[PATCH] D74298: Honor -finline-functions and -finline-hint-functions at -O0

2020-02-09 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. This clearly needs tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74298/new/ https://reviews.llvm.org/D74298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D74298: Honor -finline-functions and -finline-hint-functions at -O0

2020-02-09 Thread David Zarzycki via Phabricator via cfe-commits
davezarzycki created this revision. davezarzycki added a reviewer: chandlerc. davezarzycki added a project: clang. This fixes a regression introduced (over three years ago!) by fcd33149b48885ab8e4ca4ffb6977bce5be2e623. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74298 File

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

2020-02-09 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. Ping again. Is there still something more to do here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] e67cbac - Support -fstack-clash-protection for x86

2020-02-09 Thread via cfe-commits
Author: serge_sans_paille Date: 2020-02-09T10:42:45+01:00 New Revision: e67cbac81211d40332a79d98c9d5953624cc1202 URL: https://github.com/llvm/llvm-project/commit/e67cbac81211d40332a79d98c9d5953624cc1202 DIFF: https://github.com/llvm/llvm-project/commit/e67cbac81211d40332a79d98c9d5953624cc1202.d

[clang] 4546211 - Revert "Support -fstack-clash-protection for x86"

2020-02-09 Thread via cfe-commits
Author: serge-sans-paille Date: 2020-02-09T10:06:31+01:00 New Revision: 454621160066c067c97edb0a094553d8d0339c9b URL: https://github.com/llvm/llvm-project/commit/454621160066c067c97edb0a094553d8d0339c9b DIFF: https://github.com/llvm/llvm-project/commit/454621160066c067c97edb0a094553d8d0339c9b.d

[PATCH] D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings

2020-02-09 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin added a comment. On second thought maybe this should be fixed in clang-tidy and not here? Maybe besides `-export-fixes` there should be an `-export-warnings` or just `-yaml-export`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72730/new/ https://reviews.llvm.org/D72730

[clang] 0fd51a4 - Support -fstack-clash-protection for x86

2020-02-09 Thread via cfe-commits
Author: serge_sans_paille Date: 2020-02-09T09:35:42+01:00 New Revision: 0fd51a4554f5f4f90342f40afd35b077f6d88213 URL: https://github.com/llvm/llvm-project/commit/0fd51a4554f5f4f90342f40afd35b077f6d88213 DIFF: https://github.com/llvm/llvm-project/commit/0fd51a4554f5f4f90342f40afd35b077f6d88213.d