[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/include/clang/Serialization/ASTRecordReader.h:272 + + template <> OpenMPTraitInfo *readUserType() { return readOpenMPTraitInfo(); } + jdoerfert wrote: > kiranchandramo

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added a comment. If you don't mind, I can push a Diff to this Differential which will address these review comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:436 + + std::ifstream fin(FunctionsListFile); + if (!fin.good()) { `MemoryBuffer::getFi

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

(Also, it'd be nice if the "destructor cannot be declared using a type alias" diag had a fixit attached to it :) ) On Sat, Feb 8, 2020 at 7:09 PM Nico Weber wrote: > Our code fails to build with "destructor cannot be declared using a type > alias" after this, without us changing language mode or

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a436c5ea26: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder. (authored by fady , committed by jdoerfert). Changed prior to commit: https://reviews.l

[clang] e8a436c - [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

Author: fady Date: 2020-02-08T18:55:48-06:00 New Revision: e8a436c5ea26f69378e4c1cf3ddb5b647b201e0f URL: https://github.com/llvm/llvm-project/commit/e8a436c5ea26f69378e4c1cf3ddb5b647b201e0f DIFF: https://github.com/llvm/llvm-project/commit/e8a436c5ea26f69378e4c1cf3ddb5b647b201e0f.diff LOG: [Op

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

Our code fails to build with "destructor cannot be declared using a type alias" after this, without us changing language mode or anything. Is that intended? Can this be a default-error-mapped warning so that projects have some incremental transition path for this? On Fri, Feb 7, 2020 at 9:41 PM R

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea added inline comments. Comment at: clang/tools/driver/cc1_main.cpp:73 // defined as an internal software error. Otherwise, exit with status 1. - exit(GenCrashDiag ? 70 : 1); + llvm::sys::Process::Exit(GenCrashDiag ? 70 : 1); } arichardson wrote: > I

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

aganea updated this revision to Diff 243380. aganea added a comment. Minor update -- added support & tested the VEH codepath as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73742/new/ https://reviews.llvm.org/D73742 Files: clang/test/Driver/crash-report.c clang/tools/driver/

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. > I however didn't find how to specify in phabricator a dependency between the > two diffs, is that supported in phabricator? Ah, it can be set as child revision after creating the diff, done so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https:

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul updated this revision to Diff 243378. sthibaul retitled this revision from "[Gnu toolchain] Look at standard GCC multilib/multiarch paths by default" to "[Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul marked an inline comment as done. sthibaul added a comment. >> I feel like in this specific case it may be worth splitting this into two >> patches: > > Alright, doing so. It is now on https://reviews.llvm.org/D74282 I however didn't find how to specify in phabricator a dependency bet

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

sthibaul added a comment. > I feel like in this specific case it may be worth splitting this into two > patches: Alright, doing so. > isn't Hurd only limited to one GCC target triple (i386-gnu) for the time > being? Right now, yes, but we'll want to bootstrap a 64bit port sooner or later. Be

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

kristina added a comment. I feel like in this specific case it may be worth splitting this into two patches: - Factoring certain stuff out of `Linux.cpp` into `Gnu.(cpp|h)`. - Adding that machinery to `Hurd.cpp` with related tests. Also forgive me if I'm wrong but isn't Hurd only limited to one

Re: [PATCH] D68720: Support -fstack-clash-protection for x86

On Sat, Feb 08, 2020 at 01:26:03PM +, Simon Pilgrim via Phabricator wrote: > RKSimon added a comment. > > @serge-sans-paille Please can you fix the issues with EXPENSIVE_CHECKS > builds: > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-debian/builds/2604 yeah, spotted

[clang] 658495e - Revert "Support -fstack-clash-protection for x86"

Author: serge-sans-paille Date: 2020-02-08T14:26:22+01:00 New Revision: 658495e6ecd4f6e9422307379ce8ea959fea8e8f URL: https://github.com/llvm/llvm-project/commit/658495e6ecd4f6e9422307379ce8ea959fea8e8f DIFF: https://github.com/llvm/llvm-project/commit/658495e6ecd4f6e9422307379ce8ea959fea8e8f.d

[PATCH] D68720: Support -fstack-clash-protection for x86

RKSimon added a comment. @serge-sans-paille Please can you fix the issues with EXPENSIVE_CHECKS builds: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-debian/builds/2604 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

lewis-revill added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:93 + // If experimental extension, require use of current version number number + if (auto ExperimentalExtension = isExperimentalExtension(Ext)) { +if (!Args.hasArg(options::OPT_menab

[clang] e229017 - Support -fstack-clash-protection for x86

Author: serge_sans_paille Date: 2020-02-08T13:31:52+01:00 New Revision: e229017732bcf1911210903ee9811033d5588e0d URL: https://github.com/llvm/llvm-project/commit/e229017732bcf1911210903ee9811033d5588e0d DIFF: https://github.com/llvm/llvm-project/commit/e229017732bcf1911210903ee9811033d5588e0d.d

[PATCH] D73845: [Gnu toolchain] Look at standard GCC multilib/multiarch paths by default

sthibaul updated this revision to Diff 243359. sthibaul added a comment. Herald added a subscriber: ormris. Right, here is an updated patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/

[clang] ef83d46 - Use heterogenous lookup for std;:map

Author: Benjamin Kramer Date: 2020-02-08T13:28:29+01:00 New Revision: ef83d46b6b428fa1c8614cd28ab6fe3f07f8d075 URL: https://github.com/llvm/llvm-project/commit/ef83d46b6b428fa1c8614cd28ab6fe3f07f8d075 DIFF: https://github.com/llvm/llvm-project/commit/ef83d46b6b428fa1c8614cd28ab6fe3f07f8d075.dif