[PATCH] D72675: ix -ffast-math/-ffp-contract interaction

hfinkel added inline comments. Herald added a subscriber: wuzish. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2721 if (!MathErrno && AssociativeMath && ReciprocalMath && !SignedZeros && - !TrappingMath) + !TrappingMath && !FPContractDisabled) CmdArgs.push_

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

khchen added a comment. I think putting the resetTargetDefaultOptions after instance of TargetMachine is too late. for example: ppc and mips

[PATCH] D72675: ix -ffast-math/-ffp-contract interaction

wristow created this revision. wristow added reviewers: spatel, mcberg2017. Herald added subscribers: jsji, hiraditya, nemanjai. Herald added a project: LLVM. Fused Multiply Add (FMA) was not always being disabled when the switch `-ffp-contract=off` was used. More specifically, FMA is enabled wh

[PATCH] D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ab13f8cc3f7: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths (authored by mgorny). Herald added a subscriber: jrtc27. Herald added a project: clang. Repository: rG LLVM Github Mon

[PATCH] D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths

mgorny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72591/new/ https://reviews.llvm.org/D72591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1818233 , @thakis wrote: > This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt > > Looks like this expects itanium mangling; maybe you want `-triple > %itanium_abi_triple`? I missed this message. Sorry ab

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1818571 , @thakis wrote: > In D71301#1818233 , @thakis wrote: > > > This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt > > > > Looks like this expects itanium mangli

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thakis added a comment. In D71301#1818233 , @thakis wrote: > This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt > > Looks like this expects itanium mangling; maybe you want `-triple > %itanium_abi_triple`? Since the bot's been red for a

[PATCH] D72467: Remove "mask" operand from shufflevector.

efriedma updated this revision to Diff 237830. efriedma edited the summary of this revision. efriedma added a comment. Fixed one more issue. While I'm at it, get rid of the old overload of ConstantExpr::getShuffleVector, which only had a few remaining uses. Repository: rG LLVM Github Monorep

[clang] 84baf12 - try to fix InterfaceStubs/lambda.cpp on Windows after bd8c8827d96f0

Author: Nico Weber Date: 2020-01-13T21:22:46-05:00 New Revision: 84baf123a5213512e92e7deca2d111e00c2b97da URL: https://github.com/llvm/llvm-project/commit/84baf123a5213512e92e7deca2d111e00c2b97da DIFF: https://github.com/llvm/llvm-project/commit/84baf123a5213512e92e7deca2d111e00c2b97da.diff LO

[PATCH] D72467: Remove "mask" operand from shufflevector.

efriedma updated this revision to Diff 237825. efriedma retitled this revision from "[WIP] Remove "mask" operand from shufflevector." to "Remove "mask" operand from shufflevector.". efriedma added a comment. Rebase. Address review comment. More work on bitcode. I probably need to come up with

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

bd1976llvm added a comment. In D68101#1806475 , @nickdesaulniers wrote: > In D68101#1806213 , @rjmccall wrote: > > > In D68101#1806135 , > > @nickdesaulniers wrote: > > > >

[PATCH] D72668: [Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds

nathanchance accepted this revision. nathanchance added a comment. This revision is now accepted and ready to land. This fixes the error for me and looks better from a documentation perspective. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72668/ne

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'.

NoQ added a comment. Uh-oh, what happened here? Please don't post huge patches. 600 lines of code is huge. You could start off by implementing a single check (eg., `NullErrorResultChecker`) with a single library function and then add more checks and more functions in follow-up patches; this wo

[PATCH] D72668: [Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61798 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

MaskRay added a comment. https://reviews.llvm.org/D72668 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72668: [Driver][test] Fix Driver/hexagon-toolchain-elf.c for -DCLANG_DEFAULT_LINKER=lld builds

MaskRay created this revision. MaskRay added reviewers: leonardchan, nathanchance, sidney, bcain, kparzysz. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72668 Files: clang/test/Driver/hexagon-toolchain-el

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM. One more request for a comment below that I forgot to add earlier. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:154 } +BackendConsumer(BackendAction A

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

MaskRay added a comment. In D70919#1818355 , @nathanchance wrote: > I am seeing the same failure that @leonardchan reported above. This is > related to `-DCLANG_DEFAULT_LINKER=lld`: > > $ cmake -G Ninja \ > -Wno-dev \ > -DCMAKE_BUILD_TY

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72427/new/ https://reviews.llvm.org/D72427 ___

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang updated this revision to Diff 237811. akhuang added a comment. -Remove redundant test case -Committed refactoring part Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72427/new/ https://reviews.llvm.org/D72427 Files: clang/lib/CodeGen/CGDe

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

dblaikie added a comment. In D72427#1818322 , @rnk wrote: > > Total object file size on Windows, compiling with RelWithDebInfo: > > > > before: 4,257,448 kb > > after: 2,104,963 kb > > > > And on Linux > > > > before: 9,225,140 kb > > after: 4,387,4

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

xur updated this revision to Diff 237810. xur added a comment. Thanks Teresa for the suggestion: using the print() function in the llvm diagnosticPrinter is a lot better than duplicating the code. I changed the patch to use print() function. Also added comment as suggested by Teresa. CHANGES S

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

nathanchance added a comment. I am seeing the same failure that @leonardchan reported above. This is related to `-DCLANG_DEFAULT_LINKER=lld`: $ cmake -G Ninja \ -Wno-dev \ -DCMAKE_BUILD_TYPE=Release \ -DCLANG_DEFAULT_LINKER=lld \ -DPYTHON_EXECUTABLE=$(command -v

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

akhuang added a comment. Committed debug info kind refactoring bit in fe7cda2e. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72427/new/ https://reviews.llvm.org/D72427 ___ cfe-commits mailing list cfe

[PATCH] D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations.

ahatanak added inline comments. Comment at: clang/test/CodeGenObjC/objc-alloc-init.m:30 @implementation Y ++(Class)class { Can you add a test case for `[[self class] alloc]` to test the code in `tryGenerateSpecializedMessageSend`? Repository: rG LLVM Gith

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG53539bb032d1: [DebugInfo] Add another level to DebugInfoKind called Constructor (authored by akhuang). Changed prior to c

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

rnk added a comment. > Total object file size on Windows, compiling with RelWithDebInfo: > > before: 4,257,448 kb > after: 2,104,963 kb > > And on Linux > > before: 9,225,140 kb > after: 4,387,464 kb These numbers are amazing! I made a summary of Amy's list of types that become incomplete

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

vsapsai added a comment. Think I'll need to make another review pass but here are my comments so far: - Why are you adding ODR hash support for `RecordDecl` and not `TagDecl`? We already have support for `EnumDecl`, so `TagDecl` seems like a good candidate to cover both. Honestly, I don't know

[clang] 53539bb - [DebugInfo] Add another level to DebugInfoKind called Constructor

Author: Amy Huang Date: 2020-01-13T15:59:03-08:00 New Revision: 53539bb032d162e0147c0e9650a5d1c7ca77dae0 URL: https://github.com/llvm/llvm-project/commit/53539bb032d162e0147c0e9650a5d1c7ca77dae0 DIFF: https://github.com/llvm/llvm-project/commit/53539bb032d162e0147c0e9650a5d1c7ca77dae0.diff LOG

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

dblaikie added a comment. Looks pretty good to me - if you could commit the debug info level refactoring separately/up-front, and maybe the test case could be simplified a bit. Looking forward to seeing what comes of this option, analysis of missing types, etc. Comment at: cl

[PATCH] D72591: [clang] [test] Fix riscv-toolchain-extra to be less picky about paths

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Build llvm with `-DCLANG_RESOURCE_DIR=../lib/clang/99` Failing Tests (4): Clang :: Driver/modules.m Clang :: Driver/nostdlibinc.c Clang :: Driver/riscv32-toolchain-extra.c

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thakis added a comment. (And thanks for the mac fix!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

zahen updated this revision to Diff 237795. zahen added a comment. Incorporate review feedback. I had no luck converting the CHECK-FOO & CHECK-NOFOO tests to use `-verify` because the errors were reported against "(frontend)" error: 'error' diagnostics seen but not expected: (frontend): d

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thakis added a comment. This test fails on Windows: http://45.33.8.238/win/5658/step_7.txt Looks like this expects itanium mangling; maybe you want `-triple %itanium_abi_triple`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://re

[PATCH] D72647: [clangd] Only re-open files if their flags changed

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61796 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman updated this revision to Diff 237791. dgoldman added a comment. - Fix broken did-change-configuration test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://reviews.llvm.org/D72647 Files: clang-tools-extra/clangd/ClangdLS

[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

efriedma marked an inline comment as done. efriedma added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413 unsigned MaxRecurse) { - if (isa(Mask)) + if (all_of(Mask, [](int Elem) { return Elem == -1; })) r

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

rnk added a comment. I'm interested in making clang do this, but I think this needs significantly more work until this is ready to land. It needs in-tree tests. I assumed we'd want to hook it up to `clang-cl /Yc` and `/Yu`. Comment at: clang/include/clang/Basic/LangOptions.de

[PATCH] D69779: -fmodules-codegen should not emit extern templates

dblaikie added inline comments. Comment at: clang/test/PCH/codegen-extern-template.cpp:1-9 +// Build the PCH with extern template. +// RUN: %clang -x c++-header %S/codegen-extern-template.h -o %t.pch -Xclang -building-pch-with-obj -Xclang -fmodules-codegen +// Build the PCH's ob

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

pzheng added a comment. In D62686#1816681 , @lewis-revill wrote: > Fix .cfi_offset signedness error. Thanks, @lewis-revill. It looks correct now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1817926 , @thakis wrote: > This breaks tests on macOS: http://45.33.8.238/mac/5672/step_7.txt (macOS > prefixes functions with an extra `_`.) Should be fixed now. Sorry about this. Thanks Again Nico. Repository: rG

[PATCH] D72647: [clangd] Only re-open files if their flags changed

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61795 tests passed, 1 failed and 781 were skipped. failed: Clangd.Clangd/did-change-configuration-params.test {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format:

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

JonasToth added a comment. K. Thank you for fixing it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72630/new/ https://reviews.llvm.org/D72630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] a506f7f - [clang][IFS][test] Fixing mangled name of a test for Darwin.

Author: Puyan Lotfi Date: 2020-01-13T17:01:48-05:00 New Revision: a506f7f9105eec4baac296d21c922457d6f4b52a URL: https://github.com/llvm/llvm-project/commit/a506f7f9105eec4baac296d21c922457d6f4b52a DIFF: https://github.com/llvm/llvm-project/commit/a506f7f9105eec4baac296d21c922457d6f4b52a.diff L

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

akhuang added a comment. Looks like the first commit c958639098a8 is also causing a crash in chromium code, so I will revert that as well. I got a reduced test case: typedef void voidtype; struct S { voidtype a();

[PATCH] D69779: -fmodules-codegen should not emit extern templates

llunak added a comment. Do you need some more information about the patch? It'd be nice if this could make it into 10.0. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69779/new/ https://reviews.llvm.org/D69779 ___ c

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

malcolm.parsons marked 2 inline comments as done. malcolm.parsons added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-default-member-init.cpp:294 int e3 = {5}; - int e4 = 5; + int e4{5}; int e5 = -5; JonasToth wrot

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72647 Files: clang-tools-

[PATCH] D72621: PR44514: Fix recovery from noexcept with non-convertible expressions

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExceptionSpec.cpp:90-92 +llvm::APSInt Value{1}; +Value = 0; +return ConstantExpr::Create(Context, BoolExpr, APValue{Value}); aaron.ballman wr

[PATCH] D72621: PR44514: Fix recovery from noexcept with non-convertible expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0719bf2196c: PR44514: Fix recovery from noexcept with non-convertible expressions (authored by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72

[clang] f0719bf - PR44514: Fix recovery from noexcept with non-convertible expressions

Author: Erich Keane Date: 2020-01-13T13:51:48-08:00 New Revision: f0719bf2196c807351137ff30e39fd12aa5aa884 URL: https://github.com/llvm/llvm-project/commit/f0719bf2196c807351137ff30e39fd12aa5aa884 DIFF: https://github.com/llvm/llvm-project/commit/f0719bf2196c807351137ff30e39fd12aa5aa884.diff L

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers properly comdat

This revision was automatically updated to reflect the committed changes. Closed by commit rG810b28edb3f6: [ItaniumCXXABI] Make tls wrappers properly comdat (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/ https://rev

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

rnk added subscribers: aganea, mikerice. rnk added a comment. Honestly, MSVC's behavior makes more sense to me. Usually warnings tell the user they are doing something silly, and then let them do it anyway. Without this change, there is no way to add extra macros to some compilations, even if t

[PATCH] D72621: PR44514: Fix recovery from noexcept with non-convertible expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a simplification. Can you mention the LLVM bug report in the commit log, as well (and close the bug)? Comment at: clang/lib/Sema/SemaExceptionS

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rG349636d2bfc3: Implement VectorType conditional operator GNU extension. (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D71463?vs=234977&id=237768#toc Repository: rG LLVM G

[clang] 349636d - Implement VectorType conditional operator GNU extension.

Author: Erich Keane Date: 2020-01-13T13:27:20-08:00 New Revision: 349636d2bfc39a5c81a835a95d203a42d9f9301a URL: https://github.com/llvm/llvm-project/commit/349636d2bfc39a5c81a835a95d203a42d9f9301a DIFF: https://github.com/llvm/llvm-project/commit/349636d2bfc39a5c81a835a95d203a42d9f9301a.diff L

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze added a comment. Another option that came to my mind is using a BitVector to (recursively) flag bits that are occupied by the fields. This solution would be slightly slower and uses more memory but is probably a lot easier to understand, maintain and more robust than the currently propo

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

rjmccall added a comment. Is this approach going to work with scope-local strictness? We need a way to do a comparison that has the non-strict properties but appears in a function that enables strictness elsewhere. Comment at: llvm/include/llvm/IR/IRBuilder.h:2342 r

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi added a comment. In D71301#1817926 , @thakis wrote: > This breaks tests on macOS: http://45.33.8.238/mac/5672/step_7.txt (macOS > prefixes functions with an extra `_`.) Thank You Nico! Will fix Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM in general. The linked bug report misses a "4" --> PR0, so please the description for that. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/mac/5672/step_7.txt (macOS prefixes functions with an extra `_`.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 __

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers properly comdat

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm This will be a small change in behavior, but nobody on ELF should notice because things with vague linkage there are both ELF-weak and comdat. Comment at: clang/lib/CodeGen/

Re: [clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

Great, thanks! On Mon, Jan 13, 2020 at 4:04 PM Aaron Ballman wrote: > On Mon, Jan 13, 2020 at 2:25 PM Nico Weber wrote: > > > > This breaks tests on Windows: http://45.33.8.238/win/5636/step_8.txt > > > > Likely the usual "doesn't work with delayed template parsing" thing. > > > > Can you take

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8c8827d96f: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71463/new/ https://reviews.llvm.org/D71463 ___ cfe-commits mailing lis

[clang] bd8c882 - [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

Author: Puyan Lotfi Date: 2020-01-13T16:04:27-05:00 New Revision: bd8c8827d96f09be502f0da6897c1aef89e45c30 URL: https://github.com/llvm/llvm-project/commit/bd8c8827d96f09be502f0da6897c1aef89e45c30 DIFF: https://github.com/llvm/llvm-project/commit/bd8c8827d96f09be502f0da6897c1aef89e45c30.diff L

[clang] b7526cc - [NFC][clang][IFS] Adding braces to if-statement as prep for D71301.

Author: Puyan Lotfi Date: 2020-01-13T16:04:27-05:00 New Revision: b7526cc21ce55c8b53250df3d659fbdae3f894a7 URL: https://github.com/llvm/llvm-project/commit/b7526cc21ce55c8b53250df3d659fbdae3f894a7 DIFF: https://github.com/llvm/llvm-project/commit/b7526cc21ce55c8b53250df3d659fbdae3f894a7.diff L

Re: [clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

On Mon, Jan 13, 2020 at 2:25 PM Nico Weber wrote: > > This breaks tests on Windows: http://45.33.8.238/win/5636/step_8.txt > > Likely the usual "doesn't work with delayed template parsing" thing. > > Can you take a look, and if it takes a while to fix, revert while you > investigate? > > (I would

[clang-tools-extra] c1b13a1 - Fix a test case by adding -fno-delayed-template-parsing.

Author: Aaron Ballman Date: 2020-01-13T16:02:31-05:00 New Revision: c1b13a1b17719aebace1b3be7a6ac7f90b1901a6 URL: https://github.com/llvm/llvm-project/commit/c1b13a1b17719aebace1b3be7a6ac7f90b1901a6 DIFF: https://github.com/llvm/llvm-project/commit/c1b13a1b17719aebace1b3be7a6ac7f90b1901a6.diff

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers properly comdat

mstorsjo added a comment. @rnk and/or @rsmith - can either of you have a look at the new version of this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/ https://reviews.llvm.org/D71572 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D72579: Evaluate __{c11_,}atomic_is_lock_free to 0 (avoid libcall) if larger than MaxAtomicPromoteWidth

efriedma added a comment. Eagerly evaluating based on MaxAtomicPromoteWidth seems fine... assuming we're actually setting MaxAtomicPromoteWidth to something appropriate. The value on PowerPC looks wrong. If we're worried about constant-evaluating it in contexts where gcc doesn't, we can gener

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

tejohnson added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:151 + TargetMachine::initTargetOptions(M, Conf.Options); + lenary wrote: > tejohnson wrote: > > lenary wrote: > > > tejohnson wrote: > > > > This is going to be problematic. The Conf is a

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 237752. plotfi added a comment. Going to do an NFC pre-commit before this to add the braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D72612: [AArch64][SVE] Add ImmArg property to intrinsics with immediates

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1099 +class AsmVectorIndexOpnd +: Operand, ComplexPattern", []> { let ParserMatchClass = mc; sdesmalen wrote: > @efriedma @rengolin The idea here is to use a Compl

[PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

tejohnson added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:594 + // SourceLoc. + if (Context == nullptr) { +return FullSourceLoc(); xur wrote: > tejohnson wrote: > > Does this only happen with IR input? Does it always happen with IR in

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev added a comment. I'm not sure if leaving both `ReferenceLoc`s pointing to the same location is a sensible solution, but merging them seems quite complicated and probably not really worth the effort. I've considered multiple alternative solutions, as described in https://github.com/clan

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev edited the summary of this revision. kbobyrev added a comment. I'm not sure if leaving both `Refe

[PATCH] D70576: [Clang] Always set -z now linker option on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG231875e111fa: [Clang] Always set -z now linker option on Fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70576/new/ https://revi

[clang] 231875e - [Clang] Always set -z now linker option on Fuchsia

Author: Petr Hosek Date: 2020-01-13T11:54:04-08:00 New Revision: 231875e111facf6d15553dff9d7c04d3e9e4a404 URL: https://github.com/llvm/llvm-project/commit/231875e111facf6d15553dff9d7c04d3e9e4a404 DIFF: https://github.com/llvm/llvm-project/commit/231875e111facf6d15553dff9d7c04d3e9e4a404.diff LO

[PATCH] D72594: [clangd] Include expression in DecltypeTypeLoc sourcerange while building SelectionTree

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5465e74ef4c: [clangd] Include expression in DecltypeTypeLoc sourcerange while building… (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D72594?vs=237610&id=237743#toc Reposit

[PATCH] D72594: [clangd] Include expression in DecltypeTypeLoc sourcerange while building SelectionTree

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:530 SourceRange S = N.getSourceRange(); +if (auto *TL = N.get()) { + // DecltypeTypeLoc only contains the SourceRange for `decltype` keyword

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

Eugene.Zelenko added a comment. Please also close PRs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72121/new/ https://reviews.llvm.org/D72121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang-tools-extra] f5465e7 - [clangd] Include expression in DecltypeTypeLoc sourcerange while building SelectionTree

Author: Kadir Cetinkaya Date: 2020-01-13T20:33:13+01:00 New Revision: f5465e74ef4c9e24f867002aa598dc9e6481ead3 URL: https://github.com/llvm/llvm-project/commit/f5465e74ef4c9e24f867002aa598dc9e6481ead3 DIFF: https://github.com/llvm/llvm-project/commit/f5465e74ef4c9e24f867002aa598dc9e6481ead3.dif

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 237740. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp clang/test/InterfaceStubs/blocks.c clang/test/In

[PATCH] D72635: Add "context" capability to Thread Safety Analysis

eti-p-doray created this revision. eti-p-doray added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Main use case: Chromium has runtime "SequenceChecker" and "ThreadChecker" that enforce sequenced task context. Thread safety analysis can be used

[PATCH] D65184: [Sema] Thread Safety Analysis: Make negative capability typeless.

aaronpuchert requested changes to this revision. aaronpuchert added a comment. This revision now requires changes to proceed. > A fix would be to let all three produce exclusive negative capability, which > essentially means there is no type associated with negative capability. This > fix could

[PATCH] D72625: [clangd] Render header of hover card as a heading

This revision was automatically updated to reflect the committed changes. Closed by commit rG15078d7202b4: [clangd] Render header of hover card as a heading (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72625/new/ https://rev

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

plotfi updated this revision to Diff 237739. plotfi added a comment. using isa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 Files: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp clang/test/Int

Re: [clang-tools-extra] fb79ef5 - Fix readability-identifier-naming missing member variables

This breaks tests on Windows: http://45.33.8.238/win/5636/step_8.txt Likely the usual "doesn't work with delayed template parsing" thing. Can you take a look, and if it takes a while to fix, revert while you investigate? (I wouldn't said this on the phab issue, but couldn't find one.) On Mon, J

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

thakis added a comment. Thanks for seeing this through! > env var or flag Our build setup can easily add commandline flags, but it can't easily add env vars. So I think this should have a driver mode flag. For people who asked for an env var: Why do you need an env var for this? Almost all co

[PATCH] D50360: [Concepts] Requires Expressions

rsmith added a comment. (Partial comments; I'll try to complete the review today or tomorrow.) Comment at: clang/include/clang/AST/ExprCXX.h:4933 + +/// \brief A static requirement that can be used in a requires-expression to You're adding a total of ~400 lin

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. In D72362#1817599 , @bader wrote: > Does it make sense to implement such diagnostics in clang Sema, considering > that OpenCL does not allow recursion? > We implemented similar diag

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61796 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 6288f86 - Revert "[ThinLTO] Add additional ThinLTO pipeline testing with new PM"

Author: Teresa Johnson Date: 2020-01-13T11:01:48-08:00 New Revision: 6288f86e870c7bb7fe47cc138320b9eb34c93941 URL: https://github.com/llvm/llvm-project/commit/6288f86e870c7bb7fe47cc138320b9eb34c93941 DIFF: https://github.com/llvm/llvm-project/commit/6288f86e870c7bb7fe47cc138320b9eb34c93941.diff

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

dgoldman requested changes to this revision. dgoldman added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:347 + )cpp", + "ObjCPropertyRefExpr"}, + Please add a t

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

sammccall created this revision. sammccall added a reviewer: dgoldman. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72634 Files: clang-

[clang] cb988a8 - Add a couple of missed wildcards in debug-pass-manager output checking

Author: Teresa Johnson Date: 2020-01-13T10:49:40-08:00 New Revision: cb988a858abbaf1a1ae0fe03f2a1dae692131ea9 URL: https://github.com/llvm/llvm-project/commit/cb988a858abbaf1a1ae0fe03f2a1dae692131ea9 DIFF: https://github.com/llvm/llvm-project/commit/cb988a858abbaf1a1ae0fe03f2a1dae692131ea9.diff

  1   2   >