[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

nhlubek added a comment. Required change for break after colon: https://github.com/llvm-mirror/clang/pull/67 New unit test shows use case that is not covered currently. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14484/new/ https://reviews.llvm.org/D14484 _

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

sdmitriev added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:1 -; RUN: opt -mtriple=x86_64-- -O2 -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck %s +; RUN: opt -mtriple=x86_64-- -O2 -debug-pass=Structure < %s -o /dev/null 2>&1 | FileCheck --check-pre

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. LLVM Release Schedule: 10.0.0: Jan 15, 2020: branch, then rc1 It would be nice to get a reply to my mail proposal before the branch.. so we could push the code for LLVM 10. (If it was lost, I can resend it) It can likely upset both sides, but with the proposal in th

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

njames93 created this revision. njames93 added a reviewer: aaron.ballman. njames93 added projects: clang, clang-tools-extra. Herald added a subscriber: xazax.hun. Fixes (clang-tidy) readability-identifier-naming misses fixing member variables in destructor

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

rjmccall added a comment. The solution described in that comment is not acceptable. We are not going to tell users that they cannot assign symbols explicitly to sections because LLVM is unable to promise not to miscompile if they do. It is LLVM's responsibility to correctly compile valid code

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is mostly a workaround for https://bugs.llvm.org/show_bug.cgi?id=42914. Once that is fixed, the handling in VisitDeducedTyped()

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61163 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

bd1976llvm added a comment. Sorry for the delay in updating this. I hoped to post an updated patch today for this but I realized that I first need to investigate whether section relative references might interact badly with multiple sections with the same name.. I will be able to update the pat

[PATCH] D72057: [docs] Remove outdated svn/git information from hacking page

AlexanderLanin updated this revision to Diff 235968. AlexanderLanin retitled this revision from "[docs] Update dead anchor in hacking page" to "[docs] Remove outdated svn/git information from hacking page". AlexanderLanin edited the summary of this revision. AlexanderLanin added a comment. Not su

[PATCH] D72113: [CMake] clang-scan-deps in Fuchsia distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rGb63bc648a489: [CMake] clang-scan-deps in Fuchsia distribution (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72113/new/ https://reviews

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

nridge updated this revision to Diff 235970. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72066/new/ https://reviews.llvm.org/D72066 Files: clang-tools-ext

[clang] b63bc64 - [CMake] clang-scan-deps in Fuchsia distribution

Author: Petr Hosek Date: 2020-01-02T16:49:52-08:00 New Revision: b63bc648a489c0f4d78203ae44cc1e9a6f9bcada URL: https://github.com/llvm/llvm-project/commit/b63bc648a489c0f4d78203ae44cc1e9a6f9bcada DIFF: https://github.com/llvm/llvm-project/commit/b63bc648a489c0f4d78203ae44cc1e9a6f9bcada.diff LO

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze marked 4 inline comments as done. gbencze added a comment. Thanks for all the feedback @JonasToth :) Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-suspicious-memory-comparison.rst:10 +This check corresponds to the CERT C Coding Standard rule +`EXP42-C.

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze updated this revision to Diff 235965. gbencze added a comment. Punctuation in comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bu

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added a comment. For future reference, if anyone needs here's the C versions of these builtins: https://godbolt.org/z/oHeAh- ^ looks like we are missing some backend-level folds for round-down variant, filed https://bugs.llvm.org/show_bug.cgi?id=8 Repository: rG LLVM Github Mo

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rnk created this revision. rnk added reviewers: rjmccall, craig.topper, erichkeane. Herald added a project: clang. MSVC 2013 would refuse to pass highly aligned things (typically vectors and aggregates) by value. Users would receive this error: t.cpp(11) : error C2719: 'w': formal parameter wit

[PATCH] D72113: [CMake] clang-scan-deps in Fuchsia distribution

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72113/new/ https://reviews.llvm.org/D72113 __

[PATCH] D72113: [CMake] clang-scan-deps in Fuchsia distribution

phosek created this revision. phosek added a reviewer: xazax.hun. Herald added subscribers: cfe-commits, tschuett, rnkovacs, mgorny. Herald added a project: clang. We would like to use clang-scan-deps in Fuchsia build so include it in the toolchain distribution. Repository: rG LLVM Github Mono

[PATCH] D72057: [docs] Update dead anchor in hacking page

AlexanderLanin marked an inline comment as done. AlexanderLanin added inline comments. Comment at: clang/www/hacking.html:301 - It is also possible to https://llvm.org/docs/GettingStarted.html#sending-patches-with-git";>use git to contribute to Clang. + It is also possible t

[PATCH] D72110: [X86] ABI compat bugfix for MSVC vectorcall

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61175 tests passed, 0 failed and 729 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

CJ-Johnson updated this revision to Diff 235948. CJ-Johnson edited the summary of this revision. CJ-Johnson added a comment. Herald added a project: clang. Fixing rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.

[PATCH] D72110: [X86] ABI compat bugfix for MSVC vectorcall

rnk created this revision. rnk added reviewers: erichkeane, craig.topper. Herald added a project: clang. Before this change, X86_32ABIInfo::classifyArgument would be called twice on vector arguments to vectorcall functions. This function has side effects to track GPR register usage, and this would

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

CJ-Johnson updated this revision to Diff 235944. CJ-Johnson added a comment. Rebase on head CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/Sanitizers.def clang/includ

[clang] a58da1a - [OPENMP50]Codegen for lastprivate conditional list items.

Author: Alexey Bataev Date: 2020-01-02T16:43:00-05:00 New Revision: a58da1a2ff039dd3bb4c43db3919995cf4a74cc7 URL: https://github.com/llvm/llvm-project/commit/a58da1a2ff039dd3bb4c43db3919995cf4a74cc7 DIFF: https://github.com/llvm/llvm-project/commit/a58da1a2ff039dd3bb4c43db3919995cf4a74cc7.diff

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth marked 6 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/AddConstTest.cpp:1006 +} + +} // namespace test aaron.ballman wrote: > JonasToth wrote: > > aaron.ballman wrote: > > > Can you also add

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 235938. JonasToth added a comment. - add proper objc test, that fail mostly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 Files: clang-tools-extra/clang-tidy/perf

[clang] 1fcc9b6 - [OPENMP] Restore allowing of braced initializers in the declare reduction

Author: Alexey Bataev Date: 2020-01-02T16:10:17-05:00 New Revision: 1fcc9b6ff8558efed0c1241c72f69d079baeecf8 URL: https://github.com/llvm/llvm-project/commit/1fcc9b6ff8558efed0c1241c72f69d079baeecf8 DIFF: https://github.com/llvm/llvm-project/commit/1fcc9b6ff8558efed0c1241c72f69d079baeecf8.diff

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61175 tests passed, 0 failed and 729 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames added a comment. This is for example useful to add a catch-all clause like `// expected-note-re@*:* 1+ {{candidate function {{.+` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 __

[PATCH] D72103: [Sema] Avoid using an invalid InsertPos

Mordante created this revision. Mordante added reviewers: lvoufo, rsmith. Mordante added a project: clang. The function `Sema::CheckVarTemplateId` tries to find a template specialization. If that fails it gets an `InsertPos` where the specialization should be added in a `FoldingSet`. Then it tri

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. arames added a reviewer: rsmith. This allows specifying `*` for the filename to match any file. For example: // expected-note@*:* {{Match this note in any file at any line.}} // expected-note@

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

xazax.hun added a comment. In D72097#1801777 , @gribozavr2 wrote: > Could you provide a more fleshed out example of a case where it is useful? Sure! The `std::any` could be one example (`std::variant` is similar, but ultimately, we migh want to be able

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

JonasToth added a comment. LG from my side, besides the small nits. Please let @aaron.ballman have a look as well. thanks for the patch :) Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousMemoryComparisonCheck.cpp:45 + + // check if comparing padding in base +

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

gribozavr2 added a comment. Could you provide a more fleshed out example of a case where it is useful? Could you update the documentation for the attribute? I'm forgetting if there's a spec for this attribute -- is this extension part of that spec? Do you foresee any issues or further special c

[PATCH] D69779: -fmodules-codegen should not emit extern templates

dblaikie added a comment. Hey - thanks for this! Does look like it reproduces in modules: foo.h: #pragma once template struct outer { static void func() { } }; template void func() { } extern template struct outer; extern template void func(); inline void cal

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 235921. hliao added a comment. code refinement after reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h clang

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao marked 6 inline comments as done. hliao added a comment. refinements are made after comments from reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 _

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

xazax.hun created this revision. xazax.hun added reviewers: aaron.ballman, gribozavr2, mgehre. xazax.hun added a project: clang. Herald added subscribers: Szelethus, Charusso, gamesh411, dkrupp, rnkovacs. It turns out it is useful to be able to define the deref type as void. In case we have a typ

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze updated this revision to Diff 235915. gbencze added a comment. Tests: Split C/C++ tests and add 32/64bit specific test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D72018: [attributes] [analyzer] Add an attribute to prevent checkers from modeling a function

xazax.hun added a comment. In D72018#1801725 , @aaron.ballman wrote: > Thank you for the explanation, that makes sense, but I'm still a bit > uncomfortable. In this case, it seems like the author of the API needs to 1) > know that users will be analyzin

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

rupprecht added a comment. In D71554#1789360 , @arichardson wrote: > Also handle -h/-v as short options. Does the adjusted test look okay? Sorry, didn't have time to take a second look before the holiday break -- yep, looks good, I didn't anticipate so

[PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante added a comment. In D71857#1800663 , @MaskRay wrote: > However, I am afraid I don't like some of the fixes here. You can replace > `const auto` with `const auto &` and call that a fix... IMHO if the type is > not obvious, `const ConcreteType &`

[PATCH] D72018: [attributes] [analyzer] Add an attribute to prevent checkers from modeling a function

aaron.ballman added a comment. In D72018#1801450 , @xazax.hun wrote: > In D72018#1800018 , @aaron.ballman > wrote: > > > This seems like a very specialized attribute for the static analyzer and > > I'm not certain

[clang] abb0075 - build: reduce CMake handling for zlib

Author: Saleem Abdulrasool Date: 2020-01-02T11:19:12-08:00 New Revision: abb00753069554c538f3d850897373d093389945 URL: https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945 DIFF: https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945.

[PATCH] D71991: Fix external-names.c test when separator is \\

amccarth added a comment. It would surprise me if the different test config is cause here. The path is assembled entirely in the code, so it should be consistent. If you had a systemic problem introduced by test config, I'd expect more of the VFS tests to fail. Anyway, if you're back in busi

[PATCH] D72087: [clang-tools-extra] NFC: Fix trivial typos in comments

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in 7ab9acd8f414161b784b61a1633a7c241b82be85 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch, I've committed on your behalf in ec3d8e61b527c6312f77a4dab095ffc34e954927 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7184

[clang-tools-extra] 7ab9acd - Fix trivial typos in comments; NFC

Author: Kazuaki Ishizaki Date: 2020-01-02T13:41:43-05:00 New Revision: 7ab9acd8f414161b784b61a1633a7c241b82be85 URL: https://github.com/llvm/llvm-project/commit/7ab9acd8f414161b784b61a1633a7c241b82be85 DIFF: https://github.com/llvm/llvm-project/commit/7ab9acd8f414161b784b61a1633a7c241b82be85.di

[clang-tools-extra] ec3d8e6 - Handle init statements in readability-else-after-return

Author: Nathan James Date: 2020-01-02T13:39:27-05:00 New Revision: ec3d8e61b527c6312f77a4dab095ffc34e954927 URL: https://github.com/llvm/llvm-project/commit/ec3d8e61b527c6312f77a4dab095ffc34e954927 DIFF: https://github.com/llvm/llvm-project/commit/ec3d8e61b527c6312f77a4dab095ffc34e954927.diff

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-suspicious-memory-comparison.cpp:1 +// RUN: %check_clang_tidy %s bugprone-suspicious-memory-comparison %t + gbencze wrote: > JonasToth wrote: > > We should explicitl

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61176 tests passed, 0 failed and 729 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added a comment. Hmm, i keep coming up with things here, sorry :/ I think we should take one more step - explicitly call out that the result of `__builtin_align_*` is, well, aligned :) For that, we need to add `__attribute__((alloc_align(2)))` attribute. Despite the name, it does not

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61176 tests passed, 0 failed and 729 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 235903. arichardson added a comment. - Fix typos caused by dodgy n key on my keyboard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 Files: clang/docs/LanguageE

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson added a comment. In D71499#1801421 , @lebedev.ri wrote: > (temporarily undoing my review since it looks like things may change) > > In D71499#1801302 , @arichardson > wrote: > > > ... > > > Aha! :) > >

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze marked 18 inline comments as done. gbencze added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-suspicious-memory-comparison.cpp:1 +// RUN: %check_clang_tidy %s bugprone-suspicious-memory-comparison %t + JonasToth wrote:

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze updated this revision to Diff 235900. gbencze added a comment. Coding guide and better diagnostic message for padding comparison CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyM

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 235899. arichardson marked 2 inline comments as done. arichardson added a comment. - Generate inbounds GEP. Also mention that values must point to the same allocation in the documentation. - Clarify that correctly aligned values do not change. Repositor

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71463/new/ https://reviews.llvm.org/D71463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

aaron.ballman added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/AddConstTest.cpp:66 + StringRef S = "MyInt target = 0;"; + auto Cat = [&T](StringRef S) { return (T + S).str(); }; + JonasToth wrote: > aaron.ballman wrote: > > I don't thin

[PATCH] D72057: [docs] Update dead anchor in hacking page

aaron.ballman added inline comments. Comment at: clang/www/hacking.html:301 - It is also possible to https://llvm.org/docs/GettingStarted.html#sending-patches-with-git";>use git to contribute to Clang. + It is also possible to https://llvm.org/docs/GettingStarted.html#checko

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71969/new/ https://reviews.llvm.org/D71969 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D72087: [clang-tools-extra] NFC: Fix trivial typos in comments

kiszk added a comment. I do not have commit rights to the repository. Could someone commit this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72087/new/ https://reviews.llvm.org/D72087 ___ cfe-

[PATCH] D69878: Consoldiate internal denormal flushing controls

cameron.mcinally added a comment. This is looking pretty good to me, but I'm ignoring some of the target specific code that I'm not familiar with. Is `denormal-fp-math` influenced by `-Ofast`? Or are there plans for that? Seems like `-Ofast` should imply DAZ and FTZ (if supported by target). I

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

kkwli0 updated this revision to Diff 235894. kkwli0 added a comment. Update based on suggestion to simply the check and rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71969/new/ https://reviews.llvm.org/D71969 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

kpn closed this revision. kpn added a comment. My pleasure! Closed with commit 89d6c288ba5adb20d92142e9425f7ab79b8f159e . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 __

[PATCH] D72018: [attributes] [analyzer] Add an attribute to prevent checkers from modeling a function

xazax.hun added a comment. In D72018#1800018 , @aaron.ballman wrote: > This seems like a very specialized attribute for the static analyzer and I'm > not certain how much utility it adds, but that may be because I don't > understand the analyzer require

[clang] 89d6c28 - [SystemZ] Use FNeg in s390x clang builtins

Author: Kevin P. Neal Date: 2020-01-02T12:14:43-05:00 New Revision: 89d6c288ba5adb20d92142e9425f7ab79b8f159e URL: https://github.com/llvm/llvm-project/commit/89d6c288ba5adb20d92142e9425f7ab79b8f159e DIFF: https://github.com/llvm/llvm-project/commit/89d6c288ba5adb20d92142e9425f7ab79b8f159e.diff

[clang-tools-extra] acc4ffb - [clangd] Reorder FindTarget.h - group targetDecl() stuff and findExplicitReferences(). NFC

Author: Sam McCall Date: 2020-01-02T18:01:29+01:00 New Revision: acc4ffbb4733ec716d6ca3ad4d1e4605b9a2bcea URL: https://github.com/llvm/llvm-project/commit/acc4ffbb4733ec716d6ca3ad4d1e4605b9a2bcea DIFF: https://github.com/llvm/llvm-project/commit/acc4ffbb4733ec716d6ca3ad4d1e4605b9a2bcea.diff LO

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. (temporarily undoing my review since it looks like things may change) In D71499#1801302 , @arichardson wrote: > ... Aha! :) In D71

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

thakis added a comment. In D71554#1801246 , @arichardson wrote: > Should be fixed in > https://github.com/llvm/llvm-project/commit/a4f3847f3d5742cfab7acdc614e7ca54643e0c85 Thanks! Now it fails with a different error: http://45.33.8.238/win/4962/step_11

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. serge-sans-paille added inline comments. Comment at: llvm/test/lit.site.cfg.py.in:6 +def cmake_bool(val): +return val.lower() in (1, "on", "yes", "true", "y",) + thakis wro

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); ilya-biryukov wrote: > No need to fix this.

[PATCH] D72089: [Syntax] Build declarator nodes

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 ___ cfe-commits mailing list

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72089: [Syntax] Build declarator nodes

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. ilya-biryukov added a parent revision: D72072: [AST] Respect shouldTraversePostOrder when traversing type locs. They cover part of types and names for some declarations, including commo

[PATCH] D72087: [clang-tools-extra] NFC: Fix trivial typos in comments

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61171 tests passed, 0 failed and 729 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

CJ-Johnson commandeered this revision. CJ-Johnson added a reviewer: hfinkel. CJ-Johnson added a comment. After discussing things with Hal, I'm going to take over these diffs and try to update them to the new pass manager :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

__simt__ added a comment. In D71726#1792852 , @yaxunl wrote: > In D71726#1791904 , @jfb wrote: > > > This generally seems fine. Does it work on most backends? I want to make > > sure it doesn't fail in backends :)

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov marked 4 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/Expr.h:126 +if (TD) + D = D | DependencyFlags::Type; +if (VD) riccibruno wrote: > ilya-biryukov wrote: > > Mordante wrote: > > >

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

thakis added inline comments. Comment at: llvm/test/lit.site.cfg.py.in:6 +def cmake_bool(val): +return val.lower() in (1, "on", "yes", "true", "y",) + FYI, this is a now-discouraged pattern. It's better to use llvm_canonicalize_cmake_booleans in the cmake fi

[PATCH] D72087: NFC: Fix trivial typos in comments

kiszk created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. "the the" -> "the" "an" -> "a" Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72087 Files: clang-tools-extra/clang-tidy/bugprone/NotNull

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

jrtc27 added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2844 +The builtins ``__builtin_align_up``, ``__builtin_align_down``, return their +first argument aligned up/down to the next multiple of the second argument. +The builtin ``__builtin_is_aligned`` returns

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

ilya-biryukov added a comment. I landed a patch that does exactly this a few days ago: 14e11005d1a6ac1fecb230c470e9011d6956b8e4 Did you pull the latest changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D71854: [SystemZ] Use FNeg in s390x clang builtins

kpn updated this revision to Diff 235880. kpn added a comment. Update now-failing tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71854/new/ https://reviews.llvm.org/D71854 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-systemz-vector.c clang/test/CodeGen

[clang] e406cca - Revert "build: reduce CMake handling for zlib"

Author: James Henderson Date: 2020-01-02T16:02:10Z New Revision: e406cca5f9a6477c9861717f81c156aa83feeaca URL: https://github.com/llvm/llvm-project/commit/e406cca5f9a6477c9861717f81c156aa83feeaca DIFF: https://github.com/llvm/llvm-project/commit/e406cca5f9a6477c9861717f81c156aa83feeaca.diff LO

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG24ab9b537e61: Generalize the pass registration mechanism used by Polly to any third-party tool (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:597-598 case AtomicExpr::AO__atomic_add_fetch: -PostOp = llvm::Instruction::Add; +PostOp = E->getValueType()->isFloatingType() ? llvm::Instruction::FAdd +

[clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

Author: serge_sans_paille Date: 2020-01-02T16:45:31+01:00 New Revision: 24ab9b537e61b3fe5e6a1019492ff6530d82a3ee URL: https://github.com/llvm/llvm-project/commit/24ab9b537e61b3fe5e6a1019492ff6530d82a3ee DIFF: https://github.com/llvm/llvm-project/commit/24ab9b537e61b3fe5e6a1019492ff6530d82a3ee.d

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61043 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

riccibruno added inline comments. Comment at: clang/include/clang/AST/Expr.h:126 +if (TD) + D = D | DependencyFlags::Type; +if (VD) ilya-biryukov wrote: > Mordante wrote: > > Just curious why do you prefer `D = D | DependencyFlags::Type;` over `D |=

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson added a subscriber: brooks. arichardson added a comment. > What i'm asking is: > > - Are these builtins designed (as per `clang/docs/LanguageExtensions.rst`) to > only be passed pointers in-bounds to the allocated memory chunk (`Logical > pointer`*), or any random bag of bits casted

[clang-tools-extra] 8d7ecc1 - Revert "Revert "[clangd] Implement "textDocument/documentLink" protocol support""

Author: Sam McCall Date: 2020-01-02T16:36:21+01:00 New Revision: 8d7ecc16291ff415da0d5bfccb6363590a1310ad URL: https://github.com/llvm/llvm-project/commit/8d7ecc16291ff415da0d5bfccb6363590a1310ad DIFF: https://github.com/llvm/llvm-project/commit/8d7ecc16291ff415da0d5bfccb6363590a1310ad.diff LO

[PATCH] D72085: [clangd] Fix hover for functions inside templated classes

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/235 Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D71884: [OpenMP] Fix formatting of OpenMP error message.

This revision was automatically updated to reflect the committed changes. Closed by commit rG87a004d0f8c2: [OpenMP] Fix formatting of OpenMP error message, by Wang Tianqing. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71884/n

[clang] 87a004d - [OpenMP] Fix formatting of OpenMP error message, by Wang Tianqing.

Author: Alexey Bataev Date: 2020-01-02T10:07:04-05:00 New Revision: 87a004d0f8c2fe5c4577d81b4306c35e77f21f9a URL: https://github.com/llvm/llvm-project/commit/87a004d0f8c2fe5c4577d81b4306c35e77f21f9a DIFF: https://github.com/llvm/llvm-project/commit/87a004d0f8c2fe5c4577d81b4306c35e77f21f9a.diff

  1   2   >