[PATCH] D71982: [docs] Update path to clang-tools-extra

Jim added a comment. There shows "Context not available". Could you update for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71982/new/ https://reviews.llvm.org/D71982 ___ cfe-commits mailing lis

[PATCH] D71980: [clang-tidy] Fix bug - 44229, 33203 and 32204

lebedev.ri added a comment. Missing tests; please upload patches with full context (`-U9`); just referencing bug# is non-informative - best to say `"[clang-tidy] check-name: fix 'constexpr if' handling (PR#)"`; possibly you want to split this up into per-check patches Repository: rG LLV

Re: [clang] ce1f95a - Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag"

Thanks! Best regards, Djordje On 27.12.19. 20:30, David Blaikie wrote: > > > On Thu, Dec 26, 2019 at 11:58 PM Djordje Todorovic > mailto:djordje.todoro...@rt-rk.com>> wrote: > > Hi David, > > It's a good question. > > Current approach of the debug entry values will consider an e

[PATCH] D71625: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeadc97b0ec87: [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache… (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] eadc97b - [CMake] Added remote test execution support into CrossWinToARMLinux CMake cache file.

Author: Vladimir Vereschaka Date: 2019-12-29T20:36:19-08:00 New Revision: eadc97b0ec87801ddcf35f03d1d005f9929a5254 URL: https://github.com/llvm/llvm-project/commit/eadc97b0ec87801ddcf35f03d1d005f9929a5254 DIFF: https://github.com/llvm/llvm-project/commit/eadc97b0ec87801ddcf35f03d1d005f9929a5254

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

junparser added a comment. There is another issue we should consider: clang is crashed when compile coroutine with -disable-llvm-passes and output an object file. Is it reasonable to run coroutine passes even -disable-llvm-passes is enabled? Comment at: clang/lib/CodeGen/Ba

[PATCH] D71982: [docs] Update path to clang-tools-extra

AlexanderLanin created this revision. AlexanderLanin added projects: clang-tools-extra, clang. Herald added a subscriber: cfe-commits. > tools/clang/tools/extra has become > clang-tools-extra which was not updated in all docs. Also hacking page has an outdated anchor for git. Repository: r

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:103 + +- New alias :doc:`cert-exp42-c + ` to gbencze wrote: > Eugene.Zelenko wrote: > > Please move into aliases section (in alphabetical order) > I'm not quite sure where

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze marked 5 inline comments as done. gbencze added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:103 + +- New alias :doc:`cert-exp42-c + ` to Eugene.Zelenko wrote: > Please move into aliases section (in alphabetical order) I'm not qui

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze updated this revision to Diff 235526. gbencze added a comment. Update style based on comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71973/new/ https://reviews.llvm.org/D71973 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clan

[PATCH] D71953: [Tooling] Infer driver mode and target for FixedCompilationDatabase

de1acr0ix abandoned this revision. de1acr0ix added a comment. It is impossible to handle the case that positional argument starts with a source file with a driver mode suffix in file name stem, such as "somecpp.cpp". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D71980: Fix ClangTidy Bug - 44229, 33203 and 32204

njames93 updated this revision to Diff 235525. njames93 added a comment. Forgot to clang-format... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71980/new/ https://reviews.llvm.org/D71980 Files: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy

[PATCH] D71980: Fix ClangTidy Bug - 44229, 33203 and 32204

njames93 created this revision. njames93 added reviewers: clang-tools-extra, cfe-commits. fixes readability-misleading-indentation broken for if constexpr , readability-braces-around-statements broken for if constexpr

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousMemoryComparisonCheck.cpp:38 + + if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) { +const auto NonEmptyBaseIt = llvm::find_if(CXXRD->bases(), IsNotEmptyBase); Y

[PATCH] D57662: [clang-tidy] Parallelize clang-tidy-diff.py

JonasToth added a comment. In D57662#1797607 , @derek wrote: > @zinovy.nis @alexfh @JonasToth @MyDeveloperDay > > Hi folks, please correct me if I'm wrong but it appears that an effect of > this change is that this script will no longer exit non-zero if `

[PATCH] D71976: Match code following lambdas when ignoring invisible nodes

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71976 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp clang/unittests/ASTMatchers/A

[PATCH] D71977: Implement additional traverse() overloads

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. These overloads make it possible to wrap unless(), anyOf(), has() etc with the traverse matcher. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D71963: clang-tidy doc: Add the severities description

aaron.ballman added a comment. In D71963#1798212 , @sylvestre.ledru wrote: > I do agree that they are subjective and not perfect. > > However, I found the classification extremely useful when you look at the > results on big projects. > I have been usin

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:29 + unless(anyOf( + isConstexpr(), hasDeclContext(namespaceDecl(isAnonymous())), + hasType(isConstQualified()), -

[clang] f7d9584 - Fix formatting in previous commits

Author: Stephen Kelly Date: 2019-12-29T19:41:30Z New Revision: f7d9584c56d9d8e6092cc37d5e859db47b1a40d7 URL: https://github.com/llvm/llvm-project/commit/f7d9584c56d9d8e6092cc37d5e859db47b1a40d7 DIFF: https://github.com/llvm/llvm-project/commit/f7d9584c56d9d8e6092cc37d5e859db47b1a40d7.diff LOG:

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson updated this revision to Diff 235510. tejohnson added a comment. Attempt to fix patch to not include parent revision changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files: clang/test/Cod

[PATCH] D71911: [ThinLTO] Summarize vcall_visibility metadata

tejohnson updated this revision to Diff 235509. tejohnson added a comment. Implement suggested name change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 Files: clang/lib/CodeGen/CGVTables.cpp clang/l

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze created this revision. gbencze added reviewers: aaron.ballman, alexfh, JonasToth, Charusso. gbencze added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, xazax.hun, whisperity, mgorny. The check warns on suspicious calls to memcmp. It currently checks for compari

[PATCH] D71969: [OpenMP] diagnose zero-length array section in the depend clause

jdoerfert added a comment. I would put this check right next to the one that issues `err_omp_section_length_negative`. SemaExpr.cpp +4668 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71969/new/ https://reviews.llvm.org/D71969 ___ cfe-comm

Re: [clang-tools-extra] dc93540 - Fix handling of newlines in clang-query

On Sun, Dec 29, 2019 at 6:59 AM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Stephen Kelly > Date: 2019-12-29T14:58:56Z > New Revision: dc93540acbf047cf54052568d2826d1a06df025e > > URL: > https://github.com/llvm/llvm-project/commit/dc93540acbf047cf54052568d2826d1a

[clang-tools-extra] dc93540 - Fix handling of newlines in clang-query

Author: Stephen Kelly Date: 2019-12-29T14:58:56Z New Revision: dc93540acbf047cf54052568d2826d1a06df025e URL: https://github.com/llvm/llvm-project/commit/dc93540acbf047cf54052568d2826d1a06df025e DIFF: https://github.com/llvm/llvm-project/commit/dc93540acbf047cf54052568d2826d1a06df025e.diff LOG:

[clang-tools-extra] 544f200 - Fix newline handling in clang-query parser

Author: Stephen Kelly Date: 2019-12-29T14:58:56Z New Revision: 544f200c785f0314949ba3b8d1c51f65bf8d7761 URL: https://github.com/llvm/llvm-project/commit/544f200c785f0314949ba3b8d1c51f65bf8d7761 DIFF: https://github.com/llvm/llvm-project/commit/544f200c785f0314949ba3b8d1c51f65bf8d7761.diff LOG:

[PATCH] D57662: [clang-tidy] Parallelize clang-tidy-diff.py

zinovy.nis added a comment. In D57662#1797607 , @derek wrote: > @zinovy.nis @alexfh @JonasToth @MyDeveloperDay > > I'd be happy to provide a patch. It would be nice, thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://revi

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru added a comment. I do agree that they are subjective and not perfect. However, I found the classification extremely useful when you look at the results on big projects. I have been using codechecker (where the severities are coming from) for Firefox and its has been extremely us

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

tawmoto added a comment. In D44609#1798209 , @Alundra wrote: > Please review and consider a merge of this change which looks to not have > news since long time. > It's useful for a lot of people and it's awesome that there is a ready or > almost ready p

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Alundra added a comment. Please review and consider a merge of this change which looks to not have news since long time. It's useful for a lot of people and it's awesome that there is a ready or almost ready patchset about it. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

vingeldal marked an inline comment as done. vingeldal added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:29 + unless(anyOf( + isConstexpr(), hasDeclContext(namespaceDecl(isAnonymous())), +

[PATCH] D71963: clang-tidy doc: Add the severities description

vingeldal added a comment. It's very hard to write these kinds of definitions without ambiguity and plenty of subjective interpretation creeping in. I'll try my best to provide constructive feedback but I'm admittedly struggling a bit with providing helpful counter proposals. Ideally these leve