[PATCH] D71374: Improve support of GNU mempcpy

xbolva00 added a comment. Please add a IR codegen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 created this revision. Jac1494 added reviewers: dblaikie, vsk, echristo. Jac1494 added a project: debug-info. Herald added subscribers: cfe-commits, hiraditya, aprantl. Herald added projects: clang, LLVM. Hi Devs, Consider below testcases, $cat shlib.c int var; int test() { return var++

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void updated this revision to Diff 233738. void marked 3 inline comments as done. void added a comment. Use "any_of" and improve tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ https://reviews.llvm.org/D71314 Files: clang/lib/Ana

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void added inline comments. Comment at: clang/test/Analysis/uninit-asm-goto.cpp:16 + if (x < 42) +asm volatile goto("testl %0, %0; testl %1, %2; jne %l3" : "+S"(x), "+D"(y) : "r"(x) :: indirect_1, indirect_2); + else nickdesaulniers wrote: > I wonder if it

[PATCH] D71374: Improve support of GNU mempcpy

Jim added a comment. I am curious what is difference of code generation after applying your changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___ cfe-com

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

No worries, it happens. On Thu, Dec 12, 2019, 10:59 PM Michał Górny wrote: > On Thu, 2019-12-12 at 14:47 -0800, Eric Christopher wrote: > > As a quick note, this broke the test because you didn't update the line > > numbers in the checks. > > > > Fixed thusly: > > > > echristo@athyra ~/r/llvm-pr

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

On Thu, 2019-12-12 at 14:47 -0800, Eric Christopher wrote: > As a quick note, this broke the test because you didn't update the line > numbers in the checks. > > Fixed thusly: > > echristo@athyra ~/r/llvm-project> git push > To github.com:llvm/llvm-project.git >6bed43f3c40..259a9b10390 maste

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1782917 , @ABataev wrote: > In D71241#1782898 , @JonChesterfield > wrote: > > > In D71241#1782846 , @ABataev wrote: > > > > > But I sugg

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1782668 , @ABataev wrote: > In D71241#1782650 , @jdoerfert wrote: > > > While we talk a lot about what you think is bad about this solution it > > seems we ignore the problems i

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71167/new/ https://reviews.llvm.org/D71167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D57732: Correct inf typo

This revision was automatically updated to reflect the committed changes. Closed by commit rG4daa8d1de6dd: Correct inf typo (authored by gaul, committed by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57732/new/ https://reviews.llvm.org/D5773

[clang] 4daa8d1 - Correct inf typo

Author: Andrew Gaul Date: 2019-12-13T11:02:40+08:00 New Revision: 4daa8d1de6dda58aebfa7b19547ed3ce4e9bc91a URL: https://github.com/llvm/llvm-project/commit/4daa8d1de6dda58aebfa7b19547ed3ce4e9bc91a DIFF: https://github.com/llvm/llvm-project/commit/4daa8d1de6dda58aebfa7b19547ed3ce4e9bc91a.diff L

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui added a comment. In D70537#1765607 , @probinson wrote: > I guess first I'm confused about why the type would be undeduced in the first > place, given that it is actually instantiated. > And if undeduced is correct, wouldn't we rather emit t

[PATCH] D57732: Correct inf typo

Jim added a comment. I can commit it for you. If you are interested in obtaining the commit right. you can refer https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57732/new/ https://r

[clang] bc0c60f - Remove extra character I added to test my changes that I forgot to delete before submitting.

Author: Douglas Yung Date: 2019-12-12T18:23:08-08:00 New Revision: bc0c60f714fca54711b806c54467a8ce28c04181 URL: https://github.com/llvm/llvm-project/commit/bc0c60f714fca54711b806c54467a8ce28c04181 DIFF: https://github.com/llvm/llvm-project/commit/bc0c60f714fca54711b806c54467a8ce28c04181.diff

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782898 , @JonChesterfield wrote: > In D71241#1782846 , @ABataev wrote: > > > But I suggest to discuss this with Richard Smith. > > > Is the appeal to authority necessary to resol

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added a comment. In D71240#1782828 , @nridge wrote: > In D71240#1782763 , @thakis wrote: > > > Probably needs the usual -fno-delayed-template-parsing workaround, see > > other clangd tests. > > > Thanks for

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. In D62731#1782897 , @andrew.w.kaylor wrote: > In D62731#1782762 , @rjmccall wrote: > > > Currently we emit a warning if you use `-frounding-math`, saying that the > > option is ignored.

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

andrew.w.kaylor added a comment. In D62731#1782762 , @rjmccall wrote: > Currently we emit a warning if you use `-frounding-math`, saying that the > option is ignored. That should have alerted users that they're not getting > the correct behavior now. T

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. In D71241#1782846 , @ABataev wrote: > But I suggest to discuss this with Richard Smith. Is the appeal to authority necessary to resolve this? The last few posts by Hal look clear to me. Especially convincing is: > We're

[PATCH] D71444: [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to LocateSymbol.Ambiguous

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4f732a3d49ac: [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to… (authored by nridge). Reposit

[clang-tools-extra] 4f732a3 - [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to LocateSymbol.Ambiguous

Author: Nathan Ridge Date: 2019-12-12T20:31:46-05:00 New Revision: 4f732a3d49ace980058bbb12150c8afc499af0ae URL: https://github.com/llvm/llvm-project/commit/4f732a3d49ace980058bbb12150c8afc499af0ae DIFF: https://github.com/llvm/llvm-project/commit/4f732a3d49ace980058bbb12150c8afc499af0ae.diff

[clang] b71475f - Fix test to work correctly on 32-bit platforms.

Author: Douglas Yung Date: 2019-12-12T17:28:06-08:00 New Revision: b71475ff9ae02a8ec8d9841316c9717ef67b2f40 URL: https://github.com/llvm/llvm-project/commit/b71475ff9ae02a8ec8d9841316c9717ef67b2f40 DIFF: https://github.com/llvm/llvm-project/commit/b71475ff9ae02a8ec8d9841316c9717ef67b2f40.diff

[PATCH] D71447: [CIndex] #pragma clang transform

Meinersbur created this revision. Meinersbur added reviewers: abramobagnara, ddunbar, aganea, hfinkel, rjmccall, kbarton, SjoerdMeijer, aaron.ballman, ABataev, fhahn, hsaito, hans, greened, dmgreen, Ayal, asavonic, rtrieu, dorit, rsmith, tyler.nowicki, jdoerfert. Herald added a subscriber: arpham

[PATCH] D71434: [Driver] Use .init_array for all gcc installations and simplify Generic_ELF -fno-use-init-array rules

MaskRay updated this revision to Diff 233721. MaskRay added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71434/new/ https://reviews.llvm.org/D71434 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChains/Fre

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782812 , @hfinkel wrote: > In D71241#1782779 , @ABataev wrote: > > > In D71241#1782742 , @hfinkel wrote: > > > > > In D71241#1782703

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added a comment. In D71240#1782763 , @thakis wrote: > Probably needs the usual -fno-delayed-template-parsing workaround, see other > clangd tests. Thanks for the suggestion! Fix at https://reviews.llvm.org/D71444 Repository: rG LLVM Github Mo

[PATCH] D71444: [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to LocateSymbol.Ambiguous

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71444 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp

[PATCH] D70032: [docs] #pragma clang transform

Meinersbur updated this revision to Diff 233717. Meinersbur added a comment. - Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70032/new/ https://reviews.llvm.org/D70032 Files: clang/docs/LanguageExtensions.rst clang/docs/Pragm

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782779 , @ABataev wrote: > In D71241#1782742 , @hfinkel wrote: > > > In D71241#1782703 , @ABataev wrote: > > > > > > > > > > > ... > > > >

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782723 , @ABataev wrote: > I don't insist on function redefinition solution. You want to replace > functions - fine, but do this at the codegen, not in AST. Again, no one is replacing anything, and we're not mutating

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

eugenis added a comment. Nice cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/ https://reviews.llvm.org/D71408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D69092: [CodeGen] #pragma clang transform

Meinersbur updated this revision to Diff 233713. Meinersbur added a comment. - Remove handling of OpenMP simd and LoopHints by CGTransform Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69092/new/ https://reviews.llvm.org/D69092 Files: clang/lib/

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

thopre updated this revision to Diff 233712. thopre added a comment. Herald added subscribers: Sanitizers, cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, delcypher, niosHD, sabu

[PATCH] D70572: [Serialization] #pragma clang transform

Meinersbur updated this revision to Diff 233714. Meinersbur added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70572/new/ https://reviews.llvm.org/D70572 Files: clang/include/clang/Serialization/ASTBitCodes.h clang/include

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782742 , @hfinkel wrote: > In D71241#1782703 , @ABataev wrote: > > > > > > ... > > >> > >> > >>> Given we have two implementations, each at different points in the

[PATCH] D69091: [Sema] #pragma clang transform

Meinersbur updated this revision to Diff 233707. Meinersbur added a comment. - Remove handling of LoopHints (#pragma clang loop) and OpenMP (#pragma omp simd) to reducethe size of the patches. Compatibility with OpenMP is still a goal (to implement the upcoming OpenMP loop transformations su

[PATCH] D71439: Allow redeclaration of __declspec(uuid)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Seems reasonable, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71439/new/ https://reviews.llvm.org/D71439 __

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Currently we emit a warning if you use `-frounding-math`, saying that the option is ignored. That should have alerted users that they're not getting the correct behavior now. This patch removes the warning and (IIUC) implements the correct behavior but is over-conser

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

thakis added a comment. Tests fail on Windows: http://45.33.8.238/win/3976/step_9.txt Probably needs the usual -fno-delayed-template-parsing workaround, see other clangd tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://revi

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782703 , @ABataev wrote: > ... >> >> >>> Given we have two implementations, each at different points in the >>> pipeline, it might be constructive to each write down why you each >>> choose sai

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

rnk added a comment. Sorry for the delay, overall this seems like the right approach. Comment at: clang/include/clang/AST/Type.h:477-479 + ((isPtrSizeAddressSpace(A) && B == LangAS::Default) || +(isPtrSizeAddressSpace(B) && A == LangAS::Default) || +

[PATCH] D69089: [Parser] #pragma clang transform

Meinersbur updated this revision to Diff 233704. Meinersbur added a comment. - Simplify transformation classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69089/new/ https://reviews.llvm.org/D69089 Files: clang/include/clang/AST/StmtTransform.

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">, andrew.w.kayl

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. I don't insist on function redefinition solution. You want to replace functions - fine, but do this at the codegen, not in AST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71241/new/ https://reviews.llvm.org/D71241 __

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782670 , @hfinkel wrote: > In D71241#1782652 , @ABataev wrote: > > > In D71241#1782648 , @hfinkel wrote: > > > > > In D71241#1782614

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782700 , @hfinkel wrote: > In D71241#1782668 , @ABataev wrote: > > > > > > ... > > >> While we talk a lot about what you think is bad about this solution it > >> seems we ignore

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

rjmccall added inline comments. Comment at: clang/include/clang/AST/ExternalASTSource.h:69 - /// Whether this AST source also provides information for - /// semantic analysis. - bool SemaSource = false; + // LLVM-style RTTI. + static char ID; aprantl wrote

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782668 , @ABataev wrote: > ... >> While we talk a lot about what you think is bad about this solution it seems >> we ignore the problems in the current one. Let me summarize a few: >> >> - Take https://godbolt.org/z

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGecaa9363303e: [clangd] Heuristically resolve dependent method calls (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D71240?vs=233681&id=233698#toc Repository: rG LLVM Github M

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c6c1d0f4371: [clang] [test] Disable the test exhausting stack on NetBSD (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8e0bb3b2c24: [LTO] Support for embedding bitcode section during LTO (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782652 , @ABataev wrote: > In D71241#1782648 , @hfinkel wrote: > > > In D71241#1782614 , @ABataev wrote: > > > > > In D71241#1782551

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782650 , @jdoerfert wrote: > In D71241#1782614 , @ABataev wrote: > > > Actually, early resolution will break tbe tools, not help them. It will > > definitely break clangd, for ex

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1779179 , @awpandey wrote: > @dblaikie . I have removed the redundant test case. What else should I do in > this patch? Please address this warning before committing: /usr/local/google/home/blaikie/dev/llvm/src/cl

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

rjmccall added a comment. Patch looks good, but could you describe this behavior in the ARC documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71431/new/ https://reviews.llvm.org/D71431 ___ c

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 233691. xazax.hun added a comment. - Fix some problems discovered during some real world stress test - Add more tests - The ASCII art is not updated yet, but will do so at some point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https:

[PATCH] D71439: Allow redeclaration of __declspec(uuid)

zahen created this revision. zahen added reviewers: rnk, thakis, hans, zturner. Herald added a project: clang. Herald added a subscriber: cfe-commits. msvc allows a subsequent declaration of a uuid attribute on a struct/class. Mirror this behavior in clang-cl. Repository: rG LLVM Github Mono

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782430 , @JonChesterfield wrote: > In D71241#1782427 , @ABataev wrote: > > > In D71241#1782425 , > > @JonChesterfield wrote: > > > > > >

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782648 , @hfinkel wrote: > In D71241#1782614 , @ABataev wrote: > > > In D71241#1782551 , @hfinkel wrote: > > > > > In D71241#1779168

RE: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

Hi Alexander, I am debugging this now but I assume the checks for the if condition were skipped before this commit (therefore no crash) because ‘c’ was set as type dependent. The checks are probably run now since c’s type dependency changed with this patch. The checks might need to be guarded b

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1782614 , @ABataev wrote: > Actually, early resolution will break tbe tools, not help them. It will > definitely break clangd, for example. The user will try to navigate to > originally called function `base` and inst

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1778671 , @ABataev wrote: > There can be another one issue with this solution with inline assembly. I’m > not completely sure about it, will try to investigate it tomorrow. I suggest > to discuss this solution with Rich

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782614 , @ABataev wrote: > In D71241#1782551 , @hfinkel wrote: > > > In D71241#1779168 , > > @JonChesterfield wrote: > > > > > Lowering i

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

nridge added a comment. In D71345#1781141 , @sammccall wrote: > How do you feel about the approach here? I agree that having more of the logic centralized (in `SelectionTree`) is preferable to having it directly in a call site like `getDeclAtPosition`.

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added a comment. In D68520#1782387 , @tstellar wrote: > After thinking about this more, do we want to even try to support the > BUILD_SHARED=ON + CLANG_LINK_CLANG_DYLIB=ON configuration? We don't support > this in llvm. Actually, even if we d

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 233687. sidneym added a comment. Herald added a project: LLVM. make check for lld more generic. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/ https://reviews.llvm.org/D70919 Files: clang/lib/Driver/ToolChains/Hex

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782551 , @hfinkel wrote: > In D71241#1779168 , @JonChesterfield > wrote: > > > Lowering in sema or in codegen seems a standard phase ordering choice. > > There will be pros and

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

As a quick note, this broke the test because you didn't update the line numbers in the checks. Fixed thusly: echristo@athyra ~/r/llvm-project> git push To github.com:llvm/llvm-project.git 6bed43f3c40..259a9b10390 master -> master :) -eric On Thu, Dec 12, 2019 at 12:25 PM Petr Hosek via Pha

[clang] 259a9b1 - Update line number after previous patch added an additional unsupported

Author: Eric Christopher Date: 2019-12-12T14:45:05-08:00 New Revision: 259a9b1039093a1d036c1e6efcae699873f93ba5 URL: https://github.com/llvm/llvm-project/commit/259a9b1039093a1d036c1e6efcae699873f93ba5 DIFF: https://github.com/llvm/llvm-project/commit/259a9b1039093a1d036c1e6efcae699873f93ba5.di

[PATCH] D71434: [Driver] Use .init_array for all gcc installations and simplify Generic_ELF -fno-use-init-array rules

rnk added a comment. I think we should do this, but let's add a release note for it. There's a flag, so users always have a workaround if clang starts doing the wrong thing for them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71434/new/ https:

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782504 , @jdoerfert wrote: > In D71241#1782460 , @JonChesterfield > wrote: > > > > https://clang.llvm.org/docs/InternalsManual.html#the-ast-library > > > > > > Faithfulness¶ >

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1779779 , @ABataev wrote: > Here is the example that does not work with the proposed solution but works > with the existing one: > > static void cpu() { asm("nop"); } > > #pragma omp declare variant(cpu) match(devi

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782460 , @JonChesterfield wrote: > > https://clang.llvm.org/docs/InternalsManual.html#the-ast-library > > > > Faithfulness¶ > > The AST intends to provide a representation of the program that is > > faithful to th

[clang-tools-extra] ecaa936 - [clangd] Heuristically resolve dependent method calls

Author: Nathan Ridge Date: 2019-12-12T17:18:00-05:00 New Revision: ecaa9363303e811a051ebb6199e35e43319a699c URL: https://github.com/llvm/llvm-project/commit/ecaa9363303e811a051ebb6199e35e43319a699c DIFF: https://github.com/llvm/llvm-project/commit/ecaa9363303e811a051ebb6199e35e43319a699c.diff

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:278 +}); +for (const NamedDecl *D : Decls) { + Outer.add(D, Flags); sammccall wrote: > sammccall wrote: > > can we make this function return the decls,

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 233681. nridge marked an inline comment as done. nridge added a comment. Fix a typo and address one remaining comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Fil

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge updated this revision to Diff 233680. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/ https://reviews.llvm.org/D71240 Files: clang-tools-ext

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1779168 , @JonChesterfield wrote: > Lowering in sema or in codegen seems a standard phase ordering choice. There > will be pros and cons to both. > > I think prior art leans towards sema. Variants are loosely equivalent

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

lhames added a comment. Side note: This https://reviews.llvm.org/D39111 seems related. The patch has languished as I have been busy with other work, but if it would be useful for you guys I'd be happy to try to land it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D71428: [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES

smeenai added reviewers: beanz, phosek, compnerd, smeenai. smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71428/new/ https://reviews.llvm.

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added a comment. `unique_ptr` is harder to get to work than it might appear at first blush :) Looking at the gcc 6 libstdc++ implementation as an example: the declared return type is not `T*`, but `unique_ptr::pointer`. The declaration of that is in turn: typedef typename _Pointer::ty

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1782460 , @JonChesterfield wrote: > > https://clang.llvm.org/docs/InternalsManual.html#the-ast-library > > > > Faithfulness¶ > > The AST intends to provide a representation of the program that is > > faithful to

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

andrew.w.kaylor added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">, rupprec

[PATCH] D71434: [Driver] Use .init_array for all gcc installations and simplify Generic_ELF -fno-use-init-array rules

MaskRay created this revision. MaskRay added reviewers: echristo, rnk, thakis. Herald added subscribers: cfe-commits, s.egerton, simoncook, fedor.sergeev, krytarowski, emaste, dschuff. Herald added a project: clang. D39317 made clang use .init_array when no gcc

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

martong updated this revision to Diff 233675. martong marked 4 inline comments as done. martong added a comment. Addressing Alexeis comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020 Files: clang/l

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:334 + FromDC->lookup(FromNamed->getDeclName()); + if (std::find(FromLookup.begin(), FromLookup.end(), FromNamed) != + FromLookup.end()) a_sidorin wrote: >

[PATCH] D71433: [analyzer] CERT: POS34-C

zukatsinadze created this revision. zukatsinadze added a reviewer: NoQ. zukatsinadze added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. This patch introduces a new checker: `alpha

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. > https://clang.llvm.org/docs/InternalsManual.html#the-ast-library > > Faithfulness¶ > The AST intends to provide a representation of the program that is faithful > to the original source. That's pretty convincing. Repository: rG LLVM Github Monorepo C

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

george.burgess.iv added a comment. Just a few more nits, and this LGTM. Thanks again! IDK if Eli wanted to have another look at this; please wait until tomorrow before landing to give him time to comment. Comment at: clang/lib/AST/Decl.cpp:3006 +bool FunctionDecl::isInlineB

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

martong marked an inline comment as done. martong added a comment. > Are you going to add any tests in the following patches? I don't have any tests for now, but in a later patch we can create them. Comment at: clang/lib/AST/ASTImporter.cpp:8043 + + Error VisitFunctionTypeLoc

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782430 , @JonChesterfield wrote: > In D71241#1782427 , @ABataev wrote: > > > In D71241#1782425 , > > @JonChesterfield wrote: > > > > > >

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. In D71241#1782427 , @ABataev wrote: > In D71241#1782425 , @JonChesterfield > wrote: > > > > Explain that you're replacing the function written by the user on the fly > > > by anoth

[clang] 5ad5258 - [OPENMP50]Fix possible conflict when emitting an alias for the functions

Author: Alexey Bataev Date: 2019-12-12T15:48:33-05:00 New Revision: 5ad52587ec182f03636649e2cb66a0a4d9ffeab2 URL: https://github.com/llvm/llvm-project/commit/5ad52587ec182f03636649e2cb66a0a4d9ffeab2 DIFF: https://github.com/llvm/llvm-project/commit/5ad52587ec182f03636649e2cb66a0a4d9ffeab2.diff

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782425 , @JonChesterfield wrote: > > Explain that you're replacing the function written by the user on the fly > > by another one. If they accept it, go ahead. > > That's the observational effect of variants. Replacing

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. > Explain that you're replacing the function written by the user on the fly by > another one. If they accept it, go ahead. That's the observational effect of variants. Replacing is very similar to calling + inlining. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">, mibintc wrote

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

ahatanak created this revision. ahatanak added reviewers: rjmccall, arphaman. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. Copy the block to the heap before passing it to the callee in case the block escapes in the callee. rdar://problem/55683462 Re

[clang] c8e0bb3 - [LTO] Support for embedding bitcode section during LTO

Author: Teresa Johnson Date: 2019-12-12T12:34:19-08:00 New Revision: c8e0bb3b2c24ef59556d81a275fb1f5db64899d3 URL: https://github.com/llvm/llvm-project/commit/c8e0bb3b2c24ef59556d81a275fb1f5db64899d3 DIFF: https://github.com/llvm/llvm-project/commit/c8e0bb3b2c24ef59556d81a275fb1f5db64899d3.diff

[clang] 0ee89c1 - [OPENMP50]Improve checks for declare variant functions compatibility.

Author: Alexey Bataev Date: 2019-12-12T15:18:19-05:00 New Revision: 0ee89c1bad8cef81725ef892d60b4aa254d84744 URL: https://github.com/llvm/llvm-project/commit/0ee89c1bad8cef81725ef892d60b4aa254d84744 DIFF: https://github.com/llvm/llvm-project/commit/0ee89c1bad8cef81725ef892d60b4aa254d84744.diff

  1   2   3   >