[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a comment. In D70157#1772019 , @reames wrote: > In D70157#1771841 , @jyknight wrote: > > > In D70157#1771832 , @reames wrote: > > > > > I've been digging throug

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c2b2b9e20ab: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Git

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

Charusso added a comment. I would change the order of CCh and scan-build because we usually list stuff in alphabetical order. Also the chronological order is that, the newest is the first. Comment at: clang/www/analyzer/command-line.html:54 +Can run clang-tidy checkers to

[PATCH] D69088: [Lex] #pragma clang transform

rjmccall added a comment. This is a major new language feature, and code review is probably not the right venue for reviewing it; there should be a thread on cfe-dev. My apologies if that's already been discussed and I missed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

rjmccall added a comment. Richard is definitely our main expert in the implicit synthesis of special members. It seems to me that if we need the destructor declaration at some point, we should be forcing it to exist at that point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/ne

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder updated this revision to Diff 232491. MadCoder edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/lib/Sema/SemaDeclObjC.cpp clang/test/CodeGenObjC/direct

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added a comment. oh hah, thanks :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc added inline comments. Comment at: clang/test/OpenMP/target_messages.cpp:4 + +// RUN: not %clang_cc1 -fopenmp -std=c++11 -fopenmp-targets=aaa-bbb-ccc-ddd -o - %s 2>&1 | FileCheck %s // CHECK: error: OpenMP target is invalid: 'aaa-bbb-ccc-ddd' ABataev w

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

dblaikie added a comment. @rsmith - thanks for looking at this. I'd looked at it a bit and I was/am still wondering whether there's a way to coalesce these codepaths between PCH and the existing modular code generation support? But if you're good with it, that's certainly good enough for me.

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1771709 , @probinson wrote: > In D70524#1771522 , @shafik wrote: > > > @probinson I was reading the C++ "auto" return type > >

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

dyung added a comment. This change caused the Import/namespace/struct-and-var/test.cpp test to fail on ARM due to an extra line with `-CXXRecordDecl being emitted by the compiler that was being matched instead of the intended line. I checked in a fix to tighten up the check a little more so tha

[clang] 7599095 - Fix crash if a user-defined conversion is applied in the middle of a

Author: Richard Smith Date: 2019-12-05T18:44:15-08:00 New Revision: 759909506c2b557b9bc5cd3883970dea48e0b86b URL: https://github.com/llvm/llvm-project/commit/759909506c2b557b9bc5cd3883970dea48e0b86b DIFF: https://github.com/llvm/llvm-project/commit/759909506c2b557b9bc5cd3883970dea48e0b86b.diff

[clang] 757bc55 - Tighten up CHECK lines added in a9f10ebffa to work on ARM.

Author: Douglas Yung Date: 2019-12-05T18:35:08-08:00 New Revision: 757bc55f8314c8c789f81b7f0b3397a8c6148b68 URL: https://github.com/llvm/llvm-project/commit/757bc55f8314c8c789f81b7f0b3397a8c6148b68 DIFF: https://github.com/llvm/llvm-project/commit/757bc55f8314c8c789f81b7f0b3397a8c6148b68.diff

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

ABataev added inline comments. Comment at: clang/test/OpenMP/target_messages.cpp:4 + +// RUN: not %clang_cc1 -fopenmp -std=c++11 -fopenmp-targets=aaa-bbb-ccc-ddd -o - %s 2>&1 | FileCheck %s // CHECK: error: OpenMP target is invalid: 'aaa-bbb-ccc-ddd' Why do you

[PATCH] D66437: Sema: Create a no-op implicit cast for lvalue function conversions.

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4745 + else if (FunctionConversion) +Sequence.AddQualificationConversionStep(cv1T1, VK_LValue); Is this a qualification conversion though? The standard lists it "function

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc added a comment. Pinging reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

aaronpuchert abandoned this revision. aaronpuchert added a comment. Already fixed via D66437 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

dmajor added a comment. In D65761#1772031 , @rnk wrote: > I think `-fcf-protection` and `__attribute__((nocf_check))` have to do with > CET and Intel's endbranch instruction or what have you. Similar goals, > different implementation. I think at this poi

[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Hoisting this to ASTContext and using it where needed seems like the logical thing to do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68627/new/ https://reviews.llvm.org/D68627

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese updated this revision to Diff 232484. Bigcheese marked an inline comment as done. Bigcheese added a comment. Herald added a subscriber: mgrang. - Remove duplicate decl - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ ht

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File); arphaman wrote: > Bigcheese wrote: > > arpham

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese updated this revision to Diff 232483. Bigcheese marked 2 inline comments as done. Bigcheese added a comment. - Removed `OutputPaths`. - Add documentation for `AlreadySeen`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

rnk added a comment. In D65761#1766993 , @dmajor wrote: > Are there any plans to implement `__declspec(guard(nocf))` or an equivalent > mechanism? `__attribute__((nocf_check))` doesn't do anything without the > -fcf-protection flag. (https://bugs.llvm.or

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

NoQ added inline comments. Comment at: clang/www/analyzer/codechecker.html:13 + + + martong wrote: > NoQ wrote: > > Note related to your patch, but SSI seem to be completely broken these > > days; previously the dropdown menus header kept working on the front pa

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:201 +std::tie(StateRetNotNull, StateRetNull) = +CM.assumeDual(StateStreamNull, RetVal); +if (StateRetNull) { baloghadamsoftware wrote: > balazske wrote: > >

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. In D70157#1771841 , @jyknight wrote: > In D70157#1771832 , @reames wrote: > > > I've been digging through the code for this for the last day or so. This > > is a new area for me, so it's po

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. @MyDeveloperDay Anything I'll need to do on my end to start the landing process? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 ___ c

[clang] 6470497 - Revert "[AST] Traverse the class type loc inside the member type loc."

Author: Sterling Augustine Date: 2019-12-05T16:48:18-08:00 New Revision: 6470497817eafe3fe2d15e11ade78fd99753d7ca URL: https://github.com/llvm/llvm-project/commit/6470497817eafe3fe2d15e11ade78fd99753d7ca DIFF: https://github.com/llvm/llvm-project/commit/6470497817eafe3fe2d15e11ade78fd99753d7ca.

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

ormris added a comment. I've done testing with the following global parameters. - The base for the branch is llvmorg-10-init-8655-g94a4a2c97f8 - Used llvm, clang, lld, and llvm-ar from this branch. - The sqlite kvtest program was the test payload. This test compared an unmodified compiler from t

[PATCH] D71098: Handle two corner cases in creduce-clang-crash.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f822f212cde: Handle two corner cases in creduce-clang-crash.py (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71098/new/ https://reviews.

[clang] 1f822f2 - Handle two corner cases in creduce-clang-crash.py

Author: Reid Kleckner Date: 2019-12-05T16:24:24-08:00 New Revision: 1f822f212cde1ad9099cf45af0652a83380de772 URL: https://github.com/llvm/llvm-project/commit/1f822f212cde1ad9099cf45af0652a83380de772 DIFF: https://github.com/llvm/llvm-project/commit/1f822f212cde1ad9099cf45af0652a83380de772.diff

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

saugustine added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1169 DEF_TRAVERSE_TYPELOC(MemberPointerType, { - TRY_TO(TraverseType(QualType(TL.getTypePtr()->getClass(), 0))); + if (auto *TSI = TL.getClassTInfo()) +TRY_TO(TraverseTypeLoc(TSI->g

[PATCH] D71098: Handle two corner cases in creduce-clang-crash.py

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71098/new/ https://reviews.llvm.org/D71098 _

[PATCH] D71098: Handle two corner cases in creduce-clang-crash.py

rnk created this revision. rnk added a reviewer: akhuang. Herald added a project: clang. First, call os.path.normpath on the filename argument. I passed in ./foo-asdf.cpp, and this meant that the script failed to find the filename, and bad things happened. Second, call os.path.abspath on binaries

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman added a comment. @MadCoder Indexing by names doesn't seem like the right solution. You should be able to get the canonical declaration (`getCanonicalDecl`) from the declaration that represents the method in @implementation, which should avoid the problem you're describing. CHANGES SI

[clang] e7c2466 - [Concepts] Fix build failures in D41569

Author: Saar Raz Date: 2019-12-06T01:53:18+02:00 New Revision: e7c24667816edc1a3754b46a49f9eac011dc1fee URL: https://github.com/llvm/llvm-project/commit/e7c24667816edc1a3754b46a49f9eac011dc1fee DIFF: https://github.com/llvm/llvm-project/commit/e7c24667816edc1a3754b46a49f9eac011dc1fee.diff LOG:

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a subscriber: opaparo. MaskRay added a comment. In D70157#1771841 , @jyknight wrote: > In D70157#1771832 , @reames wrote: > > > I've been digging through the code for this for the last day or so. This

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder updated this revision to Diff 232460. MadCoder added a comment. Fix the fact that the hashmap of direct method was indexed by Declarations instead of names (and depending on code ordering, the declaration used at codegen time may be the one from the @interface or from the @implementatio

[clang] fdf80e8 - [Concepts] Constraint Enforcement & Diagnostics

Author: Saar Raz Date: 2019-12-06T01:34:20+02:00 New Revision: fdf80e86a52849813d05da4b6c25884c06ba9e98 URL: https://github.com/llvm/llvm-project/commit/fdf80e86a52849813d05da4b6c25884c06ba9e98 DIFF: https://github.com/llvm/llvm-project/commit/fdf80e86a52849813d05da4b6c25884c06ba9e98.diff LOG:

[PATCH] D70157: Align branches within 32-Byte boundary

jyknight added a comment. In D70157#1771832 , @reames wrote: > I've been digging through the code for this for the last day or so. This is > a new area for me, so it's possible I'm off base, but I have some concerns > about the current design. > > First

[PATCH] D70701: Fix more VFS tests on Windows

rnk added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1077-1078 +std::error_code RedirectingFileSystem::makeAbsolute(SmallVectorImpl &Path) const { + if (llvm::sys::path::is_absolute(Path, llvm::sys::path::Style::posix) || + llvm::sys::path::is_abso

[PATCH] D71092: [VFS] Use path canonicalization on all paths

rnk added a comment. I would add, take a look at the existing unit tests (llvm/unittests/Support/VirtualFileSystemTests.cpp) and audit for _WIN32 ifdefs that we can remove after this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 __

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. I've been digging through the code for this for the last day or so. This is a new area for me, so it's possible I'm off base, but I have some concerns about the current design. First, there appears to already be support for instruction bundling and alignment in the ass

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

mstorsjo added a comment. In D69950#1771515 , @rnk wrote: > I fixed this particular code upstream: > https://github.com/KhronosGroup/glslang/pull/2010 > I am not enough an expert to be sure, but I suspect this is in the area of > "invalid, no diagnostic

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

krytarowski added inline comments. Comment at: compiler-rt/test/sanitizer_common/netbsd_commands/run_noaslr.sh:4 +PATH=${PATH}:/usr/sbin +paxctl +a "${1}" +exec "${@}" eugenis wrote: > krytarowski wrote: > > I propose to use `/usr/bin/paxctl` as it will be PATH a

[PATCH] D71092: [VFS] Use path canonicalization on all paths

amccarth planned changes to this revision. amccarth added a comment. Hold off on this one. It needs an explicit test for canonicalization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 ___ cfe-com

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

saar.raz added a comment. Addressed in latest diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41910/new/ https://reviews.llvm.org/D41910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 232450. Tyker marked 14 inline comments as done. Tyker added a comment. comments were fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/St

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

saar.raz updated this revision to Diff 232457. saar.raz marked 7 inline comments as done. saar.raz added a comment. Address all CR comments by rsmith (including rewrite of normalization). Decided to not support things like: template concept C = ...; template requires C struct S { }; For now, as

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13618 + if (InPlace) { +LValue LVal; +if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || rsmith wrote: > This isn't sufficient: the evaluation process can refer back to the obje

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu added a comment. Did you mean the linkage issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. It's a bit weird for this to be controlled by a `-fmodules` flag, but it's only a `-cc1` flag, so I'm OK with that; we can rename it if/when we expose it from the driver. Repository: rC Cl

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. We uncovered another functional issue with this patch, or at least, the interaction of this patch and other parts of LLVM. In our support for STATEPOINT, PATCHPOINT, and STACKMAP we use N-byte nop sequences for regions of code which might be patched out. It's important

[PATCH] D71092: [VFS] Use path canonicalization on all paths

amccarth created this revision. amccarth added reviewers: rnk, vsapsai, arphaman. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. The virtual file system had an option to eliminate dots from paths (e.g., `/foo/./bar` -> `/foo/bar`). Because of differe

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

plotfi updated this revision to Diff 232455. plotfi added a comment. Updating comments and altering test as per @cishida and @compnerd's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70763/new/ https://reviews.llvm.org/D70763 Files: cla

[PATCH] D70763: [clang][IFS] Allow 2 output files when using -o and -c with clang IFS stubs.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/test/InterfaceStubs/driver-test3.c:6 +// RUN: %clang -target x86_64-unknown-linux-gnu -c -emit-interface-stubs %s -o %t/driver-test3.o +// RUN: cat %t/driver-test3.ifs | FileCheck %s + -

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added a comment. hmm wait I have an old problem I had fixed creep up again :'( need to fix it again sigh. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091

[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: llvm/test/MC/WebAssembly/import-module.s:13 + .import_module foo, bar + .import_name foo, qux + sbc100 wrote: > dschuff wrote: > > What should happen if there's a directive tha

[clang] b220662 - Properly convert all declaration non-type template arguments when

Author: Richard Smith Date: 2019-12-05T14:32:36-08:00 New Revision: b220662a45c8067a2ae485ae34c1138d93506df9 URL: https://github.com/llvm/llvm-project/commit/b220662a45c8067a2ae485ae34c1138d93506df9 DIFF: https://github.com/llvm/llvm-project/commit/b220662a45c8067a2ae485ae34c1138d93506df9.diff

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_c

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added a comment. turns out that I had no codegen check for the call site and that one of the last iteration broke it trivially :'( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 ___

[PATCH] D70157: Align branches within 32-Byte boundary

fedor.sergeev added a comment. In D70157#1768310 , @skan wrote: > fix the bug > > https://bugs.llvm.org/show_bug.cgi?id=44215 FYI: I did close the bug as fixed after verifying that the fix works for me. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder created this revision. MadCoder added reviewers: rjmccall, arphaman, dexonsmith. MadCoder added a project: clang. Herald added a subscriber: cfe-commits. MadCoder added a comment. turns out that I had no codegen check for the call site and that one of the last iteration broke it triviall

[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: llvm/test/MC/WebAssembly/import-module.s:13 + .import_module foo, bar + .import_name foo, qux + dschuff wrote: > What should happen if there's a directive that refers to a symb

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen added a comment. In D70615#1770550 , @hans wrote: > Seems fine to me. I'm not sure how to test the actual "don't write to temp > file" functionality, but at least there could be a test to check that the > flag gets forwarded to cc1. Added a best

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:301 +// So the value in some sense escaped our analysis. +zx_handle_close(sa); + } else xazax.hun wrote: > This is also nasty. Cf.: ```lang=c++ int *x = malloc(sizeof(int)); if

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: compiler-rt/test/sanitizer_common/netbsd_commands/run_noaslr.sh:4 +PATH=${PATH}:/usr/sbin +paxctl +a "${1}" +exec "${@}" krytarowski wrote

[PATCH] D70836: [analysis] Fix value tracking for pointers to qualified types

NoQ accepted this revision. NoQ edited reviewers, added: NoQ; removed: dergachev.a. NoQ added a comment. Thanks!! This definitely doesn't sort out all the problems of this kind, but that's a strict improvement. Do you have commit access? Or i could commit for you. Comment at:

[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary templateFixes https://github.com/clangd/clangd/issues/212.

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71090 Files: clang-tools-extr

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added a comment. In D70524#1771522 , @shafik wrote: > @probinson I was reading the C++ "auto" return type > issue and I can't come up > with a case where we don't have class descriptions across

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_c

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen updated this revision to Diff 232442. zahen added a comment. Fixed patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 Files: clang/include/clang/Driver/Options.td clang/include/clang/Frontend/FrontendOptions.h clang/lib/Driver/Too

[clang] 338588d - Debug Info: Apply a default location for cleanups if none is available.

Author: Adrian Prantl Date: 2019-12-05T13:30:23-08:00 New Revision: 338588d7cf1865f2095f5961b73cfb533bc535c4 URL: https://github.com/llvm/llvm-project/commit/338588d7cf1865f2095f5961b73cfb533bc535c4 DIFF: https://github.com/llvm/llvm-project/commit/338588d7cf1865f2095f5961b73cfb533bc535c4.diff

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen updated this revision to Diff 232441. zahen added a comment. Updated with review feedback and formatting fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/CompilerInst

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

george.burgess.iv added a comment. Thanks for looking into this! I dunno what implications this has elsewhere, but I'd like to note a few things about this general approach: - AIUI, this'll only work for FORTIFY functions which are literally calling `__builtin___foo_chk`; an equivalent impleme

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

rnk added a comment. I'd be fine with the cmake var and the env var and no driver flag. I think clang developers on Darwin probably want the single-process `clang -c` behavior (that's how I interpreted what Duncan said), even though Apple as a distributor of clang wants the multi-process behavi

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

vsk added a comment. This is causing a failure in debuginfo-tests: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4450/testReport/junit/debuginfo-tests/llgdb-tests/block_var_m/ Assertion failed: (EndLoc.isValid() && "no location for inlineable cleanup calls") Repository: rG LLVM Gi

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rGce7d35988d1c: Debug Info: Assert that location is available for cleanups (authored by aprantl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D71042?vs=232431&id=23243

[PATCH] D71084: Set a source location for Objective-C accessor stubs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1a9aa17b4db: Set a source location for Objective-C accessor stubs even when there is no… (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] ce7d359 - Debug Info: Assert that location is available for cleanups

Author: Adrian Prantl Date: 2019-12-05T12:45:10-08:00 New Revision: ce7d35988d1ca5e17758283804ea1f76389dc1f0 URL: https://github.com/llvm/llvm-project/commit/ce7d35988d1ca5e17758283804ea1f76389dc1f0 DIFF: https://github.com/llvm/llvm-project/commit/ce7d35988d1ca5e17758283804ea1f76389dc1f0.diff

[clang] a1a9aa1 - Set a source location for Objective-C accessor stubs

Author: Adrian Prantl Date: 2019-12-05T12:45:10-08:00 New Revision: a1a9aa17b4db08937e458cdda85327b9eff307df URL: https://github.com/llvm/llvm-project/commit/a1a9aa17b4db08937e458cdda85327b9eff307df DIFF: https://github.com/llvm/llvm-project/commit/a1a9aa17b4db08937e458cdda85327b9eff307df.diff

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:384 + else +assert(EndLoc.isValid() && "no location for inlineable cleanup calls"); +} vsk wrote: > The braces around the `

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

vsk added inline comments. Comment at: clang/test/CodeGenObjCXX/synthesized-property-cleanup.mm:16 + +// [[LOC]] = !DILocation(line: 0 + Heads-up: this location should be different once https://reviews.llvm.org/D71084 lands, which I assume this depends on. CHA

[PATCH] D71084: Set a source location for Objective-C accessor stubs

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71084/new/ https://reviews.llvm.org/D71084 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm with a minor change. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:384 + else +assert(EndLoc.isValid() && "no location for inlineable cleanup calls");

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D61842: [clangd] [WIP] [Not ready for review] Semantic highlighting

nridge abandoned this revision. nridge added a comment. Herald added a subscriber: usaxena95. Abandoning as all of the functionality in this prototype is now present in mainline (except for the ability to color declarations differently from references, which is blocked on a spec change as discus

[PATCH] D71042: [DebugInfo] Ensure fallback artificial location is available for cleanups

aprantl updated this revision to Diff 232431. aprantl added a comment. Updated patch to assert a valid EndLoc and actually pass it in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71042/new/ https://reviews.llvm.org/D71042 Files: clang/lib/CodeGen/CGObjC.cpp clang/lib/CodeGen/Code

[PATCH] D71084: Set a source location for Objective-C accessor stubs

aprantl added a comment. In D71084#1771501 , @vsk wrote: > Shall we add in the assert we discussed in CFG::FinishFunction, as an > additional test? Done over in https://reviews.llvm.org/D71042 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7108

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

arphaman added a comment. The environment variable should be enough IMHO CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

aaron.ballman added a comment. In D71005#1771513 , @saugustine wrote: > When I try to run tablegen on this file for clang/docs (as described in > clang/docs/InternalsManual.rst), I get an error, introduced by this change: > > $ ./bin/clang-tblgen -gen-att

[clang] f5193d8 - Add documentation headings for the OpenCL attributes.

Author: Aaron Ballman Date: 2019-12-05T15:12:01-05:00 New Revision: f5193d87feaedb411255e92979abd6b62522bc38 URL: https://github.com/llvm/llvm-project/commit/f5193d87feaedb411255e92979abd6b62522bc38 DIFF: https://github.com/llvm/llvm-project/commit/f5193d87feaedb411255e92979abd6b62522bc38.diff

[PATCH] D69779: -fmodules-codegen should not emit extern templates

llunak added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69779/new/ https://reviews.llvm.org/D69779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69778/new/ https://reviews.llvm.org/D69778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 232425. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. test case updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D7108

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. @dblaikie I consolidated test cases as you suggested. Along the way, I also added some more tests. I already answered some of your questions earlier. Please let me know what you think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

  1   2   3   >