[PATCH] D69792: [NFC] Supress GCC "Bitfield too small to hold all values of enum" warning.

xbolva00 added a comment. Can you please land it? These warnings are quite annoying. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69792/new/ https://reviews.llvm.org/D69792 ___ cfe-commits mailing lis

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70041 Files: clang-tools-extra/clangd/clients/clangd-vscode/package.json clang-tools-ex

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc updated this revision to Diff 228558. poelmanc added a comment. I just rebased this patch on the latest master. I believe I've addressed all the comments raised so far. Should I add mention of this change to the release notes? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST A

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc added a comment. In D69238#1739627 , @NoQ wrote: > Clang's `-ast-dump` > . Wow. That makes this so much easier... Thank you so much! Looking at the AST showed that the `CXXConstructEx

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm marked an inline comment as done. arsenm added a comment. In D69598#1739655 , @andrew.w.kaylor wrote: > I'm unclear as to the expectations surrounding this option. I suppose this is > somewhat beyond the scope of the current changes, but I'm confu

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc updated this revision to Diff 228556. poelmanc edited the summary of this revision. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69238/new/ https://reviews.llvm.org/D69238 Files: clang-tools-extra/clang-tidy/readability/RedundantStringIni

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. Great. Looks like inner propagation fix was straighforward. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69759/new/ https://reviews.llvm.org/

[PATCH] D67932: [analyzer] Fix accidentally skipping the call during inlined defensive check suppression.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4da37e8a0a3: [analyzer] Fix skipping the call during inlined defensive check suppression. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D67932?vs=221408&id=228552#toc Re

[clang] e4da37e - [analyzer] Fix skipping the call during inlined defensive check suppression.

Author: Artem Dergachev Date: 2019-11-08T18:27:14-08:00 New Revision: e4da37e8a0a3197baca674d683cb05341c6a4097 URL: https://github.com/llvm/llvm-project/commit/e4da37e8a0a3197baca674d683cb05341c6a4097 DIFF: https://github.com/llvm/llvm-project/commit/e4da37e8a0a3197baca674d683cb05341c6a4097.dif

[clang] 57adc37 - [analyzer] Nullability: Don't infer nullable when passing as nullable parameter.

Author: Artem Dergachev Date: 2019-11-08T18:27:14-08:00 New Revision: 57adc37fe57c6edabc006e6de41523319e874c65 URL: https://github.com/llvm/llvm-project/commit/57adc37fe57c6edabc006e6de41523319e874c65 DIFF: https://github.com/llvm/llvm-project/commit/57adc37fe57c6edabc006e6de41523319e874c65.dif

[clang] 1257146 - [clang][IFS][test] Fixing buildbot test fails for clang-ifs.

Author: Puyan Lotfi Date: 2019-11-08T21:06:23-05:00 New Revision: 1257146eb41485e91cb13a6b0ccc2fb7faa68b75 URL: https://github.com/llvm/llvm-project/commit/1257146eb41485e91cb13a6b0ccc2fb7faa68b75 DIFF: https://github.com/llvm/llvm-project/commit/1257146eb41485e91cb13a6b0ccc2fb7faa68b75.diff L

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

leonardchan added a comment. Yup, a bisect shows it was this patch that caused it. I filed a bug for tracking at https://bugs.llvm.org/show_bug.cgi?id=43950 and attached a reproducer. Could you look into this? Thanks. Comment at: clang/lib/Sema/SemaExpr.cpp:487 +const Lan

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc added a comment. In D69145#1725026 , @malcolm.parsons wrote: > I like that this check warns about copy constructors that don't copy. > The warning can be suppressed with a NOLINT comment if not copying is > intentional. Thanks for the comment

[PATCH] D69995: [clang][IFS] Adding support for processing more decl types in clang interface stubs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG79e345fbcc82: [clang][IFS] Adds support for more decl types in clang interface stubs. (authored by plotfi). Changed prior to commit: https://reviews.llvm.org/D69995?vs=228383&id=228551#toc Repository:

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

rjmccall added a comment. In D69991#1739456 , @aprantl wrote: > Why doesn't this need an update in lib/Serialization, is there generic code > that handles all attributes? The serialization logic for attributes is tblgen'ed from Attr.td. Repository:

[clang] 79e345f - [clang][IFS] Adds support for more decl types in clang interface stubs.

Author: Puyan Lotfi Date: 2019-11-08T20:27:25-05:00 New Revision: 79e345fbcc822e914fac4838dd7a4f2ddbb5fcad URL: https://github.com/llvm/llvm-project/commit/79e345fbcc822e914fac4838dd7a4f2ddbb5fcad DIFF: https://github.com/llvm/llvm-project/commit/79e345fbcc822e914fac4838dd7a4f2ddbb5fcad.diff L

[PATCH] D69598: Work on cleaning up denormal mode handling

andrew.w.kaylor added a comment. I'm unclear as to the expectations surrounding this option. I suppose this is somewhat beyond the scope of the current changes, but I'm confused by clang's current behavior with regard to denormals. The -fdenromal-fp-math option causes a function attribute to be

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

leonardchan added a comment. Hi. I have a suspicion this patch is causing a segfault for us when building zircon: https://ci.chromium.org/p/fuchsia/builders/ci/fuchsia-x64-debug-clang/b8897388724384628544 I'm almost done with a bisect and will provide a reproducer if this is the case. Just rai

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman updated this revision to Diff 228548. arphaman marked 2 inline comments as done. arphaman retitled this revision from "[WIP][clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros" to "[clangd] Add a tweak refactoring to wrap Objective-C string

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

NoQ added a comment. In D69238#1739618 , @poelmanc wrote: > Is there a tool to print the AST? That would show whether the AST already has > some expression with the right SourceRange. Clang's `-ast-dump`

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc added a comment. In D69238#1739429 , @gribozavr2 wrote: > If it is indeed the extra AST node for the elidable constructor, see if you > can use the `ignoringElidableConstructorCall` AST matcher to ignore it, > therefore smoothing over AST differ

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

poelmanc updated this revision to Diff 228541. poelmanc edited the summary of this revision. poelmanc added a comment. Now allows namespaces on types and defaults to `::std::basic_string` as requested. The code uses namespaced string type names to check types, and uses non-namespaced string type

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song updated this revision to Diff 228538. yonghong-song edited the summary of this revision. yonghong-song added a comment. handle forward declaration correctly, i.e., not losing its attribute/action. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D70032: [docs] #pragma clang transform

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, kbarton, SjoerdMeijer, aaron.ballman, ABataev, fhahn, hsaito, hans, greened, dmgreen, Ayal, asavonic, rtrieu, dorit, rsmith, tyler.nowicki, jdoerfert. Herald added a subscriber: arphaman. Herald added a project: clang. Meiners

RE: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Thanks! LGTM > -Original Message- > From: jkor...@apple.com > Sent: Friday, November 8, 2019 3:33 PM > To: Voss, Matthew > Cc: Jan Korous ; cfe-commits@lists.llvm.org; > jeremy.morse.l...@gmail.com > Subject: Re: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a > dependency in c

Re: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Yes, sorry, I messed up when relanding the patch. Seems fixed now. > On Nov 8, 2019, at 2:24 PM, Voss, Matthew wrote: > > Hi Jan, > > Thanks for looking at this. I'm seeing new errors on the PS4 windows bot. > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/build

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

This revision was automatically updated to reflect the committed changes. Closed by commit rG901cc4a4bc52: Debug Info: Nest Objective-C property function decls inside their container. (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 901cc4a - Debug Info: Nest Objective-C property function decls inside their container.

Author: Adrian Prantl Date: 2019-11-08T15:14:00-08:00 New Revision: 901cc4a4bc5257d100338e6c318b96b022d554ee URL: https://github.com/llvm/llvm-project/commit/901cc4a4bc5257d100338e6c318b96b022d554ee DIFF: https://github.com/llvm/llvm-project/commit/901cc4a4bc5257d100338e6c318b96b022d554ee.diff

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

gribozavr2 added a comment. A number of ClangTidy tests have `-fno-delayed-template-parsing` in their RUN lines. While not a great solution (it only fixes the test, but does not make the warnings show for users on Windows), there's only so much a checker can do to counteract that. Before adding

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Comment at: clang/test/CodeGenObjC/debug-info-objc-property-dwarf5.m:26 +// CHECK: ![[DECL:[0-9]+]] = !DISubprogram(name: "-[Foo setBar:]", +// CHECK-SAME: scope: ![

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder added a comment. In D69991#1739456 , @aprantl wrote: > Why doesn't this need an update in lib/Serialization, is there generic code > that handles all attributes? I followed the patch made for `NonLazyClass` and it didn't touch `lib/Serializati

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

aprantl added a comment. Why doesn't this need an update in lib/Serialization, is there generic code that handles all attributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69991/new/ https://reviews.llvm.org/D69991 _

[PATCH] D69544: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply method

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1b07aac3d1c: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] e1b07aa - [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply method

Author: Alex Lorenz Date: 2019-11-08T14:50:54-08:00 New Revision: e1b07aac3d1c92f58e05cb5c37c0707842da5839 URL: https://github.com/llvm/llvm-project/commit/e1b07aac3d1c92f58e05cb5c37c0707842da5839 DIFF: https://github.com/llvm/llvm-project/commit/e1b07aac3d1c92f58e05cb5c37c0707842da5839.diff L

[PATCH] D69981: [www] More HTTPS and outdated link fixes.

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Committed: https://github.com/llvm/llvm-project/commit/3a7a22445e806c08f80cf6d83d1760f7ff732ed0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 3a7a224 - [www] More HTTPS and outdated link fixes.

Author: Stephan T. Lavavej Date: 2019-11-08T14:41:27-08:00 New Revision: 3a7a22445e806c08f80cf6d83d1760f7ff732ed0 URL: https://github.com/llvm/llvm-project/commit/3a7a22445e806c08f80cf6d83d1760f7ff732ed0 DIFF: https://github.com/llvm/llvm-project/commit/3a7a22445e806c08f80cf6d83d1760f7ff732ed0.

[clang] 3a3255a - clang-format: refresh the list of options

Author: Sylvestre Ledru Date: 2019-11-08T23:40:16+01:00 New Revision: 3a3255a22398f34dec16b57beef9e2ff60a108e3 URL: https://github.com/llvm/llvm-project/commit/3a3255a22398f34dec16b57beef9e2ff60a108e3 DIFF: https://github.com/llvm/llvm-project/commit/3a3255a22398f34dec16b57beef9e2ff60a108e3.dif

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ marked an inline comment as done. NoQ added a comment. In D69962#1738618 , @Szelethus wrote: > Nice catch! Though, wouldn't the memory sanitizer buildbots break on this > reliably? I kinda hope so; i'll take a look at home. Comme

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

eandrews added a comment. Thank you for letting me know. The patch has been reverted. The fail is a result of different diagnostics thrown on Windows and Linux. It looks like clang passes -fdelayed-template-parsing by default on Windows, which I assume is the reason why the diagnostic is not ge

[clang] d52cff8 - Revert "Reland "[clang] Report sanitizer blacklist as a dependency in cc1""

Author: Jan Korous Date: 2019-11-08T14:28:30-08:00 New Revision: d52cff88367df4d6bc57949d5e8a61aec0c301e8 URL: https://github.com/llvm/llvm-project/commit/d52cff88367df4d6bc57949d5e8a61aec0c301e8 DIFF: https://github.com/llvm/llvm-project/commit/d52cff88367df4d6bc57949d5e8a61aec0c301e8.diff LO

[clang] 4c44fd3 - clang-format: Add to the release notes the new --dry-run/-n option

Author: Sylvestre Ledru Date: 2019-11-08T23:26:44+01:00 New Revision: 4c44fd3de374fdce383ca1b0313b2418d1f1d370 URL: https://github.com/llvm/llvm-project/commit/4c44fd3de374fdce383ca1b0313b2418d1f1d370 DIFF: https://github.com/llvm/llvm-project/commit/4c44fd3de374fdce383ca1b0313b2418d1f1d370.dif

RE: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Hi Jan, Thanks for looking at this. I'm seeing new errors on the PS4 windows bot. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/57835 Thanks, Matthew > -Original Message- > From: jkor...@apple.com > Sent: Friday, November 8, 2019 2:01 PM > To: Voss

[clang-tools-extra] d0b3e73 - Revert "Reapply "Fix crash on switch conditions of non-integer types in templates""

Author: Melanie Blower Date: 2019-11-08T14:18:15-08:00 New Revision: d0b3e73175041306474bfb1914ef565e042fb50a URL: https://github.com/llvm/llvm-project/commit/d0b3e73175041306474bfb1914ef565e042fb50a DIFF: https://github.com/llvm/llvm-project/commit/d0b3e73175041306474bfb1914ef565e042fb50a.diff

[PATCH] D69769: [Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 abandoned this revision. Ericson2314 added a comment. OK abandoning this too. Thanks for the extra info. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69769/new/ https://reviews.llvm.org/D69769 ___ cfe-co

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc added a comment. In D69238#1736365 , @NoQ wrote: > I suspect that it's not just the source range, but the whole AST for the > initializer is different, due to C++17 mandatory copy elision in the > equals-initializer syntax. Like, before C++17 it

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 abandoned this revision. Ericson2314 added a comment. OK sounds good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69760/new/ https://reviews.llvm.org/D69760 ___ cfe-commits mailing list c

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 reclaimed this revision. Ericson2314 added a comment. Oops meant to abandon the backport Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69760/new/ https://reviews.llvm.org/D69760 ___ cfe-com

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

gribozavr2 added a comment. If it is indeed the extra AST node for the elidable constructor, see if you can use the `ignoringElidableConstructorCall` AST matcher to ignore it, therefore smoothing over AST differences between language modes. Repository: rCTE Clang Tools Extra CHANGES SINCE L

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

gribozavr2 added a comment. > Should I go ahead and revert my patch while I investigate the issue on > Windows or should I just push a new patch deleting the 'CHECK-FIXES' while I > look into the issue? Yes. As a general rule, if you landed a patch and it broke a bot that was previously green,

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc added a comment. Just documenting here that I sent the following email to cfe-...@lists.llvm.org: > When parsing a named declaration with an equals sign with clang -std > c++11/14, clang builds an initializer expression whose SourceRange covers > from the variable name through the end

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*) jdoerfe

[clang] b314414 - Basic: fix FileManager invalidation issue for file redirect

Author: Alex Suhan Date: 2019-11-08T17:02:44-05:00 New Revision: b314414570c0db6cd3a2712d7b26942fe38278db URL: https://github.com/llvm/llvm-project/commit/b314414570c0db6cd3a2712d7b26942fe38278db DIFF: https://github.com/llvm/llvm-project/commit/b314414570c0db6cd3a2712d7b26942fe38278db.diff LO

Re: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Hi Matthew, You were absolutely right - my bad! I relanded the patches plus a fix. 555c6be041d [clang] Fix -fsanitize-system-blacklist processing in cc1 Thanks, Jan > On Nov 8, 2019, at 11:00 AM, Voss, Matthew wrote: > > Hi Jan, > >> Are you sure it is this commit? > I narrowed it down to

[clang] cae4a28 - Reland "[clang] Report sanitizer blacklist as a dependency in cc1"

Author: Jan Korous Date: 2019-11-08T13:55:00-08:00 New Revision: cae4a28864f4e8a55920e2b94e2cd43617902dec URL: https://github.com/llvm/llvm-project/commit/cae4a28864f4e8a55920e2b94e2cd43617902dec DIFF: https://github.com/llvm/llvm-project/commit/cae4a28864f4e8a55920e2b94e2cd43617902dec.diff LO

[clang] 6d28588 - Reland "[clang] Report sanitizer blacklist as a dependency in cc1"

Author: Jan Korous Date: 2019-11-08T13:54:28-08:00 New Revision: 6d28588cc0f223cc06fc103493b1f16cb7e579f8 URL: https://github.com/llvm/llvm-project/commit/6d28588cc0f223cc06fc103493b1f16cb7e579f8 DIFF: https://github.com/llvm/llvm-project/commit/6d28588cc0f223cc06fc103493b1f16cb7e579f8.diff LO

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev marked 2 inline comments as done. ABataev added a comment. In D69952#1739366 , @jdoerfert wrote: > I think we are almost there. > > Last remaining points: > > - Constructor (see below) > - enum naming scheme (see below) > - can we test this somehow

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 updated this revision to Diff 228514. xbolva00 added a comment. Fixed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cl

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

jdoerfert added a comment. I think we are almost there. Last remaining points: - Constructor (see below) - enum naming scheme (see below) - can we test this somehow? Comment at: clang/include/clang/Basic/OpenMPKinds.h:43 +/// Struct to store the context selectors info. +templ

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*) jdoerfe

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rG860ee4f3ebf5: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the… (authored by paul_hoad ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. gentle ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ https://reviews.llvm.org/D69573 ___ cfe-commits ma

[clang] 860ee4f - [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

Author: paul_hoad Date: 2019-11-08T21:14:29Z New Revision: 860ee4f3ebf56f4d2e387ceec9b8028636e72d2c URL: https://github.com/llvm/llvm-project/commit/860ee4f3ebf56f4d2e387ceec9b8028636e72d2c DIFF: https://github.com/llvm/llvm-project/commit/860ee4f3ebf56f4d2e387ceec9b8028636e72d2c.diff LOG: [cl

[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

craig.topper updated this revision to Diff 228511. craig.topper added a comment. Refactor to share more code with the CodeGen target feature stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68627/new/ https://reviews.llvm.org/D68627 Files: clang/include/clang/AST/ASTContext.h c

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added a comment. jdoerfert added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 added a comment. Looking at Sema/AnalysisBasedWarnings.cpp, reworking it to "select" would take some time so I will prepare just simple patch without "select". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2343-2344 +// pointer +if (Arg.back() < OMPC_DEFAULTMAP_MODIFIER_unknown) + Arg.back() = OMPC_DEFAULTMAP_MODIFIER_unknown; KLoc.push_back(Tok.getLoca

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*) jdoerfe

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2343-2344 +// pointer +if (Arg.back() < OMPC_DEFAULTMAP_MODIFIER_unknown) + Arg.back() = OMPC_DEFAULTMAP_MODIFIER_unknown; KLoc.push_back(Tok.getLocation()); Is this poss

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie added a comment. In D69935#1738273 , @uabelho wrote: > Don't you need to also remove > > case LinkageSpecDecl::lang_cxx_11: > case LinkageSpecDecl::lang_cxx_14: > > > from VisitLinkageSpecDecl in clang-tools-extra/modularize/Modularize.cpp?

[PATCH] D69878: Consoldiate internal denormal flushing controls

jlebar added a comment. > AMDGPU wants a distinct control for f32 flushing from f16/f64, and as far as > I can tell the same is true for NVPTX (based on the attribute name). I may be corrected, but I believe nvptx only supports ftz for f32. > Double-precision instructions support subnormal inpu

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:498 +CmdArgs.push_back( +Args.MakeArgString(Twine("-plugin-opt=-target-abi=") + ABIName)); } khchen wrote: > efriedma wrote: > > I don't think this change is right

Bots which still pulling SVN will be removed from the staging

Hello everyone, The following bots which are in staging and still working with SVN will be removed at the end of the day tomorrow. * llvm-riscv-linux * llvm-avr-linux * fuchsia-x86_64-linux * fuchsia-x86_64-linux along with the bots which are still missing dependencies to build from github and w

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

eandrews added a comment. @rnk @gribozavr2 clang-tidy test "bugprone-string-integer-assignment.cpp" caused a bot fail on windows. From the logs it looks like the 'CHECK-FIXES' I added in that test is failing because the fix isn't applied. I am not sure why. I don't have a windows build set up a

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69951/new/ https://reviews.llvm.org/D69951 ___ cfe-commits mailin

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. Let me take a look whether this is a *relatively easy way* to support sticky forward declaration (w.r.t. applying to inner structures). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69759/new/ https://reviews.llvm.or

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. Yes, in the above, all three of them will be relocatable. -bash-4.4$ cat t2.c #define __reloc__ __attribute__((preserve_access_index)) struct S1; struct S2 { struct S1 *f; } __reloc__; struct S1 { int i; } __reloc__; // access s2->f

Re: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Hi Jan, The x86_64 sanitizer was failing: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/24326 And then immediately after the reverts landed: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/24327 check-dfsan passes. I don't have any explanation as to wh

[PATCH] D69648: Add VFS support for sanitizers' blacklist' 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG590f279c456b: [clang] Add VFS support for sanitizers' blacklists (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGE

RE: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Hi Jan, > Are you sure it is this commit? I narrowed it down to your commit on my local machine. Let me know if it doesn't repro on your end, though. Thanks, Matthew > -Original Message- > From: jkor...@apple.com > Sent: Friday, November 8, 2019 10:55 AM > To: Voss, Matthew > Cc: Jan

[clang] 590f279 - [clang] Add VFS support for sanitizers' blacklists

Author: Jan Korous Date: 2019-11-08T10:58:50-08:00 New Revision: 590f279c456bbde632eca8ef89a85c478f15a249 URL: https://github.com/llvm/llvm-project/commit/590f279c456bbde632eca8ef89a85c478f15a249 DIFF: https://github.com/llvm/llvm-project/commit/590f279c456bbde632eca8ef89a85c478f15a249.diff LO

Re: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Hi Matthew, Are you sure it is this commit? It is definitely possible yet sounds a bit unlikely that my patch would cause linker errors. Anyway, I am going to reproduce on a linux box. Thanks. Jan > On Nov 7, 2019, at 4:50 PM, Voss, Matthew wrote: > > Hi Jan, > > It looks like this commit

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

ast added a comment. So what happens in the following case: struct S1; struct S2 { struct S1 *f; } relo *s2; // access s2->f struct S1 { int i; } relo; // access s2->f->i lack of relo on fwd declaration is not going to be sticky 'non-relo' when it's seen later, right? So a

[PATCH] D69971: clang-format: [JS] support null operators.

mprobst updated this revision to Diff 228495. mprobst added a comment. Add tests for .?(foo) and .?[foo]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69971/new/ https://reviews.llvm.org/D69971 Files: clang/lib/Format/FormatToken.h clang/lib/

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. But it does not work for inner structs any more. -bash-4.4$ cat t.c #define __reloc__ __attribute__((preserve_access_index)) struct __reloc__ p; struct p { int a; struct { int b; }; }; int test(struct p *arg) { return arg->b; } -bash-4.4$ In onl

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*) jdoerfe

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. For question > Is there a use case to apply that attribute to inner types automatically ? It is possible, but I feel make attribute per record is better. For example, struct s1 { int foo; }; struct s2 { struct s1 *ptr; } __reloc__ *s2; If we impl

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. > Is the attribute sticky with forward delcarations? forward declaration is not a record type, so an error will be emited if you have attribute on a forward declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay updated this revision to Diff 228491. MyDeveloperDay marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69951/new/ https://reviews.llvm.org/D69951 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h Index: cl

[clang] 7599484 - Reapply "Fix crash on switch conditions of non-integer types in templates"

Author: Melanie Blower Date: 2019-11-08T10:17:06-08:00 New Revision: 759948467ea3181615d44d80f74ffeb260180fd0 URL: https://github.com/llvm/llvm-project/commit/759948467ea3181615d44d80f74ffeb260180fd0 DIFF: https://github.com/llvm/llvm-project/commit/759948467ea3181615d44d80f74ffeb260180fd0.diff

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

This revision was automatically updated to reflect the committed changes. Closed by commit rG759948467ea3: Reapply "Fix crash on switch conditions of non-integer types in templates" (authored by mibintc). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc added a comment. Thanks @aaron.ballman, I don't have commit access so will someone else commit this? To address the minor nit, should I upload a new patch with post-increment/post-decrement changed to pre-increment/pre-decrement? (Does uploading changes undo the "Ready to Land" status

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

Ericson2314 added a comment. Reading https://llvm.org/docs/DeveloperPolicy.html it looks like I need to submit an patch email? Is that true, or can/will someone with perms see the approval and eventually merge it from phabricator? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 added a comment. While I am fine making `-fuse-ld=lld` mean "use that lld driver most appropriate for the clang driver", in principle the clang driver and lld driver choices are orthogonal, and I'd want to expose that with something like `-fuse-ld=ld.lld` to compliment `-fuse-ld=lld

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

aprantl updated this revision to Diff 228484. aprantl marked 3 inline comments as done. aprantl added a reviewer: vsk. aprantl added a comment. Address comments from Vedant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66121/new/ https://reviews.llvm.org/D66121 Files: clang/lib/Code

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

ast added a comment. Is the attribute sticky with forward delcarations? struct s __reloc; struct s { int foo; } *s; what is s->foo ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69759/new/ https://reviews.llvm.org/D69759

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: llvm/lib/IR/OpenMPIRBuilder.cpp:153-159 +// Search the entry block, not needed once all thread id calls go through +// here and are cached in the OpenMPIRBuilder. +for (Instructio

  1   2   >