[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked 3 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:139 +// that constructor. FIXME(nridge): this should probably be handled in +// targetDecl() itself. +const CXXConstructorDecl *findCalledConstructor(const Select

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous. Herald added a project: clang. This fixes issue #163, among other improvements to go-to-definition. Repository: rG LLVM Github Monorepo htt

[PATCH] D69233: [OpenCL] Support -fdeclare-opencl-builtins in C++ mode

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a project: clang. Support for C++ mode was accidentally lacking due to not checking the OpenCLCPlusPlus LangOpts version. Repository: rC Clang https://review

[PATCH] D62731: Add support for options -frounding-math, ftrapping-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1318 + mode informs the compiler that it must not assume any particular + rounding mode. + rjmccall wrote: > rjmccall wrote: > > "represent *the* corresponding IEEE rounding rules" > A few

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

xbolva00 added a comment. Probably it is not very cheap in terms of compile time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66046/new/ https://reviews.llvm.org/D66046 ___ cfe-commits mailing list c

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

thakis added a comment. Any reason why this is off by default? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66046/new/ https://reviews.llvm.org/D66046 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

mgehre updated this revision to Diff 225804. mgehre marked 6 inline comments as done. mgehre added a comment. - Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68074/new/ https://reviews.llvm.org/D68074 Files: clang-tools-extr

[PATCH] D69225: Sema: Fixes a crash with a templated destructor

Mordante created this revision. Mordante added reviewers: rcraik, hubert.reinterpretcast, aaron.ballman, rsmith. Mordante added a project: clang. This fixes PR38671. The issue was introduced by D33833 which fixed PR33189. Repository: rG LLVM Github Monorepo

[PATCH] D67052: Add reference type transformation builtins

zoecarver added a comment. Herald added a reviewer: mclow.lists. Friendly ping. Other than type mangling, does anything need to be fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67052/new/ https://reviews.llvm.org/D67052 __

[PATCH] D69223: WDocumentation: Implement the \anchor.

Mordante created this revision. Mordante added a reviewer: gribozavr. Mordante added a project: clang. Herald added a subscriber: arphaman. I'm not sure it should be added to the `InlineComment` group. It's not entirely a markup. Do you think it should be a in a separate group? (I also have not

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225788. abelkocsis added a comment. The documentation of the checker updated. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-tools-extra/clang-tidy/mi

[PATCH] D69129: [AMDGPU] Fix assertion due to initializer list

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGe6125fc0ec34: [AMDGPU] Fix assertion due to initializer list (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.o

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225786. abelkocsis added a comment. Test clang-formatted. Uncaught word removed from documentations. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 Files: clang-to

r375362 - [AMDGPU] Fix assertion due to initializer list

Author: yaxunl Date: Sun Oct 20 08:02:22 2019 New Revision: 375362 URL: http://llvm.org/viewvc/llvm-project?rev=375362&view=rev Log: [AMDGPU] Fix assertion due to initializer list Sometimes a global var is replaced by a different llvm value. clang use GetAddrOfGlobalVar to get the original llvm

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-bad-signal-to-kill-thread.rst:9 +individual thread. Use any signal except ``SIGTERM`` or ``SIGKILL``. +To learn more about this rule please visit the following page: +https://wiki.sei

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225784. abelkocsis marked an inline comment as done. abelkocsis added a comment. Header documentation and Release Notes synchronised. Documentation of checker updated. Type changed to auto type when necessary. Repository: rCTE Clang Tools Extra CHANGE

[PATCH] D69218: [clang][AST] Add `CXXBaseSpecifier` matcher support

nick updated this revision to Diff 225783. nick added a comment. Fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AST/ASTTyp

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante updated this revision to Diff 225782. Mordante added a comment. Undo the changes to the caret position as requested by @aaron.ballman . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/ https://reviews.llvm.org/D68913 Files: clang/include/clang/AST/Decl.h clang/lib/

[PATCH] D69129: [AMDGPU] Fix assertion due to initializer list

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3898 +Entry = CE->stripPointerCasts(); } rjmccall wrote: > You can just make this whole thing `Entry = Entry->stripPointerCasts()`. will do w

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

sylvestre.ledru added a comment. > More dynamic, less static isn't always a good thing. It saves disk space at > the expense of performance. The option that controls this is > `CLANG_LINK_CLANG_DYLIB`, which is mentioned in the clang 9.0 release notes. Sure :) For example, for a full build of l

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

MyDeveloperDay updated this revision to Diff 225779. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. I think we agree it should be (StringRef ), no const,no reference CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D6891