[PATCH] D69129: [AMDGPU] Fix assertion due to initializer list

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Minor change, but otherwise LGTM. Comment at: lib/CodeGen/CodeGenModule.cpp:3898 +Entry = CE->stripPointerCasts(); } You can just make this whol

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:31 +void BadSignalToKillThreadCheck::check(const MatchFinder::MatchResult &Result) { + Preprocessor::macro_iterator It = PP->macro_begin(); + while (It != PP->mac

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

mhinz created this revision. mhinz added reviewers: ldionne, rsmith. mhinz added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. For each absolute path given to C_INCLUDE_DIRS, we want it to be added as-is to the include search path. Relative paths should be prefixed with the

[PATCH] D69194: build: add clang-cl and clang++ symlinks in the build tree

compnerd abandoned this revision. compnerd added a comment. I think I must have had something else in my tree, cause a clean build does build them. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69194/new/ https://reviews.llvm.org/D69194 __

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis updated this revision to Diff 225769. abelkocsis added a comment. Auto types replaced on checker files. New lines added when necessary. Reordered ReleaseNotes by alphabetical order. Checker name is updated on ReleaseNotes, compliant solution is wrote to the documentation. Another two

[PATCH] D69218: [clang][AST] Add `CXXBaseSpecifier` matcher support

nick updated this revision to Diff 225770. nick added a comment. Regenerated the docs, added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218 Files: clang/docs/LibASTMatchersReference.html cl

[PATCH] D69218: [clang][AST] Add `CXXBaseSpecifier` matcher support

lebedev.ri added a comment. Needs more tests - what happens with multiple inheritance, what about inheriting from inherited? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218 __

[PATCH] D69218: [clang][AST] Add `CXXBaseSpecifier` matcher support

lebedev.ri added a comment. Missing docs regeneration (`clang/docs/tools/dump_ast_matchers.py` i think) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69218/new/ https://reviews.llvm.org/D69218 ___ cfe-

[PATCH] D69218: [clang][AST] Add `CXXBaseSpecifier` matcher support

nick created this revision. nick added a reviewer: klimek. nick added a project: clang. Herald added a subscriber: cfe-commits. Required for capturing base specifier in matchers: `cxxRecordDecl(hasBase(cxxBaseSpecifier().bind("base")))` Will make implementation of D69000

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc added a comment. In D69145#1715614 , @lebedev.ri wrote: > So https://godbolt.org/z/qzjU-C > This feels like gcc being overly zealous, i'm not sure what it says with > that warning. I'd agree, while copy constructors //usually// need to copy ba

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc updated this revision to Diff 225764. poelmanc added a comment. Addressed @mgehre's feedback: - Ran clang-format - Included gcc, -Wextra, -Werror=extra, and the full text of the warning/error message to aid in searchability, so people can find this option when they encounter the proble

[PATCH] D69164: [clang-format] fix regression recognizing casts in Obj-C calls

MyDeveloperDay added a comment. rC373922: [clang-format] [PR27004] omits leading space for noexcept when formatting… was to fix https://bugs.llvm.org/show_bug.cgi?id=27004 which wasn't just related to `delete` it occurred in other cases. (operator++) and ther

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc added a comment. In D69145#1715611 , @mgehre wrote: > Exactly due to the issue you are fixing here, we ended up disabling the > complete check because we didn't want to live with the warnings it produced > on -Wextra. > Therefore, I'm actually

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay added a comment. Thank you for the patch. If you plan to continue to submit patches I think it would be worthwhile if you applied for commit access, This is not the first revision from you and we need more people who are willing to help with clang-format to fix bug and do code r

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

abelkocsis added a comment. Thank you for the reviews! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69181/new/ https://reviews.llvm.org/D69181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

lebedev.ri added a comment. So https://godbolt.org/z/qzjU-C This feels like gcc being overly zealous, i'm not sure what it says with that warning. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69145/new/ https://reviews.llvm.org/D69145 _

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

mgehre added a comment. Exactly due to the issue you are fixing here, we ended up disabling the complete check because we didn't want to live with the warnings it produced on -Wextra. Therefore, I'm actually strongly in favor to enable the option by default. When others see that clang-tidy fixi

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

mgehre added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantMemberInitCheck.cpp:55 const auto *Construct = Result.Nodes.getNodeAs("construct"); + const auto* ConstructorDecl = Result.Nodes.getNodeAs( "constructor" ); + Extra

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:34-48 + Preprocessor::macro_iterator It = PP->macro_begin(); + while (It != PP->macro_end() && !SigtermValue.hasValue()) { +if (It->first->getName() == "SIGTERM") {

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___

Re: [PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

On Fri, Oct 18, 2019 at 7:38 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > Looks like this fails on win: http://45.33.8.238/win/841/step_6.txt > > Ptal! > > Maybe just cat'ing all files instead of echoing the first and piping into > cat works? > > R

r375338 - Revert "[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics." and "[Docs] Fix header level."

Author: mspencer Date: Sat Oct 19 02:45:28 2019 New Revision: 375338 URL: http://llvm.org/viewvc/llvm-project?rev=375338&view=rev Log: Revert "[Implicit Modules] Add -cc1 option -fmodules-strict-context-hash which includes search paths and diagnostics." and "[Docs] Fix header level." The test do

Re: Zorg migration to GitHub/monorepo

Hello everyone, The staging master is ready to accept bots from the list I have sent yesterday. Don't wait too long. The master has been updated and works with both SVN and Github monorepo now. The following builders are already listening for changes in monorepo and building monorepo. More are c

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX updated this revision to Diff 225749. SouraVX added a comment. Corrected typo in test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-deleted.cpp llvm/

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX created this revision. SouraVX added reviewers: probinson, dblaikie, aprantl. SouraVX added a project: debug-info. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. SouraVX marked an inline comment as done. SouraVX added inline comments. =

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX marked an inline comment as done. SouraVX added inline comments. Comment at: llvm/test/DebugInfo/X86/DW_AT_deleted.ll:68 + +attributes #0 = { noinline nounwind optnone uwtable } +attributes #1 = { nounwind readnone speculatable willreturn } Removed all st