[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

malaperle added a comment. In D63397#1696000 , @malaperle wrote: > "Extend our extension to support detecting these files as C++ files based on > the first > line (-*- C++ -*-), it will make clangd work on C++ standard headers > (e.g. iostream)." > > Th

[PATCH] D68535: Fix loop unrolling initialization in the new pass manager

echristo created this revision. echristo added reviewers: chandlerc, hfinkel. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mcrosier. Herald added projects: clang, LLVM. In the new pass manager use PTO.LoopUnrolling to determine when and how we will unroll loops. Also comment a f

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

malaperle added a comment. Herald added a subscriber: usaxena95. "Extend our extension to support detecting these files as C++ files based on the first line (-*- C++ -*-), it will make clangd work on C++ standard headers (e.g. iostream)." This is not in the standard right? I don't see this in MS

[PATCH] D68531: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100. Herald added projects: clang, LLVM. This clang builtin and corresponding LLVM intrinsic are necessary to expose the exact se

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. I think this is reasonable change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68526/new/ https://reviews.llvm.org/D68526 _

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

Bigcheese updated this revision to Diff 223345. Bigcheese retitled this revision from "[Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths." to "[Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.". Bigcheese added

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths.

Bigcheese created this revision. Bigcheese added reviewers: rsmith, bruno. Herald added a subscriber: dexonsmith. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D68528 Files: include/clang/Driver/CC1Options.td include/clang/Lex/HeaderSearchOptions.h lib/Fron

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev updated this revision to Diff 223335. sdmitriev added a comment. Rebased patch and changed clang-offload-wrapper CMakeLists.txt to use add_clang_tool() rather than add_clang_executable() with a custom install rule. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/ http

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

jrtc27 created this revision. jrtc27 added reviewers: rsmith, xbolva00. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68526 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/div-sizeof-array.cpp Index

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar created this revision. tstellar added a reviewer: beanz. Herald added a subscriber: mgorny. Herald added a project: clang. We were linking all the clang objects and shared libraries into libclang-cpp.so, which was causing the command line options to be registered twice. Repository: rG

[PATCH] D68482: [clang] fix a typo from r372531

This revision was automatically updated to reflect the committed changes. Closed by commit rL373792: [clang] fix a typo from r372531 (authored by yuanfang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

r373792 - [clang] fix a typo from r372531

Author: yuanfang Date: Fri Oct 4 14:37:20 2019 New Revision: 373792 URL: http://llvm.org/viewvc/llvm-project?rev=373792&view=rev Log: [clang] fix a typo from r372531 Reviewers: xbolva00 Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68482 Modified:

[PATCH] D68481: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete()

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:1617 +if (Tok.Next->isOneOf(tok::kw_noexcept, tok::kw_volatile, tok::kw_const, +

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

yaxunl updated this revision to Diff 223284. yaxunl marked 6 inline comments as done. yaxunl added a comment. Revised by Alexey's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 Files: include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cp

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

yaxunl marked 12 inline comments as done. yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:17618 + + if (LangOpts.CUDA) { +// When compiling for device, host functions are never emitted. Similarly, ABataev wrote: > Are you going to handle `#p

[PATCH] D68482: [clang] fix a typo from r372531

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68482/new/ https://reviews.llvm.org/D68482 __

[PATCH] D68482: [clang] fix a typo from r372531

ychen created this revision. ychen added a reviewer: xbolva00. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68482 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/warn-integer-constants-in-ternary

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

This revision was automatically updated to reflect the committed changes. Closed by commit rL373785: [clang] [cmake] Use add_clang_tool() to install all tools (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

This revision was automatically updated to reflect the committed changes. Closed by commit rL373786: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible (authored by mgorny, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Herald added a project: LLVM. Ch

[clang-tools-extra] r373786 - [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

Author: mgorny Date: Fri Oct 4 13:30:02 2019 New Revision: 373786 URL: http://llvm.org/viewvc/llvm-project?rev=373786&view=rev Log: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible Use clang_target_link_libraries() in order to support linking against libclang-cpp instead o

r373785 - [clang] [cmake] Use add_clang_tool() to install all tools

Author: mgorny Date: Fri Oct 4 13:28:59 2019 New Revision: 373785 URL: http://llvm.org/viewvc/llvm-project?rev=373785&view=rev Log: [clang] [cmake] Use add_clang_tool() to install all tools Switch clang-check, clang-extdef-mapping and clang-offload-bundler to use add_clang_tool() rather than add

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

beanz added a comment. In D68448#1694284 , @sylvestre.ledru wrote: > More dynamic, less static usage :) More dynamic, less static isn't always a good thing. It saves disk space at the expense of performance. The option that controls this is `CLANG_LIN

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68448/new/ https://reviews.llvm.org/D68448 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D68429: [clang] [cmake] Use add_clang_tool() to install all tools

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. fair enough CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68429/new/ https://reviews.llvm.org/D68429 ___ cfe-commits mailing list cfe-comm

[PATCH] D68481: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete()

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, owenpan, mitchell-stellar. MyDeveloperDay added a project: clang-format. Herald added a project: clang. clang-format is incorrectly thinking the parameter parens are part of a cast operation, this is resulting in there

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GN

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") xbolva00 wrote: > aaron.ballman wrote:

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:91 HANDLE_DISP_FLAG((1u << 8), MainSubprogram) +HANDLE_DISP_FLAG((1u << 9), NotDefaulted) +HANDLE_DISP_FLAG((1u << 10), DefaultedInClass) probinson wrote: > SouraVX wrote: > > a

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GN

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1618 + return; +} else if (const auto Def = Method->getDefinition()) { + if (Def->isDefaulted()) { LLVM style is not to use 'else' after 'return'. Comm

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GNU_LANGUAGES) xbolva00

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") a

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GN

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GNU_LANGUAGES) xbolva00

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GN

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

This revision was automatically updated to reflect the committed changes. Closed by commit rL373774: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r373774 - [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

Author: epilk Date: Fri Oct 4 12:20:27 2019 New Revision: 373774 URL: http://llvm.org/viewvc/llvm-project?rev=373774&view=rev Log: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic The warnings now in -Wformat-type-confusion don't align with how we interpret 'pedantic' in clang, an

r373771 - Add missing null pointer check in -ftime-trace code

Author: rnk Date: Fri Oct 4 11:57:01 2019 New Revision: 373771 URL: http://llvm.org/viewvc/llvm-project?rev=373771&view=rev Log: Add missing null pointer check in -ftime-trace code createOutputFile diagnoses the error for the caller already, so recover by not writing the output. Fixes PR43555

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I confirmed the test case matches the name that MSVC produces. I guess this regressed in rC362293 / D62746 , so the bug is

[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

sylvestre.ledru added a comment. In D24243#1695052 , @sylvestre.ledru wrote: > Maybe it could be mentioned in the release notes? Forget about this comment, I have been distracted by the fact that it is now installed https://reviews.llvm.org/D68423 Re

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Comment at: clang/test/Sema/format-strings-pedantic.c:1 -// RUN: %clang_cc1 -fsyntax-only -verify -Wformat -Wformat-pedantic -isystem

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

rnk added a subscriber: Bigcheese. rnk added a comment. + @Bigcheese, for amusement. We discussed some interesting behavior of _Pragma and C++ raw string literals last night. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68114/new/ https://reviews

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") xbolva00 wrote: > aaron.ballman wrote:

[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

sylvestre.ledru added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Maybe it could be mentioned in the release notes? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24243/new/ https://reviews.llvm.org/D24243 __

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

aaron.ballman added inline comments. Comment at: clang/lib/AST/Decl.cpp:3107 +if (!ArmMveAliasValid(BuiltinID, getIdentifier()->getName())) { + getASTContext().getDiagnostics().Report( +getLocation(), diag::err_attribute_arm_mve_alias); simon_tat

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang updated this revision to Diff 223255. akhuang added a comment. - move TokenCollector out of function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68114/new/ https://reviews.llvm.org/D68114 Files: clang/lib/Lex/Pragma.cpp clang/test/Pr

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose closed this revision. jordan_rose added a comment. Committed as rC373769 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68430/new/ https://reviews.llvm.org/D68430 __

r373769 - [CMake] Clang: Don't use object libraries with Xcode

Author: jrose Date: Fri Oct 4 11:17:58 2019 New Revision: 373769 URL: http://llvm.org/viewvc/llvm-project?rev=373769&view=rev Log: [CMake] Clang: Don't use object libraries with Xcode Undoes some of the effects of r360946 when using the Xcode CMake generator---it doesn't handle object libraries

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64820/new/ https://reviews.llvm.org/D64820 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D68430: Don't use object libraries with Xcode

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. That's fine. That said, there are things that just can't be done, or don't work well, in the Xcode and Visual Studio generators, so we have precedent for disabling functionality based on those g

[PATCH] D64874: [Sema] Improve handling of function pointer conversions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, though I'd like to see this generalized to handle noreturn too. Comment at: clang/lib/Sema/SemaTemplate.cpp:6997 + QualType ResultTy; + if (getLangOpts().CPlu

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65695/new/ https://reviews.llvm.org/D65695 ___ cfe-commits mailing list cfe-commit

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose updated this revision to Diff 223250. jordan_rose added a comment. Okay, having Xcode force-load the static libraries doesn't seem bad at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68430/new/ https://reviews.llvm.org/D68430 Fil

[PATCH] D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too

mitchell-stellar added a comment. Thanks, please commit on my behalf. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68473/new/ https://reviews.llvm.org/D68473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68473/new/ https://reviews.llvm.org/D68473 ___

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose added a comment. In D68430#1693965 , @beanz wrote: > clang_cpp can't link the libraries "normally" because it has no unresolved > symbols to force the contents of the libraries to link. I don't like it, but > I think the best option is to dis

[PATCH] D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too

mitchell-stellar created this revision. mitchell-stellar added reviewers: MyDeveloperDay, reuk, owenpan. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes the `SpacesInSquareBrackets` setting also apply to C++ la

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc added a comment. Herald added a subscriber: mgehre. Hi @alexfh, @jonathanmeier has reviewed my pull request but lacks commit access. It changes ~30 lines of code isolated to modernize-use-using.cpp and adds ~60 lines of tests. If you have time I'd greatly appreciate it if you could pro

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 7 inline comments as done. SouraVX added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1610 + if (const auto *CXXC = dyn_cast(Method)) { +if (CXXC->getCanonicalDecl()->isDeleted()) + SPFlags |= llvm::DISubprogram::SPFlagDeleted; -

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 223240. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp clang/test/CodeGenCXX/debug-info-defaulted-in-class

[PATCH] D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style

MyDeveloperDay added a comment. In D67773#1694797 , @mitchell-stellar wrote: > This needs to be more thought out. At the very least it needs to cover more > keywords like `do`, `switch`, `try`, and `catch`. There may be more. > Consideration also needs

[PATCH] D67980: [WIP][CLANG][BPF] do compile-once run-everywhere relocation for bitfields

yonghong-song updated this revision to Diff 223233. yonghong-song edited the summary of this revision. yonghong-song added a comment. using 64bit buf always, handling non bitfield members, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67980/new

r373756 - [OPENMP50]Suppport for multiple vendors in the same vendor context

Author: abataev Date: Fri Oct 4 08:58:45 2019 New Revision: 373756 URL: http://llvm.org/viewvc/llvm-project?rev=373756&view=rev Log: [OPENMP50]Suppport for multiple vendors in the same vendor context selector. According to OpenMP 5.0, multiple vendors could be specified in the vendor context sel

[PATCH] D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style

mitchell-stellar requested changes to this revision. mitchell-stellar added a comment. This revision now requires changes to proceed. This needs to be more thought out. At the very least it needs to cover more keywords like `do`, `switch`, `try`, and `catch`. There may be more. Consideration als

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

simon_tatham marked 20 inline comments as done. simon_tatham added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8529 "argument should be a multiple of %0">; +def err_argument_not_power_of_2 : Error< + "argument should be a power of 2">; --

[PATCH] D68467: [clangd] If an undocumented definition exists, don't accept documentation from other forward decls.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This fixes cases like: foo.h class Undocumented{} bar.h // break an include cycle. we sho

r373753 - SemaDeclAttr - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Fri Oct 4 08:02:46 2019 New Revision: 373753 URL: http://llvm.org/viewvc/llvm-project?rev=373753&view=rev Log: SemaDeclAttr - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cas

r373752 - CGBlocks - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Fri Oct 4 08:01:54 2019 New Revision: 373752 URL: http://llvm.org/viewvc/llvm-project?rev=373752&view=rev Log: CGBlocks - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases w

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

This revision was automatically updated to reflect the committed changes. Closed by commit rL373751: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

r373751 - [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

Author: paulhoad Date: Fri Oct 4 07:25:20 2019 New Revision: 373751 URL: http://llvm.org/viewvc/llvm-project?rev=373751&view=rev Log: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting Summary: According to the clang-format documentation, "Fundamentally, C++11 brace

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. LGTM and passes [--] Global test environment tear-down [==] 700 tests from 21 test cases ran. (67039 ms total) [ PASSED ] 700 tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGba12cec21f55: [clang-format] [PR43531] clang-format damages "alternative representations" for… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

r373750 - [clang-format] [PR43531] clang-format damages "alternative representations" for operators

Author: paulhoad Date: Fri Oct 4 07:16:59 2019 New Revision: 373750 URL: http://llvm.org/viewvc/llvm-project?rev=373750&view=rev Log: [clang-format] [PR43531] clang-format damages "alternative representations" for operators Summary: https://bugs.llvm.org/show_bug.cgi?id=43531 Fix for clang-for

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68332/new/ https://reviews.llvm.org/D68332 ___ cfe-commits mailin

[PATCH] D68459: [clang-rename] Fix a crash when renaming a class without definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373748: [clang-rename] Fix a crash when renaming a class without definition. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

MyDeveloperDay updated this revision to Diff 223215. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. - add additional compl(5) and not(5) unit tests - improve the comments around the condition and explaining the tests - remove the use of .equals(...) CHANGES SINC

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk added a comment. @dexonsmith when you get a chance, can you take another look at this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 ___ cfe-c

r373749 - Further improve -Wbool-operation bitwise negation message

Author: sammccall Date: Fri Oct 4 07:11:05 2019 New Revision: 373749 URL: http://llvm.org/viewvc/llvm-project?rev=373749&view=rev Log: Further improve -Wbool-operation bitwise negation message Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/test/Sema/warn-bitwise

r373748 - [clang-rename] Fix a crash when renaming a class without definition.

Author: hokein Date: Fri Oct 4 07:09:31 2019 New Revision: 373748 URL: http://llvm.org/viewvc/llvm-project?rev=373748&view=rev Log: [clang-rename] Fix a crash when renaming a class without definition. Reviewers: sammccall Subscribers: cfe-commits Tags: #clang Differential Revision: https://re

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar updated this revision to Diff 223212. mitchell-stellar added a comment. Fixed empty parentheses unit test for C++11 braced initializer list. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 Files: clang/

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. You are correct. I'll work on this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. @mitchell-stellar I pulled the patch to commit it, but the unit tests fail, could you double-check them for me? [ OK ] FormatTest.LayoutBraceInitializersInReturnStatement (13 ms) [ RUN ] FormatTest.LayoutCxx11BraceInitializers C:/cygwin64/buildar

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

edward-jones updated this revision to Diff 223209. edward-jones retitled this revision from "[WIP][RISCV] Use compiler-rt if no GCC installation detected" to "[RISCV] Use compiler-rt if no GCC installation detected". edward-jones added a comment. Herald added subscribers: arichardson, emaste. Her

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones updated this revision to Diff 223205. edward-jones added a comment. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. Rebased and added tests I've made this use the Triple from the driver rather than the parsed LLVM triple, this means the Triple does

[PATCH] D68242: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading

This revision was automatically updated to reflect the committed changes. Closed by commit rL373746: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

r373746 - [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading

Author: paulhoad Date: Fri Oct 4 06:24:15 2019 New Revision: 373746 URL: http://llvm.org/viewvc/llvm-project?rev=373746&view=rev Log: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading Summary: https://bugs.llvm.org/show_bug.cgi?id=42417 This revision

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

kousikk accepted this revision. kousikk marked an inline comment as done. kousikk added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:206 +if (*First == '\\') { + if (++First == End) +return; dexonsmith wrote:

r373744 - [clang] Prevent false positives in arm-mfpu-none codegen test.

Author: statham Date: Fri Oct 4 06:01:41 2019 New Revision: 373744 URL: http://llvm.org/viewvc/llvm-project?rev=373744&view=rev Log: [clang] Prevent false positives in arm-mfpu-none codegen test. A user pointed out to me in private email that this test will fail if it sees the letter 's' followe

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones planned changes to this revision. edward-jones added a comment. I'm reworking this at the moment and adding some tests. Standby! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 __

r373743 - [NFCI] Improve the -Wbool-operation's warning message

Author: xbolva00 Date: Fri Oct 4 05:55:13 2019 New Revision: 373743 URL: http://llvm.org/viewvc/llvm-project?rev=373743&view=rev Log: [NFCI] Improve the -Wbool-operation's warning message Based on the request from the post commit review. Also added one new test. Modified: cfe/trunk/include

[PATCH] D68458: [clangd] Collect missing macro references.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68458/new/ https://reviews.llvm.org/D68458 _

[clang-tools-extra] r373739 - [clangd] update the package-lock.json.

Author: hokein Date: Fri Oct 4 05:35:16 2019 New Revision: 373739 URL: http://llvm.org/viewvc/llvm-project?rev=373739&view=rev Log: [clangd] update the package-lock.json. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package-lock.json Modified: clang-tools-extra/trunk/clang

[PATCH] D68459: [clang-rename] Fix a crash when renaming a class without definition.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68459 Files: clang/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp clang/test/clang-rename/ForwardClassDecl.cpp Index: clang/

r373712 - [Driver] NFC: Remove duplicate call to getLibGccType

Author: c-rhodes Date: Fri Oct 4 01:26:37 2019 New Revision: 373712 URL: http://llvm.org/viewvc/llvm-project?rev=373712&view=rev Log: [Driver] NFC: Remove duplicate call to getLibGccType Reviewed By: saugustine Differential Revision: https://reviews.llvm.org/D68380 Modified: cfe/trunk/lib/

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

rnk accepted this revision. rnk added a comment. In D67847#1691898 , @jyknight wrote: > The `abort()` function raises SIGABRT, for which the default behavior is to > trigger a coredump. Do we actually want that behavior? > > Either `_exit()` (long availab

[PATCH] D68458: [clangd] Collect missing macro references.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Semantic highlghting is missing a few macro references. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D68388: [PR41008][OpenCL] Support restrict keyword in C++ mode

kpet added a comment. Something I should probably have explained in the commit message is that the functionality provided by `restrict` is already present in C++, where it is already exposed using different keywords. If you look at `clang/include/clang/Basic/TokenKinds.def`, there are `__restri

[PATCH] D68388: [PR41008][OpenCL] Support restrict keyword in C++ mode

Anastasia added a comment. Can you please explain why we are deviating from C++ on this? My concern is that this can potentially uncover bugs in C++ parsing due to un-handled restrict cases that would have to be fixed in some unclear way... I would appreciate more detailed analysis before we go

[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

sammccall added a comment. Thanks, rL373724 should fix. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67541/new/ https://reviews.llvm.org/D67541 ___ cfe-commits mailing list cfe-com

  1   2   >