[PATCH] D68009: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68009/new/ https://reviews.llvm.org/D68009 ___ cfe-co

[PATCH] D68009: [Driver] Always use -z separate-loadable-segments with lld on Fuchsia

MaskRay created this revision. MaskRay added reviewers: jakehehrlich, mcgrathr, phosek. Herald added a project: clang. Herald added a subscriber: cfe-commits. The option was added to lld in D67481 /372807. Repository: rC Clang https://reviews.llvm.org/D68009

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. Keep in mind that for static linking you will need something that pulls-in a symbol from the pass static library. In this patch, `NewPMDriver.cpp` does it for `opt` by calling `get##Ext##PluginInfo()`. In clang, it is `BackendUtil.cpp`. But nothing for `bugpoint` hen

r372802 - [x86] Adding support for some missing intrinsics: _castf32_u32, _castf64_u64, _castu32_f32, _castu64_f64

Author: pengfei Date: Tue Sep 24 19:24:05 2019 New Revision: 372802 URL: http://llvm.org/viewvc/llvm-project?rev=372802&view=rev Log: [x86] Adding support for some missing intrinsics: _castf32_u32, _castf64_u64, _castu32_f32, _castu64_f64 Summary: Adding support for some missing intrinsics: _ca

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

vsk updated this revision to Diff 221645. vsk retitled this revision from "[Mangle] Add flag to asm labels to disable global prefixing" to "[Mangle] Add flag to asm labels to disable '\01' prefixing". vsk edited the summary of this revision. vsk added a comment. - Address latest round of comment

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

efriedma added a subscriber: rsmith. efriedma added a comment. Does this have any significant impact on -fsyntax-only performance? Hopefully @rsmith can take a quick look at the use of ConstantExpr here; I think it's fine, but we don't use ConstantExpr like that elsewhere. Co

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

rjmccall added inline comments. Comment at: clang/lib/AST/Mangle.cpp:130 + return; +} + vsk wrote: > rjmccall wrote: > > This is actually backwards, right? A literal label is one that doesn't get > > the global prefix and therefore potentially needs th

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. In D67978#1681388 , @ABataev wrote: > In D67978#1681333 , @lildmh wrote: > > > In D67978#1681319 , @ABataev wrote: > > > > > In D67978#1681318

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur requested changes to this revision. Meinersbur added inline comments. This revision now requires changes to proceed. Comment at: llvm/test/Feature/load_extension.ll:1 +; RUN: not test -f %llvmshlibdir/libBye%shlibext || opt %s -load=%llvmshlibdir/libBye%shlibext -good

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

vsk added inline comments. Comment at: clang/lib/AST/Mangle.cpp:130 + return; +} + rjmccall wrote: > This is actually backwards, right? A literal label is one that doesn't get > the global prefix and therefore potentially needs the `\01` prefix to > s

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

phosek added a comment. @dankm is it OK if we take over this change to push it forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits mailing

[PATCH] D67992: [Sema] Add FunctionTypeUnwrapper

leonardchan created this revision. leonardchan added a reviewer: rsmith. leonardchan added a project: clang. Herald added a subscriber: kristof.beyls. This is a fix for PR43315. An assertion error is hit for this minimal example: //clang -cc1 -triple x86_64-- -S tstVMStructRC-min.cpp #define

[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102 // expected-error@-2{{implicit declaration of function 'get_sub_group_size' is invalid in Open

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1681333 , @lildmh wrote: > In D67978#1681319 , @ABataev wrote: > > > In D67978#1681318 , @lildmh wrote: > > > > > Without this patch, it ca

[PATCH] D67980: [WIP][CLANG][BPF] implement clang __builtin_bitfield_info() intrinsic

yonghong-song updated this revision to Diff 221598. yonghong-song edited the summary of this revision. yonghong-song added a comment. builtin return u32 instead of u64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67980/new/ https://reviews.llvm.o

[PATCH] D67573: Fix __atomic_is_lock_free's return type.

jyknight added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67573/new/ https://reviews.llvm.org/D67573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

dmikulin created this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, Prazek. Herald added projects: clang, Sanitizers, LLVM. Fix for https://bugs.llvm.org/show_bug.cgi?id=43390 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67985 Files: clang/lib/

[PATCH] D67982: [ObjC] Add some additional test cases around pointer conversions.

jyknight added a comment. (See https://reviews.llvm.org/D67983 for the proposed behavior change.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67982/new/ https://reviews.llvm.org/D67982 ___ cfe-commit

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight added a comment. Note that the test-case diffs are on top of https://reviews.llvm.org/D67982, which I split out to make the actual change in behavior in this commit clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67983/new/ https:/

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

jyknight created this revision. jyknight added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. For example, in Objective-C mode, the initialization of 'x' in: @implementation MyType + (void)someClassMethod { MyType *x = self; } @end is cor

[PATCH] D67982: [ObjC] Add some additional test cases around pointer conversions.

jyknight created this revision. jyknight added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is especially important for Objective-C++, which is entirely missing this testing at the moment. This annotates with "FIXME" the cases which I change in

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. In D67978#1681319 , @ABataev wrote: > In D67978#1681318 , @lildmh wrote: > > > Without this patch, it cannot recognize array with mapper, for instance, > > `#pragma omp target map(mapper(a),

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1681318 , @lildmh wrote: > Without this patch, it cannot recognize array with mapper, for instance, > `#pragma omp target map(mapper(a),to: arr[0:2])` won't work without this > patch. What if we have a mapper for the

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. Without this patch, it cannot recognize array with mapper, for instance, `#pragma omp target map(mapper(a),to: arr[0:2])` won't work without this patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67978/new/ https://reviews.llvm.org/D67

[PATCH] D67980: [WIP][CLANG][BPF] implement clang __builtin_bitfield_info() intrinsic

yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. Herald added a project: clang. Herald added a subscriber: cfe-commits. The patch is still work in progress. The signature: u64 __builtin_bitfield_info(bitfield_member_access) return value: ret >> 16 : bitfi

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge updated this revision to Diff 221583. nridge added a comment. Updated to use a new "dependent type" highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67901/new/ https://reviews.llvm.org/D67901 Files: clang-tools-extra/clangd/Sema

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:181 + addToken(E->getMemberLoc(), E->getQualifier() + ? HighlightingKind::StaticField +

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

zturner added a reviewer: krasimir. zturner added a comment. What's the status of this patch, out of curiosity? It doesn't seem there were any objections to the original idea, just that nobody with ownership over clang-format is still actively participating in the review. +krasimir to maybe sh

r372775 - [NFC] Strenghten preconditions for warning

Author: xbolva00 Date: Tue Sep 24 13:10:57 2019 New Revision: 372775 URL: http://llvm.org/viewvc/llvm-project?rev=372775&view=rev Log: [NFC] Strenghten preconditions for warning Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL: http://llvm.org/

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 221578. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: include/clang/AST/OpenMPClause.h lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/CGStmtOpenMP.cpp lib/CodeGen/C

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. What happens without this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67978/new/ https://reviews.llvm.org/D67978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh created this revision. lildmh added reviewers: ABataev, Meinersbur, hfinkel, jdoerfert. lildmh added a project: OpenMP. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This patches fixes the case when a user-defined mapper is attached to the elements of an a

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

yaxunl added a comment. In D67509#1679524 , @tra wrote: > In D67509#1678394 , @yaxunl wrote: > > > A reduced test case is > > > > struct A { > > A(); > > }; > > > > template > > struct B > > { > >

[PATCH] D67947: [HIP] Support new kernel launching API

This revision was automatically updated to reflect the committed changes. Closed by commit rL372773: [HIP] Support new kernel launching API (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

r372773 - [HIP] Support new kernel launching API

Author: yaxunl Date: Tue Sep 24 12:16:40 2019 New Revision: 372773 URL: http://llvm.org/viewvc/llvm-project?rev=372773&view=rev Log: [HIP] Support new kernel launching API Differential Revision: https://reviews.llvm.org/D67947 Modified: cfe/trunk/include/clang/Basic/LangOptions.def cfe/t

[PATCH] D67935: Add `#pragma clang deprecated`, used to deprecate macros

erik.pilkington planned changes to this revision. erik.pilkington added a comment. Marking as "planned changes" to get this out of review queues. Aaron Ballman wants to add "macro attributes", which would be a better way of solving this problem, and is going to ask the C and C++ committees if th

[PATCH] D60748: Fix i386 struct and union parameter alignment

kib added a comment. In fact, can we have an option controlling this ? Does it have anything to do with -malign-data gcc switch ? We do want to be able to optionally generate code ABI-compatible with modern gcc, per user discretion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/lib/AST/APValue.cpp:599 Out << '[' << Path[I].getAsArrayIndex() << ']'; -ElemTy = Ctx.getAsArrayType(ElemTy)->getElementType(); +ElemTy = cast(ElemTy)->getElementType(); } aaron.ballma

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221568. Tyker marked 7 inline comments as done. Tyker added a comment. fixed most comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/A

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHe

[PATCH] D60748: Fix i386 struct and union parameter alignment

emaste added a comment. In D60748#1499756 , @dim wrote: > Please also exclude FreeBSD from these changes, since we care a lot about > backwards compatibility, and specifically about alignment requirements. (We > have run into many issues in our ports co

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

rjmccall added a comment. If that's tractable, then that does seem like the best solution. You can commit this if you need a shorter-term fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 ___ cf

[PATCH] D67973: [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. Currently, some tests use homegrown matchers to handle `llvm::Expected` values. This revision standardizes on EXPECT_THAT_EXPECTED and `HasValue`. Repository: rG LLVM Github Monorepo https:/

[PATCH] D67385: Pass -mcmodel to LTO plugin

khchen added a comment. In D67385#1680959 , @tejohnson wrote: > In D67385#1680942 , @khchen wrote: > > > @tejohnson for example: > > > > $ clang -flto a.c -c -o a.o > > $ llvm-ar q a.a a.o // archive li

[PATCH] D67971: [WIP] Add warning when zero-initializing a union if its first member is not is largest

leonardchan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This may result in the entire union not being initialized. For example: union U { uint32_t x; uint64_t y; }; void func() { U u = {}; ... } Some might assume that `

[PATCH] D67216: [cfi] Add flag to always generate call frame information

JohnReagan added a comment. Does the current code generate all the prologue cfi directives? Epilogue too? The last time I checked, it did not (especially for epilogues). Fully asynch prologue/epilogue is one of the things that we need for OpenVMS and will be doing that work. We're also looking

Re: [PATCH] D67216: [cfi] Add flag to always generate call frame information

Does the current code generate all the prologue cfi directives?  Epilogue too?  The last time I checked, it did not (especially for epilogues). Fully asynch prologue/epilogue is one of the things that we need for OpenVMS and will be doing that work.  We're also looking at using the compact format

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(O

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov added a comment. I believe all comments were addressed. PTAL and let me know if I missed something. Comment at: clang-tools-extra/clangd/FindTarget.h:93 + /// in 'obj.foo'. + const Expr* MemberExprBase = nullptr; +}; kadircet wrote: > do we hav

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov updated this revision to Diff 221556. ilya-biryukov marked 8 inline comments as done. ilya-biryukov added a comment. - Remove ExprMemberBase - Add an overload for Decl* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67826/new/ https://

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

atanasyan accepted this revision. atanasyan added a comment. LGTM. But before commit get more approvals. For example, from echristo, code owners of other targets, etc. I would keep the as-is. In that case a target of such huge modifications looks a bit more clear. CHANGES SINCE LAST ACTION

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

ymandel updated this revision to Diff 221554. ymandel added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67969/new/ https://reviews.llvm.org/D67969 Files: clang/include/clang/Tooling/Refactoring/Stencil.h clang/lib/Too

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision adds `run`, a StencilPart that runs a user-defined function that computes a result over `MatchFinder::MatchResult`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 3 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHe

[PATCH] D67385: Pass -mcmodel to LTO plugin

tejohnson added a comment. In D67385#1680942 , @khchen wrote: > @tejohnson for example: > > $ clang -flto a.c -c -o a.o > $ llvm-ar q a.a a.o // archive libraries > $ clang -flto a.a b.c -O2 -o main -mcmodel=small > > > In above case

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(O

[PATCH] D67385: Pass -mcmodel to LTO plugin

khchen added a comment. @tejohnson for example: $ clang -flto a.c -c -o a.o $ llvm-ar q a.a a.o // archive libraries $ clang -flto a.a b.c -O2 -o main -mcmodel=small In above case user need to aware that passing `-Wl,-plugin-opt=-code-model=small` to plugin is necessary. I

Re: [PATCH] D67216: [cfi] Add flag to always generate call frame information

That said, prior art in gcc in this area: -fasynchronous-unwind-tables Generate unwind table in DWARF format, if supported by target machine. The table is exact at each instruction boundary, so it can be used for stack unwinding from asynchronous events (such as debugger or garbage collector). -

[PATCH] D67947: [HIP] Support new kernel launching API

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67947/new/ https://reviews.llvm.org/D67947 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D67216: [cfi] Add flag to always generate call frame information

keith.walker.arm added a comment. I feel that using a -g option make more sense. Maybe -gdwarf-frame, or -gdwarf-frame-always might be more user friendly as it relates more to the DWARF section created rather than the section content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHe

[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102 // expected-error@-2{{implicit declaration of function 'get_sub_group_size' is invalid in OpenCL}} +// expected-error@-3{{implicit conversion

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(O

[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102 // expected-error@-2{{implicit declaration of function 'get_sub_group_size' is invalid in OpenCL}} +// expected-error@-3{{implicit conversion changes signedness: 'int' to 'uint'

[PATCH] D67713: [OpenCL] Add image query builtin functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67713/new/ https://reviews.llvm.org/D67713 ___

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3372 + if (Phase == phases::IfsMerge) { +assert(Phase == PL.back() && "merging must be final compilation step."); +MergerInputs.push_back(Current); Does the interface me

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

cishida added inline comments. Comment at: clang/include/clang/Driver/Options.td:635 + Flags<[CC1Option]>, Group, + HelpText<"Generate Inteface Stub Files, emit merged text not binary.">; def iterface_stub_version_EQ : JoinedOrSeparate<["-"], "interface-stub-version=">, Flags

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHe

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

yaxunl added a comment. In D67837#1679670 , @rjmccall wrote: > Okay. And it's okay to fall down to the code below when functions are used > in both ways this way? This part of code is for delayed checking of hostness. If a host function calls device f

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Szelethus added a comment. I have no objections on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67877/new/ https://reviews.llvm.org/D67877 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D67964: [clangd] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This would enable the newly-added semantic selection feature in vscode. Repository: rG LLVM Github Monorepo https://r

[PATCH] D67949: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities

This revision was automatically updated to reflect the committed changes. Closed by commit rL372760: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

r372760 - [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities

Author: paulhoad Date: Tue Sep 24 07:00:06 2019 New Revision: 372760 URL: http://llvm.org/viewvc/llvm-project?rev=372760&view=rev Log: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities Summary: https://bugs.llvm.org/show_bug.cgi?id=36858 identifies .hh as

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372753: [clangd] Add semantic selection to ClangdLSPServer. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[clang-tools-extra] r372753 - [clangd] Add semantic selection to ClangdLSPServer.

Author: usaxena95 Date: Tue Sep 24 06:38:33 2019 New Revision: 372753 URL: http://llvm.org/viewvc/llvm-project?rev=372753&view=rev Log: [clangd] Add semantic selection to ClangdLSPServer. Summary: This adds semantic selection to the LSP Server. Adds support for serialization of input request and

[PATCH] D67826: [clangd] A helper to find explicit references and their names

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:96 +}; +llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, ReferenceLoc R); + ilya-biryukov wrote: > kadircet wrote: > > Is this for tes

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221534. usaxena95 added a comment. Removed ununsed header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

ymandel updated this revision to Diff 221531. ymandel added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67961/new/ https://reviews.llvm.org/D67961 Files: clang/include/clang/Tooling/Refactoring/MatchConsumer.h clang/i

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision introduces a separate (small) library for the `MatchConsumer` abstraction: computations over AST match results. This abstraction is central to the Transformer framework, and there dese

[clang-tools-extra] r372752 - [clangd] Save an unnecessary copy, NFC.

Author: hokein Date: Tue Sep 24 06:25:38 2019 New Revision: 372752 URL: http://llvm.org/viewvc/llvm-project?rev=372752&view=rev Log: [clangd] Save an unnecessary copy, NFC. Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp URL

[PATCH] D67960: [clangd] Move the existing heder-source-switch implemenation out of clangdServer.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is a NFC change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67960 Files: clang-tools-extra

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Jiboo added a comment. Here you go: https://bugs.llvm.org/show_bug.cgi?id=43430 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67877/new/ https://reviews.llvm.org/D67877 ___ cfe-commits mailing list cfe

r372749 - [Diagnostics] Handle tautological left shifts in boolean context

Author: xbolva00 Date: Tue Sep 24 06:14:18 2019 New Revision: 372749 URL: http://llvm.org/viewvc/llvm-project?rev=372749&view=rev Log: [Diagnostics] Handle tautological left shifts in boolean context Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaC

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

lebedev.ri added a subscriber: tstellar. lebedev.ri added a comment. Actually, uh oh. @Jiboo can you please file this as a bug? This really should go into next patch release. CC @tstellar @Szelethus this breaks LLVMExports.cmake as compared with LLVM-8, so it's actually a critical bug. Reposit

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Comment at: clang-tools-extra/clangd/Protocol.cpp:18 #include "llvm/ADT/Hashing.h" +#include "llvm/ADT/STLExtras.h" #include "llvm/ADT/SmallString.h" --

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:365 +- background indexing canb be disable by the ``--background-index=false`` flag; + if it is disabled, clangd doesn't have a global view of the whole project, it + only has a view on sym

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein updated this revision to Diff 221523. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/ https://reviews.llvm.org/D66937 Files: clang-tools-extra/doc

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov updated this revision to Diff 221522. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Use DeclRefExpr::getFoundDecl, add a test - Update a comment - Remove redundant anon namespace declaration - Remove :wa - Do not filter-out macro references - Docume

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov marked 9 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:432 + Ref = ReferenceLoc{ + E->getQualifierLoc(), E->getNameInfo().getLoc(), {E->getDecl()}}; +} kadircet wr

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1169 +Result.emplace_back(render(std::move(*Ranges))); +return Reply(std::move(Result)); + }); hokein wrote: > does `Reply({render(std::move(*Ranges))})

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221521. usaxena95 marked 9 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tool

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

kadircet added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:363 -- Pass an experimental `-background-index` command line argument. With - this feature enabled, clangd incrementally builds an index of projects - that you work on and uses the jus

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHe

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein added a comment. mostly good, a few nits. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { + if (Params.positions.size() != 1) { +elog("{0} positions provided to SelectionRange. Supports exactly one " usaxena95 w

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added a comment. > The SelectionRangeClientCapabilities determines what should the LSP server > send the client, if it is true, clangd should send > SelectionRangeRegistrationOptions. > But looking at the current specification, it doesn't seem to add too much > value. I think we can

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221510. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tool

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:363 -- Pass an experimental `-background-index` command line argument. With - this feature enabled, clangd incrementally builds an index of projects - that you work on and uses the just-

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein updated this revision to Diff 221508. hokein marked 8 inline comments as done. hokein added a comment. Herald added a subscriber: usaxena95. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/ https://reviews.llvm.org/

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein updated this revision to Diff 221509. hokein added a comment. fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/ https://reviews.llvm.org/D66937 Files: clang-tools-extra/docs/clangd/Installation.rst Index: clang-tools-e

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

This revision was automatically updated to reflect the committed changes. Closed by commit rL372725: [clangd] Collect macros in the preamble region of the main file (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

  1   2   >