[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL372689: [clang-format] NFC clang-format the clang-format unit tests (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r372689 - [clang-format] NFC clang-format the clang-format unit tests

Author: paulhoad Date: Mon Sep 23 23:35:37 2019 New Revision: 372689 URL: http://llvm.org/viewvc/llvm-project?rev=372689&view=rev Log: [clang-format] NFC clang-format the clang-format unit tests Summary: It is annoying that the clang-format tests aren't themselves clang-formatted, if you use a f

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

uabelho added a comment. In D67613#1679879 , @xbolva00 wrote: > /srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/modularize/Modularize.cpp:583:13: > warning: enumeration values 'lang_cxx_11' and 'lang_cxx

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221469. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221467. plotfi added a comment. tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.t

[PATCH] D67940: [BPF] Preserve and make bitfield access relocatable

yonghong-song updated this revision to Diff 221466. yonghong-song added a comment. Herald added a subscriber: ormris. fix a bug like `foo(..., bar(&value), value)` where `value` is set in function `bar`. This is not right and depends on compiler optimization as there is not guarantee that argume

r372688 - [ASTImporter] 3rd attempt to fix Windows buildbot test errors

Author: martong Date: Mon Sep 23 22:50:02 2019 New Revision: 372688 URL: http://llvm.org/viewvc/llvm-project?rev=372688&view=rev Log: [ASTImporter] 3rd attempt to fix Windows buildbot test errors Modified: cfe/trunk/unittests/AST/ASTImporterODRStrategiesTest.cpp Modified: cfe/trunk/unittests

r372687 - Revert "[static analyzer] Define __clang_analyzer__ macro in driver"

Author: jkorous Date: Mon Sep 23 20:21:22 2019 New Revision: 372687 URL: http://llvm.org/viewvc/llvm-project?rev=372687&view=rev Log: Revert "[static analyzer] Define __clang_analyzer__ macro in driver" This reverts commit fbd13570b0d5f92ef2cf6bcfe7cc2f6178500187. Removed: cfe/trunk/test/Ana

r372685 - Revert "[static analyzer][test] Test directly that driver sets D__clang_analyzer__"

Author: jkorous Date: Mon Sep 23 20:19:20 2019 New Revision: 372685 URL: http://llvm.org/viewvc/llvm-project?rev=372685&view=rev Log: Revert "[static analyzer][test] Test directly that driver sets D__clang_analyzer__" This reverts commit c7541903d72765a38808e9973572a8d50c9d94fb. Modified: c

Re: r372679 - [static analyzer] Define __clang_analyzer__ macro in driver

Well, those were not fixups in the sense that I was aware of anything broken... Anyway, I don't see a quick fix for clang-tidy so I'm going to revert. > On Sep 23, 2019, at 8:00 PM, Nico Weber wrote: > > Even after all the fixup attempts, there's still a failing clang-tools-extra > test: > >

Re: r372679 - [static analyzer] Define __clang_analyzer__ macro in driver

Even after all the fixup attempts, there's still a failing clang-tools-extra test: ninja: Entering directory `out/gn' [0/2] ACTION //clang-tools-extra/test:check-clang-tools(//llvm/utils/gn/build/toolchain:unix) -- Testing: 787 tests, 64 threads -- Testing: 0 .. 10 FAIL: Clang Tools :: clang-tidy/

[PATCH] D67947: [HIP] Support new kernel launching API

yaxunl created this revision. yaxunl added a reviewer: tra. https://reviews.llvm.org/D67947 Files: include/clang/Basic/LangOptions.def include/clang/Driver/Options.td lib/CodeGen/CGCUDANV.cpp lib/Driver/ToolChains/Clang.cpp lib/Frontend/CompilerInvocation.cpp lib/Sema/SemaCUDA.cpp t

r372683 - [static analyzer][test] Test directly that driver sets D__clang_analyzer__

Author: jkorous Date: Mon Sep 23 19:06:59 2019 New Revision: 372683 URL: http://llvm.org/viewvc/llvm-project?rev=372683&view=rev Log: [static analyzer][test] Test directly that driver sets D__clang_analyzer__ Follow-up to fbd13570b0d Modified: cfe/trunk/test/Analysis/misc-driver.c Modified:

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221453. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

xbolva00 added a comment. Did you run it with the linux kernel? It could be interesting cc @nickdesaulniers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67122/new/ https://reviews.llvm.org/D67122 ___

[PATCH] D67932: [analyzer] Fix accidentally skipping the call during inlined defensive check suppression.

NoQ marked an inline comment as done. NoQ added a comment. Yeah, i think we should avoid such peeking and instead try to do everything in one pass. I.e., if we need to peek at the node above us, just make a visitor that delays the decision until it has precisely the information it needs. I gues

r372681 - Support for DWARF-5 C++ language tags.

Author: adrian Date: Mon Sep 23 17:38:49 2019 New Revision: 372681 URL: http://llvm.org/viewvc/llvm-project?rev=372681&view=rev Log: Support for DWARF-5 C++ language tags. This patch provides support for DW_LANG_C_plus_plus_11, DW_LANG_C_plus_plus_14 tags in the Clang C++ frontend. Patch by Sour

r372680 - [static analyzer] Remove --analyze-auto

Author: jkorous Date: Mon Sep 23 17:37:25 2019 New Revision: 372680 URL: http://llvm.org/viewvc/llvm-project?rev=372680&view=rev Log: [static analyzer] Remove --analyze-auto Differential Revision: https://reviews.llvm.org/D67934 Modified: cfe/trunk/docs/ClangCommandLineReference.rst cfe/

r372679 - [static analyzer] Define __clang_analyzer__ macro in driver

Author: jkorous Date: Mon Sep 23 17:33:47 2019 New Revision: 372679 URL: http://llvm.org/viewvc/llvm-project?rev=372679&view=rev Log: [static analyzer] Define __clang_analyzer__ macro in driver Differential Revision: https://reviews.llvm.org/D67938 Added: cfe/trunk/test/Analysis/misc-driver.

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

xbolva00 added a comment. In D66046#1634055 , @sylvestre.ledru wrote: > You should also probably add a note in the release notes (maybe for the > others changes too) > thanks for the work btw! +1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

JDevlieghere added a comment. I reverted this in r372672 because it caused a test failure in LLDB: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/1748/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 _

r372672 - Revert "Support for DWARF-5 C++ language tags."

Author: jdevlieghere Date: Mon Sep 23 16:49:36 2019 New Revision: 372672 URL: http://llvm.org/viewvc/llvm-project?rev=372672&view=rev Log: Revert "Support for DWARF-5 C++ language tags." This reverts commit bf9c8ffb54943c6d77398adbedddf05ef9724007. Modified: cfe/trunk/include/clang/AST/DeclC

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach updated this revision to Diff 221433. dmaclach added a comment. Updated based on review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67865/new/ https://reviews.llvm.org/D67865 Files: clang-tidy/objc/AvoidOSReadCheck.cpp clang-tidy/objc/AvoidOSReadCheck.h clang-tidy/objc

[PATCH] D67940: [BPF] Preserve and make bitfield access relocatable

yonghong-song created this revision. yonghong-song added reviewers: ast, eli.friedman. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya. Herald added projects: clang, LLVM. Previous work for BPF CO-RE (compile once, run everywhere) tries to record structure, union and arra

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. > This makes the IR self-contained, which is good, but it also make the > interpretation of the IR modal, which isn't great. It means that suddenly the > rules of interpretation of what is valid to do or not changes according to > this module flag. I think the origin

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/objc-avoid-osread.rst:26 + +The OSRead* functions from libkern/OSByteOrder.h have undocumented dependencies on aligned reads due to type punning by casting through a pointer: + Please highl

[PATCH] D67932: [analyzer] Fix accidentally skipping the call during inlined defensive check suppression.

Szelethus added a comment. Hmm, so before this patch, we just used `LVNode` everywhere and ignored `InputNode`. It may not have made much sense, but its still not as confusing as using both if the creation of `LVNode` is unnecessary overall. Could we just remove it? Comment

r372668 - [NFCI] Return PathSensitiveBugReport where appropriate

Author: xiaobai Date: Mon Sep 23 15:24:47 2019 New Revision: 372668 URL: http://llvm.org/viewvc/llvm-project?rev=372668&view=rev Log: [NFCI] Return PathSensitiveBugReport where appropriate Some compilers have trouble converting unique_ptr to unique_ptr causing some functions to fail to compile. C

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

xbolva00 added a comment. /srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/modularize/Modularize.cpp:583:13: warning: enumeration values 'lang_cxx_11' and 'lang_cxx_14' not handled in switch [-Wswitch] 1 warning generated. Repository: rL LLV

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach marked 5 inline comments as done. dmaclach added inline comments. Comment at: clang-tidy/objc/AvoidOSReadCheck.cpp:21 +void AvoidOSReadCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee((functionDecl(hasAnyName(

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach updated this revision to Diff 221420. dmaclach added a comment. Fixed up review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67865/new/ https://reviews.llvm.org/D67865 Files: clang-tidy/objc/AvoidOSReadCheck.cpp clang-tidy/objc/AvoidOSReadCheck.h clang-tidy/ob

r372664 - [Diagnostics] Warn for enum constants in bool context (-Wint-in-bool-context; GCC compatibility)

Author: xbolva00 Date: Mon Sep 23 15:09:49 2019 New Revision: 372664 URL: http://llvm.org/viewvc/llvm-project?rev=372664&view=rev Log: [Diagnostics] Warn for enum constants in bool context (-Wint-in-bool-context; GCC compatibility) Extracted from D63082. Modified: cfe/trunk/include/clang/B

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL372663: Support for DWARF-5 C++ language tags. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

r372663 - Support for DWARF-5 C++ language tags.

Author: adrian Date: Mon Sep 23 15:01:49 2019 New Revision: 372663 URL: http://llvm.org/viewvc/llvm-project?rev=372663&view=rev Log: Support for DWARF-5 C++ language tags. This patch provides support for DW_LANG_C_plus_plus_11, DW_LANG_C_plus_plus_14 tags in the Clang C++ frontend. Patch by Sour

[PATCH] D67935: Add `#pragma clang deprecated`, used to deprecate macros

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. This patch adds support for `#pragma clang deprecated`, which emits a deprecated warning whenever it is encountere

[PATCH] D67932: [analyzer] Fix accidentally skipping the call during inlined defensive check suppression.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Got myself distracted with a tiny fix

[PATCH] D65841: [Driver] Switch -stdlib++-isystem test to -###-verbatim

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65841/new/ https://reviews.llvm.org/D65841 ___

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

rjmccall added inline comments. Comment at: clang/include/clang/Basic/Attr.td:734 +// TODO: Make it possible to specify this in source. +BoolArgument<"LiteralLabel"> + ]; `LiteralLabel` is an unfortunate name for this property because `getLiteralLabel`

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

tlively planned changes to this revision. tlively added a comment. It sounds reasonable to check this from the backend instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67739/new/ https://reviews.llvm.org/D67739

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

rjmccall added a comment. Okay. And it's okay to fall down to the code below when functions are used in both ways this way? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 ___ cfe-commits mailing l

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/APValue.h:618 } + const CXXRecordDecl **getMemberPointerPathPtr(); }; Tyker wrote: > aaron.ballman wrote: > > We're horribly inconsistent

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added a comment. 2nd attempt to fix the windows build errors: 372646 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 ___ cfe-commits mailing list cfe-commits@lists.llvm

r372646 - [ASTImporter] 2nd attempt to fix Windows buildbot test errors

Author: martong Date: Mon Sep 23 12:49:45 2019 New Revision: 372646 URL: http://llvm.org/viewvc/llvm-project?rev=372646&view=rev Log: [ASTImporter] 2nd attempt to fix Windows buildbot test errors Modified: cfe/trunk/unittests/AST/ASTImporterODRStrategiesTest.cpp Modified: cfe/trunk/unittests

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

vsk updated this revision to Diff 221391. vsk marked 3 inline comments as done. vsk added a comment. - Address latest review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 ___ cfe-commits mailing lis

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221384. Tyker marked 12 inline comments as done. Tyker retitled this revision from "[clang] Improve Serialization/Imporing of APValues" to "[clang] Improve Serialization/Imporing/Dumping of APValues". Tyker edited the summary of this revision. Tyker added a comm

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/include/clang/AST/APValue.h:618 } + const CXXRecordDecl **getMemberPointerPathPtr(); }; aaron.ballman wrote: > We're horribly inconsistent in this class, but because the other private > member functions go with

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm not python expert but as this is a comment I don't see any issue. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38446/new/ https://rev

[PATCH] D67843: DisableFormat also now disables SortIncludes

MyDeveloperDay added a subscriber: klimek. MyDeveloperDay added a comment. I basically agree with all the comments, I agree with you that I doubt its ever used in SortIncludes:true and DisableFormat:true, I just saw this as a hole that probably based on Myrums Law (https://www.hyrumslaw.com/) m

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good - thanks! Comment at: llvm/include/llvm/ADT/iterator_range.h:27-33 +template +constexpr bool is_random_iterator() { + return std::is_same< +typename std

[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier added a comment. In D67843#1679529 , @thakis wrote: > 4. Make it so that if DisableFormat is explicitly set to true and > SortIncludes isn't explicitly set, then it disables SortIncludes. Or, put a > different way, when DisableFormat is set, set

[PATCH] D67843: DisableFormat also now disables SortIncludes

thakis added a comment. 4. Make it so that if DisableFormat is explicitly set to true and SortIncludes isn't explicitly set, then it disables SortIncludes. Or, put a different way, when DisableFormat is set, set SortIncludes to false at that point. Then an explicit `DisableFormat: true; SortInc

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

tra added a comment. In D67509#1678394 , @yaxunl wrote: > A reduced test case is > > struct A { > A(); > }; > > template > struct B > { > T a; > constexpr B() = default; > }; > > B x; > > > > `B::B()` got implicit `__host__

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372640: [Sema] Fix the atomic expr rebuilding order. (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood marked an inline comment as done. dgatwood added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:23 + Finder->addMatcher(objcMethodDecl(hasDeclContext( + objcCategoryDecl())).bind(CustomCategoryMethodIdentifi

[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier added a comment. In D67843#1677983 , @MyDeveloperDay wrote: > I assume the intention was that users could have DisableFormat=true and > SortIncludes=true when they want to sort the includes but not perform any > additional formatting in the cod

r372640 - [Sema] Fix the atomic expr rebuilding order.

Author: hliao Date: Mon Sep 23 11:48:06 2019 New Revision: 372640 URL: http://llvm.org/viewvc/llvm-project?rev=372640&view=rev Log: [Sema] Fix the atomic expr rebuilding order. Summary: - Rearrange the atomic expr order to the API order when rebuilding atomic expr during template instantiation.

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 221355. Szelethus added a comment. The following words are echoing in my ears as I'm knowingly going completely against them: In D45532#1083670 , @NoQ wrote: > I'm asking for this because it's, like, actually diffi

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 221376. jpakkane added a comment. Added MathHeader documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tools-extra/c

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao updated this revision to Diff 221375. hliao added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/ https://reviews.llvm.org/D67924 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaChecking.cpp clang/l

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao updated this revision to Diff 221374. hliao added a comment. add test case for compare_exchange. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/ https://reviews.llvm.org/D67924 Files: clang/include/clang/Sema/Sema.h clang/lib/Se

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added a comment. Seems your test changes have disappeared as well? Otherwise, 1 comment then I'm ok with this. Comment at: clang/lib/Sema/TreeTransform.h:3319 +Range, Range, RParenLoc, SubExprs, Op, +/*AtomicArgumentOrder*/ Sema::AtomicArgumentOrder

r372635 - [OPENMP]Use standard parsing for 'match' clause, NFC.

Author: abataev Date: Mon Sep 23 11:13:31 2019 New Revision: 372635 URL: http://llvm.org/viewvc/llvm-project?rev=372635&view=rev Log: [OPENMP]Use standard parsing for 'match' clause, NFC. Reused standard clauses parsing scheme for parsing/matching 'match' clause in 'declare variant' directive. M

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao updated this revision to Diff 221369. hliao added a comment. revised Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/ https://reviews.llvm.org/D67924 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaChecking.cpp clang/

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added a comment. Also, can you add a test for GNUCmpXchg in both situations (inside a template, and outside)? It is the most complicated, and would best reflect the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/ https:/

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added a comment. It kinda stinks that we have to do this at such a late step. I'd have much preferred doing this as a part of the rebuild, but it appears that the 'form' takes quite a bit to calculate. Also, I'd likely have preferred that the initial reordering happened in codegen

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

rsmith added a comment. In D59754#1665601 , @thakis wrote: > Another question about this, sorry. Do you know _why_ C++20 is more > restrictive than C99 wrt "mixture of designated and non-designated > initializers in the same initializer list is a C99 ext

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao updated this revision to Diff 221365. hliao added a comment. Add parameter name for that default argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/ https://reviews.llvm.org/D67924 Files: clang/include/clang/Sema/Sema.h cl

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao added a comment. In D67924#1679409 , @erichkeane wrote: > Yikes, good catch! > > Would we be better off instead to just modify how the other switch loads the > value? Presumably something like, "if (NeedsRearrangeArgs) > SubExprs.append(Args.begin

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added a comment. Trying to fix in svn commit 372633. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

r372633 - [ASTImporter] Attempt to fix Windows buildbot test errors

Author: martong Date: Mon Sep 23 10:29:08 2019 New Revision: 372633 URL: http://llvm.org/viewvc/llvm-project?rev=372633&view=rev Log: [ASTImporter] Attempt to fix Windows buildbot test errors Modified: cfe/trunk/unittests/AST/ASTImporterODRStrategiesTest.cpp Modified: cfe/trunk/unittests/AST

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:3319 +return getSema().BuildAtomicExpr(Range, Range, RParenLoc, SubExprs, Op, + true); } When passing a bool, use the comment syntax /*paramnam

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added a comment. Yikes, good catch! Would we be better off instead to just modify how the other switch loads the value? Presumably something like, "if (NeedsRearrangeArgs) SubExprs.append(Args.begin(), Args.end()); else /*the switch*/. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao created this revision. hliao added a reviewer: erichkeane. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. hliao added a comment. The current BuildAtomicExpr expects the arguments to be in the API order instead of the AST order. If RebuildAtomicExpr uses the same

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao added a comment. The current BuildAtomicExpr expects the arguments to be in the API order instead of the AST order. If RebuildAtomicExpr uses the same BuildAtomicExpr, it needs to ensure the order of arguments are in API order; otherwise, arguments (especially the one with memory order) w

r372631 - NFC: Fix a poorly-written test

Author: epilk Date: Mon Sep 23 10:16:55 2019 New Revision: 372631 URL: http://llvm.org/viewvc/llvm-project?rev=372631&view=rev Log: NFC: Fix a poorly-written test The author of r364954 foolishly forgot that == binds tighter than ?: Modified: cfe/trunk/test/SemaCXX/constexpr-builtin-bit-cast.

[clang-tools-extra] r372627 - [Clang-doc] NFC: Fixed link to llvm bugs in documentation

Author: sureyeaah Date: Mon Sep 23 09:55:13 2019 New Revision: 372627 URL: http://llvm.org/viewvc/llvm-project?rev=372627&view=rev Log: [Clang-doc] NFC: Fixed link to llvm bugs in documentation Modified: clang-tools-extra/trunk/docs/clang-doc.rst Modified: clang-tools-extra/trunk/docs/clang-

Re: [PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

Thanks, for reaching out to me. I am looking into it. Gabor On Mon, Sep 23, 2019 at 5:44 PM Simon Pilgrim via Phabricator < revi...@reviews.llvm.org> wrote: > RKSimon added a comment. > > @martong This is failing on windows buildbots: > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expens

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674597 , @aprantl wrote: > Please be sure the watch the lldb (and other debugger) bots after committing > this.. Could you please commit these changes. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D67899: Fix __is_fundamental to accept nullptr_t

zoecarver closed this revision. zoecarver added a comment. Resolved by rL372624 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67899/new/ https://reviews.llvm.org/D67899 ___

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

tejohnson added a comment. In D61634#1635595 , @tejohnson wrote: > I had some time to work on this finally late last week. I decided the most > straightforward thing was to implement the necessary interface changes to the > TLI analysis to make it requir

r372624 - Fix __is_fundamental to accept nullptr_t

Author: zoecarver Date: Mon Sep 23 09:02:46 2019 New Revision: 372624 URL: http://llvm.org/viewvc/llvm-project?rev=372624&view=rev Log: Fix __is_fundamental to accept nullptr_t Summary: This patch updates the __is_fundamental builtin type trait to return true for nullptr_t. Reviewer

r372623 - [OPENMP]Fix PR43355: DO not emit target calls if only -fopenmp-targets

Author: abataev Date: Mon Sep 23 08:53:51 2019 New Revision: 372623 URL: http://llvm.org/viewvc/llvm-project?rev=372623&view=rev Log: [OPENMP]Fix PR43355: DO not emit target calls if only -fopenmp-targets is not provided. We should not emit any target-dependent code if only -fopenmp flag is used

r372621 - Fix __is_signed builtin

Author: zoecarver Date: Mon Sep 23 08:41:20 2019 New Revision: 372621 URL: http://llvm.org/viewvc/llvm-project?rev=372621&view=rev Log: Fix __is_signed builtin Summary: This patch fixes the __is_signed builtin type trait to work with floating point types and enums. Now, the builtin will

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

ilya-biryukov added a comment. @MyDeveloperDay, added you on the assumption that you are interested in all things about `clang-format`. Hope the change is relevant, let me know if not. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38446/new/ https://reviews.llvm

[PATCH] D67897: Fix __is_signed builtin

zoecarver closed this revision. zoecarver added a comment. Resolved by rL372621 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67897/new/ https://reviews.llvm.org/D67897 ___

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/Sema/warn-conditional-emum-types-mismatch.c:19 + +int get_flag_anon_enum(int cond) { + return cond ? A : C; Gcc warns here, but Clang does not warn when A != C.. So not

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

RKSimon added a comment. @martong This is failing on windows buildbots: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/19808 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 _

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

ilya-biryukov added a comment. In D67501#1679050 , @xyb wrote: > `-normalized-header-filter`. I'd like this idea. Any objections? Having two solution for filter is unfortunate - making both discoverable and documenting why we need them is hard. If there

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 updated this revision to Diff 221346. xbolva00 added a comment. Added test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67919/new/ https://reviews.llvm.org/D67919 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/Sema/warn-conditiona

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov updated this revision to Diff 221345. ilya-biryukov marked 18 inline comments as done. ilya-biryukov added a comment. Herald added subscribers: jfb, mgrang. - Add simple tests - Address other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov added a comment. Added some tests too. More tests for dependent constructs are still missing, but please take a look at what we have for now. Comment at: clang-tools-extra/clangd/FindTarget.cpp:373 + DeclRelation::TemplateInstantiation)) && +

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 created this revision. xbolva00 added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Useful warning - GCC compatibility Repository: rC Clang https://reviews.llvm.org/D67919 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/S

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

yaxunl updated this revision to Diff 221341. yaxunl added a comment. revised by John's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 Files: lib/Sema/Sema.cpp test/SemaCUDA/openmp-static-func.cu Index: test/SemaCUDA/openmp-static

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/APValue.h:537-540 +private: + void setLValueEmptyPath(LValueBase B, const CharUnits &O, unsigned Size, + bool OnePastTheEnd, bool IsNullPtr); + LValuePathEntry *getLValuePathPtr();

[PATCH] D67897: Fix __is_signed builtin

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1165 Note that this currently returns true for enumeration types if the underlying - type is signed, and returns false for floating-point types, in viola

[PATCH] D67385: Pass -mcmodel to LTO plugin

tejohnson added a comment. In D67385#1679127 , @khchen wrote: > @tejohnson when I run the `clang -flto -Wl,-plugin-opt=-help` command, it > shows the > > --code-model= - Choose code model > =tiny

[PATCH] D67385: Pass -mcmodel to LTO plugin

khchen added a comment. @tejohnson when I run the `clang -flto -Wl,-plugin-opt=-help` command, it shows the --code-model= - Choose code model =tiny- Tiny code model =small

[clang-tools-extra] r372617 - [clangd] Simplify the callside of URI::resolve, NFC.

Author: hokein Date: Mon Sep 23 07:39:37 2019 New Revision: 372617 URL: http://llvm.org/viewvc/llvm-project?rev=372617&view=rev Log: [clangd] Simplify the callside of URI::resolve, NFC. Summary: - Add a overrloded URI::resolve, which accepts a string URI; - also fixed some callside that don't che

[PATCH] D67916: [clangd] Simplify the callside of URI::resolve, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372617: [clangd] Simplify the callside of URI::resolve, NFC. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

  1   2   >