[PATCH] D67323: [NewPM][Sancov] Create the Sancov Pass after building the pipelines

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM to fix folks broken by this. That said, we should look for a way to test this in a follow up patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D67323: [NewPM][Sancov] Create the Sancov Pass after building the pipelines

leonardchan created this revision. leonardchan added reviewers: chandlerc, phosek. leonardchan added a project: Sanitizers. Herald added subscribers: cryptoad, kristof.beyls. Herald added a project: clang. We're running into linker errors from missing sancov sections: ld.lld: error: relocation

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

cishida added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3688 .Case("experimental-ifs-v1", "experimental-ifs-v1") - .Default(""); + .Default("experimental-ifs-v1"); nit: no need to check `ArgStr`

[PATCH] D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

aaron.ballman closed this revision. aaron.ballman added a comment. In D64644#1661417 , @Mordante wrote: > Thanks for the review. > Could you commit this patch? I don't have commit access. Happy to do so -- I've commit in r371320. CHANGES SINCE LAST AC

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 ___ cfe-commits mailing lis

r371320 - Fixes an assertion while instantiating a template with an incomplete typo-corrected type.

Author: aaronballman Date: Sat Sep 7 13:14:09 2019 New Revision: 371320 URL: http://llvm.org/viewvc/llvm-project?rev=371320&view=rev Log: Fixes an assertion while instantiating a template with an incomplete typo-corrected type. Fixes PR35682. When a template in instantiated with an incomplete t

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth added inline comments. Comment at: clang/test/Profile/misexpect-branch-cold.c:4 +// RUN: llvm-profdata merge %S/Inputs/misexpect-branch.proftext -o %t.profdata +// RUN: %clang_cc1 %s -O2 -o - -disable-llvm-passes -emit-llvm -fprofile-instrument-use-path=%t.profdata -ve

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

aaronpuchert added a comment. I'm thinking about the following, but I'm not sure if that's the proper way to do it. --- a/clang/cmake/modules/AddClang.cmake +++ b/clang/cmake/modules/AddClang.cmake @@ -174,8 +174,11 @@ macro(add_clang_symlink name dest) endmacro() function(clang_

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

aaronpuchert created this revision. aaronpuchert added reviewers: akyrtzi, beanz, tstellar. Herald added subscribers: cfe-commits, arphaman, dexonsmith, mgorny. Herald added a project: clang. aaronpuchert added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:115

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

aaronpuchert added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:115 +clang_target_link_libraries(libclang + PRIVATE + ${CLANG_LIB_DEPS} This might not be correct for static builds, I think we need `INTERFACE` here. Repository: rG LLVM Gi

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus added a comment. Hmm, we could make a redundant assignments checker: if a variable has multiple reaching definitions, but those all assign the same value, emit a warning. We could even use fixits with that. void t(int a) { if (coin()) a = 2; // note: reaching def else

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 219240. Tyker added a comment. Changes: - Rebased - Fixed typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Basic/DiagnosticASTKinds.td c

[PATCH] D67037: [ClangFormat] Add new style option IndentGotoLabels

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM, just some minor Nits Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1354 Line->Tokens.begin()->Tok->MustBreakBefore = true; -

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

steakhal added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:118 /// Check for CWE-134: Uncontrolled Format String. - static const char MsgUncontrolledFormatString[]; + static constexpr llvm::StringLiteral MsgUncontrolledFormatString = +

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 219226. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn marked an inline comment as done. zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{},

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri accepted this revision. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Okay, thank you for the patience, this looks good to me now too. Please update patch description/subject - this patch is not a standalone tool. Comment at: clang/test/Pro