[PATCH] D66862: Make lround builtin constexpr (and others)

zoecarver created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66862 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/math-builtins.cpp Index: clang/test/SemaCXX/math-builtins.c

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. Sorry for the break. Unfortunately the patch does not apply cleanly anymore. Can you rebase to latest trunk? I surprisingly did not know about `__declspec(selectany)`. I still think having the symbol only defined in that loadable module, but not in the statically li

[PATCH] D66783: [clang-doc] Use llvm::createStringError and canonicalize error messages

This revision was automatically updated to reflect the committed changes. Closed by commit rL370155: [clang-doc] Use llvm::createStringError and canonicalize error messages (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

[clang-tools-extra] r370155 - [clang-doc] Use llvm::createStringError and canonicalize error messages

Author: maskray Date: Tue Aug 27 19:56:03 2019 New Revision: 370155 URL: http://llvm.org/viewvc/llvm-project?rev=370155&view=rev Log: [clang-doc] Use llvm::createStringError and canonicalize error messages "Bad block found.\n" -> "bad block found" The lower cased form with no full stop or newlin

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver added a comment. Thanks for the explanation. Should I then not try to "fix" the issue? Or should I update sema checking? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839

[PATCH] D66360: Expose constructing a virtual method dispatch through the include/clang/CodeGen APIs.

pschuh updated this revision to Diff 217566. pschuh added a comment. Herald added a subscriber: mgorny. Your suggestions of pulling the builder out as an API and exposing CGCallee made everything a lot simpler. Unfortunately, I had to split the CGCallee header because it threatened to pull EHSco

r370151 - Fixup build of clang-interpreter example after change in r370122.

Author: dyung Date: Tue Aug 27 19:13:24 2019 New Revision: 370151 URL: http://llvm.org/viewvc/llvm-project?rev=370151&view=rev Log: Fixup build of clang-interpreter example after change in r370122. This should fix the build failure on llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast. Modified: cfe

[PATCH] D66668: [OPENMP][Analysis] Add analysis of the map clauses.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yes please! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8/new/ https://reviews.llvm.org/D8 ___ cfe-commit

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

Szelethus marked 10 inline comments as done. Szelethus added a comment. In D66765#1646237 , @NoQ wrote: > I approve the patch and i don't see anything obvious that we're missing out > (@Szelethus, your GSoC isn't on by default back in 9.0, only in master,

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

Szelethus updated this revision to Diff 217564. Szelethus added a comment. Fixing inlines! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66765/new/ https://reviews.llvm.org/D66765 Files: clang/docs/ClangStaticAnalyzer.rst clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes

[PATCH] D66847: [analyzer] Fix analyzer warnings.

NoQ added a comment. Filed the remaining false positive back on myself as https://bugs.llvm.org/show_bug.cgi?id=43135. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66847/new/ https://reviews.llvm.org/D66847 ___ cfe-commits mailing list cf

[PATCH] D66847: [analyzer] Fix analyzer warnings.

NoQ added a comment. In D66847#1648209 , @Szelethus wrote: > if (isa(D)) { > const auto *FD = dyn_cast(D); // warn: D is known to be a > FunctionDecl, prefer using cast<> > // ... > } > In D66847#1648339

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

This revision was automatically updated to reflect the committed changes. Closed by commit rL370143: [Clang][Bundler] Do not require host triple for extracting device bundles (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D66847: [analyzer] Fix analyzer warnings.

Szelethus added a comment. Another common mistake is this: if (A) { const auto *B = dyn_cast_or_null(A); // warn: A is known to be non-null, prefer dyn_cast } CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66847/new/ https://reviews.llvm.org/D66847 __

r370143 - [Clang][Bundler] Do not require host triple for extracting device bundles

Author: sdmitriev Date: Tue Aug 27 18:26:13 2019 New Revision: 370143 URL: http://llvm.org/viewvc/llvm-project?rev=370143&view=rev Log: [Clang][Bundler] Do not require host triple for extracting device bundles Bundler currently requires host triple to be provided no matter if you are performing

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, Nathan-Huckleberry. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. Instead, emit them under -Wformat-pedantic. This is particularly important for us because we have a lo

Re: r370083 - Change the X86 datalayout to add three address spaces for 32 bit signed,

llvm-project/lld/test/ELF/lto/Inputs/drop-debug-info.bc needs to be updated http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/34675/steps/check-lld%20msan/logs/stdio /usr/local/google/home/vitalybuka/slow/bbot/llvm_build/bin/ld.lld -shared /usr/local/google/home/vitalybuka/slow/

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

NoQ added a comment. Mmm, i don't know what was that commit meant to fix. Your evaluation looks fairly sufficient for turning it on by default. Let's make it an on-by-default option and flip the flag back into off-by-default if it turns out to be somehow broken. Comment at:

r370142 - Revert "Change the X86 datalayout to add three address spaces for 32 bit signed, "

Author: vlad.tsyrklevich Date: Tue Aug 27 18:08:54 2019 New Revision: 370142 URL: http://llvm.org/viewvc/llvm-project?rev=370142&view=rev Log: Revert "Change the X86 datalayout to add three address spaces for 32 bit signed," This reverts commit r370083 because it caused check-lld failures on san

r370141 - Fix "commas at the end of enumerator lists are a C99-specific"

Author: vitalybuka Date: Tue Aug 27 18:04:50 2019 New Revision: 370141 URL: http://llvm.org/viewvc/llvm-project?rev=370141&view=rev Log: Fix "commas at the end of enumerator lists are a C99-specific" Modified: cfe/trunk/include/clang-c/Index.h Modified: cfe/trunk/include/clang-c/Index.h URL:

[PATCH] D66847: [analyzer] Fix analyzer warnings.

NoQ added a comment. I mean, such code should indeed be refactored to query the custom RTTI only once, but given that it's locally obvious that there's no null dereference in this code, we should not be emitting a warning on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66847/new/

[PATCH] D66847: [analyzer] Fix analyzer warnings.

NoQ marked an inline comment as done. NoQ added a comment. In D66847#1648209 , @Szelethus wrote: > > if the dyn_ part is really necessary here, then you crash with a null > > dereference a few lines below because you didn't check the result > > Hmm, can w

[PATCH] D66850: Avoid crash when dumping NULL Type as JSON

piscisaureus updated this revision to Diff 217545. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850 Files: clang/lib/AST/JSONNodeDumper.cpp Index: clang/lib/AST/JSONNodeDumper.cpp

[PATCH] D66847: [analyzer] Fix analyzer warnings.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. > if the dyn_ part is really necessary here, then you crash with a null > dereference a few lines below because you didn't check the result Hmm, can we detect things like this?: if (i

[PATCH] D66850: Do not attempt visit child nodes of NULL type

piscisaureus created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66850 Files: clang/include/clang/AST/ASTNodeTraverser.h Index: clang/include/clang/AST/ASTNodeTraverser.h ===

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370130: [ObjC] Fix type checking for qualified id block parameters. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai added a comment. Thanks for the fast review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66831/new/ https://reviews.llvm.org/D66831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

r370130 - [ObjC] Fix type checking for qualified id block parameters.

Author: vsapsai Date: Tue Aug 27 17:25:06 2019 New Revision: 370130 URL: http://llvm.org/viewvc/llvm-project?rev=370130&view=rev Log: [ObjC] Fix type checking for qualified id block parameters. When checking if block types are compatible, we are checking for compatibility their return types and p

[PATCH] D66847: [analyzer] Fix analyzer warnings.

NoQ updated this revision to Diff 217537. NoQ edited the summary of this revision. NoQ added a comment. Use `auto` in one more place. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66847/new/ https://reviews.llvm.org/D66847 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/

[PATCH] D66847: [analyzer] Fix analyzer warnings.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. They ain't gonna fix themselves... wel

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL370129: Re-land [clang-scan-deps] Minimizer: Correctly handle multi-line content with… (authored by aganea, committed by )

r370129 - Re-land [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

Author: aganea Date: Tue Aug 27 17:04:06 2019 New Revision: 370129 URL: http://llvm.org/viewvc/llvm-project?rev=370129&view=rev Log: Re-land [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings Previously, an #error directive with quoted, multi-line content, a

[PATCH] D66839: Fix stack address builtin for negative numbers

efriedma added a comment. We usually prefer to generate error messages for incorrect parameters to builtins in SemaChecking.cpp. I don't think there's really an infinite loop here. The parameter to __builtin_frame_address is an unsigned integer; values greater than 0x7FFU aren't special.

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

rsmith added a comment. Do we need `KnownModules` at all? It seems to serve a very similar purpose to the `Modules` string map on `ModuleMap`. (The main difference seems to be that `KnownModules` can cache module load failures.) If we can keep only a single data structure tracking this, owned b

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

jcai19 marked 3 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +- New :doc:`bugprone-posix-return + ` check. Eugene.Zelenko wrote: > Check is not new, just modified. Such check should be after new

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

jcai19 updated this revision to Diff 217532. jcai19 added a comment. Fix format and test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66627/new/ https://reviews.llvm.org/D66627 Files: clang-tools-extra/clang-tidy/bugprone/PosixReturnChec

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

rnk added a comment. I'm not sure what happens, but I see you added .gitattributes. I'd commit it as is. Buildbots using svn will keep working. You can check that the monorepo has the right line endings afterwards, and try again if not. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D665

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

dexonsmith added a comment. In D66556#1648109 , @rnk wrote: > I'm not sure what happens, but I see you added .gitattributes. I'd commit it > as is. Buildbots using svn will keep working. You can check that the monorepo > has the right line endings afterw

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetNum != 1)) { Error = true; ---

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217528. paulkirth added a comment. Add comment to clarify choice of operands and reasoning about profiling metadata Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Fi

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 217527. aganea added subscribers: jyknight, rnk. aganea added a comment. In D66556#1647669 , @arphaman wrote: > Will the git monorepo handle `svn:eol-style` correctly? Other files in the repo already use `svn:eol-styl

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

zoecarver added a comment. Seems like a very useful function. `__max_representable_int_for_float` also seems useful. Should this work in C++03? If so there are a few changes that need to be made. It would also be great if this could be a `constexpr` (but, obviously, not necessary). =

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev updated this revision to Diff 217522. sdmitriev marked an inline comment as done. sdmitriev added a comment. Added tests for each file type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 Files: clang/test/Driver/clang-offload-bundl

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands(); paulkirth wrote: > n

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66831/new/ https://reviews.llvm.org/D66831 ___ cfe-commits mailing list cfe-commi

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zoecarver added reviewers: kparzysz, eli.friedman. zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/test/Sema/builtin-stackaddress

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/test/Sema/builtin-stackaddress.c:10 +// expected-error@+1 {{argument to '__builtin_return_address' must be a constant integer}} +return __builtin_return_address(x); }

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal added a comment. @Szelethus The mispositioned report message was my fault. I used a different version of clang for the analysis and to upload the results, which resulted in some mispositioned reports. I've fixed the linked CodeChecker instance. CHANGES SINCE LAST ACTION https://revi

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands();

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

EricWF created this revision. EricWF added reviewers: mclow.lists, ldionne. Herald added subscribers: libcxx-commits, dexonsmith, christof. This is needed anytime we need to clamp an arbitrary floating point value to an integer type. Repository: rCXX libc++ https://reviews.llvm.org/D66836 F

r370123 - [preprocessor] Add an opportunity to retain excluded conditional blocks

Author: emankov Date: Tue Aug 27 15:15:32 2019 New Revision: 370123 URL: http://llvm.org/viewvc/llvm-project?rev=370123&view=rev Log: [preprocessor] Add an opportunity to retain excluded conditional blocks It is handy for clang tooling, for instance, in source to source transformation. Reviewers

[PATCH] D66797: ArrayRef'ized CompilerInvocation::CreateFromArgs

This revision was automatically updated to reflect the committed changes. Closed by commit rL370122: ArrayRef'ized CompilerInvocation::CreateFromArgs (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r370122 - ArrayRef'ized CompilerInvocation::CreateFromArgs

Author: gribozavr Date: Tue Aug 27 15:13:31 2019 New Revision: 370122 URL: http://llvm.org/viewvc/llvm-project?rev=370122&view=rev Log: ArrayRef'ized CompilerInvocation::CreateFromArgs Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66797 Modified: cf

[PATCH] D66834: Driver tests: set `--sysroot` to "" to support toolchains with default sysroot

broadwaylamb created this revision. broadwaylamb added reviewers: rsmith, sfantao, sepavloff. Herald added a project: clang. Herald added a subscriber: cfe-commits. When testing clang that has been compiled with `-DDEFAULT_SYSROOT` set to some path, the test `VFSGCCInstallation` would fail, becau

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

dyung added a comment. In D64931#1647880 , @dyung wrote: > Hi, this is causing 3 test failures on the PS4 linux bot. The changes may not > have been initially flagged because a different issue was causing a build > failure which masked the problem. I hav

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

rsmith added a comment. This isn't the right approach: instead of re-instantiating the parameter when we encounter a use of it, we should inject the parameters into the local instantiation scope before trying to instantiate a default argument (`Sema::CheckCXXDefaultArgExpr` should call `addInst

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

rnk added a comment. This change needs a clang CodeGen test to show that we generate IR with `__ptr32` / `__ptr64` in the correct places. We should already have some semantic tests, but we may need more. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1874 +case LangAS::ptr

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

dyung added a comment. Hi, this is causing 3 test failures on the PS4 linux bot. The changes may not have been initially flagged because a different issue was causing a build failure which masked the problem. I have bisected the test failures to this change though. http://lab.llvm.org:8011/bui

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dexonsmith added a comment. Herald added a subscriber: wuzish. Is this still a problem? I'd be interested to understand *why* the preprocessor is going away here. Is the `CompilerInstance` being reused for two different compilations? Is that what we should fix instead? Repository: rC Clan

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

This revision was automatically updated to reflect the committed changes. Closed by commit rL370115: [Clang][Bundler] Fix for a hang when unbundling fat binary (authored by sdmitriev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: clang/test/SemaObjC/block-type-safety.m:141 genericBlock = block; +block = genericBlock; // expected-error {{incompatible block pointer types assigning to 'NSAllArray *(^)(id)' from 'id

r370116 - [clang][Index][NFC] Move IndexDataConsumer default implementation

Author: jkorous Date: Tue Aug 27 14:49:39 2019 New Revision: 370116 URL: http://llvm.org/viewvc/llvm-project?rev=370116&view=rev Log: [clang][Index][NFC] Move IndexDataConsumer default implementation Modified: cfe/trunk/include/clang/Index/IndexDataConsumer.h cfe/trunk/lib/Index/IndexingA

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands(); paulkirth wrote: > n

r370115 - [Clang][Bundler] Fix for a hang when unbundling fat binary

Author: sdmitriev Date: Tue Aug 27 14:47:52 2019 New Revision: 370115 URL: http://llvm.org/viewvc/llvm-project?rev=370115&view=rev Log: [Clang][Bundler] Fix for a hang when unbundling fat binary clang-offload-bundler tool may hang under certain conditions when it extracts a subset of all availab

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai created this revision. vsapsai added reviewers: erik.pilkington, arphaman. Herald added subscribers: ributzka, dexonsmith, jkorous. When checking if block types are compatible, we are checking for compatibility their return types and parameters' types. As these types have different varianc

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth abandoned this revision. paulkirth added a comment. This is being abandoned in favor of D66324 , which reimplements this logic completely in the LLVM backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked 3 inline comments as done. paulkirth added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands();

[PATCH] D65694: Properly instantiate a decltype in argument's default initializer

comex added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65694/new/ https://reviews.llvm.org/D65694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D66830: Consumed checker: various improvements

comex created this revision. comex added reviewers: delesley, dblaikie, rsmith. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. - Treat arguments to constructor calls the same way as arguments to other calls (fixes 42856). Previously, arguments t

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217494. paulkirth added a comment. Change check for minimum number of metadata operands. Branch weights must have at least 3 elements: metadata name, and a list of at least 2 branch weights Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217491. paulkirth marked 2 inline comments as done. paulkirth added a comment. Remove namespace qualifier & insert check for number of arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https:

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

BlackAngel35 requested changes to this revision. BlackAngel35 added a comment. This revision now requires changes to proceed. In D66564#1640584 , @Eugene.Zelenko wrote: > Please mention new module and check in Release Notes. CHANGES SINCE LAST ACTION

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66598/new/ https://reviews.llvm.org/D66598 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

lebedev.ri added a comment. In D65300#1647775 , @paulkirth wrote: > In D65300#1647746 , @lebedev.ri > wrote: > > > Please can you clarify hat's the current layout of these patches? > > Is this patch required, or i

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth added a comment. In D65300#1647746 , @lebedev.ri wrote: > Please can you clarify hat's the current layout of these patches? > Is this patch required, or is it superseded by D66324 > (and thus should be abandone

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

dexonsmith added a comment. In D66556#1647762 , @dexonsmith wrote: > In D66556#1646229 , @aganea wrote: > > > This failed the build - I've changed `unix2dos` to `svn:eol-style CRLF` > > instead. > > > Can we count

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

NoQ added a comment. > Do you think its ever okay to find a last store in a `BlockEdge`? *In a `BlockEntrance` into an empty block (that has no elements but does have a terminator). At least that's what your code is fixing. Attaching store notes to such program points is most likely not ok. We

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

dexonsmith added a comment. In D66556#1646229 , @aganea wrote: > This failed the build - I've changed `unix2dos` to `svn:eol-style CRLF` > instead. Can we count on `tr` when we have `shell`? If so, I suggest this instead: // REQUIRES: shell // RUN

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:295 return StringRef(); - +CurBundleInfo = NextBundleInfo++; return CurBundleInfo->first(); ABataev

[PATCH] D66828: [clangd] Add distinct highlightings for static fields and methods

nridge created this revision. nridge added reviewers: hokein, ilya-biryukov, jvikstrom. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66828 Files: clang-tools-extra/cla

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:295 return StringRef(); - +CurBundleInfo = NextBundleInfo++; return CurBundleInfo->first(); Maybe just: ``` const BundleInfo &Bundle = *CurBundleI

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

lebedev.ri added a comment. Please can you clarify hat's the current layout of these patches? Is this patch required, or is it superseded by D66324 (and thus should be abandoned)? I'd like to begin reviewing, but i don't understand where to start. Repository:

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev updated this revision to Diff 217485. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66598/new/ https://reviews.llvm.org/D66598 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/tools/clang-offload-bundl

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:150 +// Operand 0 is a string tag "branch_weights" +if (MDString *Tag = cast(MD->getOperand(0))) { + unsigned NOps = MD->getNumOperands(); Sorry if I'm going b

r370108 - Diagnose _Bool as a C99 extension.

Author: aaronballman Date: Tue Aug 27 13:33:05 2019 New Revision: 370108 URL: http://llvm.org/viewvc/llvm-project?rev=370108&view=rev Log: Diagnose _Bool as a C99 extension. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/trunk/test/Parser/c99.c Modified: cfe/trunk/lib/Parse/ParseDecl.cp

[PATCH] D66667: Debug Info: Support for DW_AT_export_symbols for anonymous structs

This revision was automatically updated to reflect the committed changes. Closed by commit rG528f5da6d862: Debug Info: Support for DW_AT_export_symbols for anonymous structs (authored by shafik). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D7?vs=217457&i

[PATCH] D66822: Hardware cache line size builtins

zoecarver added a comment. > BTW, I note that facebook uses 128 bytes for x86 They also use 64 for arm which is interesting (the opposite of this patch). Also, see this comment in the same snippet: > We assume a cache line size of 64, so we use a cache line pair size of 128 Which would indicat

r370107 - Debug Info: Support for DW_AT_export_symbols for anonymous structs

Author: shafik Date: Tue Aug 27 13:17:35 2019 New Revision: 370107 URL: http://llvm.org/viewvc/llvm-project?rev=370107&view=rev Log: Debug Info: Support for DW_AT_export_symbols for anonymous structs This implements the DWARF 5 feature described in: http://dwarfstd.org/ShowIssue.php?issue=141212

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:301 assert(CurBundleInfo != BundlesInfo.end() && "Invalid reader info!"); ++CurBundleInfo; } Just notic

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Szelethus added a comment. In D66716#1647668 , @NoQ wrote: > I don't understand. Isn't widening supposed to happen //after we exit the > loop//? The loop isn't over yet when the bug is being reported. Why is this > problem widening-specific? Given that w

[PATCH] D66822: Hardware cache line size builtins

zoecarver added a comment. We should probably tell people never to use this, period. That being said, I like your idea of having it be a constant. The only issue would be when, in the next few years, people start shipping CPUs with 256-byte-wide cache lines. Repository: rG LLVM Github Monore

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev added a comment. Sure. The main unbundling loop looks as follows (see loop on line 745) while (!Worklist.empty()) { StringRef CurTriple = FH.get()->ReadBundleStart(Input); if (CurTriple.empty()) break; auto Output = Worklist.find(CurTriple); if (Output == W

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked 6 inline comments as done. paulkirth added inline comments. Comment at: llvm/include/llvm/IR/DiagnosticInfo.h:1009 +public: + DiagnosticInfoMisExpect(const Function &Fn, const Twine &Msg, + const DiagnosticLocation &Loc = DiagnosticLocat

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217479. paulkirth added a comment. Removes unused constructor, reformat code, and remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 Files: clang/include

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang created this revision. akhuang added reviewers: rnk, rsmith. Herald added subscribers: llvm-commits, cfe-commits, erik.pilkington, hiraditya, nhaehnle, jvesely, jholewinski. Herald added projects: clang, LLVM. Previously, these qualifiers were being parsed but otherwise ignored. This chan

[PATCH] D66822: Hardware cache line size builtins

jyknight added a comment. numbers for cacheline size. In D66822#1647664 , @zoecarver wrote: > > Passing-by remark: i'm not sure it is possible to **guarantee** that this > > will be always correct and that no ABI break will happen. > > You're right. I sh

[PATCH] D66822: Hardware cache line size builtins

zoecarver added a comment. It may be a good idea only to enable this when `-march=native`. And _maybe_ remove the constexpr requirement (though it would make this feature significantly less useful it would also make it significantly more accurate). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D66723: [clangd] Add a distinct highlighting for local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG86a4a530f435: [clangd] Add a distinct highlighting for local variables (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D66723?vs=217065&id=217476#toc Repository: rG LLVM Githu

  1   2   3   >