[PATCH] D63607: [DO NOT SUBMIT] [clang][driver] Prototype --driver-mode=fortran support for new flang

Hahnfeld added a comment. Even though I know you didn't send the email yet, can you please upload the diff with full context? Thanks :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 _

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker updated this revision to Diff 205944. Tyker marked an inline comment as done. Tyker added a comment. made the requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63376/new/ https://reviews.llvm.org/D63376 Files: clang/include/clang/AST/ASTContext.h clang/include/

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

Tyker added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10298 + bool AllowFold = true, + bool StoreResult = true); ExprResult VerifyIntegerConstantExpression(Expr *E, llvm:

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

craig.topper added a comment. I'm going to try to work on the X86 tests. Can we hold off on committing those? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63174/new/ https://reviews.llvm.org/D63174 __

[PATCH] D63498: [RISC-V] Add -msave-restore and -mno-save-restore to clang driver

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks! There was some discussion about the potential stdout+stderr merging issues http://lists.llvm.org/pipermail/llvm-dev/2017-February/110469.html but I don't think it resulted in any new

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke added reviewers: 01alchemist, 4tXJ7f. fanjinke added a comment. Hi, Please help with the patch reveiw. Hi cryptoad, @cryptoad IS there anything incorrectly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/ https://reviews.llvm

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Eh, this seems close enough now. I'd like a better approach for the x86 builtins, but no idea what it will end up being. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

chandlerc added reviewers: davidxl, tejohnson. chandlerc added a comment. See inline comment, but I think we should just drop the testing of the function attribute bit here rather than adjusting the pipeline. Comment at: llvm/lib/Passes/PassBuilder.cpp:665-668 +// We must

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63156/new/ https://reviews.llvm.org/D63156 _

Re: LLVM buildmaster will be off-line for about 30 minutes today at 5 pm

Hello everyone, I was investigating the buildbot e-mail notifications. Some of you may receive old notifications, some might get some notifications again. Please ignore them. Sorry for the inconvenience and thanks for your understanding. Thanks Galina On Thu, Jun 20, 2019 at 3:41 PM Galina K

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

arphaman updated this revision to Diff 205938. arphaman added a comment. Use the shared stream as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63579/new/ https://reviews.llvm.org/D63579 Files: clang/include/clang/Frontend/Utils.h clang/lib/Frontend/DependencyFile.cpp

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

nemanjai created this revision. nemanjai added reviewers: hfinkel, jsji, rzurob, saghir. Herald added a subscriber: kbarton. Herald added a project: clang. As we currently have it implemented in altivec.h, the offsets for these two intrinsics are element offsets. The documentation in the ABI (as

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan added a comment. In D63617#1552615 , @rnk wrote: > Even if `BRK #0xF000` is a Windows convention, it's still possible for ISel > to select different instructions for different OSs, and I'd prefer to > implement it that way. Ok, did the implement

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

NoQ added a comment. Oh, wait, no, loops. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

NoQ added a comment. In D62883#1552969 , @xazax.hun wrote: > In D62883#1552870 , @Szelethus wrote: > > > - Uniqueing already tracked conditions as an (`Expr`, `ExplodedNode`) pair > > instead of on `Expr` > > > I w

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

xazax.hun added a comment. In D62883#1552870 , @Szelethus wrote: > - Now using `CFGBlock::getTerminatorConditionExpr()` > - Uniqueing already tracked conditions as an (`Expr`, `ExplodedNode`) pair > instead of on `Expr` I would be surprised to see the s

[PATCH] D62888: [NewPM] Port Sancov

leonardchan added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1231-1232 + MPM.addPass(ModuleSanitizerCoveragePass(SancovOpts)); + MPM.addPass( + createModuleToFunctionPassAdaptor(SanitizerCoveragePass(SancovOpts))); +} c

[PATCH] D62888: [NewPM] Port Sancov

leonardchan updated this revision to Diff 205922. leonardchan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ https://reviews.llvm.org/D62888 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32 +class DependencyCollectorFactory { +public: aganea wrote: > arphaman wrote: > > aganea wrote: > > > Do you envision future u

[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/android/PosixReturnCheck.h:1 +//===--- PosixReturnCheck.h - clang-tidy*- C++ -*-// +// Please use - before *- C++ -* to fill line. See other checks as exam

[PATCH] D62619: [analyzer][IDF] Add a control dependency calculator + a new debug checker

Szelethus updated this revision to Diff 205917. Szelethus added a comment. Rebase on previous patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62619/new/ https://reviews.llvm.org/D62619 Files: clang/include/clang/Analysis/Analyses/Dominators.h clang/include/clang/Analysis/CFG

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus added a comment. Gentle ping :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus updated this revision to Diff 205916. Szelethus marked an inline comment as done. Szelethus added a comment. - Now using `CFGBlock::getTerminatorConditionExpr()` - Uniqueing already tracked conditions as an (`Expr`, `ExplodedNode`) pair instead of on `Expr` - Add a `TODO:` about caching

LLVM buildmaster will be off-line for about 30 minutes today at 5 pm

Hello everyone, LLVM buildmaster will be off-line for about 30 minutes today after 5 pm PST for maintenance. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

This revision was automatically updated to reflect the committed changes. Closed by commit rG73986707bd57: [CodeGen][test] Use FileCheck variable matchers for better test support (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

r363996 - [CodeGen][test] Use FileCheck variable matchers for better test support

Author: rupprecht Date: Thu Jun 20 15:35:52 2019 New Revision: 363996 URL: http://llvm.org/viewvc/llvm-project?rev=363996&view=rev Log: [CodeGen][test] Use FileCheck variable matchers for better test support Summary: Depending on how clang is built, it may discard the IR names and use names like

r363995 - [analyzer] DeadStores: Update the crude suppression for files generated by IIG.

Author: dergachev Date: Thu Jun 20 15:29:40 2019 New Revision: 363995 URL: http://llvm.org/viewvc/llvm-project?rev=363995&view=rev Log: [analyzer] DeadStores: Update the crude suppression for files generated by IIG. They changed the comments that we were looking for. Modified: cfe/trunk/lib/

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

rnk added a comment. Thanks. This is surprisingly the first time I've heard of fdiscard-value-names. Seems useful, since now you can test your IR both ways without having to completely recompile clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D63625 _

r363994 - [X86] Change LL to O in the definitions for the vp2intersect builtins.

Author: ctopper Date: Thu Jun 20 15:19:16 2019 New Revision: 363994 URL: http://llvm.org/viewvc/llvm-project?rev=363994&view=rev Log: [X86] Change LL to O in the definitions for the vp2intersect builtins. This is needed to support OpenCL where long long is 128 bits. This was done for the other b

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

rupprecht added a comment. Sounds good, changed to use variable matching instead. This passes w/ either `-fno-discard-value-names` or `-fdiscard-value-names` used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

rupprecht updated this revision to Diff 205912. rupprecht added a comment. - Use filecheck variable matching instead of an explicit -fno-discard-value-names option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538 ___ cfe-commits mailing list cfe-commits@

[PATCH] D63538: [analyzer][CFG] Return the correct terminator condition

Szelethus updated this revision to Diff 205909. Szelethus added a comment. Addressing reviewer feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63538/new/ https://reviews.llvm.org/D63538 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp Index: clang/lib/A

[PATCH] D63578: AMDGPU: Add DS GWS sema builtins

arsenm closed this revision. arsenm added a comment. r363986 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63578/new/ https://reviews.llvm.org/D63578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

leonardchan added inline comments. Comment at: clang/test/CodeGen/pgo-sample.c:12-14 +// NEWPM-DAG: PostOrderFunctionAttrsPass +// NEWPM-DAG: SimplifyCFGPass +// NEWPM-DAG: SampleProfileLoaderPass chandlerc wrote: > The DAG worries me a bit ... The point here is

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

leonardchan updated this revision to Diff 205906. leonardchan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63156/new/ https://reviews.llvm.org/D63156 Files: clang/test/CodeGen/aggregate-assign-call.c clang/test

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

akhuang added a comment. > Why isn't this using FileCheck variable matching in the first place? That's > the least fragile solution. No reason, just something I overlooked when I wrote it- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

leonardchan created this revision. leonardchan added reviewers: chandlerc, phosek, serge-sans-paille, echristo. leonardchan added a project: clang. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. leonardchan added a parent revision: D63156: [clang][NewPM] Add -fno-

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

lebedev.ri added a comment. In D63625#1552756 , @akhuang wrote: > Looks good, alternatively I think we can just change `%result.ptr` into a > variable match? Why isn't this using FileCheck variable matching in the first place? That's the least fragile

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

akhuang added a comment. Looks good, alternatively I think we can just change `%result.ptr` into a variable match? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63625/new/ https://reviews.llvm.org/D63625

r363986 - AMDGPU: Add DS GWS sema builtins

Author: arsenm Date: Thu Jun 20 14:33:57 2019 New Revision: 363986 URL: http://llvm.org/viewvc/llvm-project?rev=363986&view=rev Log: AMDGPU: Add DS GWS sema builtins Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-ci.cl cfe/trunk

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL363985: [test][Driver] Fix Clang :: Driver/cl-response-file.c (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D63625: [CodeGen][test] Use -fno-discard-value-names for better test support

rupprecht created this revision. rupprecht added reviewers: rnk, akhuang, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depending on how clang is built, it may discard the IR names and use names like `%2` instead of `%result.ptr`, causing tests that rely on the I

r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

Author: ro Date: Thu Jun 20 14:33:09 2019 New Revision: 363985 URL: http://llvm.org/viewvc/llvm-project?rev=363985&view=rev Log: [test][Driver] Fix Clang :: Driver/cl-response-file.c Clang :: Driver/cl-response-file.c currently FAILs on Solaris: Command Output (stderr): -- /vol/llvm/src/cl

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63600/new/ https://reviews.llvm.org/D63600 _

[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

jcai19 added a comment. In D63623#1552679 , @lebedev.ri wrote: > Why is this in android module? > Is that android-specific behavior, or posix? I implemented it for Andriod as requested, but it would be completely fine to move it if it is better to plac

[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

george.burgess.iv added a comment. just a few drive-by nits/comments from me. as usual, not super familiar with clang-tidy, so i won't be able to stamp this. thanks! Comment at: clang-tools-extra/clang-tidy/android/PosixReturnCheck.cpp:23 + binaryOperator( + has

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rjmccall added a comment. In D63451#1552609 , @rsmith wrote: > In D63451#1549563 , @rjmccall wrote: > > > Can this attribute not be applied to a base class, or to a type? > > > The standard attribute forbids that ri

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

jkorous added a comment. I don't have the insight to LGTM the whole change - just a nit about implementation detail. Comment at: clang/lib/AST/ASTImporter.cpp:1724 + }; + DefinitionCompleter CompleterRAII(To); You might consider using just a lambda with `l

[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

lebedev.ri added a comment. Why is this in android module? Is that android-specific behavior, or posix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63623/new/ https://reviews.llvm.org/D63623 ___ cfe-

[PATCH] D63161: Devirtualize destructor of final class.

rsmith added inline comments. Comment at: test/CodeGenCXX/devirtualize-dtor-final.cpp:20 + void evil(D *p) { +// CHECK-NOT: call void@_ZN5Test11DD1Ev +delete p; Missing space after `void` here Repository: rC Clang CHANGES SINCE LAST ACTION https:/

[PATCH] D63161: Devirtualize destructor of final class.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Minor comment then feel free to commit. Comment at: lib/CodeGen/CGExprCXX.cpp:1877 + DevirtualizedDtor->getParent(); + if (getCXXRecord(Base) ==

[PATCH] D63623: Add a check on expected return values of posix functions (except posix_openpt) in Android module.

jcai19 created this revision. Herald added subscribers: cfe-commits, mgorny, srhines. Herald added a project: clang. Checks if any calls to posix functions (except posix_openpt) expect negative return values. These functions return either 0 on success or an errno on failure, which is positive on

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:1850 +AggValueSlot::Overlap_t +CodeGenFunction::overlapForFieldInit(const FieldDecl *FD) { + if (!FD->hasAttr() || !FD->getType()->isRecordType()) rjmcca

r363980 - Rename CodeGenFunction::overlapFor* to getOverlapFor*.

Author: rsmith Date: Thu Jun 20 13:56:20 2019 New Revision: 363980 URL: http://llvm.org/viewvc/llvm-project?rev=363980&view=rev Log: Rename CodeGenFunction::overlapFor* to getOverlapFor*. Modified: cfe/trunk/lib/CodeGen/CGClass.cpp cfe/trunk/lib/CodeGen/CGDecl.cpp cfe/trunk/lib/CodeGe

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

aganea added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32 +class DependencyCollectorFactory { +public: arphaman wrote: > aganea wrote: > > Do you envision future uses for this factory? > Most likely, yes. > > I don't want to lo

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL363976: P0840R2: support for [[no_unique_address]] attribute (authored by rsmith, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

rnk added a comment. Even if `BRK #0xF000` is a Windows convention, it's still possible for ISel to select different instructions for different OSs, and I'd prefer to implement it that way. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63617/new/ https://review

r363976 - P0840R2: support for [[no_unique_address]] attribute

Author: rsmith Date: Thu Jun 20 13:44:45 2019 New Revision: 363976 URL: http://llvm.org/viewvc/llvm-project?rev=363976&view=rev Log: P0840R2: support for [[no_unique_address]] attribute Summary: Add support for the C++2a [[no_unique_address]] attribute for targets using the Itanium C++ ABI. Thi

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rjmccall accepted this revision. rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:326 + // const llvm::Triple &T = Target.getTriple(); + code CustomCode = [{}]; } Thanks! Comment at: lib/CodeGen/CGExprAgg.cpp:1850 +A

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith added a comment. In D63451#1549563 , @rjmccall wrote: > Can this attribute not be applied to a base class, or to a type? The standard attribute forbids that right now. We could add a custom attribute that permits it, but we're required to diagnos

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan added a comment. In D63617#1552561 , @rnk wrote: > I think it would be preferable to make `llvm.debugtrap` emit `brk #0xF000` on > aarch64-windows-*, so other frontends (Rust etc) get the right behavior by > default. Right now, AArch64 doesn't do

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith updated this revision to Diff 205892. rsmith marked 4 inline comments as done. rsmith added a comment. - Use custom code to specify CXXABI requirements on attributes. - Remove dead code that would have handled [[no_unique_address]] in C. - Extend documentation to include an example and to m

[PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

rsmith added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:1850 +AggValueSlot::Overlap_t +CodeGenFunction::overlapForFieldInit(const FieldDecl *FD) { + if (!FD->hasAttr() || !FD->getType()->isRecordType()) rsmith wrote: > rjmccall wrote: > > `getOverlap

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

serge-sans-paille added a comment. Thanks @jkorous for the fast review o/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63613/new/ https://reviews.llvm.org/D63613 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL363975: [clang-tidy] Fail gracefully upon empty database fields (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

Author: serge_sans_paille Date: Thu Jun 20 13:25:59 2019 New Revision: 363975 URL: http://llvm.org/viewvc/llvm-project?rev=363975&view=rev Log: [clang-tidy] Fail gracefully upon empty database fields Fix bz#42281 Differential Revision: https://reviews.llvm.org/D63613 Added: clang-tools-extr

r363975 - [clang-tidy] Fail gracefully upon empty database fields

Author: serge_sans_paille Date: Thu Jun 20 13:25:59 2019 New Revision: 363975 URL: http://llvm.org/viewvc/llvm-project?rev=363975&view=rev Log: [clang-tidy] Fail gracefully upon empty database fields Fix bz#42281 Differential Revision: https://reviews.llvm.org/D63613 Modified: cfe/trunk/lib

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

rnk added a comment. I think it would be preferable to make `llvm.debugtrap` emit `brk #0xF000` on aarch64-windows-*, so other frontends (Rust etc) get the right behavior by default. Right now, AArch64 doesn't do anything special for DEBUGTRAP, so we get the default behavior of `llvm.trap`. Is

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

arphaman added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:32 +class DependencyCollectorFactory { +public: aganea wrote: > Do you envision future uses for this factory? Most likely, yes. I don't want to lock-in into creating the

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

arphaman updated this revision to Diff 205886. arphaman marked 3 inline comments as done. arphaman added a comment. removed the lock CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63579/new/ https://reviews.llvm.org/D63579 Files: clang/include/clang/Frontend/Utils.h clang/lib/Fronte

r363973 - Fix passing structs and AVX vectors through sysv_abi

Author: rnk Date: Thu Jun 20 13:07:20 2019 New Revision: 363973 URL: http://llvm.org/viewvc/llvm-project?rev=363973&view=rev Log: Fix passing structs and AVX vectors through sysv_abi Do this the same way we did it for ms_abi in r324594. Fixes PR36806. Added: cfe/trunk/test/CodeGen/sysv_abi.

[PATCH] D63621: [git-clang-format] recognize hxx as a C++ file

vmiklos created this revision. vmiklos added reviewers: jbcoe, djasper. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov. Herald added a project: clang. clangd, clang-tidy, etc does that already, no reason why git-clang-format should skip hxx files. Repository: rC Clang https:/

Re: [PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

Sounds like a good start. On Thu, Jun 20, 2019 at 11:55 AM Tom Roeder via Phabricator wrote: > > tmroeder marked an inline comment as done. > tmroeder added inline comments. > > > > Comment at: clang-tools-extra/test/clang-tidy/linuxkernel-must-check-errs.c:6 > +// Prototypes of

r363972 - Fix crash and rejects-valid when a later template parameter or default

Author: rsmith Date: Thu Jun 20 12:49:13 2019 New Revision: 363972 URL: http://llvm.org/viewvc/llvm-project?rev=363972&view=rev Log: Fix crash and rejects-valid when a later template parameter or default template argument contains a backreference to a dependently-typed earlier parameter. In a cas

[PATCH] D63580: [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs

This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rG97dc622ab3f7: [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs (authored by leonardchan). Changed prior to commit: https://review

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63613/new/ https://reviews.llvm.org/D63613 __

r363971 - [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs

Author: leonardchan Date: Thu Jun 20 12:44:51 2019 New Revision: 363971 URL: http://llvm.org/viewvc/llvm-project?rev=363971&view=rev Log: [clang][NewPM] Do not eliminate available_externally durng `-O2 -flto` runs This fixes CodeGen/available-externally-suppress.c when the new pass manager is tur

[PATCH] D63577: [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rL363969: [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r363969 - [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline

Author: leonardchan Date: Thu Jun 20 12:35:25 2019 New Revision: 363969 URL: http://llvm.org/viewvc/llvm-project?rev=363969&view=rev Log: [clang][NewPM] Move EntryExitInstrumenterPass to the start of the pipeline This fixes CodeGen/x86_64-instrument-functions.c when running under the new pass man

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan created this revision. TomTan added reviewers: efriedma, rnk. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. On Windows ARM64, intrinsic `__debugbreak` should be compiled into `brk #0xF000` which is different from llvm intrinsic `debugtrap

r363966 - Print additional information about @encode expressions when dumping the AST to JSON.

Author: aaronballman Date: Thu Jun 20 12:11:35 2019 New Revision: 363966 URL: http://llvm.org/viewvc/llvm-project?rev=363966&view=rev Log: Print additional information about @encode expressions when dumping the AST to JSON. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h cfe/trunk

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

3nids added a comment. Hi, may I ask why this is abandoned? We are eagerly waiting on this to move to clang-format. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60225/new/ https://reviews.llvm.org/D60225 ___ cfe-com

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/test/clang-tidy/linuxkernel-must-check-errs.c:6 +// Prototypes of the error functions. +void * __must_check ERR_PTR(long error); +long __must_check PTR_ERR(const void *ptr);

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

lebedev.ri added a comment. Test coverage missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

tuktuk created this revision. tuktuk added reviewers: kcc, morehouse. tuktuk added projects: clang, Sanitizers. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a project: LLVM. This commit adds two command-line options to clang. These options let the user decide which

r363963 - [NFC] Fix for InterfaceStubs tests (adding REQUIRES: x86-registered-target).

Author: zer0 Date: Thu Jun 20 11:28:21 2019 New Revision: 363963 URL: http://llvm.org/viewvc/llvm-project?rev=363963&view=rev Log: [NFC] Fix for InterfaceStubs tests (adding REQUIRES: x86-registered-target). clang-hexagon-elf bot was failing with: 'No available targets are compatible with triple

r363961 - [X86] Make _mm_mask_cvtps_ph, _mm_maskz_cvtps_ph, _mm256_mask_cvtps_ph, and _mm256_maskz_cvtps_ph aliases for their corresponding cvt_roundps_ph intrinsic.

Author: ctopper Date: Thu Jun 20 11:24:29 2019 New Revision: 363961 URL: http://llvm.org/viewvc/llvm-project?rev=363961&view=rev Log: [X86] Make _mm_mask_cvtps_ph, _mm_maskz_cvtps_ph, _mm256_mask_cvtps_ph, and _mm256_maskz_cvtps_ph aliases for their corresponding cvt_roundps_ph intrinsic. These

[PATCH] D63108: [OpenMP] Add support for handling declare target to clause when unified memory is required

This revision was automatically updated to reflect the committed changes. Closed by commit rL363959: [OpenMP] Add support for handling declare target to clause when unified memory… (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposit

r363959 - [OpenMP] Add support for handling declare target to clause when unified memory is required

Author: gbercea Date: Thu Jun 20 11:04:47 2019 New Revision: 363959 URL: http://llvm.org/viewvc/llvm-project?rev=363959&view=rev Log: [OpenMP] Add support for handling declare target to clause when unified memory is required Summary: This patch adds support for the handling of the variables unde

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10298 + bool AllowFold = true, + bool StoreResult = true); ExprResult VerifyIntegerConstantExpression(Expr *E, llvm

[PATCH] D63361: Pretend NRVO variables are references so they can be found by debug info

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363952: Store a pointer to the return value in a static alloca and let the debugger use… (authored by akhuang, committed b

Re: [PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

Not much, but it's not abandoned. I was interrupted by other stuff. Also I am concerned by the fact that zero initialization without any new optimization is cheaper than pattern even with patches in progress. On Thu, Jun 20, 2019 at 9:05 AM JF Bastien via Phabricator < revi...@reviews.llvm.org> wr

r363952 - Store a pointer to the return value in a static alloca and let the debugger use that

Author: akhuang Date: Thu Jun 20 10:15:21 2019 New Revision: 363952 URL: http://llvm.org/viewvc/llvm-project?rev=363952&view=rev Log: Store a pointer to the return value in a static alloca and let the debugger use that as the variable address for NRVO variables. Subscribers: hiraditya, cfe-commi

[PATCH] D63613: [clang-tidy] Fail gracefully upon empty database fields

serge-sans-paille created this revision. serge-sans-paille added a reviewer: alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. fix https://bugs.llvm.org/show_bug.cgi?id=42281 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63613 Files: c

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. This was re-landed in r363948 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

r363948 - [clang-ifs] Clang Interface Stubs, first version (second landing attempt).

Author: zer0 Date: Thu Jun 20 09:59:48 2019 New Revision: 363948 URL: http://llvm.org/viewvc/llvm-project?rev=363948&view=rev Log: [clang-ifs] Clang Interface Stubs, first version (second landing attempt). This change reverts r363649; effectively re-landing r363626. At this point clang::Index::Co

[PATCH] D63607: [DO NOT SUBMIT] [clang][driver] Prototype --driver-mode=fortran support for new flang

peterwaller-arm added a comment. Note: In case you see this early, the email isn't yet sent to the list. I'll link it here when it is, likely tomorrow. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63607/new/ https://reviews.llvm.org/D63607 __

[PATCH] D63498: [RISC-V] Add -msave-restore and -mno-save-restore to clang driver

lenary updated this revision to Diff 205846. lenary added a comment. - Add CHECK lines for warnings Hopefully these will work regardless of race conditions in the merging of stdout and stderr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63498/new

  1   2   >