[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 203775. domdom added a comment. Sorry I it's taken me a while to get back to this work. I've rebased the changes and taken advantage of the refactoring to stop modifying the CompoundStmt after creating it. This definitely simplified the changes required in S

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray updated this revision to Diff 203766. lichray added a comment. Update www Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44865/new/ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign/T.p

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray marked an inline comment as done. lichray added a comment. In D44865#1535823 , @zoecarver wrote: > - the spacing is different from the rest of libc++ (a lot of it was that way > before). That's not something I can "fix" in this patch :( > - sin

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

mclow.lists added a comment. In D44865#1391996 , @lichray wrote: > Ping @mclow.lists @EricWF ; the patch still applies, is there any other > thing I need to address? Just a note: P0608R3 was adopted in San Diego. Repository: rCXX libc++ CHANGES SI

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

zoecarver added a comment. A few minor things: - the spacing is different from the rest of libc++ (a lot of it was that way before). - since this is a paper it should probably be guarded with `#if _LIBCPP_STD_VER > 17` - update the status in `www`. Also, the standard says explicitly, "A varian

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

skan updated this revision to Diff 203762. skan added a comment. change mask paramater' s name from `__M` to `__U` in order to be consistent with other intrinsics in the file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62363/new/ https://reviews.llvm.org/D62363 Files: include/clan

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. You need to add a unit test in clang/unittests Comment at: docs/ClangFormatStyleOptions.rst:195 +**BitFieldDeclsOnSeparateLines** (``bool``) + If `

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Thanks for looking at this. I'll update the patch asap In D59919#1535643 , @nicholas wrote: > CHANGED: build-libcalls NumNoUnwind > 4526 ->

[PATCH] D63062: Added New Style Rule: BitFieldDeclsOnSeparateLines

Manikishan created this revision. Manikishan added reviewers: aaron.ballman, rsmith. Herald added a subscriber: krytarowski. Herald added a project: clang. This new Style rule is made as a part of adding support for NetBSD KNF in clang-format. This style Lines up BitField Declarations on consecut

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

nicholas added a comment. > CHANGED: build-libcalls NumNoUnwind > 4526 -> 3382 ( -25.276%) Why did the number of nounwinds drop? Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:115 +template +static void gernericValueTrave

[PATCH] D61838: [Sema] Suppress additional warnings for C's zero initializer

Lekensteyn added a comment. @rsmith Are you happy with the changes, is it ready to be merged? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61838/new/ https://reviews.llvm.org/D61838 ___ cfe-commits mailing list cfe-

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 203742. jdoerfert added a comment. Cleanup leftover arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files: clang/test/CodeGenOpenCL/as_type.cl llvm/incl

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 203741. jdoerfert added a comment. Update to new Attributor design and more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files: clang/test/CodeGenOpenCL/as

[PATCH] D44865: [libc++] Implement P0608R3 - A sane variant converting constructor

lichray updated this revision to Diff 203733. lichray added a comment. Trivial rebase Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44865/new/ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/variant/variant.variant/variant.assign

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker updated this revision to Diff 203725. Tyker marked 5 inline comments as done. Tyker added a comment. fixed requested changes. also adapted lldb to AST change. I will commit this when i have access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

Tyker updated this revision to Diff 203723. Tyker marked 4 inline comments as done. Tyker edited the summary of this revision. Tyker added a comment. fixed requested changes. i will commit it when i have access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62399/new/ https://reviews.ll