r362316 - Add script to update OpenMP -ast-dump test expectations, and use it to

Author: rsmith Date: Sat Jun 1 21:00:38 2019 New Revision: 362316 URL: http://llvm.org/viewvc/llvm-project?rev=362316&view=rev Log: Add script to update OpenMP -ast-dump test expectations, and use it to regenerate the test expectations. (Only two tests change, as a result of no longer matching t

r362317 - Factor out commonality between variable capture initialization and

Author: rsmith Date: Sat Jun 1 21:00:43 2019 New Revision: 362317 URL: http://llvm.org/viewvc/llvm-project?rev=362317&view=rev Log: Factor out commonality between variable capture initialization and 'this' capture initialization. Modified: cfe/trunk/include/clang/Sema/Initialization.h cf

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. Hi all, With the latest version, I have made below changes according to all your comments: 1. Only apply the fix to Linux where many libraries are built by GCC. 2. Avoid converting the QualType to llvm::Type and then checking if the llvm::Type is a 64-bit vector, which

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 202579. wxiao3 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_32-arguments-linux.c test/CodeGen/x86_32-m64.c Index

[PATCH] D62445: [test] Fix plugin tests

hintonda updated this revision to Diff 202573. hintonda added a comment. - Fix dependencies so required plugins get built before tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ https://reviews.llvm.org/D62445 Files: clang/lib/Ana

[PATCH] D62445: [test] Fix plugin tests

hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. This patch broke some of the bots, so reopening to track the fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ https://reviews.llvm.org/D62445

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

mstorsjo added a comment. This change had another breaking effect as well, for the MinGW target. Code that implements a COM interface easily ends up overriding a `__declspec(nothrow)` function with a method that in most cases (at least in cases that follow the microsoft sample code) lacks the s

[PATCH] D61729: [docs] Fix example for Allman brace breaking style

owenpan added a comment. This file is generated from the `clang/include/clang/Format/Format.h` header file by the `clang/docs/tools/dump_format_style.py` script. Please update the header file and rerun the script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

aaron.ballman added a comment. In D54258#1524643 , @richardmembarth wrote: > Do you know when this will be merged? I apologize, I wasn't aware you needed this merged on your behalf. I normally would be happy to do so, but I'm currently traveling. Maybe

[PATCH] D62782: Fix -Wdouble-promotion warnings.

brucem created this revision. brucem added a reviewer: mclow.lists. Herald added subscribers: ldionne, christof. Repository: rCXX libc++ https://reviews.llvm.org/D62782 Files: include/limits include/utility Index: include/utility ==

[PATCH] D43159: Modernize: Use nullptr more.

brucem marked an inline comment as done. brucem added a comment. In D43159#1526215 , @mclow.lists wrote: > What was the result of testing with `-std=c++98` and/or `-std=gnu++98` ? > The code changes look fine; but as @Ericwf said It seems to work fo

[PATCH] D43159: Modernize: Use nullptr more.

brucem marked 2 inline comments as done. brucem added inline comments. Comment at: include/memory:1259 template static __two __test(...); template static char __test(typename _Xp::template rebind<_Up>::other* = 0); public: zoecarver wrote: > This co

[PATCH] D62780: msabi: Fix exponential mangling time for even more contrived inputs

thakis created this revision. thakis added a reviewer: rnk. This is a follow-up to r362293 which fixed exponential time needed for mangling certain templates. This fixes the same issue if that template pattern happens in template arguments > 10: The first ten template arguments can use back refere

[PATCH] D43159: Modernize: Use nullptr more.

zoecarver added inline comments. Comment at: include/memory:1259 template static __two __test(...); template static char __test(typename _Xp::template rebind<_Up>::other* = 0); public: This could be `nullptr` too. Repository: rCXX libc++ CHANG

[PATCH] D43159: Modernize: Use nullptr more.

brucem updated this revision to Diff 202555. brucem added a comment. Remove CMakeLists.txt change. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 Files: include/__functional_base include/__locale include/__sso_a

[PATCH] D43159: Modernize: Use nullptr more.

brucem updated this revision to Diff 202554. brucem added a comment. Herald added a subscriber: mgorny. Updated to current master and added more nullptr usage. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 Files: C

[PATCH] D43159: Modernize: Use nullptr more.

mclow.lists added a comment. In D43159#1526170 , @brucem wrote: > Can we revive this review? I'd still like to land this ... What was the result of testing with `-std=c++98` and/or `-std=gnu++98` ? The code changes look fine; but as @Ericwf said Re

[PATCH] D43159: Modernize: Use nullptr more.

brucem added a comment. Herald added subscribers: libcxx-commits, jfb, ldionne, christof. Can we revive this review? I'd still like to land this ... Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43159/new/ https://reviews.llvm.org/D43159 ___

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

brucem added a comment. Herald added subscribers: libcxx-commits, ldionne. Can we revive this review? I'd still like to land it ... Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43226/new/ https://reviews.llvm.org/D43226

[PATCH] D62746: msabi: Fix exponential mangling time for certain pathological inputs

This revision was automatically updated to reflect the committed changes. Closed by commit rG73f05841992c: msabi: Fix exponential mangling time for certain pathological inputs (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D62746?vs=202472

r362293 - msabi: Fix exponential mangling time for certain pathological inputs

Author: nico Date: Sat Jun 1 03:12:07 2019 New Revision: 362293 URL: http://llvm.org/viewvc/llvm-project?rev=362293&view=rev Log: msabi: Fix exponential mangling time for certain pathological inputs Template back references used to be recursively recomputed, add a memoization cache to cut down o

r362186 - Revert "[X86] Fix i386 struct and union parameter alignment"

Author: pengfei Date: Thu May 30 18:50:07 2019 New Revision: 362186 URL: http://llvm.org/viewvc/llvm-project?rev=362186&view=rev Log: Revert "[X86] Fix i386 struct and union parameter alignment" This reverts commit d61cb749f4ac2c90244906d756e80a5c4a7ffa89 (SVN: 361934). According to James sugges

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 added a comment. jyu2 committed rG954ec09aed4f : clang support gnu asm goto In D56571#1523895 , @nickdesaulniers wrote: > Was this committed accidentally? > > Today in master I s

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

kees added a comment. Nick points out that "REQUIRES: x86-registered-target" is likely not needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang-tools-extra] r362176 - [clangd] clang-format SymbolCollector.cpp

Author: nridge Date: Thu May 30 16:54:43 2019 New Revision: 362176 URL: http://llvm.org/viewvc/llvm-project?rev=362176&view=rev Log: [clangd] clang-format SymbolCollector.cpp Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified: clang-tools-extra/trunk/clangd/index/Sym

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. Was this committed accidentally? Today in master I see: - r362106: Revert "clang support gnu asm goto." Erich Keane - r362059: Mark CodeGen/asm-goto.c as x86 specific after r362045 Fangrui Song - r362045: clang support gnu asm goto. Jennifer Yu and yet this

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

kees added inline comments. Comment at: test/Analysis/asm-goto.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=debug.DumpCFG %s 2>&1 | FileCheck %s + Based on Nathan's comments in another thread, it seems like this needs to be: ``` // REQUIRES: x86-register

r361934 - [X86] Fix i386 struct and union parameter alignment

Author: pengfei Date: Wed May 29 01:42:35 2019 New Revision: 361934 URL: http://llvm.org/viewvc/llvm-project?rev=361934&view=rev Log: [X86] Fix i386 struct and union parameter alignment According to i386 System V ABI 2.1: Structures and unions assume the alignment of their most strictly aligned c