[PATCH] D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR

ahatanak updated this revision to Diff 199760. ahatanak marked an inline comment as done. ahatanak added a comment. Run the main ARC optimization passes when `ObjCNoBuiltinRetainRelease` is not set. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61970/new/ https:

[PATCH] D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR

ahatanak added inline comments. Comment at: test/CodeGenObjC/convert-messages-to-runtime-calls.m:32 // CALLS: {{call.*@objc_allocWithZone}} - // CALLS: {{call.*@objc_retain}} + // CALLS-ARC-INTRINSICS: {{call.*@llvm.objc.retainAutoreleasedReturnValue}} + // CALLS-NO-ARC-INT

[libunwind] r360861 - [PPC64][libunwind] Fix r2 not properly restored

Author: mstorsjo Date: Wed May 15 23:49:13 2019 New Revision: 360861 URL: http://llvm.org/viewvc/llvm-project?rev=360861&view=rev Log: [PPC64][libunwind] Fix r2 not properly restored This change makes each unwind step inspect the instruction at the return address and, if needed, read r2 from its

[libunwind] r360862 - [PPC] Fix 32-bit build of libunwind

Author: mstorsjo Date: Wed May 15 23:49:20 2019 New Revision: 360862 URL: http://llvm.org/viewvc/llvm-project?rev=360862&view=rev Log: [PPC] Fix 32-bit build of libunwind Clang integrated assembler was unable to build libunwind PPC32 assembly code, present in functions used to save/restore regist

[PATCH] D61909: Add Clang shared library with C++ exports

winksaville added a comment. > Distributions only get libclang_shared if they run the `install` target which > installs all of LLVM & Clang. The point of `LLVM_DISTRIBUTION_COMPONENTS` is > to allow people constructing distributions to choose which pieces they want > to install without introduc

[PATCH] D61849: Do not list enabled checks when -quiet is given to run-clang-tidy.

svenpanne added a comment. Thanks for the review. How will the patch be merged? According to https://llvm.org/docs/Phabricator.html#committing-a-change, someone else has to do it for me, because AFAICT, I have no commit rights. As I said: I'm still in the process of learning the workflow here..

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added a comment. Will FreeBSD 13 or future releases support ELFv1? If not, it may be cleaner to not invent `-elfv2` `-elfv1` triples, but rather dispatch on the major version, e.g. `powerpc64-unknown-freebsd13.0` could mean ELFv2. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR

ddkilzer added a comment. Had a couple questions about using `objc_retainAutoreleasedReturnValue` without a `return` statement. (I'm just reading this from a layman's point of view; it may not actually matter in practice.) Comment at: test/CodeGenObjC/convert-messages-to-run

[PATCH] D61756: Add a __FILE_NAME__ macro.

kristina reopened this revision. kristina added a comment. This revision is now accepted and ready to land. Reverted in rL360842 as Windows bots were failing. I suspect the `MSVCCompat` case may need to be handled differently depending on the host OS similar

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. For header files that pass the -header-filter, the modernize-concat-nested-namespaces check does not generate the expected warning and fix for un-concatenated namespaces. This diff fixes

r360842 - Revert r360833 until I can work out the issue with Win32 bots

Author: kristina Date: Wed May 15 20:30:08 2019 New Revision: 360842 URL: http://llvm.org/viewvc/llvm-project?rev=360842&view=rev Log: Revert r360833 until I can work out the issue with Win32 bots This reverts "r360833: [Clang][PP] Add the __FILE_NAME__ builtin macro." The tests are failing on W

r360839 - Fix assumption about Win32 paths in r360833

Author: kristina Date: Wed May 15 19:46:12 2019 New Revision: 360839 URL: http://llvm.org/viewvc/llvm-project?rev=360839&view=rev Log: Fix assumption about Win32 paths in r360833 Attempt to fix Windows buildbots due to differences in path handling (caused by r360833). Modified: cfe/trunk/li

Re: r360833 - [Clang][PP] Add the __FILE_NAME__ builtin macro.

Yes, sorry about that, I did notice, just re-testing it, should have a fix for Windows bots in a few minutes. On Thu, May 16, 2019 at 3:26 AM wrote: > Hi Kristina, > > Your change does not seem to be working on Windows. Can you take a look? > > http://lab.llvm.org:8011/builders/clang-x64-windows

RE: r360833 - [Clang][PP] Add the __FILE_NAME__ builtin macro.

Hi Kristina, Your change does not seem to be working on Windows. Can you take a look? http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/6860 FAIL: Clang :: Preprocessor/file_name_macro.c (7959 of 14753) TEST 'Clang :: Preprocessor/file_name_macro.c' FAILED ***

r360837 - Fix regression in r360311 caused by reversed bool arguments.

Author: rsmith Date: Wed May 15 19:06:16 2019 New Revision: 360837 URL: http://llvm.org/viewvc/llvm-project?rev=360837&view=rev Log: Fix regression in r360311 caused by reversed bool arguments. Added: cfe/trunk/test/CXX/over/over.match/over.match.funcs/over.match.ref/p1.cpp Modified: cfe/

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 199712. jkorous added a comment. A major clean-up. changelog = **general** - specification, documentation, tests - returning only filenames instead of paths (or empty string when the event is related to the watched dir itself) - removed unsound eve

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak created this revision. ahatanak added reviewers: rjmccall, theraven. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. clang currently emits different strings for `s0` and `s1` in the following code because pointers to typedefs are encoded as "^{PointeeClass

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache updated this revision to Diff 199709. modocache added a comment. Oops, sent the patch from the wrong repository. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58920/new/ https://reviews.llvm.org/D58920 Files: lib/Serialization/ASTReaderDecl.cpp tes

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache updated this revision to Diff 199708. modocache added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Thanks for the help, @rsmith! Your suggestions were spot-on. (It took me a little while to figure out why, even using the `LazyDeclPtr` directly, I was

[PATCH] D61722: [AST] Add RecoveryExpr; produce it on overload resolution failure and missing member.

rsmith added a comment. I expect we'll want a `ContainsErrors` bit on `Stmt`, propagated similarly to the existing `InstantiationDependent` / `ContainsUnexpandedParameterPack` / ... bits. For example, the constant evaluator will want to quickly bail out of evaluating expressions and statements

[PATCH] D61756: Add a __FILE_NAME__ macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360833: [Clang][PP] Add the __FILE_NAME__ builtin macro. (authored by kristina, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61756/new/ https://reviews.ll

r360833 - [Clang][PP] Add the __FILE_NAME__ builtin macro.

Author: kristina Date: Wed May 15 17:52:41 2019 New Revision: 360833 URL: http://llvm.org/viewvc/llvm-project?rev=360833&view=rev Log: [Clang][PP] Add the __FILE_NAME__ builtin macro. This patch adds the `__FILE_NAME__` macro that expands to the last component of the path, similar to `__FILE__` e

Re: r360637 - PR41817: Fix regression in r359260 that caused the MS compatibility

On Wed, 15 May 2019 at 15:54, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > *From: *Hans Wennborg > *Date: *Wed, May 15, 2019 at 1:22 AM > >> On Tue, May 14, 2019 at 6:35 PM Richard Smith >> wrote: >> > Yep, I'm not at all surprised. Perhaps we should stop claiming to >> s

[PATCH] D61756: Add a __FILE_NAME__ macro.

kristina added a comment. Landing this as discussed on IRC, will try to push it forward with WG14. I think having something like this as part of the standard would benefit a lot, since currently the "unofficial" way of doing this for either GCC or Clang involves several nonstandard builtins and

[PATCH] D61970: [CodeGen][ObjC] Call objc_autoreleaseReturnValue and objc_retainAutoreleasedReturnValue instead of objc_autorelease and objc_retain in MRR

ahatanak created this revision. ahatanak added reviewers: pete, rjmccall, erik.pilkington. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. This patch makes IRGen emit ObjC runtime functions (`objc_autoreleaseReturnValue` and `objc_retainAutoreleasedReturnValue`) th

[PATCH] D61756: Add a __FILE_NAME__ macro.

rsmith added a subscriber: alexr. rsmith added a comment. Generally, I think this is a good, useful feature, but there's one point from http://clang.llvm.org/get_involved.html 's checklist for accepting language extensions on which its case is weak, as reflected by this feedback from @alexr on

[PATCH] D61722: [AST] Add RecoveryExpr; produce it on overload resolution failure and missing member.

erik.pilkington added a reviewer: erik.pilkington. erik.pilkington added inline comments. Herald added a subscriber: dexonsmith. Comment at: include/clang/AST/BuiltinTypes.def:265 +// a template. +BUILTIN_TYPE(Recovery, RecoveryTy) + Why are you creating a new ty

r360827 - Make tentative parsing to detect template-argument-lists less aggressive

Author: rsmith Date: Wed May 15 16:36:14 2019 New Revision: 360827 URL: http://llvm.org/viewvc/llvm-project?rev=360827&view=rev Log: Make tentative parsing to detect template-argument-lists less aggressive (and less wrong). It's not correct to assume that X is always a template-id; there are a fe

[PATCH] D58321: Support for relative vtables

leonardchan added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:531 +/// \brief Whether the class uses the relative C++ vtable ABI. +unsigned IsRelativeCXXABI : 1; + pcc wrote: > rjmccall wrote: > > Should we proactively generalize this a

[PATCH] D58321: Support for relative vtables

leonardchan updated this revision to Diff 199696. leonardchan marked 5 inline comments as done. leonardchan added a reviewer: rjmccall. leonardchan removed a subscriber: rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://revie

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/android-cloexec-pipe.rst:4 +android-cloexec-pipe +== + Please make same length as name above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/android-cloexec-pipe.rst:6 + +The usage of ``pipe()`` is not recommended, it's better to use ``pipe2()``. +Without this flag, an opened sensitive file descriptor would remain open across --

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

george.burgess.iv added a comment. Thanks for this! I don't have great context on tidy, so I can't stamp this, but I do have a few drive-by nits for you. Comment at: clang-tools-extra/clang-tidy/android/CloexecPipeCheck.cpp:22 + functionDecl(returns(isIn

Re: r360637 - PR41817: Fix regression in r359260 that caused the MS compatibility

*From: *Hans Wennborg *Date: *Wed, May 15, 2019 at 1:22 AM > On Tue, May 14, 2019 at 6:35 PM Richard Smith > wrote: > > Yep, I'm not at all surprised. Perhaps we should stop claiming to > support this extension, given that it fundamentally violates assumptions > made by clang (that linkage doesn

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 created this revision. jcai19 added reviewers: alexfh, chh. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. pipe() is better to be replaced by pipe2() with O_CLOEXEC flag to avoid file descriptor leakage. Repository: rG LLVM Github Monorepo htt

[PATCH] D61756: Add a __FILE_NAME__ macro.

kristina added a comment. @rsmith Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61756/new/ https://reviews.llvm.org/D61756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

atanasyan added a comment. I hope the rL360825 fixes the problem so this patch can be switch to the `abandoned` state. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59702/new/ https://reviews.llvm.org/D59702 __

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. In D61909#1503642 , @winksaville wrote: > Sorry, maybe I didn't make myself clear. I understood you fine. I don't think you understand the guidance for building distributions of LLVM. Distributions only get libclang_shared if the

[PATCH] D61909: Add Clang shared library with C++ exports

winksaville added a comment. In D61909#1503483 , @beanz wrote: > In D61909#1503433 , @winksaville > wrote: > > > IMHO "`BUILD_CLANG_DYLIB`" is needed. As you have it now libclang_shared.so > > is always builds on

[PATCH] D61722: Prototype of RecoveryExpr. Here, it's emitted when overload resolution fails.

sammccall updated this revision to Diff 199678. sammccall added a comment. Herald added a subscriber: arphaman. This should work for real now: handle types properly, make tests pass, add some tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61722/new/ https:

[PATCH] D61963: [clang][Darwin] Refactor header search path logic into the driver

ldionne created this revision. ldionne added reviewers: jfb, arphaman. Herald added subscribers: cfe-commits, jsji, dexonsmith, jkorous, christof, kbarton, javed.absar, nemanjai. Herald added a project: clang. This commit moves the logic for determining system, resource and C++ header search path

[PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

shafik added a comment. I ran `check-lldb` and I hit one regression in `TestFormatters.py`, part of what I am seeing is as follows: AssertionError: False is not True : FileCheck'ing result of `expression --show-types -- *(new foo(47))` Error output: error: no matching constructor for init

[PATCH] D61281: [clang-format] Fixed self assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rC360810: [clang-format] Fixed self assignment (authored by xbolva00, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61281/new/ https://reviews.llvm.org/D6128

r360810 - [clang-format] Fixed self assignment

Author: xbolva00 Date: Wed May 15 13:29:33 2019 New Revision: 360810 URL: http://llvm.org/viewvc/llvm-project?rev=360810&view=rev Log: [clang-format] Fixed self assignment Reviewers: MyDeveloperDay, RKSimon Reviewed By: MyDeveloperDay Subscribers: RKSimon, cfe-commits Tags: #clang Differentia

[PATCH] D61959: [OpenMP][Bugfix] Move double and float versions of abs under c++ macro

This revision was automatically updated to reflect the committed changes. Closed by commit rC360809: [OpenMP][Bugfix] Move double and float versions of abs under c++ macro (authored by gbercea, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61959/new

r360809 - [OpenMP][Bugfix] Move double and float versions of abs under c++ macro

Author: gbercea Date: Wed May 15 13:28:23 2019 New Revision: 360809 URL: http://llvm.org/viewvc/llvm-project?rev=360809&view=rev Log: [OpenMP][Bugfix] Move double and float versions of abs under c++ macro Summary: This is a fix for the reported bug: [[ https://bugs.llvm.org/show_bug.cgi?id=41861

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Ugh. Reverted in rC360805 . Buildbots don't seem to be able to find the new plugins. Repository: rL LLVM CHANGES SINCE LAST ACTION https://review

r360806 - [c++20] For P1327R1: support dynamic_cast in constant expression

Author: rsmith Date: Wed May 15 13:22:21 2019 New Revision: 360806 URL: http://llvm.org/viewvc/llvm-project?rev=360806&view=rev Log: [c++20] For P1327R1: support dynamic_cast in constant expression evaluation. Modified: cfe/trunk/include/clang/Basic/DiagnosticASTKinds.td cfe/trunk/lib/AST

[PATCH] D61949: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC360804: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61949?vs=199662&id=19966

r360805 - Revert "[analyzer] Add a test for plugins using checker dependencies"

Author: szelethus Date: Wed May 15 13:19:51 2019 New Revision: 360805 URL: http://llvm.org/viewvc/llvm-project?rev=360805&view=rev Log: Revert "[analyzer] Add a test for plugins using checker dependencies" Buildbots don't seem to find the new plugin. Added: cfe/trunk/examples/analyzer-plugin

r360804 - [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions

Author: gbercea Date: Wed May 15 13:18:21 2019 New Revision: 360804 URL: http://llvm.org/viewvc/llvm-project?rev=360804&view=rev Log: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions Summary: In OpenMP device offloading we must ensure that unde C++ 17, the inclusi

[PATCH] D61957: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

This revision was automatically updated to reflect the committed changes. Closed by commit rC360802: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D61957?vs=199640&id=199666#toc Repository

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn marked an inline comment as done. kpn added a comment. I'm waiting for a signoff from at least one front-end guy. I hope the mode setting that allows us to keep front ends from having to touch every use of the IRBuilder is something that works for clang. But I haven't heard anything from @r

r360802 - [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

Author: epilk Date: Wed May 15 13:15:01 2019 New Revision: 360802 URL: http://llvm.org/viewvc/llvm-project?rev=360802&view=rev Log: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary Any of these methods can be overridden, so we need to invoke these functions. Differential revisio

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea abandoned this revision. gtbercea added a comment. Replaced by: D61399 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47849/new/ https://reviews.llvm.org/D47849 ___ cfe-commi

[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading

gtbercea abandoned this revision. gtbercea marked an inline comment as done. gtbercea added a comment. Replaced by: D61399 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 __

[PATCH] D61959: [OpenMP][Bugfix] Move double and float versions of abs under c++ macro

gtbercea created this revision. gtbercea added reviewers: tra, jdoerfert, hfinkel, ABataev, caomhin. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This is a fix for the reported bug: 41861 abs functions need to be mo

[PATCH] D61949: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions

gtbercea updated this revision to Diff 199662. gtbercea marked an inline comment as done. gtbercea added a comment. - Remove included headers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61949/new/ https://reviews.llvm.org/D61949 Files: lib/Headers/__clang_c

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL360799: [analyzer] Add a test for plugins using checker dependencies (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r360799 - [analyzer] Add a test for plugins using checker dependencies

Author: szelethus Date: Wed May 15 12:47:26 2019 New Revision: 360799 URL: http://llvm.org/viewvc/llvm-project?rev=360799&view=rev Log: [analyzer] Add a test for plugins using checker dependencies Also, I moved the existing analyzer plugin to test/ as well, in order not to give the illusion that

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. In D61909#1503433 , @winksaville wrote: > IMHO "`BUILD_CLANG_DYLIB`" is needed. As you have it now libclang_shared.so > is always builds on UNIX systems, which I believe means that all linux > distros would have both increasing the

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

aganea updated this revision to Diff 199659. aganea marked 3 inline comments as done. aganea added a comment. In D60283#1503256 , @probinson wrote: > Minor stuff. This solution is surprisingly simple, the main question being > (and I don't have an answer

[PATCH] D61949: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions

jdoerfert requested changes to this revision. jdoerfert added inline comments. This revision now requires changes to proceed. Comment at: lib/Headers/openmp_wrappers/__clang_openmp_math_declares.h:24 + #include + #include #endif jdoerfert wrote: > I ask this

[PATCH] D61949: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions

tra added a comment. LGTM. Comment at: lib/Headers/__clang_cuda_cmath.h:42 +// variant is supported. +#if defined(_OPENMP) && defined(__cplusplus) && __cplusplus >= 201703L +#define __NOEXCEPT noexcept I think the change is useful for CUDA, too, but I'm OK keep

[PATCH] D61957: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGenObjC/convert-messages-to-runtime-calls.m:208 + } +} Can you add tests for `objc_alloc`, `objc_allocWithZone` and `obj

[PATCH] D61909: Add Clang shared library with C++ exports

winksaville added a comment. IMHO "`BUILD_CLANG_DYLIB`" is needed. As you have it now libclang_shared.so is always builds on UNIX systems, which I believe means that all linux distros would have both increasing their sizes. I think the default should be "always" `build libclang*.a` as it is now

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator

riccibruno added a comment. Ping :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60956/new/ https://reviews.llvm.org/D60956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kbarton added a comment. I think this looks straightforward, as long as people agree to have a separate CreateConstrained* version of these functions. I'm not qualified to weigh in on that as I don't know Clang at all and can't comment about the tradeoffs (although I think they have been well a

[PATCH] D61949: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_device_functions.h:1477 #endif // CUDA_VERSION >= 9020 +#if __cplusplus >= 201703L +__DEVICE__ int abs(int __a) noexcept { return __nv_abs(__a); } tra

[PATCH] D61949: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions

gtbercea updated this revision to Diff 199651. gtbercea added a comment. - Refactor. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61949/new/ https://reviews.llvm.org/D61949 Files: lib/Headers/__clang_cuda_cmath.h lib/Headers/__clang_cuda_device_functions.h

[PATCH] D61845: [builtin] Fixed definitions of builtins that rely on the int/long long type is 32/64 bits

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61845/new/ https://reviews.llvm.org/D61845 ___ cfe-commit

[PATCH] D61958: [analyzer] RetainCount: Fix a crash when os_returns_retained_on_zero (_nonzero) is applied to functions that return weird stuff.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360790: [analyzer] RetainCount: Fix os_returns_retained_on_zero with weird return types. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61958?vs=199647&id=19

r360790 - [analyzer] RetainCount: Fix os_returns_retained_on_zero with weird return types.

Author: dergachev Date: Wed May 15 11:41:32 2019 New Revision: 360790 URL: http://llvm.org/viewvc/llvm-project?rev=360790&view=rev Log: [analyzer] RetainCount: Fix os_returns_retained_on_zero with weird return types. The checker was crashing when it was trying to assume a structure to be null or

[PATCH] D61958: [analyzer] RetainCount: Fix a crash when os_returns_retained_on_zero (_nonzero) is applied to functions that return weird stuff.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good do me. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61958/new/ https://reviews.llvm.org/D61958 ___

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

rsmith added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1521 Tok[0].setAnnotationValue(AnnotationVal); - EnterTokenStream(std::move(Tok), 1, true); + EnterTokenStream(std::move(Tok), 1, true, /*IsReinject*/ true); } I think it'd be more use

[PATCH] D61958: [analyzer] RetainCount: Fix a crash when os_returns_retained_on_zero (_nonzero) is applied to functions that return weird stuff.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. The checker crashes when it tries to assume a structure to

[PATCH] D61957: [CodeGenObjC] invoke objc_autorelease, objc_retain when necessary

erik.pilkington created this revision. erik.pilkington added reviewers: ahatanak, rjmccall. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. Any of these methods can be overridden, so we always need to conservatively `invoke` these calls. Repository: rC Clang htt

[PATCH] D61909: Add Clang shared library with C++ exports

beanz added a comment. In D61909#1502446 , @winksaville wrote: > Questions: > > - Should we only build `libclang_shared.so` if `LLVM_BUILD_LLVM_DYLIB` is ON? `LLVM_BUILD_LLVM_DYLIB` is actually not the important option to think about because it has no i

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:955 --LexLevel; + if (OnToken && LexLevel == 0 && !Result.getFlag(Token::IsReinjected)) +OnToken(Result); Could probably remove the `IsReinjected` check from here. It's fine t

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov updated this revision to Diff 199639. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Improve comment, remove redundant braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59885/new/ https://reviews.l

[clang-tools-extra] r360788 - [clang-tidy] Recommit r360785 "modernize-loop-convert: impl const cast iter" with correct attribution

Author: dhinton Date: Wed May 15 10:47:51 2019 New Revision: 360788 URL: http://llvm.org/viewvc/llvm-project?rev=360788&view=rev Log: [clang-tidy] Recommit r360785 "modernize-loop-convert: impl const cast iter" with correct attribution Summary: modernize-loop-convert was not detecting implicit c

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added a comment. In D61923#1503272 , @jfb wrote: > Have you asked on libcxx-dev whether a stand-alone base is something of > interest to them? No, but I will follow up on that. > Kinda... but your answer really sounds like this is a Google-only p

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov added a comment. I've added a new parameter to `EnterToken` and `EnterTokenStream`. There are a bunch of interesting cases. `Preprocessor::AnnotateCachedTokens` is one. It consumes some `CachedTokens` (which are always considered re-injected) and replaces them with a single annot

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov updated this revision to Diff 199637. ilya-biryukov added a comment. Herald added a subscriber: eraman. - Properly mark tokens as reinjected where necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59885/new/ https://reviews.llv

[clang-tools-extra] r360787 - Revert [clang-tidy] modernize-loop-convert: impl const cast iter

Author: dhinton Date: Wed May 15 10:36:54 2019 New Revision: 360787 URL: http://llvm.org/viewvc/llvm-project?rev=360787&view=rev Log: Revert [clang-tidy] modernize-loop-convert: impl const cast iter This reverts r360785 (git commit 42d28be802fe5beab18bc1a27f89894c0a290d44) Modified: clang-to

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

hintonda added a comment. I've also had issues with this behavior. It's a bad default, as the PR notes, but is there a way to provide a better one and still respect the config file? Also, could you add a test for this? Perhaps in `clang-tools-extra/test//clang-tidy/run-clang-tidy.cpp`. Repo

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava marked 3 inline comments as done. adalava added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:217 case Triple::ppc64: -return PPCTargetMachine::PPC_ABI_ELFv1; +// if ELFv2 on target triple i.e. powerpc64-unknown-freebsd12.0-elfv2 +

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava updated this revision to Diff 199633. adalava added a comment. - remove redundant comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 Files: clang/lib/Basic/Targets/PPC.h llvm/include/llvm/A

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava marked an inline comment as done. adalava added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:382 resetDataLayout("e-m:e-i64:64-n32:64"); - ABI = "elfv2"; } else { MaskRay wrote: > MaskRay wrote: > > Have you researched how G

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

jfb added a comment. > In D61923#1502404 , @jfb wrote: > >> > We can't use `std::mutex` as we must be C-compatible >> >> Can you clarify what you mean by this? I don't understand. >> Have you asked on libcxx-dev? Is there interest in the libc++ community

Re: [clang-tools-extra] r360785 - [clang-tidy] modernize-loop-convert: impl const cast iter

Just wanted to note that this patch was contributed by Torbjörn Klatt, and I failed to add the following line to the commit message: Patch by Torbjörn Klatt! Sorry about that Torbjörn. On Wed, May 15, 2019 at 9:56 AM Don Hinton via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dhin

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 199632. hctim marked 2 inline comments as done. hctim added a comment. In D61923#1502988 , @cryptoad wrote: > Is the question why do Scudo has its own as opposed to rely on platform > specific ones? Yes, I have assump

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville abandoned this revision. winksaville added a comment. Abandoning, @beanz has proposed a better solution, D61909 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61804/new/ https://reviews.llvm.org/D61804

[PATCH] D61827: [clang-tidy] modernize-loop-convert: impl const cast iter

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360785: [clang-tidy] modernize-loop-convert: impl const cast iter (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D61827?vs=199496&id=199631#toc Repository:

[clang-tools-extra] r360785 - [clang-tidy] modernize-loop-convert: impl const cast iter

Author: dhinton Date: Wed May 15 09:58:58 2019 New Revision: 360785 URL: http://llvm.org/viewvc/llvm-project?rev=360785&view=rev Log: [clang-tidy] modernize-loop-convert: impl const cast iter Summary: modernize-loop-convert was not detecting implicit casts to const_iterator as convertible to rang

[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

probinson added a comment. Minor stuff. This solution is surprisingly simple, the main question being (and I don't have an answer) whether increasing the size of PresumedLoc is okay. Comment at: lib/Basic/SourceManager.cpp:1460 +FID = FileID::get(0); // contents of fi

[PATCH] D61949: [OpenMP][bugfix] Fix issues with C++ 17 compilation when handling math functions

tra added inline comments. Comment at: lib/Headers/__clang_cuda_device_functions.h:1477 #endif // CUDA_VERSION >= 9020 +#if __cplusplus >= 201703L +__DEVICE__ int abs(int __a) noexcept { return __nv_abs(__a); } jdoerfert wrote: > Hahnfeld wrote: > > If I recall

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:1643 +if (!ImportedOrErr) { + // For RecordDecls, failed import of a field will break the layout of the + // structure. Handle it as an error. shafik wrote: > What cases are failed i

r360783 - Test commit

Author: kpet Date: Wed May 15 09:39:28 2019 New Revision: 360783 URL: http://llvm.org/viewvc/llvm-project?rev=360783&view=rev Log: Test commit Remove stray space. Signed-off-by: Kevin Petit Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL: http://ll

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong updated this revision to Diff 199629. martong marked 13 inline comments as done. martong added a comment. - Address Shafik's comments and update assertions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44100/new/ https://reviews.llvm.org/D4

  1   2   >