r360408 - Delete write-only HasQualifiers after rC360370

Author: maskray Date: Thu May 9 23:59:50 2019 New Revision: 360408 URL: http://llvm.org/viewvc/llvm-project?rev=360408&view=rev Log: Delete write-only HasQualifiers after rC360370 Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL: http://llvm.org

r360406 - Added an assert in `isConstantInitializer`: initializer lists must be in semantic form

Author: gribozavr Date: Thu May 9 23:39:20 2019 New Revision: 360406 URL: http://llvm.org/viewvc/llvm-project?rev=360406&view=rev Log: Added an assert in `isConstantInitializer`: initializer lists must be in semantic form Subscribers: cfe-commits Tags: #clang Differential Revision: https://re

[PATCH] D61485: Added an assert in `isConstantInitializer`: initializer lists must be in semantic form

This revision was automatically updated to reflect the committed changes. Closed by commit rL360406: Added an assert in `isConstantInitializer`: initializer lists must be in… (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D61777: [cc1as] Change -compress-debug-sections= to use --

MaskRay added a comment. If you feel strong about it, I can add back `-compress-debug-sections=`, but it is not used by anyone. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61777/new/ https://reviews.llvm.org/D61777 __

[PATCH] D61777: [cc1as] Change -compress-debug-sections= to use --

MaskRay created this revision. MaskRay added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. The double dash form is documented by GNU as, used by gcc, and accepted by llvm-mc. Repository: rC Clang https://reviews.llvm.org/D61777 Files: include

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: llvm/lib/TextAPI/ELF/TBEHandler.cpp:137 IO.mapRequired("Arch", (ELFArchMapper &)Stub.Arch); +IO.mapOptional("Endian", Stub.Endian); IO.mapOptional("NeededLibs", Stub.NeededLibs);

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198977. plotfi added a comment. renaming things from "ifso" to "interface stubs" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Opti

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

This revision was automatically updated to reflect the committed changes. Closed by commit rC360404: Assume `__cxa_allocate_exception` returns an under-aligned memory on (authored by ahatanak, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61667/new/

r360404 - Assume `__cxa_allocate_exception` returns an under-aligned memory on

Author: ahatanak Date: Thu May 9 19:16:37 2019 New Revision: 360404 URL: http://llvm.org/viewvc/llvm-project?rev=360404&view=rev Log: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123 This patch

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

This revision was automatically updated to reflect the committed changes. Closed by commit rL360403: Change -gz and -Wa,--compress-debug-sections to use gABI compression… (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r360403 - Change -gz and -Wa, --compress-debug-sections to use gABI compression (SHF_COMPRESSED)

Author: maskray Date: Thu May 9 19:08:21 2019 New Revision: 360403 URL: http://llvm.org/viewvc/llvm-project?rev=360403&view=rev Log: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED) Since July 15, 2015 (binutils-gdb commit 19a7fe52ae3d0971e67a134bcb1648899e2

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a subscriber: mgorny. Herald added a project: clang. NOTE: This is a preliminary revision for discussion; tests have not yet been provided. The RangeSelector library defines a combinator language for specifying

[PATCH] D61774: [LibTooling] Add RangeSelector library for defining source ranges based on bound AST nodes.

ymandel added a comment. Ilya, this revision follows up from our discussion on the doc. It adds some more selectors. If this change is to big, I'm happy to split it up (e.g. moving the changes to SourceCode to a separate revision and/or splitting up the RangeSelector changes). Also, I have th

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

MaskRay updated this revision to Diff 198970. MaskRay edited the summary of this revision. MaskRay added a comment. Update release notes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61689/new/ https://reviews.llvm.org/D61689 Files: docs/ReleaseNotes.rst lib

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198967. plotfi added a comment. cleaned up VisitNamedDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61667/new/ https://reviews.llvm.org/D61667 ___ c

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/SemaCXX/aggregate-initialization.cpp:199 void test0() { -auto *y = new Y {}; // expected-error {{temporary of type 'ElementDestructor

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198963. plotfi marked 9 inline comments as done. plotfi added a comment. removed all the template functions to handle decls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D609

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:566 + notMatchesObjC("@interface Y @end typedef Y X; @interface Z : X @end", + ZIsDerivedFromX)); + EXPECT_TRUE( (note that there are

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore added a comment. I did some digging and I believe there are two approaches that we can take to extend `isDerivedFrom` to support Objective-C classes. **Option 1: Match on Common Ancestor Declaration Type**: Convert `isDerivedFrom` to match on the common ancestor declaration type,

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak updated this revision to Diff 198959. ahatanak added a comment. Update the comment in `CheckCXXThrowOperand`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61667/new/ https://reviews.llvm.org/D61667 Files: include/clang/AST/ASTContext.h include/clan

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:13121-13122 + if (VD->isNoDestroy(getASTContext()) && + !(VD->getType()->isArrayType() && getLangOpts().Exceptions && +VD->isStaticLocal())) return; rjmccall wrot

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

stephanemoore updated this revision to Diff 198956. stephanemoore added a comment. Present one potential option for making isDerivedFrom support Objective-C classes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60543/new/ https://reviews.llvm.org

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington updated this revision to Diff 198944. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Rename `hasAccessibleDestructor`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61165/new/ https://reviews.llvm.org/D61165 Files: clang/include/cla

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

rjmccall added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:946 + // is larger than the minimum alignment the libc++abi runtime guarantees. + if (Context.getTargetInfo().getTriple().isOSDarwin()) { +CharUnits TypeAlign = Context.getTypeAlignInChars(Ty); ---

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:13121-13122 + if (VD->isNoDestroy(getASTContext()) && + !(VD->getType()->isArrayType() && getLangOpts().Exceptions && +VD->isStaticLocal())) return; erik.pilkington wrot

[PATCH] D61769: [clang] Regenerate AST matcher docs 📖

stephanemoore created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation seems to have been manually edited in https://reviews.llvm.org/rGa282bde69e375985edd4c371b79864f617380ad5. This commit regenerates the documentation and commits the resul

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak added inline comments. Comment at: include/clang/Basic/TargetInfo.h:643 + /// runtime, such as those using the Itanium C++ ABI. + virtual unsigned getExnObjectAlignment() const { +// Itanium says that an _Unwind_Exception has to be "double-word" rj

[PATCH] D61667: Assume `__cxa_allocate_exception` returns an under-aligned memory on Darwin if the version of libc++abi isn't new enough to include the fix in r319123

ahatanak updated this revision to Diff 198939. ahatanak marked 6 inline comments as done. ahatanak added a comment. Herald added a subscriber: aheejin. Address review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61667/new/ https://reviews.llvm.org/D616

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington marked 2 inline comments as done. erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:13121-13122 + if (VD->isNoDestroy(getASTContext()) && + !(VD->getType()->isArrayType() && getLangOpts().Exceptions && +VD->isStaticLoc

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 198937. bernhardmgruber marked 3 inline comments as done. bernhardmgruber added a comment. - fixed formatting - fixed function names in tests - added `-fexceptions` to test arguments - fixed type in release notes CHANGES SINCE LAST ACTION https://r

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3915 +Here, if the construction of `array[9]` fails with an exception, `array[0..8]` +will be destroyed, so the element's destructor needs to be accessible. }]; Probably worth ad

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added inline comments. Comment at: clang/unittests/Rewrite/RewriterTest.cpp:1 +//===- unittests/Rewrite/RewriteTest.cpp - RewriteBuffer tests ===// +// Oops. Need to change the description here. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

jdoerfert added a comment. This always includes the declare file but not the define file, correct? Could we have 4 tests that are compiled in target mode with: // with and without math.h/cmath (clang/clang++) #include long abs(long __i) { return (__i < 0 ? -i : i); } Repository: rC

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea updated this revision to Diff 198929. gtbercea added a comment. - Remove define. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61765/new/ https://reviews.llvm.org/D61765 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt lib/Headers

[PATCH] D61467: [Rewrite] Extend to further accept CharSourceRange

jdenny added a comment. Ping. This seems like a straight-forward extension to the Rewriter API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61467/new/ https://reviews.llvm.org/D61467 ___ cfe-commits

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea created this revision. gtbercea added reviewers: jdoerfert, ABataev, hfinkel, caomhin. Herald added subscribers: cfe-commits, guansong, mgorny. Herald added a project: clang. This patches fixes an issue in which the __clang_cuda_cmath.h header is being included even when cmath or math.h

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

rnk added a subscriber: echristo. rnk added a comment. @echristo mentioned that this patch was also causing issues in another freestanding environment where _MSC_VER was defined, but no corecrt.h header existed on the system. So, I think it's likely that we don't want to do this in the long run

r360387 - Remember to decay arrays to pointers before checking whether the

Author: rsmith Date: Thu May 9 15:22:48 2019 New Revision: 360387 URL: http://llvm.org/viewvc/llvm-project?rev=360387&view=rev Log: Remember to decay arrays to pointers before checking whether the left-hand side of an -> operator is a pointer to class type. Modified: cfe/trunk/lib/Sema/SemaE

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington updated this revision to Diff 198916. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Address review comments. Also remove the special case where we wouldn't check a destructor for an array in `-fno-exceptions` mode. This seems inconsistent with

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:3897-3900 +This works in almost all cases, but if ``no_destroy`` is applied to a ``static`` +or ``thread_local`` local builtin array variable and exceptions are enabled, the +destructor is

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

xbolva00 added inline comments. Comment at: lib/Frontend/DependencyFile.cpp:279 + if (DependencyFilter.size() && + strncmp(Filename, DependencyFilter.c_str(), DependencyFilter.size()) == 0) +// Remove dependencies that are prefixed by the Filter string. ---

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 198902. plotfi added a comment. addressing a lot of @compnerd 's feedback. Still lots of templating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/inclu

[PATCH] D61756: Add a __FILE_NAME__ macro.

shawnl requested changes to this revision. shawnl added a comment. This revision now requires changes to proceed. There is no documentation specific to the #include directive. https://docs.microsoft.com/en-us/cpp/preprocessor/hash-include-directive-c-cpp?view=vs-2019 However, fileio treats / and

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc marked an inline comment as done. mibintc added a comment. added an inline comment about the use of strncmp Comment at: lib/Frontend/DependencyFile.cpp:279 + if (DependencyFilter.size() && + strncmp(Filename, DependencyFilter.c_str(), DependencyFilter.size()) ==

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

rnk added a comment. Thanks, I would like to do this for the sanitizers as well, since this is a constant pain point for users, who have to come up with an architecture-dependent filename (`clang_rt.asan-dynamic-$arch.lib` or something). Comment at: clang/lib/Driver/ToolChai

[PATCH] D61756: Add a __FILE_NAME__ macro.

shawnl added inline comments. Comment at: lib/Lex/PPMacroExpansion.cpp:1509 +if (LastSep == StringRef::npos && LangOpts.MicrosoftExt) + LastSep = PLFileName.find_last_of('\\'); + What is the path name uses both \ and / to separate paths?

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:223 +for (auto *I : cast(ND)->decls()) + HandleNamedDecl(dyn_cast(I), Symbols, RDO); +return true; compnerd wrote: > Hmm, do we

[PATCH] D61758: [driver][xray] fix the macOS support checker by supporting -macos triple in addition to -darwin

arphaman created this revision. arphaman added a reviewer: dberris. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. The previous check incorrectly checked for macOS support by allowing `-darwin` triples only, and `-macos` triple was not supported. Repository: rG

r360374 - NFC, make XFAIL work on macOS correctly for test/Driver/XRay/xray-instrument-os.c

Author: arphaman Date: Thu May 9 13:35:41 2019 New Revision: 360374 URL: http://llvm.org/viewvc/llvm-project?rev=360374&view=rev Log: NFC, make XFAIL work on macOS correctly for test/Driver/XRay/xray-instrument-os.c The test 'test/Driver/XRay/xray-instrument-os.c' is supposed to XFAIL on -darw

[PATCH] D61756: Add a __FILE_NAME__ macro.

kristina updated this revision to Diff 198894. kristina added a comment. Fix style, remove unnecessary braces, add missing newline. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61756/new/ https://reviews.llvm.org/D61756 Files: include/clang/Lex/Preprocessor.h

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

kristina abandoned this revision. kristina added a comment. Superseded by D61756 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17741/new/ https://reviews.llvm.org/D17741 ___ cfe-commits mailing list cfe-com

[PATCH] D61756: Add a __FILE_NAME__ macro.

kristina created this revision. kristina added reviewers: aaron.ballman, rsmith, rnk. Herald added a project: clang. A much simplified version of D17741 which adds a new builtin macro `__FILE_NAME__` that is similar to `__FILE__` but only renders the last path c

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

Eugene.Zelenko added subscribers: JonasToth, Eugene.Zelenko. Eugene.Zelenko added a comment. @JonasToth tried to implement const check, so probably const and static part should be split. It's hard to tell about state of existing implementation, but you could continue it or at least borrow ideas

[PATCH] D61709: [NewPM] Port HWASan and Kernel HWASan

leonardchan updated this revision to Diff 198889. leonardchan marked 2 inline comments as done. leonardchan retitled this revision from "[NewPM] Port HWASan" to "[NewPM] Port HWASan and Kernel HWASan". leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES

r360369 - Simplify tracking of end of consumed decl-specifier sequence.

Author: rsmith Date: Thu May 9 12:45:46 2019 New Revision: 360369 URL: http://llvm.org/viewvc/llvm-project?rev=360369&view=rev Log: Simplify tracking of end of consumed decl-specifier sequence. Patch by Tyker! Differential Revision: https://reviews.llvm.org/D60934 Modified: cfe/trunk/lib/P

r360370 - DR1872: don't allow any calls to virtual functions in constant

Author: rsmith Date: Thu May 9 12:45:49 2019 New Revision: 360370 URL: http://llvm.org/viewvc/llvm-project?rev=360370&view=rev Log: DR1872: don't allow any calls to virtual functions in constant evaluation. Not even in cases where we would not actually perform virtual dispatch. Modified: cf

[PATCH] D61750: [Targets] Move soft-float-abi filtering to `initFeatureMap`

george.burgess.iv created this revision. george.burgess.iv added reviewers: michaelplatings, efriedma. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. I'm not convinced this is an excellent approach, in part because I'm unclear on where all we expect to funnel

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre created this revision. mgehre added reviewers: alexfh, aaron.ballman. Herald added subscribers: xazax.hun, mgorny. Herald added a project: clang. Finds non-static member functions that can be made ``const`` or ``static``. The check conservatively tries to preserve logical costness in favor

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! In D61621#1496978 , @vsapsai wrote: > Didn't use `-fms-compatibility` in the test and it seems to be working fine. > Don't know if it is accid

r360365 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none).

Author: abataev Date: Thu May 9 11:44:53 2019 New Revision: 360365 URL: http://llvm.org/viewvc/llvm-project?rev=360365&view=rev Log: [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none). If the combined directive has default(none) clause and has clauses for inner directi

[PATCH] D61747: [clang-tidy] remove default header-filter for run-clang-tidy

torbjoernk created this revision. torbjoernk added reviewers: alexfh, bkramer. torbjoernk added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. run-clang-tidy.py was enforcing '-header-filter' parameter with an unfortunate default valu

r360363 - Specify target triple to fix the tests I committed in r360359 that are

Author: ahatanak Date: Thu May 9 11:32:16 2019 New Revision: 360363 URL: http://llvm.org/viewvc/llvm-project?rev=360363&view=rev Log: Specify target triple to fix the tests I committed in r360359 that are still failing. Modified: cfe/trunk/test/CodeGenObjC/externally-initialized-selectors.m

r360362 - [OPENMP]Fix PR41768: check DSA for globals with default(none) clauses.

Author: abataev Date: Thu May 9 11:14:57 2019 New Revision: 360362 URL: http://llvm.org/viewvc/llvm-project?rev=360362&view=rev Log: [OPENMP]Fix PR41768: check DSA for globals with default(none) clauses. If the default(none) was specified for the construct, we might miss diagnostic for the globa

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai updated this revision to Diff 198875. vsapsai added a comment. - Improve `-fno-gnu-inline-asm` support for MS-compatibility too. Didn't use `-fms-compatibility` in the test and it seems to be working fine. Don't know if it is accidental and if I should add the flag. CHANGES SINCE LAST A

r360361 - Specify ObjC runtime to fix the tests I committed in r360359 that are

Author: ahatanak Date: Thu May 9 11:05:17 2019 New Revision: 360361 URL: http://llvm.org/viewvc/llvm-project?rev=360361&view=rev Log: Specify ObjC runtime to fix the tests I committed in r360359 that are failing. Modified: cfe/trunk/test/CodeGenObjC/externally-initialized-selectors.m cfe

[PATCH] D53072: [clang-format] Create a new tool for IDEs based on clang-format

yvvan added a comment. In D53072#1496317 , @sammccall wrote: > My feedback would be: > > - I definitely think more control over preserving line breaks would be > useful. Actually preserving *blank* lines is an important property. If you > see D60605

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

Dmitry.Kozhevnikov added a comment. In D50993#1496946 , @ilya-biryukov wrote: > I'd still put it into LLVM to avoid platform-specific code in clangd. > Maybe `std::abort()` in the added `...Async` function if threads are > disabled? It's a bit unusual,

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360359: [CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make (authored by ahatanak, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61454/new/

r360359 - [CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make

Author: ahatanak Date: Thu May 9 10:43:52 2019 New Revision: 360359 URL: http://llvm.org/viewvc/llvm-project?rev=360359&view=rev Log: [CodeGen][ObjC] Remove the leading `l_` from ObjC symbols and make private symbols in the __DATA segment internal. This prevents the linker from removing the symb

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

ilya-biryukov added a comment. I'd still put it into LLVM to avoid platform-specific code in clangd. Maybe `std::abort()` in the added `...Async` function if threads are disabled? It's a bit unusual, but would allow keeping this function where it belongs. Repository: rCTE Clang Tools Extra

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 198868. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Use bsearch instead of upper_bound Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.or

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:78 + /// For debugging purposes. + std::string str() const; + sammccall wrote: > ilya-biryukov wrote: > > sammccall wrot

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:62 + SourceLocation location() const { return Location; } + SourceLocation endLocation() const { +return Location.getLocWithOffset(Le

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 198867. ilya-biryukov marked 5 inline comments as done. ilya-biryukov added a comment. - Check invariants on FileRange construction, unify access to all fields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. (Accepting with the condition that you will update the release notes before committing) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61689/new/ https://r

[PATCH] D61739: check_clang_tidy.py now passes `-format-style=none` to clang_tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rL360358: check_clang_tidy.py now passes `-format-style=none` to clang_tidy (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[clang-tools-extra] r360358 - check_clang_tidy.py now passes `-format-style=none` to clang_tidy

Author: gribozavr Date: Thu May 9 10:08:10 2019 New Revision: 360358 URL: http://llvm.org/viewvc/llvm-project?rev=360358&view=rev Log: check_clang_tidy.py now passes `-format-style=none` to clang_tidy Summary: If the test does not specify a formatting style, force "none"; otherwise autodetection

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc created this revision. mibintc added reviewers: clang-c, fedor.sergeev. mibintc added a project: clang. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Intel is developing an offload compiler based on clang (that will eventually be contributed to open source). In th

[PATCH] D61689: Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)

compnerd added a comment. I don't really have a problem with this change. But, if we make this change, please include a change to the release notes *now*. This is something which may catch users off guard and confuse them and require them to go looking for what happened. As an aside, I think

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 198862. ilya-biryukov marked 6 inline comments as done. ilya-biryukov added a comment. - Move filling the gaps at the end of files to a separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

russell.gallop created this revision. russell.gallop added reviewers: rnk, bogner. russell.gallop added a project: clang. This is needed so lld-link can find clang_rt.profile when self hosting on Windows with PGO. Trying to self host on Windows with PGO runs into undefined symbols as lld-link d

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:130 + OS << llvm::formatv( + "['{0}'_{1}, '{2}'_{3}) => ['{4}'_{5}, '{6}'_{7})\n", + PrintToken(File.SpelledTokens[M.BeginSpelled]), M.BeginSpelled, il

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 198857. ilya-biryukov added a comment. - Move the constuction logic to a separate class, split into multiple methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D598

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

aprantl added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *Import(TypeSourceInfo *FromTSI); +llvm

[PATCH] D61739: check_clang_tidy.py now passes `-format-style=none` to clang_tidy

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61739/new/ https://reviews.llvm.org/D61739

[PATCH] D61739: check_clang_tidy.py now passes `-format-style=none` to clang_tidy

gribozavr created this revision. gribozavr added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the test does not specify a formatting style, force "none"; otherwise autodetection logic can discover a ".clang-tidy" file that is not related to the test

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

ilya-biryukov added a comment. Here are some numbers from running `clang -cc1 -Eonly` on `SemaExpr.cpp`, it includes a whole ton of headers, including a rather large `TreeTransform.h`. This was run on my machine, so keep in mind it's rather noisy. Minimal times should be somewhat representative

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

micah-s added a comment. @djasper @klimek @krasimir @sammccall @enyquist Can I trouble you for an update? In D28462#1492600 , @jkorous wrote: > Hi @VelocityRa, just FYI - it's considered fine to ping your reviewers once > per week here if you've addres

[PATCH] D61734: [clangd] Bump index version and get rid of wrong assertion

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360349: [clangd] Bump index version and get rid of wrong assertion (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D61734?vs=198825&id=198828#toc Repository:

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3590 +Twine("-interface-stubs-version=") + +Args.getLastArgValue(options::OPT_ifso_version_EQ))); + } compnerd wr

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

sammccall added a comment. In D50993#1496638 , @Dmitry.Kozhevnikov wrote: > In D50993#1496250 , @ilya-biryukov > wrote: > > > We should definitely land this. > > > > @Dmitry.Kozhevnikov, you don't have commit acce

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

Dmitry.Kozhevnikov added a comment. In D50993#1496250 , @ilya-biryukov wrote: > We should definitely land this. > > @Dmitry.Kozhevnikov, you don't have commit access, right? Should we land > these two revisions for you? The depending review was never d

[PATCH] D53866: [Preamble] Stop circular inclusion of main file when building preamble

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. See the nit about naming of an error, though Comment at: include/clang/Basic/DiagnosticLexKinds.td:429

[PATCH] D61497: [clangd] Introduce a structured hover response

sammccall added a comment. Main comment is that I think the code is doing too much work to exactly reproduce the current output, and include as much information as possible. Minimizing the diff is good all else equal, but one of the goals here is to have richer hovercards that are more consisten

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman reopened this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D56160#1496594 , @aaron.ballman wrote: > In D56160#1496391 , @bernhardmgruber > wrote: > > >

[clang-tools-extra] r360349 - [clangd] Bump index version and get rid of wrong assertion

Author: kadircet Date: Thu May 9 08:07:53 2019 New Revision: 360349 URL: http://llvm.org/viewvc/llvm-project?rev=360349&view=rev Log: [clangd] Bump index version and get rid of wrong assertion Summary: After rL360344, BackgroundIndex expects symbols with zero refcounts. Therefore existing index

[PATCH] D61734: [clangd] Bump index version and get rid of wrong assertion

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61734/new/ https://reviews.llvm.org/D61734 _

[clang-tools-extra] r360348 - Revert r360345 and r360346, as they are not passing the testbots.

Author: aaronballman Date: Thu May 9 08:06:41 2019 New Revision: 360348 URL: http://llvm.org/viewvc/llvm-project?rev=360348&view=rev Log: Revert r360345 and r360346, as they are not passing the testbots. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/48063/st

[clang-tools-extra] r360346 - Fixing a link in the release notes to appease the Sphinx bot.

Author: aaronballman Date: Thu May 9 08:00:38 2019 New Revision: 360346 URL: http://llvm.org/viewvc/llvm-project?rev=360346&view=rev Log: Fixing a link in the release notes to appease the Sphinx bot. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/d

  1   2   >