[PATCH] D29707: Fix improper microsoft-pure-definition warning on template class

adrianh.bsc added a comment. Just wondering if this will be fixed soon. It's kinda annoying. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D29707/new/ https://reviews.llvm.org/D29707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: r358665 - [clang][CIndex] Use llvm::set_thread_priority

This breaks building with LLVM_ENABLE_THREADS=OFF. The call probably needs to be behind a `#if LLVM_ENABLE_THREADS`. FAILED: bin/c-index-test ... lib/libclang.a(CIndex.cpp.o): In function `void llvm::function_ref::callback_fn(long)': CIndex.cpp:(.text._ZN4llvm12function_refIFvvEE11callback_fnIZ25c

[PATCH] D60937: [clangd] Fix code completion of macros defined in the preamble region of the main file.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. This is a tricky case (we baked the assumption that symbols come from the preamble xor mainfile pretty de

[PATCH] D60910: [WIP] Dumping the AST to JSON

riccibruno added a comment. In D60910#1473484 , @aaron.ballman wrote: > In D60910#1473441 , @riccibruno > wrote: > > > A few comments/questions: > > > > 1. How stable is the format going to be, and how much state

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker updated this revision to Diff 195973. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/DeclBase.h clang/include/clang/AST/DeclCXX.h clang/include/clang/ASTMatchers/ASTMatch

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:959 + // Each decl-specifier shall appear at most once in a complete + // decl-specifier-seq, except that long may appear twice. + if (hasExplicitSpecifier()) { ---

[PATCH] D60910: [WIP] Dumping the AST to JSON

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. In D60910#1473441 , @riccibruno wrote: > A few comments/questions: > > 1. How stable is the format going to be, and how much state is going to be > exposed ? I don't expect i

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. In D60872#1473205 , @rsmith wrote: > Hmm. So there are a few different situations where we might meet an unknown > attribute (I'm sure I missed some): > > 1. The attribute had

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

riccibruno added a comment. This patch certainly took a few hours to write. Can you spend 5 minutes on making the summary readable (spelling, capitalization, formatting, well-formed sentences, ...) ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ http

[PATCH] D60186: Support CLANG_ENABLE_DEFAULT_PIE like gcc --enable-default-pie

jiangyi added a comment. @rsmith How do you think of this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60186/new/ https://reviews.llvm.org/D60186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Quuxplusone added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2620 + + bool hasExplicitSpecifer() const { +return ExplicitSpecifier.getInt() != ESF_resolved_false || s/Specifer/Specifier/ (and please `git grep` for other instances of the s

[PATCH] D60910: [WIP] Dumping the AST to JSON

riccibruno added a subscriber: lebedev.ri. riccibruno added a comment. A few comments/questions: 1. How stable is the format going to be, and how much state is going to be exposed ? 2. I am wondering if it would be possible to separate the logic about how to visit a given AST node, from the log

[PATCH] D60523: [clang] Bugfixe for 41400

Tyker added a comment. awaiting feedback on this Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60523/new/ https://reviews.llvm.org/D60523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch adds support for the explicit bool specifier. added parsing for explicit bool specifier

[PATCH] D60899: [analyzer] Unbreak body farms in presence of multiple declarations.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Artem, This looks good to me. However, it seems to me that the correct solution is to synthesize a shining new function and include it into the redeclaration chain. This requires much

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

Hahnfeld added a comment. So the scheme is: `pow` is defined in `__clang_openmp_math.h` to call `__kmpc_pow`. This lives in `libomptarget-nvptx` (both bc and static lib) and just calls `pow` which works because `nvcc` and Clang in CUDA mode make sure that the call gets routed into `libdevice`?