[PATCH] D59605: [clangd] Introduce background-indexer

ilya-biryukov added a comment. I would propose to change the name of the tool. The "background" part only makes sense in the context of running inside clangd, the index stored on disk is not "background" in any manner. I'd go with something like `build-clangd-index` (the best option is probably

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:405 - std::vector Diags = ASTDiags.take(); + auto ShouldSurfaceDiag = [](const Diag &D) { +if (D.Severity == DiagnosticsEngine::Level::Error || The name suggests we filter **all** diag

[PATCH] D60379: Make precompiled headers reproducible

lebedev.ri added a comment. Needs a test. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto &I : SemaRef.OpenCLTypeExtMap) { Woul

r357879 - IAS is now enabled for all OS on MIPS64

Author: brad Date: Sun Apr 7 17:03:01 2019 New Revision: 357879 URL: http://llvm.org/viewvc/llvm-project?rev=357879&view=rev Log: IAS is now enabled for all OS on MIPS64 Modified: cfe/trunk/test/Driver/freebsd.c cfe/trunk/test/Driver/openbsd.c Modified: cfe/trunk/test/Driver/freebsd.c U

r357878 - Enable IAS for FreeBSD SPARC64.

Author: brad Date: Sun Apr 7 16:12:31 2019 New Revision: 357878 URL: http://llvm.org/viewvc/llvm-project?rev=357878&view=rev Log: Enable IAS for FreeBSD SPARC64. Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/trunk/test/Driver/freebsd.c Modified: cfe/trunk/lib/Driver/ToolChains/G

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

brad added a comment. George, look at adding some appropriate entries to test/Driver/frame-pointer-elim.c Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60335/new/ https://reviews.llvm.org/D60335 ___ cfe-commits mail

[PATCH] D60380: Also document -arch as -arch is mac specific

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D60380 Files: docs/CommandGuide/clang.rst Index: docs/CommandGuide/clang.rst ===

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: yaxunl, Anastasia. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch have been applied to Debian packages for a few months without any regression. Patch by Rebecca N. Palmer Repository: rC

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert added a comment. In D59673#1452269 , @dblaikie wrote: > Ah, fair. You could actually test the dwo_name is accurate in the .dwo file > (I added the dwo_name to the .dwo file so that multi-level dwp error messages > could be more informative)

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

This revision was automatically updated to reflect the committed changes. Closed by commit rL357877: [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413 (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

r357877 - [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413

Author: owenpan Date: Sun Apr 7 14:05:52 2019 New Revision: 357877 URL: http://llvm.org/viewvc/llvm-project?rev=357877&view=rev Log: [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413 Differential Revision: https://reviews.llvm.org/D60374 Modified: cfe/trunk/lib/Format/Conti

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan requested review of this revision. owenpan added a comment. Updated the diff. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60374/new/ https://reviews.llvm.org/D60374 ___ cfe-commits mailing list cfe-commits@

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan updated this revision to Diff 194072. This revision is now accepted and ready to land. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60374/new/ https://reviews.llvm.org/D60374 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unittests/Format/Form

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay added a comment. In D60374#1457705 , @owenpan wrote: > In D60374#1457693 , @MyDeveloperDay > wrote: > > > LGTM , if you also think the test will help show the use case then please > > add it, otherw

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan added a comment. In D60374#1457693 , @MyDeveloperDay wrote: > LGTM , if you also think the test will help show the use case then please add > it, otherwise this revision notes might be information enough Thanks! I just got the alternative patch

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan planned changes to this revision. owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:968 if (Current.is(tok::r_paren) && State.Stack.size() > 1 && - (!Current.Next || Current.Next->isOneOf(tok::semi, tok::l_brace))) + (!Curre

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM , if you also think the test will help show the use case then please add it, otherwise this revision notes might be information enough Repository: rC Clang CHANGES SIN

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan added a comment. In D60374#1457639 , @MyDeveloperDay wrote: > maybe add the following as a test because I think it shows the inconsistency > > void Foo::bar( // some comment > ) {} > > void Foo::bar( // some comment > ) const {} > I ha

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

owenpan added a comment. In D60374#1457638 , @klimek wrote: > The previous behavior looks intentional, and much more regular. I'd be > curious why you think the proposed behavior is more readable. I see the bug in the inconsistency for the code below:

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Woohoo! Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the future,

Re: [PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

Even if I just issue one file with /Yc and none with /Yu, it still fails. Looks like it possibly generates two processes, one to generate the pch and the other to compile and link. A temp file is generated but no final pch; an error is emitted "Unable to read pch file foo.pch". On Sun, 7 Apr 2019,

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay added a comment. maybe add the following as a test because I think it shows the inconsistency void Foo::bar( // some comment ) {} void Foo::bar( // some comment ) const {} Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60374/new/ https:/

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

klimek added a comment. The previous behavior looks intentional, and much more regular. I'd be curious why you think the proposed behavior is more readable. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60374/new/ https://reviews.llvm.org/D60374 _

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

probinson added inline comments. Comment at: test/CodeGenCXX/debug-info-composite-triviality.cpp:88 - -// CHECK-DAG: !DICompositeType({{.*}}, name: "NonTrivialE",{{.*}}flags: {{.*}}DIFlagNonTrivial -struct NonTrivialE : Trivial, NonTrivial { Hui wrote: > probins

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

aganea added a comment. That is strange. As you can’t mix /Yc and /Yu on the command line, MSBuild should issue two different calls to clang-cl, one with /Yc and one /Yu /MP. Can you check with ProcMon that commands are issued in the right order? Repository: rC Clang CHANGES SINCE LAST ACTI

[PATCH] D60374: clang-format incorrectly indents wrapped closing parenthesis

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:968 if (Current.is(tok::r_paren) && State.Stack.size() > 1 && - (!Current.Next || Current.Next->isOneOf(tok::semi, tok::l_brace))) + (!Current.Next || Current.Next->isOneOf(to

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk updated this revision to Diff 194057. reuk added a comment. Fixed formatting nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Forma

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM (minor nit) Comment at: clang/lib/Format/TokenAnnotator.cpp:2834 } - if (Left.is(TT_UnaryOperator)) -return Right.is(TT_BinaryOperator); + if (L

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay added a comment. In D60320#1457568 , @reuk wrote: > I updated `ClangFormatStyleOptions.rst` by hand, is there a way to do that > automatically instead (for future patches)? I do it by hand, I know there is a python script out there, go wi

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst:33 + + Upper limit for the magnitue bits of the loop variable. If it's

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk added a comment. I updated `ClangFormatStyleOptions.rst` by hand, is there a way to do that automatically instead (for future patches)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 ___ cfe-c

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk updated this revision to Diff 194055. reuk added a comment. Updated with fixes. Thanks for pointing out that the options are ordered alphabetically, I hadn't noticed that! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 Files: clang/docs

[PATCH] D52193: RFC: [clang] Multithreaded compilation support -- NOT FOR SUBMIT

angushewlett added a comment. Having applied this patch to the clang latest (which took a bit of doing, and it's possible I messed up along the way) - all working in general, and a roughly 6x speed-up on my i7-7820X. However, PCH support does not seem to work correctly. Specifically, it looks

[PATCH] D54978: Move the SMT API to LLVM

NoQ added inline comments. Comment at: cfe/trunk/CMakeLists.txt:453 +if(NOT CLANG_ENABLE_STATIC_ANALYZER AND CLANG_ENABLE_ARCMT) message(FATAL_ERROR "Cannot disable static analyzer while enabling ARCMT or Z3") endif() This message needs to be updated :) Re