[PATCH] D55044: [clang-tidy] check for Abseil make_unique

lebedev.ri resigned from this revision. lebedev.ri added a comment. Hmm, i suppose this looks good to me now. It would be good to early-exit, but i'm not sure how important that is. Please see D52771 / `clang-tools-extra/trunk/clang-tidy/misc/NonPrivateMemberVari

[PATCH] D60308: Leave alone the semicolon after the MacroBlockBegin name

owenpan created this revision. owenpan added reviewers: sammccall, klimek, djasper, krasimir. owenpan added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes the bug below. The code: FOO_BEGIN(); FOO_ENTRY FOO_END(); is erroneously formatted to: FOO_BEGIN()

[PATCH] D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers.

NoQ updated this revision to Diff 193828. NoQ marked 6 inline comments as done. NoQ added a comment. Address comments. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60107/new/ https://reviews.llvm.org/D60107 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp clang

[PATCH] D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:364 QualType T = PVD->getType(); - while (const MemRegion *R = S.getAsRegion()) { -if (RegionOfInterest->isSubRegionOf(R) && !isPointerToConst(T)) - return no

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak added a comment. Corresponding llvm patch is here: https://reviews.llvm.org/D60303. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60302/new/ https://reviews.llvm.org/D60302 ___ cfe-commits mailing list cfe-c

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak created this revision. ahatanak added reviewers: steven_wu, dexonsmith, rjmccall. ahatanak added a project: clang. Herald added subscribers: jkorous, kristof.beyls, javed.absar, mehdi_amini. This fixes a bug which causes the ARC contract pass to not insert the assembly marker that is nee

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

Thanks! I committed the fix in r357740. The test should start passing now. Cheers, Alex On Thu, 4 Apr 2019 at 18:32, Stephen Hines wrote: > Ah I just saw this. Please feel free to CC me on the fix CL and I will > approve it. I didn't realize that the exact specification was missing > for that.

r357740 - [test] Specify an explicit darwin version in a triple in

Author: arphaman Date: Thu Apr 4 18:48:11 2019 New Revision: 357740 URL: http://llvm.org/viewvc/llvm-project?rev=357740&view=rev Log: [test] Specify an explicit darwin version in a triple in `test/Driver/debug-options.c` to ensure that the driver selects the DWARF 2 version as intended by the tes

[PATCH] D60301: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak abandoned this revision. ahatanak added a comment. I'll write the summary and send the patch again. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60301/new/ https://reviews.llvm.org/D60301 ___ cfe-commits ma

[PATCH] D60301: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak created this revision. ahatanak added reviewers: steven_wu, dexonsmith, rjmccall. ahatanak added a project: clang. Herald added a subscriber: jkorous. Repository: rC Clang https://reviews.llvm.org/D60301 Files: lib/CodeGen/CGObjC.cpp test/CodeGenObjC/arc-unsafeclaim.m Index: tes

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

Ah I just saw this. Please feel free to CC me on the fix CL and I will approve it. I didn't realize that the exact specification was missing for that. Thanks, Steve On Thu, Apr 4, 2019 at 6:31 PM Alex L wrote: > > Thanks, for the explanation, it makes sense. It looks like an explicit > `darwin1

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

Thanks, for the explanation, it makes sense. It looks like an explicit `darwin14` in one of the non-versioned darwin triples fixes the issue. I will commit the fix right away. Cheers, Alex On Thu, 4 Apr 2019 at 18:24, Adrian Prantl wrote: > IIRC, the dwarf version on Darwin depends on the depl

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

IIRC, the dwarf version on Darwin depends on the deployment target and is 2 for earlier versions of macOS and and 4 for newer ones (I need to dig through the driver code to determine the exact version). I can take a look at this tomorrow morning. -- adrian > On Apr 4, 2019, at 6:21 PM, Alex L

Re: r357713 - Verify that Android targets generate DWARF 4 by default.

Hi Stephen, It looks like your change has caused the 'debug-options.c' test to start failing on Darwin. It looks like we emit "-dwarf-version=4" by default, and not 2. Could you please take a look. Here's a link to a latest build on the public LLVM CI that contains the failure: http://lab.llvm.or

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore planned changes to this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:112 + << Message->getMethodDecl() + << FixItHint::CreateReplacement(Mess

[PATCH] D60279: [CUDA] Implemented _[bi]mma* builtins.

tra updated this revision to Diff 193809. tra added a comment. - Added PTX64 to the list of builtins' constraints. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60279/new/ https://reviews.llvm.org/D60279 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Basic/Targets/NVP

[PATCH] D60287: [IR] Refactor attribute methods in Function class (NFC)

evandro added a comment. If anyone could give me a tip on how to avoid the review to be collapsed to just the part of whichever repo was hit first by a commit, I'd appreciate it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60287/new/ https://reviews.llvm.org/D

[PATCH] D60279: [CUDA] Implemented _[bi]mma* builtins.

tra updated this revision to Diff 193796. tra added a comment. - Fixed minor issues with parameters of the new builtins: - __imma*_st_c_i32 builtins have 'const int * src' - __bmma_m8n8k128_mma_xor_popc_b1 does not have 'satf' argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D60287: [IR] Refactor attribute methods in Function class (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rC357731: [IR] Refactor attribute methods in Function class (NFC) (authored by evandro, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: http

r357731 - [IR] Refactor attribute methods in Function class (NFC)

Author: evandro Date: Thu Apr 4 15:40:06 2019 New Revision: 357731 URL: http://llvm.org/viewvc/llvm-project?rev=357731&view=rev Log: [IR] Refactor attribute methods in Function class (NFC) Rename the functions that query the optimization kind attributes. Differential revision: https://reviews.l

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang updated this revision to Diff 193792. akhuang marked 3 inline comments as done. akhuang added a comment. -added struct case to test -style fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60237/new/ https://reviews.llvm.org/D60237 Files: clang/lib/CodeGen/CGCall.cpp clan

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rnk added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:9473-9474 IsWin32FloatStructABI, CodeGenOpts.NumRegisterParameters)); +} else if (Triple.getOS() == llvm::Triple::Linux) { + // System V i386 ABI requires __m64 value passing by MMX registers. +

[PATCH] D55229: [COFF] Statically link certain runtime library functions

rnk added a comment. This patch fixes a lot of LNK4286 warnings when running `check-asan` on Windows, so I'd like to get it committed upstream. Are there any remaining objections? Is it OK if I commandeer the revision and make some minor aesthetic adjustments and land it? CHANGES SINCE LAST A

[PATCH] D60247: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer*

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357724: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm… (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60247?

[clang-tools-extra] r357724 - Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer*

Author: nico Date: Thu Apr 4 14:06:41 2019 New Revision: 357724 URL: http://llvm.org/viewvc/llvm-project?rev=357724&view=rev Log: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer* Requires making the llvm::MemoryBuffer* stored by SourceManager const, which in tu

r357724 - Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer*

Author: nico Date: Thu Apr 4 14:06:41 2019 New Revision: 357724 URL: http://llvm.org/viewvc/llvm-project?rev=357724&view=rev Log: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer* Requires making the llvm::MemoryBuffer* stored by SourceManager const, which in tu

[PATCH] D60279: [CUDA] Implemented _[bi]mma* builtins.

tra updated this revision to Diff 193774. tra edited the summary of this revision. tra added a comment. Cleaned up mma test generation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60279/new/ https://reviews.llvm.org/D60279 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/

[PATCH] D60247: Make SourceManager::createFileID(UnownedTag, ...) take a const llvm::MemoryBuffer*

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60247/new/ https://reviews.llvm.org/D60247 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D60094: [MSVC] If unable to find link.exe relative to MSVC, look for link.exe in the path

rnk added inline comments. Comment at: lib/Driver/ToolChains/MSVC.cpp:493 C.getDriver().Diag(clang::diag::warn_drv_msvc_not_found); + linkPath = TC.GetProgramPath("link.exe"); +} mstorsjo wrote: > rnk wrote: > > amccarth wrote: > > > The comment a

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

rnk added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:429-430 + const FileEntry *fileEntry = SM.getFileEntryForID(foundIdFromLoc); + if (!fileEntry || fileEntry->getName().empty() || + fileEntry->getName().equals(FileName)) { +CSKind = computeChecksum(foun

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman closed this revision. dgoldman added a comment. Closed via rL357720 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commit

r357720 - Special case ObjCPropertyDecl for printing

Author: dgoldman Date: Thu Apr 4 13:13:22 2019 New Revision: 357720 URL: http://llvm.org/viewvc/llvm-project?rev=357720&view=rev Log: Special case ObjCPropertyDecl for printing ObjCPropertyDecl should use the category interface as a context similar to what is done for methods. Previously categ

[PATCH] D60283: [clang-cl] Don't emit checksums when compiling a preprocessed CPP

aganea created this revision. aganea added reviewers: rnk, scott.linder, uabelho, aprantl. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compiling from an already preprocessed CPP, the checksums generated in the debug info would be those of the (input) preprocessed C

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357719: check-clang-tools: Actually build and run XPC test (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60120?vs=193256&id=19377

[clang-tools-extra] r357719 - check-clang-tools: Actually build and run XPC test

Author: nico Date: Thu Apr 4 13:08:04 2019 New Revision: 357719 URL: http://llvm.org/viewvc/llvm-project?rev=357719&view=rev Log: check-clang-tools: Actually build and run XPC test The CMake variable controlling if XPC code is built is called CLANGD_BUILD_XPC but three places unintentionally che

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman updated this revision to Diff 193769. dgoldman added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 Files: lib/AST/Decl.cpp unittests/AST/NamedDeclPrinterTest.cpp Index: unittests/AST/Nam

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

rnk added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4382-4383 + // Add metadata for calls to MSAllocator functions + if (!DisableDebugInfo) { +if (TargetDecl && TargetDecl->hasAttr()) + getDebugInfo()->addHeapAllocSiteMetadata(CI, RetTy, Loc); -

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

NoQ added a comment. I guess i'll commit, given that i don't know anybody else who uses these functions anyway. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59977/new/ https://reviews.llvm.org/D59977 ___ cfe-commit

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis added a comment. erik.pilkington, could you stamp this maybe? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

rnkovacs created this revision. rnkovacs added reviewers: NoQ, xazax.hun, Szelethus, dcoughlin, dkrupp. Herald added subscribers: cfe-commits, Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Tried to pick two inte

r357717 - [OPENMP]Add codegen for task reduction vars with allocate clause, NFC.

Author: abataev Date: Thu Apr 4 11:58:17 2019 New Revision: 357717 URL: http://llvm.org/viewvc/llvm-project?rev=357717&view=rev Log: [OPENMP]Add codegen for task reduction vars with allocate clause, NFC. Added test for the task reduction variables with the allocate clause. Modified: cfe/tru

[PATCH] D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. It is very good to try one improvement in another similar function. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:364 QualType T = PVD->getType

[PATCH] D60279: [CUDA] Implemented _[bi]mma* builtins.

tra created this revision. tra added reviewers: timshen, jlebar. Herald added subscribers: llvm-commits, bixia, hiraditya, jholewinski. Herald added a project: LLVM. These builtins provide access to the new integer and sub-integer variants of MMA (matrix multiply-accumulate) instructions provided

[PATCH] D60236: add periods

akhuang abandoned this revision. akhuang added a comment. test commit with incorrect diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60236/new/ https://reviews.llvm.org/D60236 ___ cfe-commits mailin

[PATCH] D60238: Verify that Android targets generate DWARF 4 by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357713: Verify that Android targets generate DWARF 4 by default. (authored by srhines, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

r357713 - Verify that Android targets generate DWARF 4 by default.

Author: srhines Date: Thu Apr 4 11:17:46 2019 New Revision: 357713 URL: http://llvm.org/viewvc/llvm-project?rev=357713&view=rev Log: Verify that Android targets generate DWARF 4 by default. Summary: In the future, Android releases will support DWARF 5, but we need to ensure that older targets on

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang updated this revision to Diff 193751. akhuang marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60237/new/ https://reviews.llvm.org/D60237 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGDebugInfo.h c

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang marked an inline comment as done. akhuang added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1691 } else { -// Build new lvalue for temp address +// Build new lvalue for temp address. Address Ptr = Atomics.materializeRValue(OldRVal); ---

r357712 - [OPENMP]Add codegen for linear vars with allocate clause, NFC.

Author: abataev Date: Thu Apr 4 11:06:53 2019 New Revision: 357712 URL: http://llvm.org/viewvc/llvm-project?rev=357712&view=rev Log: [OPENMP]Add codegen for linear vars with allocate clause, NFC. Added test for the linear variables with the allocate clause. Modified: cfe/trunk/test/OpenMP/f

[libunwind] r357711 - Move the alias definition of unw_getcontext to within !defined(__USING_SJLJ_EXCEPTIONS__)

Author: mstorsjo Date: Thu Apr 4 10:50:14 2019 New Revision: 357711 URL: http://llvm.org/viewvc/llvm-project?rev=357711&view=rev Log: Move the alias definition of unw_getcontext to within !defined(__USING_SJLJ_EXCEPTIONS__) For builds with SJLJ, there is no __unw_getcontext symbol. On Windows,

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

ormris added inline comments. Comment at: test/ClangScanDeps/regular_cdb.cpp:14 +// CHECK: regular_cdb.cpp +// CHECK-NEXT: Inputs/header.h Quick drive-by nit: This test won't work under Windows due to the path separator. To account for both platforms, you could

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel updated this revision to Diff 193750. ymandel added a comment. Rebasing to parent D60269 so that diffs show correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D593

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel updated this revision to Diff 193748. ymandel added a comment. Switch from using FixIt to SourceCode, as solution to circular dependency problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376 Fil

r357708 - [OPENMP]Fix lookup of the user-defined reductions in C.

Author: abataev Date: Thu Apr 4 10:28:22 2019 New Revision: 357708 URL: http://llvm.org/viewvc/llvm-project?rev=357708&view=rev Log: [OPENMP]Fix lookup of the user-defined reductions in C. Fixed the regression of the lookup of user-defined reductions for C. Modified: cfe/trunk/lib/Sema/Sema

[PATCH] D60269: [LibTooling] Add "SourceCode" library for functions relating to source-code manipulation.

ymandel updated this revision to Diff 193741. ymandel added a comment. Various tweaks to get tests compiling/passing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60269/new/ https://reviews.llvm.org/D60269 Files: clang/include/clang/Tooling/Fix

[PATCH] D60269: [LibTooling] Add "SourceCode" library for functions relating to source-code manipulation.

ymandel updated this revision to Diff 193736. ymandel added a comment. Herald added a subscriber: mgorny. Update CMakeLists.txt and rename (misnamed) test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60269/new/ https://reviews.llvm.org/D6026

[PATCH] D60269: [LibTooling] Add "SourceCode" library for functions relating to source-code manipulation.

ymandel updated this revision to Diff 193735. ymandel added a comment. Add tests for SourceCode and remove corresponding tests from FixIt tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60269/new/ https://reviews.llvm.org/D60269 Files: clan

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-type-mismatch check

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:136 + + Finds placement-new calls where the size of the pointee type of the placement + parameter is smaller than the size of the constructed type and the pointer is Please synchronize wi

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

dnsampaio created this revision. dnsampaio added reviewers: pablooliveira, olista01, LukeGeeson. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Implements the intrinsics define on the ACLE to extract half precision fp scalar elements from float16

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek updated this revision to Diff 193733. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59264/new/ https://reviews.llvm.org/D59264 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtbegin-i386.o clang/test/Driver/Inputs/resourc

[PATCH] D60269: [LibTooling] Add "SourceCode" library for functions relating to source-code manipulation.

ymandel created this revision. ymandel added reviewers: ilya-biryukov, ioeric. Herald added a project: clang. Introduces a utility library in Refactoring/ to collect routines related to source-code manipulation. In this change, we move "extended-range" functions from the FixIt library (in clangTo

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:290 -class LangOpt { +class LangOpt { string Name = name; I think there's a grand total of one use of `negated`, so you might as well rewrite it to use `customCode`; see below. ==

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-type-mismatch check

DennisL updated this revision to Diff 193715. DennisL marked an inline comment as done. DennisL retitled this revision from "[clang-tidy] Add misc-placement-new-target-size check" to "[clang-tidy] Add misc-placement-new-target-type-mismatch check". DennisL edited the summary of this revision. Den

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:18 + +AST_MATCHER(Expr, isMacroID) { return Node.getExprLoc().isMacroID(); } +} // namespace ast_matchers aaro

r357702 - [RISCV] Fix rL357699 by adding missing zero-length files

Author: asb Date: Thu Apr 4 07:36:07 2019 New Revision: 357702 URL: http://llvm.org/viewvc/llvm-project?rev=357702&view=rev Log: [RISCV] Fix rL357699 by adding missing zero-length files svn add doesn't play very nicely here... Added: cfe/trunk/test/Driver/Inputs/basic_riscv64_tree/lib/gcc/

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 updated this revision to Diff 193705. boga95 added a comment. Rebase after https://reviews.llvm.org/D59861. Fix custom filter test case: functions without definition always remove taintedness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D595

[PATCH] D53392: [RISCV] Collect library directories and triples for riscv64 triple too

This revision was automatically updated to reflect the committed changes. Closed by commit rL357699: [RISCV] Collect library directories and triples for riscv64 triple too (authored by asb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D60203: Updating Chromium's Java import order

This revision was automatically updated to reflect the committed changes. Closed by commit rC357700: Updating Chromium's Java import order (authored by nico, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203

[PATCH] D53392: [RISCV] Collect library directories and triples for riscv64 triple too

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Herald added subscribers: benna, psnobl, MaskRay. This got missed somehow as I had a functionally identical patch in my local development tree (though not with as thorough tests - thanks for that!).

[PATCH] D60267: [clangd] Support relatedInformation in diagnostics.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. We already have the structure internally, we just need to expose it. Repository: rCTE Clang Tools Ext

[PATCH] D60203: Updating Chromium's Java import order

thakis added a comment. Ah, ok. Probably want to add tests at some point, but I'll land this as-is for now then. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60203/new/ https://reviews.llvm.org/D60203 ___ cfe-commi

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

thakis added a comment. Please don't land changes with open discussion. Objective-C++ basically is C++ code. I don't think it makes sense to make a distinction here. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60263/new/ https://reviews.llvm.org/D60263

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ioeric added a comment. In D59376#1454834 , @ymandel wrote: > In D59376#1454768 , @ilya-biryukov > wrote: > > > Per @ioeric's suggestion: why not move the helper into > > `Tooling/Refactoring/ExtendedRange.h`? > >

r357700 - Updating Chromium's Java import order

Author: nico Date: Thu Apr 4 07:19:45 2019 New Revision: 357700 URL: http://llvm.org/viewvc/llvm-project?rev=357700&view=rev Log: Updating Chromium's Java import order Adding in androidx as another import group. Differential Revision: https://reviews.llvm.org/D60203 Patch from Sam Maier ! Mod

r357699 - [RISCV] Collect library directories and triples for riscv64 triple too

Author: asb Date: Thu Apr 4 07:18:26 2019 New Revision: 357699 URL: http://llvm.org/viewvc/llvm-project?rev=357699&view=rev Log: [RISCV] Collect library directories and triples for riscv64 triple too When setting up library and tools paths when detecting an accompanying GCC installation only ris

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

This revision was automatically updated to reflect the committed changes. Closed by commit rL357695: [clang-format] Preserve include blocks in ObjC Google style (authored by krasimir, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHA

[clang-tools-extra] r357696 - Fix clangd-fuzzer build

Author: nico Date: Thu Apr 4 07:08:35 2019 New Revision: 357696 URL: http://llvm.org/viewvc/llvm-project?rev=357696&view=rev Log: Fix clangd-fuzzer build r357102 made clangd-fuzzer no longer compile, but before r357654 / r357694 we didn't notice. Fix the compile. Also add a dep on FuzzMutate wh

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel added a comment. In D59376#1454768 , @ilya-biryukov wrote: > Per @ioeric's suggestion: why not move the helper into > `Tooling/Refactoring/ExtendedRange.h`? > If it's in `ToolingRefactoring`, both stencil and transformer can access it. > > For e

r357695 - [clang-format] Preserve include blocks in ObjC Google style

Author: krasimir Date: Thu Apr 4 07:04:26 2019 New Revision: 357695 URL: http://llvm.org/viewvc/llvm-project?rev=357695&view=rev Log: [clang-format] Preserve include blocks in ObjC Google style Summary: r357567 started to regroup include block for Google style; it was meant to apply only for C++

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

krasimir updated this revision to Diff 193699. krasimir added a comment. - Add a note about intent Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60263/new/ https://reviews.llvm.org/D60263 Files: lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp I

[clang-tools-extra] r357694 - Use a cmake check for linux that actually works.

Author: nico Date: Thu Apr 4 06:54:01 2019 New Revision: 357694 URL: http://llvm.org/viewvc/llvm-project?rev=357694&view=rev Log: Use a cmake check for linux that actually works. Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt

r357693 - [RISCV][NFC] s/riscv32-linux-unknown-elf/riscv32-unknown-linux-gnu in test/Driver/riscv32-toolchain.c

Author: asb Date: Thu Apr 4 06:51:41 2019 New Revision: 357693 URL: http://llvm.org/viewvc/llvm-project?rev=357693&view=rev Log: [RISCV][NFC] s/riscv32-linux-unknown-elf/riscv32-unknown-linux-gnu in test/Driver/riscv32-toolchain.c riscv32-linux-unknown-elf was a weird thing to test for as it do

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

krasimir marked an inline comment as done. krasimir added a comment. In D60263#1454812 , @thakis wrote: > Why would we want this to be different in Obj-C and C++? Only the C++ Style Guide had been updated. Practically, clang-format would need to be updat

[PATCH] D60203: Updating Chromium's Java import order

SamMaier added a comment. In D60203#1453313 , @thakis wrote: > Thanks! > > (Test?) We currently don't have tests for Chromium's specific Java import order. The tests for Java import order use their own order. Should this change? Repository: rC Clang

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

thakis added a comment. Why would we want this to be different in Obj-C and C++? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60263/new/ https://reviews.llvm.org/D60263 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

Why would we want this to be different in Obj-C and C++? On Thu, Apr 4, 2019 at 9:34 AM Krasimir Georgiev via Phabricator via cfe-commits wrote: > krasimir marked 2 inline comments as done. > krasimir added inline comments. > > > > Comment at: lib/Format/Format.cpp:787 >Goog

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

hintonda added a comment. In D60151#1454741 , @alexfh wrote: > In D60151#1454105 , @hintonda wrote: > > > - Rename llvm directory to llvm_project. > > - Change llvm- to llvm-project-. > > - Rename files. > > > Aweso

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

krasimir marked 2 inline comments as done. krasimir added inline comments. Comment at: lib/Format/Format.cpp:787 GoogleStyle.IncludeStyle.IncludeIsMainRegex = "([-_](test|unittest))?$"; GoogleStyle.IncludeStyle.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; GoogleSt

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

ioeric added inline comments. Comment at: lib/Format/Format.cpp:787 GoogleStyle.IncludeStyle.IncludeIsMainRegex = "([-_](test|unittest))?$"; GoogleStyle.IncludeStyle.IncludeBlocks = tooling::IncludeStyle::IBS_Regroup; GoogleStyle.IndentCaseLabels = true;

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov added a subscriber: ioeric. ilya-biryukov added a comment. Per @ioeric's suggestion: why not move the helper into `Tooling/Refactoring/ExtendedRange.h`? If it's in `ToolingRefactoring`, both stencil and transformer can access it. For external users, a dependency on either `ToolingC

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

krasimir created this revision. krasimir added a reviewer: ioeric. Herald added a project: clang. Herald added a subscriber: cfe-commits. r357567 started to regroup include block for Google style; it was meant to apply only for C++. This patch reverts this for ObjC. Repository: rC Clang https

[clang-tools-extra] r357690 - [clangd] Test #import directive go-to-definition. NFC

Author: sammccall Date: Thu Apr 4 06:09:02 2019 New Revision: 357690 URL: http://llvm.org/viewvc/llvm-project?rev=357690&view=rev Log: [clangd] Test #import directive go-to-definition. NFC Modified: clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp Modified: clang-tools-extra/trunk/un

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov added a comment. In D59376#1454748 , @ymandel wrote: > I propose that I create a new library in Core with `getExtendedRange()` and > remove it from FixIt. The other utility functions that I need will also go > there. We can separately inv

[clang-tools-extra] r357689 - [clangd] Stop passing around PCHContainerOperations, just create it in place. NFC

Author: sammccall Date: Thu Apr 4 05:56:03 2019 New Revision: 357689 URL: http://llvm.org/viewvc/llvm-project?rev=357689&view=rev Log: [clangd] Stop passing around PCHContainerOperations, just create it in place. NFC Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel added a comment. In D59376#1454617 , @ilya-biryukov wrote: > Keeping it **only** in the cpp file also LG if we don't plan to have other > usages for now, but please remove the version from `FixIt.h` The Stencil library will need this as well an

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

alexfh added a comment. In D60151#1454105 , @hintonda wrote: > - Rename llvm directory to llvm_project. > - Change llvm- to llvm-project-. > - Rename files. Awesome! Thanks for doing this. Could you ensure that the add_new_check.py script still works?

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

sammccall added inline comments. Comment at: clangd/CodeComplete.cpp:1136 +std::unique_ptr +indexIdentifiers(llvm::StringRef FileName, llvm::StringRef Content, + const format::FormatStyle &Style) { as discussed offline, I love the lexer approach b

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:18 + +AST_MATCHER(Expr, isMacroID) { return Node.getExprLoc().isMacroID(); } +} // namespace ast_matchers hintonda wrote: > aaron.ballman wrote: > >

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:145 + +diag(MatchedDecl->getBeginLoc(), "use dyn_cast_or_null") +<< FixItHint::CreateReplacement(SourceRange(MatchedDecl->getBeginLoc(), ---

  1   2   >