[clang-tools-extra] r356849 - [pp-trace] Modernize the code

Author: maskray Date: Sat Mar 23 23:55:08 2019 New Revision: 356849 URL: http://llvm.org/viewvc/llvm-project?rev=356849&view=rev Log: [pp-trace] Modernize the code Use InitLLVM and WithColor Delete PPTraceConsumer, add the callback in PPTraceAction Migrae to tooling::createExecutorFromCommandLine

[PATCH] D59745: [NFC] Move writeFuncOrVarName out of class CodegenNameGenerator so that it can be reused more easily.

plotfi created this revision. plotfi added reviewers: compnerd, akyrtzi. Herald added subscribers: cfe-commits, jdoerfert, arphaman. Herald added a project: clang. I simply want a helper function to use for printing out mangled Decl names. I think this could be a pretty simple straightforward pat

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 created this revision. wxiao3 added reviewers: annita.zhang, LuoYuanke, smaslov, craig.topper, hjl.tools. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to System V i386 ABI: the "__m64" type paramater and return va passed by MMX registers. But current imp

[PATCH] D59743: [WebAssembly] Don't use default GetLinkerPath

sbc100 created this revision. Herald added subscribers: cfe-commits, atanasyan, jrtc27, sunfish, aheejin, jgravelle-google, sdardis, dschuff. Herald added a project: clang. We can't (don't want to) honor the same set of "-fuse-ld" flags with WebAssembly since the ELF linkers (ld.lld, ld.gnu, etc)

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

sbc100 added a comment. Hi @phosek ! Fixed in rL356847 . This did make me look a little deeper into this issue though, and wonder if the CLANG_DEFAULT_LINKER is implemented in a useful way right now. I believe the reason this came up for you guys in that you

[PATCH] D59682: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.

This revision was automatically updated to reflect the committed changes. Closed by commit rC356848: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc. (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D59682?vs=192010&id=192017#toc Repositor

r356848 - [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.

Author: ctopper Date: Sat Mar 23 17:56:52 2019 New Revision: 356848 URL: http://llvm.org/viewvc/llvm-project?rev=356848&view=rev Log: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc. Summary: These are all implemented by icc as well. I made bit_scan_forward/reverse forward to the

r356847 - [WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of CLANG_DEFAULT_LINKER

Author: sbc Date: Sat Mar 23 17:03:41 2019 New Revision: 356847 URL: http://llvm.org/viewvc/llvm-project?rev=356847&view=rev Log: [WebAssembly] Fix test/Driver/wasm-toolchain.c in the presence of CLANG_DEFAULT_LINKER This was broken in rL356817 (See https://reviews.llvm.org/D59721) Modified:

[PATCH] D59682: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59682/new/ https://reviews.llvm.org/D59682 ___ cfe

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

hintonda added a comment. In D17407#1439029 , @xbolva00 wrote: > Please check also https://bugs.llvm.org/show_bug.cgi?id=40030 If you compile with -pedantic, you'll get the following warning: `warning: designated initializers are a C99 feature [-Wc99-e

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

lebedev.ri added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1795 + BranchHint getBranchHint() const { return IfStmtBits.Hint; } + `lib/AST/TextNodeDumper.cpp` will need to be taught to print it too (and astdumper test coverage to show that)

[PATCH] D59741: [lit] Set shlibpath_var on AIX

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: xingxue, jasonliu, sfertile. Herald added a reviewer: serge-sans-paille. Herald added subscribers: cfe-commits, jsji. Herald added a project: clang. When building the `check-all` target on AIX, lit produces wa

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker added a comment. @riccibruno Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 192012. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticS

[PATCH] D59523: Thread Safety: also look at ObjC methods

aaronpuchert added a comment. In D59523#1440263 , @aaron.ballman wrote: > In D59523#1440238 , @jfb wrote: > > > This is very concrete: this specific code used to cause a crash. This test > > has exactly this purpo

[PATCH] D59682: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.

craig.topper updated this revision to Diff 192010. craig.topper added a comment. Add doxygen comments. Check the zero_undef flag. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59682/new/ https://reviews.llvm.org/D59682 Files: lib/Headers/ia32intrin.h lib/Hea

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

keryell added a comment. In D59603#1437684 , @Anastasia wrote: > Updated test to use root namespace (commented by Ronan). Thank you for testing! :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59603/new/ https://reviews.llvm.org/D59603 __

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

riccibruno added a comment. Before any further review, could you please run `clang-format` on your patch (but not necessarily on the tests and not on the `*.td` files), wrap lines to 80 cols, and in general use complete sentences in comments (that is with proper punctuation and capitalization)

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 192004. Tyker added a comment. i implemented the semantic the changes for if for, while and do while statement and the AST change to if. can you review it and tell me if it is fine so i implement the rest. i didn't update the test so they will fail. CHANGES

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

This revision was automatically updated to reflect the committed changes. hubert.reinterpretcast marked 3 inline comments as done. Closed by commit rC356843: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library (authored by hubert.reinterpretcast, committed by ). Changed prior to com

r356843 - libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

Author: hubert.reinterpretcast Date: Sat Mar 23 11:10:45 2019 New Revision: 356843 URL: http://llvm.org/viewvc/llvm-project?rev=356843&view=rev Log: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library Summary: `dladdr` is not available on AIX. Similar functionality is presented thro

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

This revision was automatically updated to reflect the committed changes. Closed by commit rC356842: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format. (authored by sylvestre, committed by ). Changed prior to commit: https://reviews.llvm.org/D58186?vs=192002&id=1920

r356842 - Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

Author: sylvestre Date: Sat Mar 23 10:57:31 2019 New Revision: 356842 URL: http://llvm.org/viewvc/llvm-project?rev=356842&view=rev Log: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h` Summary: These changes were corrected directly in ClangFormatStyleOptions.rst

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

sylvestre.ledru updated this revision to Diff 192002. sylvestre.ledru added a comment. Try again Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186 Files: include/clang/Format/Format.h include/clang/Tooling/Inclusions/In

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

sylvestre.ledru updated this revision to Diff 192001. sylvestre.ledru added a comment. Remove unrelated changes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186 Files: include/clang/Format/Format.h include/clang/Toolin

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

sylvestre.ledru updated this revision to Diff 191999. sylvestre.ledru edited the summary of this revision. sylvestre.ledru added a comment. Herald added a subscriber: jdoerfert. Svn version Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.

r356839 - Fix unused variable warning. NFCI.

Author: rksimon Date: Sat Mar 23 09:16:46 2019 New Revision: 356839 URL: http://llvm.org/viewvc/llvm-project?rev=356839&view=rev Log: Fix unused variable warning. NFCI. Modified: cfe/trunk/lib/CodeGen/CGCXX.cpp Modified: cfe/trunk/lib/CodeGen/CGCXX.cpp URL: http://llvm.org/viewvc/llvm-proje

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

This revision was automatically updated to reflect the committed changes. Closed by commit rL356835: [clang-format] Keep protobuf "package" statement on one line (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CH

r356835 - [clang-format] Keep protobuf "package" statement on one line

Author: paulhoad Date: Sat Mar 23 07:43:41 2019 New Revision: 356835 URL: http://llvm.org/viewvc/llvm-project?rev=356835&view=rev Log: [clang-format] Keep protobuf "package" statement on one line Summary: Top-level "package" and "import" statements should generally be kept on one line, for all la

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

This revision was automatically updated to reflect the committed changes. Closed by commit rL356834: Clang-format: add finer-grained options for putting all arguments on one line (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r356834 - Clang-format: add finer-grained options for putting all arguments on one line

Author: paulhoad Date: Sat Mar 23 07:37:58 2019 New Revision: 356834 URL: http://llvm.org/viewvc/llvm-project?rev=356834&view=rev Log: Clang-format: add finer-grained options for putting all arguments on one line Summary: Add two new options, AllowAllArgumentsOnNextLine and AllowAllConstructorIni

[PATCH] D59627: [clang-format] Keep protobuf "package" statement on one line

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59627/new/ https://reviews.llvm.org/D59627 __

[PATCH] D59629: [clang-format] correctly format protobuf fields named "enum".

This revision was automatically updated to reflect the committed changes. Closed by commit rL356833: [clang-format] correctly format protobuf fields named "enum". (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM C

r356833 - [clang-format] correctly format protobuf fields named "enum".

Author: paulhoad Date: Sat Mar 23 07:24:30 2019 New Revision: 356833 URL: http://llvm.org/viewvc/llvm-project?rev=356833&view=rev Log: [clang-format] correctly format protobuf fields named "enum". Summary: Similar to TypeScript, "enum" is not a reserved word. Reviewers: krasimir, MyDeveloperDay

[PATCH] D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: test/clang-tidy/run-clang-tidy.cpp:1 +// RUN: %run_clang_tidy --help // RUN: rm -rf %t Just check that python doesn't complain on the script code and imported modules. C

[PATCH] D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py

zinovy.nis updated this revision to Diff 191992. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59734/new/ https://reviews.llvm.org/D59734 Files: clang-tidy/tool/run-clang-tidy.py test/clang-tidy/run-clang-tidy.cpp Index: test/clang-tidy/run-clang-tidy.cpp ==

[PATCH] D59734: [clang-tidy] Handle missing yaml module in run-clang-tidy.py

zinovy.nis created this revision. zinovy.nis added reviewers: alexfh, bkramer, kuhar. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. The Yaml module is missing on some syste

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

takuto.ikuta added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:28 + +static std::string escapeString(const char *Src) { + std::string OS; you can pass StringRef here and remove .data() or .c_str() from caller. Comment at: ll

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus added a comment. Would you be more comfortable with this patch I didn't touch the examples folder? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 ___ cfe-commits m

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. This patch isn't intended for end users, which is why `-analyzer-checker-option-help` is a frontend flag -- besides, some of the plain frontend flags aren't either. It is purely for development purposes, though exposing an end user friendly subset of these through a d

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. In D57860#1432728 , @dcoughlin wrote: > I think it would be better if the default for compatibility mode were 'true'. > That way this change will be backwards compatible and clients who want to > enforce stricter checking could

[PATCH] D59721: [WebAssembly] Make driver -pthread imply linker --shared-memory

phosek added a comment. This broke our builders (see https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8918246038501974992/+/steps/clang/0/steps/test/0/stdout) because the test uses the default linker (lld in our case) instead of `wasm-ld`, it seems that the `clang`

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. In D54978#1433646 , @mikhail.ramalho wrote: > To fix that, I changed the script slightly: we first try to dinamically get > the Z3's version, if we fail and we are cross compiling, then we try to parse > the headers. Right now, it