[PATCH] D59185: [PowerPC] Set the default PLT mode on musl to Secure PLT

awilfox created this revision. awilfox added reviewers: nemanjai, jhibbits. Herald added subscribers: cfe-commits, jsji, kbarton. Herald added a project: clang. The musl libc only supports Secure PLT. Repository: rC Clang https://reviews.llvm.org/D59185 Files: lib/Driver/ToolChains/Arch/PP

[PATCH] D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check

hwright created this revision. hwright added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. This adds coverage for expressions of these forms absl::Duration d2, d1; d2 = absl::Seconds(d1 / absl::Seconds(1)); d2 = absl::Seconds(absl::FDiv

[PATCH] D58878: [Diagnostics] Warn for assignments in bool contexts

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6738 + "assignment to bool">, + InGroup; // Completely identical except off by default. xbolva00 wrote: > rjmccall wrote: > > Sorry, I didn't mean to suggest that you should

[PATCH] D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker

Szelethus added a comment. In D58777#1422248 , @NoQ wrote: > Very nice! Crashing diagnostic locations are a fairly common issue. That > said, this still makes me wonder what sort of checker were you writing that > triggered this originally :) Unfortuna

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus added a comment. Herald added a subscriber: whisperity. This patch no longer applies cleanly to the latest version of clang -- could you rebase please? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

bernhardmgruber updated this revision to Diff 189993. bernhardmgruber marked 8 inline comments as done. bernhardmgruber added a comment. - added support for __restrict - added two dots at end of comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56160/new/ https://reviews.llvm.org/D

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

reuk added a comment. Thanks for the review, and for approving this PR. It's very much appreciated! I don't have merge rights - could someone commit this for me please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55170/new/ https://reviews.llvm.org/D55170 _

[PATCH] D33029: [clang-format] add option for dangling parenthesis

stringham added a comment. @MyDeveloperDay I am happy to write unit tests and clean up the change set but I don't want to spend more time on this if it has no chance of being merged. I am looking for some agreement that this feature is worth adding to clang format and then I'd like to know that

r355780 - Stop relying on allocator behaviour in modules unit test

Author: dexonsmith Date: Sat Mar 9 12:15:01 2019 New Revision: 355780 URL: http://llvm.org/viewvc/llvm-project?rev=355780&view=rev Log: Stop relying on allocator behaviour in modules unit test Another fixup for r355778 for Windows bots, this time to stop accidentally relying on allocator behavio

Re: r355182 - [clang-format] [NFC] clang-format the Format library

Yes ideally I'd agree, It also says: > Avoid committing formatting- or whitespace-only changes outside of code you plan to make subsequent changes to. This was getting to be a problem, every time we edited the file (with auto-clang-format) a large number of other changes would also get made, pres

r355779 - Fix slashes in path references in -Rmodule-import test from r355778

Author: dexonsmith Date: Sat Mar 9 11:33:32 2019 New Revision: 355779 URL: http://llvm.org/viewvc/llvm-project?rev=355779&view=rev Log: Fix slashes in path references in -Rmodule-import test from r355778 Fixup for r355778 to fix all the Windows bots. Apparently I already forgot the lesson from

[PATCH] D58893: Modules: Invalidate out-of-date PCMs as they're discovered

dexonsmith closed this revision. dexonsmith marked 2 inline comments as done. dexonsmith added a comment. Committed in r355778. Comment at: clang/include/clang/Serialization/InMemoryModuleCache.h:37 /// Track the timeline of when this was added to the cache. +bool Is

r355778 - Modules: Invalidate out-of-date PCMs as they're discovered

Author: dexonsmith Date: Sat Mar 9 09:44:01 2019 New Revision: 355778 URL: http://llvm.org/viewvc/llvm-project?rev=355778&view=rev Log: Modules: Invalidate out-of-date PCMs as they're discovered Leverage the InMemoryModuleCache to invalidate a module the first time it fails to import (and to loc

[PATCH] D58890: Modules: Rename MemoryBufferCache to InMemoryModuleCache

dexonsmith closed this revision. dexonsmith added a comment. Committed in r355777. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58890/new/ https://reviews.llvm.org/D58890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

r355777 - Modules: Rename MemoryBufferCache to InMemoryModuleCache

Author: dexonsmith Date: Sat Mar 9 09:33:56 2019 New Revision: 355777 URL: http://llvm.org/viewvc/llvm-project?rev=355777&view=rev Log: Modules: Rename MemoryBufferCache to InMemoryModuleCache Change MemoryBufferCache to InMemoryModuleCache, moving it from Basic to Serialization. Another patch

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith created this revision. dexonsmith added reviewers: bruno, rsmith, vsapsai, jordan_rose. Herald added a subscriber: jdoerfert. Add an option to cache the generated PCH in the ModuleCache when emitting it. This protects clients that build PCHs and read them in the same process, allowing

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

manojgupta added a comment. In D53608#1423692 , @LuoYuanke wrote: > Hi > What's the status for __float128 support? Has it already been finished? Sorry, haven't looked at time for a while. Consider this change abandoned for now :( Repository: rCRT C

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. This review lack unit tests, please add some for FormatTest to show its use cases, otherwise someone else will come along and break this later CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm.org/D33029 ___

[PATCH] D58878: [Diagnostics] Warn for assignments in bool contexts

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6738 + "assignment to bool">, + InGroup; // Completely identical except off by default. rjmccall wrote: > Sorry, I didn't mean to

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm not the code owner but this LGTM, Assuming the unit tests remain passing, I'd like to see more items like this in clang-format addressed, at present we seem to lack getting

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

LuoYuanke added a comment. Herald added a subscriber: jdoerfert. Herald added projects: LLVM, Sanitizers. Hi What's the status for __float128 support? Has it already been finished? Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://revi

Re: [RFC 00/12] Introduce struct layout randomization feature

You probably want to submit this patchset to phabricator. It will get lost in mailing list. On Sat, Mar 9, 2019 at 1:38 AM Connor Kuehl via cfe-commits wrote: > > This patch set introduces structure field layout randomization into the Clang > compiler. The Randstruct feature is a compile-time har

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

xazax.hun accepted this revision. xazax.hun added a comment. LG! It is an interesting idea to use this facility for `trackExpressionValue`. But I would expect such a mechanism to trigger quite often. I wonder if the memory consumption would increase significantly by storing a lambda for almost