[PATCH] D58979: [clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists"

This revision was automatically updated to reflect the committed changes. Closed by commit rL355486: [clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists" (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

r355486 - [clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists"

Author: lebedevri Date: Tue Mar 5 23:45:10 2019 New Revision: 355486 URL: http://llvm.org/viewvc/llvm-project?rev=355486&view=rev Log: [clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists" Summary: This reverts rL352390 / D57280. As discussed in https://reviews.llvm.org/D5

[PATCH] D58811: [clang] Fix misuses of char width to char align

amalykh added a comment. > Could you clarify the characteristics of your target? Yeah, sure. The target supports only word addressing when it comes to loading from memory or storing to memory, that's why types shorter than 4 bytes need to be aligned by at least 4. In order to achieve this, ge

[PATCH] D58556: [LibTooling] Add "smart" retrieval of AST-node source to FixIt library

kimgr added inline comments. Comment at: clang/include/clang/Tooling/FixIt.h:73 +// context. In contrast with \p getText(), this function selects a source range +// "automatically", extracting text that a reader might intuitively associate +// with a node. Currently, only specia

r355482 - Fix slashes in path references in -Rmodule-import test from r355477

Author: dexonsmith Date: Tue Mar 5 21:42:56 2019 New Revision: 355482 URL: http://llvm.org/viewvc/llvm-project?rev=355482&view=rev Log: Fix slashes in path references in -Rmodule-import test from r355477 Fixup for r355477 to fix the Windows bot: http://lab.llvm.org:8011/builders/llvm-clang-x8

[PATCH] D58830: [ASTImporter] Import member expr with explicit template args

shafik accepted this revision. shafik added a comment. LGTM and I don't see any regressions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58830/new/ https://reviews.llvm.org/D58830 ___ cfe-commits mailing list cfe-c

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:885 +static Optional +getTypeHierarchy(const CXXRecordDecl &CXXRD, ASTContext &ASTCtx, int Levels, + TypeHierarchyDirection Direction) { -

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:365 Callback CB) { - auto Action = [Sel](decltype(CB) CB, std::string File, -std::string TweakID, -Expected

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

nridge updated this revision to Diff 189444. nridge marked 10 inline comments as done. nridge added a comment. Address most of the latest review comments. The infinite recursion issue remains to be fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

rjmccall added inline comments. Comment at: test/SemaObjC/boxing-illegal.m:70 + s = @(L"abc"); // expected-error {{illegal type 'int *' used in a boxed expression}} + s = @("\pabc"); // expected-error {{illegal type 'unsigned char *' used in a boxed expression}} +} --

[PATCH] D58891: Modules: Add -Rmodule-import

dexonsmith closed this revision. dexonsmith marked 2 inline comments as done. dexonsmith added a comment. Committed in r355477. Comment at: clang/test/Modules/Inputs/Rmodule-import/B.h:1 +// B +#include "C.h" bruno wrote: > Can you make one of the tests to use

r355477 - Modules: Add -Rmodule-import

Author: dexonsmith Date: Tue Mar 5 18:50:46 2019 New Revision: 355477 URL: http://llvm.org/viewvc/llvm-project?rev=355477&view=rev Log: Modules: Add -Rmodule-import Add a remark for importing modules. Depending on whether this is a direct import (into the TU being built by this compiler instanc

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: test/SemaObjC/boxing-illegal.m:70 + s = @(L"abc"); // expected-error {{illegal type 'int *' used in a boxed expression}} + s = @("\pabc"); // expected-error {{illegal type 'unsigned char *'

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak added inline comments. Comment at: test/SemaObjC/boxing-illegal.m:70 + s = @(L"abc"); // expected-error {{illegal type 'int *' used in a boxed expression}} + s = @("\pabc"); // expected-error {{illegal type 'unsigned char *' used in a boxed expression}} +} --

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak updated this revision to Diff 189436. ahatanak marked 2 inline comments as done. ahatanak added a comment. If the string literal used for the boxed expression isn't a valid UTF-8 string, don't emit a compile-time constant. Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

[PATCH] D58930: Add XCOFF triple object format type for AIX

hubert.reinterpretcast added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; JDevlieghere wrote: >

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

scott.linder created this revision. scott.linder added reviewers: kzhuravl, t-tye. Herald added subscribers: cfe-commits, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely. Herald added a project: clang. Reverts r337612. The issues that cropped up with the last attempt appear to have gone away.

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC355462: [Fixed Point Arithmetic] Fixed Point and Integer Conversions (authored by leonardchan, committed by ). Changed pr

r355462 - [Fixed Point Arithmetic] Fixed Point and Integer Conversions

Author: leonardchan Date: Tue Mar 5 16:28:43 2019 New Revision: 355462 URL: http://llvm.org/viewvc/llvm-project?rev=355462&view=rev Log: [Fixed Point Arithmetic] Fixed Point and Integer Conversions This patch includes the necessary code for converting between a fixed point type and integer. Thi

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 189422. leonardchan marked 11 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/OperationKinds.def clang/inc

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:45 + +short _Accum sa_const9 = 2u; // DEFAULT-DAG: @sa_const9 = {{.*}}global i16 256, align 2 +unsigned short _Accum usa_const3 = 2; bjope wrote: > Perhaps we should ver

[PATCH] D58154: Add support for -fpermissive.

rsmith added a comment. In D58154#1418594 , @jyknight wrote: > The errors disabled by this feature are default-error warnings -- you can > already get the same effect by using -Wno-. Right; the `-fpermissive` mode added by this patch turns off strictly

[PATCH] D58930: Add XCOFF triple object format type for AIX

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; jasonliu wrote: > JDevlieghere w

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:165 +case MCObjectFileInfo::IsXCOFF: + // TODO: Need to implement class MCSymbolXCOFF. + break; JDevlieghere wrote: > See previous comme

r355454 - Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux

Author: xur Date: Tue Mar 5 15:02:06 2019 New Revision: 355454 URL: http://llvm.org/viewvc/llvm-project?rev=355454&view=rev Log: Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux Removed: cfe/trunk/test/CodeGen/Inputs/pgotestir.proftext cfe/trunk/test/CodeGen/Inputs/p

[PATCH] D58922: [clang-format] broken after lambda with return type template with boolean literal

This revision was automatically updated to reflect the committed changes. Closed by commit rC355450: [clang-format] broken after lambda with return type template with boolean… (authored by paulhoad, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org

r355450 - [clang-format] broken after lambda with return type template with boolean literal

Author: paulhoad Date: Tue Mar 5 14:20:25 2019 New Revision: 355450 URL: http://llvm.org/viewvc/llvm-project?rev=355450&view=rev Log: [clang-format] broken after lambda with return type template with boolean literal Summary: A Lamdba with a return type template with a boolean literal (true,fals

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

shafik added inline comments. Comment at: lib/AST/ASTImporter.cpp:5147 } +} else { // ODR violation. + // FIXME HandleNameConflict ODR violations are ill-formed no diagnostic required. So currently will this fail for cases that clang proper would

r355445 - [docs] Add some architectures into the list of supported ThreadSanitizer platforms

Author: vitalybuka Date: Tue Mar 5 13:10:42 2019 New Revision: 355445 URL: http://llvm.org/viewvc/llvm-project?rev=355445&view=rev Log: [docs] Add some architectures into the list of supported ThreadSanitizer platforms Some platforms for which TSAN has build rules are omitted for the lack of kn

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 3 inline comments as done. jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1470 + case Triple::XCOFF: +// TODO: Falling through for XCOFF format for now. +break; JDevlieghere wrote: > This is confusing, you s

r355442 - [docs] Update the list of ThreadSanitizer supported OSes

Author: vitalybuka Date: Tue Mar 5 12:53:34 2019 New Revision: 355442 URL: http://llvm.org/viewvc/llvm-project?rev=355442&view=rev Log: [docs] Update the list of ThreadSanitizer supported OSes Modified: cfe/trunk/docs/ThreadSanitizer.rst Modified: cfe/trunk/docs/ThreadSanitizer.rst URL: ht

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked an inline comment as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

r355440 - [cmake] Add libRemarks to LLVM_DISTRIBUTION_COMPONENTS

Author: thegameg Date: Tue Mar 5 12:47:34 2019 New Revision: 355440 URL: http://llvm.org/viewvc/llvm-project?rev=355440&view=rev Log: [cmake] Add libRemarks to LLVM_DISTRIBUTION_COMPONENTS Add this in the Apple-stage2.cmake to ship the remark tooling library with the compiler. Modified: cfe

[PATCH] D58930: Add XCOFF triple object format type for AIX

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1470 + case Triple::XCOFF: +// TODO: Falling through for XCOFF format for now. +break; --

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189387. jasonliu added a comment. Address some review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/C

[PATCH] D58992: [CUDA][HIP][DebugInfo] Skip reference device function

hliao created this revision. Herald added subscribers: cfe-commits, jdoerfert, aprantl. Herald added a project: clang. - A device functions could be used as a non-type template parameter in a global/host function template. However, we should not try to retrieve that device function and reference

[PATCH] D58811: [clang] Fix misuses of char width to char align

efriedma added a comment. > The patch have been tested for a proprietary architecture, where there is a > difference between align and width of char. The C standard requires that both `alignof(char)` and `sizeof(char)` must equal 1, and therefore must equal each other. Could you clarify the

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58821/new/ https://reviews.llvm.org/D58821 ___ cfe-commits mailing list cfe-commi

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu marked 2 inline comments as done. jasonliu added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; --

[PATCH] D58934: [clang-format] Fix lambdas returning template specialization that contains operator in parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rL355434: [clang-format] Fix lambdas returning template specialization that contains… (authored by jkorous, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

r355434 - [clang-format] Fix lambdas returning template specialization that contains operator in parameter

Author: jkorous Date: Tue Mar 5 11:27:24 2019 New Revision: 355434 URL: http://llvm.org/viewvc/llvm-project?rev=355434&view=rev Log: [clang-format] Fix lambdas returning template specialization that contains operator in parameter A template specialization of a template foo can contain integer

[PATCH] D58986: Fix typo in string returned from index::getSymbolKindString for SymbolKind::ConversionFunction

nathawes created this revision. nathawes added a reviewer: akyrtzi. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. This patch updates SymbolKind::ConversionFunction's string from "coversion-func" to "conversion-func" and extends the Index/Core/index-source.cpp t

[PATCH] D58922: [clang-format] broken after lambda with return type template with boolean literal

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. In D58922#1418029 , @MyDeveloperDay wrote: > do you mean this case? as this seems to work for me? > > verifyFormat("namespace bar {\n" >

[PATCH] D58934: [clang-format] Fix lambdas returning template specialization that contains operator in parameter

jkorous added a comment. In D58934#1418043 , @MyDeveloperDay wrote: > I'm not sure I personally would ever write code like that ;-) , but if its > legal C++ and it compiles we should handle it the same as > foo<1>,foo,foo I hear you :D > As there are

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

nridge added a comment. In D58880#1418195 , @hokein wrote: > I think we can extend the existing Ref to support it, so that most of the > stuff could be reused, rather than implementing a new slab: > > - introduce a new RefKind, like BaseOf > - add a new f

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2671 DestType = Context.getPointerType(DestRecordType); FromRecordType = FromType->getPointeeType(); PointerConversions = true; And here. CHANGES SINCE LAST ACTION https://

r355432 - [PGO] Clang part of change for context-sensitive PGO (part2)

Author: xur Date: Tue Mar 5 11:09:56 2019 New Revision: 355432 URL: http://llvm.org/viewvc/llvm-project?rev=355432&view=rev Log: [PGO] Clang part of change for context-sensitive PGO (part2) Part 2 of CSPGO change in Clang: Add test cases. Differential Revision: https://reviews.llvm.org/D54176

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

shafik accepted this revision. shafik added a comment. LGTM outside of the question I had. Comment at: lib/AST/ASTImporter.cpp:4967 +template static auto getTemplateDefinition(T *D) -> T * { + auto *ToTemplatedDef = D->getTemplatedDecl()->getDefinition(); if (!ToTemplatedD

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

Anastasia updated this revision to Diff 189371. Anastasia added a comment. Use common pointer type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58708/new/ https://reviews.llvm.org/D58708 Files: lib/CodeGen/CGClass.cpp lib/Sema/SemaExpr.cpp test/CodeGenOpenCLCXX/addrspace-derive

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

rjmccall added inline comments. Comment at: lib/Sema/SemaCast.cpp:2293 + // define overlapping address spaces currently. + if (Self.getLangOpts().OpenCL) { +auto SrcType = SrcExpr.get()->getType(); Please structure this as an early exit. CHANGES SINCE LAS

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia added a comment. In D58346#1417983 , @rjmccall wrote: > In the abstract, it would be nice to warn about casts that always have UB > because the address spaces don't overlap; however, I'm worried about how > people might be using address spaces

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia updated this revision to Diff 189361. Anastasia added a comment. Updates FiXME explaining why C++ mode is more permissive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58346/new/ https://reviews.llvm.org/D58346 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/S

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2666 +? FromType->getPointeeType().getAddressSpace() +: FromType.getAddressSpace()); Please do a `getAs()` into a local and then use that h

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rC355421: [CUDA][HIP][Sema] Fix template kernel with function as template parameter (authored by yaxunl, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION ht

r355421 - [CUDA][HIP][Sema] Fix template kernel with function as template parameter

Author: yaxunl Date: Tue Mar 5 10:19:35 2019 New Revision: 355421 URL: http://llvm.org/viewvc/llvm-project?rev=355421&view=rev Log: [CUDA][HIP][Sema] Fix template kernel with function as template parameter If a kernel template has a function as its template parameter, a device function should b

[PATCH] D58060: Fix diagnostic for addr spaces in reference binding

Anastasia updated this revision to Diff 189351. Anastasia marked an inline comment as done. Anastasia added a comment. Un-commented the line in the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58060/new/ https://reviews.llvm.org/D58060 Files: include/clang/Basic/DiagnosticSemaK

[PATCH] D58060: Fix diagnostic for addr spaces in reference binding

Anastasia added inline comments. Comment at: test/SemaOpenCLCXX/address-space-references.cl:7 +// can't detect this case and therefore fails. +//int bar(const unsigned int &i); + ebevhan wrote: > Is there a reason the declaration is commented out? If it's just a

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

Anastasia added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2670 } else { DestType = DestRecordType; FromRecordType = FromType; rjmccall wrote: > This path (when the object is a gl-value) also needs an address-space > qualifier, so you

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

Anastasia updated this revision to Diff 189347. Anastasia marked an inline comment as done. Anastasia added a comment. Moved adding address space to `DestType` earlier to cover pointer and non-pointer case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58708/new/ https://reviews.llvm.

[PATCH] D58979: [clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists"

gribozavr accepted this revision. gribozavr added a comment. > Hmm, do we really need the matches for the AST node that is not > described/defined by the standard? If this is really so, I'm ok with this. When the rubber meets the road, it does not matter what is in the spec, users will need to

[PATCH] D58057: Allow bundle size to be 0 in clang-offload-bundler

This revision was automatically updated to reflect the committed changes. Closed by commit rC355419: Allow bundle size to be 0 in clang-offload-bundler (authored by yaxunl, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

r355419 - Allow bundle size to be 0 in clang-offload-bundler

Author: yaxunl Date: Tue Mar 5 09:52:32 2019 New Revision: 355419 URL: http://llvm.org/viewvc/llvm-project?rev=355419&view=rev Log: Allow bundle size to be 0 in clang-offload-bundler HIP uses clang-offload-bundler to create fat binary. The bundle for host is empty. Currently clang-offload-bundl

r355418 - [OPENMP]Target region: emit const firstprivates as globals with constant

Author: abataev Date: Tue Mar 5 09:47:18 2019 New Revision: 355418 URL: http://llvm.org/viewvc/llvm-project?rev=355418&view=rev Log: [OPENMP]Target region: emit const firstprivates as globals with constant memory. If the variable with the constant non-scalar type is firstprivatized in the target

[PATCH] D58979: [clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists"

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. Hmm, do we really need the matches for the AST node that is not described/defined by the standard? If this is really so, I'm ok with this. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58979: [clang][OpenMP] Revert "OMPFlushClause is synthetic, no such clause exists"

lebedev.ri created this revision. lebedev.ri added reviewers: gribozavr, ABataev, rjmccall, aaron.ballman. lebedev.ri added a project: clang. Herald added subscribers: jdoerfert, arphaman, guansong, dylanmckay. This reverts rL352390 / D57280

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

aemerson added a comment. In D58320#1418477 , @peter.smith wrote: > I've no objections to adding the command line as a Darwin only option. > Implementation looks fine to me although I've not got any prior experience > with Darwin. Thanks, @ab ok for Da

[PATCH] D35169: Refactor DragonFly BSD toolchain driver.

rimvydas added inline comments. Comment at: lib/Driver/ToolChains/DragonFly.cpp:118 } - CmdArgs.push_back(Args.MakeArgString(getToolChain().GetFilePath("crti.o"))); -if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_pie)) - CmdArgs.push_back( -

[PATCH] D58154: Add support for -fpermissive.

jyknight added a comment. The errors disabled by this feature are default-error warnings -- you can already get the same effect by using -Wno-. Why is it bad to additionally allow -fpermissive to disable them? (If we have any diagnostics which are currently default-on-warnings which should not

[PATCH] D58977: [clang-tidy] Add the abseil-time-comparison check

hwright created this revision. hwright added reviewers: hokein, ioeric. Herald added subscribers: cfe-commits, jdoerfert, xazax.hun, mgorny. Herald added a project: clang. This is an analog of the `abseil-duration-comparison` check, but for the `absl::Time` domain. It has a similar implementatio

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This test file will probably grow over time, so please add a CHECK-LABEL line to the test case to make sure you're checking the body of foo(). Also, you'll probably need to allow the name

[PATCH] D58556: [LibTooling] Add "smart" retrieval of AST-node source to FixIt library

ymandel marked 5 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/FixIt.h:73 +// context. In contrast with \p getText(), this function selects a source range +// "automatically", extracting text that a reader might intuitively associ

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

peter.smith added a comment. I've no objections to adding the command line as a Darwin only option. Implementation looks fine to me although I've not got any prior experience with Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58320/new/ h

[PATCH] D58917: [HIP] Do not unbundle object files for -fno-gpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rL355410: [HIP] Do not unbundle object files for -fno-gpu-rdc (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r355410 - [HIP] Do not unbundle object files for -fno-gpu-rdc

Author: yaxunl Date: Tue Mar 5 08:07:56 2019 New Revision: 355410 URL: http://llvm.org/viewvc/llvm-project?rev=355410&view=rev Log: [HIP] Do not unbundle object files for -fno-gpu-rdc When -fno-gpu-rdc is set, device code is compiled, linked, and assembled into fat binary and embedded as string

[PATCH] D58966: [libc++] Fix failures on GCC

ldionne created this revision. ldionne added a reviewer: EricWF. Herald added a reviewer: jfb. Herald added subscribers: cfe-commits, jdoerfert, jfb, dexonsmith, jkorous, christof. Herald added a project: clang. In https://reviews.llvm.org/D58201, we turned memory_order into an enum class in C++2

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

hans updated this revision to Diff 189319. hans added a comment. Extract code to a new method in APValue. Eli, what do you think about something like this? Suggestions for better name welcome :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58821/new/ https://reviews.llvm.org/D58821

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

hans marked 2 inline comments as done. hans added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:1852 +IntResult = +llvm::APSInt::get(EVResult.Val.getLValueOffset().getQuantity()); + else efriedma wrote: > hans wrote: > > efrie

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman updated this revision to Diff 189318. dgoldman added a comment. - Fix broken test by last change Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 Files: lib/AST/DeclPrinter.cpp test/AST/ast-print-objc-property

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman updated this revision to Diff 189317. dgoldman added a comment. - Add more tests and improved printing of pointers Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 Files: lib/AST/DeclPrinter.cpp test/AST/ast-p

r355368 - Replace clang::FileData with llvm::vfs::Status

Author: harlanhaskins Date: Mon Mar 4 18:27:12 2019 New Revision: 355368 URL: http://llvm.org/viewvc/llvm-project?rev=355368&view=rev Log: Replace clang::FileData with llvm::vfs::Status Summary: FileData was only ever used as a container for the values in llvm::vfs::Status, so they might as well

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL355340: [build] Rename clang-headers to clang-resource-headers (authored by smeenai, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D58791?vs=189

[PATCH] D58057: Allow bundle size to be 0 in clang-offload-bundler

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58057/new/ https://reviews.llvm.org/D58057 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D58154: Add support for -fpermissive.

aaron.ballman added a comment. In D58154#1417474 , @rsmith wrote: > In D58154#1417363 , @aaron.ballman > wrote: > > > I'm not super keen on supporting -fpermissive -- what is the impetus for > > supporting this?

[PATCH] D58917: [HIP] Do not unbundle object files for -fno-gpu-rdc

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Driver/Driver.cpp:2298 +/// Flag for -fgpu-rdc. +bool Relocatable; public: ABataev wrote: > Set the default initializer for the field will do. thanks. Repository:

[PATCH] D58057: Allow bundle size to be 0 in clang-offload-bundler

yaxunl added a comment. Alexey, could you please also review this patch? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58057/new/ https://reviews.llvm.org/D58057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

Anastasia updated this revision to Diff 189313. Anastasia added a comment. - Implement the fix correctly by added an extra address space conversion step after binding the reference CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58634/new/ https://reviews.llvm.org/D58634 Files: includ

[PATCH] D58060: Fix diagnostic for addr spaces in reference binding

ebevhan added inline comments. Comment at: test/SemaOpenCLCXX/address-space-references.cl:7 +// can't detect this case and therefore fails. +//int bar(const unsigned int &i); + Is there a reason the declaration is commented out? If it's just a problem with the r

[PATCH] D58917: [HIP] Do not unbundle object files for -fno-gpu-rdc

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/Driver/Driver.cpp:2298 +/// Flag for -fgpu-rdc. +bool Relocatable; public: Set the default initializer for the fie

[clang-tools-extra] r355401 - [clang-tidy] Fix bugprone-string-constructor crash

Author: alexfh Date: Tue Mar 5 06:09:57 2019 New Revision: 355401 URL: http://llvm.org/viewvc/llvm-project?rev=355401&view=rev Log: [clang-tidy] Fix bugprone-string-constructor crash Modified: clang-tools-extra/trunk/clang-tidy/bugprone/StringConstructorCheck.cpp clang-tools-extra/trunk/

[PATCH] D58930: Add XCOFF triple object format type for AIX

apaprocki added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; No need to be `sorry:` :) This shou

[PATCH] D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)

joerg added a comment. Well, that was a sample to illustrate the point. A full working (and now failing) example is: static inline void outl(unsigned port, unsigned data) { if (__builtin_constant_p(port) && port < 0x100) { __asm volatile("outl %0,%w1" : : "a"(data), "n"(port)); }

[PATCH] D58060: Fix diagnostic for addr spaces in reference binding

Anastasia updated this revision to Diff 189306. Anastasia retitled this revision from "Fix diagnostic for addr spaces in static_cast" to "Fix diagnostic for addr spaces in reference binding". Anastasia edited the summary of this revision. Anastasia added a comment. - Fixed incorrect diagnostic in

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

lebedev.ri added a comment. In D58894#1418251 , @djtodoro wrote: > @lebedev.ri I agree, thank you! I needed to be more precise in my previous > reply, sorry for that. I thought it will be (somehow) overhead if I change > existing, very basic, matchers.

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

djtodoro added a comment. @lebedev.ri I agree, thank you! I needed to be more precise in my previous reply, sorry for that. I thought it will be (somehow) overhead if I change existing, very basic, matchers. I already implemented a static function that skips comma operands, and extended this t

[PATCH] D58828: [analyzer] Fix taint propagation in GenericTaintChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC355396: [analyzer] Fix taint propagation in GenericTaintChecker (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58828/new/ https://re

r355396 - [analyzer] Fix taint propagation in GenericTaintChecker

Author: szelethus Date: Tue Mar 5 04:42:59 2019 New Revision: 355396 URL: http://llvm.org/viewvc/llvm-project?rev=355396&view=rev Log: [analyzer] Fix taint propagation in GenericTaintChecker The gets function has no SrcArgs. Because the default value for isTainted was false, it didn't mark its D

r355395 - [ASTMatchers] Improved formatting in a documentation comment

Author: gribozavr Date: Tue Mar 5 04:38:18 2019 New Revision: 355395 URL: http://llvm.org/viewvc/llvm-project?rev=355395&view=rev Log: [ASTMatchers] Improved formatting in a documentation comment Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h Modified: cfe/trunk/include

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

lebedev.ri added a comment. In D58894#1416691 , @djtodoro wrote: > @lebedev.ri Thanks for your comment! > > > Is there any way to model this more generically? > > I.e don't duplicate every naive matcher (ignoring possible presence of , > > op) with an var

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

hokein added a comment. Haven't looked at the patch. I think we can extend the existing Ref to support it, so that most of the stuff could be reused, rather than implementing a new slab: - introduce a new RefKind, like BaseOf - add a new field SymbolID in Ref and `clangIndex` library has alrea

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

This revision was automatically updated to reflect the committed changes. Closed by commit rL355390: [ASTImporter] Fix redecl failures of Class and ClassTemplate (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHA

  1   2   >