[PATCH] D55250: [clangd] Enhance macro hover to see full definition

This revision was automatically updated to reflect the committed changes. Closed by commit rL354761: [clangd] Enhance macro hover to see full definition (authored by malaperle, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[clang-tools-extra] r354761 - [clangd] Enhance macro hover to see full definition

Author: malaperle Date: Sun Feb 24 15:47:03 2019 New Revision: 354761 URL: http://llvm.org/viewvc/llvm-project?rev=354761&view=rev Log: [clangd] Enhance macro hover to see full definition Summary: Signed-off-by: Marc-Andre Laperle Reviewers: simark, ilya-biryukov, sammccall, ioeric, hokein Rev

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

a_sidorin added a comment. Hi Gabor, The patch looks OK overall but I have some comments inline. Comment at: lib/AST/ASTImporter.cpp:4966 // it has any definition in the redecl chain. -static ClassTemplateDecl *getDefinition(ClassTemplateDecl *D) { - CXXRecordDecl *ToTemplate

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, I don't see any problems with the patch. Thanks! I think it will be good to get Shafik's approval as well. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. This will make life much more easier now with this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58592/new/ https://reviews.llvm.org/D58592 __

r354752 - Fix accidentally used hard tabs. NFC

Author: kristina Date: Sun Feb 24 10:06:10 2019 New Revision: 354752 URL: http://llvm.org/viewvc/llvm-project?rev=354752&view=rev Log: Fix accidentally used hard tabs. NFC Big sorry. This undoes the indentation mess I made in r354751. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified:

Re: [PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

Hey David Thanks for letting me know, and analysing it this far! I also can't see anything wrong with the intrinsic. Its just defined as: def int_objc_autoreleasePoolPop : Intrinsic<[], [llvm_ptr_ty]>; which (I believe) means it has unmodelled side effects so it should have been f

r354751 - Wrap code for builtin_assume_aligned at 80 col.NFC

Author: kristina Date: Sun Feb 24 09:57:33 2019 New Revision: 354751 URL: http://llvm.org/viewvc/llvm-project?rev=354751&view=rev Log: Wrap code for builtin_assume_aligned at 80 col.NFC Minor style fix to avoid going over 80 cols in handling of case for Builtin::BI__builtin_assume_aligned. NFC.

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny updated this revision to Diff 188083. mgorny added a comment. Shamelessly increased overhead by checking one more path as requested by Kamil. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58592/new/ https://reviews.llvm.org/D58592 Files: clang/lib/Driver/ToolChains/NetBSD.cpp

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

joerg added a comment. I'm not in favor of this. It adds overhead for the system compiler and generally makes the logic more complicated. This seems to be another hack around the fact that the driver has no clear notion of "use system runtime" vs "use custom runtime". Repository: rC Clang

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

krytarowski added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; mgorny wrote: > krytarowski wrote: > > mgorny wrote: > > > krytarowski wrote: > > > > I

[PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

theraven added a comment. Herald added a project: LLVM. After some bisection, it appears that this is the revision that introduced the regression in the GNUstep Objective-C runtime test suite that I reported on the list a few weeks ago. In this is the test (compiled with `-fobjc-runtime=gnuste

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; krytarowski wrote: > mgorny wrote: > > krytarowski w

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

krytarowski added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; mgorny wrote: > krytarowski wrote: > > I propose to go for: > > > > `getDriver().SysRoo

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; krytarowski wrote: > I propose to go for: > > `getD

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

krytarowski added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; I propose to go for: `getDriver().SysRoot + "/usr/include/c++/v1",` with a fallback for

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, chandlerc, eugenis. Herald added a reviewer: EricWF. Herald added a project: clang. Support locating the libc++ header files relatively to the clang executable, in addition to the default system path. This is meant to cover