r354742 - Typo: s/CHCCK/CHECK

Author: hliao Date: Sat Feb 23 19:10:14 2019 New Revision: 354742 URL: http://llvm.org/viewvc/llvm-project?rev=354742&view=rev Log: Typo: s/CHCCK/CHECK Modified: cfe/trunk/test/CodeGenCXX/pragma-loop-safety.cpp Modified: cfe/trunk/test/CodeGenCXX/pragma-loop-safety.cpp URL: http://llvm.org/

r354741 - [NFC] Minor coding style (indent) fix.

Author: hliao Date: Sat Feb 23 19:07:32 2019 New Revision: 354741 URL: http://llvm.org/viewvc/llvm-project?rev=354741&view=rev Log: [NFC] Minor coding style (indent) fix. Modified: cfe/trunk/lib/AST/Type.cpp Modified: cfe/trunk/lib/AST/Type.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/t

[PATCH] D58586: Clear TimerGroup to avoid redundant profile results

tk1012 created this revision. tk1012 added a project: clang. Herald added a subscriber: cfe-commits. This patch clears out all timers just after printing all timers. Repository: rC Clang https://reviews.llvm.org/D58586 Files: clang/tools/driver/cc1_main.cpp clang/tools/driver/cc1as_main.

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

akyrtzi added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } mgorny wrote: > akyrtzi wrote: > > mgorny wrote: > > > akyrtzi

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } akyrtzi wrote: > mgorny wrote: > > akyrtzi wrote: > > > mgorny

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

akyrtzi added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } mgorny wrote: > akyrtzi wrote: > > mgorny wrote: > > > akyrtzi

r354735 - [cxx_status] Update to match Kona motions.

Author: rsmith Date: Sat Feb 23 13:06:25 2019 New Revision: 354735 URL: http://llvm.org/viewvc/llvm-project?rev=354735&view=rev Log: [cxx_status] Update to match Kona motions. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL: http://llvm.org/viewvc/llvm-pr

r354736 - Enable coroutines under -std=c++2a.

Author: rsmith Date: Sat Feb 23 13:06:26 2019 New Revision: 354736 URL: http://llvm.org/viewvc/llvm-project?rev=354736&view=rev Log: Enable coroutines under -std=c++2a. Modified: cfe/trunk/include/clang/Basic/LangOptions.def cfe/trunk/include/clang/Basic/TokenKinds.def cfe/trunk/lib/B

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } akyrtzi wrote: > mgorny wrote: > > akyrtzi wrote: > > > mgorny

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

akyrtzi added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } mgorny wrote: > akyrtzi wrote: > > mgorny wrote: > > > jkorous

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } akyrtzi wrote: > mgorny wrote: > > jkorous wrote: > > > mgorny

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

akyrtzi added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } mgorny wrote: > jkorous wrote: > > mgorny wrote: > > > Why? I

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::VisitChooseExpr(ChooseExpr *E) { + auto Imp = importSeq(E->getCond(), E->getLHS(), E->getRHS(), + E->getBuiltinLoc(), E->getRParenLoc(), E->getType(

r354728 - [NFC] Fix Wdocumentation warning in OMPToClause

Author: brunoricci Date: Sat Feb 23 08:40:30 2019 New Revision: 354728 URL: http://llvm.org/viewvc/llvm-project?rev=354728&view=rev Log: [NFC] Fix Wdocumentation warning in OMPToClause Modified: cfe/trunk/include/clang/AST/OpenMPClause.h Modified: cfe/trunk/include/clang/AST/OpenMPClause.h

r354727 - [Sema][NFC] SequenceChecker: More tests in preparation for D57660

Author: brunoricci Date: Sat Feb 23 08:25:00 2019 New Revision: 354727 URL: http://llvm.org/viewvc/llvm-project?rev=354727&view=rev Log: [Sema][NFC] SequenceChecker: More tests in preparation for D57660 Modified: cfe/trunk/test/SemaCXX/warn-unsequenced.cpp Modified: cfe/trunk/test/SemaCXX/w

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

riccibruno added a comment. > I'm not quite sure what this differential is about, but i feel like > mentioning ExprMutationAnalyzer lib in clang-tidy / clang-tools-extra. Alternatively perhaps you could re-use `getMemoryLocation()` from D57660 . It would handle

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expression.

riccibruno created this revision. riccibruno added reviewers: rsmith, aaron.ballman, Rakete. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. In C++17 the postfix-expression of a call expression is sequenced before each expression in the expression-list and any defau

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

riccibruno updated this revision to Diff 188048. riccibruno added a comment. Rebased. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/new/ https://reviews.llvm.org/D57659 Files: lib/Sema/SemaChecking.cpp Index: lib/Sema/SemaChecking.cpp ==

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam updated this revision to Diff 188047. zahiraam marked 2 inline comments as done. Herald added subscribers: jdoerfert, jfb, mgrang, srhines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: lib/Sema/SemaDecl.cpp mypatch.patch t

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam added a comment. Let's see if I have included every thing mentioned. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

riccibruno updated this revision to Diff 188046. riccibruno added a comment. Rebased on D57660 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58297/new/ https://reviews.llvm.org/D58297 Files: lib/Sema/Se

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 188045. riccibruno added a comment. Rebased on D57660 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D57747 Files: lib/Sema/Se

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

JonasToth added inline comments. Comment at: clang-tidy/abseil/TimeSubtractionCheck.cpp:97 +void TimeSubtractionCheck::check(const MatchFinder::MatchResult &Result) { + const auto *BinOp = Result.Nodes.getNodeAs("binop"); + std::string inverse_name = hwright wr

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 188043. riccibruno retitled this revision from "[Sema] SequenceChecker: Handle references and members" to "[Sema] SequenceChecker: Handle references, members and structured bindings.". riccibruno edited the summary of this revision. Repository: rC Clang

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

Szelethus accepted this revision. Szelethus added a comment. But, as a work-in-progress alpha checker, the direction is set and looks great. Please let @NoQ have the final say. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50488/new/ https://reviews.llvm.org/D50488 _

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

Szelethus created this revision. Szelethus added reviewers: dcoughlin, NoQ, xazax.hun, rnkovacs, whisperity, a.sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, szepet, baloghadamsoftware. I've tested the checker on

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Tom, Thanks for the fixes! The patch looks good to me now. I have only a small nit inline. Comment at: lib/AST/ASTImporter.cpp:6140 +ExpectedStmt ASTNodeImporter::V