[PATCH] D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type

This revision was automatically updated to reflect the committed changes. Closed by commit rC349444: [ExprConstant] Handle compound assignment when LHS has integral type and RHS… (authored by cpplearner, committed by ). Changed prior to commit: https://reviews.llvm.org/D55413?vs=178242&id=17859

r349444 - [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type

Author: cpplearner Date: Mon Dec 17 23:38:06 2018 New Revision: 349444 URL: http://llvm.org/viewvc/llvm-project?rev=349444&view=rev Log: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type Fixes PR39858 Differential Revision: https://reviews.llvm

[PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

pete added a comment. In D55802#1334008 , @rjmccall wrote: > You're making intrinsics with `weak_external` linkage? I feel like that's > going to be unnecessarily awkward in the future, but okay. Yeah... i was a little surprised that was possible, but

[PATCH] D55802: Change CGObjC to use objc intrinsics instead of runtime methods

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. You're making intrinsics with `weak_external` linkage? I feel like that's going to be unnecessarily awkward in the future, but okay. Repository: rC Clang CHANGES SINCE LAST ACTION h

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

rjmccall added inline comments. Comment at: clang/test/CodeGenObjCXX/inheriting-constructor-cleanup.mm:10 + // Use variadic args to force inlining the inherited constructor. + Base(const Strong &s, ...) {} +}; To test what I'd like to see, this needs to take `S

r349442 - Automatic variable initialization

Author: jfb Date: Mon Dec 17 21:12:21 2018 New Revision: 349442 URL: http://llvm.org/viewvc/llvm-project?rev=349442&view=rev Log: Automatic variable initialization Summary: Add an option to initialize automatic variables with either a pattern or with zeroes. The default is still that automatic va

[PATCH] D54604: Automatic variable initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL349442: Automatic variable initialization (authored by jfb, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54604?vs=178566&id=178590#toc Rep

[PATCH] D55616: Emit ASM input in a constant context

void updated this revision to Diff 178582. void added a comment. Reduce duplication by using multiple check prefixes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55616/new/ https://reviews.llvm.org/D55616 Files: lib/Basic/TargetInfo.cpp lib/CodeGen/CGStmt.

[PATCH] D55771: [AST] Store the callee and argument expressions of CallExpr in a trailing array.

rjmccall added a comment. I agree with not packing the argument count in. Comment at: include/clang/AST/Stmt.h:439 +/// trailing objects belonging to CallExpr. +unsigned OffsetToTrailingObjects : 6; }; If we're not packing anything into these bits an

[PATCH] D55781: Make CC mangling conditional on the ABI version

rjmccall added a reviewer: probinson. rjmccall added a comment. I think the core question is whether there are any vendors who care about ABI stability for these attributes who don't care about the bugfix. Speaking for Apple, we would rather have the bugfix. Sony might have different thoughts;

[PATCH] D55804: [analyzer] C++17: Fix leak false positives when an object with destructor is returned from the top frame.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, rnkovacs, Szelethus, mikhail.ramalho, baloghadamsoftware. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. The `return_from_top_frame` test demonstrates what happens. Th

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/DuplicatedAccessSpecifiersCheck.cpp:36 + NS != NSEnd; ++NS) { +const auto *decl = *NS; + Type is not obvious here, so please don't use auto. CHANGES SINCE LAST ACTION https://r

[PATCH] D55765: Fix use-after-free bug in Tooling.

alexfh added inline comments. Comment at: include/clang/Tooling/Tooling.h:208 std::unique_ptr -buildASTFromCode(const Twine &Code, const Twine &FileName = "input.cc", +buildASTFromCode(StringRef Code, const Twine &FileName = "input.cc", std::shared_ptr PCHConta

[PATCH] D55616: Emit ASM input in a constant context

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with a minor nit, but give a couple days for @jyknight to add any more comments. Comment at: test/CodeGen/builtin-constant-p.c:2 +// RUN: %clang_cc1 -triple x86_64-

[PATCH] D54604: Automatic variable initialization

jfb updated this revision to Diff 178566. jfb added a comment. - Update attribute test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54604/new/ https://reviews.llvm.org/D54604 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clan

[PATCH] D54604: Automatic variable initialization

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/CodeGenCXX/trivial-auto-var-init-attribute.cpp:13 +void test_attribute_uninitialized() { + [[clang::trivial_auto_init("uninitialized")]] int i; + used(i); -

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai updated this revision to Diff 178563. vsapsai added a comment. - Test order of destroying parameters to inlined inherited constructor. - [ObjC++] Add test using struct with `__strong` field as a parameter for inlined inherited constructor. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added a comment. In D54862#1333700 , @ebevhan wrote: > I'm also a bit confused about the semantics that this patch is applying to > function types. It mostly seems to concern the extra trailing Qualifiers on > CXXMethodDecl to store the addrspac

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

riccibruno added a comment. In D55793#1333691 , @m4tx wrote: > Don't use `CXXRecordDecl::accessSpecs()`, use unique comments in tests. Thanks! `CXXRecordDecl` is already huge and so adding iterators for a single checker is in my opinion not a good idea

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

ebevhan added a comment. I'm also a bit confused about the semantics that this patch is applying to function types. It mostly seems to concern the extra trailing Qualifiers on CXXMethodDecl to store the addrspace quals, but in some places (SemaType:4842, SemaDecl:3198) it seems to be applying t

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx updated this revision to Diff 178543. m4tx added a comment. Don't use `CXXRecordDecl::accessSpecs()`, use unique comments in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/

r349415 - Fix ms-layout_version declspec test and add missing new test

Author: rnk Date: Mon Dec 17 15:16:43 2018 New Revision: 349415 URL: http://llvm.org/viewvc/llvm-project?rev=349415&view=rev Log: Fix ms-layout_version declspec test and add missing new test Now that MSVC compatibility versions are stored as a four digit number (1912) instead of a two digit numbe

[PATCH] D55685: Update Microsoft name mangling scheme for exception specifiers in the type system

This revision was automatically updated to reflect the committed changes. Closed by commit rL349414: Update Microsoft name mangling scheme for exception specifiers in the type… (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

r349414 - Update Microsoft name mangling scheme for exception specifiers in the type system

Author: rnk Date: Mon Dec 17 15:10:43 2018 New Revision: 349414 URL: http://llvm.org/viewvc/llvm-project?rev=349414&view=rev Log: Update Microsoft name mangling scheme for exception specifiers in the type system Summary: The msvc exception specifier for noexcept function types has changed from t

[PATCH] D55616: Emit ASM input in a constant context

void marked an inline comment as done. void added inline comments. Comment at: test/CodeGen/builtin-constant-p.c:2 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - %s -O2 | FileCheck --check-prefix=O2 %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-

[PATCH] D55790: [AST] Add accessSpecs() iterator range for CXXRecordDecl

m4tx added a comment. In D55790#1333627 , @riccibruno wrote: > Do you really have to add an iterator for this particular thing ? > Why not just use `specific_decl_iterator` in your clang-tidy > checker ? I don't need to - if this is the preferred way t

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

lebedev.ri added a comment. Please add tests with preprocessor (`#if ...`) that will show that it ignores disabled code. e.g.: class ProbablyValid { private: int a; #if defined(ZZ) public: int b; #endif private: int c; protected: int d; public: int e; }; C

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

m4tx updated this revision to Diff 178539. m4tx added a comment. Use alphabetical order in ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55793/new/ https://reviews.llvm.org/D55793 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/DuplicatedAccessS

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

Eugene.Zelenko added a comment. Please close PR25403 after commit. Comment at: docs/ReleaseNotes.rst:70 +- New :doc:`readability-duplicated-access-specifiers + ` check. Please use alphabetical order for new checks. Repository: rCTE Clang Tools Extra CHA

[PATCH] D55790: [AST] Add accessSpecs() iterator range for CXXRecordDecl

riccibruno added a comment. Do you really have to add an iterator for this particular thing ? Why not just use `specific_decl_iterator` in you clang-tidy checker ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55790/new/ https://reviews.llvm.org/D55790 __

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

boga95 updated this revision to Diff 178537. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index: lib/StaticAnalyzer/Checkers/GenericTaintChec

[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check

m4tx created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. This finds redundant access specifier declarations inside classes, structs, and unions. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D55793 Files: clang-tidy/readability/CMakeLists.txt c

[PATCH] D55790: [AST] Add accessSpecs() iterator range for CXXRecordDecl

m4tx created this revision. Herald added a subscriber: cfe-commits. Adds an iterator that allows to loop over C++ class/union/struct access specifier declarations. Repository: rC Clang https://reviews.llvm.org/D55790 Files: include/clang/AST/DeclCXX.h Index: include/clang/AST/DeclCXX.h

[PATCH] D55566: [analyzer] LiveVariables: Fix a zombie expression problem, add testing infrastructure.

dcoughlin added a comment. This looks good to me. It is great to see a dumper for this! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55566/new/ https://reviews.llvm.org/D55566 ___ cfe-commits mailing list cfe-commits

[PATCH] D55671: [analyzer] Don't pretend that unknown block calls have one null parameter.

dcoughlin added a comment. Looks good to me! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55671/new/ https://reviews.llvm.org/D55671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D55616: Emit ASM input in a constant context

efriedma added inline comments. Comment at: test/CodeGen/builtin-constant-p.c:2 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - %s -O2 | FileCheck --check-prefix=O2 %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - %s -O0 | FileCheck --che

r349394 - [analyzer] MoveChecker: Squash the bit field because it causes a GCC warning.

Author: dergachev Date: Mon Dec 17 13:07:38 2018 New Revision: 349394 URL: http://llvm.org/viewvc/llvm-project?rev=349394&view=rev Log: [analyzer] MoveChecker: Squash the bit field because it causes a GCC warning. The warning seems spurious (GCC bug 51242), but the bit field is simply not worth t

[PATCH] D55616: Emit ASM input in a constant context

void added a comment. Ping? :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55616/new/ https://reviews.llvm.org/D55616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D55685: Update Microsoft name mangling scheme for exception specifiers in the type system

zahen added a comment. I don't have check-in permission, so I'd appreciate if someone could handle the actual commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55685/new/ https://reviews.llvm.org/D55685 ___ cfe-commits mailing list cfe

r349393 - Make test/Driver/darwin-sdk-version.c pass on hosts < macOS10.14

Author: arphaman Date: Mon Dec 17 13:01:04 2018 New Revision: 349393 URL: http://llvm.org/viewvc/llvm-project?rev=349393&view=rev Log: Make test/Driver/darwin-sdk-version.c pass on hosts < macOS10.14 The test test/Driver/darwin-sdk-version.c from r349380 checks if the macOS deployment target can

[PATCH] D55685: Update Microsoft name mangling scheme for exception specifiers in the type system

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55685/new/ https://reviews.llvm.org/D55685 ___ cfe-commits mailing list cfe-commit

[PATCH] D55749: [Driver] Automatically enable -munwind-tables if -fseh-exceptions is enabled

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55749/new/ https://reviews.llvm.org/D55749 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin added a comment. Ok, So thank you for the suggestions. I will implement that way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55710/new/ https://reviews.llvm.org/D55710 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

r349388 - Fix build after r349380

Author: arphaman Date: Mon Dec 17 12:25:41 2018 New Revision: 349388 URL: http://llvm.org/viewvc/llvm-project?rev=349388&view=rev Log: Fix build after r349380 Modified: cfe/trunk/include/clang/Basic/TargetOptions.h Modified: cfe/trunk/include/clang/Basic/TargetOptions.h URL: http://llvm.org

[PATCH] D55749: [Driver] Automatically enable -munwind-tables if -fseh-exceptions is enabled

mstorsjo updated this revision to Diff 178513. mstorsjo marked an inline comment as done. mstorsjo added a comment. Moved the added code to `toolchains::MinGW::IsUnwindTablesDefault`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55749/new/ https://reviews.llvm.org/D55749 Files: lib/

[PATCH] D55749: [Driver] Automatically enable -munwind-tables if -fseh-exceptions is enabled

mstorsjo marked 2 inline comments as done. mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3929 + options::OPT_fno_asynchronous_unwind_tables, + (TC.IsUnwindTablesDefault(Args) || + (ExceptionArg && rnk wrote: > Can you

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:77 + if (MD) +RecTy = Context.getAddrSpaceQualType(RecTy, MD->getType().getAddressSpace()); return Context.getPointerType(CanQualType::CreateUnsafe(RecTy)); ebevhan wrote: > I'm a bit lat

[PATCH] D55656: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/AST/ASTContext.cpp:2781 + + return getAddrSpaceQualType(NewT, Orig.getAddressSpace()); } Anastasia wrote: > rjmccall wrote: > > You're trying to handle a method qualifier, not a type a functions that are > > them

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added a comment. In D53738#1333276 , @leonardchan wrote: > In D53738#1326071 , @rjmccall wrote: > > > I'm fine with making this change under the assumption that we've gotten the > > language rule right. E

r349384 - [NFC] Test commit: tweak whitespace in comment

Author: cpplearner Date: Mon Dec 17 11:53:22 2018 New Revision: 349384 URL: http://llvm.org/viewvc/llvm-project?rev=349384&view=rev Log: [NFC] Test commit: tweak whitespace in comment Modified: cfe/trunk/test/CXX/temp/temp.param/p3.cpp Modified: cfe/trunk/test/CXX/temp/temp.param/p3.cpp URL:

[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

rjmccall added a comment. Do you have an example, and is there a reasonable place to call `CheckPlaceholderExpr` on those paths? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55662/new/ https://reviews.llvm.org/D55662 _

[PATCH] D55765: Fix use-after-free bug in Tooling.

ymandel updated this revision to Diff 178507. ymandel added a comment. Update test that was calling builAST with an actual Twine. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55765/new/ https://reviews.llvm.org/D55765 Files: include/clang/Tooling/Tooling.h

[PATCH] D55781: Make CC mangling conditional on the ABI version

rnk added a comment. @rsmith asked if we should make this mangling conditional on the ABI version. I implemented it here, let me know if you think it's worth the extra code complexity. Our mingw ABI hasn't been particularly stable, but I think going forward we'll want to start mangling new call

[PATCH] D35783: Ignore shadowing for declarations coming from within macros.

rsmith added a comment. I think the ideal solution would be something like: If a variable produced by a macro expansion shadows a variable not produced by a macro expansion, do not warn immediately. Instead, warn if we see a use of the inner variable in a context that is not produced by the sam

Re: r349212 - Mangle calling conventions into function pointer types where GCC does

I sent https://reviews.llvm.org/D55781 and cc'd the original reviewers so we can decide if it's worth the cost. On Fri, Dec 14, 2018 at 5:17 PM Richard Smith wrote: > Should this change be disableable by -fclang-abi-compat=7 or below? > > On Fri, 14 Dec 2018, 15:46 Reid Kleckner via cfe-commits

[PATCH] D55781: Make CC mangling conditional on the ABI version

rnk created this revision. rnk added reviewers: rjmccall, rsmith. Herald added a subscriber: krytarowski. https://reviews.llvm.org/D55781 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/CodeGenCXX/mangle-win-ccs-old.cpp Index: clang/test/CodeGenCXX/mangle-win-ccs-old.cpp ==

r349382 - [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch`

Author: arphaman Date: Mon Dec 17 11:30:46 2018 New Revision: 349382 URL: http://llvm.org/viewvc/llvm-project?rev=349382&view=rev Log: [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch` is not specified The -target option allows the user to specify the build target using LLVM trip

[PATCH] D55731: [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch` is not specified

This revision was automatically updated to reflect the committed changes. Closed by commit rC349382: [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch` (authored by arphaman, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55731/new/

r349381 - [Driver] Don't override '-march' when using '-arch x86_64h'

Author: thegameg Date: Mon Dec 17 11:29:27 2018 New Revision: 349381 URL: http://llvm.org/viewvc/llvm-project?rev=349381&view=rev Log: [Driver] Don't override '-march' when using '-arch x86_64h' On Darwin, using '-arch x86_64h' would always override the option passed through '-march'. This patch

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

This revision was automatically updated to reflect the committed changes. Closed by commit rL349381: [Driver] Don't override '-march' when using '-arch x86_64h' (authored by thegameg, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D557

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

hfinkel added inline comments. Comment at: include/clang/Basic/Attr.td:2871-2872 /// distribute: attempt to distribute loop if State == Enable + /// pipeline: disable pipelining loop if State == Disable + /// pipeline_ii_count: try to pipeline loop for only 'Value' value -

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55775/new/ https://reviews.llvm.org/D55775 ___ cfe-commits mailing list cfe-commi

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

Gerolf added reviewers: ahatanak, qcolombet. Gerolf added a comment. + Akira, Quentin for their driver / x86_64h experience for a quick double check. Fwiw, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55775/new/ https://reviews.llvm.org/D55775

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

This revision was automatically updated to reflect the committed changes. Closed by commit rC349380: [darwin] parse the SDK settings from SDKSettings.json if it exists and (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D55673?vs=178309&id=178501#toc Re

r349380 - [darwin] parse the SDK settings from SDKSettings.json if it exists and

Author: arphaman Date: Mon Dec 17 11:19:15 2018 New Revision: 349380 URL: http://llvm.org/viewvc/llvm-project?rev=349380&view=rev Log: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend This commit adds support for re

[PATCH] D54604: Automatic variable initialization

rsmith added a comment. Thanks, you've addressed my comments to my satisfaction. (Not approving as I've not done a detailed review of the implementation, only of the approach, but it looks like your review with @pcc is nearly complete.) In D54604#1330356

[PATCH] D55731: [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch` is not specified

ab accepted this revision. ab added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55731/new/ https://reviews.llvm.org/D55731 ___ cfe-commits m

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1326071 , @rjmccall wrote: > I'm fine with making this change under the assumption that we've gotten the > language rule right. Even if that weren't abstractly reasonable for general > language work — and I do thin

[PATCH] D55770: [clangd] BackgroundIndex rebuilds symbol index periodically.

dblaikie added a comment. (from the peanut gallery): Usually what I'd expect here is "reindexing will occur X milliseconds after a write, covering anything written up until that point" - so it doesn't reindex unnecessarily if the files are unmodified/sitting idle, and it doesn't thrash reindexi

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:2871-2872 /// distribute: attempt to distribute loop if State == Enable + /// pipeline: disable pipelining loop if State == Disable + /// pipeline_ii_count: try to pipeline loop for only 'Value' val

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

steven_wu added inline comments. Comment at: include/clang/Driver/DarwinSDKInfo.h:36 +/// SDK has no SDKSettings.json, or a valid \c DarwinSDKInfo otherwise. +Expected> parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS, + StringRef

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin marked an inline comment as done. alexey.lapshin added inline comments. Comment at: include/clang/Basic/Attr.td:2871-2872 /// distribute: attempt to distribute loop if State == Enable + /// pipeline: disable pipelining loop if State == Disable + /// pipeline_i

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: include/clang/Driver/DarwinSDKInfo.h:36 +/// SDK has no SDKSettings.json, or a valid \c DarwinSDKInfo otherwise. +Expected> parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS, +

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:2871-2872 /// distribute: attempt to distribute loop if State == Enable + /// pipeline: disable pipelining loop if State == Disable + /// pipeline_ii_count: try to pipeline loop for only 'Value' val

[PATCH] D55749: [Driver] Automatically enable -munwind-tables if -fseh-exceptions is enabled

rnk added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3929 + options::OPT_fno_asynchronous_unwind_tables, + (TC.IsUnwindTablesDefault(Args) || + (ExceptionArg && Can you put this logic in the Windows or mingw toolchain instead by

[PATCH] D55685: Update Microsoft name mangling scheme for exception specifiers in the type system

zahen updated this revision to Diff 178490. zahen added a comment. Added support for msvc minor version as requested. Tied the updated mangling scheme to C++17 & compatibility mode > 1912 (15.5). Added additional tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55685/new/ https:/

[PATCH] D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. Other than a small design choice commented inline, LGTM. Comment at: include/clang/Driver/DarwinSDKInfo.h:36 +/// SDK has no SDKSettings.json, or a valid \c DarwinSDKIn

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

thegameg created this revision. thegameg added reviewers: vsk, dexonsmith, ab, t.p.northover, Gerolf. On Darwin, using '-arch x86_64h' would always override the option passed through '-march'. This patch allows users to use '-march' with x86_64h, while keeping the default to 'core-avx2' https

[PATCH] D55770: [clangd] BackgroundIndex rebuilds symbol index periodically.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:464 + if (BuildIndexPeriodMs > 0) +SymbolsUpdatedSinceLastIndex = true; + else why not simply check if `BuildIndexPeriodMs` has passed and issue rebuild here? That way we won't spawn a

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

lebedev.ri added a comment. Clang reviews should mainly go to cfe-commits, not llvm-commits. (all that will happen automagically if one sets the correct repo for the differential..) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.or

Re: r349063 - [CodeComplete] Adhere to LLVM naming style in CodeCompletionTest. NFC

Hi Yvan, sorry for the inconvenience. I believe this is the same as https://llvm.org/PR40033, should be fixed by r349362 (the build hasn't finished yet). I'll double check it's fixed tomorrow and make sure to take another look if not. On Mon, Dec 17, 2018 at 10:46 AM Yvan Roux wrote: > Hi Ilya,

[PATCH] D55437: [Index] Index declarations in lambda expression.

ilya-biryukov added a comment. Update after investigating with @hokein offline: the `RecursiveASTVisitor` has custom code to visit lambda parameters and return type, but it fallback to visiting typelocs when both parameters and a return type are specified. Unfortunately this fallback does not w

[PATCH] D55712: [Driver][PS4] Do not implicitly link against asan or ubsan if -nostdlib or -nodefaultlibs on PS4.

probinson added a comment. LGTM but I will defer to @filcab as he is more familiar with the area. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55712/new/ https://reviews.llvm.org/D55712 ___ cfe-commits mailing list

[PATCH] D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors

NoQ added a comment. In D54834#1332679 , @Szelethus wrote: > Interesting, I've been watching the bots closely, but got no mail after a > while. I'm not sure what the cause is, so I'll revert one-by-one. One of the common reasons for that is that the bui

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 178477. steleman added a comment. Herald added a subscriber: arphaman. Updated version of this changeset/patch, as per Renato's latest comments from D53927 (https://reviews.llvm.org/D53927). New benchmark comparing SLEEF pe

[PATCH] D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp

boga95 added a comment. I don't have commit access. Can you please do it on my behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54918/new/ https://reviews.llvm.org/D54918 ___ cfe-commits mailing list cfe-commits

r349362 - [CodeComplete] Fix test failure on different host and target configs

Author: ibiryukov Date: Mon Dec 17 08:37:52 2018 New Revision: 349362 URL: http://llvm.org/viewvc/llvm-project?rev=349362&view=rev Log: [CodeComplete] Fix test failure on different host and target configs This should fix PR40033. Modified: cfe/trunk/unittests/Sema/CodeCompleteTest.cpp Modif

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

aprantl added inline comments. Comment at: lib/AST/ASTImporter.cpp:1672 // FIXME: Handle this case somehow better. - consumeError(ImportedOrErr.takeError()); + else +consumeError(ImportedOrErr.takeError()); this else is redundant. =

[PATCH] D54676: [AST] Pack CallExpr

riccibruno abandoned this revision. riccibruno added a comment. Abandoned in favor of D55771 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54676/new/ https://reviews.llvm.org/D54676

[PATCH] D55771: [AST] Store the callee and argument expressions of CallExpr in a trailing array.

riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added subscribers: cfe-commits, javed.absar. Herald added a reviewer: shafik. Since `CallExpr::setNumArgs` has been removed, it is now possible to store the callee expression and the

[PATCH] D55770: [clangd] BackgroundIndex rebuilds symbol index periodically.

ioeric created this revision. ioeric added reviewers: ilya-biryukov, kadircet. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay. Currently, background index rebuilds symbol index on every indexed file, which can be inefficient. This patch makes it only rebuild symbol index p

[PATCH] D54438: [analyzer] Reimplement dependencies between checkers

Szelethus added a comment. > I still expect some skeletons to fall out of the closet This patch doesn't handle -analyzer-disable-checker, which leads to assertation failures in later pathes. Since the way which checker should/shouldnt be enabled is implemented rather poorly, I'll probably try t

[PATCH] D55765: Fix use-after-free bug in Tooling.

ymandel updated this revision to Diff 178470. ymandel added a comment. Change header correspondingly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55765/new/ https://reviews.llvm.org/D55765 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp In

Re: r349053 - [CodeComplete] Fill preferred type on binary expressions

Hi Douglas, Reid, Sorry for the breakage, I'll take a look at the bug. On Sat, Dec 15, 2018 at 12:18 AM wrote: > Hi, I think this test is still broken on Windows when you are building a > cross compiler as we at Sony do. I have put the details in PR40033. Can > somebody take a look? > > > > Do

[PATCH] D55765: Fix use-after-free bug in Tooling.

ymandel updated this revision to Diff 178468. ymandel added a comment. Change buildAST functions to take a StringRef instead of a Twine. In practice, code is almost never constructed on the fly using a Twine, so StringRef is simpler and avoids needing a copy when constructing the MemBuffer. Re

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

ebevhan added inline comments. Comment at: lib/CodeGen/CGCall.cpp:77 + if (MD) +RecTy = Context.getAddrSpaceQualType(RecTy, MD->getType().getAddressSpace()); return Context.getPointerType(CanQualType::CreateUnsafe(RecTy)); I'm a bit late to the party, bu

[PATCH] D55765: Fix use-after-free bug in Tooling.

ymandel created this revision. ymandel added a reviewer: alexfh. Herald added a subscriber: cfe-commits. `buildASTFromCodeWithArgs()` was creating a memory buffer referencing a stack-allocated string. This diff changes the implementation to copy the code string into the memory buffer so that said

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

alexey.lapshin marked 2 inline comments as done. alexey.lapshin added a comment. Ok, I will address all issues. Comment at: include/clang/Basic/Attr.td:2871-2872 /// distribute: attempt to distribute loop if State == Enable + /// pipeline: disable pipelining loop if State =

[PATCH] D53708: [ASTImporter] Add importer specific lookup

riccibruno added a comment. > Exactly. And this seems to be an important feature in ASTImporter, because > this makes it possible that we can chain into the redecl chain a newly > imported AST node to existing and structurally equivalent > nodes. (The > existing nodes are found by the lookup an

r349357 - Build ASTImporterTest.cpp with /bigobj on MSVC builds to keep llvm-clang-x86_64-expensive-checks-win buildbot happy

Author: rksimon Date: Mon Dec 17 07:14:08 2018 New Revision: 349357 URL: http://llvm.org/viewvc/llvm-project?rev=349357&view=rev Log: Build ASTImporterTest.cpp with /bigobj on MSVC builds to keep llvm-clang-x86_64-expensive-checks-win buildbot happy Modified: cfe/trunk/unittests/AST/CMakeLis

  1   2   >