[PATCH] D52967: Extend shelf-life by 70 years

bmwiedemann added a comment. As to the why: I'm working on reproducible builds for openSUSE and for that I verify that our packages can still give identical build results 15 years from now (which is the expected lifetime of today's enterprise software). `kvm -rtc base` option helps there. Somet

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

reuk created this revision. reuk added reviewers: Typz, krasimir, cfe-commits. This patch aims to add support for the following rules from the JUCE coding standards: - Always put a space before an open parenthesis that contains text - e.g. foo (123); - Never put a space before an empty pair of

r348084 - OpenCL: Improve vector printf warnings

Author: arsenm Date: Sat Dec 1 14:16:27 2018 New Revision: 348084 URL: http://llvm.org/viewvc/llvm-project?rev=348084&view=rev Log: OpenCL: Improve vector printf warnings The vector modifier is considered separate, so don't treat it as a conversion specifier. This is still not warning on some c

[PATCH] D55023: OpenCL: Improve vector printf warnings

arsenm closed this revision. arsenm added a comment. r348084 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55023/new/ https://reviews.llvm.org/D55023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

r348083 - OpenCL: Extend argument promotion rules to vector types

Author: arsenm Date: Sat Dec 1 13:56:10 2018 New Revision: 348083 URL: http://llvm.org/viewvc/llvm-project?rev=348083&view=rev Log: OpenCL: Extend argument promotion rules to vector types The spec is ambiguous on whether vector types are allowed to be implicitly converted. The only legal context

[PATCH] D55022: OpenCL: Extend argument promotion rules to vector types

arsenm closed this revision. arsenm marked an inline comment as done. arsenm added a comment. r348083 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55022/new/ https://reviews.llvm.org/D55022 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D55134: [CTU] Add triple/lang mismatch handling

a_sidorin added a comment. Hi Gabor, Please find my comments inline. > Hah. Do we support CTU for other languages, like ObjC and ObjC++? Can this be > an issue there? That's a good question. In Samsung, CTU hasn't been tested on ObjC code. Upstream CTU supports only FunctionDecls as well so it

[PATCH] D55135: [CTU][Analyzer]Add DisplayCTUProgress analyzer switch

a_sidorin added a comment. Hi Gabor, In addition to Umann remarks, there is a small comment inline. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:239 + if (DisplayCTUProgress) { +llvm::errs() << "ANALYZE (CTU loaded AST for source file): " +

[PATCH] D55131: [CTU] Add more lit tests and better error handling

a_sidorin added a comment. Hi Gabor, Please find my comments inline. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:251 + cast_or_null(Importer.Import(const_cast(FD))); + if (!ToDecl) { +return llvm::make_error(index_error_code::failed_import); Cond

[PATCH] D55133: [CTU] Add statistics

a_sidorin added a comment. Hi Gabor, Sorry, but I don't understand the meaning of some options. Could you please explain what are NumNoUnit and NumNotInOtherTU and what is the difference between them? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55133/new/ htt

[PATCH] D55132: [CTU] Add asserts to protect invariants

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. More assertions are always good. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55132/new/ https://reviews.llvm.org/D55132

[PATCH] D55129: [CTU] Eliminate race condition in CTU lit tests

a_sidorin added a comment. Hi Gabor, Yes, the `%T` variable is obsolete, but it looks like the Guide recommendations are not entirely fulfilled. Comment at: test/Analysis/ctu-main.cpp:1 -// RUN: mkdir -p %T/ctudir -// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o %

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

a_sidorin accepted this revision. a_sidorin added a comment. LGTM with a nit: the call to GetAlreadyImportedOrNull is not removed but moved into ImportDeclParts. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53755/new/ https://reviews.llvm.org/D53755

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53699/new/ https://reviews.llvm.org/D53699 ___

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

a_sidorin added a comment. Hi Gabor, Thank you for digging into this! Unfortunately, I don't have any MacOS device and I cannot check my code for the compatibility. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44100/new/ https://reviews.llvm.org/D44100 _

[PATCH] D53708: [ASTImporter] Add importer specific lookup

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Gabor, I think the code looks good. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53708/new/ https://reviews.llvm.org/D53708 ___

[PATCH] D55101: [clang-tidy] Ignore namespaced and C++ member functions in google-objc-function-naming check 🙈

aaron.ballman added a comment. In D55101#1315294 , @benhamilton wrote: > > Would you be okay with landing this fix and if we get any further reports > > for Objective-C++ sources then we can suppress it in all C++/Objective-C++ > > sources? I think there

[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

aaron.ballman added a comment. P-p-power ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54450/new/ https://reviews.llvm.org/D54450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

aaron.ballman added inline comments. Comment at: include/clang/AST/NestedNameSpecifier.h:220 + void print(raw_ostream &OS, const PrintingPolicy &Policy, + bool ResolveTemplateArguments = false) const; Quuxplusone wrote: > Peanut gallery says: Shoul

[PATCH] D53812: [Analyzer] Iterator Checker - Forbid increments past the begin() and decrements past the end() of containers

baloghadamsoftware updated this revision to Diff 176256. baloghadamsoftware added a comment. Thank you for the review! You are absolutely right, these error messages were not accurate and even misleading. Now I updated them. To achieve this I also had to separate the function `isOutOfRange()` i

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + leonardchan wrote: > rjmccall wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > Hmm. So adding a signed integer to an unsigned fixed-point type alway

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. Alexei, I had a chance to have a quick look into this on a borrowed Mac Book. Seems like the assertion which was related to the revert is not existent anymore, but a new assertion came in. Next week I'll have time to debug that and I'll come back to you with what I fin

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a reviewer: alexfh. Szelethus added a comment. *advanced summoning* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54401/new/ https://reviews.llvm.org/D54401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D55136: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins

riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. Much better. LGTM with a small format nit. Comment at: lib/Sema/SemaExpr.cpp:5556 // Extract the return type from the (builtin) function pointer type. -auto

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

dkrupp added a comment. In D55125#1315335 , @Szelethus wrote: > I see your point, but here's why I think it isn't a bug: I like to see macros > as `constexpr` variables, and if I used those instead, I personally wouldn't > like to get a warning just beca

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

dkrupp marked 3 inline comments as done. dkrupp added a comment. In D55125#1314788 , @JonasToth wrote: > In D55125#1314741 , @Szelethus wrote: > > > @JonasToth this is the `Lexer` based expression equality check I t

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

dkrupp updated this revision to Diff 176247. dkrupp added a comment. -clang-format applied -clang:: namespace qualifiers removed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55125/new/ https://reviews.llvm.org/D55125 Files: clang-tidy/misc/RedundantExpressionCheck.cpp test/clang-t

Re: r348070 - Specify constant context in constant emitter

This seems is wrong way to handle this, and seems likely to be unsound in C++. We should be creating a ConstantExpr node wrapped around the initializer instead. On Sat, 1 Dec 2018, 00:32 Bill Wendling via cfe-commits < cfe-commits@lists.llvm.org wrote: > Author: void > Date: Sat Dec 1 00:29:36 2

r348071 - Correct indentation.

Author: void Date: Sat Dec 1 01:06:26 2018 New Revision: 348071 URL: http://llvm.org/viewvc/llvm-project?rev=348071&view=rev Log: Correct indentation. Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp URL: http://llvm.org/viewvc/llvm-proj

r348070 - Specify constant context in constant emitter

Author: void Date: Sat Dec 1 00:29:36 2018 New Revision: 348070 URL: http://llvm.org/viewvc/llvm-project?rev=348070&view=rev Log: Specify constant context in constant emitter The constant emitter may need to evaluate the expression in a constant context. For exasmple, global initializer lists.