[PATCH] D47111: : Implement monotonic_buffer_resource.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. The tests might need some XFAIL'ing, but otherwise I think this looks good. Sorry for the wait. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47111/n

[PATCH] D54872: [clangd] Add ability to not use -resource-dir at all

malaperle planned changes to this revision. malaperle added a comment. In D54872#1307775 , @ilya-biryukov wrote: > We have to point clangd into the resource dir, corresponding to the version > of the headers it was built with. It's important we pick the

[PATCH] D54878: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347635: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking. (authored by henrywong, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] r347635 - [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking.

Author: henrywong Date: Mon Nov 26 20:27:00 2018 New Revision: 347635 URL: http://llvm.org/viewvc/llvm-project?rev=347635&view=rev Log: [clangd] NFC: Prefer `isa<>` to `dyn_cast<>` to do the checking. Summary: Prefer `isa<>` to `dyn_cast<>` when there only need a checking. Reviewers: ilya-biryuk

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

Glad I could help you diagnose the issue at least :) On Mon, 26 Nov 2018 at 18:03, Shoaib Meenai via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Uhh, we have our own build that uses the release branch, but somehow we > didn’t have that commit in there. Not sure how that happened, but sorry

r347633 - [docs] UBSan and ASan are supported on Windows

Author: rnk Date: Mon Nov 26 19:55:15 2018 New Revision: 347633 URL: http://llvm.org/viewvc/llvm-project?rev=347633&view=rev Log: [docs] UBSan and ASan are supported on Windows Also fix a bullet list. Fixes PR39775 Modified: cfe/trunk/docs/AddressSanitizer.rst cfe/trunk/docs/UndefinedBe

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

malaperle added a comment. In D54781#1307755 , @hokein wrote: > @malaperle, do you want a new release of `vscode-clangd` extension for this? I don't plan on doing changes for a little while in vscode-clangd so it would be good indeed to have a new relea

[PATCH] D54799: [clangd][WIP] textDocument/SymbolInfo method

arphaman added a comment. LGTM, we can optimize later. It looks like you also moved `SymbolID` to a new file, this should be an NFC precommit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 ___ cfe

r347630 - Revert r347627 "[MS] Push fewer DeclContexts for delayed template parsing"

Author: rnk Date: Mon Nov 26 18:54:17 2018 New Revision: 347630 URL: http://llvm.org/viewvc/llvm-project?rev=347630&view=rev Log: Revert r347627 "[MS] Push fewer DeclContexts for delayed template parsing" It broke the Windows self-host: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/bui

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Szelethus added a comment. > @george.karpenkov Matching macros is a very non-trivial job, how would you > feel if we shipped this patch as-is, and maybe leave a TODO about adding > macro `assert`s down the line? The only solution I saw in clang-tidy was to match binary expressions as a heurist

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright added a comment. Sorry it's taken so long to get all the feedback addressed! Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHou

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright updated this revision to Diff 175379. hwright marked 23 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54737/new/ https://reviews.llvm.org/D54737 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/Duratio

r347628 - Revert "[clang][slh] add attribute for speculative load hardening"

Author: zbrid Date: Mon Nov 26 18:22:00 2018 New Revision: 347628 URL: http://llvm.org/viewvc/llvm-project?rev=347628&view=rev Log: Revert "[clang][slh] add attribute for speculative load hardening" until I figure out why the build is failing or timing out *** Summary: T

r347627 - [MS] Push fewer DeclContexts for delayed template parsing

Author: rnk Date: Mon Nov 26 18:21:51 2018 New Revision: 347627 URL: http://llvm.org/viewvc/llvm-project?rev=347627&view=rev Log: [MS] Push fewer DeclContexts for delayed template parsing Only push the outermost record as a DeclContext when parsing a function body. See the comments in Sema::getCo

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

Uhh, we have our own build that uses the release branch, but somehow we didn’t have that commit in there. Not sure how that happened, but sorry for the noise. From: cfe-commits on behalf of Richard Smith via cfe-commits Reply-To: Richard Smith Date: Monday, November 26, 2018 at 12:01 PM To: S

[PATCH] D54923: [Modules] Remove non-determinism while serializing DECL_CONTEXT_LEXICAL and DECL_RECORD

bruno created this revision. bruno added reviewers: rsmith, v.g.vassilev. Herald added subscribers: dexonsmith, mgrang, jkorous. A module signature hashes out all relevant content in a module in order to guarantee that in a dep chain, an inconsistent module never gets imported. When using implicit

r347617 - [clang][slh] add attribute for speculative load hardening

Author: zbrid Date: Mon Nov 26 16:03:44 2018 New Revision: 347617 URL: http://llvm.org/viewvc/llvm-project?rev=347617&view=rev Log: [clang][slh] add attribute for speculative load hardening Summary: The prior diff had to be reverted because there were two tests that failed. I updated the two test

[PATCH] D53280: [analyzer] Emit an error for invalid -analyzer-config inputs

Szelethus added a comment. Polite ping. :) I'd be most comfortable landing D53692 together with this patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53280/new/ https://reviews.llvm.org/D53280

[PATCH] D50119: Compiler support for P1144R0 "__is_trivially_relocatable(T)"

rjmccall added a comment. In D50119#1305503 , @Quuxplusone wrote: > In D50119#1303720 , @rjmccall wrote: > > > In D50119#1303662 , @Quuxplusone > > wrote: > > > > > >> I sti

Re: r345099 - [analyzer] Trust summaries for OSObject::retain and OSObject::release

The error is indeed strange. The body is declared as LazyDeclStmtPtr Body; where using LazyDeclStmtPtr = LazyOffsetPtr; where template struct LazyOffsetPtr { mutable uint64_t Ptr = 0; (…) explicit operator bool() const { return Ptr != 0; } (…) } so it does not seem like it can be un

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

Charusso marked 2 inline comments as done. Charusso added a comment. @george.karpenkov thanks you for the comments! In D53076#1308641 , @george.karpenkov wrote: > What about just dropping the `Knowing` prefix? > Just having `arr is null, taking true bra

[PATCH] D54918: Apply clang-format to GenericTaintChecker.cpp

boga95 created this revision. boga95 added a reviewer: gerazo. boga95 added a project: clang. Herald added a subscriber: cfe-commits. I would like to add some patch for this checker later and I found that it isn't well formatted. Repository: rC Clang https://reviews.llvm.org/D54918 Files:

[PATCH] D54437: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry

Szelethus added a comment. Polite ping :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54437/new/ https://reviews.llvm.org/D54437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

dexonsmith added 1 blocking reviewer(s): arphaman. dexonsmith added a comment. In D54630#1308605 , @arphaman wrote: > Sounds convincing. > @dexonsmith What do you think? Besides maintaining correct behaviour, I think the most important thing here is th

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

george.karpenkov requested changes to this revision. george.karpenkov added inline comments. This revision now requires changes to proceed. Comment at: test/Analysis/uninit-vals.m:222 testObj->origin = makeIntPoint(1, 2); - if (testObj->size > 0) { ; } // expected-note{{Takin

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri marked an inline comment as not done. lebedev.ri added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:198 +assume-aligned-like attributes), `object-size``, and ``vptr`` checks do not +apply to pointers to types with the ``volatile`` qualifier --

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

george.karpenkov added a comment. This looks more reasonable, thanks! What about just dropping the `Knowing` prefix? Just having `arr is null, taking true branch` seems considerably more readable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53076/new/ https://reviews.llvm.org/D53076

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:198 +assume-aligned-like attributes), `object-size``, and ``vptr`` checks do not +apply to pointers to types with the ``volatile`` qualifier --

[PATCH] D54900: [Sema] Avoid CallExpr::setNumArgs in Sema::BuildCallToObjectOfClassType

aaron.ballman added inline comments. Comment at: lib/Sema/SemaOverload.cpp:13260 + // The number of arguments slots to allocate in the call. + // If we have default arguments we need to allocate space for them arguments -> argument Also, I think this comment

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman added a comment. In D54630#1302566 , @ilya-biryukov wrote: > In D54630#1301283 , @arphaman wrote: > > > I don't think we want to move the logic to add a libc++ path to the driver. > > `-cc1` with `-resour

[PATCH] D54902: [AST][Sema] Remove CallExpr::setNumArgs

aaron.ballman added inline comments. Comment at: include/clang/AST/ExprCXX.h:168 public: - CXXMemberCallExpr(ASTContext &C, Expr *fn, ArrayRef args, -QualType t, ExprValueKind VK, SourceLocation RP) - : CallExpr(C, CXXMemberCallExprClass, fn, args, t, V

[PATCH] D53751: [ASTImporter] Added Import functions for transition to new API.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53751/new/ https://reviews.llvm.org/D53751 ___

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

rjmccall added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:198 +assume-aligned-like attributes), `object-size``, and ``vptr`` checks do not +apply to pointers to types with the ``volatile`` qualifier lebedev.ri wrote: > rjmccall wrote: > >

[PATCH] D54799: [clangd][WIP] textDocument/SymbolInfo method

jkorous updated this revision to Diff 175314. jkorous marked an inline comment as done. jkorous added a comment. Adressed last comments + initial unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 Files: CMakeLists.txt ClangdLSPServ

[PATCH] D54799: [clangd][WIP] textDocument/SymbolInfo method

jkorous marked 5 inline comments as done. jkorous added inline comments. Comment at: clangd/ClangdServer.cpp:529 + + WorkScheduler.runWithAST("CursorInfo", File, Bind(Action, std::move(CB))); +} sammccall wrote: > sammccall wrote: > > nit: SymbolInfo > (This sti

Re: r347588 - Revert "[clang][slh] add attribute for speculative load hardening"

On Mon, Nov 26, 2018 at 3:13 PM Zola Bridges via cfe-commits wrote: > > Author: zbrid > Date: Mon Nov 26 12:11:18 2018 > New Revision: 347588 > > URL: http://llvm.org/viewvc/llvm-project?rev=347588&view=rev > Log: > Revert "[clang][slh] add attribute for speculative load hardening" > > This revert

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:198 +assume-aligned-like attributes), `object-size``, and ``vptr`` checks do not +apply to pointers to types with the ``volatile`` qualifier rjmccall wrote: > Is there a reason fo

r347588 - Revert "[clang][slh] add attribute for speculative load hardening"

Author: zbrid Date: Mon Nov 26 12:11:18 2018 New Revision: 347588 URL: http://llvm.org/viewvc/llvm-project?rev=347588&view=rev Log: Revert "[clang][slh] add attribute for speculative load hardening" This reverts commit 801eaf91221ba6dd6996b29ff82659ad6359e885. Removed: cfe/trunk/test/CodeGen

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

rjmccall added inline comments. Comment at: docs/UndefinedBehaviorSanitizer.rst:75 - ``-fsanitize=alignment``: Use of a misaligned pointer or creation - of a misaligned reference. + of a misaligned reference. Also sanitizes assume-aligned-like attributes. - ``-fsa

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

On Mon, 26 Nov 2018, 11:50 Richard Smith On Wed, 21 Nov 2018, 15:32 Shoaib Meenai via cfe-commits < > cfe-commits@lists.llvm.org wrote: > >> If it's not too late, could we have this as part of 7.0.1? (You'll also >> need to cherry-pick the initial reversion in r338602.) >> > > The revert was cherr

Re: [cfe-dev] Dumping AST information to other formats

On Mon, Nov 26, 2018 at 2:27 PM Keane, Erich via cfe-commits wrote: > > I'd be tentative to commit to any stability guarantees, particularly as the > AST tends to change reasonably often. Understood. This presupposes that there are stability guarantees to be made surrounding the information prov

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

On Wed, 21 Nov 2018, 15:32 Shoaib Meenai via cfe-commits < cfe-commits@lists.llvm.org wrote: > If it's not too late, could we have this as part of 7.0.1? (You'll also > need to cherry-pick the initial reversion in r338602.) > The revert was cherrypicked onto the branch in r338674. Was that not in

[PATCH] D54555: [clang][slh] add attribute for speculative load hardening

This revision was automatically updated to reflect the committed changes. Closed by commit rC347586: [clang][slh] add attribute for speculative load hardening (authored by zbrid, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54555?vs=

r347586 - [clang][slh] add attribute for speculative load hardening

Author: zbrid Date: Mon Nov 26 11:41:14 2018 New Revision: 347586 URL: http://llvm.org/viewvc/llvm-project?rev=347586&view=rev Log: [clang][slh] add attribute for speculative load hardening Summary: LLVM IR already has an attribute for speculative_load_hardening. Before this commit, when a user p

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

jessicah added a comment. I don't have commit permission to Clang review, can somebody commit this for me? Thanks, Jessica Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54195/new/ https://reviews.llvm.org/D54195 ___

[PATCH] D41044: Implementation of -fextend-lifetimes and -fextend-this-ptr to aid with debugging of optimized code

wolfgangp updated this revision to Diff 175307. wolfgangp added a comment. Rebased on r347577 with some test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41044/new/ https://reviews.llvm.org/D41044 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.

RE: [cfe-dev] Dumping AST information to other formats

I'd be tentative to commit to any stability guarantees, particularly as the AST tends to change reasonably often. That said, I can see the value of this. Additionally, it would be preferential I suspect if we could make the standard ast-dump just another (albeit default) "format" in whatever pl

Dumping AST information to other formats

Clang currently supports various -cc1 options that allow displaying AST information (-ast-dump, -ast-print, -ast-list, etc), but these options are not convenient to consume by third-party tools. GrammaTech has ongoing research efforts where we would like to output some information from the AST to a

[PATCH] D54195: Fix linker option for -fprofile-arcs -ftest-coverage

vsk added a comment. @jessicah Please ping this review if you need someone to commit this patch on your behalf. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54195/new/ https://reviews.llvm.org/D54195 ___ cfe-commit

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:4241 + if (SemaRef.getLangOpts().OpenCL && T.getType()->isTemplateTypeParmType()) +Quals.removeAddressSpace(); + When do you actually add the qualifier back? Also, I don't think this is sp

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. @smilewithani @lassi.niemisto @mewmew feel free to take a stab at it Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-

[PATCH] D53100: clang: Add ARCTargetInfo

tatyana-krasnukha updated this revision to Diff 175290. tatyana-krasnukha added a comment. Minor change: remove splitting big numeric arguments on 32-bit integers. Backend lowering code does this work. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53100/new/ htt

r347583 - [OPENMP][NVPTX]Emit default locations with the correct Exec|Runtime

Author: abataev Date: Mon Nov 26 10:37:09 2018 New Revision: 347583 URL: http://llvm.org/viewvc/llvm-project?rev=347583&view=rev Log: [OPENMP][NVPTX]Emit default locations with the correct Exec|Runtime modes. If the region is inside target|teams|distribute region, we can emit the locations with t

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan marked an inline comment as done. leonardchan added a comment. > Generally I think it's good! One final note; I assume we could technically > reuse/rename the EmitFixedPointAdd function and use it to emit other binops > when those are added? Yes, but I imagine if we choose to keep t

r347571 - [AArch64] Add aarch64_vector_pcs function attribute to Clang

Author: s.desmalen Date: Mon Nov 26 08:38:37 2018 New Revision: 347571 URL: http://llvm.org/viewvc/llvm-project?rev=347571&view=rev Log: [AArch64] Add aarch64_vector_pcs function attribute to Clang This is the Clang patch to complement the following LLVM patches: https://reviews.llvm.org/D51477

[PATCH] D54763: [clang][slh] Forward mSLH only to Clang CC1

This revision was automatically updated to reflect the committed changes. Closed by commit rC347582: [clang][slh] Forward mSLH only to Clang CC1 (authored by zbrid, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54763?vs=174813&id=1752

r347582 - [clang][slh] Forward mSLH only to Clang CC1

Author: zbrid Date: Mon Nov 26 10:13:31 2018 New Revision: 347582 URL: http://llvm.org/viewvc/llvm-project?rev=347582&view=rev Log: [clang][slh] Forward mSLH only to Clang CC1 Summary: -mno-speculative-load-hardening isn't a cc1 option, therefore, before this change: clang -mno-speculative-load-

[PATCH] D54845: [clangd] Canonicalize file path in URIForFile.

sammccall added inline comments. Comment at: clangd/Protocol.h:73 + + /// \p AbsPath is resolved to a canonical path corresponding to its URI. + URIForFile(llvm::StringRef AbsPath, llvm::StringRef HintPath = ""); We need to document the APIs and motivation, the

r347577 - [NFC] Replace magic numbers with CodeGenOpt enums

Author: sam_parker Date: Mon Nov 26 09:26:49 2018 New Revision: 347577 URL: http://llvm.org/viewvc/llvm-project?rev=347577&view=rev Log: [NFC] Replace magic numbers with CodeGenOpt enums Use enum values from llvm/Support/CodeGen.h for the optimisation levels in CompilerInvocation. Modified:

[PATCH] D54905: [AddressSanitizer] Add flag to disable linking with CXX runtime

evgeny777 created this revision. evgeny777 added reviewers: kcc, samsonov. This prevents link errors when operators new/delete are overridden by application. https://reviews.llvm.org/D54905 Files: include/clang/Driver/Options.td lib/Driver/SanitizerArgs.cpp test/Driver/sanitizer-ld.c I

[clang-tools-extra] r347574 - [clangd] Do not drop diagnostics from macros

Author: ibiryukov Date: Mon Nov 26 09:05:13 2018 New Revision: 347574 URL: http://llvm.org/viewvc/llvm-project?rev=347574&view=rev Log: [clangd] Do not drop diagnostics from macros if they still end up being in the main file. Modified: clang-tools-extra/trunk/clangd/Diagnostics.cpp clang

[PATCH] D54796: [clangd] C++ API for emitting file status

hokein added a comment. > It would be reasonable to be consistent with diagnostics: stop emitting the > statuses when ASTWorker was put into shutdown mode. Thanks, sounds fair. Comment at: clangd/ClangdServer.h:39 +// FIXME: find a better name. class DiagnosticsConsumer {

[PATCH] D54796: [clangd] C++ API for emitting file status

hokein updated this revision to Diff 175277. hokein marked 2 inline comments as done. hokein added a comment. Herald added a subscriber: jfb. stop emitting file status when ASTworker is shutting down. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D547

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC347571: [AArch64] Add aarch64_vector_pcs function attribute to Clang (authored by s.desmalen, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54425/new/ http

[PATCH] D54903: [WIP][Sema] Improve static_assert diagnostics.

courbet created this revision. Herald added a subscriber: cfe-commits. `static_assert(std::is_same::value, "message")` now prints the value of U and V. Repository: rC Clang https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Index: test/SemaC

[clang-tools-extra] r347570 - [clang-tidy] Improving narrowing conversions

Author: gchatelet Date: Mon Nov 26 08:25:55 2018 New Revision: 347570 URL: http://llvm.org/viewvc/llvm-project?rev=347570&view=rev Log: [clang-tidy] Improving narrowing conversions Summary: Newly flagged narrowing conversions: - integer to narrower signed integer (this is compiler implementation

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:80 +// used with the same version of generated operators. +RecTy = Context.getAddrSpaceQualType(RecTy, LangAS::opencl_generic); + Anastasia wrote: > rjmccall wrote: > > I would suggest tak

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rL347570: [clang-tidy] Improving narrowing conversions (authored by gchatelet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llv

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

On 11/21/2018 03:32 PM, Shoaib Meenai wrote: > If it's not too late, could we have this as part of 7.0.1? (You'll also need > to cherry-pick the initial reversion in r338602.) 7.0 hits assertion failures > for pretty basic memcpy cases on windows-msvc targets, and this patch fixes > that. > I'

[PATCH] D54902: [AST][Sema] Remove CallExpr::setNumArgs

riccibruno created this revision. riccibruno added reviewers: rsmith, aaron.ballman. riccibruno added a project: clang. Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini. `CallExpr::setNumArgs` is the only thing that prevents storing the arguments in a trailing array. There is only 3

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54425/new/ https://reviews.llvm.org/D54425 ___ cfe-commits mailing list

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:80 +// used with the same version of generated operators. +RecTy = Context.getAddrSpaceQualType(RecTy, LangAS::opencl_generic); + rjmccall wrote: > I would suggest taking this opportunity

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54898/new/ https://reviews.llvm.org/D54898 ___

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rL347567: [clangd] Enable auto-index behind a flag. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D53696: [Haiku] Support __float128 for Haiku x86 and x86_64

kallisti5 added a comment. I don't have permission to update this request, so I created https://reviews.llvm.org/D54901 with the updates recommended. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53696/new/ https://reviews.llvm.org/D53696

[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

vmiklos added a comment. Could you please review this at some stage? As mentioned previously, this is a dependency for D54349 . Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54450/new/ https://reviews.llvm.org/D54450 _

[clang-tools-extra] r347567 - [clangd] Enable auto-index behind a flag.

Author: sammccall Date: Mon Nov 26 08:00:11 2018 New Revision: 347567 URL: http://llvm.org/viewvc/llvm-project?rev=347567&view=rev Log: [clangd] Enable auto-index behind a flag. Summary: Ownership and configuration: The auto-index (background index) is maintained by ClangdServer, like Dynamic. (T

[PATCH] D54901: [Haiku] Support __float128 for Haiku x86 and x86_64

kallisti5 created this revision. kallisti5 added reviewers: chandlerc, joerg, compnerd, kristina, js. kallisti5 added a project: clang. Herald added a subscriber: cfe-commits. A revision on https://reviews.llvm.org/D53696 from another user. Repository: rC Clang https://reviews.llvm.org/D54901

[clang-tools-extra] r347566 - [clangd] Fix compilation of IndexBenchmark

Author: ibiryukov Date: Mon Nov 26 07:58:29 2018 New Revision: 347566 URL: http://llvm.org/viewvc/llvm-project?rev=347566&view=rev Log: [clangd] Fix compilation of IndexBenchmark Modified: clang-tools-extra/trunk/clangd/benchmarks/IndexBenchmark.cpp Modified: clang-tools-extra/trunk/clangd/b

[PATCH] D53697: [ASTImporter][Structural Eq] Check for isBeingDefined

This revision was automatically updated to reflect the committed changes. Closed by commit rL347564: [ASTImporter][Structural Eq] Check for isBeingDefined (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://revi

r347564 - [ASTImporter][Structural Eq] Check for isBeingDefined

Author: martong Date: Mon Nov 26 07:54:08 2018 New Revision: 347564 URL: http://llvm.org/viewvc/llvm-project?rev=347564&view=rev Log: [ASTImporter][Structural Eq] Check for isBeingDefined Summary: If one definition is currently being defined, we do not compare for equality and we assume that the

[clang-tools-extra] r347563 - [clangd] Fix use-after-free with expected types in indexing

Author: ibiryukov Date: Mon Nov 26 07:52:16 2018 New Revision: 347563 URL: http://llvm.org/viewvc/llvm-project?rev=347563&view=rev Log: [clangd] Fix use-after-free with expected types in indexing Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified: clang-tools-extra/t

[PATCH] D52276: [clangd] Add type boosting in code completion

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347562: [clangd] Add type boosting in code completion (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D52276?vs=175258&id=175260#toc Repository: rCTE Clang

[clang-tools-extra] r347562 - [clangd] Add type boosting in code completion

Author: ibiryukov Date: Mon Nov 26 07:38:01 2018 New Revision: 347562 URL: http://llvm.org/viewvc/llvm-project?rev=347562&view=rev Log: [clangd] Add type boosting in code completion Reviewers: sammccall, ioeric Reviewed By: sammccall Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commit

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov updated this revision to Diff 175258. ilya-biryukov added a comment. - Add a FIXME to FuzzyFindRequest Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52276/new/ https://reviews.llvm.org/D52276 Files: clangd/CodeComplete.cpp clangd/

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: test/clangd/background-index.test:16 +# Test that the index is writing files in the expected location. +# RUN: ls %t/.clangd-index/foo.cpp.*.idx + kadircet wrote: > kadircet

[PATCH] D54900: [Sema] Avoid CallExpr::setNumArgs in Sema::BuildCallToObjectOfClassType

riccibruno created this revision. riccibruno added reviewers: rsmith, aaron.ballman. riccibruno added a project: clang. Herald added subscribers: cfe-commits, dexonsmith, inglorion, mehdi_amini. `CallExpr::setNumArgs` is the only thing that prevents storing the arguments of a call expression in a

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov updated this revision to Diff 175257. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52276/new/ https://reviews.llvm.org/D52276 Files:

[PATCH] D52274: [clangd] Collect and store expected types in the index

This revision was automatically updated to reflect the committed changes. Closed by commit rL347560: [clangd] Collect and store expected types in the index (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[clang-tools-extra] r347560 - [clangd] Collect and store expected types in the index

Author: ibiryukov Date: Mon Nov 26 07:29:14 2018 New Revision: 347560 URL: http://llvm.org/viewvc/llvm-project?rev=347560&view=rev Log: [clangd] Collect and store expected types in the index Summary: And add a hidden option to control whether the types are collected. For experiments, will be remo

[PATCH] D52274: [clangd] Collect and store expected types in the index

ilya-biryukov updated this revision to Diff 175254. ilya-biryukov added a comment. - Remove unused #include Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52274/new/ https://reviews.llvm.org/D52274 Files: clangd/index/Index.h clangd/index/Serial

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

teemperor created this revision. teemperor added reviewers: martong, a.sidorin. teemperor added a project: LLDB. Herald added subscribers: cfe-commits, rnkovacs. `MustBuildLookupTable` must always be called on a primary context as we otherwise trigger an assert, but we don't ensure that this will

[PATCH] D52273: [clangd] Initial implementation of expected types

This revision was automatically updated to reflect the committed changes. Closed by commit rL347559: [clangd] Initial implementation of expected types (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://review

[clang-tools-extra] r347559 - [clangd] Initial implementation of expected types

Author: ibiryukov Date: Mon Nov 26 07:25:20 2018 New Revision: 347559 URL: http://llvm.org/viewvc/llvm-project?rev=347559&view=rev Log: [clangd] Initial implementation of expected types Summary: Provides facilities to model the C++ conversion rules without the AST. The introduced representation c

[PATCH] D52275: [Index] Expose USR generation for types

This revision was automatically updated to reflect the committed changes. Closed by commit rC347558: [Index] Expose USR generation for types (authored by ibiryukov, committed by ). Herald added a subscriber: arphaman. Changed prior to commit: https://reviews.llvm.org/D52275?vs=166167&id=175252#

r347558 - [Index] Expose USR generation for types

Author: ibiryukov Date: Mon Nov 26 07:24:48 2018 New Revision: 347558 URL: http://llvm.org/viewvc/llvm-project?rev=347558&view=rev Log: [Index] Expose USR generation for types Summary: Used in clangd. Reviewers: sammccall, ioeric Reviewed By: sammccall Subscribers: kadircet, cfe-commits Diffe

[PATCH] D45478: [clangd] Merge symbols in global-sym-builder on the go

ilya-biryukov abandoned this revision. ilya-biryukov added a comment. Herald added subscribers: kadircet, arphaman. This landed as a different change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45478/new/ https://reviews.llvm.org/D45478 __

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Bump! Thanks again for your consideration CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

sammccall updated this revision to Diff 175249. sammccall marked an inline comment as done. sammccall added a comment. Make blockUntilIdleForTest() accept a timeout, update comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54894/new/ https://re

[PATCH] D54894: [clangd] Enable auto-index behind a flag.

kadircet added inline comments. Comment at: test/clangd/background-index.test:13 +# The background index should allow us to go-to-definition on foo(). +# RUN: clangd -background-index -lit-test < %t/definition.jsonrpc | FileCheck %t/definition.jsonrpc + kadircet

  1   2   >