[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rL347509: [clangd] Add 'Switch header/source' command in clangd-vscode (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION htt

[clang-tools-extra] r347509 - [clangd] Add 'Switch header/source' command in clangd-vscode

Author: malaperle Date: Fri Nov 23 18:53:17 2018 New Revision: 347509 URL: http://llvm.org/viewvc/llvm-project?rev=347509&view=rev Log: [clangd] Add 'Switch header/source' command in clangd-vscode Summary: Alt+o is used on Windows/Linux and Option+Cmd+o on macOS. Signed-off-by: Marc-Andre Laperl

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

malaperle added a comment. In D54781#1306872 , @sammccall wrote: > This is great! > > I'm slightly nervous - the way we've extended the protocol with > `textDocument/switchSourceHeader` is pretty hard to extend, itself (since the > response is a string d

r347508 - [CodeComplete] Delete unused variable in rC342449

Author: maskray Date: Fri Nov 23 16:41:13 2018 New Revision: 347508 URL: http://llvm.org/viewvc/llvm-project?rev=347508&view=rev Log: [CodeComplete] Delete unused variable in rC342449 Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp URL: ht

[PATCH] D54547: PTH-- Remove feature entirely-

riccibruno added a comment. I looked at how `ASTReader` create the `IdentifierInfo`s returned by `IdentifierInfo *ASTReader::get(StringRef Name)`, and I ended up in `ASTIdentifierLookupTrait::ReadData`, which calls among other things `IdentifierTable::getOwn`. The `IdentifierInfo` created by `ge

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

riccibruno updated this revision to Diff 175143. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54866/new/ https://reviews.llvm.org/D54866 Files: include/clang/Basic/IdentifierTable.h lib/Basic/IdentifierTable.cpp Index: lib/Basic/IdentifierTable.cpp

[PATCH] D54866: Cleanups in IdentifierInfo following the removal of PTH

riccibruno created this revision. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Conditional on D54547 : PTH-- Remove feature entirely- The `Entry` pointer in `IdentifierInfo` was only null for `IdentifierInfo`s created from a PTH. Now

[PATCH] D54799: [clangd][WIP] textDocument/CursorInfo method

sammccall added a comment. Thanks, this looks good! Just nits, and please do port most of the test cases to unit tests. Comment at: clangd/ClangdServer.cpp:529 + + WorkScheduler.runWithAST("CursorInfo", File, Bind(Action, std::move(CB))); +} nit: SymbolInfo

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet marked an inline comment as done. gchatelet added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-narrowing-conversions.cpp:42-44 i += 2.0; - // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: narrowing conversion from 'double' to 'int' [cppcoreguidelines-n

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet updated this revision to Diff 175139. gchatelet added a comment. - Added a new option warn about wrong type literals Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53488/new/ https://reviews.llvm.org/D53488 Files: clang-tidy/cppcoreguide

[PATCH] D54865: [clangd] Auto-index watches global CDB for changes.

sammccall created this revision. sammccall added reviewers: ioeric, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Instead of receiving compilation commands, auto-index is triggered by just filenames to reindex, and gets commands from the global comp DB internally. Th

[PATCH] D54799: [clangd][WIP] textDocument/CursorInfo method

jkorous updated this revision to Diff 175137. jkorous added a comment. Multiple symbols per location. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd

[PATCH] D54796: [clangd] **Prototype**: C++ API for emitting file status

hokein added a comment. Thanks for the comment, the patch should be ready for review. There is one thing I'm not certain: should we stop emitting the file status when the file is removed (similar to the behavior of diagnostics)? For example, the file is removed while the AST is building. The cu

[PATCH] D54832: [clang-tidy] No fixes for auto new expression in smart check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:255 ASTContext *Ctx) { + // Skip when this is a new-expression with `auto`, e.g. "new auto(1)"." + if (New->getType()->getPointeeType()->getContainedA

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong added a comment. This will break LLDB, unless https://reviews.llvm.org/D54863 is applied. @shafik Could you please take a look on https://reviews.llvm.org/D54863 ? Repository: rC Clang https://reviews.llvm.org/D53655 ___ cfe-commits mail

[PATCH] D54796: [clangd] **Prototype**: C++ API for emitting file status

hokein updated this revision to Diff 175135. hokein marked 2 inline comments as done. hokein added a comment. Polish the code, address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54796 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdSe

[PATCH] D53812: [Analyzer] Iterator Checker - Forbid increments past the begin() and decrements past the end() of containers

baloghadamsoftware updated this revision to Diff 175134. baloghadamsoftware added a comment. Updated according to the comments. https://reviews.llvm.org/D53812 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/iterator-range.cpp Index: test/Analysis/iterator-range.cpp ==

[PATCH] D52311: [clangd] Add support for hierarchical documentSymbol

This revision was automatically updated to reflect the committed changes. Closed by commit rL347498: [clangd] Add support for hierarchical documentSymbol (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52311 Files:

[clang-tools-extra] r347498 - [clangd] Add support for hierarchical documentSymbol

Author: ibiryukov Date: Fri Nov 23 07:21:19 2018 New Revision: 347498 URL: http://llvm.org/viewvc/llvm-project?rev=347498&view=rev Log: [clangd] Add support for hierarchical documentSymbol Reviewers: ioeric, sammccall, simark Reviewed By: sammccall Subscribers: MaskRay, jkorous, arphaman, kadir

[PATCH] D54253: [OpenCL] Launch opencl-types.cl test only on x86

Anastasia added a comment. In https://reviews.llvm.org/D54253#1306124, @asavonic wrote: > FWIW, I'd vote for the first revision of this patch. From my > understanding, the test verifies that libclang is able to parse OpenCL > code correctly. It doesn't do anything specific to x86: target for x8

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-narrowing-conversions.cpp:42-44 i += 2.0; - // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: narrowing conversion from 'double' to 'int' [cppcoreguidelines-narrowing-conversions] + // CHECK-MESSAG

[PATCH] D52311: [clangd] Add support for hierarchical documentSymbol

ilya-biryukov updated this revision to Diff 175130. ilya-biryukov added a comment. - Handle 'using namespace' in printName - Do not mix-in symbols with locations from other files. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52311 Files: clangd/AST.cpp clangd/AST.h clan

[PATCH] D54745: [clang-tidy] Don't generate incorrect fixes for class with deleted copy/move constructor in smart_ptr check.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Generally LGTM with a few small nits. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:379 + // + // The fix (std::make_unique) requires to see

[PATCH] D54379: Add Hurd toolchain support to Clang

aaron.ballman added a comment. I don't know enough about hurd to review those portions of it, but I have some general comments on the patch. Comment at: lib/Basic/Targets/OSTargets.h:279 +MacroBuilder &Builder) const override { +// Hurd defines; list ba

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong updated this revision to Diff 175127. martong added a comment. - Use MostRecentDecl when setting PrevDecl Repository: rC Clang https://reviews.llvm.org/D53655 Files: include/clang/AST/DeclContextInternals.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTImporter.cpp lib/A

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael created this revision. mikael added a reviewer: Anastasia. Herald added subscribers: cfe-commits, yaxunl. Address spaces are cast into generic before invoking the constructor. Repository: rC Clang https://reviews.llvm.org/D54862 Files: lib/AST/DeclCXX.cpp lib/CodeGen/CGCall.cpp

r347496 - Remove the optional dependency from libclang to clang-tidy/include-fixer

Author: d0k Date: Fri Nov 23 07:02:33 2018 New Revision: 347496 URL: http://llvm.org/viewvc/llvm-project?rev=347496&view=rev Log: Remove the optional dependency from libclang to clang-tidy/include-fixer clangd does a better job on both of these, so don't slow down everyone's build for a poorly wo

[clang-tools-extra] r347496 - Remove the optional dependency from libclang to clang-tidy/include-fixer

Author: d0k Date: Fri Nov 23 07:02:33 2018 New Revision: 347496 URL: http://llvm.org/viewvc/llvm-project?rev=347496&view=rev Log: Remove the optional dependency from libclang to clang-tidy/include-fixer clangd does a better job on both of these, so don't slow down everyone's build for a poorly wo

[PATCH] D52879: Derive builtin return type from its definition

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! It looks reasonable small change! Repository: rC Clang https://reviews.llvm.org/D52879 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

baloghadamsoftware updated this revision to Diff 175125. baloghadamsoftware added a comment. More standard-like tests. https://reviews.llvm.org/D54466 Files: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h lib/StaticAnalyzer/Checkers/IteratorChecker.cpp lib/StaticAnalyzer/Core

[PATCH] D53812: [Analyzer] Iterator Checker - Forbid increments past the begin() and decrements past the end() of containers

baloghadamsoftware updated this revision to Diff 175124. baloghadamsoftware added a comment. Restored corrected patch after uploading an incorrect one. https://reviews.llvm.org/D53812 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/iterator-range.cpp Index: test/Analys

[clang-tools-extra] r347495 - [clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp)

Author: alexfh Date: Fri Nov 23 06:30:14 2018 New Revision: 347495 URL: http://llvm.org/viewvc/llvm-project?rev=347495&view=rev Log: [clang-tidy] Ignore matches in template instantiations (cert-dcl21-cpp) The test fails with a local modification to clang-tidy/ClangTidyDiagnosticConsumer.cpp to in

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

sammccall added a comment. This is great! I'm slightly nervous - the way we've extended the protocol with `textDocument/switchSourceHeader` is pretty hard to extend, itself (since the response is a string directly). This is only tangentially related to this patch, the same issue exists with Th

[PATCH] D52276: [clangd] Add type boosting in code completion

sammccall added inline comments. Comment at: clangd/CodeComplete.cpp:1307 getCompletionKindString(Recorder->CCContext.getKind())); log("Code complete: sema context {0}, query scopes [{1}] (AnyScope={2})", getCompletionKindString(Recorder->CCCo

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

Anastasia updated this revision to Diff 175120. Anastasia added a comment. Removed FIXME from the test case that is being fixed. https://reviews.llvm.org/D54858 Files: lib/Sema/SemaDecl.cpp lib/Sema/TreeTransform.h test/CodeGenOpenCLCXX/template-address-spaces.cl test/SemaOpenCLCXX/addr

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

Anastasia created this revision. Anastasia added reviewers: rjmccall, yaxunl. When template instantiation leads to creation of invalid code patterns with address spaces compiler crashes with ICE. This patch fixes the template instantiation to provide correct diagnostics instead. https://revie

[PATCH] D52311: [clangd] Add support for hierarchical documentSymbol

ilya-biryukov added inline comments. Comment at: unittests/clangd/FindSymbolsTests.cpp:442 +SymNameRange(Main.range("decl"), + AllOf(WithName("f"), WithKind(SymbolKind::Method), +SymN

[PATCH] D52311: [clangd] Add support for hierarchical documentSymbol

ilya-biryukov updated this revision to Diff 175116. ilya-biryukov added a comment. - Do not drop anonymous enums Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52311 Files: clangd/AST.cpp clangd/AST.h clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdSe

[PATCH] D52795: [analyzer][PlistMacroExpansion] Part 3.: Macro arguments are expanded

xazax.hun accepted this revision. xazax.hun added a reviewer: xazax.hun. xazax.hun added a comment. Some minor comment inline. Otherwise looks good. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:879 +// If this token is the current macro's argument, we should exp

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. Do not forget that there is a fix the to use getMostRecentDecl in ASTImporter.cpp line 2666 here. Repository: rC Clang https://reviews.llvm.org/D53655 __

[PATCH] D54799: [clangd][WIP] textDocument/CursorInfo method

jkorous updated this revision to Diff 175115. jkorous marked 2 inline comments as done. jkorous added a comment. Herald added a subscriber: mgorny. Couple minor changes based on discussion. - Move `SymbolID` to `index/SymbolID.h`. - Rename in `ClangdServer` - drop the verb from method name. - Rem

[PATCH] D54799: [clangd][WIP] textDocument/CursorInfo method

jkorous marked 7 inline comments as done. jkorous added a comment. In https://reviews.llvm.org/D54799#1306585, @sammccall wrote: > So I think both SymbolID and USR are optional. No problem. I am just wondering if it make sense to include any symbol with empty name, empty USR and no ID in LSP r

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov added inline comments. Comment at: clangd/Quality.cpp:373 + if (TypeMatchesPreferred) +Score *= 2.0; + sammccall wrote: > is 2 really enough? Changed to 5. We can tweak it later if that turns out to be too big. Comment at: cl

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov updated this revision to Diff 175114. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Increase the multiplier - Move the member out of the file proximity group Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52276 Files: clangd/Co

[PATCH] D53812: [Analyzer] Iterator Checker - Forbid increments past the begin() and decrements past the end() of containers

baloghadamsoftware updated this revision to Diff 175113. baloghadamsoftware added a comment. Herald added a subscriber: gamesh411. More standard-like tests. https://reviews.llvm.org/D53812 Files: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h lib/StaticAnalyzer/Checkers/Iterato

[PATCH] D54851: [clangd] Tune down scope boost for global scope

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. This improves cross-namespace completions and has ignorable impact on other completion types. Metrics === OVERALL (excl. CROSS_NAME

[PATCH] D52274: [clangd] Collect and store expected types in the index

ilya-biryukov added inline comments. Comment at: clangd/index/Index.cpp:118 +static void own(Symbol &S, UniqueStringSaver &Strings, +BumpPtrAllocator &Arena) { visitStrings(S, [&](StringRef &V) { V = Strings.save(V); }); sammccall wrote: > why

[PATCH] D52274: [clangd] Collect and store expected types in the index

ilya-biryukov updated this revision to Diff 175104. ilya-biryukov added a comment. - Remove another accidental change Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52274 Files: clangd/index/Index.h clangd/index/Serialization.cpp clangd/index/SymbolCollector.cpp clangd/

[PATCH] D52274: [clangd] Collect and store expected types in the index

ilya-biryukov updated this revision to Diff 175103. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Remove accidental changes - Add types to binary serialization Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52274 Files: clangd/index/Index.h

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

dkrupp added a comment. Herald added a subscriber: gamesh411. @dcoughlin could you please look into this? https://reviews.llvm.org/D54429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov updated this revision to Diff 175098. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Add using namespace llvm, get rid of llvm:: Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52273 Files: clangd/CMakeLists.txt clangd/Expected

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175097. kadircet added a comment. - rebased and changed URI convertion patterns, since it changed in https://reviews.llvm.org/rL347467 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54817 Files: clangd/index/Background.cpp clangd/inde

[PATCH] D54845: [clangd] Canonicalize file path in URIForFile.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. File paths in URIForFile can come from index or local AST. Path from index goes through URI transformation and the final path is resolved b

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

baloghadamsoftware added a comment. There is `CXXDerivedObjectRegion` as well. I am totally confused about the terminology now. Is there somewhere a documentation that explains all these things? If I make a class

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong added a comment. > I see that now everything is reverted, the "good" things too (change to > indirectFieldDecl and a line split)? Yes, you are completely right, sorry for this mess. I just have updated so the good things remain. Repository: rC Clang https://reviews.llvm.org/D53655

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong updated this revision to Diff 175091. martong marked an inline comment as done. martong added a comment. - Keep the good changes and use the name 'containsInVector' Repository: rC Clang https://reviews.llvm.org/D53655 Files: include/clang/AST/DeclContextInternals.h include/clang/

[PATCH] D54799: [clangd][WIP] textDocument/CursorInfo method

hokein added inline comments. Comment at: XRefs.cpp:95 Preprocessor &PP; + const bool StopOnFirstDeclFound; sammccall wrote: > jkorous wrote: > > sammccall wrote: > > > Please don't do this - it's inconsistent with the other XRefs features. > > > (If for so

[PATCH] D54799: [clangd][WIP] textDocument/CursorInfo method

sammccall added a subscriber: hokein. sammccall added a comment. In https://reviews.llvm.org/D54799#1306488, @jkorous wrote: > >> - conditional return in `getCursorInfo` - Should we return for example > >> data with empty `USR`? > > > > Please return a symbol unless it has no SymbolID (we don't

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175087. kadircet marked an inline comment as done. kadircet added a comment. - Change srcs to store multiple source file information rathet than one. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54817 Files: clangd/index/Background.cpp

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

shuaiwang added a comment. In https://reviews.llvm.org/D54399#1296317, @dblaikie wrote: > Could you fix the modulemap (might amount to reverting the change Eric made > in r342827? or maybe it's more involved than that) & validate that the > modules build is working with this change (probably un

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

balazske added a comment. I see that now everything is reverted, the "good" things too (change to indirectFieldDecl and a line split)? Repository: rC Clang https://reviews.llvm.org/D53655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h