wuzish marked 2 inline comments as done.
wuzish added a comment.
The updated patch now extended the scope and can include the case.
https://reviews.llvm.org/D53417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
wuzish updated this revision to Diff 173276.
wuzish added a comment.
Extend the scope to all vector type as one comment suggested.
> a conversion sequence that bitcasts a vector should be ranked worse than one
> that does not, regardless of the kind of vector in use.
Which is also made code cle
Test?
On Fri, Nov 9, 2018 at 4:34 AM Bill Wendling via cfe-commits
wrote:
>
> Author: void
> Date: Thu Nov 8 17:32:30 2018
> New Revision: 346461
>
> URL: http://llvm.org/viewvc/llvm-project?rev=346461&view=rev
> Log:
> Ignore implicit things like ConstantExpr.
>
> Modified:
>
> clang-tools
wuzish added a comment.
In https://reviews.llvm.org/D53417#1292404, @rsmith wrote:
> I like the direction here, and I'd like to see this applied generally: a
> conversion sequence that bitcasts a vector should be ranked worse than one
> that does not, regardless of the kind of vector in use.
hubert.reinterpretcast added a comment.
> some test points check the error report for ambiguous call because of too
> many implicit cast choices from ext_vector_type to vector type.
It appears the answer is to update these tests and remove the restriction on
the type class.
https://reviews.ll
Author: wuzish
Date: Thu Nov 8 19:35:32 2018
New Revision: 346471
URL: http://llvm.org/viewvc/llvm-project?rev=346471&view=rev
Log:
[PowerPC] [Clang] [AltiVec] The second parameter of vec_sr function should be
modulo the number of bits in the element
The second parameter of vec_sr function is r
rsmith added a comment.
I like the direction here, and I'd like to see this applied generally: a
conversion sequence that bitcasts a vector should be ranked worse than one that
does not, regardless of the kind of vector in use.
https://reviews.llvm.org/D53417
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346471: [PowerPC] [Clang] [AltiVec] The second parameter of
vec_sr function should be… (authored by wuzish, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346471: [PowerPC] [Clang] [AltiVec] The second parameter of
vec_sr function should be… (authored by wuzish, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54087?vs=172538&id=173262#t
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D53263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Wizard updated this revision to Diff 173258.
Wizard added a comment.
remove blank lines
Repository:
rC Clang
https://reviews.llvm.org/D54288
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
Author: dyung
Date: Thu Nov 8 18:44:07 2018
New Revision: 346468
URL: http://llvm.org/viewvc/llvm-project?rev=346468&view=rev
Log:
Fix test from r346439 to also work on Windows due to path separator differences.
Modified:
cfe/trunk/test/Modules/mismatch-diagnostics.cpp
Modified: cfe/trunk/t
echristo added a comment.
The llvm backend patch here has discussion around debug info kinds that we
should iron out first.
Comment at: lib/Driver/ToolChains/Cuda.cpp:292
+ bool IsDebugEnabled = !A || A->getOption().matches(options::OPT_O0) ||
+Args.ha
Wizard created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D54288
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
Author: void
Date: Thu Nov 8 18:03:24 2018
New Revision: 346467
URL: http://llvm.org/viewvc/llvm-project?rev=346467&view=rev
Log:
Remove unused c'tor.
Modified:
clang-tools-extra/trunk/modularize/ModuleAssistant.cpp
Modified: clang-tools-extra/trunk/modularize/ModuleAssistant.cpp
URL:
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346462: [WebAssembly] Lower select for vectors (authored by
tlively, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D53675
Files:
llvm/trunk/lib/Target/WebAssembly/WebAssemblyISelLower
Author: void
Date: Thu Nov 8 17:32:30 2018
New Revision: 346461
URL: http://llvm.org/viewvc/llvm-project?rev=346461&view=rev
Log:
Ignore implicit things like ConstantExpr.
Modified:
clang-tools-extra/trunk/clang-tidy/performance/NoexceptMoveConstructorCheck.cpp
Modified:
clang-tools-extra
Author: void
Date: Thu Nov 8 17:04:05 2018
New Revision: 346458
URL: http://llvm.org/viewvc/llvm-project?rev=346458&view=rev
Log:
Use correct parameter name in comment.
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
Modified: cfe/trunk/include/clang/StaticAnalyzer/C
echristo added a comment.
I have no other bikeshed colors here. :)
Repository:
rC Clang
https://reviews.llvm.org/D54243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346455: Compound literals, enums, et al require const expr
(authored by void, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53921?vs=172313&id=173248#toc
Repository:
rC Clang
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346455: Compound literals, enums, et al require const expr
(authored by void, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53921?vs=172313&
Author: void
Date: Thu Nov 8 16:41:36 2018
New Revision: 346455
URL: http://llvm.org/viewvc/llvm-project?rev=346455&view=rev
Log:
Compound literals, enums, et al require const expr
Summary:
Compound literals, enums, file-scoped arrays, etc. require their
initializers and size specifiers to be c
nastafev added a comment.
Thanks, I agree with @andrew.w.kaylor and his interpretation.
I was trying to convey the message that the programmer operating with
intrinsics relies on the semantics they carry because there's no other way to
express that semantics. Re-optimizing what's already optimiz
Author: adrian
Date: Thu Nov 8 16:26:15 2018
New Revision: 346454
URL: http://llvm.org/viewvc/llvm-project?rev=346454&view=rev
Log:
Fix a use-after-free introduced by r344915.
r344915 added a call to ApplyDebugLocation to the sanitizer check
function emitter. Some of the sanitizers are emitted i
void marked an inline comment as done.
void added a comment.
I'm using "arcanist" for the first time, and I don't want to mess things up.
I'll address the comments here in the next patch.
Repository:
rC Clang
https://reviews.llvm.org/D53921
___
stephanemoore added inline comments.
Comment at: docs/clang-tidy/checks/google-objc-function-naming.rst:20
+ static bool is_positive(int i) { return i > 0; }
+ bool IsNegative(int i) { return i < 0; }
+
benhamilton wrote:
> This is not actually handled by the c
rsmith accepted this revision.
rsmith added a comment.
Let's do it. The diagnostic and fix-it is awesome ;)
https://reviews.llvm.org/D53700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
stephanemoore updated this revision to Diff 173244.
stephanemoore marked an inline comment as done.
stephanemoore added a comment.
Added a test case for an extern function without an appropriate prefix
(`IsPrime`).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51575
Files:
aaron.ballman added inline comments.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:65
+ unless(isInsideOfRangeBeginEndStmt()),
+ unless(hasSourceExpression(ignoringParenCasts(stringLiteral()
.bind("cast"),
---
Eugene.Zelenko added inline comments.
Comment at: clangd/index/Background.cpp:29
#include
+#include
+#include
Please run Clang-format. Headers in sections should be in alphabetical order.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54269
JonasToth added inline comments.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:65
+ unless(isInsideOfRangeBeginEndStmt()),
+ unless(hasSourceExpression(ignoringParenCasts(stringLiteral()
.bind("cast"),
---
andrew.w.kaylor added a comment.
Agreed. Reverting this patch wouldn't move us forward on constrained FP
handling. What I'm saying (and what I think @nastafev is saying) is that this
patch is taking a built-in that allows the user to express specific signalling
behavior and throwing away that
aaron.ballman added inline comments.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:65
+ unless(isInsideOfRangeBeginEndStmt()),
+ unless(hasSourceExpression(ignoringParenCasts(stringLiteral()
.bind("cast"),
---
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
I'm fine with `_Clang` or anything else too. Thanks for doing this!
Comment at: lib/Basic/Attributes.cpp:18
if (ScopeName == "__gnu__")
-ScopeName = ScopeName.slice(
JonasToth created this revision.
JonasToth added reviewers: aaron.ballman, alexfh, hokein.
Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai.
The fix to the issue that `const char* p = ("foo")` is diagnosed as decay
is to ignored the ParenCast.
Resolves PR39583
Repository:
rC
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/llvm-problematic-statics.rst:7
+
+Looks for functions defined in "public" headers that return the address of a
static local. These are not guaranteed to have the addresss across shared
libraries and could b
void marked 2 inline comments as done.
void added inline comments.
Comment at: include/clang/AST/Expr.h:3073-3074
+ e = ice->getSubExpr();
+else if (ConstantExpr *ce = dyn_cast(e))
+ e = ce->getSubExpr();
+else
rsmith wrote:
> Should we skip an
JonasToth added inline comments.
Comment at: clang-tidy/llvm/ProblematicStaticsCheck.cpp:33
+ const auto *VD = Result.Nodes.getNodeAs("var");
+ const auto *Return = Result.Nodes.getNodeAs("return");
+ diag(Return->getBeginLoc(), "address of static local variable %0 may not "
-
JonasToth added a comment.
Very interesting. As I am not very familiar with all the internals I do have a
few questions :)
Right now notes seem not be closely attached to their related warning. But
within the there is a check, that a note is emitted after an error. Would it
make sense to group
bobsayshilol added a reviewer: rjmccall.
bobsayshilol added a comment.
Ping.
https://reviews.llvm.org/D53263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, other than the compound literal part I think this is all fine. I'm
happy for you to go ahead with this as-is; we can rearrange how we handle
compound literals as a later change if you
aaron.ballman added inline comments.
Comment at: clang-tidy/llvm/ProblematicStaticsCheck.cpp:33
+ const auto *VD = Result.Nodes.getNodeAs("var");
+ const auto *Return = Result.Nodes.getNodeAs("return");
+ diag(Return->getBeginLoc(), "address of static local variable %0 may not
efriedma added a comment.
Yes, in constrained-fp mode we might need intrinsics, at least short-term. I
assume you'll probably add target-independent constrained masked fp vector
operations at some point, but that's probably not a priority. But that still
leaves two problems. One, clang doesn
JonasToth added inline comments.
Comment at: clang-tidy/llvm/ProblematicStaticsCheck.cpp:33
+ const auto *VD = Result.Nodes.getNodeAs("var");
+ const auto *Return = Result.Nodes.getNodeAs("return");
+ diag(Return->getBeginLoc(), "address of static local variable %0 may not "
-
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:178
+ return;
+// Conversions to unsigned integer are well defined and follow modulo 2
+// arithmetic.
gchatelet wrote:
> JonasToth wrote:
> > I a
richardmembarth added a comment.
I think it's not so easy to provide such tests for CUDA.
CUDA memory space specifiers are implemented via attributes, e.g. `#define
__shared__ __attribute__((shared))`.
As a result of this, they are pretty-printed via a different code path.
In my example, I call `
JonasToth added a comment.
LG from my side. Please wait for feedback from @aaron.ballman or @alexfh before
committing.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53974
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
andrew.w.kaylor added a comment.
In https://reviews.llvm.org/D45616#1290897, @nastafev wrote:
> > can trigger arbitrary floating-point exceptions anywhere in your code
>
> I believe this statement reflects the current state of many compilers on the
> market, I guess I just don't see the reason
yaxunl created this revision.
yaxunl added a reviewer: tra.
clang-offload-bundler creates `__CLANG_OFFLOAD_BUNDLE__*` sections in the
bundles,
which get into the linked files. These sections are useless after linking. They
waste disk
space and cause confusion for clang when directly linked with
Author: dblaikie
Date: Thu Nov 8 12:47:30 2018
New Revision: 346439
URL: http://llvm.org/viewvc/llvm-project?rev=346439&view=rev
Log:
[Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch
too
The current version only emits the below error for a module (attempted to be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346439: [Frontend/Modules] Show diagnostics on prebuilt
module configuration mismatch… (authored by dblaikie, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://re
jessicah updated this revision to Diff 173209.
jessicah added a comment.
Updated diff with additional context upon review comments.
Repository:
rC Clang
https://reviews.llvm.org/D54195
Files:
lib/Driver/ToolChains/Linux.cpp
test/Driver/clang_f_opts.c
Index: test/Driver/clang_f_opts.c
=
vsapsai added a comment.
In https://reviews.llvm.org/D54245#1292008, @bruno wrote:
> Hi Volodymyr. Does this behavior changed after your VFS fallback change?
https://reviews.llvm.org/D50539 didn't change `RedirectingFileSystem` behavior
regarding real paths. But for `-ivfsoverlay` it started u
bruno added a comment.
Hi Volodymyr. Does this behavior changed after your VFS fallback change?
https://reviews.llvm.org/D54245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a comment.
Thanks for the patch. Would you mind uploading a diff with additional context
(e.g. git diff -U1)? Phab doesn't render it.
Repository:
rC Clang
https://reviews.llvm.org/D54195
___
cfe-commits mailing list
cfe-commits@lis
kpn added a comment.
In https://reviews.llvm.org/D53157#1291978, @cameron.mcinally wrote:
> In https://reviews.llvm.org/D53157#1291964, @kpn wrote:
>
> > I don't expect anyone would need to switch between constrained and regular
> > floating point at an instruction level of granularity.
>
>
> Th
probinson added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:5889
const llvm::Triple &T = getToolChain().getTriple();
- if (Args.hasArg(options::OPT_gsplit_dwarf) &&
+ if ((getDebugFissionKind(D, Args) == DwarfFissionKind::Split) &&
(T.isOSLinux() || T
cameron.mcinally added a comment.
In https://reviews.llvm.org/D53157#1291964, @kpn wrote:
> I don't expect anyone would need to switch between constrained and regular
> floating point at an instruction level of granularity.
The Standard allows for this (to some degree). E.g. FENV_ACCESS can be
andrew.w.kaylor added a comment.
Craig Topper also raised some concerns with me (in person, his desk is right by
mine) about the potential effect this might have on code size. He tells me that
IRBuilder calls are intended to always be inlined and if we grow the
implementation of these functions
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
wuzish wrote:
> hubert.re
kpn added a comment.
In https://reviews.llvm.org/D53157#1290364, @andrew.w.kaylor wrote:
> Rather than having separate methods to create the constrained versions of the
> intrinsics, why not have a way to set the constrained state in the IR builder
> and have the regular CreateFAdd et. al. func
lichray accepted this revision.
lichray added inline comments.
This revision is now accepted and ready to land.
Herald added a subscriber: libcxx-commits.
Comment at: libcxx/include/istream:365
__input_arithmetic(basic_istream<_CharT, _Traits>& __is, _Tp& __n) {
-#ifndef _LIBCPP
aaron.ballman added inline comments.
Comment at: clang-tidy/bugprone/DeleteThisCheck.cpp:23
+ cxxDeleteExpr(
+ has(ignoringParenImpCasts(cxxThisExpr(
+ .bind("DeleteThis"),
Will this catch too much? e.g.,
```
struct S {
int *Foo;
~
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:17
+#include "llvm/ADT/SmallVector.h"
+#include "llvm/Support/Mutex.h"
+
Is this include needed?
Comment at: clang-tidy/cppcoreguideline
Eugene.Zelenko added a comment.
Please also add regression test case. Is should also cover standalone function
with this variable.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54262
___
cfe-commits mailing list
cfe-commits@lists.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/bugprone-delete-this.rst:8
+
+Said statement generates multiple problems, such as enforcing allocating the
object via ``new``, or not
dgoldman added a comment.
Since I don't have commit access, sammccall will land this
Repository:
rC Clang
https://reviews.llvm.org/D53900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
aaron.ballman added inline comments.
Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:36
+GetScaleForFactory(llvm::StringRef FactoryName) {
+ static const auto *ScaleMap =
+ new std::unordered_map(
hwright wrote:
> Eugene.Zelenko wrote:
> > This
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:88
+ Checks for cases where arguments to ``absl::Duration`` factory functions are
+ scaled internally and could be changed to a different factory function. This
+ check also looks for arguements with a ze
aaron.ballman added a comment.
Can you add tests for this change? We typically have these in Misc by passing
`-ast-print`.
Repository:
rC Clang
https://reviews.llvm.org/D54258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE346418: [clang-tidy] Untangle layering in
ClangTidyDiagnosticConsumer somewhat. NFC (authored by sammccall, committed by
).
Changed prior to commit:
https://reviews.llvm.org/D54033?vs=172339&id=17318
kadircet created this revision.
kadircet added reviewers: sammccall, ioeric.
Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54269
Files:
clangd/index/Background.cpp
clangd/index/Background.h
unittests/
Author: sammccall
Date: Thu Nov 8 09:42:16 2018
New Revision: 346418
URL: http://llvm.org/viewvc/llvm-project?rev=346418&view=rev
Log:
[clang-tidy] Untangle layering in ClangTidyDiagnosticConsumer somewhat. NFC
Summary:
Clang's hierarchy is CompilerInstance -> DiagnosticsEngine ->
DiagnosticCon
hhb added a comment.
Ping..
Repository:
rC Clang
https://reviews.llvm.org/D53850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sammccall
Date: Thu Nov 8 09:10:31 2018
New Revision: 346415
URL: http://llvm.org/viewvc/llvm-project?rev=346415&view=rev
Log:
[clang-tidy] fix test after r346414
Modified:
clang-tools-extra/trunk/test/clang-tidy/diagnostic.cpp
Modified: clang-tools-extra/trunk/test/clang-tidy/diagn
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346414: [Tooling] Produce diagnostics for missing input
files. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53958?vs=172052&id=173180#toc
Repository:
rC
Author: sammccall
Date: Thu Nov 8 08:57:01 2018
New Revision: 346414
URL: http://llvm.org/viewvc/llvm-project?rev=346414&view=rev
Log:
[Tooling] Produce diagnostics for missing input files.
Summary:
This was disabled way back in 2011, in the dark times before Driver was
VFS-aware.
Also, make d
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346413: Fix bitcast to address space cast for coerced
load/stores (authored by yaxunl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53780?vs=172673&id=173179#toc
Repository:
rC
Author: yaxunl
Date: Thu Nov 8 08:55:46 2018
New Revision: 346413
URL: http://llvm.org/viewvc/llvm-project?rev=346413&view=rev
Log:
Fix bitcast to address space cast for coerced load/stores
Coerced load/stores through memory do not take into account potential
address space differences when it c
nemanjai added a comment.
@hubert.reinterpretcast Have your comments been addressed adequately in the
latest version of the patch? Do you have an opinion on adding the test case I
proposed?
Comment at: clang/test/Sema/altivec-generic-overload.c:1
+// RUN: %clang_cc1 %s -tripl
gchatelet added a comment.
Is this good enough to go? @JonasToth
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
Just for clarification (and please add the text to the commit message), this is
actually required by the ABI:
Each element of the result vector is the result of logically right shifting
filcab added a comment.
Sorry to ressurect this review, but I have a few questions:
- What kind of functions fail?
- Are there bugzillas to track these?
- How can a compiler expect to have blacklists for "all" its CFI clients? (I'm
ok with having a default for "most-used, well-known, problematic
Author: abataev
Date: Thu Nov 8 07:47:39 2018
New Revision: 346408
URL: http://llvm.org/viewvc/llvm-project?rev=346408&view=rev
Log:
[OPENMP]Make lambda mapping follow reqs for PTR_AND_OBJ mapping.
The base pointer for the lambda mapping must point to the lambda capture
placement and pointer mus
lebedev.ri added a comment.
It's best to use `clang-tidy/add_new_check.py` tool.
You also need tests, and a note in releasenotes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54262
___
cfe-commits mailing list
cfe-commits@lists.ll
hwright added inline comments.
Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:36
+GetScaleForFactory(llvm::StringRef FactoryName) {
+ static const auto *ScaleMap =
+ new std::unordered_map(
Eugene.Zelenko wrote:
> This will cause memory leaks,
hwright updated this revision to Diff 173166.
hwright marked 4 inline comments as done.
hwright added a comment.
Address reviewer comments
https://reviews.llvm.org/D54246
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/DurationFactoryScaleC
m4tx created this revision.
m4tx added reviewers: alexfh, hokein.
Herald added subscribers: cfe-commits, xazax.hun, mgorny.
Add a bugprone check to clang-tidy that detects the usages of `delete this`.
The warning is shown even when `delete this` is the last line in the method (as
there is no gua
sammccall created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov, kbarton, nemanjai.
based on https://reviews.llvm.org/D54259, with API updates to make everything
build again.
Not ready for review, probably won't become ready in
richardmembarth created this revision.
richardmembarth added reviewers: Anastasia, aaron.ballman.
Herald added a subscriber: cfe-commits.
The current pretty-printer emits OpenCL-style memory spaces specifiers:
__device, __constant, and __shared.
The correct CUDA memory space specifiers are: __dev
hokein created this revision.
Herald added subscribers: cfe-commits, mgrang, xazax.hun.
Only works on StandaloneToolExecutor, crashes happen when running
AllTUsExecutors with multithreads (I believe it is because
ClangTidyContext is not threadsafe).
// Restrict thread to 1.
./bin/clang-tidy -
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this!
Comment at: unittests/clangd/CodeCompleteTests.cpp:2195
+TEST(CompletionTest, ObjectiveCMethodNoArguments) {
+ std::string Context = R"objc(
+
JonasToth added a comment.
> Could you please explain your motivation of catching clang-tidy stdout?
> `--export-fixes` emits everything of `diagnostic` to YAML even the
> `diagnostic` doesn't have fixes. I guess the reason is that you want code
> snippets that you could show to users? If so, I
asavonic added a comment.
Committed in r346392.
Repository:
rC Clang
https://reviews.llvm.org/D51484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346393: clang-cl: Add "/clang:" pass-through arg
support. (authored by hans, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53457
Files:
docs/UsersManual.rst
include/clang/Driver/C
Author: hans
Date: Thu Nov 8 03:27:04 2018
New Revision: 346393
URL: http://llvm.org/viewvc/llvm-project?rev=346393&view=rev
Log:
clang-cl: Add "/clang:" pass-through arg support.
The clang-cl driver disables access to command line options outside of the
"Core" and "CLOption" sets of command lin
Author: asavonic
Date: Thu Nov 8 03:25:41 2018
New Revision: 346392
URL: http://llvm.org/viewvc/llvm-project?rev=346392&view=rev
Log:
[OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension
Summary:
Documentation can be found at
https://www.khronos.org/registry/OpenCL/exten
hans added a comment.
In https://reviews.llvm.org/D53457#1291020, @neerajksingh wrote:
> Reid, Hans, or someone else with commit access. If the revision looks good,
> could you please submit to SVN?
>
> Any particular testing I should run beforehand? I ran the clang tests locally
> on Windows.
asavonic added a comment.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D54253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AlexeySachkov created this revision.
AlexeySachkov added reviewers: Anastasia, asavonic.
Herald added subscribers: arphaman, yaxunl.
The problem here is that test only checks default target. I recently
introduced regression which wasn't detected by local testing: I missed that
some declarations mi
1 - 100 of 106 matches
Mail list logo
