This revision was automatically updated to reflect the committed changes.
Closed by commit rC346069: Add /Zc:DllexportInlines option to clang-cl
(authored by tikuta, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51340?vs=172348&id=172485#toc
Repository:
rC Clang
https:/
Author: tikuta
Date: Fri Nov 2 23:45:00 2018
New Revision: 346069
URL: http://llvm.org/viewvc/llvm-project?rev=346069&view=rev
Log:
Add /Zc:DllexportInlines option to clang-cl
Summary:
This CL adds /Zc:DllexportInlines flag to clang-cl.
When Zc:DllexportInlines- is specified, inline class member
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is eight in a series of patches to move intrinsic definitions out of
intrin.h.
Repository:
rC Clang
https://reviews.llvm.org
jfb added a comment.
In https://reviews.llvm.org/D54055#1286396, @rjmccall wrote:
> That sounds more like this use of the mangler isn't manipulating the function
> type context correctly. But actually I think the problem is that it's
> ridiculous to assume that arbitrary local declarations hav
rjmccall added a comment.
That sounds more like this use of the mangler isn't manipulating the function
type context correctly. But actually I think the problem is that it's
ridiculous to assume that arbitrary local declarations have meaningful
manglings. Why are we calling `getStaticDeclName
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is seventh in a series of patches to move intrinsic definitions out of
intrin.h.
Repository:
rC Clang
https://reviews.llvm.o
MaskRay added inline comments.
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128
if (OnlyLibstdcxxStatic)
- CmdArgs.push_back("-Bstatic");
+ CmdArgs.push_back("-static");
ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
If Fuchsia
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is sixth in a series of patches to move intrinsic definitions out of
intrin.h.
Repository:
rC Clang
https://reviews.llvm.org
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is fifth in a series of patches to move intrinsic defintions out of
intrin.h.
Repository:
rC Clang
https://reviews.llvm.org/
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, cryptoad.
This makes the tests stricter by not only matching the runtime file
name, but the entire path into the resource directory.
Repository:
rC Clang
https://reviews.llvm.org/D54064
Fi
Author: rsmith
Date: Fri Nov 2 19:23:33 2018
New Revision: 346065
URL: http://llvm.org/viewvc/llvm-project?rev=346065&view=rev
Log:
Revert r345562: "PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue
of type"
This exposes a (known) CodeGen bug: it can't cope with emitting lvalue
expre
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346064: [Driver] Use -push-/-pop-state and -as-needed for
libc++ on Fuchsia (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53854?vs=171948&id=172478#toc
Reposit
Author: phosek
Date: Fri Nov 2 18:43:25 2018
New Revision: 346064
URL: http://llvm.org/viewvc/llvm-project?rev=346064&view=rev
Log:
[Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia
This avoids introducing unnecessary DT_NEEDED entries when using
C++ driver for linking C code o
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is fourth in a series of patches to move intrinsic defintions out of
intrin.h.
Repository:
rC Clang
https://reviews.llvm.org
mgrang created this revision.
mgrang added reviewers: rnk, efriedma, mstorsjo, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
This is third in a series of patches to move intrinsic definitions out of
intrin.h.
Repository:
rC Clang
https://reviews.llvm.org
sammccall created this revision.
sammccall added reviewers: hokein, alexfh.
Herald added subscribers: cfe-commits, xazax.hun.
By now the context's SourceManager is now initialized everywhere that
ClangTidyCheck::registerMatcher() is called, so the call from run() seems
entirely redundant, and inde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346056: [CMake][Fuchsia] Set -fuse-ld=lld explicitly for
Linux runtimes (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5
Author: phosek
Date: Fri Nov 2 16:49:36 2018
New Revision: 346056
URL: http://llvm.org/viewvc/llvm-project?rev=346056&view=rev
Log:
[CMake][Fuchsia] Set -fuse-ld=lld explicitly for Linux runtimes
We set lld as the default linker on non-Darwin platforms, but we still
need to set -fuse-ld=lld expl
phosek added a comment.
In https://reviews.llvm.org/D54026#1285754, @mcgrathr wrote:
> So the default is not per-target? It should be.
Agreed, although that'll require non-trivial driver changes.
Repository:
rC Clang
https://reviews.llvm.org/D54026
_
Author: sammccall
Date: Fri Nov 2 16:47:55 2018
New Revision: 346054
URL: http://llvm.org/viewvc/llvm-project?rev=346054&view=rev
Log:
[clangd] don't buffer the input-mirror stream, it's used to diagnose crashes
Modified:
clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
Modified: clang-to
Hi Galina,
I'm sad that they appear to have been abandoned but no objections from me as
I'm not the admin for any of these anymore. A couple of them were taken over by
a colleague when I left but he too has left MIPS since then. Simon Atanasyan
might be able to find the owners if there still ar
Szelethus updated this revision to Diff 172459.
Szelethus marked an inline comment as done.
Szelethus added a comment.
- Fixes according to @xazax.hun's observations
Thanks! I'll commit when I have time watch buildbots.
https://reviews.llvm.org/D52794
Files:
lib/StaticAnalyzer/Core/PlistDiag
jfb added a comment.
In https://reviews.llvm.org/D54055#1286196, @erik.pilkington wrote:
> Can you give an example of some code that triggered this with your patch
> applied? Even if it isn't a real reproducer right now, it would help to try
> to understand whats happening here.
Sure!
I have
erik.pilkington added a comment.
Can you give an example of some code that triggered this with your patch
applied? Even if it isn't a real reproducer right now, it would help to try to
understand whats happening here.
Repository:
rC Clang
https://reviews.llvm.org/D54055
_
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:116
+
+ This check searches for those for loops which has a loop variable with
+ a "too small" type which means this type can't represent all values
Please avoid This check, may be Detects?
jfb added a comment.
I'm not sure this is the right fix because mangling confuses me. It fixes the
assertion I'm encountering in my patch, and I don't think I can create a repro
without the patch (since I'm asking to mangle a local in a way we don't seem to
right now).
Repository:
rC Clang
jfb created this revision.
jfb added a reviewer: rjmccall.
Herald added subscribers: cfe-commits, dexonsmith.
jfb added a comment.
I'm not sure this is the right fix because mangling confuses me. It fixes the
assertion I'm encountering in my patch, and I don't think I can create a repro
without
NoQ added a comment.
In https://reviews.llvm.org/D53856#1285373, @rnkovacs wrote:
> In https://reviews.llvm.org/D53856#1280408, @Szelethus wrote:
>
> > In https://reviews.llvm.org/D53856#1279887, @NoQ wrote:
> >
> > > This might be also covered by @rnkovacs's string buffer escape checker -
> > >
NoQ added a comment.
Ok, so what this code does is, eg., for a call of `i1.operator==(i2)` that
returns a symbol `$x` of type `bool`, it conserves the sacred checker-specific
knowledge that `$x` is in fact equal to `$offset(i1) == $offset(i2)`, where
`$offset(i)` is the offset symbol within `It
Szelethus added a comment.
Oh, and the reason why I think it would add a lot of complication: since only
`ExprEngine` is avaible in the `checkEndAnalysis` callback, which, from what I
can see, doesn't have a handly `isDead` method, so I'm not even sure how I'd
implement it.
https://reviews.ll
Szelethus added a comment.
Sorry for the late reply.
I'm not actually super confident about this idea, I don't think it would add
much value, compared to how complicated it would make things. This patch
reduces report by a significant amount when pointer chasing is enabled, but a
global set mi
Author: adrian
Date: Fri Nov 2 15:19:02 2018
New Revision: 346048
URL: http://llvm.org/viewvc/llvm-project?rev=346048&view=rev
Log:
Add an explicit -std=c++14 to this test.
rdar://problem/45642490
Modified:
cfe/trunk/test/Modules/lsv-debuginfo.cpp
Modified: cfe/trunk/test/Modules/lsv-debug
STL_MSFT added a comment.
Yes, the "real builtin" approach seems to be best. For a recent example,
https://reviews.llvm.org/D49606 added `__shiftright128` as an inline function
in intrin.h, but that didn't work with MSVC's STL when I moved our declaration
of `__shiftright128` from intrin.h to i
ztamas marked 3 inline comments as done.
ztamas added inline comments.
Comment at: test/clang-tidy/bugprone-too-small-loop-variable.cpp:6
+void voidBadForLoop() {
+ for (int i = 0; i < size(); ++i) {
+// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: loop variable has a narrower
ztamas updated this revision to Diff 172436.
ztamas added a comment.
- Use StringRef instead of char[]
- Add test cases about big constant / literal / enum values
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53974
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-ti
Author: mgrang
Date: Fri Nov 2 14:18:23 2018
New Revision: 346044
URL: http://llvm.org/viewvc/llvm-project?rev=346044&view=rev
Log:
[COFF, ARM64] Implement InterlockedExchange*_* builtins
Summary: Windows SDK needs these intrinsics to be proper builtins. This is
second in a series of patches t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346044: [COFF, ARM64] Implement InterlockedExchange*_*
builtins (authored by mgrang, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54046?vs=
david-salinas updated this revision to Diff 172261.
david-salinas added a comment.
As per rjmccall's comments, changed the call to
CreatePointerBitCastOrAddrSpaceCast back to a call to CreateBitCast, but now
we're casting to the int8* with the address space of the target.
https://reviews.llvm.
mattd created this revision.
mattd added reviewers: aaron.ballman, rjmccall.
Previously the TemplateSpecialization instance for 'template_alias', in the
example below, returned the type info of the canonical type (int). This
ignored the type alias if the template type happen to be aliased.
Be
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r346041.
https://reviews.llvm.org/D52421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Fri Nov 2 14:04:44 2018
New Revision: 346041
URL: http://llvm.org/viewvc/llvm-project?rev=346041&view=rev
Log:
Diagnose parameter names that shadow the names of inherited fields under
-Wshadow-field.
This addresses PR34120. Note, unlike GCC, we take into account the
trixirt created this revision.
trixirt added reviewers: rsmith, stephenkelly.
Herald added a subscriber: cfe-commits.
Include-what-you-use crashes when run against llvm because of late use of
TUScope.
The testcase is
https://github.com/trixirt/include-what-you-use/commit/dfec8cf07015fb5fe2db10df
rnk added a subscriber: STL_MSFT.
rnk added a comment.
In https://reviews.llvm.org/D53912#1284804, @azharudd wrote:
> I agree. This currently resolves issues with building for ARM64 target using
> Visual Studio 2017. The missing intrinsics it complains about are already
> present in intrin.h. W
Szelethus added a comment.
In https://reviews.llvm.org/D53974#1283759, @ZaMaZaN4iK wrote:
> Hmm, i thought Clang has some warning for this, but I was wrong... Did you
> think to implement this check as Clang warning?
That is an interesting point actually -- maybe it'd be worth doing that, and
rnk accepted this revision.
rnk added a comment.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D54046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added inline comments.
Comment at: clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp:20
+
+static const char LoopName[] = "forLoopName";
+static const char loopVarName[] = "loopVar";
ztamas wrote:
> JonasToth wrote:
> > Please move these variable in the
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D54046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
ztamas marked 16 inline comments as done.
ztamas added inline comments.
Comment at: clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp:20
+
+static const char LoopName[] = "forLoopName";
+static const char loopVarName[] = "loopVar";
JonasToth wrote:
> Please move
mgrang created this revision.
mgrang added reviewers: rnk, mstorsjo, efriedma, TomTan.
Herald added subscribers: kristina, jfb, chrib, kristof.beyls, javed.absar.
Windows SDK needs these intrinsics to be proper builtins. This is second in a
series of patches to move intrinsic defintions out of i
Hello everyone,
There are few abandoned mips builders on LLVM buildbot:
llvm-mips-linux
clang-cmake-mipsel
clang-cmake-mips
I am going to remove them, if anyone has any objections, please speak up!
Thanks
Galina
___
cfe-commits mailing list
cfe-commi
Appreciate the input from everyone. This is an experimental feature that
isn't hooked up anywhere yet, linux/glibc-only is fine for now. We can
revisit once this code is actually used.
(BTW musl seems to work fine:
https://git.musl-libc.org/cgit/musl/tree/src/thread/pthread_setschedparam.c)
On Fr
ztamas updated this revision to Diff 172422.
ztamas added a comment.
Update code based on reviewer comments:
- Remove const qualifier
- Fix some comments
- Use isInstantiationDependent() method
- Do not ignore macros
- Mark code-constructs in docs
- Handle the use case when both operands of the b
MaskRay added a comment.
I don't even know if this actually does any good. In some libc implementations
`pthread_setschedparam` may be a no-op (e.g. in musl)
Repository:
rL LLVM
https://reviews.llvm.org/D53922
___
cfe-commits mailing list
cfe-co
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initializ
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initialize it i
keryell added a comment.
In https://reviews.llvm.org/D53705#1285096, @rjmccall wrote:
>
> If your plan is to compile code for the CPU with a normal C++ compiler but
> for the GPU with an OpenCL-aware compiler, you are going to have
> significantly divergent behavior between the CPU and GPU
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initializ
juliehockett planned changes to this revision.
juliehockett marked 5 inline comments as done.
juliehockett added a comment.
In https://reviews.llvm.org/D53882#1282219, @aaron.ballman wrote:
> I am a bit confused by what this check is trying to accomplish. It seems like
> this is intended to catc
Author: szelethus
Date: Fri Nov 2 12:48:56 2018
New Revision: 346033
URL: http://llvm.org/viewvc/llvm-project?rev=346033&view=rev
Log:
Attempt to fix 'logical operation on address of string constant'
Caused a lot of warnings for Windows:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-sc
Yes, that's the intent, at least for now.
Fine to eat all your cores, but background indexing isn't higher priority
than anything else.
On Fri, Nov 2, 2018 at 8:35 PM Joerg Sonnenberger wrote:
> On Wed, Oct 31, 2018 at 08:53:03AM +, Sam McCall via Phabricator via
> cfe-commits wrote:
> > sam
On Wed, Oct 31, 2018 at 08:53:03AM +, Sam McCall via Phabricator via
cfe-commits wrote:
> sammccall accepted this revision.
> sammccall added a comment.
> This revision is now accepted and ready to land.
>
> Thanks!
> We should work out what to do on BSD+Mac (and windows at some point), but
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initialize it i
Szelethus added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initializ
NoQ accepted this revision.
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in thi
Szelethus closed this revision.
Szelethus added a comment.
Interesting, I didn't get a mail about this :/ In any case, let's hope no more
problems arise.
Repository:
rL LLVM
https://reviews.llvm.org/D53277
___
cfe-commits mailing list
cfe-commit
Szelethus added a comment.
In https://reviews.llvm.org/D53277#1285777, @george.karpenkov wrote:
> @NoQ @Szelethus Actually pushed a fix.
Just saw this -- Thank you! :D
Repository:
rL LLVM
https://reviews.llvm.org/D53277
___
cfe-commits mailing
Also one of your resent commits added another broken test to the builder:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/13729
. . .
Failing Tests:
. . .
Clang-Unit ::
Frontend/./FrontendTests.exe/FrontendOutputTests.TestOutputStream
. . .
The builder did not s
Author: george.karpenkov
Date: Fri Nov 2 11:28:52 2018
New Revision: 346028
URL: http://llvm.org/viewvc/llvm-project?rev=346028&view=rev
Log:
[analyzer] Fixup of the module build after https://reviews.llvm.org/D53277
Adds AnalyzerOptions.def to the list of textual headers.
Modified:
cfe/tru
george.karpenkov added a comment.
@NoQ @Szelethus Actually pushed a fix.
Repository:
rL LLVM
https://reviews.llvm.org/D53277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov added a comment.
@Szelethus @NoQ OK it seems you need to annotate those headers in modulemap.
E.g. take a look at:
george1@/Volumes/Transcend/code/monorepo/llvm-project/clang (master)≻ rg
SVals.def
include/clang/module.modulemap
131: textual header "StaticAnalyzer/Core/P
astrelni marked an inline comment as done.
astrelni added inline comments.
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:33-36
+ anyOf(hasAncestor(
+functionTemplateDecl(HasMatchingDependentDescendant)),
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346024: [COFF, ARM64] Change setjmp for AArch64 Windows to
use Intrinsic.sponentry (authored by mgrang, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
george.karpenkov added a comment.
@Szelethus you can see the command required to get modules build in the
mentioned log. I think -DLLVM_ENABLE_MODULES=On might be enough.
Repository:
rL LLVM
https://reviews.llvm.org/D53277
___
cfe-commits mailin
Hello Kristof,
It looks like this commit added broken tests to couple of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win
. . .
Clang :: Analysis/analyzer-list-configs.c
P
NoQ added a comment.
Ugh, this breaks builds with //modules//, eg.
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/12074/console
I'm bad with modules, but you might consult my own failure of this kind:
https://reviews.llvm.org/D15448#325856 - especially the
`include/clang/module.modul
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
So the default is not per-target? It should be.
Repository:
rC Clang
https://reviews.llvm.org/D54026
___
cfe-commits mailing list
cfe-com
JonasToth added a comment.
In https://reviews.llvm.org/D53974#1285585, @ztamas wrote:
> Just to make it clear. I think this check is in a good shape now. I mean it
> catches usefull issues and also does not produce too many false positives, as
> I see.
Yes, I did not want to stop the patch or
astrelni updated this revision to Diff 172402.
astrelni added a comment.
Herald added a subscriber: mgrang.
Updated filtering of template instantiations to not use potentially costly
hasDescendent matcher.
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-
mgrang accepted this revision.
mgrang added a comment.
This revision is now accepted and ready to land.
Since this is the same as https://reviews.llvm.org/D53684, we can go ahead and
close this.
Repository:
rC Clang
https://reviews.llvm.org/D53998
_
Author: mgrang
Date: Fri Nov 2 11:10:07 2018
New Revision: 346024
URL: http://llvm.org/viewvc/llvm-project?rev=346024&view=rev
Log:
[COFF, ARM64] Change setjmp for AArch64 Windows to use Intrinsic.sponentry
Summary: ARM64 setjmp expects sp on entry instead of framepointer.
Patch by: Yin Ma (yi.
Author: tstellar
Date: Fri Nov 2 11:09:42 2018
New Revision: 346022
URL: http://llvm.org/viewvc/llvm-project?rev=346022&view=rev
Log:
Creating release candidate rc2 from release_701 branch
Added:
libunwind/tags/RELEASE_701/rc2/ (props changed)
- copied from r346021, libunwind/branche
whisperity added inline comments.
Comment at: docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst:18
+This for loop is an infinite loop because the short type can't represent all
+values in the [0..size] interval.
+
Format the interval as code (monospace)
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346004: [CodeGen] Fix a crash when updating a designated
initializer (authored by epilk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54010?vs=172306&id=172396#toc
Repository:
r
Author: epilk
Date: Fri Nov 2 10:36:58 2018
New Revision: 346004
URL: http://llvm.org/viewvc/llvm-project?rev=346004&view=rev
Log:
[CodeGen] Fix a crash when updating a designated initializer
We need to handle the ConstantAggregateZero case here too.
rdar://45691981
Differential revision: http
filcab added a comment.
Thanks for the review.
Unfortunately, I forgot to edit the commit message. Let's hope no one gets too
confused (phab reviews will be up anyway, so should be easy to figure out).
Filipe
Repository:
rL LLVM
https://reviews.llvm.org/D52615
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346001: Change
-fsanitize-address-poison-class-member-array-new-cookie to -fsanitize…
(authored by filcab, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346001: Change
-fsanitize-address-poison-class-member-array-new-cookie to -fsanitize…
(authored by filcab, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52615?vs=172376&id=172392#t
Author: filcab
Date: Fri Nov 2 10:29:04 2018
New Revision: 346001
URL: http://llvm.org/viewvc/llvm-project?rev=346001&view=rev
Log:
Change -fsanitize-address-poison-class-member-array-new-cookie to
-fsanitize-address-poison-custom-array-cookie
Handle it in the driver and propagate it to cc1
Re
eandrews added a comment.
Thanks!
https://reviews.llvm.org/D52998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Nov 2, 2018 at 12:34 PM Kristof Umann via cfe-commits
wrote:
>
> Author: szelethus
> Date: Fri Nov 2 09:32:15 2018
> New Revision: 345993
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345993&view=rev
> Log:
> Didn't -> didnt, because #errors complains about untermianted '
Why not quot
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D52615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: szelethus
Date: Fri Nov 2 10:00:07 2018
New Revision: 345997
URL: http://llvm.org/viewvc/llvm-project?rev=345997&view=rev
Log:
Remove the duplicated definition of size_t
So hopefully windows won't complain.
Modified:
cfe/trunk/test/Analysis/llvm-conventions.cpp
Modified: cfe/trunk/
ztamas added a comment.
Just to make it clear. I think this check is in a good shape now. I mean it
catches usefull issues and also does not produce too many false positives, as I
see.
So my intention here is to get it in as it is now (of course after I fixed
things reviewers find) and later it
On 2 Nov 2018, at 15:28, Sam McCall wrote:
> In that case, I don't think it makes sense to think of the format string
> parser as part of the analyzer - as the build deps suggest, it's now part of
> AST and gets reused by analyzer. (Similar to how the analyzer uses other bits
> of AST/clang). I
JonasToth closed this revision.
JonasToth added a comment.
Thank you very much for the patch!
Committed in r345995.
Repository:
rL LLVM
https://reviews.llvm.org/D54036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: jonastoth
Date: Fri Nov 2 09:36:21 2018
New Revision: 345995
URL: http://llvm.org/viewvc/llvm-project?rev=345995&view=rev
Log:
[fix][clang-tidy] fix for r345961 that introduced a test failure on Windows
builds
r345961 introduced a path check in
.\tools\clang\tools\extra\test\clang-tidy\
Author: szelethus
Date: Fri Nov 2 09:32:15 2018
New Revision: 345993
URL: http://llvm.org/viewvc/llvm-project?rev=345993&view=rev
Log:
Didn't -> didnt, because #errors complains about untermianted '
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
Modified: cfe/trun
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
The patch is good to go!
Please add the commit reference to `utils/benchmark/README.LLVM`
(https://github.com/google/benchmark/commit/a9b31c51b1ee7ec7b31438c647123c2cbac5d956)
and the pat
Author: maskray
Date: Fri Nov 2 09:23:37 2018
New Revision: 345992
URL: http://llvm.org/viewvc/llvm-project?rev=345992&view=rev
Log:
[analyzer] Fix diagnostics/explicit-suppression.cpp
*OI++ = *II++ is on line 670, not 668
Modified:
cfe/trunk/test/Analysis/diagnostics/explicit-suppression.c
Author: abataev
Date: Fri Nov 2 09:08:31 2018
New Revision: 345991
URL: http://llvm.org/viewvc/llvm-project?rev=345991&view=rev
Log:
[OPENMP][NVPTX]Use __kmpc_data_sharing_coalesced_push_stack function.
Coalesced memory access requires use of the new function
`__kmpc_data_sharing_coalesced_push_
1 - 100 of 177 matches
Mail list logo
