Author: ahatanak
Date: Fri Oct 19 22:45:01 2018
New Revision: 344833
URL: http://llvm.org/viewvc/llvm-project?rev=344833&view=rev
Log:
[CodeGen] Use the mangle context owned by CodeGenModule to correctly
mangle types of lambda objects captured by a block instead of creating a
new mangle context ev
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Haha, fun!
Repository:
rC Clang
https://reviews.llvm.org/D53456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: ctopper
Date: Fri Oct 19 20:51:52 2018
New Revision: 344832
URL: http://llvm.org/viewvc/llvm-project?rev=344832&view=rev
Log:
[X86] Add support for more than 32 features for __builtin_cpu_is
libgcc supports more than 32 features by adding a new 32-bit variable
__cpu_features2.
This adds
BillyONeal closed this revision.
BillyONeal added a comment.
Thank you! :D
Committed r344829
https://reviews.llvm.org/D53466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Looks fine to me
https://reviews.llvm.org/D53466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
hwright added a comment.
Ping.
What are the next steps here?
https://reviews.llvm.org/D53339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
BillyONeal abandoned this revision.
BillyONeal added a comment.
Actually this doesn't work -- because we /FI this thing, this file is included
before the test gets to say _LIBCPP_ENABLE_DEPRECATION_WARNINGS.
https://reviews.llvm.org/D53468
___
cfe-
hubert.reinterpretcast added inline comments.
Comment at: clang/test/Sema/altivec-generic-overload.c:3
+
+typedef signed char __v4sc __attribute__((__vector_size__(16)));
+typedef unsigned char __v4uc __attribute__((__vector_size__(16)));
wuzish wrote:
> hubert.r
Author: rtrieu
Date: Fri Oct 19 19:15:58 2018
New Revision: 344828
URL: http://llvm.org/viewvc/llvm-project?rev=344828&view=rev
Log:
Make -Wfor-loop-analysis work with C++17
For now, disable the "variable in loop condition not modified" warning to not
be emitted when there is a structured binding
Author: ahatanak
Date: Fri Oct 19 19:11:45 2018
New Revision: 344827
URL: http://llvm.org/viewvc/llvm-project?rev=344827&view=rev
Log:
Disable unittests/clangd/JSONTransportTests.cpp on versions of macosx
earlier than 10.13.
rdar://problem/45310173
Modified:
clang-tools-extra/trunk/unittests
wuzish added inline comments.
Comment at: clang/test/Sema/altivec-generic-overload.c:3
+
+typedef signed char __v4sc __attribute__((__vector_size__(16)));
+typedef unsigned char __v4uc __attribute__((__vector_size__(16)));
hubert.reinterpretcast wrote:
> `__v4sc`
hubert.reinterpretcast requested changes to this revision.
hubert.reinterpretcast added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Sema/SemaOverload.cpp:3920
+
+ // Prefer a compatible vector conversion to lax vector conversion
+ // Fo
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
https://reviews.llvm.org/D53468
Files:
test/support/msvc_stdlib_force_include.hpp
Index: test/support/msvc_stdlib_force_include.hpp
===
--- test/s
NoQ accepted this revision.
NoQ added a comment.
I'll use this.
And i think it's unfair to give users -analyzer-config and not give them a list
of options. Users should be able to discover either both or none of the two. If
a user goes far enough to start digging into non-driver options, such u
NoQ added a comment.
Herald added a subscriber: dkrupp.
I guess we should consider the idea in
http://lists.llvm.org/pipermail/cfe-dev/2018-October/059864.html
Comment at: lib/Frontend/CompilerInvocation.cpp:343
}
+ // Check whether this really is a valid -analyzer
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I think this is awesome o_o
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:70-71
+
+/// Controls the high-level analyzer mode, which influences the default
+///
BillyONeal updated this revision to Diff 170294.
BillyONeal added a comment.
Also fixed cstdlib tests.
https://reviews.llvm.org/D53466
Files:
test/std/depr/depr.c.headers/stdlib_h.pass.cpp
test/std/language.support/support.runtime/cstdlib.pass.cpp
Index: test/std/language.support/support.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344824: [X86] When checking the bits in cpu_features for
function multiversioning… (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
BillyONeal created this revision.
BillyONeal added reviewers: EricWF, mclow.lists.
The test is trying to avoid saying aligned_alloc on Windows' UCRT, which does
not (and can not) implement aligned_alloc. However, it's testing for c1xx,
meaning clang on Windows will fail this test when using the
Author: ctopper
Date: Fri Oct 19 18:30:00 2018
New Revision: 344824
URL: http://llvm.org/viewvc/llvm-project?rev=344824&view=rev
Log:
[X86] When checking the bits in cpu_features for function multiversioning
dispatcher in the resolver, make sure all the required bits are set. Not just
one of the
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: dkrupp.
Thanks! Let's commit.
https://reviews.llvm.org/D53274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
NoQ added a reviewer: dcoughlin.
NoQ added inline comments.
Herald added a subscriber: dkrupp.
Comment at: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp:1401-1402
checker->IsAggressive =
- mgr.getAnalyzerOptions().getBooleanOption("AggressiveReport", false);
+
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
Please remove the reference to b/X in the commit message. LLVM doesn't allow
internal bug numbers, and you described the issue well enough without it.
Repository:
rC Clang
https://review
NoQ accepted this revision.
NoQ added a comment.
I guess maybe let's skip stuff without examples and leave Objective-C
descriptions waiting on us?
Comment at: www/analyzer/available_checks.html:483
+
+LLVM Checkers
Wow, i never noticed this one. It seems to
NoQ closed this revision.
NoQ added a comment.
Herald added subscribers: dkrupp, donat.nagy.
I committed both patches as https://reviews.llvm.org/rC344823 but it seems that
Phabricator doesn't pick up closing multiple revisions with the same commit, so
closing manually.
Also thanks!~
Reposito
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344823: [analyzer] Be more plugin-friendly by moving static
locals into .cpp files. (authored by dergachev, committed by ).
Herald added subscribers: llvm-commits, dkrupp, donat.nagy.
Changed prior to com
Author: dergachev
Date: Fri Oct 19 17:29:24 2018
New Revision: 344823
URL: http://llvm.org/viewvc/llvm-project?rev=344823&view=rev
Log:
[analyzer] Be more plugin-friendly by moving static locals into .cpp files.
The GDMIndex functions return a pointer that's used as a key for looking up
data, but
NoQ added a comment.
Hmm, i guess i sent this out too early.
As per our long-lasting tradition, i forgot the point about the web page :\
Bullets about RUN-lines, Checkers.td descriptions and CMakeLists are also great
for everyday use :)
https://reviews.llvm.org/D52984
_
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2871
+ auto *DI = CGF.getDebugInfo();
+ SourceLocation Loc = DI ? DI->getLocation() : SourceLocation();
+ auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc);
aprantl wrote:
> vsk wrote:
nickdesaulniers created this revision.
nickdesaulniers added reviewers: srhines, pirama, danalbert.
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar.
Partial revert of r330873 ('[Driver] Reland "Android triples are not
aliases for other triples."')
While we don't want `-target aa
NoQ added a comment.
My take on the out-of-alpha checklist:
- The checker should be evaluated on a large codebase in order to discover
crashes and false positives specific to the checker. It should demonstrate the
expected reasonably good results on it, with the stress on having as little
fals
aprantl added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2871
+ auto *DI = CGF.getDebugInfo();
+ SourceLocation Loc = DI ? DI->getLocation() : SourceLocation();
+ auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc);
vsk wrote:
> Why should
vsk added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2871
+ auto *DI = CGF.getDebugInfo();
+ SourceLocation Loc = DI ? DI->getLocation() : SourceLocation();
+ auto DL = ApplyDebugLocation::CreateDefaultArtificial(CGF, Loc);
Why shouldn't this always b
dblaikie added a comment.
@aprantl - yeah, not sure I have any big feels about this (nor do I fully
understand it)
@yonghong-song - could you explain this maybe in a bit more detail. What
behavior does this fix provide? (compared to behavior of existing working cases
that don't hit this bug, f
bobsayshilol updated this revision to Diff 170277.
bobsayshilol retitled this revision from "[CodeGen] Fix places where the return
type of a FunctionDecl was being used in place of the function type" to "Fix
places where the return type of a FunctionDecl was being used in place of the
function t
BillyONeal closed this revision.
BillyONeal added a comment.
Committed r344821
https://reviews.llvm.org/D50551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
BillyONeal closed this revision.
BillyONeal added a comment.
Committed r344820
https://reviews.llvm.org/D50549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper created this revision.
craig.topper added reviewers: erichkeane, echristo.
The multiversioning code repurposed the code from __builtin_cpu_supports for
checking if a single feature is enabled. That code essentially performed
(_cpu_features & (1 << C)) != 0. But with the multiversion
aprantl created this revision.
aprantl added a reviewer: vsk.
Function calls without a !dbg location inside a function that has a
DISubprogram make it impossible to construct inline information and are
rejected by the verifier. This patch ensures that sanitizer check function
calls have a !dbg
hans added a comment.
I haven't started looking at the code yet.
I'm not completely convinced that we want this. So far we've used the strategy
of promoting clang options that are also useful in clang-cl to core options,
and if someone wants to use more clang than that, maybe clang-cl isn't the
ilya-biryukov added a comment.
In https://reviews.llvm.org/D53347#1267216, @kadircet wrote:
> LGTM, it bugs me that some part in the documentation says it doesn't go
> through decltype(`This looks through declarators like pointer types, but not
> through decltype or typedefs`) but since tests c
rsmith added inline comments.
Comment at: lib/AST/DeclBase.cpp:1704-1705
+
+ // In C, the redeclaration context for enumerators is the translation unit,
+ // so we skip through transparent contexts as well as struct/union contexts.
+ bool SkipRecords = getDeclKind() == Decl::K
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
(Looks fine with a suitably-adjusted comment.)
https://reviews.llvm.org/D52384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
On Fri, Oct 19, 2018 at 3:56 PM Adrian Prantl via Phabricator via
llvm-commits wrote:
> aprantl added a comment.
>
> I have a vague recollection that this column info hack was added to
> disambiguate two types defined on the same line (which is something that
> happened more often than one would
ilya-biryukov updated this revision to Diff 170273.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53347
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Inde
aprantl added a comment.
RTTI?
Repository:
rC Clang
https://reviews.llvm.org/D38061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added a comment.
Oh wait, this patch is just for dumping the ASTs? Can you elaborate why this
makes it into a binary then?
Repository:
rC Clang
https://reviews.llvm.org/D38061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
aprantl added a comment.
I have a vague recollection that this column info hack was added to
disambiguate two types defined on the same line (which is something that
happened more often than one would think because of macro expansion). Did you
do the git archeology to ensure that the original
rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:711
+
+ /// Evaluate as a constant expression, as per C++11-and-later constexpr
+ /// rules. Stop if we find that the expression is not a constant
jyknight wrote:
> rsmith wrote:
>
neerajksingh created this revision.
neerajksingh added reviewers: rnk, hans.
The clang-cl driver disables access to command line options outside of the
"Core" and "CLOption" sets of command line arguments. This filtering makes it
impossible to pass arguments that are interpreted by the clang drive
oleg.smolsky updated this revision to Diff 170270.
oleg.smolsky added a comment.
Generalized the patch so that it deals with lambda args irrespective of bin
packing. Added additional tests and patched existing ones.
Repository:
rC Clang
https://reviews.llvm.org/D52676
Files:
lib/Format/Co
ilya-biryukov created this revision.
ilya-biryukov added reviewers: ioeric, sammccall.
Herald added a subscriber: arphaman.
Without the function body, we cannot determine is parameter was used.
Repository:
rC Clang
https://reviews.llvm.org/D53456
Files:
lib/Sema/SemaDecl.cpp
test/Index/s
oleg.smolsky added a comment.
In https://reviews.llvm.org/D52676#1268806, @djasper wrote:
> In https://reviews.llvm.org/D52676#1268748, @oleg.smolsky wrote:
>
> > In https://reviews.llvm.org/D52676#1268706, @djasper wrote:
> >
> > > Ok, I think I agree with both of you to a certain extent, but I
echristo added a reviewer: aprantl.
echristo added a comment.
I think Adrian has looked at this more recently than I have. Adding him here.
Repository:
rC Clang
https://reviews.llvm.org/D38061
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:163
+
+switch (FloatingSize) {
+ case 64:
Continuing the float semantics discussion on the new revision - Did you
consider `llvm::APFloat`? (http://llvm.org/doxygen
vmiklos added a comment.
In practice cppunit's `CPPUNIT_TEST_SUITE_END` macro triggers this problem.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
vmiklos created this revision.
vmiklos added reviewers: alexfh, sbenza.
Herald added subscribers: cfe-commits, xazax.hun.
And also enable it by default to be consistent with e.g. modernize-use-using.
This helps e.g. when running this check on client code where the macro is
provided by the
ilya-biryukov added a comment.
Since we're showing the diagnostics in the editors anyway, how crucial do we
think it is to actually add that to the procotol?
Having more concrete reasons for misbehaving completions sounds more useful,
though, e.g. "cannot complete members of the incomplete type"
NoQ added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:515
+ continue;
+const auto *FirstAccess = Accesses[0].getNodeAs("access");
+
I feel that it's a good practice to `assert(FirstAccess)`
hubert.reinterpretcast added inline comments.
Comment at: clang/test/Sema/altivec-generic-overload.c:3
+
+typedef signed char __v4sc __attribute__((__vector_size__(16)));
+typedef unsigned char __v4uc __attribute__((__vector_size__(16)));
`__v4sc` is suspicious.
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Code looks good to me, but I'd wait for @george.karpenkov because it was his
idea.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:502
gtbercea updated this revision to Diff 170241.
gtbercea added a comment.
Rebase.
Repository:
rC Clang
https://reviews.llvm.org/D53448
Files:
include/clang/AST/StmtOpenMP.h
include/clang/Basic/OpenMPKinds.h
lib/AST/StmtOpenMP.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenM
gtbercea created this revision.
gtbercea added reviewers: ABataev, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
This patch adds a new code generation path for bound sharing directives
containing distribute parallel for. The new code generation scheme applies to
chunked
Author: danalbert
Date: Fri Oct 19 12:23:01 2018
New Revision: 344806
URL: http://llvm.org/viewvc/llvm-project?rev=344806&view=rev
Log:
Revert "[Driver] Reland: Default Android toolchains to libc++."
This reverts commit 84677d5009d613232d360fda27e6e41fb5cb6700.
Modified:
cfe/trunk/lib/Driver
gtbercea updated this revision to Diff 170238.
gtbercea added a comment.
Refactor.
Repository:
rOMP OpenMP
https://reviews.llvm.org/D53141
Files:
libomptarget/deviceRTLs/nvptx/src/data_sharing.cu
libomptarget/deviceRTLs/nvptx/src/interface.h
libomptarget/deviceRTLs/nvptx/src/omptarge
gtbercea updated this revision to Diff 170237.
gtbercea added a comment.
Refactor.
Repository:
rC Clang
https://reviews.llvm.org/D53443
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
==
gtbercea updated this revision to Diff 170236.
gtbercea added a comment.
Herald added subscribers: cfe-commits, jholewinski.
Refactor.
Repository:
rC Clang
https://reviews.llvm.org/D53141
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Index: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
==
Author: rsmith
Date: Fri Oct 19 12:01:34 2018
New Revision: 344801
URL: http://llvm.org/viewvc/llvm-project?rev=344801&view=rev
Log:
PR24164, PR39336: init-captures are not distinct full-expressions.
Rather, they are subexpressions of the enclosing lambda-expression, and
any temporaries in them a
Author: rsmith
Date: Fri Oct 19 12:01:31 2018
New Revision: 344800
URL: http://llvm.org/viewvc/llvm-project?rev=344800&view=rev
Log:
Add basic test that we perform lifetime extension in the expected
situations.
Added:
cfe/trunk/test/CXX/special/class.temporary/p6.cpp
Added: cfe/trunk/test/CX
Anastasia added inline comments.
Comment at: lib/Headers/opencl-c.h:16197
+#ifdef cl_intel_device_side_avc_motion_estimation
+#pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : enable
+
Anastasia wrote:
> Should we be using:
> #pragma OPENCL
rsmith added a comment.
In https://reviews.llvm.org/D52301#1267163, @kadircet wrote:
> So in the middle of the patch we were just trying to figure out whether we
> are going to break a big assumption that lots of different components relied
> on but just didn't had any tests for. Maybe @rsmith
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.h:350
void getDefaultScheduleAndChunk(CodeGenFunction &CGF,
- const OMPLoopDirective &S, OpenMPScheduleClauseKind &ScheduleKind,
+ const OMPLoopDirective &S, OpenMPScheduleTy &ScheduleKind,
dblaikie added a comment.
Don't know enough about the code to have an opinion on the fix - but in any
case this would need a test case, if possible
Repository:
rC Clang
https://reviews.llvm.org/D53334
___
cfe-commits mailing list
cfe-commits@lis
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D51402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
dblaikie added a comment.
@echristo
> As far as the standard text here, IMO it was just there in case people didn't
> have an objcopy around or don't want to split it. I'm not sure why we would
> want the ability.
I think others have mentioned - but with distributed build it might be easier
t
Author: danalbert
Date: Fri Oct 19 11:06:02 2018
New Revision: 344795
URL: http://llvm.org/viewvc/llvm-project?rev=344795&view=rev
Log:
[Driver] Reland: Default Android toolchains to libc++.
The sanitizer builder that was broken by this should now be fixed.
Original review was https://reviews.ll
Anastasia accepted this revision.
Anastasia added inline comments.
This revision is now accepted and ready to land.
Comment at: test/Headers/opencl-pragma-extension-begin.cl:1
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
I think the tests in this folder are for standa
gtbercea created this revision.
gtbercea added reviewers: ABataev, caomhin.
Herald added subscribers: cfe-commits, guansong, jholewinski.
This patch enables the choosing of the default schedule for parallel for loops
even in non-SPMD cases.
Repository:
rC Clang
https://reviews.llvm.org/D5344
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D52654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
kadircet updated this revision to Diff 170215.
kadircet added a comment.
- Keep only relavant changes and rebase
Repository:
rC Clang
https://reviews.llvm.org/D52301
Files:
include/clang/AST/PrettyPrinter.h
include/clang/Sema/Sema.h
lib/AST/TypePrinter.cpp
lib/Frontend/ASTConsumers.c
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
LGTM, thanks!
Would be super-nice if didn't have to rewrite this in code completion
Repository:
rC Clang
https://reviews.llvm.org/D53369
___
cfe-commits mailing list
cfe-commits
lantictac created this revision.
lantictac added a reviewer: rsmith.
lantictac added a project: clang.
MicrosoftExt allows explicit constructor calls. Prevent lookup of constructor
name unless the name has explicit scope.
This avoids a compile-time crash due to confusing a member access for a
co
ilya-biryukov added a comment.
A few more comments, mostly marking places of unintentional changes that we
need to revert.
Hope it's not going past the point where the number of comments are not useful.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8616
"use of %se
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344789: Java annotation declaration being handled correctly
(authored by hans, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53434?vs=170197
Author: hans
Date: Fri Oct 19 09:19:52 2018
New Revision: 344789
URL: http://llvm.org/viewvc/llvm-project?rev=344789&view=rev
Log:
Java annotation declaration being handled correctly
Previously, Java annotation declarations (@interface AnnotationName) were being
handled as ObjC interfaces. This c
sammccall added a comment.
Nice savings!
My initial thought is that it seems weird to only do it for this one string -
the readers look different, the serialization code has different logic etc for
the different flavors of strings.
The struct certainly looks nicer to my eyes.
This may be the r
sammccall created this revision.
sammccall added reviewers: ioeric, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
The CDB implementations used in open-source code are fast, and our private
slow CDB will soon do the relevant caching itself.
Simplifying
twoh updated this revision to Diff 170205.
twoh added a comment.
Remove conflict line.
Repository:
rC Clang
https://reviews.llvm.org/D34796
Files:
docs/ClangCommandLineReference.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
twoh added a comment.
@joerg Sorry but I'm not sure if I understand your question. This doesn't
pretend to honor source code order, but makes linker to place "hot" functions
under .text.hot section (There's no guarantee of ordering between functions
inside .hot.text section) while "cold" functi
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks for the fix! Do you happen to know what had regressed this?
Repository:
rC Clang
https://reviews.llvm.org/D53434
___
cfe-commits mailin
Author: sammccall
Date: Fri Oct 19 08:42:23 2018
New Revision: 344787
URL: http://llvm.org/viewvc/llvm-project?rev=344787&view=rev
Log:
[clangd] Set workspace root when initializing ClangdServer, disallow mutation.
Summary:
Rename instance variable to WorkspaceRoot to match what we call it intern
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344787: [clangd] Set workspace root when initializing
ClangdServer, disallow mutation. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53404?vs=170098&id=170
Author: kparzysz
Date: Fri Oct 19 08:36:45 2018
New Revision: 344786
URL: http://llvm.org/viewvc/llvm-project?rev=344786&view=rev
Log:
[Hexagon] Remove support for V4
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/lib/Basic/T
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344785: [clang-tidy] Resolve readability-else-after-return
false positive for constexpr… (authored by mkurdej, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53372?vs=170152&id=170
Author: mkurdej
Date: Fri Oct 19 08:26:17 2018
New Revision: 344785
URL: http://llvm.org/viewvc/llvm-project?rev=344785&view=rev
Log:
[clang-tidy] Resolve readability-else-after-return false positive for constexpr
if.
Summary:
It fixes the false positive when using constexpr if and where else ca
sammccall added inline comments.
Comment at: clangd/index/FileIndex.cpp:167
+}
+// FIXME: aggregate symbol reference count based on references.
+for (const auto &Sym : FileSyms.getValue()->Refs) {
This is a good FIXME to carry over to FileSymbols::bui
Author: balazske
Date: Fri Oct 19 08:16:51 2018
New Revision: 344784
URL: http://llvm.org/viewvc/llvm-project?rev=344784&view=rev
Log:
[ASTImporter] Removed uneeded default case label.
Modified:
cfe/trunk/lib/AST/ASTImporter.cpp
Modified: cfe/trunk/lib/AST/ASTImporter.cpp
URL:
http://llvm.o
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3908
+ QualType ToType) {
+assert(FromType->isVectorType() && "FromType should be a vector type");
+assert(ToType->isVectorType() &&
SamMaier created this revision.
Herald added a subscriber: cfe-commits.
Previously, Java annotation declarations (`@interface AnnotationName`) were
being handled as ObjC interfaces. This caused the brace formatting to mess up,
so that when you had a class with an interface defined in it, it woul
1 - 100 of 130 matches
Mail list logo
